[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=354004

--- Comment #3 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76436.
cblack added a comment.


  Recolour text with titlebar colour

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76435=76436

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze
Cc: ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Could we draw the line in the window decoration theme then? Could it 
communicate in some way with the widgets theme to know what's beneath it?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze
Cc: ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#618083 , @ngraham wrote:
  
  > In terms of the appearance for windows without a menubar or toolbar (e.g. 
system settings) I think the latest mockups has a horizontal line below the 
titlebar itself, so that should be added here.
  
  
  That would be impractical if not impossible to do, as the lack of widgets 
making up a tools area means nothing to draw a line on. The only thing that's 
always present with a top border is the window itself, and drawing directly to 
it is a no.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze
Cc: ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Nice!
  
  Obviously this needs to be paired with appropriate changes to the default 
Breeze color scheme to replicate the desired look in T10201 
 :) Here's a quick-and-dirty version of the 
Breeze Evolved color scheme: {F8132321  
(note VERY quick-and-dirty, not to be taken literally). Since the color scheme 
is shipped in the same repo, maybe we should polish it up and add it to this 
patch, or do it in another patch and make it a dependency.
  
  Also we'll need QQC2-desktop-style and maybe Kirigami patches to make sure 
that the toolbars in QML apps adjust appropriately as well.
  
  In terms of the appearance for windows without a menubar or toolbar (e.g. 
system settings) I think the latest mockups has a horizontal line below the 
titlebar itself, so that should be added here.
  
  Finally, it might be nice to color the icons and UI elements in the Tools 
Area with the Active Titlebar Text color to ensure compatibility with all color 
schemes. This color is specifically made to have adequate contrast with the 
titlebar color, which is now used for the Tools Area. Otherwise it won't work 
with color schemed that have a dark titlebar color and a dark text color (like 
the current Breeze does).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze
Cc: ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27667: Align wallpaper dialog to bottom

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  anchor-thumbnail-to-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27667

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76435.
cblack added a comment.


  Relocate painter restore

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76434=76435

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze
Cc: manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  There is now a tools area.

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze
Cc: manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Plasma 5.18.2

[Jonathan Riddell]

Plasma 5.18.2 is now released
https://www.kde.org/announcements/plasma-5.18.2.php

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> kdeplatformdependent.cpp:165
> +// directly requests the accounts kcm to start adding a new account if 
> it's not there, maybe even pre-fills the fields...)
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("KCModule"), 
> QStringLiteral("Library == 'kcm_kaccounts'"));
> +// If we failed to get the kcm, tell the caller we failed

This sounds like a use case for KCMultiDialog, like e.g. in 
https://invent.kde.org/kde/kdeconnect-kde/-/blob/master/settings/main.cpp

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25961

To: leinir
Cc: nicolasfella, apol, zachus, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D27636: Remove redundant match for mountpoints

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0acbfba3b0e4: Remove redundant match for mountpoints 
(authored by bruns).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27636?vs=76333=76432

REVISION DETAIL
  https://phabricator.kde.org/D27636

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp

To: bruns, #baloo, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27667: Align wallpaper dialog to bottom

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Align wallpaper dialog to bottom instead of vertically centering it between 
the theme info and the bottom of the frame.
  
  BUG: 418173
  FIXED-IN: 5.19

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  anchor-thumbnail-to-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27667

AFFECTED FILES
  src/ui/themeconfig.ui

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27666: Support WPA3-SAE in the applet popup

[hexchain]

hexchain updated this revision to Diff 76430.
hexchain added a comment.


  Remove accidental new empty line

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27666?vs=76429=76430

BRANCH
  plasma-nm-support-sae (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27666

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  libs/declarative/enums.h
  libs/handler.cpp
  libs/uiutils.cpp

To: hexchain, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27666: Support WPA3-SAE in the applet popup

[hexchain]

hexchain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
hexchain requested review of this revision.

REVISION SUMMARY
  Add support for WPA3-SAE in the applet popup:
  
  - The "Security type" field in the connection detail correctly shows WPA3-SAE
  
  - Support QR code generation for WPA3-SAE connections
  
  Depends on D27665 

TEST PLAN
  1. Apply D27665 
  
  2. Connect to a WPA3-SAE network and see the "Security type" field in Details
  
  3. Right click on the active connection and choose "Show network's QR code"

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  plasma-nm-support-sae (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27666

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  libs/declarative/enums.h
  libs/handler.cpp
  libs/uiutils.cpp

To: hexchain, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27664: Improve layout and appearance of app details view

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  After porting to FormLayout in D27183 , 
the layout can now be so wide due to the URLs
  that it switches to the compact/mobile view. This patch re-arranges things a 
bit and
  uses human-readable strings for the links instead of showing raw URLs. For 
safety,
  this requires D27663  to be implemented 
first.
  
  BUG: 418019
  FIXED-IN: 5.19.0
  Depends on D27663 

TEST PLAN
  Before: normal-sized window (shows the compact/mobile view): F8131970: 
Before.png 
  
  Before wide window: F8131971: Before 2.png 

  
  After: normal-sized or wide window: F8131972: After.png 


REPOSITORY
  R134 Discover Software Store

BRANCH
  clean-up-app-details (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27664

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27663: Show tooltip with full URL for URL button with overridden text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Kirigami, mart, apol.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Normally the `URLButton` shows the full URL in its text. However if this text 
is overridden
  to anything else, then the user can't know where the URL points, which may be 
worrisome,
  and could be abused by malicious applications to obscure a hostile URL.
  
  This patch implements a tooltip shat shows the full URL when the `text` 
property has been
  overridden and no longer shows the real URL.

TEST PLAN
  F8131965: vokoscreenNG-2020-02-25_14-35-45.mp4 


REPOSITORY
  R169 Kirigami

BRANCH
  conditionally-show-tooltip-on-url-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27663

AFFECTED FILES
  src/controls/LinkButton.qml
  src/controls/UrlButton.qml

To: ngraham, #vdg, #kirigami, mart, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27643: FileChooser: download remote files to a cache location to open them through the portal

[Alexander Saoutkin]

feverfew added a comment.


  With a brief look the ideal scenario is to be able to use 
`DesktopExecParser::resultingArguments`, or a class that calls it `KRun`. That 
should do the conversion. I'm just not sure if you have the information 
required to use it.
  
  See D23384 

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27643

To: jgrulich, aacid, feverfew, fvogt
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Nathaniel Graham]

ngraham added a comment.


  You're right, it does work for GTK2 apps on my system, but not GTK3 apps. :/
  
  BAH I say!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Lionel Chauvin]

chauvin added a comment.


  In D27380#617927 , @ngraham wrote:
  
  > All fonts tested. :(
  
  
  Thunderbird is a gtk3 application ?
  
  If I manually change .gtkrc-2.0 with this line:
  
gtk-font-name="Ubuntu, Italic 9"
  
  Gimp and Inskape display an italic font on my machine.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Nathaniel Graham]

ngraham added a comment.


  BAH!
  
  So what kind of font styles do work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27661: wireguard: Trim IP list before submitting to NM

[hexchain]

hexchain updated this revision to Diff 76418.
hexchain edited the summary of this revision.
hexchain edited the test plan for this revision.
hexchain added a comment.


  Edited summary according to guidelines

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27661?vs=76417=76418

BRANCH
  arcpatch-D27661

REVISION DETAIL
  https://phabricator.kde.org/D27661

AFFECTED FILES
  libs/editor/settings/wireguardpeerwidget.cpp

To: hexchain, jgrulich
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

gikari added a comment.


  In D27380#617927 , @ngraham wrote:
  
  > All fonts tested. :(
  
  
  Hm, I can't get it work too. On GNOME via tweaks Italic fonts also do not 
work, so I guess it is a GTK bug.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Nathaniel Graham]

ngraham added a comment.


  All fonts tested. :(

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27661: wireguard: Trim IP list before submitting to NM

[hexchain]

hexchain updated this revision to Diff 76417.
hexchain added a comment.


  Updated according to comments.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27661?vs=76414=76417

REVISION DETAIL
  https://phabricator.kde.org/D27661

AFFECTED FILES
  libs/editor/settings/wireguardpeerwidget.cpp

To: hexchain, jgrulich
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27661: wireguard: Trim IP list before submitting to NM

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> wireguardpeerwidget.cpp:197
> +
> +for (QString  : rawIPList) {
> +ipList.append(ip.trimmed());

const

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27661

To: hexchain, jgrulich
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

gikari added a comment.


  In D27380#617774 , @ngraham wrote:
  
  > Thanks.
  >
  > So if I set the general font to 9pt Ubuntu Italic, then in the config file 
I see `gtk-font-name=Ubuntu, Italic 9` and Thunderbird respects the font, and 
the size, but not the style; it's not italic. :(
  >
  > Or is that a separate issue?
  
  
  Does the Italicness only not work with Ubuntu font?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27661: wireguard: Trim IP list before submitting to NM

[hexchain]

hexchain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
hexchain requested review of this revision.

REVISION SUMMARY
  The `SimpleIpListValidator` validates each trimmed item in a comma-separated 
list, but `WireGuardPeerWidget` sets `peerData` without trimming each item. 
Untrimmed items are not accepted by NetworkManager, so the user might see NM 
rejecting values that are valid in the peer settings dialog.
  
  Fix this discrepancy by trimming each item before setting `peerData`.

TEST PLAN
  1. Type a comma-separated list of IP addresses, with spaces around comma, 
into the "Allowed IPs" field of the WireGuard peer settings dialog.
  2. Save the connection. No error should be reported by NM.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27661

AFFECTED FILES
  libs/editor/settings/wireguardpeerwidget.cpp

To: hexchain, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[George Vogiatzis]

gvgeo added a comment.


  Don't see anyone objecting, will commit later.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  FreeThePort3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: breeze-gtk now in invent

[Ben Cooksley]

On Wed, 26 Feb 2020, 1:50 AM Jonathan Riddell,  wrote:

> breeze-gtk seems to have moved to invent for development.
>
> Looking through the list on invent I don't see any other Plasma projects
> there.
>
> That's cool but it's useful to know when and why moves like this happens
> as it needs changes to my release scrips and others will get a surprise
> when they want to make contributions to it.
>

Please note that I subscribed both yourself and Bhushan to the ticket
requesting that move, where I asked you to confirm this was okay.

You never responded to this, but he confirmed it would be okay and would
not cause any issues.


> Jonathan
>
>
Regards,
Ben

D26934: KCM/Autostart Add a model to separate logic from UI

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> autostart.cpp:87
>  
> +setMinimumHeight(300);
> +setMinimumWidth(400);

Unrelated right? Where do this come from?

> autostart.cpp:112
>  
> -void Autostart::addItem( DesktopStartItem* item, const QString& name, const 
> QString& run, const QString& command, bool disabled )
> +void Autostart::setDesktopStartItem( DesktopStartItem* item, const QString 
> , const QString , bool disabled, const QString )
>  {

Please remove the space after (, and space should be before * not after

Shouldn't that be called "updateDesktopStartItem" or similar? It's not setting 
anything on "this" after all, but changing the state of the item.

> autostart.cpp:183
>  {
>  AddScriptDialog * addDialog = new AddScriptDialog(this);
> +if (addDialog->exec() != QDialog::Accepted) {

It'd be better to have this dialog on the stack, or reachable via a pointer 
available between calls to this slot. Currently it'd instantiate a new dialog 
each time this slot is invoked and it'd never be freed until the KCModule 
itself is freed.

> autostart.cpp:243
> +QTreeWidgetItem *item = m_scriptItem->child(topLeft.row() - 
> m_programItem->childCount());
> +ScriptStartItem *scriptEntry = dynamic_cast( item 
> );
> +setScriptStartItem(scriptEntry, name, command, source, fileName);

qobject_cast is deemed faster (since it turns out those items inherit from 
QObject which gives me the creeps somehow)

> autostart.cpp:250
> +QTreeWidgetItem *item = m_programItem->child(topLeft.row());
> +DesktopStartItem *desktopItem = dynamic_cast( 
> item );
> +setDesktopStartItem(desktopItem, name, command, !enabled, fileName);

ditto

> autostart.cpp:254
> +
> +// const int index = 
> widget->listCMD->indexOfTopLevelItem(widgetItem->parent()) + 
> widgetItem->parent()->indexOfChild(widgetItem);
> +}

I guess you didn't meant to commit this

> autostart.cpp:288
>  return;
> -slotEditCMD( (AutoStartItem*)widget->listCMD->currentItem() );
> +slotEditCMD( 
> dynamic_cast(widget->listCMD->currentItem()) );
>  }

ditto

> autostart.h:48
>  public Q_SLOTS:
> -void slotChangeStartup( ScriptStartItem* item, int index );
> +void slotChangeStartup( ScriptStartItem *item, int index );
>  

Since you touched the line anyway you could as well remove the spaces between 
the parentheses

> autostartmodel.cpp:1
> +#include "autostartmodel.h"
> +

Copyright header missing

> autostartmodel.cpp:31
> +// must match enum AutostartEntrySource
> +const static QStringList s_paths = QStringList()
> +<< 
> QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + 
> QStringLiteral("/autostart/")

Urgh, no, use Q_GLOBAL_STATIC with an initializer

> autostartmodel.cpp:37
> +
> +const QStringList s_pathName = QStringList() << i18n("Startup")
> + << i18n("Logout")

Ditto

> autostartmodel.cpp:66
> +{
> +this->beginResetModel();
> +

We don't do "this->"

> autostartmodel.cpp:74
> +
> +autostartdir.setFilter( QDir::Files );
> +

Remove the spaces between the parentheses

> autostartmodel.cpp:76
> +
> +for (QFileInfo fi : autostartdir.entryInfoList()) {
> +QString filename = fi.fileName();

const auto , and qAsConst (have no idea if the list is cached somewhere and 
thus could detach)

> autostartmodel.cpp:79
> +bool desktopFile = filename.endsWith(QLatin1String(".desktop"));
> +if ( desktopFile ) {
> +AutostartEntry entry = loadDesktopEntry(fi.absoluteFilePath());

Drop the spaces

> autostartmodel.cpp:100
> +
> +dir.setFilter( QDir::Files );
> +

Drop the spaces

> autostartmodel.cpp:102
> +
> +for (QFileInfo fi : dir.entryInfoList()) {
> +

const auto , and qAsConst (have no idea if the list is cached somewhere and 
thus could detach)

> autostartmodel.cpp:121
> +
> +this->endResetModel();
> +}

s/this->//

> autostartmodel.cpp:126
> +{
> +Q_UNUSED(parent)
> +

Should return 0 if the parent is valid

> autostartmodel.cpp:131
> +
> +bool AutostartModel::checkEntry(const AutostartEntry )
> +{

Shouldn't that be at least const? Actually could probably even be static or in 
an anonymous namespace at the top of this file

> autostartmodel.cpp:145
> +
> +AutostartEntry AutostartModel::loadDesktopEntry(const QString )
> +{

Ditto

> autostartmodel.cpp:195
> +
> +switch (role) {
> +case DisplayRole : return entry.name;

at least Qt::DisplayRole should be handled

> autostartmodel.cpp:196
> +switch (role) {
> +case DisplayRole : return entry.name;
> +case Command : return entry.command;

No space before :

> autostartmodel.cpp:217
> +switch (role) {
> +case DisplayRole : {
> +if (entry.name == value.toString()) {

I think you meant Qt::EditRole here. Also no space before :

> autostartmodel.cpp:303
> +if (dirty) {
> +emit dataChanged(index, index, {role});
> +}

There might be a trick in the 

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

[Aleix Pol Gonzalez]

apol added a comment.


  In D27518#617439 , @ahmadsamir 
wrote:
  
  > In D27518#617038 , @apol wrote:
  >
  > > Makes sense. Have you tested that this works? You should probably pass 
KF5::GuiAddons to the target_link_libraries as well.
  >
  >
  > I tested a good number of the KCMs, and it seems to work well (both when 
khelpcenter is available and when it is not).
  
  
  Please link against KF5::GuiAddons from the target that needs to support help:

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27518

To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27643: FileChooser: download remote files to a cache location to open them through the portal

[Nathaniel Graham]

ngraham added a comment.


  In D27643#617800 , @apol wrote:
  
  > This really isn't ideal. It means we can't deal with any biggish files 
without having to cache them first.
  >  Also saving back (e.g. in kate) won't work, right?
  >
  > Maybe we can come up with a solution with fuse?
  
  
  ...Or use the existing one. That's what I was hinting at.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27643

To: jgrulich, aacid, feverfew, fvogt
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27643: FileChooser: download remote files to a cache location to open them through the portal

[Aleix Pol Gonzalez]

apol added a comment.


  This really isn't ideal. It means we can't deal with any biggish files 
without having to cache them first.
  Also saving back (e.g. in kate) won't work, right?
  
  Maybe we can come up with a solution with fuse?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27643

To: jgrulich, aacid, feverfew, fvogt
Cc: apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27638: allow to take qqc2 actions and fix issues with it not having the visible prop

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ActionToolBar.qml:211
>  id: button
> +visible: true
>  flat: root.flat && !kirigamiAction.icon.color.a

Isn't visible true by default?

> ActionToolBarLayoutDetails.qml:138
>  PrivateActionToolButton {
> + visible: true
>  flat: details.flat && !kirigamiAction.icon.color.a

Indentation is broken.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27638

To: camiloh, ahiemstra, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Nathaniel Graham]

ngraham added a comment.


  Thanks.
  
  So if I set the general font to 9pt Ubuntu Italic, then in the config file I 
see `gtk-font-name=Ubuntu, Italic 9` and Thunderbird respects the font, and the 
size, but not the style; it's not italic. :(
  
  Or is that a separate issue?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Camilo Higuita]

camiloh added a comment.


  works okay for me with qqc2 actions

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27653

To: ahiemstra, #kirigami
Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> spellchecking.cpp:55
> +
> +auto referenceValue = m_settings->currentIgnoreList();
> +auto currentValue = m_configWidget->ignoreList();

What about calling toSet() on those? Not overly efficient but would compress a 
bit the resulting code. Alternatively, couldn't we ensure those lists are 
always kept sorted?

> spellchecking.cpp:61
> +defaultValue.sort();
> +if (currentValue != referenceValue) {
> +unmanagedChangeState = true;

this is:

  unmanagedChangeState |= currentValue != referenceValue;

> spellchecking.cpp:64
> +}
> +if (currentValue != defaultValue) {
> +unmanagedDefaultState = false;

this is:

  unmanagedDefaultState &= currentValue == defaultValue

> spellchecking.cpp:74
> +defaultValue.sort();
> +if (currentValue != referenceValue) {
> +unmanagedChangeState = currentValue != referenceValue;

see above

> spellchecking.cpp:77
> +}
> +if (currentValue != defaultValue) {
> +unmanagedDefaultState = false;

see above

> spellchecking.cpp:82
> +
> +if (m_settings->defaultLanguage() != m_configWidget->language()) {
> +unmanagedChangeState = true;

see above

> spellchecking.cpp:85
> +}
> +if (m_configWidget->language() != 
> Sonnet::Settings::defaultDefaultLanguage()) {
> +unmanagedDefaultState = false;

see above

> ervin wrote in spellchecking.h:56
> nitpick: we usually find methods before variables

This still applies

> spellcheckingskeleton.cpp:38
> +
> +void SpellCheckingSkeleton::usrRead()
> +{

I'd expect this to update m_preferredLanguages, m_ignoreList and 
m_defaultLanguage otherwise we could have situations where things get out of 
sync. Also I'd expect to see usrSetDefaults() to be overridden as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea08681efe5e: libnotificationmanager : deprecate Settings 
ctor that takes a config (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=76380=76394

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27651: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo abandoned this revision.
gvgeo added a comment.


  Accidental patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27651

To: gvgeo, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27116: KCM/Component email: simplify code

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3d2dfabe5509: KCM/Component email: simplify code 
(authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27116?vs=75846=76393

REVISION DETAIL
  https://phabricator.kde.org/D27116

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp

To: meven, #plasma, ervin, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ca02af6584c6: Solid-device-automounter/kcm: Get rid of 
singleton for AutomounterSettings (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27480?vs=76294=76392

REVISION DETAIL
  https://phabricator.kde.org/D27480

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.h
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kcm/DeviceModel.h
  solid-device-automounter/kded/DeviceAutomounter.cpp
  solid-device-automounter/kded/DeviceAutomounter.h
  solid-device-automounter/lib/AutomounterSettings.cpp
  solid-device-automounter/lib/AutomounterSettings.h
  solid-device-automounter/lib/AutomounterSettingsBase.kcfgc

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Carson Black]

cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  There's a lot of string concatenation going on. I would replace a lot of the 
instances where you concat more than 2 strings with QString's arg function for 
readability purposes.
  
  Will review more thoroughly when I get the time.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

gikari added a comment.


  In D27380#617677 , @ngraham wrote:
  
  > Do you need to reload any daemon to get this to work?
  
  
  Yes

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Nathaniel Graham]

ngraham added a comment.


  Visually +1.
  
  I'm starting to agree that this is the wrong place to add the titlebar 
separator.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Nathaniel Graham]

ngraham added a comment.


  Do you need to reload any daemon to get this to work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27648: [KCM]Set implicitWidth for main page

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch please!

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  init (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27648

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 76385.
bport added a comment.


  Take change from sonnet patch in consideration and other ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27503?vs=75998=76385

REVISION DETAIL
  https://phabricator.kde.org/D27503

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.h
  kcms/spellchecking/spellcheckingskeleton.cpp
  kcms/spellchecking/spellcheckingskeleton.h

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:126
> +
> +if (modelData.hasOwnProperty("displayHint") &&
> +
> modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide)) {

I think this can be simplified to

  return !modelData.hasOwnProperty("displayHint") || 
!modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide;

> ActionToolBarLayoutDetails.qml:180
> +}
> +if (modelData.hasOwnProperty("displayHint")
> +&& 
> modelData.displayHintSet(Kirigami.Action.DisplayHint.KeepVisible)) {

same here

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27653

To: ahiemstra, #kirigami
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi updated this revision to Diff 76380.
crossi added a comment.


  constexpr

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=76379=76380

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi updated this revision to Diff 76379.
crossi added a comment.


  constexpr instead of static

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26834?vs=74116=76379

REVISION DETAIL
  https://phabricator.kde.org/D26834

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari added a comment.


  Ping

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27626: refactor: fix various compiler warnings

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:51fd586686a8: refactor: fix various compiler warnings 
(authored by dvratil).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27626?vs=76302=76377

REVISION DETAIL
  https://phabricator.kde.org/D27626

AFFECTED FILES
  common/control.cpp
  common/orientation_sensor.h
  kcm/kcm.cpp
  kcm/output_model.cpp
  kcm/output_model.h
  kded/config.cpp
  kded/generator.cpp
  kded/output.cpp
  tests/kded/configtest.cpp

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27626: refactor: fix various compiler warnings

[Daniel Vrátil]

dvratil added a comment.


  Also note that `noexcept` is not a compile-time check, it's a hint to enable 
some optimizations. It makes a difference when using standard library 
containers, e.g. `std::vector` will perform a copy if `T`'s move constructor 
is not `noexcept` in order to guarantee strong exceptions safety.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27626

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27626: refactor: fix various compiler warnings

[Daniel Vrátil]

dvratil added a comment.


  A good rule of a thumb is that your move constructor and assignment operator 
should always be `noexcept` unless you have a very good reason for them not to 
be. Qt has most move constructors marked as noexcept - I found a few that are 
not marked but that looks more like an oversight rather than intent, more so 
that Qt does not use exceptions - so if you have a type composed Qt types, 
making the constructor `noexcept` is perfectly safe. For custom types, even if 
their move constructors/assignment operators are not marked as `noexcept` it's 
fairly safe to assume they do not throw since we generally do not use 
exceptions in KDE.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27626

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in ExpandedRepresentation.qml:48
> not in all places you will have access to a dialog. the magic correct values 
> should come from the toparea margins itself done to go well with the 
> correspoding background svg.
> 
> in the end, i would like to have this in a control... i kinda hope a standard 
> toolBar control (will need some special casing when that style is running in 
> plasma or an app in plasma mobile

I've done the first part (the magic correct values should come from the toparea 
margins).

Regarding the control, I'm not sure how it could be done, since the usage of 
the toparea element changes a lot:

- On the systemtray, it includes a big header and buttons on the right
- On the notifications, it includes a small header / text and buttons on the 
right
- On kickoff, it should include the entire area with the profile picture, name 
and password.

How could that be done?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76374.
niccolove added a comment.


  Used toparea margins rather than systray dialog.margins

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=75095=76374

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27481: Panel spacer that can center things

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7b3b06a48576: Panel spacer that can center things 
(authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27481?vs=76369=76372

REVISION DETAIL
  https://phabricator.kde.org/D27481

AFFECTED FILES
  applets/CMakeLists.txt
  applets/panelspacer/CMakeLists.txt
  applets/panelspacer/Messages.sh
  applets/panelspacer/contents/config/main.xml
  applets/panelspacer/contents/ui/main.qml
  applets/panelspacer/metadata.desktop
  applets/panelspacer/package/contents/config/main.xml
  applets/panelspacer/package/contents/ui/main.qml
  applets/panelspacer/package/metadata.desktop
  applets/panelspacer/plugin/CMakeLists.txt
  applets/panelspacer/plugin/panelspacer.cpp
  applets/panelspacer/plugin/panelspacer.h
  shell/panelconfigview.cpp

To: mart, #plasma, #vdg, davidedmundson
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27643: FileChooser: download remote files to a cache location to open them through the portal

[Fabian Vogt]

fvogt added a comment.


  In D27643#617558 , @ngraham wrote:
  
  > Shouldn't KIO take care of this stuff automatically? I wouldn't want to 
lose streaming support for Flatpak apps.
  
  
  It should, but there's no API for that yet.
  
  At some point the file dialog can just return a FUSE path if the selected 
file is a remote URL and only local paths are accepted.

INLINE COMMENTS

> filechooser.cpp:210
> +
> +for (const QUrl  : fileDialog->m_fileWidget->selectedUrls()) {
> +// HACK we have to avoid returning until we copy the files

What about local URLs such as `file:///`?

Should probably try to use `KIO::mostLocalUrl` or something like that before.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27643

To: jgrulich, aacid, feverfew, fvogt
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27481: Panel spacer that can center things

[Marco Martin]

mart marked 7 inline comments as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in panelconfigview.cpp:115
> Seems like Panel could benefit from some sort of...ContinamentLayoutManager?
> 
> Effectively we're evaluating what RowLayout evaluates by hand here anyway, it 
> seems like the right path forward and worth investing time in. Though it can 
> happen after this patch.

indeed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27481: Panel spacer that can center things

[Marco Martin]

mart updated this revision to Diff 76369.
mart added a comment.


  - take maximum size into account
  - document -1

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27481?vs=75990=76369

BRANCH
  mart/panelSpacer

REVISION DETAIL
  https://phabricator.kde.org/D27481

AFFECTED FILES
  applets/CMakeLists.txt
  applets/panelspacer/CMakeLists.txt
  applets/panelspacer/Messages.sh
  applets/panelspacer/contents/config/main.xml
  applets/panelspacer/contents/ui/main.qml
  applets/panelspacer/metadata.desktop
  applets/panelspacer/package/contents/config/main.xml
  applets/panelspacer/package/contents/ui/main.qml
  applets/panelspacer/package/metadata.desktop
  applets/panelspacer/plugin/CMakeLists.txt
  applets/panelspacer/plugin/panelspacer.cpp
  applets/panelspacer/plugin/panelspacer.h
  shell/panelconfigview.cpp

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This applies a few fixes to ActionToolBar and PrivateActionToolButton when
  used in combination with QtQuick Controls 2's Action instead of 
  Kirigami.Action. It is a more elaborate version of D27638 
 .
  
  - Properly check if PrivateActionToolButton should be visible
  - Use hasOwnProperty for checking property exists and write out everything
  - Don't try to use tooltip property that may not be defined

TEST PLAN
  Kirigami Gallery still shows actions correctly.
  A test QML with QQC2 actions shows them correct.
  
  (I have an autotest for ActionToolBar in the works that will include a
  tests with QQC2 Action)

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_action

REVISION DETAIL
  https://phabricator.kde.org/D27653

AFFECTED FILES
  src/controls/private/ActionToolBarLayoutDetails.qml
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27643: FileChooser: download remote files to a cache location to open them through the portal

[Nathaniel Graham]

ngraham added reviewers: feverfew, fvogt.
ngraham added a comment.


  Shouldn't KIO take care of this stuff automatically? I wouldn't want to lose 
streaming support for Flatpak apps.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27643

To: jgrulich, aacid, feverfew, fvogt
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27626: refactor: fix various compiler warnings

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> dvratil wrote in output_model.h:90
> Because in `output_model.cpp:224` we do `m_outputs.insert(i, Output(output, 
> pos))`, which can make use of move semantics.
> 
> Making move operations `noexcept` is part of Cpp Core Guidelines 
> 
>  and because `QSharedPointer`'s move ctor is `noexcept` and `QPoint` is 
> trivially movable, the move operations here are also `noexcept`.
> 
> If it has any benefit here, since we possibly don't even have exceptions 
> enabled in kscreen, is a question - I wrote it by force of habit.

Thanks for the interesting explanation. I find it impractical that the 
usefulness of the noexcept keyword here depends on internals of the Qt classes. 
One would wish this is advertised to the consumer without knowing the 
internals. Or is it somewhere I'm not aware of?

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27626

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27650: Don't use guarded pointers for AppletsLayout

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > This function takes a plain pointer and wraps it into weak shared pointer.
  
  That's QWeakPointer.
  
  QPointer is something else that doesn't have an equivalent in stdlib.
  It takes a QObject,  then QObject has a special hook to unset watching 
QPointers to nullptr in QObject::~QObject()
  
  I don't understand how this could fix anything.
  
  If this is null, then m_layout is dangling which is worse.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27650

To: alnikiforov, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27481: Panel spacer that can center things

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in main.xml:15
> Please mention in the label what `-1` means

this needs doing

> main.qml:109
> +if (root.horizontal) {
> +middleItemsHint += Math.max(child.Layout.minimumWidth, 
> child.Layout.preferredWidth) + panelLayout.rowSpacing;
> +} else {

If we're trying to recreate the size hint of RowLayout we need to include 
maximum size hints

> mart wrote in panelconfigview.cpp:115
> so, i need to add the second spacer at first position rather than the last.
> I don't think i can do this without a script, as i need to access  the 
> qquickitem to actually set a position (well, i could by accessing the 
> graphics object property,directly, like the script implementation is doing, 
> but it would be uglier

Seems like Panel could benefit from some sort of...ContinamentLayoutManager?

Effectively we're evaluating what RowLayout evaluates by hand here anyway, it 
seems like the right path forward and worth investing time in. Though it can 
happen after this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Kevin Ottens]

ervin added a comment.


  LGTM, now requires swift testing to not miss the next bugfix release

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27651: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Fix applet configuration overlap with top line.
  Change the margins to move scrollbar so that it touches the edge,
  and use margins for content.
  Change the layout so that categories column can get the full height.
  Remove 2 unused properties.
  Fix bind loop for pageFlickable's width.

TEST PLAN
  Open desktop and audio configurations and make windows small.
  Select audio category and move content to the top. (If there is no
  scrollbar, increase and decrease height to exploit bug.)
  Before:
  At the right side (the main) scrollbar will have a margin.
  Desktop categories stop above buttons cancel, ok.
  Main content, and category highlight are displayed on top of the line.
  After:
  Scrollbar touch the edge, and the content has correct margin.
  Categories height is not limited.
  Main content, and category highlight touch the line below.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27651

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27650: Don't use guarded pointers for AppletsLayout

[Aleksei Nikiforov]

alnikiforov created this revision.
alnikiforov added reviewers: ngraham, davidedmundson, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alnikiforov requested review of this revision.

REVISION SUMMARY
  Using these pointer types incorrectly leads to premature destruction
  of AppletsLayout object and crash
  
  AppletsLayout m_layout is set only in function ItemContainer::setLayout.
  This function takes a plain pointer and wraps it into weak shared pointer.
  Eventually weak shared pointer's internal counter reaches zero and object 
instance m_layout points to is destroyed,
  although it was created via qml in plasma-desktop. This object destruction 
leads to a lot of issues, including eventual crash.
  
  BUG: 417603

TEST PLAN
  1. Unlock widgets via command: qdbus org.kde.plasmashell /PlasmaShell 
evaluateScript "lockCorona(false)"
  2. On desktop push right mouse button and select menu item 'Add Widgets...'
  3. Add various widgets to desktop using drag'n'drop on desktop. I've added at 
least following widgets on same desktop screen: Audio Volume, Battery and 
Brightness, Binary Clock, Clipboard, Color Picker, Grouping Plasmoid, Quick Chat
  4. Remove just added widgets in random order
  5. If necessary, repeat steps 3 and 4 a few times If widgets aren't appearing 
on desktop despite adding them via drag'n'drop, it's bugged and ready to crash. 
But it's not a requirement for crash.
  6. lock widgets via command: qdbus org.kde.plasmashell /PlasmaShell 
evaluateScript "lockCorona(true)"
  7. repeat steps 1-6 multiple times
  8. plasmashell shouldn't crash

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27650

AFFECTED FILES
  components/containmentlayoutmanager/itemcontainer.h

To: alnikiforov, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27625: fix: handle when backend fails to load/initialize

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:ff98585ea554: fix: handle when backend fails to 
load/initialize (authored by dvratil).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27625?vs=76295=76359

REVISION DETAIL
  https://phabricator.kde.org/D27625

AFFECTED FILES
  src/getconfigoperation.cpp

To: dvratil, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27626: refactor: fix various compiler warnings

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> romangg wrote in output_model.h:90
> Why to add and why noexcept?

Because in `output_model.cpp:224` we do `m_outputs.insert(i, Output(output, 
pos))`, which can make use of move semantics.

Making move operations `noexcept` is part of Cpp Core Guidelines 

 and because `QSharedPointer`'s move ctor is `noexcept` and `QPoint` is 
trivially movable, the move operations here are also `noexcept`.

If it has any benefit here, since we possibly don't even have exceptions 
enabled in kscreen, is a question - I wrote it by force of habit.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27626

To: dvratil, #plasma
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27648: [KCM]Set implicitWidth for main page

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Set implicitWidth in the main page for the initial size when opening
  audio settings.

TEST PLAN
  Open audio settings from kickoff.
  Before:
  
  After:

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  init (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27648

AFFECTED FILES
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: breeze-gtk now in invent

[Christoph Feck]

On 02/25/20 13:50, Jonathan Riddell wrote:

breeze-gtk seems to have moved to invent for development.

Looking through the list on invent I don't see any other Plasma projects
there.

That's cool but it's useful to know when and why moves like this happens as
it needs changes to my release scrips and others will get a surprise when
they want to make contributions to it.


We have https://phabricator.kde.org/T11994 to track those moves, please 
subscribe there.


--
Christoph Feck
KDE Release Team

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 125 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/125/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 25 Feb 2020 12:35:45 +
 Build duration:
32 min and counting
   CONSOLE OUTPUT
  [...truncated 218 lines...][2020-02-25T13:08:20.509Z] HOME  = '/home/jenkins'[2020-02-25T13:08:20.509Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/125/'[2020-02-25T13:08:20.509Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-02-25T13:08:20.509Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-25T13:08:20.509Z] SHELL = '/bin/sh'[2020-02-25T13:08:20.509Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-25T13:08:20.509Z] STAGE_NAME= 'Configuring Build'[2020-02-25T13:08:20.509Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-02-25T13:08:20.509Z] BLOCKSIZE = 'K'[2020-02-25T13:08:20.509Z] EXECUTOR_NUMBER   = '0'[2020-02-25T13:08:20.509Z] SHLVL = '0'[2020-02-25T13:08:20.509Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-25T13:08:20.509Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-25T13:08:20.509Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-25T13:08:20.509Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-25T13:08:20.509Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-25T13:08:20.509Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-25T13:08:20.509Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-25T13:08:20.509Z] QT_SELECT = 'qt5'[2020-02-25T13:08:20.509Z] LANG  = 'en_US.UTF-8'[2020-02-25T13:08:20.509Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-25T13:08:20.509Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-25T13:08:20.509Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-25T13:08:20.509Z] [2020-02-25T13:08:20.509Z] [2020-02-25T13:08:20.509Z] == Commencing Configuration:[2020-02-25T13:08:20.509Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-25T13:08:21.306Z] -- The C compiler identification is Clang 8.0.1[2020-02-25T13:08:21.306Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-25T13:08:21.306Z] -- Check for working C compiler: /usr/bin/cc[2020-02-25T13:08:21.306Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-25T13:08:21.306Z] -- Detecting C compiler ABI info[2020-02-25T13:08:21.306Z] -- Detecting C compiler ABI info - done[2020-02-25T13:08:21.306Z] -- Detecting C compile features[2020-02-25T13:08:21.306Z] -- Detecting C compile features - done[2020-02-25T13:08:21.306Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-25T13:08:21.306Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-25T13:08:21.306Z] -- Detecting CXX compiler ABI info[2020-02-25T13:08:21.306Z] -- Detecting CXX compiler ABI info - done[2020-02-25T13:08:21.306Z] -- Detecting CXX compile features[2020-02-25T13:08:21.306Z] -- Detecting CXX compile features - done[2020-02-25T13:08:21.306Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2020-02-25T13:08:21.306Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-25T13:08:21.306Z] -- Looking for __GLIBC__[2020-02-25T13:08:21.306Z] -- Looking for __GLIBC__ - not found[2020-02-25T13:08:21.306Z] -- Performing Test _OFFT_IS_64BIT[2020-02-25T13:08:21.306Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-25T13:08:21.306Z] -- Performing Test HAVE_DATE_TIME[2020-02-25T13:08:21.591Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-25T13:08:21.591Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.68.0") [2020-02-25T13:08:21.591Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for 

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 56 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/56/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 12:48:45 +
 Build duration:
9 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2020-02-25T12:57:53.715Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/56/display/redirect'[2020-02-25T12:57:53.715Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-25T12:57:53.715Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2020-02-25T12:57:53.715Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-25T12:57:53.715Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-25T12:57:53.715Z] NODE_NAME = 'Docker Swarm-f48d02916fc9'[2020-02-25T12:57:53.715Z] HOST  = 'f48d02916fc9'[2020-02-25T12:57:53.715Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-25T12:57:53.715Z] USER  = 'jenkins'[2020-02-25T12:57:53.715Z] MORE  = '-sl'[2020-02-25T12:57:53.715Z] CSHEDIT   = 'emacs'[2020-02-25T12:57:53.715Z] SHLVL = '2'[2020-02-25T12:57:53.715Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-56'[2020-02-25T12:57:53.715Z] WINDOWMANAGER = 'xterm'[2020-02-25T12:57:53.715Z] PAGER = 'less'[2020-02-25T12:57:53.715Z] EXECUTOR_NUMBER   = '0'[2020-02-25T12:57:53.715Z] CVS_RSH   = 'ssh'[2020-02-25T12:57:53.715Z] LIBGL_DEBUG   = 'quiet'[2020-02-25T12:57:53.715Z] STAGE_NAME= 'Configuring Build'[2020-02-25T12:57:53.715Z] NODE_LABELS   = 'Docker Swarm-f48d02916fc9 SUSEQt5.12'[2020-02-25T12:57:53.715Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-25T12:57:53.715Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-25T12:57:53.715Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-25T12:57:53.715Z] PROFILEREAD   = 'true'[2020-02-25T12:57:53.715Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-25T12:57:53.715Z] HOSTTYPE  = 'x86_64'[2020-02-25T12:57:53.715Z] BUILD_ID  = '56'[2020-02-25T12:57:53.715Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-25T12:57:53.715Z] OLDPWD= '/home/jenkins'[2020-02-25T12:57:53.715Z] LC_CTYPE  = 'C.UTF-8'[2020-02-25T12:57:53.715Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-25T12:57:53.715Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-25T12:57:53.715Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-25T12:57:53.715Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-25T12:57:53.715Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-25T12:57:53.715Z] QT_SELECT = 'qt5'[2020-02-25T12:57:53.715Z] LANG  = 'en_US.UTF-8'[2020-02-25T12:57:53.715Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-25T12:57:53.715Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-25T12:57:53.715Z] [2020-02-25T12:57:53.715Z] [2020-02-25T12:57:53.715Z] == Commencing Configuration:[2020-02-25T12:57:53.715Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2020-02-25T12:57:53.978Z] -- The C compiler identification is GNU 9.2.1[2020-02-25T12:57:53.978Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-25T12:57:53.978Z] -- Check for working C compiler: /usr/bin/cc[2020-02-25T12:57:54.242Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-25T12:57:54.242Z] -- Detecting C compiler ABI info[2020-02-25T12:57:54.242Z] -- Detecting C compiler ABI info - done[2020-02-25T12:57:54.502Z] -- Detecting C compile features[2020-02-25T12:57:54.502Z] -- Detecting C compile features - done[2020-02-25T12:57:54.502Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-25T12:57:54.502Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-25T12:57:54.502Z] -- Detecting CXX compiler ABI info[2020-02-25T12:57:54.775Z] -- Detecting CXX compiler ABI info - done[2020-02-25T12:57:54.775Z] -- Detecting CXX compile 

breeze-gtk now in invent

[Jonathan Riddell]

breeze-gtk seems to have moved to invent for development.

Looking through the list on invent I don't see any other Plasma projects
there.

That's cool but it's useful to know when and why moves like this happens as
it needs changes to my release scrips and others will get a surprise when
they want to make contributions to it.

Jonathan

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 279 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/279/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 12:35:44 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 277 lines...][2020-02-25T12:47:53.242Z] WINDOWMANAGER = 'xterm'[2020-02-25T12:47:53.242Z] PAGER = 'less'[2020-02-25T12:47:53.242Z] EXECUTOR_NUMBER   = '0'[2020-02-25T12:47:53.242Z] CVS_RSH   = 'ssh'[2020-02-25T12:47:53.242Z] LIBGL_DEBUG   = 'quiet'[2020-02-25T12:47:53.242Z] STAGE_NAME= 'Configuring Build'[2020-02-25T12:47:53.242Z] NODE_LABELS   = 'Docker Swarm-6f55098f504d SUSEQt5.12'[2020-02-25T12:47:53.242Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-25T12:47:53.242Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-25T12:47:53.242Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-25T12:47:53.242Z] PROFILEREAD   = 'true'[2020-02-25T12:47:53.242Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-25T12:47:53.242Z] HOSTTYPE  = 'x86_64'[2020-02-25T12:47:53.242Z] BUILD_ID  = '279'[2020-02-25T12:47:53.242Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-25T12:47:53.242Z] OLDPWD= '/home/jenkins'[2020-02-25T12:47:53.242Z] LC_CTYPE  = 'C.UTF-8'[2020-02-25T12:47:53.242Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-25T12:47:53.242Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-25T12:47:53.242Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-25T12:47:53.242Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-25T12:47:53.242Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-25T12:47:53.242Z] QT_SELECT = 'qt5'[2020-02-25T12:47:53.242Z] LANG  = 'en_US.UTF-8'[2020-02-25T12:47:53.242Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-25T12:47:53.242Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-25T12:47:53.242Z] [2020-02-25T12:47:53.242Z] [2020-02-25T12:47:53.242Z] == Commencing Configuration:[2020-02-25T12:47:53.242Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12"[2020-02-25T12:47:53.502Z] -- The C compiler identification is GNU 9.2.1[2020-02-25T12:47:53.502Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-25T12:47:53.502Z] -- Check for working C compiler: /usr/bin/cc[2020-02-25T12:47:53.502Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-25T12:47:53.502Z] -- Detecting C compiler ABI info[2020-02-25T12:47:53.836Z] -- Detecting C compiler ABI info - done[2020-02-25T12:47:53.836Z] -- Detecting C compile features[2020-02-25T12:47:53.836Z] -- Detecting C compile features - done[2020-02-25T12:47:53.836Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-25T12:47:53.836Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-25T12:47:53.836Z] -- Detecting CXX compiler ABI info[2020-02-25T12:47:54.093Z] -- Detecting CXX compiler ABI info - done[2020-02-25T12:47:54.093Z] -- Detecting CXX compile features[2020-02-25T12:47:54.093Z] -- Detecting CXX compile features - done[2020-02-25T12:47:54.093Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-02-25T12:47:54.093Z] -- Looking for __GLIBC__[2020-02-25T12:47:54.093Z] -- Looking for __GLIBC__ - found[2020-02-25T12:47:54.093Z] -- Performing Test _OFFT_IS_64BIT[2020-02-25T12:47:54.348Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-25T12:47:54.348Z] -- Performing Test HAVE_DATE_TIME[2020-02-25T12:47:54.348Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-25T12:47:54.612Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.68.0") [2020-02-25T12:47:54.612Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-02-25T12:47:54.612Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 37 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/37/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 25 Feb 2020 12:33:05 +
 Build duration:
8 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 198 lines...][2020-02-25T12:41:14.685Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-02-25T12:41:14.685Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2020-02-25T12:41:14.685Z] EDITOR= 'vi'[2020-02-25T12:41:14.685Z] ENV   = '/home/jenkins/.shrc'[2020-02-25T12:41:14.685Z] HUDSON_HOME   = '/home/production/data'[2020-02-25T12:41:14.685Z] BUILD_ID  = '37'[2020-02-25T12:41:14.685Z] OLDPWD= '/usr/home/jenkins'[2020-02-25T12:41:14.685Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-25T12:41:14.685Z] _ = '/usr/local/bin/java'[2020-02-25T12:41:14.685Z] TERM  = 'su'[2020-02-25T12:41:14.685Z] NODE_LABELS   = 'FreeBSD Builder Theta FreeBSDQt5.13'[2020-02-25T12:41:14.685Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-37'[2020-02-25T12:41:14.685Z] BUILD_DISPLAY_NAME= '#37'[2020-02-25T12:41:14.685Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/37/display/redirect'[2020-02-25T12:41:14.685Z] USER  = 'jenkins'[2020-02-25T12:41:14.685Z] HOME  = '/home/jenkins'[2020-02-25T12:41:14.685Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/37/'[2020-02-25T12:41:14.685Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-02-25T12:41:14.685Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-25T12:41:14.685Z] SHELL = '/bin/sh'[2020-02-25T12:41:14.685Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-02-25T12:41:14.685Z] STAGE_NAME= 'Configuring Build'[2020-02-25T12:41:14.685Z] NODE_NAME = 'FreeBSD Builder Theta'[2020-02-25T12:41:14.685Z] BLOCKSIZE = 'K'[2020-02-25T12:41:14.685Z] EXECUTOR_NUMBER   = '0'[2020-02-25T12:41:14.685Z] SHLVL = '0'[2020-02-25T12:41:14.685Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-25T12:41:14.685Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-02-25T12:41:14.685Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-25T12:41:14.685Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-02-25T12:41:14.685Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-02-25T12:41:14.685Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-25T12:41:14.685Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-02-25T12:41:14.685Z] QT_SELECT = 'qt5'[2020-02-25T12:41:14.685Z] LANG  = 'en_US.UTF-8'[2020-02-25T12:41:14.685Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-25T12:41:14.685Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-25T12:41:14.685Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-25T12:41:14.685Z] [2020-02-25T12:41:14.685Z] [2020-02-25T12:41:14.685Z] == Commencing Configuration:[2020-02-25T12:41:14.685Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2020-02-25T12:41:14.945Z] -- The C compiler identification is Clang 8.0.1[2020-02-25T12:41:14.945Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-25T12:41:14.945Z] -- Check for working C compiler: /usr/bin/cc[2020-02-25T12:41:15.210Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-25T12:41:15.210Z] -- Detecting C compiler ABI info[2020-02-25T12:41:15.210Z] -- Detecting C compiler ABI info - done[2020-02-25T12:41:15.210Z] -- Detecting C compile features[2020-02-25T12:41:15.211Z] -- Detecting C compile features - done[2020-02-25T12:41:15.211Z] -- Check for working CXX compiler: 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 61 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/61/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 12:33:05 +
 Build duration:
3 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-02-25T12:36:03.774Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-25T12:36:03.774Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-02-25T12:36:03.774Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/61/display/redirect'[2020-02-25T12:36:03.774Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-02-25T12:36:03.774Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-02-25T12:36:03.774Z] HUDSON_URL= 'https://build.kde.org/'[2020-02-25T12:36:03.774Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-02-25T12:36:03.774Z] NODE_NAME = 'Docker Swarm-62c9777a774b'[2020-02-25T12:36:03.774Z] HOST  = '62c9777a774b'[2020-02-25T12:36:03.774Z] LESSOPEN  = 'lessopen.sh %s'[2020-02-25T12:36:03.774Z] USER  = 'jenkins'[2020-02-25T12:36:03.774Z] MORE  = '-sl'[2020-02-25T12:36:03.774Z] CSHEDIT   = 'emacs'[2020-02-25T12:36:03.774Z] SHLVL = '2'[2020-02-25T12:36:03.774Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-61'[2020-02-25T12:36:03.774Z] WINDOWMANAGER = 'xterm'[2020-02-25T12:36:03.774Z] PAGER = 'less'[2020-02-25T12:36:03.774Z] EXECUTOR_NUMBER   = '0'[2020-02-25T12:36:03.774Z] CVS_RSH   = 'ssh'[2020-02-25T12:36:03.774Z] LIBGL_DEBUG   = 'quiet'[2020-02-25T12:36:03.774Z] STAGE_NAME= 'Configuring Build'[2020-02-25T12:36:03.774Z] NODE_LABELS   = 'Docker Swarm-62c9777a774b SUSEQt5.12'[2020-02-25T12:36:03.774Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-02-25T12:36:03.774Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-02-25T12:36:03.774Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-25T12:36:03.774Z] PROFILEREAD   = 'true'[2020-02-25T12:36:03.774Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-25T12:36:03.774Z] HOSTTYPE  = 'x86_64'[2020-02-25T12:36:03.774Z] BUILD_ID  = '61'[2020-02-25T12:36:03.774Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-25T12:36:03.774Z] OLDPWD= '/home/jenkins'[2020-02-25T12:36:03.774Z] LC_CTYPE  = 'C.UTF-8'[2020-02-25T12:36:03.774Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-25T12:36:03.774Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-02-25T12:36:03.774Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-25T12:36:03.774Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-02-25T12:36:03.774Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-02-25T12:36:03.774Z] QT_SELECT = 'qt5'[2020-02-25T12:36:03.774Z] LANG  = 'en_US.UTF-8'[2020-02-25T12:36:03.774Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-25T12:36:03.774Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-25T12:36:03.774Z] [2020-02-25T12:36:03.774Z] [2020-02-25T12:36:03.774Z] == Commencing Configuration:[2020-02-25T12:36:03.774Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-02-25T12:36:03.774Z] -- The C compiler identification is GNU 9.2.1[2020-02-25T12:36:03.774Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-25T12:36:03.774Z] -- Check for working C compiler: /usr/bin/cc[2020-02-25T12:36:03.774Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-25T12:36:03.774Z] -- Detecting C compiler ABI info[2020-02-25T12:36:03.774Z] -- Detecting C compiler ABI info - done[2020-02-25T12:36:03.774Z] -- Detecting C compile features[2020-02-25T12:36:03.774Z] -- Detecting C compile features - done[2020-02-25T12:36:03.774Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-25T12:36:03.774Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-25T12:36:03.774Z] -- 

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/5/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 25 Feb 2020 12:32:55 +
 Build duration:
2 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 409 lines...][2020-02-25T12:34:25.249Z] [26/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commentclient.cpp.obj[2020-02-25T12:34:25.249Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\productclient.cpp.obj[2020-02-25T12:34:25.249Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugclient.cpp.obj[2020-02-25T12:34:25.249Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\exceptions.cpp.obj[2020-02-25T12:34:25.249Z] [30/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-02-25T12:34:25.816Z] [31/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\logindetails.cpp.obj[2020-02-25T12:34:26.074Z] [32/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-02-25T12:34:26.074Z] [33/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-02-25T12:34:26.344Z] [34/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\querycommand.cpp.obj[2020-02-25T12:34:26.344Z] [35/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-02-25T12:34:26.344Z] [36/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla_debug.cpp.obj[2020-02-25T12:34:26.344Z] [37/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\product.cpp.obj[2020-02-25T12:34:26.633Z] [38/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\qbugzilla_autogen\mocs_compilation.cpp.obj[2020-02-25T12:34:26.633Z] [39/149] Automatic MOC for target gdbbacktracelinetest[2020-02-25T12:34:26.633Z] [40/149] Linking CXX static library lib\qbugzilla.lib[2020-02-25T12:34:27.301Z] [41/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\abstract_generator.cpp.obj[2020-02-25T12:34:27.301Z] [42/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.cpp.obj[2020-02-25T12:34:27.301Z] [43/149] Building CXX object src\tests\CMakeFiles\gdbbacktracelinetest.dir\gdbbacktracelinetest_autogen\mocs_compilation.cpp.obj[2020-02-25T12:34:27.301Z] [44/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\callbacks.cpp.obj[2020-02-25T12:34:27.679Z] [45/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj[2020-02-25T12:34:35.039Z] [46/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\__\drkonqi_debug.cpp.obj[2020-02-25T12:34:39.786Z] [47/149] Linking CXX executable bin\crashtest.exe[2020-02-25T12:34:39.786Z] [48/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\outputters.cpp.obj[2020-02-25T12:34:40.057Z] [49/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\msvc_generator.cpp.obj[2020-02-25T12:34:41.191Z] [50/149] Building CXX object src\tests\CMakeFiles\gdbbacktracelinetest.dir\gdbbacktracelinetest.cpp.obj[2020-02-25T12:34:41.820Z] [51/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_autogen\mocs_compilation.cpp.obj[2020-02-25T12:34:46.771Z] [52/149] Automatic MOC for target backtraceparsertest_manual[2020-02-25T12:35:10.502Z] [53/149] Linking CXX executable bin\gdbbacktracelinetest.exe[2020-02-25T12:35:10.502Z] [54/149] Automatic MOC for target backtraceparsertest[2020-02-25T12:35:12.051Z] [55/149] Linking CXX executable bin\kdbgwin.exe[2020-02-25T12:35:12.312Z] [56/149] Automatic MOC for target bugzillalibtest[2020-02-25T12:35:13.716Z] [57/149] Building CXX object src\tests\backtraceparsertest\CMakeFiles\backtraceparsertest_manual.dir\backtraceparsertest_manual.cpp.obj[2020-02-25T12:35:13.716Z] [58/149] Building CXX object src\tests\backtraceparsertest\CMakeFiles\backtraceparsertest_manual.dir\backtraceparsertest_manual_autogen\mocs_compilation.cpp.obj[2020-02-25T12:35:13.716Z] [59/149] Building CXX object src\tests\backtraceparsertest\CMakeFiles\backtraceparsertest_manual.dir\fakebacktracegenerator.cpp.obj[2020-02-25T12:35:13.990Z] [60/149] Automatic MOC for target attachmenttest[2020-02-25T12:35:14.594Z] [61/149] Automatic MOC for target bugzillatest[2020-02-25T12:35:14.595Z] [62/149] Building CXX object src\tests\backtraceparsertest\CMakeFiles\backtraceparsertest.dir\fakebacktracegenerator.cpp.obj[2020-02-25T12:35:14.878Z] [63/149] Automatic MOC for target connectiontest[2020-02-25T12:35:15.195Z] [64/149] Automatic MOC for target commenttest[2020-02-25T12:35:15.195Z] [65/149] Automatic MOC for 

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo added a comment.


  Can't have everything. now will cat line again.
  F8130965: Screenshot_20200225_140134.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo updated this revision to Diff 76356.
gvgeo added a comment.


  Categories touch top and bottom.
  Removed 1 unnecessary line.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27608?vs=76320=76356

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg, filipf
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

[Ahmad Samir]

ahmadsamir updated this revision to Diff 76355.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  target_link_libraries() KGuiAddons

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27518?vs=76266=76355

BRANCH
  l-khelp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27518

AFFECTED FILES
  CMakeLists.txt
  core/CMakeLists.txt
  core/ModuleView.cpp

To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

[Ahmad Samir]

ahmadsamir added a comment.


  In D27518#617038 , @apol wrote:
  
  > Makes sense. Have you tested that this works? You should probably pass 
KF5::GuiAddons to the target_link_libraries as well.
  
  
  I tested a good number of the KCMs, and it seems to work well (both when 
khelpcenter is available and when it is not).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27518

To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> VolumeSlider.qml:43
> +// Workaround: Slider has 2 extra pixels at the bottom, used for the 
> tickmarks, which move it off-center.
> +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11)
> +

I tried to change qqc2-desktop-style but didn't had any effect.
Wonder If I did something wrong,

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27645

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> VolumeSlider.qml:43
> +// Workaround: Slider has 2 extra pixels at the bottom, used for the 
> tickmarks, which move it off-center.
> +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11)
> +

Eww. Can we fix the slider instead?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27645

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Align mute button, slider and percent text.
  
  Set proper margin for mute.
  Cut 2 extra pixels at the bottom of the slider, which are used for the
  tickmarks and move it off-center.

TEST PLAN
  Before:
  
  After:

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  scaleM (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27645

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex added a comment.


  In D27166#617379 , @sitter wrote:
  
  > Yeah, I don't think I understand. I am sure a unit test would make things 
clearer ;) ;)
  
  
  Yes, I will add one :-).
  And in the last commit I just used a regex feature which matches all currency 
symbols, this makes it a lot easier.
  
  And a qick question: Should the converter be able to convert values like 
`US$`, If yes I would try to implement this.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Cyril Rossi]

crossi added a comment.


  @broulik any thoughts on this ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26834

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27643: FileChooser: download remote files to a cache location to open them through the portalBUG: 418155

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27643

AFFECTED FILES
  src/filechooser.cpp

To: jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27096: Refactoring, improve validation in kcm, optimize

[Alexander Lohnau]

alex updated this revision to Diff 76350.
alex added a comment.


  - Implement suggestion

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27096?vs=75358=76350

BRANCH
  charrunner_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27096

AFFECTED FILES
  runners/characters/charrunner.cpp
  runners/characters/charrunner.h
  runners/characters/charrunner_config.cpp
  runners/characters/charrunner_config.h
  runners/characters/charrunner_config.ui
  runners/characters/config_keys.h

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: davidre, dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Harald Sitter]

sitter added a comment.


  Yeah, I don't think I understand. I am sure a unit test would make things 
clearer ;) ;)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27096: Refactoring, improve validation in kcm, optimize

[Harald Sitter]

sitter added a subscriber: davidre.
sitter added a comment.


  Huh, guess kconfig never goes to QString after all.
  
  @davidre had a similar suggestion of using auto instead and let the compiler 
do its work IIRC
  
  dvratil's comment still applies to DEFAULT_TRIGGERWORD though.
  
  Generally speaking the global static keyword strings aren't very popluar in 
our code. Although, TBH, I do not know why.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27096

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: davidre, dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex updated this revision to Diff 76347.
alex added a comment.


  Use character types for currency symbols in regex

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27166?vs=76324=76347

BRANCH
  converter_runner_refactoring (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27166

AFFECTED FILES
  runners/converter/CMakeLists.txt
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Harald Sitter]

sitter added a comment.


  12? Why 12? Or I guess the more pertinent question: where is that limit set?

INLINE COMMENTS

> converterrunner.cpp:86
> +matchRegex.optimize();
> +//qInfo() << matchRegex.pattern();
>  }

left over debug

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27482: Update kdeglobals config file for Breeze widgetStyle

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> bport wrote in style_widgetstyle_default_breeze.pl:8
> This will fix only for Breeze theme
> This will fix existing case but we also need to fix the root cause (i.e. how 
> we end up with a lowercase name).

Root cause was fixed by D27407 

This patch will allow to fix faulty configuration file without requiring the 
user to re-apply Breeze Style as chatted in aforementioned patch.

Currently, this is the only faulty breeze I see, others KCM looks ok.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27482

To: crossi, ngraham, ervin, bport, meven, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Plasma Sprint 2020 in Augsburg, Germany

[Kai Uwe Broulik]

Hi,


My plan is to commute from Munich daily, so for the purpose of the
sprint you can consider I have a place to stay :)


Ah, okay, yeah, sure, come hang out with us ;)

Cheers
Kai Uwe

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf added a comment.


  Looks good to me and solves 3 of the 4 binding loops, although this one still 
remains:
  
  
`file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/configuration/AppletConfiguration.qml:296:25:
 QML StackView: Binding loop detected for property "height"`

INLINE COMMENTS

> gvgeo wrote in AppletConfiguration.qml:117
> I can make this side to draw on top of the separator, as it was. Will be 
> incorrect again.
> 
> Maybe separator must leave. It looks nice for breeze dark, but if the theme 
> says no line, why force it? It is not forced in system settings. And despite 
> if it looks okay or not for most setups, it is wrong to display for all 
> themes.

> Maybe separator must leave

I agree. I already tried doing it in D25728 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Feature requests re: 5.18 changes

[Kai Uwe Broulik]

Hi Derek,


First, I liked the old notification style with the linear countdown meter; I 
don't know what about the new style rubs
me the wrong way, but I think it would be neat to have a toggle in notification 
settings to switch between countdown
meter styles.


Is it misaligned for you?


Similarly, I noticed Breeze added a border to the scrollbar in 5.18. In my 
opinion, this makes the interface look more
bulky and bubbly, and especially on my Konsole windows bugs me something 
fierce. I think it would make sense to
add a Breeze scrollbar option for trough borders instead of forcing it on users.


I dislike our general lack of confidence in visual matters, resulting in 
"we don't relly like what we just did, so let's make an option to 
try to please everyone".


While I am quite unhappy with the scroll bar change, especially that it 
went in at the last minute and is still causing fall out all over the 
place, they should stay like this now.



If it's not on anybody's radar, I'd be glad to poke around the source and try 
these changes myself, but I hope
somebody who's already familiar with the source and the nitty-gritty of the 
changes between 5.17 and 5.18 has my
back.


I won't implement an option for the notification indicator but if you 
want to, go ahead, as long as it doesn't cause too much spaghetti code, 
I won't be opposed to it. And while at it, we could then also have an 
option to hide the indicator entirely, perhaps a ComboBox in settings of 
sorts:


Hide after: [5 seconds v^]
Timeout indicator style: [None|Circular|Vertical]

Cheers
Kai Uwe