D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham added a comment.


  It is (already) font-dependent, yes. A higher font size will result in larger 
spacing.
  
  IMO this is not super sensible, but, there is it. :p

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Went to check on different DPIs again to be sure it's fine and it definitely 
looks fine to me, scaling up the hitbox padding additions (and therefore the 
icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an 
issue.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezetoolsareamanager.cpp:146
> +if (window == widget->window()->windowHandle()) {
> +hasWidget = true;
> +}

you can break here once one widget is found. no need to loop over the remaining 
widgets.
alternatively you can use std::any_of or (better) std::none_of

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#620052 , @IlyaBizyaev 
wrote:
  
  > In D27466#620050 , 
@The-Feren-OS-Dev wrote:
  >
  > > This patch only affects the System Tray widget itself, not anything else 
on the panel. Only the spacing around the icons that are part of the System 
Tray applet itself will be changed by this patch.
  >
  >
  > I understand, but, as I mentioned, for me it already looks like what you 
expect to achieve with this.
  >  Is it maybe DPI or font dependent, causing the spacing to be smaller in 
your local setup?
  
  
  I have 1.0 DPI scaling, though the system tray icon spacing is indeed 
controlled by DPI scaling due to the 'units.smallSpacing' size unit.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76706.
cblack added a comment.


  Clean up animation map

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76694=76706

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breeze.h:191
> +AnimationPressed = 0x8,
> +AnimationWindowFocused = 0x10,
>  };

Sorry for the many postings. 
As far as I can tell this guy is used nowhere. Please remove.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezetoolsareamanager.h:1
> +#pragma once
> +

Please use garding defines rather than "pragma once" for consistency with the 
rest of the code.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a subscriber: davidedmundson.
hpereiradacosta added a comment.


  also adding @davidedmundson in the loop in particular for opinion on the 
devicepixel ratio business, and in case he can reproduce the crash.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> cblack wrote in breezehelper.cpp:1726
> In testing, I found that this would remain 1 physical pixel regardless of 
> scale factor.

Then shouldn't you divide device pixel ratio ? 
Also, someone else should double check. To me that does not make sense. 
Everything else (*everything*) scales with device pixel ratio. Why should this 
line in particular not scale ? What makes it different from regular separators ?

> breezestyle.cpp:886
> +painter->drawLine(
> +widget->rect().left() - 100,
> +widget->rect().top(),

What are these + and -100 numbers ? They sound arbitrary. At the minimum there 
should be a comment, and an enum to define what this number is.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezehelper.cpp:1726
> No. Should be QPen( outline, 1) or just "outline"
> DevicePixelRatio is handled by paint engine.

In testing, I found that this would remain 1 physical pixel regardless of scale 
factor.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.cpp:1726
> +
> +painter->setPen(QPen(outline, 
> 1*widget->screen()->devicePixelRatio()));
> +painter->setBrush(Qt::NoBrush);

No. Should be QPen( outline, 1) or just "outline"
DevicePixelRatio is handled by paint engine.

> breezestyle.cpp:882
> +
> +painter->setPen(QPen(outline, 
> 1*widget->screen()->devicePixelRatio()));
> +painter->setBrush(Qt::NoBrush);

Same remark

> breezetoolsareamanager.cpp:97
> +
> +void ToolsAreaManager::registerWidget(QWidget *widget)
> +{

As far as I have followed the code you need an "unregisterWidget" for when 
widgets are unpolished and to remove windows from the map. 
You also need a connection to the destroyed signal to cleanup the map when a 
widget is deleted, otherwise you will keep accumulating an ever growing map of 
dangling pointers.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#620072 , 
@hpereiradacosta wrote:
  
  > I can also try produce a crash report.
  
  
  A stack trace (with all debug symbols available) would be nice, yes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D27669#619991 , @cblack wrote:
  
  > In D27669#619230 , 
@hpereiradacosta wrote:
  >
  > > right now it crashes all applications (here at least) when you unlock 
toolbars, move them to a different position, then move them back to top. 
  > >  Tested with dolphin, okular, etc. All crash.
  >
  >
  > Cannot reproduce.
  
  
  Can someone else try ? (Nathan ? Noah ?) I do not have the latest Qt version 
installed so maybe it is just on my system. 
  I can also try produce a crash report. 
  (in more details: open dolphin, unlock toolbars from right click menu in 
toolbar area. Move toolbar to the left side of the window and leave it there. 
Then move it back to the top, where it originally was. Bam. Crash)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27466#620050 , 
@The-Feren-OS-Dev wrote:
  
  > This patch only affects the System Tray widget itself, not anything else on 
the panel. Only the spacing around the icons that are part of the System Tray 
applet itself will be changed by this patch.
  
  
  I understand, but, as I mentioned, for me it already looks like what you 
expect to achieve with this.
  Is it maybe DPI or font dependent, causing the spacing to be smaller in your 
local setup?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#620037 , @IlyaBizyaev 
wrote:
  
  > Repeating my comment on the previous diff for this change: on my machine, 
the current spacing for systray elements already looks like your "after" 
screenshot. With normal usage, my systray area (icons + clock + a note widget) 
takes up 1/4 of the panel. Does it mean that after this change, it's going to 
be even larger?
  
  
  This patch only affects the System Tray widget itself, not anything else on 
the panel. Only the spacing around the icons that are part of the System Tray 
applet itself will be changed by this patch.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Repeating my comment on the previous diff for this change: on my machine, the 
current spacing for systray elements already looks like your "after" 
screenshot. With normal usage, my systray takes up 1/4 of the panel. Does it 
mean that after this change, it's going to be even larger?

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[George Vogiatzis]

gvgeo added a comment.


  I was too late, it does change constantly now. But it depends on the font. 
The default font has the same width for all numbers, others don't.
  
  Wish I could at least help with git, but I struggle with it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: gvgeo, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 76694.
cblack added a comment.


  Clear pen before drawing toolbar control

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=76592=76694

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#619230 , 
@hpereiradacosta wrote:
  
  > right now it crashes all applications (here at least) when you unlock 
toolbars, move them to a different position, then move them back to top. 
  >  Tested with dolphin, okular, etc. All crash.
  
  
  Cannot reproduce.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fed83f884acd: Fixed margin of digital clock (authored by 
niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27737?vs=76678=76692

REVISION DETAIL
  https://phabricator.kde.org/D27737

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: gvgeo, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Niccolò Venerandi]

niccolove added a comment.


  Is this correct, or is there anything special I have to do to land it to 
stable?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: gvgeo, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[George Vogiatzis]

gvgeo added a comment.


  By using paintedWidth size is going to change constantly and will move the 
rest of the widgets.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  margin_digital_clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: gvgeo, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Visually +1 too.
  
  Stable branch?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  margin_digital_clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  code wise it makes much more sense than the original one

REPOSITORY
  R120 Plasma Workspace

BRANCH
  margin_digital_clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#619931 , @ngraham wrote:
  
  > So at this point it's just one pixel, and I don't see the huge harm. :) 
However the last patch to adjust this (D27438 
) proved quite controversial, so we should 
wait for more opinions to avoid unduly ruffling feathers. :)
  
  
  To be fair, part of the issue with the previous patch was that it didn't 
increase hitbox size while increasing spacing, while this one does, so 
hopefully there won't be too many issues with this.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  So at this point it's just one pixel, and I don't see the huge harm. :) 
However the last patch to adjust this (D27438 
) proved quite controversial, so we should 
wait for more opinions to avoid unduly ruffling feathers. :)

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9e0711ac408d: Make the icon hitboxes for the System Tray 
Plasmoid larger when Kirigami Tablet… (authored by The-Feren-OS-Dev, committed 
by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75911=76686

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg, #plasma, niccolove
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27577: [KCM]Fix content below scrollbars

[Nathaniel Graham]

ngraham added a comment.


  +1, go ahead

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27737: Fixed margin of digital clock

[Nathaniel Graham]

ngraham added a comment.


  Nice, this fixes https://bugs.kde.org/show_bug.cgi?id=417803.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Niccolò Venerandi]

niccolove added a comment.


  +1

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  margin_digital_clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27737

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76674.
niccolove added a comment.


  Fix close button right margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76672=76674

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76672.
niccolove added a comment.


  Fixed layouts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76571=76672

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[George Vogiatzis]

gvgeo added a comment.


  In my opinion this is better even without the workaround.
  Only when scale is 100% for playback devices, look worse (first photo in 
before-after).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27645

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart