D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27763 To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Fere

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. IMO this is the wrong way to do these changes. 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place. 2. For tablets already allow to use bigger si

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. This patch is depends on D27763 being applied first. Old l2tp: F8144374: old-l2tp.png Old l2tp IPsec Settings : F8144378: old-l2tp-ipsec.png

D27770: HiDPI improvement of left panel

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27770 AFFECTED FILES applets/kimpanel/backend/ib

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. Well, if dedoimedo likes it this way, then it's probably the right thing to do ;) Since no one else complains about this change, I'll assume I just was lucky to have proper scaling on my machine without "magic number" spacings. BRANCH D27466 (branched from

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

niccolove added a comment. E.g.: dedoimedo complained about this in both the .18 and .17 review. BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. The main point of this patch is the spacing increase between tray icons that this hitbox size increase gives, which makes the tray look less cramped as a result. BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

anthonyfieroni added a comment. Do it like in pager for wayland https://github.com/KDE/plasma-desktop/blob/master/applets/pager/plugin/pagermodel.cpp#L577 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353 To: wstephenson, #plasma, ivan, davidedmundson Cc:

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

wstephenson added a comment. In D27353#618452 , @ivan wrote: > This looks cool. The thing I'm missing (correct me if I'm wrong - I'm yet to test the patch) is for it to open the switcher when dragging the window over the switcher applet icon.

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. It's hard to measure this in pixels, but on the screenshot, it's a 10% increase in size. I use default font settings btw, with a global scaling factor of 1.25. I'm not strongly against this, but I don't really see a point in this either. In, like, 4 years o

D27669: WIP: [kstyle] Tools area

ndavis added a comment. Okular has the same problem as Dolphin. Backtrace: F8143746: okular-20200301-093637.kcrash.txt <https://phabricator.kde.org/F8143746> REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidedm

D27669: WIP: [kstyle] Tools area

ndavis added a comment. It's too hard to tell the difference between active and inactive icons: F8143741: Screenshot_20200301_093349.PNG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc:

D27669: WIP: [kstyle] Tools area

ndavis added a comment. Falkon doesn't blend: F8143736: Screenshot_20200301_093246.PNG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham,

D27669: WIP: [kstyle] Tools area

ndavis added a comment. This line is way too bright on Dark themes{F8143729 } REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin

D27669: WIP: [kstyle] Tools area

ndavis added a comment. Dolphin is crashing pretty regularly for me and it has this graphical glitch every time it crashes: F8143719: Screenshot_20200301_092241.PNG <https://phabricator.kde.org/F8143719> Backtrace: F8143722: dolphin-20200301-092242.kcrash.txt

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. I mean, it's only one more pixel. :) But yes, for some people with certain fonts maybe it will be too much. But then again, could a single pixel really be enough to make it too much? BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.or

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. dkosovic requested review of this revision. REVISION SUMMARY - Update to NetworkManager-l2tp 1.8.0 features which include: - NetworkManager-l2tp 1.8.0 u

D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

dkosovic created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. dkosovic requested review of this revision. REVISION SUMMARY Calling the IPsec dialog Advanced is confusing, so rename it to IPsec. Also in a subsequent p

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. In D27466#620191 , @ngraham wrote: > It is (already) font-dependent, yes. A higher font size will result in larger spacing. > > IMO this is not super sensible, but, there is it. :p Ok, so I guess for the g