D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: Plasma.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  [0-9] is \d

TEST PLAN
  make && ctest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:999f0ad9fb8b: Update L2TP  to NetworkManager-l2tp 1.8.0 
features (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27764?vs=76933=76989

REVISION DETAIL
  https://phabricator.kde.org/D27764

AFFECTED FILES
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Jan Grulich]

jgrulich added a comment.


  I would say it's not a big deal as we use groupboxes quite a lot in 
plasma-nm. We can get rid of them in future when rewriting the KCM to QML.

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

[Nathaniel Graham]

ngraham added a comment.


  In D27847#622409 , @anthonyfieroni 
wrote:
  
  > Why?
  
  
  I think you forgot to read the description section. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27847

To: ngraham, #vdg, #plasma, niccolove, ognarb
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

[Anthony Fieroni]

anthonyfieroni added a comment.


  Why?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27847

To: ngraham, #vdg, #plasma, niccolove, ognarb
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27856: Improve "write a review" encouragement message

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:6d6b7555248b: Improve write a review 
encouragement message (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27856?vs=76984=76985

REVISION DETAIL
  https://phabricator.kde.org/D27856

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: apol, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27856: Improve "write a review" encouragement message

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's not necessarily apps, it doesnt' really add that much meaning
  
  BUG: 418365

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27856

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: apol, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27838: Port to new QML Connections syntax

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Yes, can't be done until 5.14 is required in frameworks.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27838

To: jbbgameich, #frameworks, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Nathaniel Graham]

ngraham added a comment.


  Can confirm the fix when running from the desktop, but not when using the 
shortcut. So I wouldn't call 416145 fully fixed yet. Are you planning to work 
on that other part in this patch, or in a separate one?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Nathaniel Graham]

ngraham added a comment.


  It's just that in general we're trying to move away from group boxes and 
towards the use of whitespace to logically group sections. It's not a huge 
deal, but it would be appreciated. :)

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27849: [applets/digital-clock] Remove the tooltip icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  To increase consistency and reduce redundancy, widget tooltip icons are being 
removed
  in D27847  and D27848 
, per discussion in T12778 
. This patch makes the Digital Clock
  consistent what that initiative, since it has a custom tooltip.

TEST PLAN
  F8150016: Clock.png 
  F8150021: Icon-less tooltips.webm 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27849

AFFECTED FILES
  applets/digital-clock/package/contents/ui/Tooltip.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  As discussed in T12778 , the icon can 
never be in a correct state: either it's
  redundant with the icon you're hovering over that made the tooltip appear, or
  else it's different from the icon you're hovering over, which is inconsistent.
  Furthermore, some instances of the tooltip have icons and others do not,
  heightening the inconsistency.
  
  Since either case is undesirable, let's just remove the icon from the tooltip
  entirely. This reduces the visual noise in the tooltip and solves the entire
  class of bugs automatically.

TEST PLAN
  F8150018: App launcher.png  
  F8150021: Icon-less tooltips.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27847

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham updated this revision to Diff 76967.
ngraham added a comment.


  Use 38px as the height, and hardcode it since there's no good way to get 
there with a
  multiple of `gridUnit`

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27845?vs=76966=76967

BRANCH
  iotm-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27845

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: ngraham, #vdg, #plasma
Cc: niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27792: [Applet]Fix traffic monitor labels width

[Nathaniel Graham]

ngraham added a comment.


  Yeah, if you want to keep the plotter dimensions constant, then there's no 
way around measuring the width of the labels.
  
  Regarding not opening any new patches, I hope you didn't have a bad 
experience in KDE that's left a bad taste in your mouth. If anything's gone 
wrong, don't hesitate to let me know and I'll do what I can.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27792

To: gvgeo, #vdg, #plasma, jgrulich, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  Now to my eyes, 38px is too small. But apparently my tired old eyes and small 
screen (13.3" FHD) are not representative of other VDG people's views. :)
  
  Still it makes me realize that we really need to get 
https://bugs.kde.org/show_bug.cgi?id=356446 done so that Plasma can properly 
scale itself. Ideally I would be using a 1.1 or 1.2x scale factor and 
everything in Plasma would automatically get bigger. And even more ideally, the 
correct scale factor would be auto-detected based on the user's display metrics.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Niccolò Venerandi]

niccolove added a comment.


  +1 to 38
  Weirdly enough, the plasma icon only looks that big from >40, while the IOTM 
does not use big icons in 40 yet. I'd like small icons to be used consistently.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  Some folks in the #VDG  channel have 
objected to the panel being 48px tall, so here's how it would look at 38 (the 
default Windows panel height):
  
  F8149938: 38.png 
  
  Not as touch-friendly, but the clock text looks better and it won't be so 
huge for people using low-DPI screens. However 38 is not easy to calculate by 
our existing units so it would likely need to be hardcoded.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  Sounds like a bug we should fix with the `preferred://` schemas then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  
`applications:systemsettings.desktop,applications:org.kde.discover.desktop,preferred://filemanager,preferred://browser`
  
  There is currently an issue that might make this cumbersome, unless it was 
fixed very recently as part of the patch work for this, being that 
preferred://browser causes duplicated entries for stuff like Vivaldi, etc 
(they'll be separate from the preferred:// pins meaning the preferred:// item 
basically acts as a quick launcher which is far from what is intended). Similar 
problem with preferred://filemanager. I would've used those instead of hard 
pins to vivaldi.desktop and org.kde.dolphin.desktop by default in Feren OS if 
it wasn't for that aforementioned issue being there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of, D27845: Replace Task Manager with Icons-Only-Task 
Manager in the default panel, and thicken it 
, after further discussion in T12441 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25773

To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  One other note: it might make sense to turn on the Digital Clock's date 
display by default if we go with this, as the clock text is currently rather 
gigantic and IMO adding the date results in both more information and also a 
better use of space:
  
  F8149908: clock.png 
  
  It might also be nice to make the date automatically appear for panels of a 
certain height, and then change the date display to a three-position setting 
"always shown", "always hidden", and "automatic". That would be material for 
another patch though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements the part of T12441  
that was virtually universally agreed-to:
  switching out the regular Task Manager for an Icons-Only Task Manager, 
pinning some
  apps by default, and thickening the panel. The panel remains in its current 
position.
  
  Ideally I'd like for this patch to used for discussions about the 
implementation, not the
  general concept, so if you have concerns about that, please put them in 
T12441 .
  
  Also note that https://bugs.kde.org/show_bug.cgi?id=403640 currently breaks 
the IOTM
  icons from keeping their position, which would definitely need to be fixed 
before this
  lands.

TEST PLAN
  This is now the default panel: F8149886: desktop.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  iotm-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27845

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27792: [Applet]Fix traffic monitor labels width

[George Vogiatzis]

gvgeo added a comment.


  I don't plan to make more patches, for now. But if the problem would not 
exist with layouts, prefer to do it than make quick bugfixes.
  
  But can't see how the Layouts would help with that. Everything can be done 
without Layouts too AFAIK, just more messy.
  I want to keep the plotter dimensions constant. It would not be nice to 
change width constantly.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27792

To: gvgeo, #vdg, #plasma, jgrulich, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27792: [Applet]Fix traffic monitor labels width

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  If you need to measure the width of text, then you're doing it the right way.
  
  However this problem wouldn't be happening in the first place if this UI used 
Layouts, which handle this kind of case more elegantly so you don't need to 
manually set margins and measure the width of items.
  
  So I say feel free to land this now since it's a correct bugfix and the 
current code is obviously wrong. And I think we should move towards porting to 
Layouts in another patch. I can do that if you're sick of plasma-nm. :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27792

To: gvgeo, #vdg, #plasma, jgrulich, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo added a comment.


  There is a problem, I still try to fix...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Nathaniel Graham]

ngraham added a comment.


  Yeah, this seems fine to land as-is. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27686: Fix connection to invalid signal

[Albert Astals Cid]

aacid added a comment.


  ping

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27686

To: aacid
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  UI and interaction are good, and a basic code review reveals no issues to me. 
Still, you may want to wait for a more thorough code review from a #plasma 
 person.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27843: Port to new QML Connections syntax

[Jonah Brüchert]

jbbgameich created this revision.
jbbgameich added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Can be landed once Frameworks can depend on Qt 5.14

TEST PLAN
  Everything still work (It won't work with Qt < 5.14)

REPOSITORY
  R169 Kirigami

BRANCH
  515-connection-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27843

AFFECTED FILES
  src/controls/FormLayout.qml
  src/controls/private/ActionButton.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/private/globaltoolbar/BreadcrumbControl.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml
  src/controls/templates/SwipeListItem.qml

To: jbbgameich, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=345440

Harald Sitter  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||sit...@kde.org
 Status|REPORTED|NEEDSINFO

--- Comment #3 from Harald Sitter  ---
Do you think it was important that the remote directory was on a mount?

The way I see it that should be all the same to ssh, in the end the permissions
you documented would prevent you from deleting that folder on a POSIX level as
well, so I would think that the access-denied error condition simply wasn't
mapped to a pretty string in sftp. It is now however, so this should be solved
in (at least) 19.12+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=376301

Harald Sitter  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||sit...@kde.org
 Status|REPORTED|NEEDSINFO

--- Comment #2 from Harald Sitter  ---
Is this still reproducible with the 19.12 release? What version of libssh is
used?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, 
ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

TEST PLAN
  Has been tested with the three modules mentioned in the commit message

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27841

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27838: Port to new QML Connections syntax

[Jonah Brüchert]

jbbgameich updated this revision to Diff 76950.
jbbgameich added a comment.


  Fix syntax error

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27838?vs=76949=76950

BRANCH
  5.15-connections-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27838

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Menu.qml

To: jbbgameich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27838: Port to new QML Connections syntax

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Fixes deprecation warnings with Qt 5.15

TEST PLAN
  No deprecations warnings, everything still works

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  5.15-connections-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27838

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Menu.qml

To: jbbgameich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27837: Fix about page with Qt 5.15

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  UrlButton exists since since org.kde.kirigami 2.6, before the file was 
resolved from the current directory but doesn't seem to be anymore with 5.15

REPOSITORY
  R169 Kirigami

BRANCH
  about-page-qt-515 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27837

AFFECTED FILES
  src/controls/AboutPage.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27824: Use consistent highlight

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Need to adjust the button's right margin in `DeviceItem.qml` as well: 
F8149546: Screenshot_20200304_084053.png 
  
  Could be done in another patch.

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham added a comment.


  This needs a rebase. Also you probably need to delete the existing mouseover 
highlight effect.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=366488

Harald Sitter  changed:

   What|Removed |Added

 CC||sit...@kde.org

--- Comment #1 from Harald Sitter  ---
Is this still a problem? Does this happen when talking to more than one or two
servers?

There should be guards in place to limit the amount of concurrent processes in
general and specifically per host as well, so it sounds a bit like the
processes may have gotten stuck on shutdown. As in: KIO doesn't know about them
anymore but they are still there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=366488

Harald Sitter  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #2 from Harald Sitter  ---
status

-- 
You are receiving this mail because:
You are the assignee for the bug.

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic added a comment.


  When I was updating this client's UI, I was pretty conflicted about using 
group boxes, many of the other VPN clients were using group boxes for their 
main window and at one stage I was thinking of introducing group boxes for the 
main window of this client. It was definitely this client's PPP settings dialog 
which uses multiple group boxes that initially convinced me to use group boxes 
with the IPsec settings dialog.
  
  I don't know what is best for the UI.

REVISION DETAIL
  https://phabricator.kde.org/D27764

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic updated this revision to Diff 76933.
dkosovic added a comment.


  updates based on review comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27764?vs=76731=76933

REVISION DETAIL
  https://phabricator.kde.org/D27764

AFFECTED FILES
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h

To: dkosovic, jgrulich
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27832: Fix spacing change

[Niccolò Venerandi]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eb4235eae1e8: Fix spacing change (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27832?vs=76929=76930

REVISION DETAIL
  https://phabricator.kde.org/D27832

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27832: Fix spacing change

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  A accidentally changed spacing with my previous commit

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27832

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

[Ahmad Samir]

ahmadsamir added a comment.


  FTR, removing setNeedsSave(false) from load(), it seems to work sometimes, 
and then some other times it doesn't work (i.e. changing anything, Apply 
doesn't get enabled)...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, broulik, ervin, meven.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  KConfig will clear the styleName font property for "Regular"-like font
  styles (so that setBold(true) can work properly); this means that when
  opening the font selection dialog it may highlight the wrong style for
  the font currently set in kdeglobals, i.e. if the styleName property is
  empty, QFontDialog will always select the first style in the list.
  
  Workaround the issue by setting the "Regular"-like font style of the
  initial font.
  
  adjustAllFonts() doesn't take any arguments, change the QML code accordingly.
  
  Depends on D27808 
  Depends on D27785 
  
  See also https://phabricator.kde.org/D27735 (KConfig)

TEST PLAN
  - Apply this diff and the other two it depends on
  - Edit kdeglobals and remove ",Regular|Normal|Book|Roman" from the *font*= 
entries; append e.g. ",Bold" to one of those entries (pick a font family that 
has a bold style)
  - Open the fonts kcm, and open the font selection dialog for a font, the 
correct "Regular"-like style should be selected
  - Open the font selection dialog for the font you set as Bold; Bold should be 
highlighted
  - Open the "Adjust all fonts" dialog, again the correct style should be 
selected

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-qfontdlg-fix-initial (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27830

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  Uff, I screwed up landing this patch: 
https://cgit.kde.org/plasma-workspace.git/commit/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:149075077b82: Changed leftMargins to smallSpacing to be 
consistent (authored by niccolove).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26946?vs=76913=76923#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=76913=76923

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26945: fix(plasmoid): add smallSpacing to leftMargin

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:b0f3fa30d427: fix(plasmoid): add smallSpacing to 
leftMargin (authored by niccolove).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26945?vs=76025=76920

REVISION DETAIL
  https://phabricator.kde.org/D26945

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: niccolove, #vdg, romangg
Cc: romangg, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26945: fix(plasmoid): add smallSpacing to leftMargin

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Depends on if you use in the end arc. Then it's given by the Phab diff title.
  
  I changed it some more. See 
https://github.com/angular/angular/blob/3cf2005a936bec2058610b0786dd0671dae3d358/CONTRIBUTING.md#subject.
  
  Patch looks good.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26945

To: niccolove, #vdg, romangg
Cc: romangg, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26945: fix(plasmoid): Added smallSpacing to leftMargin

[Niccolò Venerandi]

niccolove added a comment.


  Is the commit given by the patch title that I just changed, or do I have to 
change the commit name somewhere else?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26945

To: niccolove, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Volker Krause]

vkrause added a comment.


  I can reproduce only if I set a valid translation catalog. Even more 
surprising since the affected dialog does not seem to contain any qsTr() 
translations.
  I don't think this patch is wrong as such, the layouting glitch is a bug 
elsewhere that we trigger by the retranslation (but that could be non-trivial 
to track down). If you need a quick workaround (at the expense of working qsTr 
translations), just comment the connect() call in initializeEngine().

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove updated this revision to Diff 76913.
niccolove added a comment.


  Remove spacing changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=76024=76913

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This uses the PlasmaComponents.Highlight feature to be consistent with other 
lists

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
niccolove requested review of this revision.

REVISION SUMMARY
  Use the PlasmaComponents.Highlight feature to be consistent with other lists.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo abandoned this revision.
gvgeo added a comment.


  Unfortunately I won't be able to continue with this patch about battery 
applet.
  Feel free to use/modify if you want.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  Actually, there is a proper way to do this. Gimme a sec.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf added a comment.


  In D27608#621705 , @gvgeo wrote:
  
  > Strange, I don't get the resizing problem as it is now, or in master. Only 
managed to get this space by changing the theme, and was immediately fixed with 
resize.
  >
  > Thanks Filip for double checking.
  
  
  No problem. It needs to be a specific kind of resize action I guess.
  
  F8149051: RTLresize 
  
  I'm using Kvantum but I can make it with happen Breeze as well. We probably 
also need to change heading so it's aligned to the right, but both of these 
things are material for a different patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo added a comment.


  Strange, I don't get the resizing problem as it is now, or in master. Only 
managed to get this space by changing the theme, and was immediately fixed with 
resize.
  
  Thanks Filip for double checking.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo updated this revision to Diff 76910.
gvgeo added a comment.


  Cancel button was touching the edge in RTL.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27608?vs=76908=76910

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Fixes the regression. It's still possible to get this when resizing, but it 
was actually already like that before this patch.
  
  F8149023: image.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27645: [KCM]Align volume controls row

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:ca15ec82c121: [KCM]Align volume controls row (authored by 
gvgeo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27645?vs=76884=76909

REVISION DETAIL
  https://phabricator.kde.org/D27645

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27608: Fixes for applet configuration layout.

[George Vogiatzis]

gvgeo updated this revision to Diff 76908.
gvgeo marked an inline comment as not done.
gvgeo added a comment.


  Fixed margins.
  Unfortunatly the RTL layout has some issues, had to disable the use of 
available width for RTL layout, to stop the jumping from the scrollview.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27608?vs=76869=76908

BRANCH
  configscollcat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27608

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: gvgeo, #plasma, #vdg, filipf, ngraham
Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart