D27866: Make it compile against qt5.15. ::unite is deprecated.

This revision was automatically updated to reflect the committed changes. Closed by commit R123:9e3f9fb2c8cb: Make it compile against qt5.15. ::unite is deprecated. (authored by mlaurent). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

hpereiradacosta added a comment. In my opinion this should really go into a different decoration. Starting to have "styles inside styles" inside a single decoration is a UI mess. If you want to turn breeze into a theme engine and not a theme, then so be it, but one must go the full way.

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

paulm added a comment. In D27938#624385 , @ngraham wrote: > > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp whereby the "Draw a circle around close button" setting does not reset to Defaults properly. > > Would you

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

paulm added a comment. In D27938#624382 , @ngraham wrote: > Can you add a bit more information about what your goal is here? You're adding different icon styles for the titlebar buttons that you can use while still using the Breeze window

D27903: [applet/digital-clock] Show time zones in expanded representation too

apol added a comment. Looks much better! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27903 To: ngraham, #vdg, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mbehrendt created this revision. mbehrendt added a reviewer: mvourlakos. mbehrendt added a project: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mbehrendt requested review of this revision. REVISION SUMMARY The triangle indicating window grouping would

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

ngraham added a comment. > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp whereby the "Draw a circle around close button" setting does not reset to Defaults properly. Would you mind extracting this into its own patch and submitting it separately? Sounds like a

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

ngraham added reviewers: Breeze, ndavis. ngraham added a comment. Wow, looks like this was a lot of work! Can you add a bit more information about what your goal is here? You're adding different icon styles for the titlebar buttons that you can use while still using the Breeze window

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

paulm created this revision. paulm added a reviewer: hpereiradacosta. paulm added projects: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. paulm requested review of this revision. REVISION SUMMARY This implements as described at

D25324: [GTK Config] Add XSettingsd as a runtime dependency

ngraham added subscribers: jriddell, cfeck. ngraham added a comment. We can't add a new required dependency since dependencies are frozen in the stable branches. Not sure what the policy is regarding adding optional ones though. @cfeck/@jriddell? REPOSITORY R99 KDE Gtk Configuration Tool

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me and seems sane. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH font-style REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport,

D27107: [GTK Config] Remove redundant reparse configuration call

gikari added a comment. Ping! After D27904 this should be working. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27107 To: gikari, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26777: [App Style KCM] Port away from QDBusInterface

gikari added a comment. Ping! Do I sound reasonable? Any suggestions how can it be simplified without depending on `kde-gtk-config`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26777 To: gikari, #plasma Cc: apol, plasma-devel, Orage, LeGast00n,

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added a comment. Ping! Does it work for everybody? For me everything is OK. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck, ngraham,

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. Ok. So, can I land it or should I wait for other reviewers? Also, should I make the dependency `REQUIRED` or leave it optional? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL

D25324: [GTK Config] Add XSettingsd as a runtime dependency

eszlari added a comment. In D25324#624299 , @gikari wrote: > In D25324#624229 , @eszlari wrote: > > > This bug is not fixed by this patch. `xsettingsd` needs to be started in

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Ok, I see the issue. The question is if `Vendor Model` is not a bit stupid as a name for an output and if KWin/KWayland should not be a bit more intelligent about choosing a

D27677: feat: fix build after EDID changes in libkscreen

romangg added a comment. Is this now a bug fix or a feature? I would call it a refactor since there is no regression or prior bug and neither does it add a new feature. The feature was added in libkscreen. And please don't say `refactor: fix...` How about `refactor: incorporate prior

D10042: feat: parse EDID on the backend side

romangg added a comment. The idea to parse on the backend side is sound. Can you paste the output you get in a Wayland session? For me it shows the XWayland EDID of the outputs. INLINE COMMENTS > waylandbackend.cpp:81 > +auto device = output->outputDevice(); > +auto edid = new

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. In D25324#624229 , @eszlari wrote: > This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future). `xsettingsd` is started by

D27935: Make kwallet-pam work with pam_fscrypt

aacid updated this revision to Diff 77232. aacid added a comment. don't log the password to journald ^_^ REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27935?vs=77231=77232 BRANCH Plasma/5.18 REVISION DETAIL

D27935: Make kwallet-pam work with pam_fscrypt

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY fscrypt encrypts folders, you can use pam_fscrypt to auto-unencrypt some, for example your home folder. This means that the old

D25324: [GTK Config] Add XSettingsd as a runtime dependency

eszlari added a comment. > BUG: 418263 This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future). > FIXED-IN: 5.19 I would be nice, if this could make it to 5.18, so that `xsettingsd` would

D27563: [mobile/wifi] Use ScrollViewKCM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:83ce03a41117: [mobile/wifi] Use ScrollViewKCM (authored by nicolasfella). REPOSITORY R116 Plasma Network Management

D27823: Use consistent highlight

ngraham added a comment. Now I see no highlight effect at all. Does this work for you? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27823: Use consistent highlight

niccolove added a comment. Should now work? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77219. niccolove added a comment. remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77218=77219 BRANCH highlight (branched from master) REVISION DETAIL

D27824: Use consistent highlight

niccolove added a comment. Wait, I think I understood the reason REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D27824 To: niccolove, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77217. niccolove added a comment. remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77215=77217 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77218. niccolove added a comment. ops REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77217=77218 BRANCH highlight (branched from master) REVISION DETAIL

D25324: [GTK Config] Add XSettingsd as a runtime dependency

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma,

D27823: Use consistent highlight

ngraham added a comment. Does this work for you? I still see the old highlight. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27823: Use consistent highlight

ngraham added a comment. There we go, much better now. :) Reviewing... REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77215. niccolove added a comment. rebase x3 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77214=77215 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

davidre added a comment. Probably your arc diff base target thingy didn't switch and is on the old commit so this includes everything new on the master branch. Specify it manually with `arc diff master` or `arc diff origin/master` REPOSITORY R116 Plasma Network Management Applet REVISION

D27823: Use consistent highlight

niccolove added a comment. well fuck. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77214. niccolove added a comment. rebase x2 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77212=77214 BRANCH highlight (branched from master) REVISION DETAIL

D27915: Use breeze icons for categories

ngraham added a reviewer: apol. ngraham added a comment. Hmm, your before and after screenshots look identical to me. What's the reason for this? To make them look better in High DPI mode? I thought that was already fixed with D27515: Icon: fix rendering of image: urls on High DPI

D27823: Use consistent highlight

ngraham added a comment. you need to rebase on top of `master` from the remote. This looks to have been branched off of the state of master from last November or something. Try `git pull --rebase origin master` That should give you some merge conflicts that you can fix. REPOSITORY

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1d769841d53: Increase the size of system tray icon hitboxes on the System Tray Plasmoid (authored by The-Feren-OS-Dev, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D27823: Use consistent highlight

niccolove updated this revision to Diff 77212. niccolove added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77203=77212 BRANCH highlight (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 77210. The-Feren-OS-Dev added a comment. Redone, again. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=77209=77210 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27466

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 77209. The-Feren-OS-Dev added a comment. One more diff tweak to make it normal-er. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=77208=77209 REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 77208. The-Feren-OS-Dev added a comment. Rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75913=77208 REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27823: Use consistent highlight

ngraham added a comment. Now it needs a rebase, as there are merge conflicts. :) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27824: Use consistent highlight

This revision was automatically updated to reflect the committed changes. Closed by commit R97:24f2bd58bb5a: Use consistent highlight (authored by niccolove). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27824?vs=77002=77205 REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77203. niccolove added a comment. Fixed double declaration REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77004=77203 BRANCH highlight (branched from master) REVISION DETAIL