D27866: Make it compile against qt5.15. ::unite is deprecated.

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:9e3f9fb2c8cb: Make it compile against qt5.15. ::unite is 
deprecated. (authored by mlaurent).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27866?vs=77016=77246

REVISION DETAIL
  https://phabricator.kde.org/D27866

AFFECTED FILES
  src/advancedconfig.cpp
  src/advancedconfig.h
  src/sddmkcm.cpp
  src/themeconfig.cpp
  src/themeconfig.h

To: mlaurent, davidedmundson, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In my opinion this should really go into a different decoration. Starting to 
have "styles inside styles" inside a single decoration is a UI mess. 
  If you want to turn breeze into a theme engine and not a theme, then so be 
it, but one must go the full way. Not just essentially duplicating the code to 
render a different set of visually orthogonal buttons into the engine. The new 
buttons must have a different entry in the kcm. Not be selectable by an 
internal option.  See how decoration engines like aurorae implements different 
entries in decoration page as the way it should be.
  How is a new user supposed to discover that what she/he sees in the KCM is 
not the only set of icons she/he can chose ?
  Also on the code side, the current patch makes the code maintainability much 
more complicated.
  
  Now I am not the maintainer any more. So feel free to ignore my opinion here. 
  But I cannot +1 this, sorry. (although the idea is nice, design is nice, etc.)
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm added a comment.


  In D27938#624385 , @ngraham wrote:
  
  > > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp 
whereby the "Draw a circle around close button" setting does not reset to 
Defaults properly.
  >
  > Would you mind extracting this into its own patch and submitting it 
separately? Sounds like a good fix, regardless of whether or not this patch 
gets merged in its current form or in another form. In general it's best to 
have each patch/commit do only one thing and not combine new features and 
bugfixes.
  
  
  Sure, I can do that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm added a comment.


  In D27938#624382 , @ngraham wrote:
  
  > Can you add a bit more information about what your goal is here? You're 
adding different icon styles for the titlebar buttons that you can use while 
still using the Breeze window decoration theme? Before-and-after screenshots 
would help too. See also 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots
  
  
  Hi Nate. Yes, the changes allow you to have different sets of icon styles for 
the titlebar buttons, while still keeping the overall Breeze style. I have 
updated the summary. The motivation to add it was mainly to add the 'Classic' 
button icon style, while also preserving the 'Oxygen' style of button icons for 
those who like it. I have added screenshots to the summary, and will maybe make 
another video to show it tomorrow.
  
  > Could you add a few words regarding why you think adding this option to the 
Breeze window decoration theme is right right place for this, as opposed to 
creating a new window decoration theme or just changing the default appearance? 
If there's something wrong with the current button appearance, maybe we should 
just change it. If not, and this is just to satisfy people with different 
aesthetic preferences, why not make a different window decoration theme?
  
  I added these options to the Breeze window decoration because I liked the 
overall Breeze style (shading, colours, configurability etc.), just not the 
icons for the window control buttons (I just don't think the 'Oxygen' style 
buttons are logical and often initially found myself confused by them, not 
knowing whether an up-arrow means restore or maximize, not knowing whether a 
down-arrow means minimize or restore, and not having a clue what the diamond 
means! I tried to replace it with buttons that visually describe the outcome of 
the click). However, I know there are some people attached to the 
'Oxygen'-style buttons so didn't just want to arrogantly remove them or 
arrogantly change defaults without some discussion or demonstration (which I 
hope this provides).
  
  With regards to why not a separate theme, that was actually my original plan, 
but I wanted to use Breeze as the base. When I asked 3 years ago if there was 
an Aurorae theme for Breeze that I could edit I was told there was not and that 
it was just C++; is this still the case today? Can the Breeze theme be easily 
forked and redistributed in the GetHotNewStuff dialogue box? If so, how, and 
where to share? I also wanted to change the Application Style as well as the 
Window Decorations (i.e. the style of buttons to dock/undock and close etc. 
within applications with dockable panes). Can you easily fork, redistribute and 
download new Application Styles in the GetHotNewStuff dialogue box as well?
  
  With regards to why not just change the default titlebar button icons. Yes, 
of course I do indeed think the default titlebar button icons should be changed 
to what I have called 'Classic' by default :). However, I do realise that 
defaults can be contentious things that can cause a lot of debate!! With this 
patch people can at least see the 'Classic' style for themselves and discuss 
before committing to anything new.
  
  I also think the tiny square minimize icon with 'Classic' visually fits in 
nicely with the Icons Only Task Manager.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27903: [applet/digital-clock] Show time zones in expanded representation too

[Aleix Pol Gonzalez]

apol added a comment.


  Looks much better!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27903

To: ngraham, #vdg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

[Marcus Behrendt]

mbehrendt created this revision.
mbehrendt added a reviewer: mvourlakos.
mbehrendt added a project: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mbehrendt requested review of this revision.

REVISION SUMMARY
  The triangle indicating window grouping would not move to the other side.
  Like for the BackLayer this is done for the corresponding part of the 
FrontLayer

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

AFFECTED FILES
  indicators/org.kde.latte.plasma/package/ui/FrontLayer.qml

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Nathaniel Graham]

ngraham added a comment.


  > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp 
whereby the "Draw a circle around close button" setting does not reset to 
Defaults properly.
  
  Would you mind extracting this into its own patch and submitting it 
separately? Sounds like a good fix, regardless of whether or not this patch 
gets merged in its current form or in another form. In general it's best to 
have each patch/commit do only one thing and not combine new features and 
bugfixes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Nathaniel Graham]

ngraham added reviewers: Breeze, ndavis.
ngraham added a comment.


  Wow, looks like this was a lot of work!
  
  Can you add a bit more information about what your goal is here? You're 
adding different icon styles for the titlebar buttons that you can use while 
still using the Breeze window decoration theme? Before-and-after screenshots 
would help too. See also 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots
  
  Could you add a few words regarding why you think adding this option to the 
Breeze window decoration theme is right right place for this, as opposed to 
creating a new window decoration theme or just changing the default appearance? 
If there's something wrong with the current button appearance, maybe we should 
just change it. If not, and this is just to satisfy people with different 
aesthetic preferences, why not make a different window decoration theme?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm created this revision.
paulm added a reviewer: hpereiradacosta.
paulm added projects: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
paulm requested review of this revision.

REVISION SUMMARY
  This implements as described at https://phabricator.kde.org/T12793
  
  Modifications have been made to both kdecoration and kstyle so that window 
decorations for both normal windows and MDI applications will be affected, with 
new designs placed in libbreezecommon as are shared between both. A 
configuration in the Breeze window decoration settings will affect both 
kdecoration and kstyle so .kcfg files in each have been updated. 'Oxygen' 
remains the default style as at present.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/breezeconfigwidget.cpp
  kdecoration/config/ui/breezeconfigurationui.ui
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezerenderdecorationbuttonicon.cpp
  libbreezecommon/breezerenderdecorationbuttonicon.h
  libbreezecommon/breezestyleclassic.cpp
  libbreezecommon/breezestyleclassic.h
  libbreezecommon/breezestyleoxygen.cpp
  libbreezecommon/breezestyleoxygen.h
  libbreezecommon/breezestyleredmond.cpp
  libbreezecommon/breezestyleredmond.h

To: paulm, hpereiradacosta
Cc: plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, 
ndavis, ZrenBot, firef, ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Nathaniel Graham]

ngraham added subscribers: jriddell, cfeck.
ngraham added a comment.


  We can't add a new required dependency since dependencies are frozen in the 
stable branches. Not sure what the policy is regarding adding optional ones 
though. @cfeck/@jriddell?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me and seems sane.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  font-style

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson, ngraham
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: [GTK Config] Remove redundant reparse configuration call

[Mikhail Zolotukhin]

gikari added a comment.


  Ping! After D27904  this should be 
working.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26777: [App Style KCM] Port away from QDBusInterface

[Mikhail Zolotukhin]

gikari added a comment.


  Ping! Do I sound reasonable? Any suggestions how can it be simplified without 
depending on `kde-gtk-config`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26777

To: gikari, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

gikari added a comment.


  Ping! Does it work for everybody? For me everything is OK.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari added a comment.


  Ok. So, can I land it or should I wait for other reviewers? Also, should I 
make the dependency `REQUIRED` or leave it optional?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Peter Eszlari]

eszlari added a comment.


  In D25324#624299 , @gikari wrote:
  
  > In D25324#624229 , @eszlari 
wrote:
  >
  > > This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  >
  >
  > `xsettingsd` is started by the daemon itself, if it's not instantiated 
already. The daemon itself launches at startup, because it is a kded module.
  
  
  You are right, sorry for the noise! I must have mixed up someting while 
testing it on the Kubuntu 20.04 preview.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27675: feat: avoid duplicated text when assembling user-facing output names

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Ok, I see the issue. The question is if `Vendor Model` is not a bit stupid as 
a name for an output and if KWin/KWayland should not be a bit more intelligent 
about choosing a name. Then it could make sense again to have `(Vendor model)` 
appended afterwards. For example I have here a monitor for testing which is 
called on the website: PROLITE XUB2395WSU-B1. But KWin returns as Vendor "IVM" 
and as name "DP-1-PL2395W/11638JJ60250".

INLINE COMMENTS

> utils.cpp:36
>  {
> +const auto append = [](const QString , const QString ) -> QString {
> +const auto s = b.trimmed();

Please don't use single character variable names. Also can this be made more 
explicit? I can't guess directly what the meaning of a, b and s is. I don't 
think it is that generic, is it?

> utils.cpp:61
>  }
> -if (!name.trimmed().isEmpty()) {
> -return name + QLatin1Char('(') + output->name() + 
> QLatin1Char(')');
> +// Don't append (ConnectorName) if its the same as "VendorName 
> ModelName"
> +if (!name.isEmpty() && name != output->name()) {

Full-stop in the end.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27675

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27677: feat: fix build after EDID changes in libkscreen

[Roman Gilg]

romangg added a comment.


  Is this now a bug fix or a feature? I would call it a refactor since there is 
no regression or prior bug and neither does it add a new feature. The feature 
was added in libkscreen. And please don't say `refactor: fix...` How about 
`refactor: incorporate prior libkscreen EDID changes`?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27677

To: dvratil, #plasma
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D10042: feat: parse EDID on the backend side

[Roman Gilg]

romangg added a comment.


  The idea to parse on the backend side is sound. Can you paste the output you 
get in a Wayland session? For me it shows the XWayland EDID of the outputs.

INLINE COMMENTS

> waylandbackend.cpp:81
> +auto device = output->outputDevice();
> +auto edid = new Edid::Private;
> +edid->vendorName = device->manufacturer();

Let the backend populate the Private here is unusual, or is it not? On the 
other side it makes sense. Let the consumer only access the public interface 
and the backend access the private one. I don't know what's the commonly used 
approach to that in Qt dev. Out of interest you can say? In any case we can 
leave it like that for now.

> waylandbackend.cpp:90
> +edid->checksum = QString::fromLatin1(device->uuid());
> +edid->valid = true;
> +

A WaylandOutput::edid() function should be put in the WaylandOutput class.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari added a comment.


  In D25324#624229 , @eszlari wrote:
  
  > This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  
  
  `xsettingsd` is started by the daemon itself, if it's not instantiated 
already.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27935: Make kwallet-pam work with pam_fscrypt

[Albert Astals Cid]

aacid updated this revision to Diff 77232.
aacid added a comment.


  don't log the password to journald ^_^

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27935?vs=77231=77232

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27935

AFFECTED FILES
  pam_kwallet.c

To: aacid
Cc: security-team, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27935: Make kwallet-pam work with pam_fscrypt

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  fscrypt encrypts folders, you can use pam_fscrypt to auto-unencrypt
  some, for example your home folder.
  
  This means that the old code of kwallet-pam would not work
  since it tries to read/write the salt file at the auth step.
  
  This change moves that from the auth step to the open step, sadly that
  means we need to keep the password in (pam "secure") memory for a while more.

TEST PLAN
  I can now login into my session and the kwallet password prompt is not shown

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27935

AFFECTED FILES
  pam_kwallet.c

To: aacid
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Peter Eszlari]

eszlari added a comment.


  > BUG: 418263
  
  This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  
  > FIXED-IN: 5.19
  
  I would be nice, if this could make it to 5.18, so that `xsettingsd` would 
end up on the Kubuntu 20.04 ISO image (https://phabricator.kde.org/T12753).

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27563: [mobile/wifi] Use ScrollViewKCM

[Nicolas Fella]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:83ce03a41117: [mobile/wifi] Use ScrollViewKCM (authored 
by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27563?vs=76137=77222

REVISION DETAIL
  https://phabricator.kde.org/D27563

AFFECTED FILES
  mobile/wifi/package/contents/ui/main.qml

To: nicolasfella, #plasma, jgrulich, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham added a comment.


  Now I see no highlight effect at all.
  
  Does this work for you?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Should now work?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77219.
niccolove added a comment.


  remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77218=77219

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Wait, I think I understood the reason

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77217.
niccolove added a comment.


  remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77215=77217

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77218.
niccolove added a comment.


  ops

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77217=77218

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham added a comment.


  Does this work for you? I still see the old highlight.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham added a comment.


  There we go, much better now. :) Reviewing...

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77215.
niccolove added a comment.


  rebase x3

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77214=77215

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[David Redondo]

davidre added a comment.


  Probably your arc diff base target thingy didn't switch and is on the old 
commit so this includes everything new on the master branch. Specify it 
manually with `arc diff master` or `arc diff origin/master`

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  well fuck.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77214.
niccolove added a comment.


  rebase x2

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77212=77214

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

[Nathaniel Graham]

ngraham added a reviewer: apol.
ngraham added a comment.


  Hmm, your before and after screenshots look identical to me.
  
  What's the reason for this? To make them look better in High DPI mode? I 
thought that was already fixed with D27515: Icon: fix rendering of image: urls 
on High DPI 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma, apol
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham added a comment.


  you need to rebase on top of `master` from the remote. This looks to have 
been branched off of the state of master from last November or something.
  
  Try `git pull --rebase origin master` That should give you some merge 
conflicts that you can fix.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d1d769841d53: Increase the size of system tray icon 
hitboxes on the System Tray Plasmoid (authored by The-Feren-OS-Dev, committed 
by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77210=77213

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77212.
niccolove added a comment.


  rebase

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77203=77212

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77210.
The-Feren-OS-Dev added a comment.


  Redone, again.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77209=77210

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77209.
The-Feren-OS-Dev added a comment.


  One more diff tweak to make it normal-er.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77208=77209

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77208.
The-Feren-OS-Dev added a comment.


  Rebased on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75913=77208

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Nathaniel Graham]

ngraham added a comment.


  Now it needs a rebase, as there are merge conflicts. :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:24f2bd58bb5a: Use consistent highlight (authored by 
niccolove).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27824?vs=77002=77205

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77203.
niccolove added a comment.


  Fixed double declaration

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77004=77203

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart