Moving bugzilla components

As a reminder, bugzilla components should not be moved without prior discussion with maintainers. @nate please inform everyone of the bulk changes made and we'll see which we keep. David

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:4897 > + > +auto palette = toolbar->palette(); > +palette.setColor( QPalette::Window, > _toolsAreaManager->background(widget) ); This should move in the if condition below. Creating a new palette (even by

D27669: [kstyle] Tools area

hpereiradacosta added a comment. I noticed there seems to be something wrong in the color logic when - active window decoration color is the same as the main window decoration - inactive window decoration is different (essentially the opposite as current breeze theme) In that

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 77379. pdabrowski added a comment. more context lines in diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77378=77379 REVISION DETAIL https://phabricator.kde.org/D27972 AFFECTED FILES

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski created this revision. pdabrowski added reviewers: Plasma, zzag, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY Fix for NightColor plasmoid active/passive status and its tooltip subtext.

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > cblack wrote in breeze.h:104 > This is part of the visual changes of the tools area design—extra spacing as > to prevent ugly border on border action. Why would this be more "ugly" as when there was no toolarea ? can you post a

D27669: [kstyle] Tools area

hpereiradacosta added a comment. A few more comments, but all in all seems to be getting there (beside the options to disable and/or to define the colors based on the QPalette and not the decorations) INLINE COMMENTS > breezehelper.cpp:1631 > + > +QMainWindow* window; > +

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breeze.h:104 > // toolbars > -ToolBar_FrameWidth = 2, > +ToolBar_FrameWidth = 6, > ToolBar_HandleExtent = 10, Is that the reason why the toolbar moves down and to the left? If so it seems not to do your intended

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breeze.h:104 > This change seems unrelated to introducing a tool area. > I would move it to a separate commit and review request. In fact there are > already complains about there being too much space wasted in breeze.

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77376. cblack marked 17 inline comments as done. cblack added a comment. Address feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77375=77376 BRANCH cblack/toolsarea REVISION DETAIL

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77375. cblack added a comment. Load animation values from KDecoration REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77334=77375 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27958: [SystemTray] Fix item size for very narrow panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:85f646eb5649: [SystemTray] Fix item size for very narrow panel (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27958?vs=77321=77370

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. In D27958#625431 , @broulik wrote: > Not sure if it is just me but the vertical alignment looks slightly off > F8169131: Screenshot_20200310_172654.PNG > Or maybe that's the

D27958: [SystemTray] Fix item size for very narrow panel

ngraham added a comment. Nice, drag-and-drop now correctly shows the menu for the case of dragging an icon from Kickoff or the task manager. However dragging a URL still doesn't show the menu; it just downloads the entire page. We need the drop menu in this case because it's probably more

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8aa96ac72dbd: Solid-device-automounter/kcm: show disconnected known device when disconnecting… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27971: Solid-device-automounter/kcm: correctly update automountOn

meven created this revision. meven added reviewers: bport, Plasma, ervin, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Open kcmshell5 device_automounter_kcm Play with the checkbox "Automatically

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari closed this revision. gikari added a comment. https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma, cblack, apol, jgrulich, ngraham Cc: cfeck,

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezehelper.cpp:1613 > + > +auto castedWidget = const_cast(widget); > + as far as I can tell you do not need the const_cast. just check the relevant methods to take a const as input. Const_cast must really be avoided as much as

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77367. meven added a comment. Remove bad commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=77366=77367 BRANCH arcpatch-D27024 REVISION DETAIL https://phabricator.kde.org/D27024 AFFECTED FILES

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77366. meven added a comment. Solid-device-automounter/kcm: correctly update automountOn REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=77365=77366 BRANCH stash{0} REVISION DETAIL

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77365. meven added a comment. Add the recently disconnected device at the end of the list of devices REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=77361=77365 BRANCH arcpatch-D27024 REVISION DETAIL

D27957: [GTK Config] Port all settings to KConfigWatcher

ngraham added a comment. So much less code! Seems to work well for me. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27957 To: gikari, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D25324: [GTK Config] Add XSettingsd as a runtime dependency

jriddell added a comment. I don't think this is adding a new dependency just highlighting that there is one, so it's good to add to stable branches REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL

D27958: [SystemTray] Fix item size for very narrow panel

broulik added a comment. Not sure if it is just me but the vertical alignment looks slightly off F8169131: Screenshot_20200310_172654.PNG Or maybe that's the random different sizes REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27956: [Various KCMs] Notify about changes in GTK related settings

ngraham accepted this revision. ngraham added reviewers: ervin, bport, meven. ngraham added a comment. This revision is now accepted and ready to land. I'm finding myself wondering why we don't just make everything notify by default. REPOSITORY R119 Plasma Desktop BRANCH

D27669: [kstyle] Tools area

hpereiradacosta added a comment. In D27669#625338 , @ngraham wrote: > FWIW, I'm okay making this configurable, as I do admit that it could be a very polarizing change. We do intend to change the default Breeze color scheme itself to use a light

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77361. meven added a comment. Rebase on master, and follow removal of singleton REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=75847=77361 BRANCH arcpatch-D27024 REVISION DETAIL

Plasma 5.18.3

Plasma 5.18.3 is now released https://www.kde.org/announcements/plasma-5.18.3.php

D27960: Make it possible to scroll through the padding

ngraham added a comment. This doesn't work well for me with a touchpad. The side padding regions clearly accept scroll events now, but the actual scroll behavior is jerky and inconsistent. :( Feels like events are getting dropped or interfering with one another. REPOSITORY R169 Kirigami

D27669: [kstyle] Tools area

ngraham added a comment. In D27669#625350 , @davidre wrote: > Or the window doesn't have a tool area? ;) Conceptually, we're considering the titlebar to be always a part of the window's Tools Area. :) But yes, semantics aside, I

D27669: [kstyle] Tools area

davidre added a comment. In D27669#625349 , @ngraham wrote: > In D27669#625187 , @davidre wrote: > > > Again why are we introducing this separator line and even drawing it under normal titlebars?

D27669: [kstyle] Tools area

ngraham added a comment. In D27669#625187 , @davidre wrote: > Again why are we introducing this separator line and even drawing it under normal titlebars? Compared to before > F8168549: grafik.png

D27669: [kstyle] Tools area

ngraham added a comment. FWIW, I'm okay making this configurable, as I do admit that it could be a very polarizing change. We do intend to change the default Breeze color scheme itself to use a light gray for the titlebar, but yes, I understand that people who prefer very dark or bold

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:4382 > +QPixmap pixmap = toolButtonOption->icon.pixmap( iconSize, > iconMode, iconState ); > +if (_helper->isInToolsArea(widget)) { > +

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Some more comments about the code. INLINE COMMENTS > breeze.h:104 > // toolbars > -ToolBar_FrameWidth = 2, > +ToolBar_FrameWidth = 6, > ToolBar_HandleExtent = 10, This change seems unrelated to introducing a tool area. I

D27669: [kstyle] Tools area

hpereiradacosta added a comment. In D27669#625270 , @IlyaBizyaev wrote: > For color schemes that have contrasting titlebar and content colors, this patch makes application headers look giant... > F8168755: photo_2020-03-10_15-09-54.jpg

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 130 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/130/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Mar 2020 12:45:13 + Build duration: 14 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/58/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Mar 2020 12:47:21 + Build duration: 11 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 39 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/39/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Mar 2020 12:42:14 + Build duration: 3 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 284 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/284/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Mar 2020 12:45:12 + Build duration: 6 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 63 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/63/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Mar 2020 12:42:14 + Build duration: 1 min 6 sec and counting CONSOLE OUTPUT

D27968: notifications: on mobile align popup to top center

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3609f66a98bc: notifications: on mobile align popup to top center (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27968?vs=77346=77347

D27968: notifications: on mobile align popup to top center

bshah created this revision. bshah added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY any other position doesn't really make sense on mobile, so ignore popup location settings

D27669: [kstyle] Tools area

IlyaBizyaev added a comment. For color schemes that have contrasting titlebar and content colors, this patch makes application headers look giant... F8168755: photo_2020-03-10_15-09-54.jpg It does look good with the proposed default color palette,

Re: Proposal: Dynamic Wallpapers in Plasma

On 3/10/20 1:27 PM, Kai Uwe Broulik wrote: There's QImageIOHandler::Description which can store arbitrary text data in an image. You reckon QImageIOHandler could be extended to support whatever metadata you need to read/write? Yes, it would be fine for our specific use case. We're interested

Re: Proposal: Dynamic Wallpapers in Plasma

Hi, you know I'm a big fan of your dynamic wallpaper work :) > It's worth to point out that there is an upstream patch to add one [2]. Given 5.15 is feature frozen already, I think we won't see this anytime soon. It could be worth a try contacting the author if they're willing to include it

Proposal: Dynamic Wallpapers in Plasma

Hi, I would like to propose a dynamic wallpaper plugin for KDE Plasma [1]. As the name suggests, the plugin updates the background continuously to reflect the user's current light situation. Besides being eye-candy, it can be useful for a Night Mode (if Plasma gets one). The HEIF file

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

cfeck added a comment. See https://bugreports.qt.io/browse/QTBUG-56547 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. In D27808#625229 , @ahmadsamir wrote: > In D27808#625227 , @cfeck wrote: > > > We already lost fractional point sizes when porting from KFontDialog to QFontDialog. > >

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. In D27808#625227 , @cfeck wrote: > We already lost fractional point sizes when porting from KFontDialog to QFontDialog. Yeah, I never understood why they opted for integer values only (I will dig in upstream

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

cfeck added a comment. We already lost fractional point sizes when porting from KFontDialog to QFontDialog. Best approach is to add the KFontDialog to the platform plugin (and also the old KColorDialog while you are at it), or upstream our features to Qt. Btw, I set Toolbar font to a

D27823: Use consistent highlight

gvgeo added a comment. Couple of notes, as I'm not sure what the aim was here. I have not test it, take them with a grain of salt. - Highlight area was changed, without changing the click area. - Connect button pop up area change, was not documented. - Highlight svg is not consistent

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. In D27808#625186 , @meven wrote: > In D27808#625181 , @ahmadsamir wrote: > > > And another question, "General", "Menu", "Toolbar", how many users actually set these

D27669: [kstyle] Tools area

davidre added a comment. Oh another thing I noticed: this doesn't work, when an app changes its color scheme rather than the default one. The toolbar is not updated. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidre,

D27669: [kstyle] Tools area

davidre added a comment. I removed the separator line for comparison: F8168553: grafik.png F8168557: Screenshot_20200310_095331.PNG I thought the goal was to have less separators (see the attached task and

D27669: [kstyle] Tools area

davidre added a comment. One other thing to consider, this looks really bad with everything else other than no border: F8168528: grafik.png F8168533: grafik.png > No border is now the default! Yes I

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. In D27808#625181 , @ahmadsamir wrote: > And another question, "General", "Menu", "Toolbar", how many users actually set these three to individual font families/styles/sizes? If anything this is just not relevant

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:109 > +window->setContentsMargins(0,1,0,0); > +} > +}); Maybe the decision whether to do this could only be made based on the colors of the active

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. And another question, "General", "Menu", "Toolbar", how many users actually set these three to individual font families/styles/sizes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson,