Moving bugzilla components

[David Edmundson]

As a reminder, bugzilla components should not be moved without prior
discussion with maintainers.

@nate please inform everyone of the bulk changes made and we'll see which
we keep.

David

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:4897
> +
> +auto palette = toolbar->palette();
> +palette.setColor( QPalette::Window, 
> _toolsAreaManager->background(widget) );

This should move in the if condition below. Creating a new palette (even by 
copy) is expensive. 
When you use the palette.color( QPalette::Window) later in line 4909, you 
should use the color directly instead, namely 
_toolsAreaManager->background(widget) (which you can evaluate here already 
before entering the if loop. This should be cheaper.

> breezestyle.cpp:4933
> +QRectF copy(widget->geometry());
> +copy.setTop(widget->childrenRect().top());
> +

another case where it is probably more correct to use option->rect directly.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  I noticed there seems to be something wrong in the color logic when
  
  - active window decoration color is the same as the main window decoration
  - inactive window decoration is different
  
  (essentially the opposite as current breeze theme)
  In that case, one would expect the inactive tool area to be colored and the 
active one not to be. It seems that neither are colored except for the menu bar.
  See: 
  F8169741: Screenshot_20200310_214627.png 

  corresponding to an *inactive* window in this modified color scheme (just for 
illustration purpose)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 77379.
pdabrowski added a comment.


  more context lines in diff

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27972?vs=77378=77379

REVISION DETAIL
  https://phabricator.kde.org/D27972

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski created this revision.
pdabrowski added reviewers: Plasma, zzag, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pdabrowski requested review of this revision.

REVISION SUMMARY
  Fix for NightColor plasmoid active/passive status and its tooltip subtext.
  Especially noticeable when the tray icon is set to "Show when relevant".

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27972

AFFECTED FILES
  applets/nightcolor/package/contents/ui/main.qml

To: pdabrowski, #plasma, zzag, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> cblack wrote in breeze.h:104
> This is part of the visual changes of the tools area design—extra spacing as 
> to prevent ugly border on border action.

Why would this be more "ugly" as when there was no toolarea ? can you post a 
screeshot of the said ugliness ?

> breezetoolsareamanager.cpp:15
> +ToolsAreaManager::~ToolsAreaManager() {
> +for (auto entry : animationMap) {
> +delete entry.foregroundColorAnimation;

This is not needed. Since all animations are created as children of the 
ToolsAreaManager, they should be deleted automatically when this one is 
destroyed. 
This way you can simply remove the class destructor altogether and rely on the 
default one (from QObject).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  A few more comments, but all in all seems to be getting there (beside the 
options to disable and/or to define the colors based on the QPalette and not 
the decorations)

INLINE COMMENTS

> breezehelper.cpp:1631
> +
> +QMainWindow* window;
> +if ((window = grabMainWindow(widget))) {

Coding style: 
I would rather: 
auto window = grabMainWindow( widget );
if( window ) …
This way you avoid the double () and the seemingly uninitialized window.

> breezehelper.cpp:1644
> +auto checkMenubarInToolsArea = [grabMainWindow](const QWidget 
> *widget) {
> +QMainWindow* window;
> +if ((window = grabMainWindow(widget))) {

Same remark.

> hpereiradacosta wrote in breezehelper.cpp:1613
> as far as I can tell you do not need the const_cast. just check the relevant 
> methods to take a const as input. 
> Const_cast must really be avoided as much as possible. 
> I see that it is needed just for the call to window->toolBarArea. If so, just 
> do the const_cast there and keep all the rest const.
> (window->toolBarArea(const_cast(toolbar)))

Not really done. The only place where you need the const_cast is in the 
window->toolbarArea part. I would do it there and there only.  (line 1637) all 
the other call to toolbar-> work with a const.

> breezestyle.cpp:4352
>  
> +QPalette::ColorRole textRole( QPalette::ButtonText );
> +if( flat ) textRole = ( ((hasFocus&) || (state & 
> State_Sunken))&&!mouseOver) ? QPalette::HighlightedText: QPalette::WindowText;

Why has this code moved ? As far as I can tell it is used only line 4396, and 
so the initialization should remain in the corresponding if block.

> cblack wrote in breezestyle.cpp:4382
> If the tools area is enabled and a widget is in the tools area, then the 
> palette needs changing. It is ugly, but that's what the best you can get when 
> KIconLoader ignores widget palettes.

Not at every paint event. You should check if kiconloader already have a 
customPalette, if it matches the one you want, and update (or reset) only when 
necessary.

> breezetoolsareamanager.cpp:139
> +this, [this]() {
> +emit this->toolbarUpdated();
> +});

more unnecessary "this->"
Please try to remove them all.

> breezetoolsareamanager.cpp:159
> +
> +void ToolsAreaManager::unregisterWidget(QWidget *widget)
> +{

you should also remove the widget from widgetsWithPaletteForToolsAreaSet

> breezetoolsareamanager.h:19
> +public:
> +explicit ToolsAreaManager(QObject *parent = nullptr, Helper* helper 
> = nullptr);
> +~ToolsAreaManager();

you don't need the default arguments.
and in fact passing nullptr for helper will crash the code everywhere.

> breezetoolsareamanager.h:28
> +
> +QMap animationMap;
> +QList widgetsWithPaletteForToolsAreaSet;

don't put members public. Members should be private, and proper 
accessors/modifiers should be added.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> breeze.h:104
>  // toolbars
> -ToolBar_FrameWidth = 2,
> +ToolBar_FrameWidth = 6,
>  ToolBar_HandleExtent = 10,

Is that the reason why the toolbar moves down and to the left? If so it seems 
not to do your intended effect. I agree with Hugo regardless that this is an 
unrelated change

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breeze.h:104
> This change seems unrelated to introducing a tool area. 
> I would move it to a separate commit and review request. In fact there are 
> already complains about there being too much space wasted in breeze. These 
> extra 4 pixels don't go in the right direction (and again: are not needed for 
> this patch as far as I can tell)

This is part of the visual changes of the tools area design—extra spacing as to 
prevent ugly border on border action.

> hpereiradacosta wrote in breezehelper.h:31
> Not needed as far as I can tell (none of your changes in this file require 
> QToolbar)

This is necessary to compile.

> hpereiradacosta wrote in breezestyle.cpp:4382
> updating the palette in every paint event (and calling resetPalette()) will 
> be very innefficient. You need to track whether the palette actually needs 
> change before calling these.

If the tools area is enabled and a widget is in the tools area, then the 
palette needs changing. It is ugly, but that's what the best you can get when 
KIconLoader ignores widget palettes.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77376.
cblack marked 17 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77375=77376

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 77375.
cblack added a comment.


  Load animation values from KDecoration

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77334=77375

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:85f646eb5649: [SystemTray] Fix item size for very narrow 
panel (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27958?vs=77321=77370

REVISION DETAIL
  https://phabricator.kde.org/D27958

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka added a comment.


  In D27958#625431 , @broulik wrote:
  
  > Not sure if it is just me but the vertical alignment looks slightly off
  >  F8169131: Screenshot_20200310_172654.PNG 

  >  Or maybe that's the random different sizes
  
  
  This is just an illusion. I checked and literally counted pixels, centers of 
icons are aligned (both horizonaly and vertically). "de" icon is visually 
"heavier" at the bottom, the arrow on the right is heavier on top which makes 
impresion that these two are not aligned.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Nathaniel Graham]

ngraham added a comment.


  Nice, drag-and-drop now correctly shows the menu for the case of dragging an 
icon from Kickoff or the task manager. However dragging a URL still doesn't 
show the menu; it just downloads the entire page. We need the drop menu in this 
case because it's probably more common to want to create a link to the page 
than it is to download the entire thing.
  
  If introspecting the mimetype of every URL is too costly, could we maybe 
short-circuit the logic if the URL scheme is HTTP or HTTPS?
  
  Also I notice that the cursor still shows a plus sign icon when dragging a 
local file, even though it will be moved, not copied.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8aa96ac72dbd: Solid-device-automounter/kcm: show 
disconnected known device when disconnecting… (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27024?vs=77367=77369

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma, ervin, crossi, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27971: Solid-device-automounter/kcm: correctly update automountOn

[Méven Car]

meven created this revision.
meven added reviewers: bport, Plasma, ervin, crossi, hchain.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  Open kcmshell5 device_automounter_kcm
  Play with the checkbox "Automatically mount..." and see that the corrsponding 
columns below are enabled/disabled.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27971

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp

To: meven, bport, #plasma, ervin, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari closed this revision.
gikari added a comment.


  https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.cpp:1613
> +
> +auto castedWidget = const_cast(widget);
> +

as far as I can tell you do not need the const_cast. just check the relevant 
methods to take a const as input. 
Const_cast must really be avoided as much as possible. 
I see that it is needed just for the call to window->toolBarArea. If so, just 
do the const_cast there and keep all the rest const.
(window->toolBarArea(const_cast(toolbar)))

> hpereiradacosta wrote in breezestyle.cpp:4579
> Are you sure about the logic here ? geometry is relative to the parent 
> corrdinate system while childrenRect is relative to current widget. 
> Also, I would as expected that opt->rect would have been enough in any case 
> without the need to resort to the widget accessors

Here at least, using opt->rect directly (no need for the copy), fixes the 
multiple toolbar issue, with no regression elsewhere.
No regression on the menubar empty area either.

> breezestyle.cpp:4890
> +{
> +auto toolbar = const_cast(qobject_cast QToolBar*>(widget));
> +

as far as I can tell you dont need the cast to QToolbar. Just use the widget.
(and in any case if you use the toolbar you must make sure that the case 
succeeded.)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

meven updated this revision to Diff 77367.
meven added a comment.


  Remove bad commit

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27024?vs=77366=77367

BRANCH
  arcpatch-D27024

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma, ervin, crossi, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

meven updated this revision to Diff 77366.
meven added a comment.


  Solid-device-automounter/kcm: correctly update automountOn

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27024?vs=77365=77366

BRANCH
  stash{0}

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma, ervin, crossi, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

meven updated this revision to Diff 77365.
meven added a comment.


  Add the recently disconnected device at the end of the list of devices

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27024?vs=77361=77365

BRANCH
  arcpatch-D27024

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma, ervin, crossi, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Nathaniel Graham]

ngraham added a comment.


  So much less code! Seems to work well for me.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27957

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Jonathan Riddell]

jriddell added a comment.


  I don't think this is adding a new dependency just highlighting that there is 
one, so it's good to add to stable branches

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Kai Uwe Broulik]

broulik added a comment.


  Not sure if it is just me but the vertical alignment looks slightly off
  F8169131: Screenshot_20200310_172654.PNG 

  Or maybe that's the random different sizes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27956: [Various KCMs] Notify about changes in GTK related settings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added reviewers: ervin, bport, meven.
ngraham added a comment.
This revision is now accepted and ready to land.


  I'm finding myself wondering why we don't just make everything notify by 
default.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  notify-about-changes-in-gtk-related-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27956

To: gikari, #plasma, ngraham, ervin, bport, meven
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D27669#625338 , @ngraham wrote:
  
  > FWIW, I'm okay making this configurable, as I do admit that it could be a 
very polarizing change. We do intend to change the default Breeze color scheme 
itself to use a light gray for the titlebar, but yes, I understand that people 
who prefer very dark or bold titlebar colors in an otherwise light color scheme 
might not like the change, and they should be able to disable this without 
ditching Breeze entirely.
  >
  > However it's also worth mentioning that there's been a persistent request 
for exactly that appearance, as some people really seem to like a 
strongly-colored top area and I anticipate that they'll enjoy using this with a 
color scheme like Honeycomb.
  
  
  I doubt it. did you actually try ? 
  The active window decoration and the highlight color are the same in honey 
comb. Meaning that you have essentially no more mouse-over effect or focus 
effects in toolbars and menubars (see:

INLINE COMMENTS

> breezestyle.cpp:4579
> +
> +QRectF copy(widget->geometry());
> +copy.setTop(widget->childrenRect().top());

Are you sure about the logic here ? geometry is relative to the parent 
corrdinate system while childrenRect is relative to current widget. 
Also, I would as expected that opt->rect would have been enough in any case 
without the need to resort to the widget accessors

> breezestyle.cpp:4910
> +
> +QRectF copy(widget->geometry());
> +copy.setTop(widget->childrenRect().top() - 10);

Same remark as above.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

meven updated this revision to Diff 77361.
meven added a comment.


  Rebase on master, and follow removal of singleton

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27024?vs=75847=77361

BRANCH
  arcpatch-D27024

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma, ervin, crossi, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma 5.18.3

[Jonathan Riddell]

Plasma 5.18.3 is now released
https://www.kde.org/announcements/plasma-5.18.3.php

D27960: Make it possible to scroll through the padding

[Nathaniel Graham]

ngraham added a comment.


  This doesn't work well for me with a touchpad. The side padding regions 
clearly accept scroll events now, but the actual scroll behavior is jerky and 
inconsistent. :( Feels like events are getting dropped or interfering with one 
another.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27960

To: apol, #kirigami, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  In D27669#625350 , @davidre wrote:
  
  > Or the window doesn't have a tool area? ;)
  
  
  Conceptually, we're considering the titlebar to be always a part of the 
window's Tools Area. :)
  
  But yes, semantics aside, I think we agree.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  In D27669#625349 , @ngraham wrote:
  
  > In D27669#625187 , @davidre 
wrote:
  >
  > > Again why are we introducing this separator line and even drawing it 
under normal titlebars? Compared to before
  > >  F8168549: grafik.png 
  >
  >
  > As a part of T11661: Replace framed views with single-pixel separator lines 
. The general idea is to move away from 
using framed views and instead use single-pixel lines to separate logical 
window regions (e.g tools area on top, sidebar on left, main content view on 
right, etc).
  >
  > The extra line is designed to look good when both the Tools Area and the 
window background color are gray, but different shades of it. So I would agree 
with you that it is indeed unnecessary when the Tools Area's color is similar 
or identical to the line's color, or strongly different from the window 
background color--i.e. as in the current default Breeze color scheme. I'd be 
okay not drawing it in this case.
  
  
  Or the window doesn't have a tool area? ;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  In D27669#625187 , @davidre wrote:
  
  > Again why are we introducing this separator line and even drawing it under 
normal titlebars? Compared to before
  >  F8168549: grafik.png 
  
  
  As a part of T11661: Replace framed views with single-pixel separator lines 
. The general idea is to move away from 
using framed views and instead use single-pixel lines to separate logical 
window regions (e.g tools area on top, sidebar on left, main content view on 
right, etc).
  
  The extra line is designed to look good when both the Tools Area and the 
window background color are gray, but different shades of it. So I would agree 
with you that it is indeed unnecessary when the Tools Area's color is similar 
or identical to the line's color, or strongly different from the window 
background color--i.e. as in the current default Breeze color scheme. I'd be 
okay not drawing it in this case.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  FWIW, I'm okay making this configurable, as I do admit that it could be a 
very polarizing change. We do intend to change the default Breeze color scheme 
itself to use a light gray for the titlebar, but yes, I understand that people 
who prefer very dark or bold titlebar colors in an otherwise light color scheme 
might not like the change, and they should be able to disable this without 
ditching Breeze entirely.
  
  However it's also worth mentioning that there's been a persistent request for 
exactly that appearance, as some people really seem to like a strongly-colored 
top area and I anticipate that they'll enjoy using this with a color scheme 
like Honeycomb.
  
  Also, automatically disabling the feature when using a window border setting 
other than "No borders" seems reasonable, unless we want to also make the 
borders look visually distinct from the content area and stop trying to blend 
in.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:4382
> +QPixmap pixmap = toolButtonOption->icon.pixmap( iconSize, 
> iconMode, iconState );
> +if (_helper->isInToolsArea(widget)) {
> +KIconLoader::global()->setCustomPalette(widget->palette());

updating the palette in every paint event (and calling resetPalette()) will be 
very innefficient. You need to track whether the palette actually needs change 
before calling these.

> breezestyle.cpp:4894
> +toolbar->setPalette(toolbar->parentWidget()->palette());
> +return true;
> +}

Same remark. This is very innefficient. 
You need to track whether the palette actually need change.
Ideally it should be enough to set the right palette in polish, and then to 
update on toolbar position change (can be achieved by catching moveEvent with 
an event filter on the toolbar)

> breezestyle.cpp:4902
> +
> +toolbar->setPalette(palette);
> +

same remark

> breezetoolsareamanager.cpp:120
> +this, [this]() {
> +emit this->toolbarUpdated();
> +});

the this-> here are all unnecessary.

> cblack wrote in breezetoolsareamanager.cpp:108
> This is intentional—if a window's titlebar and content colours are the same, 
> the window is drawn as a homogeneous window instead of a window with a tools 
> area.

I was not refering to the rendering of the separator, but rather to the fact 
that the widgets margin change between active and inactive. This should not 
happen (disregarding the color scheme). 
All in all, whether you need to draw the separator or not you need to add the 
margin always (or follow David's suggestion)
Unless I misunderstood the actual issue reported by Nathan of course.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Some more comments about the code.

INLINE COMMENTS

> breeze.h:104
>  // toolbars
> -ToolBar_FrameWidth = 2,
> +ToolBar_FrameWidth = 6,
>  ToolBar_HandleExtent = 10,

This change seems unrelated to introducing a tool area. 
I would move it to a separate commit and review request. In fact there are 
already complains about there being too much space wasted in breeze. These 
extra 4 pixels don't go in the right direction (and again: are not needed for 
this patch as far as I can tell)

> breezehelper.cpp:1703
> +for (auto widget : widgets) {
> +if (this->isInToolsArea(widget) == true) {
> +return true;

this-> is not necessary.

> breezehelper.cpp:1740
> +for (auto widget : widgets) {
> +if (this->isInToolsArea(widget)) {
> +return widget;

this-> is not necessary

> breezehelper.h:31
>  
> +#include 
>  #include 

Not needed as far as I can tell (none of your changes in this file require 
QToolbar)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D27669#625270 , @IlyaBizyaev 
wrote:
  
  > For color schemes that have contrasting titlebar and content colors, this 
patch makes application headers look giant...
  >  F8168755: photo_2020-03-10_15-09-54.jpg 

  >  It does look good with the proposed default color palette, but it makes 
many others, including current Breeze, look like an ugly CSD parody :/
  
  
  yes. It also breaks menubar/toolbar highlight and mouse-over when the 
corresponding colors are similar to the active window color. 
  (oxygen color scheme for instance). I was about to comment on this next. I 
think the only way for this to work is for breeze to completely ignore the 
decoration colors, and calculate its own, based on QPalette::Window and 
WindowText colors. 
  The same way as oxygen style was doing to ensure proper blend of the 
decoration and main window. 
  Now you can also add an option to force respecting the decoration colors, 
(oxygen style has such an option), but then it is the responsibility of the use 
who checks this to fix her/his colorscheme accordingly.
  
  Concerning window border, I think that there is no choice but to disable this 
entirely if the window borders are not "none" or "no side". 
  And in fact, having a user option to disable this anyway in the config might 
be needed. This is a quite intrusive change, and many (me included) might want 
to live without.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 130 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/130/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Mar 2020 12:45:13 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 218 lines...][2020-03-10T12:59:34.923Z] HOME  = '/home/jenkins'[2020-03-10T12:59:34.923Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/130/'[2020-03-10T12:59:34.923Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-03-10T12:59:34.923Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-10T12:59:34.924Z] SHELL = '/bin/sh'[2020-03-10T12:59:34.924Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13'[2020-03-10T12:59:34.924Z] STAGE_NAME= 'Configuring Build'[2020-03-10T12:59:34.924Z] NODE_NAME = 'FreeBSD Builder Kappa'[2020-03-10T12:59:34.924Z] BLOCKSIZE = 'K'[2020-03-10T12:59:34.924Z] EXECUTOR_NUMBER   = '0'[2020-03-10T12:59:34.924Z] SHLVL = '0'[2020-03-10T12:59:34.924Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-10T12:59:34.924Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-10T12:59:34.924Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-10T12:59:34.924Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-10T12:59:34.924Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-10T12:59:34.924Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-03-10T12:59:34.924Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-03-10T12:59:34.924Z] QT_SELECT = 'qt5'[2020-03-10T12:59:34.924Z] LANG  = 'en_US.UTF-8'[2020-03-10T12:59:34.924Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-10T12:59:34.924Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-03-10T12:59:34.924Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-03-10T12:59:34.924Z] [2020-03-10T12:59:34.924Z] [2020-03-10T12:59:34.924Z] == Commencing Configuration:[2020-03-10T12:59:34.924Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13"[2020-03-10T12:59:35.200Z] -- The C compiler identification is Clang 8.0.1[2020-03-10T12:59:35.200Z] -- The CXX compiler identification is Clang 8.0.1[2020-03-10T12:59:35.200Z] -- Check for working C compiler: /usr/bin/cc[2020-03-10T12:59:35.461Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-10T12:59:35.461Z] -- Detecting C compiler ABI info[2020-03-10T12:59:35.461Z] -- Detecting C compiler ABI info - done[2020-03-10T12:59:35.461Z] -- Detecting C compile features[2020-03-10T12:59:35.461Z] -- Detecting C compile features - done[2020-03-10T12:59:35.461Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-10T12:59:35.461Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-10T12:59:35.461Z] -- Detecting CXX compiler ABI info[2020-03-10T12:59:35.719Z] -- Detecting CXX compiler ABI info - done[2020-03-10T12:59:35.719Z] -- Detecting CXX compile features[2020-03-10T12:59:35.719Z] -- Detecting CXX compile features - done[2020-03-10T12:59:35.719Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for plasma-desktop.[2020-03-10T12:59:35.719Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-03-10T12:59:35.719Z] -- Looking for __GLIBC__[2020-03-10T12:59:35.719Z] -- Looking for __GLIBC__ - not found[2020-03-10T12:59:35.719Z] -- Performing Test _OFFT_IS_64BIT[2020-03-10T12:59:35.719Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-10T12:59:35.719Z] -- Performing Test HAVE_DATE_TIME[2020-03-10T12:59:35.975Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-10T12:59:35.975Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.68.0") [2020-03-10T12:59:35.975Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for 

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/58/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Mar 2020 12:47:21 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2020-03-10T12:58:39.621Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/58/display/redirect'[2020-03-10T12:58:39.621Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-03-10T12:58:39.621Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2020-03-10T12:58:39.621Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-10T12:58:39.621Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-03-10T12:58:39.621Z] NODE_NAME = 'Docker Swarm-de3cb708b835'[2020-03-10T12:58:39.621Z] HOST  = 'de3cb708b835'[2020-03-10T12:58:39.621Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-10T12:58:39.621Z] USER  = 'jenkins'[2020-03-10T12:58:39.621Z] MORE  = '-sl'[2020-03-10T12:58:39.621Z] CSHEDIT   = 'emacs'[2020-03-10T12:58:39.621Z] SHLVL = '2'[2020-03-10T12:58:39.621Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-58'[2020-03-10T12:58:39.621Z] WINDOWMANAGER = 'xterm'[2020-03-10T12:58:39.621Z] PAGER = 'less'[2020-03-10T12:58:39.621Z] EXECUTOR_NUMBER   = '0'[2020-03-10T12:58:39.621Z] CVS_RSH   = 'ssh'[2020-03-10T12:58:39.621Z] LIBGL_DEBUG   = 'quiet'[2020-03-10T12:58:39.621Z] STAGE_NAME= 'Configuring Build'[2020-03-10T12:58:39.621Z] NODE_LABELS   = 'Docker Swarm-de3cb708b835 SUSEQt5.12'[2020-03-10T12:58:39.621Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-10T12:58:39.621Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-10T12:58:39.621Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-10T12:58:39.621Z] PROFILEREAD   = 'true'[2020-03-10T12:58:39.621Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-10T12:58:39.621Z] HOSTTYPE  = 'x86_64'[2020-03-10T12:58:39.621Z] BUILD_ID  = '58'[2020-03-10T12:58:39.621Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-10T12:58:39.621Z] OLDPWD= '/home/jenkins'[2020-03-10T12:58:39.621Z] LC_CTYPE  = 'C.UTF-8'[2020-03-10T12:58:39.621Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-10T12:58:39.621Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-10T12:58:39.621Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-10T12:58:39.621Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-10T12:58:39.621Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-10T12:58:39.621Z] QT_SELECT = 'qt5'[2020-03-10T12:58:39.621Z] LANG  = 'en_US.UTF-8'[2020-03-10T12:58:39.621Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-10T12:58:39.621Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-10T12:58:39.621Z] [2020-03-10T12:58:39.621Z] [2020-03-10T12:58:39.621Z] == Commencing Configuration:[2020-03-10T12:58:39.621Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2020-03-10T12:58:39.621Z] -- The C compiler identification is GNU 9.2.1[2020-03-10T12:58:39.879Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-10T12:58:39.879Z] -- Check for working C compiler: /usr/bin/cc[2020-03-10T12:58:39.879Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-10T12:58:39.879Z] -- Detecting C compiler ABI info[2020-03-10T12:58:39.879Z] -- Detecting C compiler ABI info - done[2020-03-10T12:58:39.879Z] -- Detecting C compile features[2020-03-10T12:58:39.879Z] -- Detecting C compile features - done[2020-03-10T12:58:39.879Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-10T12:58:40.134Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-10T12:58:40.134Z] -- Detecting CXX compiler ABI info[2020-03-10T12:58:40.134Z] -- Detecting CXX compiler ABI info - done[2020-03-10T12:58:40.389Z] -- Detecting CXX compile features[2020-03-10T12:58:40.389Z] -- 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 39 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/39/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Mar 2020 12:42:14 +
 Build duration:
3 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 198 lines...][2020-03-10T12:45:31.816Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-03-10T12:45:31.816Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2020-03-10T12:45:31.816Z] EDITOR= 'vi'[2020-03-10T12:45:31.816Z] ENV   = '/home/jenkins/.shrc'[2020-03-10T12:45:31.816Z] HUDSON_HOME   = '/home/production/data'[2020-03-10T12:45:31.816Z] BUILD_ID  = '39'[2020-03-10T12:45:31.816Z] OLDPWD= '/usr/home/jenkins'[2020-03-10T12:45:31.816Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-03-10T12:45:31.816Z] _ = '/usr/local/bin/java'[2020-03-10T12:45:31.816Z] TERM  = 'su'[2020-03-10T12:45:31.816Z] NODE_LABELS   = 'FreeBSD Builder Iota FreeBSDQt5.13'[2020-03-10T12:45:31.816Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-39'[2020-03-10T12:45:31.816Z] BUILD_DISPLAY_NAME= '#39'[2020-03-10T12:45:31.816Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/39/display/redirect'[2020-03-10T12:45:31.816Z] USER  = 'jenkins'[2020-03-10T12:45:31.816Z] HOME  = '/home/jenkins'[2020-03-10T12:45:31.816Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/39/'[2020-03-10T12:45:31.816Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2020-03-10T12:45:31.816Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-10T12:45:31.816Z] SHELL = '/bin/sh'[2020-03-10T12:45:31.816Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2020-03-10T12:45:31.816Z] STAGE_NAME= 'Configuring Build'[2020-03-10T12:45:31.816Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-03-10T12:45:31.816Z] BLOCKSIZE = 'K'[2020-03-10T12:45:31.816Z] EXECUTOR_NUMBER   = '0'[2020-03-10T12:45:31.816Z] SHLVL = '0'[2020-03-10T12:45:31.816Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-10T12:45:31.816Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-10T12:45:31.816Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-10T12:45:31.816Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-10T12:45:31.816Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-10T12:45:31.816Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-03-10T12:45:31.816Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-03-10T12:45:31.816Z] QT_SELECT = 'qt5'[2020-03-10T12:45:31.816Z] LANG  = 'en_US.UTF-8'[2020-03-10T12:45:31.816Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-10T12:45:31.816Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-03-10T12:45:31.816Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-03-10T12:45:31.816Z] [2020-03-10T12:45:31.816Z] [2020-03-10T12:45:31.816Z] == Commencing Configuration:[2020-03-10T12:45:31.816Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2020-03-10T12:45:32.072Z] -- The C compiler identification is Clang 8.0.1[2020-03-10T12:45:32.072Z] -- The CXX compiler identification is Clang 8.0.1[2020-03-10T12:45:32.072Z] -- Check for working C compiler: /usr/bin/cc[2020-03-10T12:45:32.072Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-10T12:45:32.072Z] -- Detecting C compiler ABI info[2020-03-10T12:45:32.072Z] -- Detecting C compiler ABI info - done[2020-03-10T12:45:32.072Z] -- Detecting C compile features[2020-03-10T12:45:32.072Z] -- Detecting C compile features - done[2020-03-10T12:45:32.072Z] -- Check for working CXX compiler: 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 284 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/284/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Mar 2020 12:45:12 +
 Build duration:
6 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 277 lines...][2020-03-10T12:51:17.007Z] WINDOWMANAGER = 'xterm'[2020-03-10T12:51:17.007Z] PAGER = 'less'[2020-03-10T12:51:17.007Z] EXECUTOR_NUMBER   = '0'[2020-03-10T12:51:17.007Z] CVS_RSH   = 'ssh'[2020-03-10T12:51:17.007Z] LIBGL_DEBUG   = 'quiet'[2020-03-10T12:51:17.007Z] STAGE_NAME= 'Configuring Build'[2020-03-10T12:51:17.007Z] NODE_LABELS   = 'Docker Swarm-5406e7b11974 SUSEQt5.12'[2020-03-10T12:51:17.007Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-10T12:51:17.007Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-10T12:51:17.007Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-10T12:51:17.007Z] PROFILEREAD   = 'true'[2020-03-10T12:51:17.007Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-10T12:51:17.007Z] HOSTTYPE  = 'x86_64'[2020-03-10T12:51:17.007Z] BUILD_ID  = '284'[2020-03-10T12:51:17.007Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-10T12:51:17.007Z] OLDPWD= '/home/jenkins'[2020-03-10T12:51:17.007Z] LC_CTYPE  = 'C.UTF-8'[2020-03-10T12:51:17.007Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-10T12:51:17.007Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-10T12:51:17.007Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-10T12:51:17.007Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-10T12:51:17.007Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-10T12:51:17.007Z] QT_SELECT = 'qt5'[2020-03-10T12:51:17.007Z] LANG  = 'en_US.UTF-8'[2020-03-10T12:51:17.007Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-10T12:51:17.007Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-10T12:51:17.007Z] [2020-03-10T12:51:17.007Z] [2020-03-10T12:51:17.007Z] == Commencing Configuration:[2020-03-10T12:51:17.007Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12"[2020-03-10T12:51:17.007Z] -- The C compiler identification is GNU 9.2.1[2020-03-10T12:51:17.007Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-10T12:51:17.266Z] -- Check for working C compiler: /usr/bin/cc[2020-03-10T12:51:17.266Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-10T12:51:17.266Z] -- Detecting C compiler ABI info[2020-03-10T12:51:17.266Z] -- Detecting C compiler ABI info - done[2020-03-10T12:51:17.266Z] -- Detecting C compile features[2020-03-10T12:51:17.266Z] -- Detecting C compile features - done[2020-03-10T12:51:17.266Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-10T12:51:17.266Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-10T12:51:17.266Z] -- Detecting CXX compiler ABI info[2020-03-10T12:51:17.266Z] -- Detecting CXX compiler ABI info - done[2020-03-10T12:51:17.266Z] -- Detecting CXX compile features[2020-03-10T12:51:17.266Z] -- Detecting CXX compile features - done[2020-03-10T12:51:17.266Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-03-10T12:51:17.266Z] -- Looking for __GLIBC__[2020-03-10T12:51:17.523Z] -- Looking for __GLIBC__ - found[2020-03-10T12:51:17.523Z] -- Performing Test _OFFT_IS_64BIT[2020-03-10T12:51:17.523Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-10T12:51:17.523Z] -- Performing Test HAVE_DATE_TIME[2020-03-10T12:51:17.523Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-10T12:51:17.523Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.68.0") [2020-03-10T12:51:17.780Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for plasma-desktop.[2020-03-10T12:51:17.780Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 63 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/63/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Mar 2020 12:42:14 +
 Build duration:
1 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2020-03-10T12:43:17.199Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-03-10T12:43:17.199Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-03-10T12:43:17.199Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/63/display/redirect'[2020-03-10T12:43:17.199Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2020-03-10T12:43:17.199Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2020-03-10T12:43:17.199Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-10T12:43:17.199Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-03-10T12:43:17.199Z] NODE_NAME = 'Docker Swarm-484ac4dfe92f'[2020-03-10T12:43:17.199Z] HOST  = '484ac4dfe92f'[2020-03-10T12:43:17.199Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-10T12:43:17.199Z] USER  = 'jenkins'[2020-03-10T12:43:17.199Z] MORE  = '-sl'[2020-03-10T12:43:17.199Z] CSHEDIT   = 'emacs'[2020-03-10T12:43:17.199Z] SHLVL = '2'[2020-03-10T12:43:17.199Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-63'[2020-03-10T12:43:17.199Z] WINDOWMANAGER = 'xterm'[2020-03-10T12:43:17.199Z] PAGER = 'less'[2020-03-10T12:43:17.199Z] EXECUTOR_NUMBER   = '0'[2020-03-10T12:43:17.199Z] CVS_RSH   = 'ssh'[2020-03-10T12:43:17.199Z] LIBGL_DEBUG   = 'quiet'[2020-03-10T12:43:17.199Z] STAGE_NAME= 'Configuring Build'[2020-03-10T12:43:17.199Z] NODE_LABELS   = 'Docker Swarm-484ac4dfe92f SUSEQt5.12'[2020-03-10T12:43:17.199Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-10T12:43:17.199Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-10T12:43:17.199Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-10T12:43:17.199Z] PROFILEREAD   = 'true'[2020-03-10T12:43:17.199Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-10T12:43:17.199Z] HOSTTYPE  = 'x86_64'[2020-03-10T12:43:17.199Z] BUILD_ID  = '63'[2020-03-10T12:43:17.199Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-10T12:43:17.199Z] OLDPWD= '/home/jenkins'[2020-03-10T12:43:17.199Z] LC_CTYPE  = 'C.UTF-8'[2020-03-10T12:43:17.199Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-10T12:43:17.199Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-10T12:43:17.199Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-10T12:43:17.199Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-10T12:43:17.199Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-10T12:43:17.199Z] QT_SELECT = 'qt5'[2020-03-10T12:43:17.199Z] LANG  = 'en_US.UTF-8'[2020-03-10T12:43:17.199Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-10T12:43:17.199Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-10T12:43:17.199Z] [2020-03-10T12:43:17.199Z] [2020-03-10T12:43:17.199Z] == Commencing Configuration:[2020-03-10T12:43:17.199Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2020-03-10T12:43:17.199Z] -- The C compiler identification is GNU 9.2.1[2020-03-10T12:43:17.459Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-10T12:43:17.459Z] -- Check for working C compiler: /usr/bin/cc[2020-03-10T12:43:17.459Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-10T12:43:17.459Z] -- Detecting C compiler ABI info[2020-03-10T12:43:17.459Z] -- Detecting C compiler ABI info - done[2020-03-10T12:43:17.459Z] -- Detecting C compile features[2020-03-10T12:43:17.459Z] -- Detecting C compile features - done[2020-03-10T12:43:17.459Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-10T12:43:17.715Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-10T12:43:17.715Z] -- 

D27968: notifications: on mobile align popup to top center

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3609f66a98bc: notifications: on mobile align popup to top 
center (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27968?vs=77346=77347

REVISION DETAIL
  https://phabricator.kde.org/D27968

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: bshah, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27968: notifications: on mobile align popup to top center

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  any other position doesn't really make sense on mobile, so ignore popup 
location
  settings

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/mobile-notification

REVISION DETAIL
  https://phabricator.kde.org/D27968

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: bshah, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  For color schemes that have contrasting titlebar and content colors, this 
patch makes application headers look giant...
  F8168755: photo_2020-03-10_15-09-54.jpg 
  It does look good with the proposed default color palette, but it makes many 
others, including current Breeze, look like an ugly CSD parody :/

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: Proposal: Dynamic Wallpapers in Plasma

[Vlad Zahorodnii]

On 3/10/20 1:27 PM, Kai Uwe Broulik wrote:
There's QImageIOHandler::Description which can store arbitrary text data 
in an image. You reckon QImageIOHandler could be extended to support 
whatever metadata you need to read/write?


Yes, it would be fine for our specific use case. We're interested only 
in XMP metadata after all. But please don't forget that an image in a 
HEIF file may have other metadata associated with it as well.


Heh, I also forgot to mention that we'd still probably need a custom 
writer class because it appears like Qt has nothing that one could use 
to write an image sequence or image collection.


Cheers,
Vlad

Re: Proposal: Dynamic Wallpapers in Plasma

[Kai Uwe Broulik]

Hi,

you know I'm a big fan of your dynamic wallpaper work :)

> It's worth to point out that there is an upstream patch to add one [2].

Given 5.15 is feature frozen already, I think we won't see this anytime 
soon. It could be worth a try contacting the author if they're willing 
to include it in kimageformats, and then re-evaluate once Qt (6?) will 
have the handler upstream.


>  we would still need those two classes because QImageIOHandler lacks 
an API to read and write image metadata.


There's QImageIOHandler::Description which can store arbitrary text data 
in an image. You reckon QImageIOHandler could be extended to support 
whatever metadata you need to read/write?


Cheers
Kai Uwe

Proposal: Dynamic Wallpapers in Plasma

[Vlad Zahorodnii]

Hi,

I would like to propose a dynamic wallpaper plugin for KDE Plasma [1].

As the name suggests, the plugin updates the background continuously to 
reflect the user's current light situation. Besides being eye-candy, it 
can be useful for a Night Mode (if Plasma gets one).


The HEIF file format is used to store dynamic wallpapers. Each image in 
a dynamic wallpaper has metadata associated with it. The metadata 
contains information such as the position of the Sun, and the time. The 
plugin uses the metadata to determine what image(s) must be shown at the 
current moment. The solar metadata is optional. It will be used when the 
plugin is able to construct the path of the Sun; otherwise it will 
fallback to using time metadata.


The only big issue with using the HEIF file format is that Qt doesn't 
have full support for it on Linux. I assume that's the case because the 
HEIF file format was introduced quite recently (iirc, in 2015 or 
something). So, there's no a QImageIOHandler for HEIF files and the 
QImageReader class can't be used to read image collections (it's good 
for reading image sequences, though).


Due to the aforementioned issues, the dynamic wallpaper plugin ships a 
small library that contains two classes (KDynamicWallpaperReader and 
KDynamicWallpaperWriter) that can be used to read and write dynamic 
wallpapers. Even if Qt gains a QImageIOHandler class for HEIF files, we 
would still need those two classes because QImageIOHandler lacks an API 
to read and write image metadata.


In addition to the helper library, the plugin ships an utility that one 
could use to create a dynamic wallpaper from a collection of jpg or png 
files.


I would like to stress that we probably still need a QImageIOHandler for 
the HEIF file format in order to have file previews. It's worth to point 
out that there is an upstream patch to add one [2].


In general, the core part of the plugin is complete. What is left to do 
is to clean up code turds and finish writing documentation.


Any thoughts?

Cheers,
Vlad

[1] https://invent.kde.org/vladz/plasma5-wallpapers-dynamic/
[2] https://codereview.qt-project.org/c/qt/qtimageformats/+/236077

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Christoph Feck]

cfeck added a comment.


  See https://bugreports.qt.io/browse/QTBUG-56547

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Méven Car]

meven added a comment.


  In D27808#625229 , @ahmadsamir 
wrote:
  
  > In D27808#625227 , @cfeck wrote:
  >
  > > We already lost fractional point sizes when porting from KFontDialog to 
QFontDialog.
  >
  >
  > Yeah, I never understood why they opted for integer values only (I will dig 
in upstream log history to find if there any rationale behind that, if I find 
nothing I will, FWIW, file a bug report upstream).
  >
  > > Best approach is to add the KFontDialog to the platform plugin (and also 
the old KColorDialog while you are at it), or upstream our features to Qt.
  >
  > Now, that sounds like a good idea, sort of like how the open file dialog 
from KIO is used instead of the upstream vanilla one (I'll need to figure out 
how that works to begin with).
  
  
  Repo is at https://cgit.kde.org/plasma-integration.git/
  This is around : QPlatformFontDialogHelper 
https://code.woboq.org/qt5/qtbase/src/gui/kernel/qplatformdialoghelper.h.html
  You can use 
https://cgit.kde.org/plasma-integration.git/tree/src/platformtheme/kdeplatformfiledialoghelper.cpp
 as base.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  In D27808#625227 , @cfeck wrote:
  
  > We already lost fractional point sizes when porting from KFontDialog to 
QFontDialog.
  
  
  Yeah, I never understood why they opted for integer values only (I will dig 
in upstream log history to find if there any rationale behind that, if I find 
nothing I will, FWIW, file a bug report upstream).
  
  > Best approach is to add the KFontDialog to the platform plugin (and also 
the old KColorDialog while you are at it), or upstream our features to Qt.
  
  Now, that sounds like a good idea, sort of like how the open file dialog from 
KIO is used instead of the upstream vanilla one (I'll need to figure out how 
that works to begin with).
  
  > Btw, I set Toolbar font to a "condensed" version, to have more horizontal 
room for toolbars with text aside icons.
  
  OK, message received. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Christoph Feck]

cfeck added a comment.


  We already lost fractional point sizes when porting from KFontDialog to 
QFontDialog. Best approach is to add the KFontDialog to the platform plugin 
(and also the old KColorDialog while you are at it), or upstream our features 
to Qt.
  
  Btw, I set Toolbar font to a "condensed" version, to have more horizontal 
room for toolbars with text aside icons.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[George Vogiatzis]

gvgeo added a comment.


  Couple of notes, as I'm not sure what the aim was here. I have not test it, 
take them with a grain of salt.
  
  - Highlight area was changed, without changing the click area.
  - Connect button pop up area change, was not documented.
  - Highlight svg is not consistent with list's highlight. And maybe not always 
look good. (Although it's designation is pressed, everywhere used as highlight, 
which is an different story itself.)
  - There is code left in various places, listitem.qml possibly could be 
removed completely now.
  
  ---
  
  The line above, is because you did not build plasma-nm but instead copied the 
qml files.
  See T10470  for the icon size.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: gvgeo, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  In D27808#625186 , @meven wrote:
  
  > In D27808#625181 , @ahmadsamir 
wrote:
  >
  > > And another question, "General", "Menu", "Toolbar", how many users 
actually set these three to individual font families/styles/sizes?
  >
  >
  > If anything this is just not relevant here. Either you port things away 
from kde4support or you change the behavior but the two things should not be 
done together.
  >  Generally the community has rarely removed any working features and this 
is a kind of feature plasma is known for : customization.
  
  
  That wasn't my intention (I mean changing it in this diff), it was a BTW kind 
of thought/question "is this still needed/used nowadays?", I was thinking of 
posting the question to the frameworks ML... but was afraid it might start a 
flame/bike-shedding conundrum there, so I asked here instead :)
  
  > In D27808#625064 , @ahmadsamir 
wrote:
  > 
  >> In D27808#625052 , @meven wrote:
  >>
  >> > Porting with such feature regression is hard to justify.
  >>
  >>
  >> I honestly don't know how many users actually use that feature; if it's 
still widely used, then yeah, that would definitely be a feature regression.
  >>
  >> > Perhaps we should port KFontDialog (it is ~150 lines of cpp) to 
kwidgetsaddons instead, `KFontChooser` is already there.
  >> >  Or better perhaps implement here a simple QDialog embedding 
`KFontChooser` and providing equivalent features needed here that KFontDialog 
has.
  >> >  This is a typical work we did for KF5 
https://community.kde.org/Frameworks/Porting_Notes
  >>
  >> Since, AFAICS, only the fonts KCM uses that functionality, it might be 
better to move/copy KFontDialog to the KCM, and maybe rename it; it'd be a 
helper class of sorts.
  > 
  > 
  > Moving KFontDialog would imply porting it to QDialog anyway.
  >  But license might get in the way since kdelibs4support is LGPL and plasma 
is GPL.
  >  It would mean the moved KFontDialog would stay LGPL in a GPL codebase. 
Which is possible but not recommendable at all.
  > 
  >>> implement here a simple QDialog embedding `KFontChooser` and providing 
equivalent features needed here that KFontDialog has.
  > 
  > I would suggest you this simpler way to do it, but the code of this QDialog 
helper would be loosely inspired by KFontDialog anyway but not LGPL.
  >  In the end that's pretty much the same thing as you suggested but better 
keep license potential issues at bay ;)
  
  Good point(s). :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  Oh another thing I noticed: this doesn't work, when an app changes its color 
scheme rather than the default one. The toolbar is not updated.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  I removed the separator line for comparison:
  F8168553: grafik.png 
  F8168557: Screenshot_20200310_095331.PNG 

  I thought the goal was to have less separators (see the attached task and 
this effectively increases the count. KDevelop before, your patch and your 
patch without separator (ignore the broken toolbar) :F8168568: 
Screenshot_20200310_095946.PNG F8168562: 
Screenshot_20200310_095741.PNG 
  
  F8168570: Screenshot_20200310_100102.PNG 

  All in all I think this patch would also work without the separator line

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  One other thing to consider, this looks really bad with everything else other 
than no border:
  F8168528: grafik.png  F8168533: 
grafik.png 
  
  > No border is now the default!
  
  Yes I know, but this makes the option to have window borders basically 
unusable. Just because it's not the default still we have to care for it.
  F8168541: grafik.png 
  Again why are we introducing this separator line and even drawing it under 
normal titlebars? Compared to before
  F8168544: grafik.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Méven Car]

meven added a comment.


  In D27808#625181 , @ahmadsamir 
wrote:
  
  > And another question, "General", "Menu", "Toolbar", how many users actually 
set these three to individual font families/styles/sizes?
  
  
  If anything this is just not relevant here. Either you port things away from 
kde4support or you change the behavior but the two things should not be done 
together.
  Generally the community has rarely removed any working features and this is a 
kind of feature plasma is known for : customization.
  
  In D27808#625064 , @ahmadsamir 
wrote:
  
  > In D27808#625052 , @meven wrote:
  >
  > > Porting with such feature regression is hard to justify.
  >
  >
  > I honestly don't know how many users actually use that feature; if it's 
still widely used, then yeah, that would definitely be a feature regression.
  >
  > > Perhaps we should port KFontDialog (it is ~150 lines of cpp) to 
kwidgetsaddons instead, `KFontChooser` is already there.
  > >  Or better perhaps implement here a simple QDialog embedding 
`KFontChooser` and providing equivalent features needed here that KFontDialog 
has.
  > >  This is a typical work we did for KF5 
https://community.kde.org/Frameworks/Porting_Notes
  >
  > Since, AFAICS, only the fonts KCM uses that functionality, it might be 
better to move/copy KFontDialog to the KCM, and maybe rename it; it'd be a 
helper class of sorts.
  
  
  Moving KFontDialog would imply porting it to QDialog anyway.
  But license might get in the way since kdelibs4support is LGPL and plasma is 
GPL.
  It would mean the moved KFontDialog would stay LGPL in a GPL codebase. Which 
is possible but not recommendable at all.
  
  > implement here a simple QDialog embedding `KFontChooser` and providing 
equivalent features needed here that KFontDialog has.
  
  I would suggest you this simpler way to do it, but the code of this QDialog 
helper would be loosely inspired by KFontDialog anyway but not LGPL.
  In the end that's pretty much the same thing as you suggested but better keep 
license potential issues at bay ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> breezetoolsareamanager.cpp:109
> +window->setContentsMargins(0,1,0,0);
> +}
> +});

Maybe the decision whether to do this could only be made based on the colors of 
the active state so it's consistent with the inactive one.
Also this happens because the separator line? Do we actually need it? Currently 
there is no separator between titlebar and window and/or between toolbar and 
other window content?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  And another question, "General", "Menu", "Toolbar", how many users actually 
set these three to individual font families/styles/sizes?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart