D27903: [applet/digital-clock] Show time zones in expanded representation too

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2130c848e677: [applet/digital-clock] Show time zones in expanded representation too (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D27903: [applet/digital-clock] Show time zones in expanded representation too

ngraham updated this revision to Diff 77531. ngraham marked an inline comment as done. ngraham added a comment. Use better name for bool property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27903?vs=77123&id=77531 BRANCH digital-clock-layouts

D27903: [applet/digital-clock] Show time zones in expanded representation too

ngraham added a comment. @cblack all of those things are in the existing code; I just moved the section from one place to another. I'd prefer to do those refactorings in another commit. REPOSITORY R120 Plasma Workspace BRANCH digital-clock-layouts-and-timezones-in-popup (branched from m

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:4382 > I am sorry to say this is a serious show stopper. > One cannot reset/update the kiconloader palette at every repaint event for > every single toolbutton in toolbars especially when there are

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > cblack wrote in breezestyle.cpp:4382 > The issue is that the QStyle only has the global icon palette to mutate for > the tools area. If the custom palette were to be left intact, that would > affect widgets it's not supposed to. There is

D27903: [applet/digital-clock] Show time zones in expanded representation too

apol added inline comments. INLINE COMMENTS > cblack wrote in main.qml:69 > Style change: use arg() instead of string concatenation so it's easier to see > what the end string will look like I don't think that's fair. I wouldn't say arg makes it more readable. REPOSITORY R120 Plasma Workspac

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:4382 > Not at every paint event. You should check if kiconloader already have a > customPalette, if it matches the one you want, and update (or reset) only > when necessary. The issue is that the QStyle on

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77529. cblack marked 14 inline comments as done. cblack added a comment. Address feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77376&id=77529 BRANCH cblack/toolsarea REVISION DETAIL https://phabric

D27572: [kcm] Drop 'Enable bluetooth integration' setting

nicolasfella added a comment. In D27572#626285 , @drosca wrote: > What happens if someone have it disabled and updates Plasma with this change? Nothing immediately happens, but the module can be reenabled via the KDED KCM REPOSITORY R9

D27574: Remove bold formatting of device name

This revision was automatically updated to reflect the committed changes. Closed by commit R97:c190802e1e0a: Remove bold formatting of device name (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27574?vs=76178&id=77527 REVISION DET

D27903: [applet/digital-clock] Show time zones in expanded representation too

cblack added inline comments. INLINE COMMENTS > CalendarView.qml:432 > +id: listItem > +readonly property bool lastTimeZone: modelData === > plasmoid.configuration.lastSelectedTimezone > This property's name doesn't imply it's a boolean > main.

D27903: [applet/digital-clock] Show time zones in expanded representation too

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Visually, this looks good. The code also looks makes sense and looks good to me, albeit there's some minor style issues, mostly in how properties are grouped and ordered. REPOSITORY

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77514. niccolove added a comment. - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into systray_toparea remove unrelated change REPOSITOR

Re: Proposal to centralize KCM bugs inside the systemsettings product

On Thu, 12 Mar 2020, 17:58 David Edmundson, wrote: > > > On Wed, 11 Mar 2020, 16:55 Nate Graham, wrote: > >> Forwarding to plasma-devel at David Edmundson's request because I >> originally sent this to the wrong mailing lists. Will send future such >> emails to plasma-devel, sorry about that. >>

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77512. niccolove added a comment. Removed head REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77510&id=77512 BRANCH systray_toparea (branched from master) REVISION DETAIL https://phabricator.kd

D27189: Created a top area based on widgets/toparea.svg

ngraham added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:43 > > -RowLayout { > - > -PlasmaExtras.Heading { > -id: heading > -Layout.fillWidth: true > -level: 1 > -Layout.leftMargin: { > -//Menu mode >

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77510. niccolove added a comment. - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into systray_toparea REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77416&id=77510 BRANCH sys

D27980: make opengl module support multiple dri devices

zzag added a comment. In D27980#626500 , @sitter wrote: > Had a quick look, using libdrm seems a bit excessive for what we want to do here. Well, it was worth a try. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kd

D27998: Add workspace kcm option for dndToMove

trmdi added inline comments. INLINE COMMENTS > meven wrote in main.qml:150 > You can nowadays write `!kcm.globalsSettings.isDndToMoveImmutable` > That was added recently. D26368 Thanks, but maybe this need another patch. :) REPOSITORY R119 Plasma Desktop

D27998: Add workspace kcm option for dndToMove

trmdi updated this revision to Diff 77509. trmdi added a comment. Move to bottom, add hint REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27998?vs=77478&id=77509 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kd

D27984: Add a ShadowedRectangle item

ahiemstra added a comment. With that, I think this is now completely ready. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami, mart Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > ahiemstra wrote in shadowedrectangle.h:15 > I've actually been pondering making it a grouped property, it would make it > more similar to border. > > So then you'd have: > > ShadowedRectangle { >

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra updated this revision to Diff 77506. ahiemstra added a comment. - Convert shadow properties of ShadowedRectangle to a grouped property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27984?vs=77504&id=77506 BRANCH shadowrect_distancefield REVI

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra updated this revision to Diff 77504. ahiemstra added a comment. - Documentation - Add support for rendering a border REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27984?vs=77446&id=77504 BRANCH shadowrect_distancefield REVISION DETAIL ht

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kstart.cpp:184 > Wouldn't it be easier here to just do `windowtitle.compare(info.name(), > Qt::CaseInsensitive)` and skip the regex? I thought about that, but looking at the code I found: void KStart::sendRule() { KXMess

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

apol added inline comments. INLINE COMMENTS > kstart.cpp:184 > +const QRegularExpression > re(QRegularExpression::anchoredPattern(windowtitle.toLower())); > +if (!re.match(title).hasMatch()) { > +return; // no match Wouldn't it be easier here to just do `windowtitle.

D27980: make opengl module support multiple dri devices

sitter added a comment. In D27980#625840 , @zzag wrote: > I'm not sure whether this is useful, but libdrm has an API to enumerate devices. Had a quick look, using libdrm seems a bit excessive for what we want to do here. The current /sys

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in shadowedrectangle.h:15 > shadowSize to correspond with shadowColor I've actually been pondering making it a grouped property, it would make it more similar to border. So then you'd have: ShadowedRectangle { shadow {

D27985: Include s_kcrashErrorMessage in our traces

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM for when the kcrash diff is ready. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: plasma-devel, Orag

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra added a comment. I've been adding some documentation, in addition to border properties. With that I'm fairly sure this is ready. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami, mart Cc: mart, cblack, zzag, plasma-devel, fba

D27984: [WIP] Add a ShadowedRectangle item

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. to me is good, would just change that one thing api wise. do you think there are other blockers from a technical pov or good to go? INLINE COMMENTS > shadowedrectangle.h:15 > +Q

D28003: [WIP]Expose global switch to the user

gvgeo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY This is a rough patch and will be abandoned. See D28002 instead. REPOSITORY R120 Plasma Worksp

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77481. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Fix commit message REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28000?vs=77480&id=77481 BRANCH l-qregexp (branched fro

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol, davidedmundson. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R126 KDE CLI Utilities BRANCH l-qregexp (branched from master) REVISION DETAIL htt

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/40/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 07:55:12 + Build duration: 25 min and counting JUnit Tests Na

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 131 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/131/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 07:55:09 + Build duration: 23 min and counting JUnit Tests

D27998: Add workspace kcm option for dndToMove

meven added inline comments. INLINE COMMENTS > main.qml:150 > +text: i18n("Always ask what to do") > +enabled: !kcm.globalsSettings.isImmutable("dndToMove") > +checked: !kcm.globalsSettings.dndToMove You can nowadays write `!kcm.globalsSettings.isDndToMoveImmu

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 285 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/285/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 07:55:09 + Build duration: 11 min and counting JUnit Tests Name: (

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/59/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 07:55:07 + Build duration: 5 min 49 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 64 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/64/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Mar 2020 07:55:11 + Build duration: 4 min 34 sec and counting JUnit Tests Na

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added a reviewer: VDG. zzag added a comment. In D27972#626302 , @broulik wrote: > I think this needs a VDG/Usability discussion. Yes! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrows

D27972: [NightColor] fix for plasmoid status and tooltip subtext

broulik added a comment. I think this needs a VDG/Usability discussion. Having the icon show when color correction is active (the status quo) imho makes sense. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham Cc: b

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added inline comments. INLINE COMMENTS > pdabrowski wrote in main.qml:36-38 > > We want to keep the applet visible even if Night Color is inhibited so user > > can quickly uninhibit it. > > You are right. I have modified the patch to show the icon when inhibited in > timed modes. Why onl