D27954: appstreamrunner: Port to KApplicationTrader

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3f0ca0da37d8: appstreamrunner: Port to KApplicationTrader (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27954?vs=77469=77602#toc REPOSITORY R120 Plasma Workspace

D27935: Make kwallet-pam work with pam_fscrypt

aacid added inline comments. INLINE COMMENTS > sitter wrote in pam_kwallet.c:313 > This can ENOMEM. Does that maybe need handling? Or will pam_set_data just > fail if you give it a nullptr? Passing nullptr is fine, see comment on

D27199: [Applet]Update layout based on T10470

manueljlin added a comment. I know this is closed now, but some people from the VDG didn't like the text indicator replaced with a 1px divider and the differently sized networks. Is it a good idea to tweak it or is it better to leave it like it is? REPOSITORY R116 Plasma Network

[neon] [Bug 418833] Boot splash screen shows wrong version of the Plasma

https://bugs.kde.org/show_bug.cgi?id=418833 Nate Graham changed: What|Removed |Added Component|Plymouth|Packages User Edition

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Ping. Would be nice to get this in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel,

D27189: Created a top area based on widgets/toparea.svg

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The title being moved to the right is a pre-existing feature/bug caused by some code in the system tray. Nice work! REPOSITORY R120 Plasma Workspace BRANCH systray_toparea (branched

D28034: [WIP] [Applet] Port to ExpandableListItem

gvgeo added a comment. Labels need eliding. Full width has problems? Button need to expand also. Click always collapse? Listitem.qml can be deleted now. I didn't see itemExpanded use anywhere. In expandedView (main patch) there is height in Layout. Button right margin is

D27998: [KCMs/Workspace] Add option for dndToMove

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM, modulo some small string change requests. Obviously this can't go in until and unless the dependent patch lands. :) INLINE COMMENTS > main.qml:206 > +Layout.fillWidth:

[Breeze] [Bug 418833] New: Boot splash screen shows wrong version of the Plasma

https://bugs.kde.org/show_bug.cgi?id=418833 Bug ID: 418833 Summary: Boot splash screen shows wrong version of the Plasma Product: Breeze Version: 5.18.3 Platform: Other OS: Linux Status: REPORTED

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

hpereiradacosta added a comment. In D27892#623436 , @davidre wrote: > In D27892#623425 , @ngraham wrote: > > > +1 for the concept and resulting appearance. But, should this maybe be done in KWin

D27972: [NightColor] fix for plasmoid status and tooltip subtext

ngraham added a comment. In D27972#626302 , @broulik wrote: > I think this needs a VDG/Usability discussion. > Having the icon show when color correction is active (the status quo) imho makes sense. I agree. Could you update the

D27565: Hide configure action in Info center mode

This revision was automatically updated to reflect the committed changes. Closed by commit R124:3d515026d59c: Hide configure action in Info center mode (authored by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27565?vs=77597=77598

D27565: Hide configure action in Info center mode

ngraham added a comment. Okay, this should be saner now. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27565 To: ngraham, #plasma, mart Cc: davidedmundson, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27565: Hide configure action in Info center mode

ngraham updated this revision to Diff 77597. ngraham added a comment. Or maybe I just hate myself REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27565?vs=77596=77597 BRANCH no-settings-in-infocenter-mode (branched from master) REVISION DETAIL

D27565: Hide configure action in Info center mode

ngraham updated this revision to Diff 77596. ngraham added a comment. I hate you arc REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27565?vs=77595=77596 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27565 AFFECTED FILES

D27565: Hide configure action in Info center mode

ngraham updated this revision to Diff 77595. ngraham added a comment. Rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27565?vs=76140=77595 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27565 AFFECTED FILES

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

This revision was automatically updated to reflect the committed changes. Closed by commit R120:db2518b063e4: [Applets/Battery] Dont use toolTipMainText to show info, rather use the second… (authored by mthw, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

ngraham updated this revision to Diff 77592. ngraham marked an inline comment as done. ngraham added a comment. Don't return early REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=77591=77592 BRANCH arcpatch-D24070 REVISION DETAIL

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

ngraham updated this revision to Diff 77591. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=74702=77591 BRANCH arcpatch-D24070 REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES

D28029: WIP: Use `ShadowedRectangle`

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. there's no version 2.12 for Kirigami, that's a QQC version F8174704: Screenshot_20200313_115718.png REPOSITORY R858 Qt Quick

D27189: Created a top area based on widgets/toparea.svg

niccolove requested review of this revision. niccolove added a comment. Works for me! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28038: Fix enabling border for ShadowedRectangle on item creation

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY When enabling the border during object creation, the first time updatePaintNode

D28037: [Applet] Port to ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Depends on D28033 TEST PLAN All

D28035: [Applet] Port to ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Depends on D28033 TEST PLAN All functionality

D28034: [WIP] [Applet] Port to ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY Depends on D28033

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Looks interesting, will take a look soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. With that early return addressed please REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D24070 REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma,

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:83 > +} else if (pmSource.data.Battery.State === "NoCharge") { > +return i18n("Not charging") > +} // otherwise, don't add anything Why this early return? REPOSITORY R120 Plasma Workspace

D27877: Make panel edit mode tooltip not unexpectedly disappear under certain circumstances

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9768200d9a27: Make panel edit mode tooltip not unexpectedly disappear under certain… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27565: Hide configure action in Info center mode

davidedmundson added a comment. To translate Kai: When we create the action we can call setVisible false in the one mode. Rather than here Advantage is that then any shortcuts also won't work. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27565

D28022: Fallback to a simple rectangle when using software rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4fd45c1cc7fd: Fallback to a simple rectangle when using software rendering (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28023: Fix color premultiply and alpha blending

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fe9073ec847b: Fix color premultiply and alpha blending (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28023?vs=77564=77575 REVISION

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 77574. bruns added a comment. tabs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=77560=77574 BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D28025 AFFECTED FILES

D28029: WIP: Use `ShadowedRectangle`

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of expensive `DropShadow` layer. TEST PLAN - There's something funky going on with the

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added inline comments. INLINE COMMENTS > main.qml:169 > +id: removeFolder > + visible: model.deletable > +icon.name: "user-trash" Spurious tab REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025

[kwrited] [Bug 418822] Notification flood blocks the broom icon

https://bugs.kde.org/show_bug.cgi?id=418822 --- Comment #3 from tuxutku --- nwm i found https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/backports/ -- You are receiving this mail because: You are the assignee for the bug.

D26923: Fix systemtray configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ce69fc4ea914: Fix systemtray configuration (authored by carewolf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26923?vs=74379=77568 REVISION DETAIL

D28023: Fix color premultiply and alpha blending

broulik accepted this revision. broulik added a comment. `Qt.color(0,0,0,0.3)` now matches between `DropShadow` layer and the `ShadowedRectrangle`. Very nice! REPOSITORY R169 Kirigami BRANCH color_fix REVISION DETAIL https://phabricator.kde.org/D28023 To: ahiemstra, #kirigami, mart,

D28023: Don't premultiply colors

ahiemstra updated this revision to Diff 77564. ahiemstra added a comment. - Revert "Don't premultiply colors" - Fix the premultiply function - Fix blending, offset positioning and other things of shaders REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

[kwrited] [Bug 418822] Notification flood blocks the broom icon

https://bugs.kde.org/show_bug.cgi?id=418822 --- Comment #2 from tuxutku --- Is there any ppa to do so? -- You are receiving this mail because: You are the assignee for the bug.

[kwrited] [Bug 418822] Notification flood blocks the broom icon

https://bugs.kde.org/show_bug.cgi?id=418822 Kai Uwe Broulik changed: What|Removed |Added Status|REPORTED|RESOLVED CC|

[kwrited] [Bug 418822] New: Notification flood blocks the broom icon

https://bugs.kde.org/show_bug.cgi?id=418822 Bug ID: 418822 Summary: Notification flood blocks the broom icon Product: kwrited Version: 5.16.5 Platform: Ubuntu Packages OS: Linux Status: REPORTED Severity:

D28027: fix line rating for new format when function name is missing

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously this supposedly was `#2 0x7fefe9ef79e8 in ?? () at /usr/lib/dri/i965_dri.so` nowadays the ?? is simply

D28026: further constrict line parsing of .so files

sitter created this revision. sitter added reviewers: cfeck, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY As seen in https://bugs.kde.org/show_bug.cgi?id=417435 the previous fix for .so detection

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. F8174362: Screenshot_20200313_145738.png F8174361: Screenshot_20200313_145811.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns created this revision. bruns added reviewers: Baloo, VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The current "Excluded folders" list in the KCM is quite awkward: 1. It tries to mimic

D28024: [Baloo KCM] Expose "Index hidden" config setting

bruns created this revision. bruns added reviewers: Baloo, VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Also inset both "Index file content" and "Index hidden" so it is more obvious both are

D28023: Don't premultiply colors

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Color handling with scene graph is a bit confusing at times, sometimes things need to

D28022: Fallback to a simple rectangle when using software rendering

ahiemstra updated this revision to Diff 77556. ahiemstra added a comment. - Use QQuickPaintedItem to render a rect with rounded corners and border REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28022?vs=77549=77556 BRANCH shadowrect_software REVISION

D28022: Fallback to a simple rectangle when using software rendering

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY If the scene graph is using software rendering, the custom shaders used for

D27935: Make kwallet-pam work with pam_fscrypt

sitter added inline comments. INLINE COMMENTS > pam_kwallet.c:313 > > -char *key = malloc(KWALLET_PAM_KEYSIZE); > -if (!key || kwallet_hash(pamh, password, userInfo, key) != 0) { > -free(key); > -pam_syslog(pamh, LOG_ERR, "%s: Fail into creating the hash", >

D27978: [FormLayout] Propagate FormData.enabled also to label

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1a36705f9613: [FormLayout] Propagate FormData.enabled also to label (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27978?vs=77401=77541

D27984: Add a ShadowedRectangle item

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fa4fa37879bf: Add a ShadowedRectangle item (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27984?vs=77506=77539 REVISION DETAIL

D25449: Start of the new Formats KCM

meven added a comment. ping @tcanabrava REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham Cc: meven, ahiemstra, anthonyfieroni, mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, Orage,

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. ping REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre, #breeze, #vdg, zzag, hpereiradacosta Cc: davidedmundson, ngraham, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27998: [KCMs/Workspace] Add option for dndToMove

meven added inline comments. INLINE COMMENTS > main.qml:189 > +text: i18n("Always ask what to do") > +enabled: !kcm.globalsSettings.isImmutable("dndToMove") > +checked: !kcm.globalsSettings.dndToMove My comment "you can nowadays write