D28354: [applets/digital-clock] Fix calendar events not being shown at first

2020-03-29 Thread Nathaniel Graham 
ngraham added a comment.


  Can you rebase this patch on current master?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread Eugene Popov 
epopov updated this revision to Diff 78827.
epopov added a comment.


  Use `hideOnWindowDeactivate` property instead of `configuration.pin`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78805=78827

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

2020-03-29 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Yes, I would just do a patch for the 'PURPOSE' text, mentioning "Required" or 
"Optional" (whatever you decide on), based on previously discussions with 
packagers on similar cases.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

2020-03-29 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 78823.
gikari marked an inline comment as done.
gikari added a comment.


  - Rebase on master
  - Add recoloration module check

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77860=78823

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread Eugene Popov 
epopov added a comment.


  In D28408#637476 , @davidedmundson 
wrote:
  
  > As a question, rather than a researched proposal, is it better to check for 
the pin in?
  >
  > systemtray / PlasmoidItem.qml
  >
  >   Connections {
  >   target: applet
  >   onExpandedChanged: {
  >   
  
  
  We should be able to hide the pinned applet by clicking in the system tray 
(at least this can be done now).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-03-29 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:6f01f8040007: [GTK3] Add module to reload colorscheme in 
GTK3 apps without restarting them (authored by cblack).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28076?vs=78804=78817

REVISION DETAIL
  https://phabricator.kde.org/D28076

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28360: cmake: make xsettingsd check an option

2020-03-29 Thread Mikhail Zolotukhin 
gikari added a comment.


  In D28360#636687 , @kossebau wrote:
  
  >   Edit: and yes, I agree CMake has awful flaws here when it comes to our 
needs to properly communicate dependencies to fellow developers & packagers. I 
am trying to give you best practices done so far elsewhere in KDE software to 
deal with this, to ensure consistent patterns in the approach to the same 
problem :)
  
  
  Did I understand correctly, that to make the dependency required for 
distribution packagers you need to substitute existing code with the following 
(i.e. only change the `PURPOSE` text, but keep `find_package` as it was):
  
find_package(XSettingsd)
set_package_properties(XSettingsd PROPERTIES
DESCRIPTION "XSettingsd daemon"
TYPE RUNTIME
PURPOSE "Required to have GTK Config kded module to apply settings to 
GTK applications on the fly"
)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

2020-03-29 Thread Carson Black 
cblack updated this revision to Diff 78813.
cblack added a comment.


  Rerender toolbar when invalidating cached rects

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78754=78813

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread David Edmundson 
davidedmundson added a comment.


  As a question, rather than a researched proposal, is it better to check for 
the pin in?
  
  systemtray / PlasmoidItem.qml
  
Connections {
target: applet
onExpandedChanged: {

INLINE COMMENTS

> main.qml:158
> +
> +applet.configuration.pin = Qt.binding(function() { return 
> plasmoid.configuration.pin; });
>  

What happens when this is set with some other applet that doesn't have a pin 
config option?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

2020-03-29 Thread Heiko Becker 
heikobecker added a comment.


  In D28398#637401 , @apol wrote:
  
  > If plasma pass is part of plasma, which I'm not sure of, you can consider 
just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt 
for Plasma 5.19.
  
  
  It isn't part of plasma.

REPOSITORY
  R1028 Plasma Pass

REVISION DETAIL
  https://phabricator.kde.org/D28398

To: heikobecker, dvratil
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27669: [kstyle] Tools area

2020-03-29 Thread Hugo Pereira Da Costa 
hpereiradacosta added a comment.


  In D27669#637164 , @ndavis wrote:
  
  > I've discovered another bug. When you move a window by dragging on an empty 
area, all hover effects stop working.
  
  
  This bug has been here since forever and is not related to the changes in 
this patch.
  It is due to X11 eating one of Qt's mouse release events when starting to 
drag the window from empty areas. 
  It was fixed at some point in the distant past, and the re-introduced ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

2020-03-29 Thread Eugene Popov 
epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Klipper widget and then click on a history item, the Klipper 
widget closes.
  
  To fix this bug, we need to check if Klipped is pinned, but to be able to do 
this, we also need to "forward" the pinned state from the SystemTray applet to 
the Klipper applet.
  
  BUG 416510

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

2020-03-29 Thread Carson Black 
cblack updated this revision to Diff 78804.
cblack added a comment.


  Use KDE_INSTALL_LIBDIR

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28076?vs=77871=78804

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-29 Thread Mikhail Zolotukhin 
gikari added a comment.


  Everything is fine on CI.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-29 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:7f7a57095cf1: Improve CMake handling of GNOME libraries 
(authored by cblack).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=78590=78803

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Fixed!

2020-03-29 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/18/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 29 Mar 2020 16:33:28 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: projectroot.discover Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)Name: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 11 - Fixed!

2020-03-29 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/11/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 29 Mar 2020 16:33:28 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.discover Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)Name: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report68%
(13/19)69%
(75/108)69%
(75/108)63%
(3645/5801)48%
(1722/3567)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover100%
(12/12)100%
(12/12)75%
(597/792)54%
(256/470)discover.autotests100%
(1/1)100%
(1/1)100%
(100/100)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/64)0%
(0/40)libdiscover71%
(5/7)71%
(5/7)79%
(214/272)64%
(115/181)libdiscover.Category100%
(5/5)100%
(5/5)67%
(164/244)48%
(111/230)libdiscover.ReviewsBackend100%
(7/7)100%
(7/7)87%
(202/231)77%
(57/74)libdiscover.Transaction88%
(7/8)88%
(7/8)79%
(235/298)68%
(98/144)libdiscover.UpdateModel100%
(3/3)100%
(3/3)91%
(224/247)71%
(95/133)libdiscover.appstream0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/124)libdiscover.backends.DummyBackend82%
(9/11)82%
(9/11)84%
(265/315)75%
(124/166)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)97%
(250/259)53%
(143/268)libdiscover.backends.FwupdBackend0%
(0/8)0%
(0/8)0%
(0/555)0%
(0/271)libdiscover.backends.KNSBackend100%
(5/5)100%
(5/5)59%
(348/588)43%
(139/327)libdiscover.backends.KNSBackend.tests100%
(1/1)100%
(1/1)98%
(90/92)55%
(63/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/7)0%
(0/2)libdiscover.resources94%
(17/18)94%

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

2020-03-29 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1
  
  If plasma pass is part of plasma, which I'm not sure of, you can consider 
just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt 
for Plasma 5.19.

REPOSITORY
  R1028 Plasma Pass

REVISION DETAIL
  https://phabricator.kde.org/D28398

To: heikobecker, dvratil
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 10 - Still Failing!

2020-03-29 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/10/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 29 Mar 2020 16:25:33 +
 Build duration:
2 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 611 lines...][2020-03-29T16:27:33.493Z] [ 84%] Built target fwupd-backend[2020-03-29T16:27:33.493Z] [ 85%] Building CXX object discover/CMakeFiles/plasma-discover.dir/discoversettings.cpp.o[2020-03-29T16:27:33.493Z] [ 86%] Building CXX object discover/CMakeFiles/plasma-discover.dir/plasmauserfeedback.cpp.o[2020-03-29T16:27:33.756Z] [ 87%] Linking CXX executable ../../bin/CategoriesTest[2020-03-29T16:27:33.756Z] [ 88%] Building CXX object update/CMakeFiles/plasma-discover-update.dir/main.cpp.o[2020-03-29T16:27:34.018Z] [ 89%] Linking CXX executable ../bin/plasma-discover-exporter[2020-03-29T16:27:34.276Z] [ 90%] Building CXX object discover/CMakeFiles/plasma-discover.dir/main.cpp.o[2020-03-29T16:27:34.276Z] [ 90%] Built target CategoriesTest[2020-03-29T16:27:34.276Z] [ 91%] Building CXX object discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o[2020-03-29T16:27:34.847Z] [ 91%] Built target plasma-discover-exporter[2020-03-29T16:27:34.847Z] [ 92%] Building CXX object update/CMakeFiles/plasma-discover-update.dir/DiscoverUpdate.cpp.o[2020-03-29T16:27:35.106Z] [ 92%] Building CXX object discover/CMakeFiles/plasma-discover.dir/DiscoverDeclarativePlugin.cpp.o[2020-03-29T16:27:35.106Z] [ 93%] Building CXX object discover/CMakeFiles/plasma-discover.dir/FeaturedModel.cpp.o[2020-03-29T16:27:35.106Z] [ 94%] Building CXX object discover/CMakeFiles/plasma-discover.dir/PaginateModel.cpp.o[2020-03-29T16:27:36.042Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp: In lambda function:[2020-03-29T16:27:36.042Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp:30:18: error: invalid use of incomplete type ���class QDebug���[2020-03-29T16:27:36.042Z]30 | qWarning() << "message" << message;[2020-03-29T16:27:36.042Z]   |  ^[2020-03-29T16:27:36.042Z] In file included from /usr/include/qt5/QtCore/qglobal.h:1298,[2020-03-29T16:27:36.042Z]  from /usr/include/qt5/QtCore/qnamespace.h:43,[2020-03-29T16:27:36.042Z]  from /usr/include/qt5/QtCore/qobjectdefs.h:48,[2020-03-29T16:27:36.042Z]  from /usr/include/qt5/QtCore/qobject.h:46,[2020-03-29T16:27:36.042Z]  from /usr/include/qt5/QtCore/QObject:1,[2020-03-29T16:27:36.042Z]  from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.h:23,[2020-03-29T16:27:36.042Z]  from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp:20:[2020-03-29T16:27:36.042Z] /usr/include/qt5/QtCore/qlogging.h:57:7: note: forward declaration of ���class QDebug���[2020-03-29T16:27:36.042Z]57 | class QDebug;[2020-03-29T16:27:36.042Z]   |   ^~[2020-03-29T16:27:36.042Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp: In member function ���void DiscoverUpdate::start()���:[2020-03-29T16:27:36.042Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp:44:12: error: invalid use of incomplete type ���class QDebug���[2020-03-29T16:27:36.042Z]44 | qDebug() << "ready" << ResourcesModel::global()->updatesCount();[2020-03-29T16:27:36.042Z]   |^[2020-03-29T16:27:36.043Z] In file included from /usr/include/qt5/QtCore/qglobal.h:1298,[2020-03-29T16:27:36.043Z]  from /usr/include/qt5/QtCore/qnamespace.h:43,[2020-03-29T16:27:36.043Z]  from /usr/include/qt5/QtCore/qobjectdefs.h:48,[2020-03-29T16:27:36.043Z]  from /usr/include/qt5/QtCore/qobject.h:46,[2020-03-29T16:27:36.043Z]  from /usr/include/qt5/QtCore/QObject:1,[2020-03-29T16:27:36.043Z]  from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.h:23,[2020-03-29T16:27:36.043Z]  from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp:20:[2020-03-29T16:27:36.043Z] /usr/include/qt5/QtCore/qlogging.h:57:7: note: forward declaration of ���class QDebug���[2020-03-29T16:27:36.043Z]57 | class QDebug;[2020-03-29T16:27:36.043Z]   |   ^~[2020-03-29T16:27:36.043Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.14/update/DiscoverUpdate.cpp:46:12: error: invalid use of incomplete type ���class QDebug���[2020-03-29T16:27:36.043Z]46 | qDebug() << "steady" << m_resourcesUpdatesModel->rowCount({});[2020-03-29T16:27:36.043Z]   |^[2020-03-29T16:27:36.043Z] In file included from /usr/include/qt5/QtCore/qglobal.h:1298,[2020-03-29T16:27:36.043Z]  from /usr/include/qt5/QtCore/qnamespace.h:43,[2020-03-29T16:27:36.043Z]

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Failing!

2020-03-29 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/17/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 29 Mar 2020 16:25:33 +
 Build duration:
1 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 517 lines...][2020-03-29T16:26:55.472Z] Scanning dependencies of target plasma-discover-update[2020-03-29T16:26:55.472Z] [ 80%] Built target CategoriesTest[2020-03-29T16:26:55.472Z] [ 81%] Building CXX object update/CMakeFiles/plasma-discover-update.dir/plasma-discover-update_autogen/mocs_compilation.cpp.o[2020-03-29T16:26:55.472Z] [ 82%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummySourcesBackend.cpp.o[2020-03-29T16:26:57.521Z] [ 83%] Building CXX object update/CMakeFiles/plasma-discover-update.dir/main.cpp.o[2020-03-29T16:26:57.873Z] [ 83%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[2020-03-29T16:26:58.199Z] [ 84%] Building CXX object discover/CMakeFiles/plasma-discover.dir/discoversettings.cpp.o[2020-03-29T16:26:58.485Z] [ 85%] Building CXX object update/CMakeFiles/plasma-discover-update.dir/DiscoverUpdate.cpp.o[2020-03-29T16:26:59.990Z] [ 86%] Linking CXX shared module ../../../bin/kns-backend.so[2020-03-29T16:27:00.600Z] [ 86%] Built target kns-backend[2020-03-29T16:27:00.600Z] [ 87%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[2020-03-29T16:27:00.600Z] [ 88%] Linking CXX shared module ../../../bin/dummy-backend.so[2020-03-29T16:27:01.247Z] [ 88%] Built target dummy-backend[2020-03-29T16:27:01.247Z] [ 89%] Building CXX object discover/CMakeFiles/plasma-discover.dir/plasmauserfeedback.cpp.o[2020-03-29T16:27:01.898Z] [ 90%] Building CXX object discover/CMakeFiles/plasma-discover.dir/main.cpp.o[2020-03-29T16:27:02.930Z] /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.14/update/DiscoverUpdate.cpp:30:9: error: calling 'warning' with incomplete return type 'QDebug'[2020-03-29T16:27:02.930Z] qWarning() << "message" << message;[2020-03-29T16:27:02.930Z] ^~[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:166:93: note: expanded from macro 'qWarning'[2020-03-29T16:27:02.930Z] #define qWarning QMessageLogger(QT_MESSAGELOG_FILE, QT_MESSAGELOG_LINE, QT_MESSAGELOG_FUNC).warning[2020-03-29T16:27:02.930Z] ^[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:132:12: note: 'warning' declared here[2020-03-29T16:27:02.930Z] QDebug warning() const;[2020-03-29T16:27:02.930Z]^[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:57:7: note: forward declaration of 'QDebug'[2020-03-29T16:27:02.930Z] class QDebug;[2020-03-29T16:27:02.930Z]   ^[2020-03-29T16:27:02.930Z] /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.14/update/DiscoverUpdate.cpp:44:5: error: calling 'debug' with incomplete return type 'QDebug'[2020-03-29T16:27:02.930Z] qDebug() << "ready" << ResourcesModel::global()->updatesCount();[2020-03-29T16:27:02.930Z] ^~~~[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:164:91: note: expanded from macro 'qDebug'[2020-03-29T16:27:02.930Z] #define qDebug QMessageLogger(QT_MESSAGELOG_FILE, QT_MESSAGELOG_LINE, QT_MESSAGELOG_FUNC).debug[2020-03-29T16:27:02.930Z]   ^[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:126:12: note: 'debug' declared here[2020-03-29T16:27:02.930Z] QDebug debug() const;[2020-03-29T16:27:02.930Z]^[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:57:7: note: forward declaration of 'QDebug'[2020-03-29T16:27:02.930Z] class QDebug;[2020-03-29T16:27:02.930Z]   ^[2020-03-29T16:27:02.930Z] /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.14/update/DiscoverUpdate.cpp:46:5: error: calling 'debug' with incomplete return type 'QDebug'[2020-03-29T16:27:02.930Z] qDebug() << "steady" << m_resourcesUpdatesModel->rowCount({});[2020-03-29T16:27:02.930Z] ^~~~[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:164:91: note: expanded from macro 'qDebug'[2020-03-29T16:27:02.930Z] #define qDebug QMessageLogger(QT_MESSAGELOG_FILE, QT_MESSAGELOG_LINE, QT_MESSAGELOG_FUNC).debug[2020-03-29T16:27:02.930Z]   ^[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:126:12: note: 'debug' declared here[2020-03-29T16:27:02.930Z] QDebug debug() const;[2020-03-29T16:27:02.930Z]^[2020-03-29T16:27:02.930Z] /usr/local/include/qt5/QtCore/qlogging.h:57:7: note: forward declaration of 'QDebug'[2020-03-29T16:27:02.930Z] class QDebug;[2020-03-29T16:27:02.930Z]

D28389: Add support for logging categories

2020-03-29 Thread Aleix Pol Gonzalez 
apol added a comment.


  Other than that, the patch looks good. +1

INLINE COMMENTS

> romangg wrote in CMakeLists.txt:23
> Any idea how to reuse the declaration from the top-directory CMake file?

Make sure the include() call is before the add_subdirectory().

That's why we usually put them together on top right under the find_package() 
together with `include(ECMGenerateHeaders)`.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28389

To: romangg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28385: Remove unused file

2020-03-29 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:184cee85e9f5: Remove unused file (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28385?vs=78753=78802

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h

To: apol, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28339: [kapplymousetheme] Avoid loading QPT

2020-03-29 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:aa2212e25c92: [kapplymousetheme] Avoid loading QPT 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28339?vs=78640=78800

REVISION DETAIL
  https://phabricator.kde.org/D28339

AFFECTED FILES
  kcms/mouse/kapplymousetheme.cpp

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28369: [runners/recentdocuments] disable executables or .desktop files

2020-03-29 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:97bf7d777e56: [runners/recentdocuments] disable 
executables or .desktop files (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28369?vs=78712=78797

REVISION DETAIL
  https://phabricator.kde.org/D28369

AFFECTED FILES
  runners/recentdocuments/recentdocuments.cpp

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

2020-03-29 Thread David Faure 
dfaure added a comment.


  In D28286#637346 , @anthonyfieroni 
wrote:
  
  > Even 1200 is not problem to me.
  
  
  We seem to have very different opinions on good API design.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

2020-03-29 Thread David Edmundson 
davidedmundson added a comment.


  Be careful about mixing terms here.
  
  This absolutely does not change "the timezone". This changes what the applet 
shows. It is super super important that if a user travels to another country 
even for a vacation they update the system timezone.
  
  The reason this had a configuration option was because we need people to not 
use the wrong thing. The applet's timezone purpose is so you can show a clock 
of what time it is for your European colleagues or whatever.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28133

To: ngraham, #vdg, #plasma, jriddell, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

2020-03-29 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  In D28286#636881 , @dfaure wrote:
  
  > Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 
wrapper methods...
  
  
  Even 1200 is not problem to me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions

2020-03-29 Thread Andreas Cord-Landwehr 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:d2f44e46e758: QQC2-Desktop-Style: Convert license headers 
to SPDX expressions (authored by cordlandwehr).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28382?vs=78738=78788

REVISION DETAIL
  https://phabricator.kde.org/D28382

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/LicenseRef-KFQF-Accepted-GPL.txt
  LICENSES/LicenseRef-Qt-Commercial.txt
  Mainpage.dox
  kirigami-plasmadesktop-integration/kirigamiplasmafactory.cpp
  kirigami-plasmadesktop-integration/kirigamiplasmafactory.h
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h
  org.kde.desktop/BusyIndicator.qml
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckDelegate.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Container.qml
  org.kde.desktop/Control.qml
  org.kde.desktop/DelayButton.qml
  org.kde.desktop/Dial.qml
  org.kde.desktop/Dialog.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/Drawer.qml
  org.kde.desktop/Frame.qml
  org.kde.desktop/GroupBox.qml
  org.kde.desktop/ItemDelegate.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/Menu.qml
  org.kde.desktop/MenuBarItem.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/MenuSeparator.qml
  org.kde.desktop/Popup.qml
  org.kde.desktop/ProgressBar.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/RadioDelegate.qml
  org.kde.desktop/RangeSlider.qml
  org.kde.desktop/RoundButton.qml
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/ScrollView.qml
  org.kde.desktop/Slider.qml
  org.kde.desktop/SpinBox.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/SwitchDelegate.qml
  org.kde.desktop/SwitchIndicator.qml
  org.kde.desktop/TabBar.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/ToolBar.qml
  org.kde.desktop/ToolButton.qml
  org.kde.desktop/ToolTip.qml
  org.kde.desktop/private/DefaultListItemBackground.qml
  org.kde.desktop/private/FocusRect.qml
  org.kde.desktop/private/MobileCursor.qml
  org.kde.desktop/private/MobileTextActionsToolBar.qml
  plugin/kpropertywriter.cpp
  plugin/kpropertywriter_p.h
  plugin/kquickpadding_p.h
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h
  plugin/qqc2desktopstyleplugin.cpp
  plugin/qqc2desktopstyleplugin.h
  plugin/qsgdefaultninepatchnode.cpp
  plugin/qsgdefaultninepatchnode_p.h
  plugin/qsgninepatchnode.cpp
  plugin/qsgninepatchnode.h
  tests/LineEditWithClearButton.qml
  tests/buttonIcons.qml

To: cordlandwehr, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

2020-03-29 Thread Kai Uwe Broulik 
broulik planned changes to this revision.
broulik added a comment.


  Will rebase on pending API change in D28268 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

2020-03-29 Thread Kai Uwe Broulik 
broulik planned changes to this revision.
broulik added a comment.


  Will rebase on pending API change in D28268 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28347

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

2020-03-29 Thread Heiko Becker 
heikobecker created this revision.
heikobecker added a reviewer: dvratil.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  The former was introduced with Qt 5.14 while the latter was deprecated
  with 5.15 [1], causing the build to fail with that Qt version (because
  of -DQT_DISABLE_DEPRECATED_BEFORE=0x06).

TEST PLAN
  Builds

REPOSITORY
  R1028 Plasma Pass

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28398

AFFECTED FILES
  plugin/passwordfiltermodel.cpp

To: heikobecker, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart