D26719: [Battery Monitor] Glow icon on hover

ngraham added a comment. In D26719#596266 , @kmaterka wrote: > The question is: should I move this component somewhere else? PlasmaComponents3? It would live in PlasmaExtras; PlasmaComponents3 is just a theme for QtQuickControls2

D27271: [kcms/colors] RFC: Accent Colours

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a subscriber: cblack. ngraham added a comment. In D25728#640365 , @ngraham wrote: > With D27669 , it's probably time to revisit drawing this separator at all. We should probably be relying on the

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/20/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 14 Apr 2020 04:15:15 + Build duration: 22 sec and counting CONSOLE OUTPUT

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This'll need a rebase, as I landed the ExpandableListItem port a few days ago. INLINE COMMENTS > FullRepresentation.qml:31 > > -PlasmaBt.DevicesProxyModel { > -

D28575: Make headings of systray and applet merge

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. We could still have a sidebar that goes all the way to the top of the pop-up and also a grid of items on the main page rather than a flat list. The grid items could even animate to their

D28262: [applets/analog-clock] Optional minute hand

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm not sure I think this makes sense, sorry. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma, ngraham

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

ngraham added a comment. Okay. But then the difference between a sheet and a dialog is inherently nebulous: a short sheet is like a dialog; a tall dialog is like a sheet. In my mind it makes sense to use one thing for both and tweak the presentation accordingly. Clearly lots of people are

D28652: [Cursors] Remove Resolution Dependant option

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. But please remove the BUG: keywords for bugs that this patch does not actually fix (and ideally fix them in follow-up patches :) ) REPOSITORY R119 Plasma Desktop REVISION DETAIL

Re: Update on Status of Gitlab Migration

On 4/13/20 6:59 PM, Ben Cooksley wrote: Why do we need to mimic them? If you Google "KDE Gitlab" then the first hit is invent.kde.org . To flip it around: why do we need to do something different? I don't think it's about mimicking anyone else, but rather using the

Re: Update on Status of Gitlab Migration

On Tue, 14 Apr 2020, 11:45 am Aleix Pol, wrote: > On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley wrote: > > > > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham wrote: > > > > > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: > > > > Regarding this: is the subdomain going to stay invent.kde.org once

Re: Update on Status of Gitlab Migration

On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley wrote: > > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham wrote: > > > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: > > > Regarding this: is the subdomain going to stay invent.kde.org once we > > > have officially moved? I find it's a bit confusing

D28744: Rewrite of the global shortcuts kcm

ngraham added inline comments. INLINE COMMENTS > ShortcutActionDelegate.qml:67 > +Layout.alignment: Qt.AlignRight > +icon.name: "arrow-down" > +onClicked: { use `expand` > ShortcutActionDelegate.qml:94 > +

D28360: cmake: make xsettingsd check an option

eszlari abandoned this revision. eszlari added a comment. OK, found it. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28360: cmake: make xsettingsd check an option

eszlari added a comment. How can I close this? (phabricator UI really sucks, I hope the move to Gitlab is completed soon) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: rikmills, kossebau, ngraham, plasma-devel,

D28806: Provide light icon for dark mode via theme_icons

This revision was automatically updated to reflect the committed changes. Closed by commit R856:269da15cf9b4: Provide light icon for dark mode via theme_icons (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28744: Rewrite of the global shortcuts kcm

nicolasfella added a comment. When I open the KCM and type 'Krun' + Enter I find KRunner as expected, but I still need to click on the KRunner item to actually see the shortcuts. When I then type 'Yaku' + Enter Yakuake is shown correctly in the results, but clicking on the entry does not

D28744: Rewrite of the global shortcuts kcm

nicolasfella added a comment. I always get two horizontal scrollbars, no matter the window size: F8234349: Screenshot_20200413_212457.png The first Choqok shortcut is missing a name, not sure if that's an issue here or in Choqok F8234357:

D28806: Provide light icon for dark mode via theme_icons

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. For reference this is the bug report in firefox for adding js scripting: https://bugzilla.mozilla.org/show_bug.cgi?id=1416871 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D28806: Provide light icon for dark mode via theme_icons

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I recall we originally didn't do it when Noah added these icons as

D28744: Rewrite of the global shortcuts kcm

nicolasfella added a comment. Cool stuff! INLINE COMMENTS > kcm_keys.cpp:110 > +{ > +auto includedComponents = > m_shortcutsModel->match(m_shortcutsModel->index(0, 0), > ShortcutsModel::CheckedRole, true, -1); > +qCDebug(KCMKEYS) << "Exporting to " << url.toLocalFile(); const >

D28798: Make warning and error messages grammatically correct

This revision was automatically updated to reflect the committed changes. Closed by commit R845:d17f0e717fcf: Make warning and error messages grammatically correct (authored by ngraham). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28798?vs=80031=80043

D28724: Fix build

This revision was automatically updated to reflect the committed changes. Closed by commit R135:6d7fe9e5a504: Fix build (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28724?vs=79770=80042 REVISION

Re: Update on Status of Gitlab Migration

On Tue, Apr 14, 2020 at 3:35 AM Nate Graham wrote: > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: > > Regarding this: is the subdomain going to stay invent.kde.org once we > > have officially moved? I find it's a bit confusing to use that instead > > of gitlab.kde.org > > I agree.

D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. This is excellent work. A radical improvement over the existing KCM. In addition to the inline comments, here are some more general ones: - When a shortcut is to launch an app, and that shortcut's name would be identical to the app name, maybe we should

D28783: krunner: polish placement

apol updated this revision to Diff 80036. apol added a comment. DOn't set it to Dock type, all sort of bad things happen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28783?vs=79966=80036 BRANCH arcpatch-D28783 REVISION DETAIL

D28724: Fix build

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I don't really see why this would be necessary, but it's okay to add it. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix-build (branched from master) REVISION DETAIL

D28627: Adaptive panel opacity

cblack updated this revision to Diff 80035. cblack added a comment. Choreography fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79973=80035 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED

D28710: Make accidental panel and panel widget deletion more difficult

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ba66d2eabe38: Make accidental panel and panel widget deletion more difficult (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28710: Make accidental panel and panel widget deletion more difficult

davidedmundson added a comment. We shouldn't be making UX changes on the stable branch REPOSITORY R119 Plasma Desktop BRANCH make-accidental-panel-and-panel-widget-deletion-harder (branched from master) REVISION DETAIL https://phabricator.kde.org/D28710 To: ngraham, #vdg, #plasma,

D28710: Make accidental panel and panel widget deletion more difficult

ngraham updated this revision to Diff 80032. ngraham added a comment. Revert string change so it can be landed on the stable branch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28710?vs=79953=80032 BRANCH

D28798: Make warning and error messages grammatically correct

ngraham updated this revision to Diff 80031. ngraham added a comment. "because" is better REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28798?vs=80030=80031 BRANCH fix-grammar (branched from master) REVISION DETAIL

D28798: Make warning and error messages grammatically correct

ngraham updated this revision to Diff 80030. ngraham added a comment. ; -> as REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28798?vs=80028=80030 BRANCH fix-grammar (branched from master) REVISION DETAIL https://phabricator.kde.org/D28798

D28798: Make warning and error messages grammatically correct

ivan added a comment. Maybe "Unable to close the vault; it is being used by %1" -> "Unable to close the vault as it is being used by %1" ? "Unable to close the vault; an application is using it" -> "Unable to close the vault because an application is using it" While writing for

D28799: Refactor and fix the mobile wifi kcm

tfella created this revision. tfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. tfella requested review of this revision. REVISION SUMMARY Previous refactoring and existing errors made editing connections

D28724: Fix build

ngraham added a comment. Ping REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D28724 To: ngraham, davidre, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D28798: Make warning and error messages grammatically correct

ngraham created this revision. ngraham added reviewers: ivan, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY These messages are currently comma splices, which are incorrect. REPOSITORY R845 Plasma

KDE CI: Plasma » bluedevil » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 15:49:49 + Build duration: 59 sec and counting

Re: Update on Status of Gitlab Migration

On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: Regarding this: is the subdomain going to stay invent.kde.org once we have officially moved? I find it's a bit confusing to use that instead of gitlab.kde.org I agree. gitlab.kde.org would make more sense to me, mirroring phabricator.kde.org.

D28627: Adaptive panel opacity

niccolove added a comment. I feel like it makes sense for the user to want to use a opaque panel rather than a transparent one. Also, that relies on themes actually turning on the effect, while users could already benefit from it even on current themes if the setting was exposed. Also, that

D28791: Manually merge stored and default settings

This revision was automatically updated to reflect the committed changes. Closed by commit R856:f4aa77a29780: Manually merge stored and default settings (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28791?vs=80006=80018#toc REPOSITORY R856 Plasma Browser

D28710: Make accidental panel and panel widget deletion more difficult

ngraham added a comment. Since this doesn't add any new strings, it could potentially be considered a bugfix and make it into a 5.18 bugfix release. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28710 To: ngraham, #vdg, #plasma Cc: rikmills, broulik,

D28651: Load and use global animation settings

ngraham added a comment. In D28651#646418 , @sandsmark wrote: > I think it makes sense to have it both places, having it in the breeze settings avoids people having to go back and forth to tune their settings. I'm afraid I don't agree.

D28792: [Purpose Plugin] Open shared URL when clicking notification

ngraham added a comment. Very nice! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28792 To: broulik, #plasma, fvogt Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D28627: Adaptive panel opacity

apol added a comment. In D28627#646898 , @ngraham wrote: > +1 for making this a user-controllable setting, but how does it interact with plasma themes where there isn't any transparency? Can we only show this UI for plasma themes with

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik updated this revision to Diff 80011. broulik added a comment. - Closes after click REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28792?vs=80010=80011 REVISION DETAIL https://phabricator.kde.org/D28792 AFFECTED FILES

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik updated this revision to Diff 80010. broulik added a comment. - Also remove when closed REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28792?vs=80009=80010 REVISION DETAIL https://phabricator.kde.org/D28792 AFFECTED FILES

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When we get a URL back from the share provider, let clicking the notification open it.

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#647122 , @davidedmundson wrote: > As for runtime changes I'm trying to migrate more things to KConfigWatcher which I wrote to replace random ad-hoc ints everywhere as well as making sure we automatically

D28791: Manually merge stored and default settings

fvogt accepted this revision. fvogt added inline comments. INLINE COMMENTS > fvogt wrote in utils.js:39 > Why not if/else? I'd invert the condition REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28791 To: broulik, #plasma, fvogt Cc: plasma-devel,

D28651: Load and use global animation settings

davidedmundson added a comment. As for runtime changes I'm trying to migrate more things to KConfigWatcher which I wrote to replace random ad-hoc ints everywhere as well as making sure we automatically reparse the config once and only once. It's going to be /amazing/ but it's being

D28791: Manually merge stored and default settings

broulik updated this revision to Diff 80006. broulik added a comment. - if/else REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28791?vs=8=80006 REVISION DETAIL https://phabricator.kde.org/D28791 AFFECTED FILES

D28791: Manually merge stored and default settings

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Just have to make sure not to add anything to `DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings` now. Previously that would've been ignored. INLINE COMMENTS > utils.js:39 > +

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#646572 , @ndavis wrote: > You need to fix the git author info. If you upload a patch via the web UI instead of `arc`, the author info gets messed up. I usually just push normally after approval, but

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/19/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 12:36:28 + Build duration: 27 sec and counting CONSOLE OUTPUT

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R838:b8af0f136865: Make PipeWire, GBM and Epoxy libs as required dependencies (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich updated this revision to Diff 80001. jgrulich marked 2 inline comments as done. jgrulich added a comment. - Better naming for the cmake option disabling PipeWire REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28791: Manually merge stored and default settings

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY One can pass a default Object to `storage.get()` which will be used for keys that don't

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

romangg accepted this revision. romangg added a comment. Add the `const` and push. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28773 To: z3ntu, #plasma, bshah, nicolasfella, romangg Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

nicolasfella added inline comments. INLINE COMMENTS > config.cpp:99 > +{ > +auto outputs = m_data->outputs(); > +return std::all_of(outputs.cbegin(), outputs.cend(), const auto REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28773 To: z3ntu, #plasma, bshah,

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu updated this revision to Diff 79997. z3ntu added a comment. - extract m_data->outputs() into a variable REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28773?vs=79995=79997 BRANCH autorotate REVISION DETAIL https://phabricator.kde.org/D28773

D28650: [Notifications] Don't reverse() Array

nicolasfella added a comment. Related to the KDE Connect issue: https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/238 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28650 To: broulik, #plasma, nicolasfella Cc: plasma-devel, Orage, LeGast00n,

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

nicolasfella added inline comments. INLINE COMMENTS > config.cpp:99 > +{ > +return std::all_of(m_data->outputs().cbegin(), m_data->outputs().cend(), > +[this](KScreen::OutputPtr output) { extract m_data->outputs() into a variable. See

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. LGTM, Please wait for @romangg to approve. I am fine with behavior change of the, - method rename of lock -> set/getAutoRotate - all panels being considered for value of

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu updated this revision to Diff 79995. z3ntu added a comment. - const function, std::all_of REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28773?vs=79930=79995 BRANCH autorotate REVISION DETAIL https://phabricator.kde.org/D28773 AFFECTED FILES

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > Good morning Community, > > I'm pleased to report that this week we reached a major milestone, > with all the necessary technical components now being in place on our > side for our migration to Gitlab to take place. Regarding this: is the