Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

[Ben Cooksley]

Hi all,

Please see below - any ideas as to why KHelpCenter no longer successfully
builds?

It doesn't look like KHelpCenter has changed...

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Sat, Apr 18, 2020 at 4:38 PM
Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
FreeBSDQt5.14 - Build # 7 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20FreeBSDQt5.14/7/
Project: Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14
Date of build: Sat, 18 Apr 2020 04:09:43 +
Build duration: 28 min and counting
* CONSOLE OUTPUT *
[...truncated 117391 lines...]
[2020-04-18T04:38:09.745Z] Scanning dependencies of target testmetainfo
[2020-04-18T04:38:09.745Z] [ 22%] Built target
doc-onlinehelp-index-cache-bz2
[2020-04-18T04:38:09.745Z] [ 23%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/htmltextdump.cpp.o
[2020-04-18T04:38:10.007Z] [ 25%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/testmetainfo_autogen/mocs_compilation.cpp.o
[2020-04-18T04:38:10.007Z] [ 27%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/cachereader.cpp.o
[2020-04-18T04:38:10.007Z] [ 28%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/xapiancommon.cpp.o
[2020-04-18T04:38:10.007Z] [ 30%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/xapianindexer.cpp.o
[2020-04-18T04:38:10.007Z] [ 32%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/testmetainfo.cpp.o
[2020-04-18T04:38:10.007Z] [ 33%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/__/docmetainfo.cpp.o
[2020-04-18T04:38:10.007Z] [ 33%] Built target
doc-khelpcenter-index-cache-bz2
[2020-04-18T04:38:10.007Z] [ 35%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/__/docentry.cpp.o
[2020-04-18T04:38:10.265Z] [ 35%] Built target doc-glossary-index-cache-bz2
[2020-04-18T04:38:10.265Z] [ 37%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/__/docentrytraverser.cpp.o
[2020-04-18T04:38:10.524Z] [ 37%] Built target
doc-fundamentals-index-cache-bz2
[2020-04-18T04:38:10.524Z] [ 38%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/khc_debug.cpp.o
[2020-04-18T04:38:10.524Z] [ 38%] Built target kdeinit_khelpcenter_autogen
[2020-04-18T04:38:10.524Z] [ 40%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/prefs.cpp.o
[2020-04-18T04:38:11.094Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/khelpcenter/searchhandlers/cachereader.cpp:108:10: error: no
member named 'fromList' in 'QSet'; did you mean
'QStack::fromList'?
[2020-04-18T04:38:11.094Z] return QSet::fromList(
mRanges.uniqueKeys() );
[2020-04-18T04:38:11.094Z] ^~~
[2020-04-18T04:38:11.094Z] QStack::fromList
[2020-04-18T04:38:11.094Z] /usr/local/include/qt5/QtCore/qvector.h:301:23:
note: 'QStack::fromList' declared here
[2020-04-18T04:38:11.094Z] static QVector fromList(const QList );
[2020-04-18T04:38:11.094Z] ^
[2020-04-18T04:38:11.094Z] [ 42%] Generating prefs.h, prefs.cpp
[2020-04-18T04:38:11.094Z] 1 error generated.
[2020-04-18T04:38:11.094Z] gmake[2]: ***
[searchhandlers/CMakeFiles/khc_xapianindexer.dir/build.make:96:
searchhandlers/CMakeFiles/khc_xapianindexer.dir/cachereader.cpp.o] Error 1
[2020-04-18T04:38:11.094Z] gmake[2]: *** Waiting for unfinished jobs
[2020-04-18T04:38:11.354Z] [ 44%] Linking CXX executable
../bin/khc_xapiansearch
[2020-04-18T04:38:11.354Z] [ 44%] Built target khc_xapiansearch
[2020-04-18T04:38:11.354Z] Scanning dependencies of target
kdeinit_khelpcenter
[2020-04-18T04:38:11.354Z] [ 47%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigatorappgroupitem.cpp.o
[2020-04-18T04:38:11.354Z] [ 47%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/kdeinit_khelpcenter_autogen/mocs_compilation.cpp.o
[2020-04-18T04:38:11.354Z] [ 49%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/searchwidget.cpp.o
[2020-04-18T04:38:11.354Z] [ 50%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/docmetainfo.cpp.o
[2020-04-18T04:38:11.354Z] [ 54%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigator.cpp.o
[2020-04-18T04:38:11.354Z] [ 54%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigatoritem.cpp.o
[2020-04-18T04:38:11.354Z] [ 57%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/view.cpp.o
[2020-04-18T04:38:11.354Z] [ 57%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigatorappitem.cpp.o
[2020-04-18T04:38:11.354Z] [ 59%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/searchengine.cpp.o
[2020-04-18T04:38:11.354Z] [ 61%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/docentrytraverser.cpp.o
[2020-04-18T04:38:11.613Z] gmake[1]: *** [CMakeFiles/Makefile2:570:
searchhandlers/CMakeFiles/khc_xapianindexer.dir/all] Error 2
[2020-04-18T04:38:11.614Z] gmake[1]: *** Waiting for unfinished jobs
[2020-04-18T04:38:11.614Z] [ 62%] Building 

[plasmashell] [Bug 191394] add "minimize all" action to window list plasmoid

[João Vidal da Silva]

https://bugs.kde.org/show_bug.cgi?id=191394

--- Comment #17 from João Vidal da Silva  ---
It should also be an action assignable to the keyboard.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 353463] RFE: Make use of iio-sensor-proxy

[Ulf Bartholomäus]

https://bugs.kde.org/show_bug.cgi?id=353463

Ulf Bartholomäus  changed:

   What|Removed |Added

 CC||u...@gmx.net

--- Comment #12 from Ulf Bartholomäus  ---
Any news about this request?

So at my Fujitsu U939X - iio-sensor-proxy seems to work:
> monitor-sensor 
Waiting for iio-sensor-proxy to appear
+++ iio-sensor-proxy appeared
=== Has accelerometer (orientation: normal)
=== No ambient light sensor
Accelerometer orientation changed: left-up
Accelerometer orientation changed: normal
Accelerometer orientation changed: right-up
Accelerometer orientation changed: normal
Accelerometer orientation changed: bottom-up

-- 
You are receiving this mail because:
You are the assignee for the bug.

D28926: Signal player gone in "unload" not "beforeunload"

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I don't recall if there was a particular reason for using *before* unload but 
this event is not emitted for iframes.
  Using "unload" instead makes an iframe content script notice it's being 
destroyed (e.g. because of the overlay it was in being removed) and correctly 
signals the player being gone.
  We did noticed a video in an overlay being removed but not when it was inside 
of an iframe.

TEST PLAN
  - media controller hides when closing YouTube videos in overlays on websites, 
e.g. https://www.winhistory.de/more/nt31.htm
  - media controller hides when closing a video on tweetdeck.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28926

AFFECTED FILES
  extension/content-script.js
  extension/extension-mpris.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> hchain wrote in plasma-core@.target:3
> can we make this `plasma-kwin@%i.service` ?

can do, the _ is just to match the binary name

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D28305: WIP: Systemd Startup

[Henri Chain]

hchain added inline comments.

INLINE COMMENTS

> plasma-core@.target:3
> +Description=KDE Plasma Workspace Core
> +Wants=plasma-plasmashell.service plasma-kwin_%i.service 
> plasma-kcminit.service plasma-kded.service plasma-kcminit-phase1.service
> +Requires=plasma-ksmserver.service

can we make this `plasma-kwin@%i.service` ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D28730: Couple of 'trivial' fixes for broken code

[Johan Ouwerkerk]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:57c63e7ceeb9: Couple of trivial fixes for 
broken code (authored by ouwerkerk).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28730?vs=79789=80413

REVISION DETAIL
  https://phabricator.kde.org/D28730

AFFECTED FILES
  src/controls/private/ActionButton.qml
  src/controls/templates/SwipeListItem.qml

To: ouwerkerk, #kirigami, cblack
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28730: Couple of 'trivial' fixes for broken code

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R169 Kirigami

BRANCH
  fixes-for-qt_quick_controls_mobile

REVISION DETAIL
  https://phabricator.kde.org/D28730

To: ouwerkerk, #kirigami, cblack
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson updated this revision to Diff 80412.
davidedmundson added a comment.


  support x11 and wayland ...ish
  
  we now call target plasma-workspace@x11 or plasma-workspace@wayland   it then 
can call the right services
  but kwin_wayland is still currently spawned before the systemd stuff

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28305?vs=79106=80412

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28305

AFFECTED FILES
  CMakeLists.txt
  config-workspace.h.cmake
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/plasma-gmenudbusproxy.service.in
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/plasma-krunner.service.in
  ksmserver/CMakeLists.txt
  ksmserver/plasma-ksmserver.service.in
  ksmserver/server.cpp
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop.cmake
  shell/plasma-plasmashell.service.in
  startkde/CMakeLists.txt
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/plasma-kcminit-phase1.service.in
  startkde/kcminit/plasma-kcminit.service.in
  startkde/plasma-core@.target
  startkde/plasma-ksplash-ready.service.in
  startkde/plasma-workspace@.target
  startkde/startplasma.cpp
  xembed-sni-proxy/CMakeLists.txt
  xembed-sni-proxy/plasma-xembedsniproxy.service.in
  xembed-sni-proxy/xembedsniproxy.desktop

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80408.
apol added a comment.


  Renamed classes

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80340=80408

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added a comment.


  Go ahead, although we're migrating patch review to GitLab in the coming 
weeks, so the benefit may be short-lived. :)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28658: [krdb] Drop GTK2 colour exporting

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2fb0bf85fe63: [krdb] Drop GTK2 colour exporting (authored 
by cblack).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28658?vs=79579=80406

REVISION DETAIL
  https://phabricator.kde.org/D28658

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma, ngraham, davidedmundson
Cc: gikari, fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80405.
davidre added a comment.


  - Use less DBus calls for loading

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80398=80405

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> broulik wrote in shortcutsmodel.cpp:38
> Hmm...
> how about
> 
>   QStringList actionId;
>   actionId.reserve(4);

This actually crashes now

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28917: [Media Controller] Don't set album art on tooltip anymore

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:38c269dc486d: [Media Controller] Dont set album art 
on tooltip anymore (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28917?vs=80378=80404

REVISION DETAIL
  https://phabricator.kde.org/D28917

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Konstantinos Smanis]

ksmanis added a comment.


  In D28914#650523 , @ngraham wrote:
  
  > Can you provide your email address in a comment here so that we can land 
the patch with the correct git authorship information?
  
  
  I'd like to give arcanist a spin, if possible :)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Marco Martin]

mart updated this revision to Diff 80403.
mart added a comment.


  - port to the new library

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=79120=80403

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/faces/CMakeLists.txt
  applets/systemmonitor/systemmonitor/faces/barchart/contents/config/main.xml
  applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/BarChart.qml
  
applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/barchart/metadata.desktop
  applets/systemmonitor/systemmonitor/faces/linechart/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/LineChart.qml
  applets/systemmonitor/systemmonitor/faces/linechart/metadata.desktop
  applets/systemmonitor/systemmonitor/faces/piechart/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/PieChart.qml
  applets/systemmonitor/systemmonitor/faces/piechart/metadata.desktop
  applets/systemmonitor/systemmonitor/faces/table/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/faces/table/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/table/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/table/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/table/metadata.desktop
  
applets/systemmonitor/systemmonitor/faces/textonly/contents/ui/CompactRepresentation.qml
  
applets/systemmonitor/systemmonitor/faces/textonly/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/textonly/metadata.desktop
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  The plasmoid loginc has been ported in the SensorFaceController public class
  it's its responsibility to instantiate the right qml files to load a face and 
  writes all the face config in the KConfigGroup provided by the class 
constructor
  
  the sensorfacecontroller will always be accessible as a property from the 
face 
  qml, ro read and write the config paramenters

REPOSITORY
  R111 KSysguard Library

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/ConfigAppearance.qml
  sensors/ConfigSensors.qml
  sensors/FaceDetailsConfig.qml
  sensors/SensorFace.cpp
  sensors/SensorFaceController.cpp
  sensors/SensorFaceController.h
  sensors/SensorFace_p.h
  sensors/SensorInfo_p.h
  sensors/UsedSensorsView.qml
  sensors/declarative/CMakeLists.txt
  sensors/declarative/SensorFace.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/qmldir
  sensors/resources.qrc

To: mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added a comment.


  Can you provide your email address in a comment here so that we can land the 
patch with the correct git authorship information?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added reviewers: ivan, VDG.
ngraham added inline comments.

INLINE COMMENTS

> mountdialog.cpp:34
>  m_ui.setupUi(this);
> +setWindowTitle(i18nc("%1 is the name of the Plasma Vault to open", "Open 
> %1 Plasma Vault", vault->name()));
>  

Maybe put the vault name in single quotes?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80398.
davidre added a comment.


  - Fix defaults

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80387=80398

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

[Luca Weiss]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:67980bc2728d: feat(kded): add getAutoRotate method and 
rename lockAutoRotate (authored by z3ntu).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28773?vs=80393=80395

REVISION DETAIL
  https://phabricator.kde.org/D28773

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: z3ntu, #plasma, bshah, nicolasfella, romangg
Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

[Luca Weiss]

z3ntu updated this revision to Diff 80393.
z3ntu added a comment.


  - const auto

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28773?vs=79997=80393

BRANCH
  autorotate

REVISION DETAIL
  https://phabricator.kde.org/D28773

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: z3ntu, #plasma, bshah, nicolasfella, romangg
Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> davidedmundson wrote in OsdSelector.qml:34
> That was confusing, I'll rephrase.
> 
> Is it so the property "x" remains unset when running under the x windowing 
> environment?

Yes I wanted to ensure we don't change it on X
Didn't found a way to do it with a binding

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28509: RFC: [libnotificationmanager] introduce the notification watcher

[Bhushan Shah]

bshah added a comment.


  Great! Since phab ate my nice commit message here we go,
  
  I've re-worked previous revision of patch little bit differently,
  
  - Instead of originally planned Watcher class, now there is 
WatchedNotificationsModel
  - Most if not all of original NotificationsModel code is now moved to 
AbstractNotificationsModel (this move is why the patch looks giant, but there's 
not that much extra code)
  - WatchedNotificationsModel extends AbstractNM, and instead of connecting to 
notification server instance directly, it talks with notificationmanager dbus 
interface
  - And when methods on this bus are called, it adds data in model.
  
  There's some bugs and todos, but they are small enough:
  
  - Unregister watcher when dbus service disappears
  - Fix the notification body being weird xml
  - Maybe add the test.qml I used for testing in repository
  
  I particularly need direction/help for issue 2.
  
  As for testing this, I made sure that all functions of notifications are 
functional in the notification applet in plasmoidviewer and on watcher side 
checked if actions are correctly invoked, notifications are added removed 
properly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28509

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  This is looking really good. Other than my previous comments (most of which 
have been resolved, yay) I have just nitpicks left, really.

INLINE COMMENTS

> ShortcutActionDelegate.qml:165
> +onClicked: 
> kcm.shortcutsModel.disableShortcut(originalIndex, modelData)
> +QQC2.ToolTip {
> +text: i18n("Delete this shortcut")

This tooltip is not working for me

> shortcutsmodel.cpp:165
> +
> +void ShortcutsModel::defaults() {
> +for (auto& component : m_components) {

Clicking the Defaults button does not seem to have any effect for me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in OsdSelector.qml:34
> Why are we going for this  instead of a binding?
> 
> Is it so X and Y remain unset on X?

That was confusing, I'll rephrase.

Is it so the property "x" remains unset when running under the x windowing 
environment?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> OsdSelector.qml:34
> +
> +onScreenGeometryChanged: {
> +root.x = screenGeometry.x + (screenGeometry.width - mainItem.width) 
> / 2

Why are we going for this  instead of a binding?

Is it so X and Y remain unset on X?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28509: RFC: [libnotificationmanager] introduce the notification watcher

[Bhushan Shah]

bshah updated this revision to Diff 80391.
bshah marked 3 inline comments as done.
bshah added a comment.


  - kill separate watcher class
  - introduce AbstractNotificationsModel
  - introduce WatchedNotificationsModel

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28509?vs=79122=80391

BRANCH
  bshah/notification-watcher

REVISION DETAIL
  https://phabricator.kde.org/D28509

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/abstractnotificationsmodel.cpp
  libnotificationmanager/abstractnotificationsmodel.h
  libnotificationmanager/abstractnotificationsmodel_p.h
  libnotificationmanager/dbus/org.freedesktop.Notifications.xml
  libnotificationmanager/dbus/org.kde.notificationmanager.xml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/watchednotificationsmodel.cpp
  libnotificationmanager/watchednotificationsmodel.h

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Also happy @davidedmundson ?

INLINE COMMENTS

> osd.cpp:33
> +#include 
> +#include 
>  

Correct lexicographical order on push.

> osd.cpp:143
>  if (auto *rootObject = m_osdActionSelector->rootObject()) {
> +// On wayland use m_output to set action OSD position
> +if (qGuiApp->platformName() == QLatin1String("wayland")) {

Correct grammar on push.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80387.
davidre added a comment.


  - Remove components as good as the current kcm

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80224=80387

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28653: Set cursor size default to 24 to align with KCM default value

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:4a7786999d31: Set cursor size default to 24 to align with 
KCM default value (authored by bport).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28653?vs=79570=80380

REVISION DETAIL
  https://phabricator.kde.org/D28653

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28655: Set default cursor size as 24 to follow new default on KCM

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d19c5fc0fa7: Set default cursor size as 24 to follow new 
default on KCM (authored by bport).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28655?vs=79572=80381

REVISION DETAIL
  https://phabricator.kde.org/D28655

AFFECTED FILES
  startkde/startplasma.cpp

To: bport, #plasma, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28652: [Cursors] Remove Resolution Dependant option

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a68554d39c5c: [Cursors] Remove Resolution Dependant 
option (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28652?vs=79590=80379

REVISION DETAIL
  https://phabricator.kde.org/D28652

AFFECTED FILES
  doc/kcontrol/cursortheme/index.docbook
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/delete_cursor_old_default_size.pl
  kcms/cursortheme/delete_cursor_old_default_size.upd
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/krdb/krdb.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/mouse/backends/x11/x11_backend.cpp

To: bport, #plasma, meven, davidedmundson, ngraham
Cc: ngraham, plasma-devel, kde-doc-english, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, gennad, fbampaloukas, ragreen, ZrenBot, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28917: [Media Controller] Don't set album art on tooltip anymore

[Kai Uwe Broulik]

broulik updated this revision to Diff 80378.
broulik added a comment.


  - Set default state
  
  (It's overridden by the `State` below for stopped, playing, paused, but 
doesn't hurt to have it as fallback with the other props I guess)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28917?vs=80377=80378

REVISION DETAIL
  https://phabricator.kde.org/D28917

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28917: [Media Controller] Don't set album art on tooltip anymore

[Nathaniel Graham]

ngraham added a comment.


  Hmm, `plasmoid.icon` should probably still be set so it has the right 
appearance in the tray; we just modified the other components to not show that 
same icon on the tooltip.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28917

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28917: [Media Controller] Don't set album art on tooltip anymore

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We don't show icons on tooltips anymore.
  And the System Tray config doesn't show images.
  
  BUG: 420197
  FIXED-IN: 5.19.0

TEST PLAN
  Untested but I'm pretty sure that's the reason for the bug

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28917

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Benjamin Port]

bport created this revision.
bport added reviewers: romangg, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Currently on wayland action OSD is not centered on the screen.
  On Wayland we will center it on m_output (laptop, with fallback to primary 
and then to first one).
  X behavior is not changed.
  
  BUG: 397586

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

AFFECTED FILES
  kded/osd.cpp
  kded/qml/OsdSelector.qml

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Konstantinos Smanis]

ksmanis created this revision.
ksmanis added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ksmanis requested review of this revision.

REVISION SUMMARY
  Allows synergy with password managers that rely on the window title in order 
to supply the appropriate password.

TEST PLAN
  Compiles and runs as expected both on master and Plasma/5.18 branches.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

AFFECTED FILES
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.ui

To: ksmanis, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28907: [Services Runner] Fix mimeDataForMatch

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08bafc3b44ab: [Services Runner] Fix mimeDataForMatch 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28907?vs=80358=80373

REVISION DETAIL
  https://phabricator.kde.org/D28907

AFFECTED FILES
  runners/services/servicerunner.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6d25115e4627: [libtaskmanager] Port KRun::runApplication 
to KIO::ApplicationLauncherJob (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28906?vs=80357=80372#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28906?vs=80357=80372

REVISION DETAIL
  https://phabricator.kde.org/D28906

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28853: krunner: Prevent regression

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a28e110cbb15: krunner: Prevent regression (authored by 
apol, committed by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28853?vs=80192=80371

REVISION DETAIL
  https://phabricator.kde.org/D28853

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol, #plasma, fvogt
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28905: Fix variable assignment

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:70fa173d466a: Fix variable assignment (authored by 
broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28905?vs=80354=80370

REVISION DETAIL
  https://phabricator.kde.org/D28905

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: broulik, #plasma, hein, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  beautiful

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28906

To: broulik, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[David Redondo]

davidre added a comment.


  I don't understand. The palette doesn't change when a widget is selected, 
does it?  The selected state is used by KIconLoader to decide which color to 
use for text color, or highlight
  
state == KIconLoader::SelectedState ? pal.highlightedText().color().name() 
: pal.windowText().color().name(),

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[Kai Uwe Broulik]

broulik added a comment.


  Now that we can properly recolorize all the icons, maybe we should drop the 
`State_Selected` handling altogether?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  When hovering a focused combobox the icon was in Selected  state resulting in 
a wrong color.

TEST PLAN
  Hover over a focused combobox that has an icon

REPOSITORY
  R31 Breeze

BRANCH
  combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28908

AFFECTED FILES
  kstyle/breezestyle.cpp

To: davidre, broulik, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28907: [Services Runner] Fix mimeDataForMatch

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Regression introduced in 6e660cf92d7c3fb0e20527866691eaff9f8bc207 
 
since it's now a URL with a scheme, e.g. "applications".
  Service actions cannot be dragged out but that wasn't the case before either 
I believe.

TEST PLAN
  - Can drag application results out on my desktop and task bar again
  - Can drag kcms (where the absolute path resolution is needed) out on my 
desktop and task bar again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28907

AFFECTED FILES
  runners/services/servicerunner.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Launching pinned apps still works
  - Failure to launch results in a nice plasma notification now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28906

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28830: Don't set a custom palette if we have the same palette as the currently active one

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:66d0b0b4e3e1: Dont set a custom palette if we have 
the same palette as the currently active… (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28830?vs=80127=80356#toc

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28830?vs=80127=80356

REVISION DETAIL
  https://phabricator.kde.org/D28830

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28905: Fix variable assignment

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Noticed this while refactoring something in the area.

TEST PLAN
  5.18,
  Not sure what the effect of this was. Probably made default browser launching 
not as nice. Since it falls back to using `new KRun(...)` probably had no 
visible effect

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28905

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28904: Cleanup dependencies

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> CMakeLists.txt:20
>  
> -find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus 
> X11Extras)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth 
> IdleTime Config DBusAddons Solid I18n GlobalAccel KIO NotifyConfig Wayland 
> DocTools Crash Notifications)
> +find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus 
> Network X11Extras)
> +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth 
> IdleTime Config DBusAddons Service Solid I18n GlobalAccel NotifyConfig 
> Wayland DocTools Crash Notifications WidgetsAddons XmlGui)

That's not right at least. It should be optional when KF5NetworkManagerQt is 
found. It looks weird to present at all.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28904

To: broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> waylandintegration_p.h:126
>  KWayland::Client::FakeInput *m_fakeInput = nullptr;
> -KWayland::Client::RemoteAccessManager *m_remoteAccessManager = nullptr;
> +KWayland::Client::VideoStreaming *m_remoteAccessManager = nullptr;
>  

Shouldn't we rename this variable so it reflects the interface it uses?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28884

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28853: krunner: Prevent regression

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Proper fix with refactoring will take too long, let's take this for now.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28853

To: apol, #plasma, fvogt
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28904: Cleanup dependencies

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  That unused `EditPage::openUrl` pulled in `KIOWidgets` with all its 
dependencies.
  This includes `KCompletion` which implicitly made that `KComboBox` work.
  Remove this and clean up the dependencies.
  `NetworkManagerQt` seems to pull in `Qt::Network` but doesn't automatically 
find it.

TEST PLAN
  - Still builds
  - Battery crtical combo still works

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28904

AFFECTED FILES
  CMakeLists.txt
  daemon/actions/bundled/CMakeLists.txt
  kcmodule/global/CMakeLists.txt
  kcmodule/global/generalPage.ui
  kcmodule/profiles/CMakeLists.txt
  kcmodule/profiles/EditPage.cpp
  kcmodule/profiles/EditPage.h

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28904: Cleanup dependencies

[Kai Uwe Broulik]

broulik updated this revision to Diff 80351.
broulik edited the test plan for this revision.
broulik added a comment.


  - Drop all `KComboBox` uses

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28904?vs=80350=80351

REVISION DETAIL
  https://phabricator.kde.org/D28904

AFFECTED FILES
  CMakeLists.txt
  daemon/actions/bundled/CMakeLists.txt
  daemon/actions/bundled/runscriptconfig.cpp
  daemon/actions/bundled/runscriptconfig.h
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.h
  kcmodule/global/CMakeLists.txt
  kcmodule/global/generalPage.ui
  kcmodule/profiles/CMakeLists.txt
  kcmodule/profiles/EditPage.cpp
  kcmodule/profiles/EditPage.h

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28830: Don't set a custom palette if we have the same palette as the currently active one

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Fixes the Dolphin toolbar icon color and KWrite save dialog button icon color.

INLINE COMMENTS

> breezehelper.cpp:1608
> +if (changePalette) {
> +if(activePalette == QPalette()) {
> +KIconLoader::global()->resetPalette();

Coding style

REPOSITORY
  R31 Breeze

BRANCH
  ffs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28830

To: davidre, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28893: Detect Vivaldi based on binary name

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:97981b214ab6: Detect Vivaldi based on binary name 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28893?vs=80316=80347

REVISION DETAIL
  https://phabricator.kde.org/D28893

AFFECTED FILES
  CMakeLists.txt
  host/CMakeLists.txt
  host/settings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28893: Detect Vivaldi based on binary name

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Tested, works. I didn't even notice that it broke...
  
  Will probably have to be refactored later to look at 
`environmentDescriptions` or `environmentNames` though.
  
  > Should be good for 5.18 - coreaddons should have been an implicit 
dependency anyway?
  
  Yup.
  
  > Its icon doesn't show up and I have no idea where the "vivadi" icon file it 
specifies in its desktop file is located
  
  Here it used `xdg-icon-resource install ...` to install the icon in an rpm 
%post script, so I've got `/usr/share/icons/hicolor/*x*/apps/vivaldi.png` as 
usual.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28893

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart