D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

apol added inline comments. INLINE COMMENTS > main.qml:92 > +function onExtraItemsChanged() { > +plasmoid.nativeInterface.allowedPlasmoids = > plasmoid.configuration.extraItems > } Why's this needed? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28888: Fix navigation regressions

ndavis added a comment. Thanks, this fixes the navigation issue after a page has been selected. The main grid view is still annoying though. REPOSITORY R1014 Kirigami Gallery BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28888: Fix navigation regressions

cblack updated this revision to Diff 81713. cblack added a comment. Use normal list delegates REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81214=81713 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. This fix should go with Plasma 5.19, if it is not too late (code freeze). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspaces, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n,

D29111: [applet] Port to Kirigami.PlaceholderMessage

filipf added a comment. Yeah we shouldn't be mixing Kirigami with Plasma. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham, #vdg, #plasma, drosca, niccolove Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

Re: Information regarding upcoming Gitlab Migration

On Sat, May 2, 2020 at 9:04 AM Nate Graham wrote: > > On 5/1/20 2:09 PM, Ben Cooksley wrote: > > Unfortunately sharing of projects/repositories across groups does not > > impact on tasks and reviews. > > This means that merge requests for Planet (which is currently shared > > with "KDE") do not

D29111: [applet] Port to Kirigami.PlaceholderMessage

ngraham added a comment. Works for me with a 1x scale factor. Seems like a pre-existing scaling bug. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham, #vdg, #plasma, drosca, niccolove Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

Re: Information regarding upcoming Gitlab Migration

On 5/1/20 2:09 PM, Ben Cooksley wrote: Unfortunately sharing of projects/repositories across groups does not impact on tasks and reviews. This means that merge requests for Planet (which is currently shared with "KDE") do not show up in the list of merge requests for "KDE". Sharing repositories

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf updated this revision to Diff 81709. filipf added a comment. Ditch OpacityAnimator and use PropertyAnimation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29351?vs=81707=81709 BRANCH no-logo-leak (branched from master) REVISION DETAIL

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf added a comment. This kills the animation though... I found this comment in other code: "//OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" I'm able to get this opacity fading effect though without the bug if I switch from using OpacityAnimator

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into

D29111: [applet] Port to Kirigami.PlaceholderMessage

broulik added a comment. This now gives me a tiny icon on the button because this is a //Kirigami// component using desktop style: F8276714: Screenshot_20200501_221556.png REPOSITORY R97 Bluedevil REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration

On Sat, May 2, 2020 at 6:17 AM Alexander Potashev wrote: > > On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: > > Use case 4 : Tom is a student in Germany and is interested in > > contributing to wikitolearn, and he asks where can I find code of the > > wikitolearn? > > Hi, Hi Alexander, >

Re: Information regarding upcoming Gitlab Migration

On Sat, May 2, 2020 at 2:33 AM Adriaan de Groot wrote: > > On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > > If I'm understanding things, we have solutions to most or all of the > > > objections raised so far: > > > > > > -

Re: Information regarding upcoming Gitlab Migration

> On 1 May 2020, at 15:17, Alexander Potashev wrote: > > On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: >> Use case 4 : Tom is a student in Germany and is interested in >> contributing to wikitolearn, and he asks where can I find code of the >> wikitolearn? > > Hi, > > I have a

D29326: Bookmarks Runner: Fix extraction of firefox profile

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The summary needs some text which works without any images The code needs some comment which tells how the selection logic works and why it is as it is. INLINE COMMENTS >

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: > Use case 4 : Tom is a student in Germany and is interested in > contributing to wikitolearn, and he asks where can I find code of the > wikitolearn? Hi, I have a similar use case. Sometimes I need to share a URL to a project. For this

Re: Information regarding upcoming Gitlab Migration: clarifications

Ben Cooksley ha scritto: > On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: >> >> >> >> On 4/30/20 5:59 PM, Aleix Pol wrote: >>> El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid Am I the only person that just has all the repos on the same folder? I thought it was the

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham added a comment. Discover has the same issue. I guess I should look into fixing KAuth or Polkit or whatever is responsible for this. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma

D29333: Don't show an empty error dialog when canceling the sync password prompt

filipf added a comment. Yeah, this is also an issue when clicking cancel on a password prompt in sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling theme deletion an empty inline message pops up :/ We could work around all four though. I'm of the opinion

D29344: [applets/systemtray] Fix ivisible plasmoid icons when new plasmoid added

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY After adding a new plasmoid (applet), for example a new Media

D28487: Redesign of system monitor plasmoids

ahiemstra added a comment. In D28487#661262 , @ksmanis wrote: > Is there an ETA for this? Is it worth fixing any bugs in the old applets in the meantime? We'd really like this in 5.19, but it's a pretty large set of changes in multiple

D28487: Redesign of system monitor plasmoids

ngraham added a comment. In D28487#661262 , @ksmanis wrote: > Is there an ETA for this? Hopefully Plasma 5.19! But given the closeness to the release, we might end up punting it until 5.20. Either way, one of those two. > Is it

Re: Information regarding upcoming Gitlab Migration: clarifications

On 5/1/20 9:02 AM, Johan Ouwerkerk wrote: No, that is not the default. Actually, it is: https://invent.kde.org/kde/kdesrc-build/-/blob/master/kdesrc-build-setup#L389 and download all repos into ~/kde/src without any of the levels of hierarchy. But it is sufficiently common that there

D28487: Redesign of system monitor plasmoids

ksmanis added a comment. Is there an ETA for this? Is it worth fixing any bugs in the old applets in the meantime? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage,

D28686: [Battery Monitor] Choose better wording

shubham added a comment. @broulik Friendly ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D29297: [Notifications] Have checkIndex check if the index is valid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f2e34dbbd3b9: [Notifications] Have checkIndex check if the index is valid (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. > Docs explicitly say this. When you reference some "docs" please take 20 seconds and directly link it. Every piece you write here and in git commit messages is potentially read by

Re: repo freeze tomorrow

So modules to be released are same as last time plus kwayland-server. The cmake setup of the repo looks good to me. Let me know if you need any help releasing plasma-wayland-protocols Jonathan On Fri, 1 May 2020 at 02:13, Aleix Pol wrote: > On Thu, Apr 30, 2020 at 7:57 PM Rik Mills wrote:

D29319: KCM Plasmasearch: Do not intialize runners in config module

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a07b68a0093c: KCM Plasmasearch: Do not intialize runners in config module (authored by alex). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29319: KCM Plasmasearch: Do not intialize runners in config module

alex updated this revision to Diff 81692. alex added a comment. Change username from commit And thanks for the fast reviews! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29319?vs=81645=81692 BRANCH arcpatch-D29319 REVISION DETAIL

D27011: Update plasma startup sequence README

davidedmundson abandoned this revision. davidedmundson added a comment. There have been changes since. I think the new code is better at being self documenting, and that's at least up to date. I'll just rm this file REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4f3835904ccd: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY In the current code OpacityMask's source is the parent which contains itself, which doesn't make sense. Docs

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 6:38 AM Nate Graham wrote: > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > >> Am I the only person that just has all the repos on the same folder? I > >> thought it was the common thing to do :? > > > > I do too >

D29333: Don't show an empty error dialog when canceling the sync password prompt

broulik added a comment. I would like KAuth or Polkit to be fixed to properly report user canceling REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: broulik, mthw, plasma-devel, Orage,

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham added a comment. In D29333#661119 , @mthw wrote: > Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 7:18 AM Ben Cooksley wrote: > > On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: > > > > > > > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > > >> Am I the only person that just has all the repos on the same

D29333: Don't show an empty error dialog when canceling the sync password prompt

mthw added a comment. Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to

D29150: Address Connections syntax warnings on the systray plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c767ab70005: Address Connections syntax warnings on the systray plasmoid (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kwayland-server » stable-kf5-qt5 FreeBSDQt5.14 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-server/job/stable-kf5-qt5%20FreeBSDQt5.14/1/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 01 May 2020 14:22:54 + Build duration: 3.7 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kwayland-server » stable-kf5-qt5 SUSEQt5.14 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-server/job/stable-kf5-qt5%20SUSEQt5.14/1/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Fri, 01 May 2020 14:22:52 + Build duration: 26 sec and counting CONSOLE OUTPUT

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham updated this revision to Diff 81674. ngraham added a comment. Fix comment (it's always something...) REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29333?vs=81673=81674 BRANCH dont-badget-user-with-empty-error-dialog

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham created this revision. ngraham added reviewers: filipf, davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 420855 FIXED-IN: 5.18.5 TEST PLAN Click on the Sync button in

Re: Information regarding upcoming Gitlab Migration: clarifications

On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different projects > > > > that

D29296: [KCMs/Notifications] Port placeholder message to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35ed83a0a02d: [KCMs/Notifications] Port placeholder message to Kirigami.PlaceholderMessage (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Information regarding upcoming Gitlab Migration: clarifications

On 4/30/20 11:17 PM, Ben Cooksley wrote: Not necessarily. Git allows you to override the name that the local folder is called when cloning, so there is no reason why we can't specify something in the metadata to override the local name that the folder gets called in your local checkout

Re: Information regarding upcoming Gitlab Migration

Thanks for the clarifications, Ben. Then I think the original proposal is perfectly reasonable and I fully support it. Nate

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

alex abandoned this revision. alex added a comment. Is handled in separate patches. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28196 To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex created this revision. alex added reviewers: Plasma, ngraham, bruns, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY BUG 418526 The profile group with the value `Default=1` is not always the

D28627: Adaptive panel opacity

cblack added a comment. @davidedmundson can you take another look at the general direction of the code here? I'd like to know your thoughts on the direction this code is using before I start spending time sanding off the rough parts REPOSITORY R119 Plasma Desktop REVISION DETAIL

D29307: Implement smallFont in Kirigami plugin

cblack added a comment. In D29307#660851 , @filipf wrote: > How does this relate to D14562 1. This would have been a companion patch to it if the author didn't abandon it 2. But they did, so

D29301: [applets/mediacontroller] Elide text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0dcc58a10628: [applets/mediacontroller] Elide text (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29301?vs=81598=81661 REVISION

D29324: [Network Monitor] Show correct bitrate

ksmanis created this revision. ksmanis added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY Report the bitrate using SI prefixes, as is customary, instead of JEDEC prefixes. Furthermore,

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > ConfigAppearance.qml:90 > +} > +RowLayout { > +Kirigami.FormData.label: i18n("Presets:") It would probably be nice if we can make this a GridLayout with flow bound to the FormLayout's wide setting. Right now, if the layout

D28619: BookmarksRunner: Remove caching of profile database path

This revision was automatically updated to reflect the committed changes. Closed by commit R120:768e6a0a229d: BookmarksRunner: Remove caching of profile database path (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28473: BookmarksRunner: Early return and formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e518d45a4d61: BookmarksRunner: Early return and formatting (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79086=81648

D29307: Implement smallFont in Kirigami plugin

filipf added a comment. How does this relate to D14562 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D29307 To: cblack, #kirigami Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

alex created this revision. alex added reviewers: Plasma, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Because the actions are always the same the X-Plasma-Request-Actions-Once property can be set to

D29319: KCM Plasmasearch: Do not intialize runners in config module

alex created this revision. alex added reviewers: Plasma, davidedmundson, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The runners are loaded from the plugin info list