D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Noah Davis]

ndavis added a comment.


  In D29365#663395 , @ngraham wrote:
  
  > Of course the problem with a spinbox is that by displaying numbers, it 
demands some kind of legend or label. What does a value of 100 mean? Does a 
value of 0 make any sense? etc. The value displayed to the user must make some 
sense or explained with context. In this case, perhaps a percentage would work, 
with the default value being "100%", and the max and min values displaying 50% 
and 200%, or something, or whatever the scale actually is.
  
  
  Didn't we solve this already with Slider + Spinbox in the Display 
Configuration KCM?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis updated this revision to Diff 81966.
ndavis added a comment.


  Fix some colors

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29439?vs=81963&id=81966

BRANCH
  new-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29439

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeDark.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis updated this revision to Diff 81963.
ndavis added a comment.


  squash commits

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29439?vs=81962&id=81963

BRANCH
  new-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29439

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeDark.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  I also renamed Breeze to Breeze Light because it's very awkward to talk about 
the Breeze project when it's not clear whether or not you're talking about just 
the light version.

TEST PLAN
  TODO

REPOSITORY
  R31 Breeze

BRANCH
  new-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29439

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeDark.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Nathaniel Graham]

ngraham added a comment.


  Wait for @mart, but landing on the stable branch seems safe. No need for a 
bug report if there isn't already one open.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29351

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29438: Use font: instead of font.pointSize: where possible

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: cblack, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Otherwise we're discarding style information possibly set in
  the user's small font choices when we want to set a smaller
  font.

TEST PLAN
  Stuff that's suposta look small still looks small

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-the-whole-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29438

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffButton.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
  applets/kickoff/package/contents/ui/KickoffItem.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  desktoppackage/contents/explorer/AppletAlternatives.qml
  desktoppackage/contents/explorer/AppletDelegate.qml
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ngraham, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29437: Use font: instead of font.pointSize: where possible

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: cblack, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Otherwise we're discarding style information possibly set in
  the user's small font choices when we want to set a smaller
  font.

TEST PLAN
  Stuff that's suposta look small still looks small

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-the-whole-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29437

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/clipboard/contents/ui/UrlItemDelegate.qml

To: ngraham, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Reword inline message concerning widget locking

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:52d3389f7495: [Wallpaper Configuration] Reword inline 
message concerning widget locking (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29366?vs=81911&id=81958

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma, ngraham
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf added a comment.


  Should I also land this for 5.18 (do I have to create a bug report first)?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29351

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Giusy Margarita]

kurmikon added a comment.


  In D29365#663597 , @ngraham wrote:
  
  > Hmm, 0% as a lower value would imply no movement speed, which is obviously 
not possible here.
  
  
  As far as I know, libinput manages acceleration rather speed. Let's change 
the label to **Pointer acceleration**.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Nathaniel Graham]

ngraham added a comment.


  Hmm, 0% as a lower value would imply no movement speed, which is obviously 
not possible here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Everything looks great to me!
  
  Now go ask for re-licensing, I suppose.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Giusy Margarita]

kurmikon added a comment.


  Another solution. Spinbox 0% to 100%. -1 is 0% and 1 is 100%. Libinput 
default 0 will set 50%.
  
// Acceleration
RowLayout {
Controls.SpinBox {
Kirigami.FormData.label: i18nd("kcm_touchpad", "Pointer speed:")
id: accelSpeed

from: 0
to: 100
stepSize: 1

function load() {
enabled = touchpad.supportsPointerAcceleration
if (!enabled) {
value = 50
return
}
// transform libinput's pointer acceleration range [-1, 1] to 
spinbox range [0, 100] %
value = 50 + touchpad.pointerAcceleration / 0.02
}

onValueChanged: {
if (touchpad != undefined && enabled && !root.loading) {
// transform spinbox range [0, 100] to libinput's pointer 
acceleration range [-1, 1]
touchpad.pointerAcceleration = Math.round(((value-50) * 
0.02) * 100) / 100
root.changeSignal()
}
}
}

QtControls.Label {
text: i18n("%")
}
}

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf updated this revision to Diff 81955.
filipf added a comment.


  Drop:
  
  - Air Balloon
  - Gamepad
  
  Add:
  
  - Architecture
  - Food
  - Chalk
  
  Change:
  
  - Embiggen the leopard

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29394?vs=81839&id=81955

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Architecture.png
  src/pics/photos/Basketball.png
  src/pics/photos/Brushes.png
  src/pics/photos/Car.png
  src/pics/photos/Chalk.png
  src/pics/photos/Cocktail.png
  src/pics/photos/Food.png
  src/pics/photos/Keyboard.png
  src/pics/photos/Leopard.png
  src/pics/photos/Parrot.png
  src/pics/photos/Rubik's Cube.png
  src/pics/photos/Snail.png
  src/pics/photos/Space Shuttle.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

[Nathaniel Graham]

ngraham added reviewers: Plasma, VDG.
ngraham added a comment.


  IIRC the idea was that people who have specific DPI in mind would type it in, 
and clicking on the arrows to navigate one at a time would be 
frustrating--hence the large step size. Maybe we went too far in the direction 
of efficiency at the expense of familiarity, because the 24px step size 
suggests inaccurately that intermediate values can't be entered?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29431

To: kurmikon, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29435: Fix typo in examples

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Kirigami, cblack.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  typo

REVISION DETAIL
  https://phabricator.kde.org/D29435

AFFECTED FILES
  examples/PageRouter.qml
  examples/PageRouterCachePagesDo.qml
  examples/PageRouterCachePagesDont.qml
  examples/PageRouterColumnView.qml
  examples/PageRouterInitialRoute.qml
  examples/PageRouterRoutes.qml

To: nicolasfella, #kirigami, cblack
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29432: Use small font for BasicListItem subtitle

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:349b80d63429: Use small font for BasicListItem subtitle 
(authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29432?vs=81948&id=81952

REVISION DETAIL
  https://phabricator.kde.org/D29432

AFFECTED FILES
  src/controls/BasicListItem.qml

To: ngraham, #kirigami, cblack, #vdg
Cc: plasma-devel, cblack, broulik, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

[Giusy Margarita]

kurmikon added a comment.


  In D29431#663558 , @davidedmundson 
wrote:
  
  > That doesn't explain why we're changing the step size.
  >
  > No-one wants to click the up arrow 100 times.
  
  
  I have to set 101 and the default is 96. The arrow are there but I can't set 
101 because of the stesize. Tell me if this is sane. The majority of monitors 
have DPI around 96. Obviously, if you want an higher value, you can set it 
manually.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29431

To: kurmikon
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

[David Edmundson]

davidedmundson added a comment.


  That doesn't explain why we're changing the step size.
  
  No-one wants to click the up arrow 100 times.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29431

To: kurmikon
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29432: Use small font for BasicListItem subtitle

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Kirigami, cblack.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Should make @broulik happy. :)

TEST PLAN
  Doesn't actually seem to work with the wallpaper folder delegates, not sure 
why? @cblack?

REPOSITORY
  R169 Kirigami

BRANCH
  smallfont-subtitle-in-BasicListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29432

AFFECTED FILES
  src/controls/BasicListItem.qml

To: ngraham, #kirigami, cblack
Cc: plasma-devel, cblack, broulik, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

[Giusy Margarita]

kurmikon created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kurmikon requested review of this revision.

REVISION SUMMARY
  Since the spinbox read and write the DPI value "as is", without performing 
any format change, there's no need to set a stepsize of 24.
  
  As reported here 
, 
xdpyinfo, xrdb and fontconfig does not expect values multiple of 24 and 
sometimes the proper DPI value is an unsigned integer different than the 
default 96, to be manually calculated because xorg can't auto determine it 
correctly (see here 
).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29431

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: kurmikon
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29264: New tabs for Breeze

[Nathaniel Graham]

ngraham added a comment.


  In general I think this is a good direction to move in. However I don't think 
it's quite ready yet.
  
  Small nitpick: this will result in framed tab views having rounded bottom 
corners, but at least one pointy top corner: F8284555: 
Screenshot_20200504_140532.png 
  
  That should be easily fixable though.
  
  I think the blue line on top is an improvement and brings the tabs closer to 
the Plasma appearance, which is desirable from a #consistency 
 point of view. However I'm 
finding that the current tab just doesn't look distinct enough from un-focused 
tabs anymore. I would suggest to re-add the darkened background for inactive 
tabs, but then we run into T13054: Unify how Breeze communicates 
checked/current/selected states . Using 
only color to communicate the "current tab" state would jive with that, but 
then I start to think that we don't have //enough// color here and that it 
should look more like a Plasma tab, with a thicker highlight bar and the whole 
background colored. But then if we do that, we're fully abandoning @cblack's 
idea to make tab appearance dependent on the type of view (editable/document vs 
non-editable/tool view).
  
  Bottom line, I think we need to discuss what we really want here before we 
move forward with implementation anymore, to avoid wasting your time!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

[Giusy Margarita]

kurmikon abandoned this revision.
kurmikon added a comment.


  No changes needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29422

To: kurmikon, bport, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

[Nathaniel Graham]

ngraham added a comment.


  No worries!
  
  You have to abandon it: Add Action... > Abandon Revision

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29422

To: kurmikon, bport, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

[Giusy Margarita]

kurmikon added a comment.


  In D29422#663389 , @ngraham wrote:
  
  > How does subpixel hinting work without anti-aliasing?
  
  
  Good question. I thought they were independent because fontconfig has an 
hinting option that can be set true or false in addition to hintstyle. But I'm 
doing some tests now and they are related. So, hinting does not work with 
antialiasing off, then I worder what's the meaning of hinting, since I noticed 
that enabling or disabling it with antialiasing on is identical. But that's a 
matter of fontconfig.
  
  In D29422#663389 , @ngraham wrote:
  
  > I don't know the reason behind limiting the font DPI spinbox to multiples 
of 24, but that question should be asked elsewhere, not in the description 
section of a patch, which will become a commit message if this patch lands.
  
  
  You're right, I'm sorry. Please, close this revision and I will make a new 
one to modify stepsize to 1.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29422

To: kurmikon, bport, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Nathaniel Graham]

ngraham added a comment.


  In D29394#663180 , @filipf wrote:
  
  > In D29394#663012 , @ngraham 
wrote:
  >
  > > This is an improvement, for sure. But what happened to the noodle bowl? I 
loved that one!
  >
  >
  > Which one in T9910 ? We can still add 
some more avatars IMO.
  
  
  `Pho 2`
  
  I also liked `Greek Architecture` and `Colorful Chalk`. Including those would 
increase the overall colorfulness and saturation of the new images. I also 
really like `Snail` both because I think it's adorable, and also because I 
think it would be really ballsy to include. :)
  
  ...Or maybe I'm just a weirdo who likes snails a lot.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Mason McParlane]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9c3c2d1a2379: Add support for layers to PagePoolAction. 
(authored by masonm).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29294?vs=81640&id=81935#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29294?vs=81640&id=81935

REVISION DETAIL
  https://phabricator.kde.org/D29294

AFFECTED FILES
  .gitignore
  autotests/CMakeLists.txt
  autotests/pagepool/tst_layers.qml
  src/controls/PagePoolAction.qml
  src/controls/PageRow.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

[Nathaniel Graham]

ngraham marked 4 inline comments as done.
ngraham added a comment.


  Thanks, improved in 4517ef502169ebd104627a8463543880b3b7f7d.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29080

To: ngraham, #vdg, #plasma, cblack, bport
Cc: broulik, romangg, ahmadsamir, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Giusy Margarita]

kurmikon added a comment.


  In D29365#663395 , @ngraham wrote:
  
  > Of course the problem with a spinbox is that by displaying numbers, it 
demands some kind of legend or label. What does a value of 100 mean? Does a 
value of 0 make any sense? etc. The value displayed to the user must make some 
sense or explained with context.
  
  
  Well, I posted the slider with more ticks, you said it wasn't good. Maybe is 
it better to increase the width? I will check it out to get a wider size.
  
  In D29365#663395 , @ngraham wrote:
  
  > In this case, perhaps a percentage would work, with the default value being 
"100%", and the max and min values displaying 50% and 200%, or something, or 
whatever the scale actually is.
  
  
  -100 the slowest acceleration and 100 the fastest. Maybe a legend would be 
good. I don't think libinput has a specific scale. From -100% to 100% with 0% 
default would be good also?
  
  I think both solutions are better then the actual one since is more accurate.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: kwallet-pam >= 5.18.4 and ecryptfs homes

[Nate Graham]

On 5/3/20 4:02 PM, Albert Astals Cid wrote:> Problem with SOLUTION 1 is 
that it adds lots of code in a relative "sensitive" piece of code like a 
pam module for for what it is a one time thing.

Problem with SOLUTION 2 is that it's not a solution :D


Opinions?


I feel pretty confident in your skills at implementing option 1 safely. 
:) Once the code is pushed out to users in 5.18.5, could we remove it in 
master to avoid an ongoing maintenance and security issues?


In any event, it seems like we don't really have much of a choice since 
as you mention, option 2 doesn't actually solve the problem for the 
typical user.


Nate

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Nathaniel Graham]

ngraham added a comment.


  Of course the problem with a spinbox is that by displaying numbers, it 
demands some kind of legend or label. What does a value of 100 mean? Does a 
value of 0 make any sense? etc. The value displayed to the user must make some 
sense or explained with context. In this case, perhaps a percentage would work, 
with the default value being "100%", and the max and min values displaying 50% 
and 200%, or something, or whatever the scale actually is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

[Nathaniel Graham]

ngraham added reviewers: bport, Plasma.
ngraham added a comment.


  How does subpixel hinting work without anti-aliasing?
  
  I don't know the reason behind limiting the font DPI spinbox to multiples of 
24, but that question should be asked elsewhere, not in the description section 
of a patch, which will become a commit message if this patch lands.

INLINE COMMENTS

> main.qml:219
>  textRole: "display"
> -enabled: antiAliasingCheckBox.checked
> +enabled: true
>  popup.height: popup.implicitHeight

`true` is the default value; no need to set this at all then

> main.qml:256
>  textRole: "display"
> -enabled: antiAliasingCheckBox.checked
> +enabled: true
>  popup.height: popup.implicitHeight

ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29422

To: kurmikon, bport, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Konrad Materka]

kmaterka added a comment.


  In D29386#663325 , @ngraham wrote:
  
  > Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the 
merge conflicts.
  
  
  Merged.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29386

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Nathaniel Graham]

ngraham added a comment.


  Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the 
merge conflicts.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29386

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 81926.
apol added a comment.


  Rebase on top of kwayland-server changes

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81343&id=81926

BRANCH
  arcpatch-D28884

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:77975468dc10: [systemtray] Fix SNI icon not rendering 
(authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29386?vs=81903&id=81925

REVISION DETAIL
  https://phabricator.kde.org/D29386

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

[Giusy Margarita]

kurmikon created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kurmikon requested review of this revision.

REVISION SUMMARY
  Now kcm fontconfig has **subpixel rendering** and **hintstyle** options 
depending on **antialiasing**. This means if I disable antialiasing, I can't 
set the other two options.
  
  As far as I know, subpixel rendering and hintstyle don't depend on 
antialiasing and fontconfig does not prevent to set them when antialiasing is 
off. Indeed the previous version of kcm fontconfig had a different behavior, 
letting the user chose their values whether antialiasing was enabled or not. So 
I suggest to always enable them.
  
  Then I'd like to get a clarification on DPI value. Reading the code I see 
that the spinbox accepts values from 24 with stepsize of 24.
  
QtControls.SpinBox {
id: dpiSpinBox
stepSize: 24
editable: true
enabled: dpiCheckBox.checked
value: kcm.fontsAASettings.dpi !== 0 ? 
kcm.fontsAASettings.dpi : 96
onValueModified: kcm.fontsAASettings.dpi = value
// to: need to divide to stepSize
to: 1008
// lowest vaue here can be == stepSize, that is because 
0 means off
from: 24
}
  
  That seems weird to me. First of all, the user don't even know the spinbox 
accept only values multiple of 24. If it were this way, there should be a 
message to inform the user. But basing on information reported here 
, 
neither xdpyinfo, xrdb and fontconfig report values multiple of 24.
  
  In example, xorg wrongly assumed that my monitor had 96 as DPI value, but I 
calculated it properly and the real value is 101 (see here 
 how to do it). 
So I expect system settings to accept 101, but since stepsize is 24, it seems I 
can't set it. The comment in the section of code posted above says to divide by 
24, but I can't understand why.
  
  Maybe was this made to format the value before it is passed to the system 
functions? But this should be done after the user wrote the value.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29422

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: kurmikon
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

> ConfigSensors.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +import QtQml.Models 2.12

`as QQC2`

> FaceDetails.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: alexde, ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D28922: Port Sensor Face loading from plasmoid

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

> ConfigAppearance.qml:69
> +delegate: Kirigami.SwipeListItem {
> +contentItem: Controls.Label {
> +Layout.fillWidth: true

swipeListItem has its own label property; can we use that instead of overriding 
the contentItem?

> ConfigSensors.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +import QtQml.Models 2.12

`as QQC2`

> FaceDetailsConfig.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

> FaceDetailsConfig.qml:45
> +if (item.hasOwnProperty("cfg_" + key)) {
> +root.controller.faceConfiguration[key] = item["cfg_"+key]
> +}

`"cfg_" + key`

> UsedSensorsView.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +import QtQml.Models 2.12

`as QQC2`

> CompactRepresentation.qml:24
>  import QtQuick 2.9
> +import QtQuick.Controls 2.2 as Controls
>  import QtQuick.Layouts 1.1

`as QQC2`

> Config.qml:23
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

> CompactRepresentation.qml:24
>  import QtQuick 2.9
> +import QtQuick.Controls 2.2 as Controls
>  import QtQuick.Layouts 1.1

`as QQC2`

> Config.qml:22
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

> LineChart.qml:47
> +//TODO: Have a central heading here too?
> +//TODO: Have a plasmoid config value for line thickness?
> +

Well, should we? :)

> CompactRepresentation.qml:24
>  import QtQuick 2.9
> +import QtQuick.Controls 2.2 as Controls
>  import QtQuick.Layouts 1.1

`as QQC2`

> Config.qml:22
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +

`as QQC2`

> Config.qml:22
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.2 as Controls
> +import org.kde.ksysguard.faces 1.0 as Faces

`as QQC2`

> Config.qml:45
> +sourceModel: Sensors.SensorDataModel {
> +// FIXME: unqualified property
> +sensors: controller.sensorIds

fixit :)

> Config.qml:53
> +id: sortDescendingCheckBox
> +// or do a ComboBox like in Dolphin with pretty names "highest 
> first"<->"lowest first"?
> +text: i18nc("Sort descending", "Descending")

That would be nice, yes. :) Nobody can ever figure out what "ascending" and 
"descending" means in the context of sort ordering.

> FullRepresentation.qml:24
> +import QtQuick 2.12
> +import QtQuick.Controls 2.2
> +import QtQuick.Layouts 1.2

`import QtQuick.Controls 2.2 as QQC2`

> FullRepresentation.qml:102
> +//FIXME: why +2 is necessary?
> +Layout.preferredWidth: metrics.width+2
> +Layout.maximumWidth: x > 0 ? metrics.width+2 : -1

Ugh, I don't like any of this :(

> FullRepresentation.qml:141
> +
> +//See 
> https://codereview.qt-project.org/c/qt/qtdeclarative/+/262876
> +onWidthChanged: Qt.callLater(function() {if (tableView.columns > 
> 0) {

this was merged almost a year ago; probably not needed anymore

> FullRepresentation.qml:159
> +onSensorsChanged: {
> +//note: this re sets the models in order to make the 
> table work with any new role
> +tableView.model = null;

`resets the models`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ahiemstra wrote in SensorFaceController.h:47
> I think it would be a good idea to make this a list of ids as well. My 
> current use case would be the "used/total" version of the pie chart that is 
> used in KSysGuardQML, which would need two "total" sensors.

how would that work in current faces that have this binded to that single big 
number inside graphs?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Various bugs I've complained about are still not fixed.
  
  1. The KCM does not display the two-column view when opened in System 
Settings' default window size until you resize the window a bit: F8284091: 
vokoscreenNG-2020-05-04_09-52-36.webm 
  
  2. The KCM is in a dirty state without you having changed anything: F8284093: 
vokoscreenNG-2020-05-04_09-54-54.webm 
  
  3. You can still try to delete your own user: F8284095: 
Screenshot_20200504_095557.png 
  
  4. The avatar chooser sheet is super duper space inefficient: F8284104: 
vokoscreenNG-2020-05-04_09-59-37.webm  
Could its visual parent be  the whole KCM, rather than just one page of it?
  
  5. The auto-generated avatar style with the user's initials and a colored 
background does not apply: F8284120: vokoscreenNG-2020-05-04_10-01-44.webm 
 If this feature is blocked by a bug, 
then it should be disabled until it works.
  
  And one new one: When you create a new user, the first text field should be 
focused automatically so you can start typing immediately. The new user UI 
could even be in a sheet, maybe (as long as its visual parent is the whole KCM 
and not one of the columns in a multi-column/multi-page layout)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  In D29394#663012 , @ngraham wrote:
  
  > Great, that works. I suppose there's no point in fixing that bug since this 
KCM is being re-done anyway in D28154 . 
Once this lands, @cblack can grab these and add them to that patch.
  
  
  Yeah I would agree. The user gallery in the current KCM is also something 
that should be improved (bigger previews, two lines of text) but no point in 
fiddling with it.
  
  > However I see duplicates for the space shuttle, hot air balloon, and 
Rubik's cube.
  
  Yeah I renamed those after the first revision so they're leftovers.
  
  > This is an improvement, for sure. But what happened to the noodle bowl? I 
loved that one!
  
  Which one in T9910 ? We can still add some 
more avatars IMO.
  
  > I can't help but notice that a lot of these images are sort of de-saturated 
or sepia-toned. I feel like a bit more saturation would make them pop better.
  
  I definitely have to replace the air baloon pic, it's the worst one 
saturation-wise.
  
  > The gamepad image is quite dark and low contrast. It's kind of hard to see 
the gamepad itself: F8283812: Screenshot_20200504_081738.png 

  
  Indeed, the problem with gamepads was finding a pic that doesn't have a logo. 
It's possible the Rubik's cube and the keyboard suffice for nerds, but I'll try 
to find something else related to gaming.
  
  > The Leopard image is great, but maybe it could be zoomed in a bit so the 
leopard takes up more of the frame? It's kinda tiny: F8283809: 
Screenshot_20200504_081717.png 
  
  Will do in the next revision.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

[Benjamin Port]

bport added a comment.


  I don't think we will have same behavior, we don't only check name but also 
size, type...
  If we are ok to fallback in all case to the same font that can work.
  
  From your test plan, something look strange you don't end with a monospaced 
font for fixed font as fallback ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-setnearest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29155

To: ahmadsamir, #plasma, bport, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf updated this revision to Diff 81911.
filipf added a comment.


  restore the inline message but change its text to note that layout changes 
have been restricted by the sysadmin

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29366?vs=81756&id=81911

BRANCH
  remove-obsolete-inline-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29366

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: filipf, #plasma
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Filip Fila]

filipf updated this revision to Diff 81910.
filipf marked an inline comment as done.
filipf added a comment.


  Replace PropertyAnimation with NumberAnimation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29351?vs=81709&id=81910

BRANCH
  no-logo-leak (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29351

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29395: Refactor MediaController

[Kai Uwe Broulik]

broulik added a comment.


  Generally +1
  Nice idea with this `Media` singleton

INLINE COMMENTS

> ExpandedRepresentation.qml:65
> +}
> +Media.lockPositionUpdate= false
> +}

Coding style, space

> ExpandedRepresentation.qml:99
>  seekSlider.value = Math.max(0, seekSlider.value - 500) 
> // microseconds
> -seekSlider.moved();
> +seekSlider.moved()
>  } else if (event.key === Qt.Key_Right || event.key === Qt.Key_L) 
> {

Unrelated cleanup

> Media.qml:6
> +
> +Item {
> +id: media

Make this a `QtObject`

> Media.qml:87
> +
> +readonly property int play: 0
> +readonly property int pause: 1

Just pass the action string through, since all we do below is map the number 
back to a string

> Media.qml:141
> +sources.filter(source => source !== mpris2Source.multiplexSource)
> +   .forEach(source => {
> +   model.push({

or `map()` and then `unshift` the multiplexer :p

> Media.qml:187
> +function togglePlaying() {
> +print(Media.state)
> +if (Media.state === "playing" && Media.canPause) {

Remove debug prints

> Media.qml:197
> +
> +states: [
> +State {

Turn this into a property with an `if` when this is no longer an `Item`

> main.qml:155
>  name: "playing"
> -when: !root.noPlayer && mpris2Source.currentData.PlaybackStatus 
> === "Playing"
> +when: Media.state == "playing"
>  

You can just set `state: Media.state` rather than `when` on every state

> main.qml:159
>  target: plasmoid
> -icon: albumArt ? albumArt : "media-playback-playing"
> -toolTipMainText: track
> -toolTipSubText: artist ? i18nc("by Artist (player name)", 
> "by %1 (%2)", artist, identity) : identity
> +icon: Media.albumArt ? Media.albumArt : 
> "media-playback-playing"
> +toolTipMainText: Media.currentTrack

We don't set album art on the icon anymore, cf D28917 


> main.qml:243
> -
> -function action_open() {
> -serviceOp(mpris2Source.current, "Raise");

You can't remove these, they are wired up to the `plasmoid.setAction` calls 
above. (Yes, I'd like to have an API to pass a JS callback :p but this is how 
it works right now)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Alex Debus]

alexde added a comment.


  Not sure, if this is part of the scope of this work, but do you also plan to 
add some meaningful labels and ticks to the axis?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: alexde, ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PowerManagementItem.qml:62
> +Layout.fillWidth: true
> +Layout.leftMargin: units.gridUnit + units.smallSpacing // width of 
> checkbox and spacer
>  spacing: units.smallSpacing

Try if this works with right-to-left layout, or should we ignore this and hope 
david's patch goes in?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29315

To: ngraham, #vdg, #plasma, broulik, manueljlin, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d62fd2dd58c8: [applets/batterymonitor] Port inhibition 
message to Layouts and match… (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29315?vs=81632&id=81907

REVISION DETAIL
  https://phabricator.kde.org/D29315

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

To: ngraham, #vdg, #plasma, broulik, manueljlin, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29075: [wallpapers/image] Port to BasicListItem+subtitle

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:71f1ff8e50b0: [wallpapers/image] Port to 
BasicListItem+subtitle (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29075?vs=80817&id=81906#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29075?vs=80817&id=81906

REVISION DETAIL
  https://phabricator.kde.org/D29075

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #plasma, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Konstantinos Smanis]

ksmanis closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Nathaniel Graham]

ngraham added a comment.


  +1, excellent work.

INLINE COMMENTS

> Sensor.cpp:2
> +/*
> +Copyright (C) 2019 Vlad Zagorodniy 
> +Copyright (C) 2020 Arjen Hiemstra 

Update name

> Sensor.cpp:219
> +
> +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") 
> != -1) {
> +connect(parent(), SIGNAL(enabledChanged()), this, 
> SIGNAL(enabledChanged()));

`if (`

> SensorInfo_p.h:36
> +SensorInfo() = default;
> +QString name; //translated?
> +QString shortName; // translated

Is it? :)

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28487: Redesign of system monitor plasmoids

[Nathaniel Graham]

ngraham added a comment.


  Looks fantastic!
  
  However I've applied the dependent patches, but this doesn't compile for me:
  
 In member function ‘virtual void SystemMonitor::init()’:

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:63:78:
 error: invalid use of incomplete type ‘class SensorFaceController’
   63 | m_sensorFaceController = new SensorFaceController(cg, 
qmlObject->engine());
  | 
 ^
In file included from 
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
 note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
  |   ^~~~

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:67:31:
 error: invalid use of incomplete type ‘class SensorFaceController’
   67 | m_sensorFaceController->loadPreset(m_pendingStartupPreset);
  |   ^~
In file included from 
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
 note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
  |   ^~~~

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:71:31:
 error: invalid use of incomplete type ‘class SensorFaceController’
   71 | m_sensorFaceController->loadPreset(preset);
  |   ^~
In file included from 
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
 note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
  |   ^~~~

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:
 In member function ‘virtual void SystemMonitor::configChanged()’:

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:83:31:
 error: invalid use of incomplete type ‘class SensorFaceController’
   83 | m_sensorFaceController->reloadConfig();
  |   ^~
In file included from 
/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:20:

/home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.h:33:7:
 note: forward declaration of ‘class SensorFaceController’
   33 | class SensorFaceController;
  |   ^~~~
  
  Also the test plan screenshot shows a string overlap issue: F8283936: 
Screenshot_20200504_085406.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29411: [KRunner] Watch config with KConfigWatcher

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6db69ae09524: [KRunner] Watch config with KConfigWatcher 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29411?vs=81896&id=81904#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29411?vs=81896&id=81904

REVISION DETAIL
  https://phabricator.kde.org/D29411

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h

To: broulik, #plasma, ngraham, ksmanis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Konrad Materka]

kmaterka updated this revision to Diff 81903.
kmaterka added a comment.


  Additional check for real JavaScript null - to avoid conversion errors in 
native method.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29386?vs=81803&id=81903

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29386

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29410: [Runners KCM] Notify history deletion

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8fe03502660c: [Runners KCM] Notify history deletion 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29410?vs=81895&id=81901

REVISION DETAIL
  https://phabricator.kde.org/D29410

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29411: [KRunner] Watch config with KConfigWatcher

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, much nicer! Thanks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29411

To: broulik, #plasma, ngraham, ksmanis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29379: Unassign activity from vault on activity deletion

[Ivan Čukić]

ivan closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D29379

To: ivan, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Konrad Materka]

kmaterka added a comment.


  In D29386#662960 , @ngraham wrote:
  
  > Great catch. The logic seems sane to me. Note that if you plan to land this 
on the stable branch, there will be merge conflicts that you'll need to resolve 
carefully, since it looks like this code has changed a bit between 5.18 and 
5.19.
  
  
  I know, because I changed it :) In 5.19 entire data model was rewritten, so 
that this change might not be need or better approach can be used. I will check 
it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29386

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29411: [KRunner] Watch config with KConfigWatcher

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham, ksmanis.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Rather than using a `KDirWatch` that points to the wrong place.

TEST PLAN
  5.18 please
  
  - Cleared history in KCM with D29410 , 
confi was reloaded and history gone right away

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29411

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h

To: broulik, #plasma, ngraham, ksmanis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29410: [Runners KCM] Notify history deletion

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  So KRunner can catch that in a `KConfigWatcher`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29410

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Nathaniel Graham]

ngraham added a subscriber: cblack.
ngraham added a comment.


  Great, that works. I suppose there's no point in fixing that bug since this 
KCM is being re-done anyway in D28154 . 
Once this lands, @cblack can grab these and add them to that patch.
  
  However I see duplicates for the space shuttle, hot air balloon, and Rubik's 
cube.
  
  ---
  
  In terms of the actual images themselves:
  
  This is an improvement, for sure. But what happened to the noodle bowl? I 
loved that one!
  
  I can't help but notice that a lot of these images are sort of de-saturated 
or sepia-toned. I feel like a bit more saturation would make them pop better.
  
  The gamepad image is quite dark and low contrast. It's kind of hard to see 
the gamepad itself: F8283812: Screenshot_20200504_081738.png 

  
  The Leopard image is great, but maybe it could be zoomed in a bit so the 
leopard takes up more of the frame? It's kinda tiny: F8283809: 
Screenshot_20200504_081717.png 

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: cblack, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Nathaniel Graham]

ngraham added a comment.


  Maybe we can do that on master and land this on the stable branch?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner-fix-watched-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Kai Uwe Broulik]

broulik added a comment.


  Ideally, we'd change the KCM to write the key with `KConfig::Notify` and then 
use `KConfigWatcher` here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner-fix-watched-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Good catch! Seems worthy of landing on the stable branch? What do you think, 
@broulik?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner-fix-watched-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in SensorFaceController.cpp:247
> perhaps line chart?

I was more thinking something along the lines of a new face that's either 
completely empty or displays a "not configured" message.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28888: Fix navigation regressions

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:f98e5d33f46b: Fix navigation regressions (authored by 
cblack).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2?vs=81713&id=81889

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: cblack, #vdg, #kirigami, ndavis, mart
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D29106: Introduce RouterWindow control

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d2060bf4a12a: Introduce RouterWindow control (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29106?vs=80922&id=81888

REVISION DETAIL
  https://phabricator.kde.org/D29106

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_routerwindow.qml
  src/controls/RouterWindow.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right let's do that on the stable branch to fix the bug and then change 
the string in master to be consistent.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma, ngraham
Cc: ngraham, bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Great catch. The logic seems sane to me. Note that if you plan to land this 
on the stable branch, there will be merge conflicts that you'll need to resolve 
carefully, since it looks like this code has changed a bit between 5.18 and 
5.19.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29386

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:5b8868783c01: Implement smallFont in Kirigami plugin 
(authored by cblack).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29307?vs=81642&id=81884

REVISION DETAIL
  https://phabricator.kde.org/D29307

AFFECTED FILES
  CMakeLists.txt
  kirigami-plasmadesktop-integration/CMakeLists.txt
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h

To: cblack, #kirigami, mart
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ahiemstra wrote in SensorFaceController.cpp:77
> Similar to above, does it still make sense to use "Plasma/Applet" here?

it kinda has to, as the original idea is to be able to use any preset as it was 
a standalone applet, so creating a preset means you can find it directly in the 
widget explorer. If presets are moved somewhere else, it needs somthing that 
synchronizes them for the extra plasmoids to still work, which it addsa new 
brittle level of complexity.

it is a bit annoying that is depending indirectly from libplasma for the 
package plugin, perhaps it could have an internal, non-plugin replacement for 
this package structure to have it working also when plasma is not installed

> ahiemstra wrote in SensorFaceController.cpp:182
> This seems to be unused?

it's used in the component->beginCreate(context); next line

> ahiemstra wrote in SensorFaceController.cpp:247
> I think we should have a "default face" for when no specfic face has been set 
> yet, that isn't a pie chart. At least for ksysguard the default pie chart 
> feels weird.

perhaps line chart?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 81882.
mart marked 7 inline comments as done.
mart added a comment.


  - start to port other faces
  - port faces to new api
  - add missing file
  - adapt to api changes
  - adress a part of comments

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=81078&id=81882

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/table/contents/config/main.xml
  faces/facepackages/table/contents/ui/CompactRepresentation.qml
  faces/facepackages/table/contents/ui/Config.qml
  faces/facepackages/table/contents/ui/FullRepresentation.qml
  faces/facepackages/table/metadata.desktop
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  In D29394#662776 , @ognarb wrote:
  
  > Photo using the Unsplash license can't be included in our repositories. The 
license is not considered open-source :( We should contact the artists if they 
are willing to license their photographies under a creative commons license 
(not the noncommercial and the no edit one)
  
  
  T9910#229073 

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28333: Add a new daemon for stats monitoring

[David Edmundson]

davidedmundson updated this revision to Diff 81871.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  Clear up plugin loading

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28333?vs=81087&id=81871

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28333

AFFECTED FILES
  CMakeLists.txt
  kstats/CMakeLists.txt
  kstats/autotests/CMakeLists.txt
  kstats/autotests/main.cpp
  kstats/client.cpp
  kstats/client.h
  kstats/ksysguard_iface.xml
  kstats/ksysguarddaemon.cpp
  kstats/ksysguarddaemon.h
  kstats/main.cpp
  kstats/test/CMakeLists.txt
  kstats/test/README.txt
  kstats/test/main.cpp
  libkstats/AggregateSensor.cpp
  libkstats/AggregateSensor.h
  libkstats/CMakeLists.txt
  libkstats/SensorContainer.cpp
  libkstats/SensorContainer.h
  libkstats/SensorObject.cpp
  libkstats/SensorObject.h
  libkstats/SensorPlugin.cpp
  libkstats/SensorPlugin.h
  libkstats/SensorProperty.cpp
  libkstats/SensorProperty.h
  libkstats/types.h
  plugins/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/ksgrd/ksgrdiface.h
  plugins/global/nvidia/CMakeLists.txt
  plugins/global/nvidia/nvidia.cpp
  plugins/global/nvidia/nvidia.h

To: davidedmundson, #plasma
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D29312: Change microphoneindicator for reporting audio monitors

[Giusy Margarita]

kurmikon added a comment.


  Pulseaudio is an abstraction layer over alsa.
  
  You, as a developer, can record sources in many ways, but since it's an 
abstraction layer, you can't be really sure whether the source is a microphone 
or not. There's a discussion on github where a user was asking on differences 
between speakers attached to the system and network output: PulseEffects funder 
said there's no difference, since Pulseaudio exposes them the same way.
  
  Maybe there should be something to discover it in some complicated ways, but 
that's also too difficult to implement in a simple desktop environment applet. 
No offense, but who designed this indicator had in mind one only use case. 
Unfortunately there are also other cases and Plasma gives a wrong information 
in those events.
  
  Besides, it's also not coherent. I have two laptops. On one I don't have the 
microphone and no message is shown.
  On the other the microphone is integrated, always connected, and the message 
is shown: "PulseEffects is using the microphone". That's not true, I'm using 
PulseEffects to apply volume normalization on output sources.
  
  What can we do? Maybe we can exclude PulseEffects with a string comparison or 
a reg exp from the app list? Nope, because it can record from the mic in other 
use case, so that would be in conflict with the applet primary purpose.
  
  So, please, don't mock the users and let's show the truth. If you don't like 
"monitoring", we can say "recording", "using", "handling". But not microphone. 
An audio stream.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: mart, nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a6bf4a67f099: ColorUtils: Use const ref for 
QColor/QJSValue, fix code style (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29046?vs=80747&id=81870

REVISION DETAIL
  https://phabricator.kde.org/D29046

AFFECTED FILES
  src/colorutils.cpp
  src/colorutils.h

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

Monday meeting notes for 4/5/2020

[Marco Martin]

Nico:
Kirigami:
* Bundle some missing icons for Android https://phabricator.kde.org/D29276
Diff 29276 "Bundle icons for inline messages" [Closed]
https://phabricator.kde.org/D29276
* Fixed excessive padding in scrollable pages https://phabricator.kde.org/D29308
Diff 29308 "Fix excessive right padding in scrollable page"
[Closed] https://phabricator.kde.org/D29308
* Investigated what seemed a regression from it, but appears to be a
Qt bug. Still need to do some testing and make  a report
log for review https://phabricator.kde.org/D29268
* Diff 29268 "[WIP] Add Date/Time dialog" [Needs Review]
https://phabricator.kde.org/D29268
Plasma:
* Suppress volume change sound when max is reached, a bit
controversial. there seems to be a way forward, but it's going to be
trickier to implement https://phabricator.kde.org/D29279
Diff 29279 "Don't play volume feedback if max volume is reached"
[Accepted] https://phabricator.kde.org/D29279
* Respect fallbackSearchPath in KIconLoader https://phabricator.kde.org/D29390
Diff 29390 "Respect QIcon::fallbackSearchpaths()" [Needs Review]
https://phabricator.kde.org/D29390
* Notifications:
* Killed the godawful KPassivePopup fallback and a bunch of code with
it https://phabricator.kde.org/D29021
Diff 29021 "Remove checks for notification service and fallback to
KPassivePopup" [Closed] https://phabricator.kde.org/D29021
* Remove the word galago from the code https://phabricator.kde.org/D29336
Diff 29336 "Remove galago from method/variable naming" [Needs
Review] https://phabricator.kde.org/D29336
* Began work on replacing setWidget() with setWindow()
https://phabricator.kde.org/D29391
Diff 29391 "Introduce setWindow and CloseWhenWindowActivated"
[Needs Review] https://phabricator.kde.org/D29391
* noted down more thoughts https://phabricator.kde.org/T11875
Task 11875 "KNotification v2" [Open,Needs Triage] {KF6}
https://phabricator.kde.org/T11875
Other:
* Tested KTrip on Gnome
* Ubuntu doesn't ship a good QStyle/QPT by default :/
* Fedora does, so things are much better there by default
* Kirigami toolbar has issues with styles where actions have a
background, the background overflows the toolbar
* Some icons were missing, partially solved by switching to equivalent
icons with different names, but that doesn't scale :/
* e.g. Kirigami is missing the 'hamburger' icon
* We should consider shipping the subset of breeze icons Kirigami uses
as a fallback or else we will have broken apps
Should we install on the disk (where?) or bundle them in qrc like we
do on Android?

Kai Uwe:
Notifications:
* Fixed typo breaking notification grouping with different origin name
* Battery *low* notification is now also critical
* Ensures you acknowledge it as an advance warning of battery running out
* Previously you would only then see "critical" where you'd have 1
minute to find a charger :)
plasma-browser-integration:
* Now signals player gone in "pagehide" rather than "onbeforeunload"
* The latter isn't fired for iframes. This fixes e.g. Tweetdeck
not noticing a player is gone
plasma-firewall:
* Some firewalld-related code review and refactoring
Other:
* Fixed crash in Task Manager in `QStringBuilder`, thanks fvogt
waiting on features pending for Plasma 5.19: https://phabricator.kde.org/D28021

Leinir
* I've got two patches waiting for reviews, and since they failed to
reach merge by the weekend, ghns for Global Themes and updates for all
ghns content will continue to not work correctly for another month...
* https://phabricator.kde.org/D28701 and
https://phabricator.kde.org/D29222 for those who feel like we need to
rectify that situation
Diff 28701 "Add KPackage support to KNewStuffCore" [Needs Review]
https://phabricator.kde.org/D28701
Diff 29222 "Fix update auto selection" [Needs Review]
https://phabricator.kde.org/D29222
* I realise I can do things like "This is going in unless people
reject it in the next few days", but also that's not really how we're
supposed to work, so...

David E:
Firstly, an announcement
* The kwayland split has landed
* kwayland-server is now in plasma, kwin is all ported
* and so far nothing has broken \o/
* generally it's gone very smoothly (thanks to Aleix on that)
* There's a lot of fixes coming in rapidly on that
* As a reminder to all, this is our first release with a "feature freeze" again
which is on the 14th
* which will come round sooner than we expect!
* notmart> d_ed: so the big thing is trying to get the systemmonitor
stuff in before the 14th
* d_ed> yeah, I think that's important, it's sat on review. Lets go for it
* and using the new daemon + libs in just the applets is a good
transition for testing everything before touching the main app
* which we can do in 5.20
* and I hope to land my wayland clipboard changes for 5.19, though I
can maybe wait
* the kwin side is on review, I haven't updated klipper yet
* I'll delay the systemd stuff till at least after branching

Marco:
# Plasma
* continue with syste

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Konrad Materka]

kmaterka added a comment.


  Separate Bug 420993  created for 
Media Player icon not rendering correctly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, 
davidedmundson, mart
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Konstantinos Smanis]

ksmanis added a comment.


  Nope, different bugs, similar solutions. I can still reproduce the other bug 
(I never noticed it before btw). I am not sure if this patch fixes any other 
regressions other than the Clear History button in the KCM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29324: [Network Monitor] Show correct bitrate

[Konstantinos Smanis]

ksmanis added a comment.


  Yeah, unfortunately I took notice after submitting the revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29324

To: ksmanis, #plasma
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29401: [KRunner] Fix watched config file path

[Kai Uwe Broulik]

broulik added a comment.


  That's not the bug I tried to solve in D26444 
, was it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI

[Cyril Rossi]

crossi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29402

AFFECTED FILES
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h

To: crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Konstantinos Smanis]

ksmanis created this revision.
ksmanis added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ksmanis requested review of this revision.

REVISION SUMMARY
  The "Clear History" button in the KCM is currently broken, since we are
  not watching the actual config file, but a file called "General", i.e.,
  the name of the KConfigGroup. Therefore, the QML runner is never
  informed that the history was erased in the config file.

TEST PLAN
  Clear History now works as expected on master and v5.18.4.1.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner-fix-watched-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29401

AFFECTED FILES
  krunner/view.cpp

To: ksmanis, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Carl Schwan]

ognarb added a comment.


  Photo using the Unsplash licence can't be included in our repositories. The 
license is not consired open source :(

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: repo freeze tomorrow

[Aleix Pol]

Hi Jonathan,
Thank you, will do!

Aleix

On Fri, May 1, 2020 at 5:27 PM Jonathan Riddell  wrote:
>
> So modules to be released are same as last time plus kwayland-server.  The 
> cmake setup of the repo looks good to me.
>
> Let me know if you need any help releasing plasma-wayland-protocols
>
> Jonathan
>
>
> On Fri, 1 May 2020 at 02:13, Aleix Pol  wrote:
>>
>> On Thu, Apr 30, 2020 at 7:57 PM Rik Mills  wrote:
>> >
>> > On 30/04/2020 18:33, Aleix Pol wrote:
>> > > Yes, in practice.
>> >
>> > In practice? What other way is there? Now I check some more they seem
>> > very non-optional.
>>
>> I mean that plasma-wayland-protocols is supposed to be released
>> outside of Plasma (as it will be a kwayland dependency eventually).
>> Sorry, could have explained myself better.
>>
>> Aleix

D29312: Change microphoneindicator for reporting audio monitors

[Giusy Margarita]

kurmikon added a comment.


  In D29312#662773 , @mart wrote:
  
  > i think i would prefer a somewhat inaccurate message, rather than an 
obscuretecnicism which is technically accurate (
  
  
  I don't agree, but what do you suggest considering that now Plasma is showing 
a wrong message?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: mart, nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29312: Change microphoneindicator for reporting audio monitors

[Marco Martin]

mart added a comment.


  i think i would prefer a somewhat inaccurate message, rather than an 
obscuretecnicism which is technically accurate (

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29312

To: kurmikon, #vdg, #plasma, drosca, broulik
Cc: mart, nicolasfella, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29324: [Network Monitor] Show correct bitrate

[Marco Martin]

mart added a comment.


  note that there is a whole rewrite pending for all systemmonitor applets in 
D28487  (and several related diffs)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29324

To: ksmanis, #plasma
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:026a29174279: [applets/systemtray] Fix invisible plasmoid 
icons when Media Player is added (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29344?vs=81842&id=81858

REVISION DETAIL
  https://phabricator.kde.org/D29344

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/systemtraymodel.cpp

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, 
davidedmundson, mart
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  unfortunately yeah, i had to port away from opacityanimator several places 
for this reason :(

INLINE COMMENTS

> Main.qml:449
> +// OpacityAnimator when starting from 0 is buggy (it shows 
> one frame with opacity 1)"
> +PropertyAnimation {
>  duration: units.longDuration

please use NumberAnimation 
(it's the same as propertyaniation but goes trough a qvariant conversion less, 
so i preferrable for animate properties of type int or real)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29351

To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Marco Martin]

mart added a comment.


  In D29366#661956 , @filipf wrote:
  
  > Ok, so the message can indeed still be turned on.
  >
  > Setting:
  >  `~/.config/plasmarc [General] immutability=2 (or 4)`
  >
  > ... does not work, however the following does:
  >
  > `~/.config/kdeglobals [KDE Action Restrictions][$i] 
plasma/plasmashell/unlockedDesktop=false`
  >
  > Which means that if widget locking now only exists as a restriction... 
perhaps it would make more sense to change the text of this inline message to 
say "Layout changes have been restricted by the system administrator"?
  
  
  yeah, +1 for that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Kai Uwe Broulik]

broulik added a comment.


  I find "for a year" odd. Also, this is a bug fix, so can we get this in or 
not. Changing strings can then be done in master, if we want to.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: ngraham, bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Giusy Margarita]

kurmikon updated this revision to Diff 81847.
kurmikon added a comment.


  The spinbox would be better a better solution.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29365?vs=81755&id=81847

REVISION DETAIL
  https://phabricator.kde.org/D29365

AFFECTED FILES
  kcms/touchpad/kcm/libinput/touchpad.qml

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Konrad Materka]

kmaterka updated this revision to Diff 81842.
kmaterka added a comment.


  Change warning message

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29344?vs=81724&id=81842

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29344

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/systemtraymodel.cpp

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, 
davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Konrad Materka]

kmaterka added a comment.


  In D29344#662586 , @ngraham wrote:
  
  > 5.19 hasn't branched yet, so code landed in master will still make it there.
  
  
  Maybe there was code freeze for frameworks? Or 5.18.5? Never mind :)
  
  > With this patch, I still see Media Player itself with a blank icon after 
opening Gwenview. Is that expected?
  
  This is a separate issue... :/ I will work on that and create separate fix.

INLINE COMMENTS

> ngraham wrote in ItemLoader.qml:33
> "Illegal" is one of those scary words we try not to use, even in console 
> spew. Consider changing this to "Invalid."
> 
> F8282506: Screenshot_20200503_214934.png 
> 

Old habits from Java world (IllegalStateException), I will change that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, 
davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart