date:20200508

D26111: Runner: make recentdocument use KActivityStats data

2020-05-08 Thread Méven Car

meven marked 2 inline comments as done.
meven added a comment.


  I need to change dev machine, now that plasma-workspace needs Qt5.14, that 
explains the delay.

INLINE COMMENTS

> broulik wrote in recentdocuments.cpp:78
> Do we really want `QUrl::fromUserInput` here? This thing typically assumes 
> web addresses. Maybe pass `AssumeLocalFile`? But I recal that doing a file 
> system access every time checking for existance.. probably not a big deal in 
> this instance since it's in a thread

It is needed for QString coming from KActivitiesStats, they can be 
"/home/meven/doc.txt" or "file://" or "application://" or "http://;.
So QUrl::fromEncoded or QUrl::fromLocalFile can't be used.
AssumeLocalFile would be nice to use, but it requires to provide a working 
directory. https://doc.qt.io/qt-5/qurl.html#fromUserInput-1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26111_1

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  The latter, if you don't mind. I appreciate your patience! I hope to have the 
rewrite submitted tomorrow.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-08 Thread Giusy Margarita

kurmikon added a comment.


  In D29365#40 , @ngraham wrote:
  
  > Indeed, the code here is a catastrophe. I'm actually in the middle of a 
rewrite to make everything more declarative which should make UI changes much 
easier. If you'd like to wait a few days until that's done, it might make your 
patch a lot simpler.
  
  
  Okay, but I don't get it. Will you rewrite touchpad.qml so this can be closed 
and a new revision will be opened or will you just change on this one?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  Indeed, the code here is a catastrophe. I'm actually in the middle of a 
rewrite to make everything more declarative which should make UI changes much 
easier. If you'd like to wait a few days until that's done, it might make your 
patch a lot simpler.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  Managed to re-introduce https://bugs.kde.org/show_bug.cgi?id=414045, so it 
looks like that's not related to this. Will fix it in another patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham updated this revision to Diff 82324.
ngraham added a comment.


  Move the config bar as the panel changes thickness

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29535?vs=82280=82324

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-08 Thread Giusy Margarita

kurmikon updated this revision to Diff 82323.
kurmikon added a comment.


  So I worked on this.
  
  It's not easy to me to do this stuff since the slider and the spinbox have to 
synchronize themselves on the other one.
  
  Making symply and update from one to another would lead to infinite loops.
  
  On first attempt I succeeded to synchronize them, but failed to show the 
right values when the kcm was started, maybe a race condition on the load 
method was causing an issue.
  
  Second attempt, I made it with this diff. It's working, tested several times 
on my system. Test on yours, please.F8301724: Screenshot_20200508_232047.png 

  
  Don't know if there's an easier way to make it. Let me know.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29365?vs=81847=82323

REVISION DETAIL
  https://phabricator.kde.org/D29365

AFFECTED FILES
  kcms/touchpad/kcm/libinput/touchpad.qml

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

2020-05-08 Thread Konrad Materka

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, 
davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  If status is set to NeedsAttention it tries to use Attention Icon. If 
Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is 
null or not, as a result it tries to use empty icon and nothing is rendered.
  Set null QVariant if AttentionIcon is not valid so that QML check will work 
correctly.

TEST PLAN
  - Set NeedsAttention as a status and with no Attention Icon
  - Base Icon should render correctly

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29544

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Andres Betts

abetts added a comment.


  +1 from me!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29518: Remove remaining icons from applets with custom tooltips

2020-05-08 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:eeab79954d7d: Remove remaining icons from applets with 
custom tooltips (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29518?vs=82234=82317

REVISION DETAIL
  https://phabricator.kde.org/D29518

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/showActivityManager/package/contents/ui/main.qml
  applets/showdesktop/package/contents/ui/main.qml
  applets/trash/package/contents/ui/main.qml
  kcms/touchpad/applet/qml/contents/ui/touchpad.qml

To: ngraham, bugseforuns, #plasma, #vdg, kmaterka, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham planned changes to this revision.
ngraham added a comment.


  Need to re-implement the panel thickness change handling

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29517: Remove remaining icons from applets with custom tooltips

2020-05-08 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:1d64bd119235: Remove remaining icons from applets with 
custom tooltips (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29517?vs=82233=82316

REVISION DETAIL
  https://phabricator.kde.org/D29517

AFFECTED FILES
  applets/quicklaunch/package/contents/ui/main.qml
  applets/quickshare/plasmoid/contents/ui/main.qml

To: ngraham, bugseforuns, #plasma, #vdg, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29516: Remove remaining icon from applet with custom tooltip

2020-05-08 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fe20601bddd5: Remove remaining icon from applet with 
custom tooltip (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29516?vs=82232=82314

REVISION DETAIL
  https://phabricator.kde.org/D29516

AFFECTED FILES
  applets/lock_logout/contents/ui/lockout.qml

To: ngraham, bugseforuns, #plasma, #vdg, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

2020-05-08 Thread Aleix Pol Gonzalez

apol updated this revision to Diff 82302.
apol added a comment.


  Adapt to changes in the protocol, implement windows

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=81926=82302

BRANCH
  arcpatch-D28884

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  data/org.freedesktop.impl.portal.desktop.kde.desktop.in
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/screencast.cpp
  src/screencast.h
  src/screencasting.cpp
  src/screencasting.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/screenchooserdialog.ui
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-08 Thread Mikhail Zolotukhin

gikari added a comment.

  In D28623#666400 , @cblack wrote:

  > While this is neat, I'm fairly sure that creating the CSS for this in a 
manner that works across themes is going to be hard if not impossible.

  I'm not completely sure about this right now, but currently I'm only think of 
supporting our own GTK theme - Breeze-GTK.

  > Even our own Breeze GTK uses palette swaps rather than unique pixmaps for 
every state.

  I got it working somehow on Breeze Gtk:
  F8300792: buttons.mp4 

  However I'm not sure how to provide CSS, that I'm using now. It's rather big 
to hardcore IMO. Should I use Sass and install generated file in 
`~/.config/gtk-3.0/windowdecorations.css`, so I could just enable/disable it 
with include statement?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-08 Thread Mikhail Zolotukhin

gikari updated this revision to Diff 82294.
gikari added a comment.


  Export buttons with fixed geometry (Now all buttons are exported with the 
same size)

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82266=82294

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

2020-05-08 Thread Konrad Materka

kmaterka accepted this revision.
kmaterka added a comment.


  plasma-workspace compiles using cmake 3.10 without issues now.

REPOSITORY
  R111 KSysguard Library

BRANCH
  ancient_cmake_fix

REVISION DETAIL
  https://phabricator.kde.org/D29529

To: ahiemstra, #plasma, ngraham, kmaterka
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-08 Thread Carson Black

cblack added a comment.


  While this is neat, I'm fairly sure that creating the CSS for this in a 
manner that works across themes is going to be hard if not impossible. Even our 
own Breeze GTK uses palette swaps rather than unique pixmaps for every state.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

2020-05-08 Thread Marco Martin

mart updated this revision to Diff 82289.
mart added a comment.


  - Merge branch 'sensors_lib' into mart/sensor_face

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82279=82289

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorQuery.cpp
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  When I create a new System Monitor Sensor widget, it's totally blank: 
F8300732: Screenshot_20200508_103957.png 
  
  Needs to have a Configure... button on it in this case.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham added a subscriber: ahiemstra.
ngraham added a comment.


  An idea brought up by @ahiemstra would be to add dragability into the SpinBox 
control itself, which was suggested in T9460 
 and would automatically 
re-implement/preserve draggability. I can look into that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28487: Redesign of system monitor plasmoids

2020-05-08 Thread Marco Martin

mart updated this revision to Diff 82287.
mart added a comment.


  - Merge branch 'master' into mart/mewSystemMonitor

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=82224=82287

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/contents/config/faceproperties
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/config/faceproperties
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/config/faceproperties
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/config/faceproperties
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/config/faceproperties
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/config/faceproperties
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  applets/systemmonitor/systemmonitor/package/metadata.desktop
  applets/systemmonitor/systemmonitor/systemmonitor-faces.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor-presets.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor.cpp
  applets/systemmonitor/systemmonitor/systemmonitor.h

To: mart, #plasma
Cc: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  Very cool stuff!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29157: force systemsettings for kcms

2020-05-08 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.


  I say ship it!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/systemsettings

REVISION DETAIL
  https://phabricator.kde.org/D29157

To: mart, #plasma, ngraham
Cc: broulik, ngraham, davidre, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29157: force systemsettings for kcms

2020-05-08 Thread Marco Martin

mart updated this revision to Diff 82283.
mart added a comment.


  - infocenter modules in own category

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29157?vs=82282=82283

BRANCH
  phab/systemsettings

REVISION DETAIL
  https://phabricator.kde.org/D29157

AFFECTED FILES
  runners/services/servicerunner.cpp

To: mart, #plasma, ngraham
Cc: broulik, ngraham, davidre, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29157: force systemsettings for kcms

2020-05-08 Thread Marco Martin

mart updated this revision to Diff 82282.
mart added a comment.


  - use kinfocenter for kinfocenter modules

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29157?vs=81320=82282

BRANCH
  phab/systemsettings

REVISION DETAIL
  https://phabricator.kde.org/D29157

AFFECTED FILES
  runners/services/servicerunner.cpp

To: mart, #plasma, ngraham
Cc: broulik, ngraham, davidre, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  In D29535#666303 , @abetts wrote:
  
  > I love this idea. I would request to keep the drag behavior and follow up 
with a second ticket to propose a change in the drag behavior for the panel.
  
  
  I considered that, but while implementing it and playing with the result I 
became less and less convinced that a drag-based interaction makes sense here. 
Dragging favors large movements where precision of the final result is not 
important, which is pretty much the opposite of how people adjust their panels.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham updated this revision to Diff 82280.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use less arbitrary min and max values

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29535?vs=82277=82280

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Andres Betts

abetts added a comment.


  I love this idea. I would request to keep the drag behavior and follow up 
with a second ticket to propose a change in the drag behavior for the panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Carson Black

cblack added inline comments.

INLINE COMMENTS

> ToolBar.qml:119-120
> +
> +from: 2
> +to: 960
> +stepSize: 2

These values seem arbitrary. Could it be possible to base off the screen 
dimensions?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

2020-05-08 Thread Marco Martin

mart updated this revision to Diff 82279.
mart added a comment.


  - sensorColors is now a map
  - fix preset uninstall

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82223=82279

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

2020-05-08 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: abetts, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We receive many complaints and bug reports about the current UI for adjusting 
panel
  thickness. People don't figure out that they have to drag on the button, and 
when they do,
  they complain that they can't set the value finely enough. Furthermore there 
are some bugs
  with scrolling and dragging behavior.
  
  This patch removes the draggable button and replaces it with a more 
conventional SpinBox,
  this is given scroll-adjustment behaviors in D29534 
. This yields the following
  improvements:
  
  - The way you adjust panel thickness is now more obvious
  - Fine-tuning panel thickness is now easier
  - Panel thickness can now be specified numerically
  - We have one fewer custom control to maintain
  - Bugs in custom scrolling implementation go away
  
  The current click/touch-and-drag behavior is therefore removed. I think this 
is acceptable
  because it's not a very good match for this use case anyway; a drag-based UI 
favors large
  changes where precision of the final result is not important. This does not 
describe the
  panel adjustment use case where you are changing the value by at most a few 
dozen and very
  commonly just want to adjust it up or down a tiny amount or want to end up at 
a specific
  size.
  
  BUG: 414045
  BUG: 418700
  BUG: 421169
  FIXED-IN: 5.19

TEST PLAN
  F8300568: Horizontal panel.webm 
  F8300567: Vertical panel.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

2020-05-08 Thread Roman Gilg

romangg abandoned this revision.
romangg added a comment.


  Will become an external plugin with libkscreen Wayland headers being exported 
now.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D29029: feat(wayland): add plugin for wlroots based compositors

2020-05-08 Thread Roman Gilg

romangg abandoned this revision.
romangg added a comment.


  Will become an external plugin with libkscreen Wayland headers being exported 
now.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29029

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29533: [Reminder] Also advert Chromie store for Vivaldi

2020-05-08 Thread Fabian Vogt

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  "Chromie"? :D
  
  For some reason I can't get the reminder to trigger.
  
  `dbus-monitor` shows
  
method call time=1588952594.025913 sender=:1.16 -> 
destination=org.kde.ActivityManager serial=1613 
path=/ActivityManager/Resources; interface=org.kde.ActivityManager.Resources; 
member=RegisterResourceEvent
   string "org.kde.libtaskmanager"
   uint32 0
   string "applications:vivaldi-stable.desktop"
   uint32 0
  
  But the `ResourceScoreUpdated` signal never fires.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29533

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29533: [Reminder] Also advert Chromie store for Vivaldi

2020-05-08 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They advertise supporting Chrome extensions

TEST PLAN
  Untested
  
  To test:
  
  - Run kded with `PLASMA_BROWSE_REMIND_FORCE=1`, load the reminder module in 
background services kcm (it disables autoloading if it has reminded once), then 
launch vivaldi through its desktop file (i.e. not the shell runner)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29533

AFFECTED FILES
  reminder/browserintegrationreminder.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-08 Thread Mikhail Zolotukhin

gikari updated this revision to Diff 82266.
gikari added a comment.


  Support the maximize button in the checked state

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82206=82266

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-05-08 Thread Roman Gilg

romangg added a comment.


  A separate library KScreenWayland is installed additionally to the runtime 
plugin, so that library can be linked against to create nested plugins for a 
Wayland session. These plugins must be installed in a certain directory 
(usually`/usr/lib/plugins/org.kde.libkscreen.backends/wayland/`) so they can be 
discovered at runtime after the Wayland plugin has been loaded. For each plugin 
a separate connection is established to the Wayland compositor as before and 
depending on reply the plugin is used or discarded.
  
  KWayland plugin is by default compiled with libkscreen.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29024

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-05-08 Thread Roman Gilg

romangg updated this revision to Diff 82265.
romangg added a comment.


  - refactor: export Wayland plugins headers

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29024?vs=80700=82265

BRANCH
  wayland-plugins-export

REVISION DETAIL
  https://phabricator.kde.org/D29024

AFFECTED FILES
  CONTRIBUTING.md
  backends/kwayland/CMakeLists.txt
  backends/kwayland/KScreenWaylandConfig.cmake.in
  backends/kwayland/plugins/CMakeLists.txt
  backends/kwayland/plugins/kwayland/CMakeLists.txt
  backends/kwayland/plugins/kwayland/kwayland.json
  backends/kwayland/plugins/kwayland/kwayland_interface.cpp
  backends/kwayland/plugins/kwayland/kwayland_interface.h
  backends/kwayland/plugins/kwayland/kwayland_output.cpp
  backends/kwayland/plugins/kwayland/kwayland_output.h
  backends/kwayland/wayland_interface.cpp
  backends/kwayland/wayland_interface.h
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h
  backends/kwayland/waylandscreen.cpp

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

2020-05-08 Thread Nathaniel Graham

ngraham updated this revision to Diff 82264.
ngraham added a comment.


  Remove more FIXMEs (the first one was already broken with the current 
implementation), and for the second one, there's no better way to implement 
this, though I may remove the logic entirely

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=82262=82264

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

2020-05-08 Thread Arjen Hiemstra

ahiemstra added a comment.


  Please see if D29529  resolves it.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29302

To: ahiemstra, #plasma, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

2020-05-08 Thread Arjen Hiemstra

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Apparently IMPORTED_GLOBAL is a 3.11 feature and Neon uses 3.10

TEST PLAN
  Use CMake 3.10, plasma-workspace compiles again.

REPOSITORY
  R111 KSysguard Library

BRANCH
  ancient_cmake_fix

REVISION DETAIL
  https://phabricator.kde.org/D29529

AFFECTED FILES
  KF5SysGuardConfig.cmake.in

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

2020-05-08 Thread Nathaniel Graham

ngraham updated this revision to Diff 82262.
ngraham added a comment.


  Fix a FIXME

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=82111=82262

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29264: New tabs for Breeze

2020-05-08 Thread Nathaniel Graham

ngraham added a comment.


  The tab widget's active tab background color is something that can be played 
with in code--and already is, in fact. With the default Breeze color scheme, 
observe how it has a subtly lightened background color compared to the rest of 
the view background.
  
  Since everybody loves @manualjlin's mockups, faithfully implementing those 
always seems like a good idea to me. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

2020-05-08 Thread Konrad Materka

kmaterka added a comment.


  In D29302#666138 , @ahiemstra 
wrote:
  
  > Which version of CMake are you using? I needed to promote the imported 
KSysGuard targets to "global" using set_target_property. Without that, I saw 
similar errors. The IMPORTED_GLOBAL property was added in CMake 3.11.
  
  
  Cmake version: 3.10.2
  
  Is is a default in Neon, based on Ubuntu 18.04.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29302

To: ahiemstra, #plasma, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29302: Use KSysGuard namespace for KSysGuard library targets

2020-05-08 Thread Arjen Hiemstra

ahiemstra added a comment.


  Which version of CMake are you using? I needed to promote the imported 
KSysGuard targets to "global" using set_target_property. Without that, I saw 
similar errors. The IMPORTED_GLOBAL property was added in CMake 3.11.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29302

To: ahiemstra, #plasma, davidedmundson
Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29393: Use player "poster" as album cover if available

2020-05-08 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:811ae0dd5a54: Use player poster as album 
cover if available (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29393?vs=81828=82240

REVISION DETAIL
  https://phabricator.kde.org/D29393

AFFECTED FILES
  extension/content-script.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

47 matches

Mail list logo