D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> SensorBrowser.cpp:53
> +}
>  qDeleteAll( mHostInfoMap );
>  mHostInfoMap.clear();

When you delete the map content, all agents should loose their connections, no?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28509: [libnotificationmanager] introduce the WatchedNotificationsModel

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2357e6f2e134: [libnotificationmanager] introduce the 
WatchedNotificationsModel (authored by bshah).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28509?vs=82489=82490

REVISION DETAIL
  https://phabricator.kde.org/D28509

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/abstractnotificationsmodel.cpp
  libnotificationmanager/abstractnotificationsmodel.h
  libnotificationmanager/abstractnotificationsmodel_p.h
  libnotificationmanager/dbus/org.kde.notificationmanager.xml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/watchednotificationsmodel.cpp
  libnotificationmanager/watchednotificationsmodel.h

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28509: [libnotificationmanager] introduce the WatchedNotificationsModel

[Bhushan Shah]

bshah updated this revision to Diff 82489.
bshah added a comment.


  rebase on master

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28509?vs=80990=82489

BRANCH
  bshah/notification-watcher

REVISION DETAIL
  https://phabricator.kde.org/D28509

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/abstractnotificationsmodel.cpp
  libnotificationmanager/abstractnotificationsmodel.h
  libnotificationmanager/abstractnotificationsmodel_p.h
  libnotificationmanager/dbus/org.kde.notificationmanager.xml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/watchednotificationsmodel.cpp
  libnotificationmanager/watchednotificationsmodel.h

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29618: Fix case fallback warning

[Jiří Paleček]

jpalecek created this revision.
jpalecek added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
jpalecek requested review of this revision.

REVISION SUMMARY
  Courtesy of gcc warnings: in decoding of the "ps" reply, the answer
   would be wrongly used as free memory as well due to a missing break.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29618

AFFECTED FILES
  processcore/processes_remote_p.cpp

To: jpalecek, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29617: Renice all threads of a multithreaded process

[Jiří Paleček]

jpalecek created this revision.
jpalecek added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
jpalecek requested review of this revision.

REVISION SUMMARY
  This is a mirror of D29615  implemented 
in libksysguard for local
   processes. All the same comments apply.

REPOSITORY
  R111 KSysguard Library

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29617

AFFECTED FILES
  processcore/processes_linux_p.cpp

To: jpalecek, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

[Jiří Paleček]

jpalecek created this revision.
jpalecek added reviewers: davidedmundson, ahiemstra.
Herald added a project: Plasma.
jpalecek requested review of this revision.

REVISION SUMMARY
  When some SensorClients are destroyed, eg. when KSysguard is closed,
   they fail to deregister themselves from SensorAgent. This may cause a
   crash when further messages arrive for them. This patch fixes that.
  
  BUG: 350140

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

AFFECTED FILES
  gui/SensorBrowser.cpp
  gui/ksysguard.cpp
  gui/ksysguard.h

To: jpalecek, davidedmundson, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29615: Nice all threads of multithreaded programs

[Jiří Paleček]

jpalecek created this revision.
jpalecek added reviewers: ahiemstra, davidedmundson.
Herald added a project: Plasma.
jpalecek requested review of this revision.

REVISION SUMMARY
  Setting process priorities by ksysguard has the flaw that it only
   sets priority of a single thread of a multithreaded program. For
   example, if I want to put handbrake encoding to the background, it
   usually fails as other threads from the same process continue to hog
   the CPU. This patch changes the behavior by attempting to change the
   priority of all threads (on Linux).
  
  There is a caveat: when the threads' priorities were previously
   different, it may mean you change the priority against the logic of
   the application. For example some background threads of an
   application might end up having the same priority as the
   foreground. As a corollary, the call may mean lowering priority of
   some threads, but raising it for others and thus fail due to
   insufficient capabilities. Still, I think this behavior is actually
   the only one usable, until we have individual threads in
   ksysguard. Even then, I doubt people will look at the individual
   threads when renicing. Till then, the ability to renice a task is a
   need which ksysguard should fulfill, but unfortunately doesn't.
  
  Note: this only changes the behavir for remote computers. Local use
   needs a similar fix in libksysguard.

TEST PLAN
Run a multithreaded process which uses the CPU (like video coding)
Set its priority to low
Check with ps -p $pid -L o pid,lwp,pri,comm

REPOSITORY
  R106 KSysguard

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29615

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: jpalecek, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully

[Jiří Paleček]

jpalecek added a comment.


  Could this be committed please?

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23592

To: jpalecek, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23704: Allow tmpfs in ksysguard disk space monitor

[Jiří Paleček]

jpalecek added a comment.


  @davidedmundson Can you please have a look at this?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23704

To: jpalecek, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: kwallet-pam >= 5.18.4 and ecryptfs homes

[Albert Astals Cid]

P.S: Remember to CC me

El dilluns, 4 de maig de 2020, a les 21:11:22 CEST, Nate Graham va escriure:
> On 5/3/20 4:02 PM, Albert Astals Cid wrote:> Problem with SOLUTION 1 is 
> that it adds lots of code in a relative "sensitive" piece of code like a 
> pam module for for what it is a one time thing.
> > Problem with SOLUTION 2 is that it's not a solution :D
> > 
> > 
> > Opinions?
> 
> I feel pretty confident in your skills at implementing option 1 safely. 
> :) 

Here the problem is that i actually need to be able to reproduce the issue 
myself first, i guess i can try installing some old KUbuntu and then upgrading 
in a VM. Let's try to give it a try.

> Once the code is pushed out to users in 5.18.5, could we remove it in 
> master to avoid an ongoing maintenance and security issues?

No, we need it "forever" so that people updating from < 5.18.3 to >= 5.18.4 
don't face the problem.

Cheers,
  Albert

P.S: Remember to CC me

> In any event, it seems like we don't really have much of a choice since 
> as you mention, option 2 doesn't actually solve the problem for the 
> typical user.
> 
> Nate
> 

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:63deb6a0125b: Kill Runner: Move config keys to new file 
(authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27576?vs=79224=82462

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Méven Car]

meven accepted this revision.
meven added a comment.


  In D27576#659971 , @alex wrote:
  
  > @meven and others, may I ship this?
  
  
  Yep ship it, it is low risk.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29603: Adds custom spacing between task manager icons

[Jacopo Martellini]

martellini created this revision.
martellini added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
martellini requested review of this revision.

REVISION SUMMARY
  Adds the option to set a custom spacing between the icons of the icons-only 
task manager.
  Both horizontal and vertical spacing can be set.
  Probably there should be an upper limit, but I don't know what it could be.
  
  BUG: 363878

REPOSITORY
  R119 Plasma Desktop

BRANCH
  adjustable-spacing-between-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29603

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/code/layout.js

To: martellini, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29125: lookandfeel kcm: port from KRun::runApplication to KIO::ApplicationLauncherJob

[David Faure]

dfaure closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29125

To: dfaure, broulik, ngraham, crossi, mart, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29125: lookandfeel kcm: port from KRun::runApplication to KIO::ApplicationLauncherJob

[David Faure]

dfaure added a comment.


  ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29125

To: dfaure, broulik, ngraham, crossi, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29601: Port KRun::runApplication to ApplicationLauncherJob

[David Faure]

dfaure closed this revision.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29601

To: dfaure, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29601: Port KRun::runApplication to ApplicationLauncherJob

[David Faure]

dfaure created this revision.
dfaure added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29601

AFFECTED FILES
  CMakeLists.txt
  reminder/browserintegrationreminder.cpp

To: dfaure, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29571: [Kickoff] Add emacs/bash style keybindings

[David Edmundson]

davidedmundson added a comment.


  > Does the mechanism of standard shortcuts really apply here?
  
  It's not implementing it yet, but that's the entire point.
  
  The bigger problem is someone added some vim shortcuts to krunner a year ago: 
(plasma-workspace a58e48707601d627781c6681389e4abe0f6e8899 
) in 
hindsight I shouldn't have accepted it.
  
  This is showing there's a bigger problem that needs to be addressed at the 
root. We can't be inconsistent with secondary shortcuts within our own code. 
Sorry.
  
  In terms of actions this means:
  
  - exposing KStandardAction::rotateUp/rotateDown somewhere generic
  - porting from KeyEvent to Shortcuts inside the QML

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29571

To: mlibera, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29595: Add gocryptfs support

[Martino Pilia]

mpilia created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mpilia requested review of this revision.

REVISION SUMMARY
  Implement basic support for gocryptfs backend.
  
  BUG: 398323

REPOSITORY
  R845 Plasma Vault

BRANCH
  add-gocryptfs-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29595

AFFECTED FILES
  kded/CMakeLists.txt
  kded/engine/backend_p.cpp
  kded/engine/backends/gocryptfs/gocryptfsbackend.cpp
  kded/engine/backends/gocryptfs/gocryptfsbackend.h
  kded/engine/fusebackend_p.cpp
  kded/ui/vaultconfigurationdialog.cpp
  kded/ui/vaultcreationwizard.cpp
  kded/ui/vaultimportingwizard.cpp
  kded/ui/vaultwizardbase.h

To: mpilia
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Noah Davis]

ndavis added a comment.


  I agree with the size chosen if we are doing a vertical panel, but I can't 
think of any way to justify this change in a way that I find satisfactory. 
There's no clear improvement over using a horizontal panel, just tradeoffs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ndavis, niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D29594: Close low battery notificaton when showing critical

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When not acknowledging the low battery notification, close it when showing 
the critical one, to avoid showing contradicting notificatoins.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29594

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> PowerManagementItem.qml:34
>  Layout.fillWidth: true
> +Layout.leftMargin: units.smallSpacing
>  

How does this affect RTL layouts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma
Cc: ndavis, abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29580: [kcms/keys] Also consider portable text when filtering

[David Redondo]

davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Enables searching for "ctrl" or "shift" in non english locale

REPOSITORY
  R119 Plasma Desktop

BRANCH
  portabletext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29580

AFFECTED FILES
  kcms/keys/filteredmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29579: [kcms/keys] Really ignore unknown action

[David Redondo]

davidre created this revision.
davidre added reviewers: ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise the end() iterator is dereferenced resulting in a crash
  BUG: 421016

TEST PLAN
  Import a predefined scheme

REPOSITORY
  R119 Plasma Desktop

BRANCH
  crash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29579

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart