D3835: [Calendar] Populate overview models on-demand

2020-05-29 Thread Méven Car
meven accepted this revision as: meven.
meven added a comment.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.


  @broulik is it still on the table ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D3835

To: broulik, #plasma, mart, meven
Cc: kde-frameworks-devel, meven, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, 
ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart


D29466: [applets/appmenu] Add search to global application menu

2020-05-29 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> nicolasfella wrote in appmenumodel.h:70
> const

actions are needed as non-const

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29466: [applets/appmenu] Add search to global application menu

2020-05-29 Thread Carson Black
cblack updated this revision to Diff 83175.
cblack marked 5 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29466?vs=82144&id=83175

BRANCH
  arcpatch-D29466

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29831: Update availableScreenRect when a panel moves to another screen

2020-05-29 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29831

To: akandaurov, #plasma, davidedmundson
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: Gitlab and plasma dev

2020-05-29 Thread Arjen Hiemstra
On Wednesday, 27 May 2020 20:11:25 CEST David Edmundson wrote:
> One thing I'm missing when I'm doing reviews is I don't have a nice way to
> separate merge requests that need review, and merge requests that are
> awaiting changes.
> 
> I think this could be achieved with a label, that reviewers can set and
> authors can clear when they're ready.
> Somehow it's possible to create a label that covers all of Plasma as the
> VDG have one already.

Maybe we can even go one step further and also make an "accepted" label or 
some such? That would remove the need for people to comment, instead you can 
just apply the label, which should still generate notifications, unlike 
reactions.

- Arjen

> 
> Would that workflow work for other devs?
> 
> David






KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 113 - Still Failing!

2020-05-29 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/113/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 29 May 2020 11:55:35 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 3798 lines...][2020-05-29T12:08:29.381Z] gmake[1]: *** Waiting for unfinished jobs[2020-05-29T12:08:29.381Z] [ 50%] Building CXX object kcms/lookandfeel/CMakeFiles/kcm_lookandfeel.dir/lookandfeelsettings.cpp.o[2020-05-29T12:08:29.644Z] [ 50%] Built target kcm_keys[2020-05-29T12:08:29.644Z] [ 50%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/componentchooserbrowser.cpp.o[2020-05-29T12:08:29.644Z] [ 50%] Built target kcm_desktoppaths[2020-05-29T12:08:29.644Z] [ 50%] Building CXX object kcms/activities/imports/CMakeFiles/kactivitiessettingsplugin.dir/plugin.cpp.o[2020-05-29T12:08:29.942Z] [ 50%] Linking CXX shared module ../../bin/kcm_smserver.so[2020-05-29T12:08:30.218Z] [ 50%] Linking CXX executable ../../bin/lookandfeeltool[2020-05-29T12:08:30.504Z] [ 50%] Built target kcm_smserver[2020-05-29T12:08:30.504Z] [ 50%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/kcm_activities.cpp.o[2020-05-29T12:08:30.504Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/krdb/krdb.cpp:228:7: warning: 'sprintf' is deprecated: Use asprintf(), arg() or QTextStream instead [-Wdeprecated-declarations][2020-05-29T12:08:30.823Z]   tmp.sprintf("#define %s #%02x%02x%02x\n",[2020-05-29T12:08:30.823Z]   ^[2020-05-29T12:08:30.823Z] /usr/local/include/qt5/QtCore/qstring.h:381:5: note: 'sprintf' has been explicitly marked deprecated here[2020-05-29T12:08:30.823Z] QT_DEPRECATED_X("Use asprintf(), arg() or QTextStream instead")[2020-05-29T12:08:30.823Z] ^[2020-05-29T12:08:30.823Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-05-29T12:08:30.823Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-05-29T12:08:30.823Z] ^[2020-05-29T12:08:30.823Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:676:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-05-29T12:08:30.823Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-05-29T12:08:30.823Z]   ^[2020-05-29T12:08:30.823Z] [ 50%] Built target lookandfeeltool[2020-05-29T12:08:30.823Z] [ 50%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/componentchooserfilemanager.cpp.o[2020-05-29T12:08:30.823Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/krdb/krdb.cpp:544:23: warning: 'flush' is deprecated [-Wdeprecated-declarations][2020-05-29T12:08:30.823Z] QApplication::flush();[2020-05-29T12:08:30.823Z]   ^[2020-05-29T12:08:30.823Z] /usr/local/include/qt5/QtCore/qcoreapplication.h:169:5: note: 'flush' has been explicitly marked deprecated here[2020-05-29T12:08:30.823Z] QT_DEPRECATED static void flush();[2020-05-29T12:08:30.823Z] ^[2020-05-29T12:08:30.823Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-05-29T12:08:30.823Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2020-05-29T12:08:30.823Z] ^[2020-05-29T12:08:30.823Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-05-29T12:08:30.823Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-05-29T12:08:30.823Z] ^[2020-05-29T12:08:31.826Z] [ 50%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/componentchooseremail.cpp.o[2020-05-29T12:08:31.826Z] 2 warnings generated.[2020-05-29T12:08:31.826Z] [ 50%] Building CXX object kcms/activities/imports/CMakeFiles/kactivitiessettingsplugin.dir/activitysettings.cpp.o[2020-05-29T12:08:31.826Z] [ 50%] Building CXX object kcms/activities/imports/CMakeFiles/kactivitiessettingsplugin.dir/dialog.cpp.o[2020-05-29T12:08:32.463Z] [ 51%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/componentchooserterminal.cpp.o[2020-05-29T12:08:32.463Z] [ 51%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/MainConfigurationWidget.cpp.o[2020-05-29T12:08:32.724Z] [ 51%] Linking CXX shared module ../../bin/kcm_lookandfeel.so[2020-05-29T12:08:33.346Z] [ 51%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/kcm_componentchooser.cpp.o[2020-05-29T12:08:33.346Z] [ 51%] Built target kcm_lookandfeel[2020-05-29T12:08:33.346Z] [ 52%] Building CXX object kcms/activities/imports/CMakeFiles/kactivitiessettingsplugin.dir/features_interface.cpp.o[2020-05-29T12:08:33.614Z] [ 52%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/ActivitiesTab.cpp.o[2020-05-29T12:08:34.192Z] [ 52%] Bu

Gitlab + milestone for Plasma group

2020-05-29 Thread Bhushan Shah
Helo

I have just promoted 5.20 milestone which was added in KWin to Plasma
group:

https://invent.kde.org/groups/plasma/-/milestones/1

So now we have nice way of marking specific merge requests or tasks as
targetted towards specific milestone

Let's start to make use of this feature, so we have nice summary of
major changes done for specific release, and what needs to be
merged/finished before release.

Cheers!

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature


D27004: [kstyle] Drop XCB and KWayland dependency

2020-05-29 Thread Vlad Zahorodnii
zzag added a comment.


  Will move to GitLab.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27004

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27003: [kstyle] Port to QWindow::startSystemMove()

2020-05-29 Thread Vlad Zahorodnii
zzag abandoned this revision.
zzag added a comment.


  Will move to GitLab.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27003

To: zzag, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D21987: Extend KDE Connect to images, video, audio, selection

2020-05-29 Thread Kai Uwe Broulik
broulik abandoned this revision.
broulik added a comment.


  We have image/video/audio now, text selection I might add later but maybe not 
soo useful after alll

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21987

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 112 - Still Failing!

2020-05-29 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/112/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 29 May 2020 07:42:03 +
 Build duration:
2 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 4163 lines...][2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-29T07:44:44.600Z]^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-29T07:44:44.600Z]  ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:23: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-05-29T07:44:44.600Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-05-29T07:44:44.600Z]   ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-29T07:44:44.600Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-29T07:44:44.600Z]   ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-29T07:44:44.600Z]^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-29T07:44:44.600Z]  ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:58: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-05-29T07:44:44.600Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-05-29T07:44:44.600Z]  ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-29T07:44:44.600Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-29T07:44:44.600Z]   ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-29T07:44:44.600Z]^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-29T07:44:44.600Z]  ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:389:44: warning: 'getItem' is deprecated [-Wdeprecated-declarations][2020-05-29T07:44:44.600Z] const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-05-29T07:44:44.600Z]^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:1: note: 'getItem' has been explicitly marked deprecated here[2020-05-29T07:44:44.600Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString &caption, const QString &label,[2020-05-29T07:44:44.600Z] ^[2020-05-29T07:44:44.600Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-29T07:44:44.600Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS

D15418: Dim application icon when it is not playing anything

2020-05-29 Thread Kai Uwe Broulik
broulik abandoned this revision.
broulik added a comment.


  I'd prefer some dimmed label next to the app name but with the radio button 
and manual size calculations all over the place now, this is difficult

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra


D29478: [Clipboard Plasmoid] Port to Prison QML import

2020-05-29 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7bd9bea0723c: [Clipboard Plasmoid] Port to Prison QML 
import (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29478?vs=82076&id=83171

REVISION DETAIL
  https://phabricator.kde.org/D29478

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/Menu.qml

To: broulik, #plasma, vkrause
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart