D29876: ScreenPool: Store primary connector separately
cblack added a comment. Thanks for the patch, however we use GitLab now for contributing code. Would you mind opening this as an MR at https://invent.kde.org/plasma/plasma-workspace? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29876 To: genpfault Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29876: ScreenPool: Store primary connector separately
genpfault created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. genpfault requested review of this revision. REVISION SUMMARY - Store the primary connector in a dedicated config key instead of making slot 0 do double-duty. This prevents setPrimaryConnector() from renumbering the connector list and 'losing' existing panel/desktop settings. - Add a helper function to generate connector names instead of using QScreen::name() everywhere. The helper function defaults to a QScreen::manufacturer()/model()/serialNumber() tuple where available with a fall-back to the original name() logic. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29876 AFFECTED FILES shell/autotests/screenpooltest.cpp shell/screenpool.cpp shell/screenpool.h shell/shellcorona.cpp To: genpfault Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
Re: plasma-systemmonitor in kdereview
On Friday, 2 October 2020 17:10:36 CEST Carl Schwan wrote: > Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra a écrit : > > Hello, > > > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It > > makes use of the ksystemstats daemon and the faces system for system > > monitor plasmoids that were both introduced in Plasma 5.19. > > > > Our current plan is to do a "preview release" alongside Plasma 5.20, then > > have it be an official part of Plasma with 5.21. > > Plasma System Monitor looks quite good, but it doesn't look like it is > navigable with the keyboard only. I know that some of the issues are caused > by Kirigami and Qml but it looks like many custom components can't get any > focus with tab and need the mouse to work. That's a good point, I think for a first pass I'd ensure that normal "viewing" works. Making the edit mode work with keyboard is going to be another thing entirely since that very much relies on drag and drop currently. > > It is also normal for Table component to import private api from > qqc2-desktop-style framework? Normal, no. Required, yes unfortunately. When this was written there was no header control available. And even now if we port to HorizontalHeaderView we'd probably need the private import since the API of HorizontalHeaderView is severely lacking, so we'd need to replace the delegate which means we'd need some way of getting the system-styled header item. > > https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/table/F > irstCellDelegate.qml#L13 > > Cheers, > Carl > > > Cheers, > > Arjen
Re: plasma-systemmonitor in kdereview
Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra a écrit : > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the ksystemstats daemon and the faces system for system monitor > plasmoids that were both introduced in Plasma 5.19. > > Our current plan is to do a "preview release" alongside Plasma 5.20, then have > it be an official part of Plasma with 5.21. Plasma System Monitor looks quite good, but it doesn't look like it is navigable with the keyboard only. I know that some of the issues are caused by Kirigami and Qml but it looks like many custom components can't get any focus with tab and need the mouse to work. It is also normal for Table component to import private api from qqc2-desktop-style framework? https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/table/FirstCellDelegate.qml#L13 Cheers, Carl > > Cheers, > Arjen
KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.15 - Build # 45 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.15/45/ Project: stable-kf5-qt5 SUSEQt5.15 Date of build: Thu, 24 Sep 2020 11:12:23 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 114 test(s), Skipped: 0 test(s), Total: 114 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report72% (69/96)65% (455/696)65% (455/696)58% (60223/104391)38% (26240/68507)Coverage Breakdown by Package Name FilesClassesLinesConditionalsdefault88% (139/158)88% (139/158)66% (20777/31408)51% (10293/20093)autotests97% (28/29)97% (28/29)92% (4420/4785)52% (1524/2914)autotests.drm100% (2/2)100% (2/2)96% (100/104)60% (25/42)autotests.integration100% (66/66)100% (66/66)99% (17594/17846)47% (7982/17069)autotests.integration.effects100% (10/10)100% (10/10)99% (1396/1400)46% (816/1768)autotests.integration.fakes.org.kde.kdecoration2100% (1/1)100% (1/1)95% (18/19)100% (0/0)autotests.integration.helper0% (0/3)0% (0/3)0% (0/44)0% (0/2)autotests.integration.scripting100% (2/2)100% (2/2)99% (238/239)40% (131/330)autotests.libinput100% (11/11)100% (11/11)98% (2546/2602)59% (835/1424)autotests.libkwineffects100% (4/4)100% (4/4)99% (596/602)54% (257/472)autotests.libxrenderutils100% (1/1)100% (1/1)100% (12/12)100% (0/0)autotests.tabbox100% (8/8)100% (8/8)88% (336/380)55% (107/194)colorcorrection100% (7/7)100% (7/7)79% (677/857)59% (238/401)data0% (0/1)0% (0/1)0% (0/30)0% (0/8)decorations100% (10/10)100% (10/10)78% (456/585)63% (140/221)effects100% (2/2)100% (2/2)99% (156/158)86%
KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.15 - Build # 224 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.15/224/ Project: kf5-qt5 SUSEQt5.15 Date of build: Thu, 01 Oct 2020 12:44:52 + Build duration: 8 min 10 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report7% (4/57)12% (33/267)12% (33/267)13% (2470/18721)11% (1059/9507)Coverage Breakdown by Package Name FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0% (0/1)0% (0/1)0% (0/30)0% (0/10)applets.kimpanel.backend.ibus.emojier0% (0/1)0% (0/1)0% (0/180)0% (0/107)applets.kimpanel.backend.ibus.ibus150% (0/10)0% (0/10)0% (0/1098)0% (0/590)applets.kimpanel.backend.scim0% (0/1)0% (0/1)0% (0/663)0% (0/267)applets.kimpanel.plugin0% (0/5)0% (0/5)0% (0/312)0% (0/79)applets.pager.plugin0% (0/4)0% (0/4)0% (0/368)0% (0/234)applets.showdesktop.plugin0% (0/2)0% (0/2)0% (0/15)0% (0/4)applets.taskmanager.plugin0% (0/3)0% (0/3)0% (0/318)0% (0/212)applets.taskmanager.plugin.smartlaunchers0% (0/4)0% (0/4)0% (0/236)0% (0/202)applets.trash.plugin0% (0/5)0% (0/5)0% (0/122)0% (0/52)containments.desktop.plugins.desktop0% (0/2)0% (0/2)0% (0/48)0% (0/18)containments.desktop.plugins.folder30% (6/20)30% (6/20)39% (938/2381)28% (392/1421)containments.desktop.plugins.folder.autotests100% (4/4)100% (4/4)100% (557/557)60% (221/368)imports.activitymanager0% (0/3)0% (0/3)0% (0/438)0% (0/242)kaccess0% (0/3)0% (0/3)0% (0/579)0% (0/282)kcms.access0% (0/1)0% (0/1)0% (0/343)0% (0/80)kcms.activities0% (0/8)0%
KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.15 - Build # 255 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.15/255/ Project: kf5-qt5 SUSEQt5.15 Date of build: Wed, 23 Sep 2020 09:19:33 + Build duration: 8 hr 43 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 4 test(s), Passed: 110 test(s), Skipped: 0 test(s), Total: 114 test(s)Failed: projectroot.autotests.integration.kwin_testPlasmaSurfaceFailed: projectroot.autotests.integration.kwin_testPlasmaSurface_waylandonlyFailed: projectroot.autotests.integration.kwin_testVirtualKeyboardFailed: projectroot.autotests.integration.kwin_testVirtualKeyboard_waylandonlyName: projectroot.autotests.integration Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report69% (59/85)58% (322/559)58% (322/559)43% (32960/76351)33% (14559/44274)Coverage Breakdown by Package Name FilesClassesLinesConditionalsdefault88% (139/158)88% (139/158)66% (20760/31400)51% (10275/20081)colorcorrection100% (7/7)100% (7/7)81% (692/857)62% (250/401)data0% (0/1)0% (0/1)0% (0/30)0% (0/8)decorations100% (10/10)100% (10/10)78% (456/585)63% (140/221)effects100% (2/2)100% (2/2)99% (156/158)86% (24/28)effects.backgroundcontrast25% (1/4)25% (1/4)4% (14/383)4% (12/292)effects.blur20% (1/5)20% (1/5)2% (14/692)3% (13/405)effects.colorpicker100% (2/2)100% (2/2)19% (12/62)8% (2/24)effects.coverswitch33% (1/3)33% (1/3)0% (2/657)1% (4/530)effects.cube25% (1/4)25% (1/4)0% (2/1291)0% (0/1003)effects.cubeslide67% (2/3)67% (2/3)34% (164/486)20% (72/358)effects.desktopgrid67% (2/3)67% (2/3)8% (79/970)3% (29/890)effects.diminactive33% (1/3)33% (1/3)15% (36/239)2% (3/158)effects.fallapart100% (2/2)100% (2/2)34% (38/111)27% (17/64)effects.flipswitch33% (1/3)33% (1/3)7% (47/657)1% (5/550)effects.glide67% (2/3)67%
KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.15 - Build # 345 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.15/345/ Project: kf5-qt5 SUSEQt5.15 Date of build: Fri, 25 Sep 2020 14:56:00 + Build duration: 21 min and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/LibColorCorrect-5.20.80.xmlacc/LibKWorkspace-5.20.80.xmlacc/LibNotificationManager-5.20.80.xmlacc/LibTaskManager-5.20.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.20.80/log.txtlogs/LibKWorkspace/5.20.80/log.txtlogs/LibNotificationManager/5.20.80/log.txtlogs/LibTaskManager/5.20.80/log.txt JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.applets.systemtray Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kcms.kfontinst.kio.autotests.test_kio_fontsName: projectroot.kcms.lookandfeel Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kcms.lookandfeel.autotests.lookandfeel_kcmTestName: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report19% (29/150)14% (88/618)14% (88/618)8% (4334/56566)5% (1967/37672)Coverage Breakdown by Package Name FilesClassesLinesConditionalsapplets.appmenu.lib0% (0/1)0% (0/1)0% (0/133)0% (0/88)applets.appmenu.plugin0% (0/3)0% (0/3)0% (0/125)0% (0/86)applets.calendar0% (0/1)0% (0/1)0% (0/6)100% (0/0)applets.digital-clock.plugin0% (0/4)0% (0/4)0% (0/948)0% (0/92)applets.icon0% (0/1)0% (0/1)0% (0/289)0% (0/188)applets.kicker.plugin0% (0/44)0% (0/44)0% (0/3448)0% (0/2636)applets.notifications0% (0/4)0% (0/4)0% (0/232)0% (0/102)applets.panelspacer.plugin0% (0/1)0% (0/1)0% (0/53)0% (0/71)applets.systemmonitor.systemmonitor0% (0/1)0% (0/1)0% (0/25)0% (0/16)applets.systemtray75% (3/4)75% (3/4)18%
KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.15 - Build # 203 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.15/203/ Project: kf5-qt5 SUSEQt5.15 Date of build: Wed, 23 Sep 2020 18:05:43 + Build duration: 4 min 58 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report7% (4/57)12% (33/267)12% (33/267)13% (2470/18722)11% (1059/9505)Coverage Breakdown by Package Name FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0% (0/1)0% (0/1)0% (0/30)0% (0/10)applets.kimpanel.backend.ibus.emojier0% (0/1)0% (0/1)0% (0/180)0% (0/107)applets.kimpanel.backend.ibus.ibus150% (0/10)0% (0/10)0% (0/1098)0% (0/590)applets.kimpanel.backend.scim0% (0/1)0% (0/1)0% (0/663)0% (0/267)applets.kimpanel.plugin0% (0/5)0% (0/5)0% (0/312)0% (0/79)applets.pager.plugin0% (0/4)0% (0/4)0% (0/368)0% (0/234)applets.showdesktop.plugin0% (0/2)0% (0/2)0% (0/15)0% (0/4)applets.taskmanager.plugin0% (0/3)0% (0/3)0% (0/318)0% (0/212)applets.taskmanager.plugin.smartlaunchers0% (0/4)0% (0/4)0% (0/236)0% (0/202)applets.trash.plugin0% (0/5)0% (0/5)0% (0/122)0% (0/52)containments.desktop.plugins.desktop0% (0/2)0% (0/2)0% (0/48)0% (0/18)containments.desktop.plugins.folder30% (6/20)30% (6/20)39% (938/2381)28% (392/1421)containments.desktop.plugins.folder.autotests100% (4/4)100% (4/4)100% (557/557)60% (221/368)imports.activitymanager0% (0/3)0% (0/3)0% (0/438)0% (0/242)kaccess0% (0/3)0% (0/3)0% (0/579)0% (0/282)kcms.access0% (0/1)0% (0/1)0% (0/343)0% (0/80)kcms.activities0% (0/8)0%
