Re: plasma-systemmonitor in kdereview

2020-10-18 Thread Albert Astals Cid
El dijous, 1 d’octubre de 2020, a les 14:36:05 CEST, Arjen Hiemstra va escriure:
> On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote:
> > On 01.10.20 11:36, Arjen Hiemstra wrote:
> > > Hello,
> > > 
> > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It
> > > can be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> > > 
> > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It
> > > makes use of the ksystemstats daemon and the faces system for system
> > > monitor plasmoids that were both introduced in Plasma 5.19.
> > > 
> > > Our current plan is to do a "preview release" alongside Plasma 5.20, then
> > > have it be an official part of Plasma with 5.21.
> > 
> > Cool stuff.
> > 
> > L10n is currently a bit incomplete.
> > Notably
> > - the pages files lack any localization at all and I'm also not sure how
> > those could be best localized.
> 
> Yeah that is a good point. If we can somehow extract the strings from these 
> files I think we can make it work. But that may need some custom scripting.

I think that shows a bit of a bad design decision. You shouldn't have default 
user visible strings in data files if they are also user editable

If you do, you have several chained problems:
 * You need to extract those strings somehow 
 * You need to feed all the "title" strings coming from .page files through 
i18n() to get the translation before showing it to the user
 * Once you do that, what happens if i create a page and call it "Disk"? i do 
*not* want to get the translation for that, it's something i manually created i 
want to get exactly what i wrote
 * This means that now for each title string in your .page files you need to 
store whether this is a default string and thus should be passed through i18n 
or if it is a user-entered string and should not be passed through i18n

Random suggestion after spending 2 minutes thinking on it, for the default 
pages instead of having
  title=Disk
you have
  default_page_title=overview_page_disk

and then on the C++ side you have a big group of
  if (default_page_title == "overview_page_disk") return i18nc("Label on 
Overview Page", "Disk");

and leave title only for user created pages.

Cheers,
   Albert




Re: plasma-systemmonitor in kdereview

2020-10-18 Thread Albert Astals Cid
El dijous, 1 d’octubre de 2020, a les 11:36:12 CEST, Arjen Hiemstra va escriure:
> Hello,
> 
> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can 
> be found at https://invent.kde.org/plasma/plasma-systemmonitor .
> 
> plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes 
> use of the ksystemstats daemon and the faces system for system monitor 
> plasmoids that were both introduced in Plasma 5.19.
> 
> Our current plan is to do a "preview release" alongside Plasma 5.20, then 
> have 
> it be an official part of Plasma with 5.21.

How serious are these cmake warnings? http://paste.debian.net/1167754/

I'd personally would suggest to remove these default values from KillDialog.qml
property string killButtonText: "Exterminate"
property string killButtonIcon: "killbots"
property string questionText: "Ex-ter-mi-nate"
they are not used anywhere and just cause confusion.

I guess i'm running a too old version of some dependency?
  
"file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde.ksysguard.processtable/contents/ui/FullRepresentation.qml:127:18:
 Type ProcessTableView unavailable"
  
"file:///home/tsdgeos/devel/kde/install/share/ksysguard/sensorfaces/org.kde.ksysguard.processtable/contents/ui/ProcessTableView.qml:97:9:
 Cannot assign to non-existent property \"flatList\""
Would make sense to mark that in the cmakelists you think? or is it just 
supposed to be used with plasma master in sync?

Cheers,
  Albert

> 
> Cheers,
> Arjen
> 
> 
> 






[Powerdevil] [Bug 351822] [Thinkpad T440] [kubuntu] (False?) notification of the removal of power when the battery has finished charging or has reached the threshold

2020-10-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=351822

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||n...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #3 from Nate Graham  ---
In fact, this is likely to be a upower or kernel bug, not a powerdevil issue.
There is one such issue right now:
https://gitlab.freedesktop.org/upower/upower/-/issues/126

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 351822] [Thinkpad T440] [kubuntu] (False?) notification of the removal of power when the battery has finished charging or has reached the threshold

2020-10-18 Thread Frank Steinmetzger
https://bugs.kde.org/show_bug.cgi?id=351822

Frank Steinmetzger  changed:

   What|Removed |Added

 CC||war...@gmx.de

--- Comment #2 from Frank Steinmetzger  ---
I bought a Thinkpad in spring of 2016 and I’ve been using KDE and tlp on it the
whole time (first Gentoo, now Arch Linux). I’ve never witnessed the reported
behaviour. In fact, the power applet still shows “Charging” after the charge
threshold has been reached.

Do you still experience it?

-- 
You are receiving this mail because:
You are the assignee for the bug.