Re: Review Request 118487: fix type issue with qreal

call qMax() and remove all the casts. - Aleix Pol Gonzalez On June 3, 2014, 1:48 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118487: fix type issue with qreal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59081 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 3, 2014

Re: Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of KDE Frameworks 4.100.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118540/#review59252 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 4, 2014, 8

Re: Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of KDE Frameworks 4.100.0

> On June 4, 2014, 11:16 p.m., Aleix Pol Gonzalez wrote: > > Ship It! > > Eric Hameleers wrote: > Errr? It's a good patch and it can go in, do you have commit rights or do you want me to push it for you? - Aleix

Review Request 118548: Port libtaskmanager away from QDesktopWidget

libtaskmanager/groupmanager.cpp 83b39ef Diff: https://git.reviewboard.kde.org/r/118548/diff/ Testing --- I have played with it and seems to work. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/

Re: Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of KDE Frameworks 4.100.0

ed in master, it's just the last beta that doesn't compile against the new KF5 version. The beta that will be released next week should work properly on the last KF5 beta. - Aleix Pol Gonzalez On June 4, 2014, 8:13 p.m., Eric

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

a6 libtaskmanager/launcheritem.cpp 649caca libtaskmanager/groupmanager.h aa71bac libtaskmanager/groupmanager.cpp 83b39ef Diff: https://git.reviewboard.kde.org/r/118548/diff/ Testing --- I have played with it and seems to work. Thanks,

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

ask.cpp 50ea1a6 libtaskmanager/launcheritem.cpp 649caca libtaskmanager/groupmanager.h aa71bac libtaskmanager/groupmanager.cpp 83b39ef Diff: https://git.reviewboard.kde.org/r/118548/diff/ Testing --- I have played with it and seems to work. Thanks, Ale

Re: Review Request 118573: Some tweaks in the logout screen

as well, but I can do that tomorrow. - Aleix Pol Gonzalez On June 5, 2014, 7:02 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 118573: Some tweaks in the logout screen

I see graesslin has concerns about it skipping the WM. Let's get this sorted. - Aleix Pol Gonzalez On June 6, 2014, 10:07 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On June 10, 2014, 10:26 a.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 152 > > > > > > QLatin1String > > > > (or rather QStringLiteral) > > Martin Klapetek wrote: > For string compa

Re: Review Request 118659: Improve finding of all X11 dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118659/#review59764 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 11, 2014

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? I agree it's the best way, the only problem being th

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzale

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review59795 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 4, 2014, 6

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 1:51 p.m., Aleix Pol Gonzalez wrote: > > Ship It! > > Vishesh Handa wrote: > Uhh. Currently the patch renames it to KFileMetaData5 instead of > KF5::FileMetaData. We want the one with the KF5, not this on. H

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzale

Re: Review Request 118733: Change installation path of sddm theme

733/#comment41787> Actually, shouldn't we have a find_package sddm and install it wherever it's installed? - Aleix Pol Gonzalez On June 13, 2014, 4:09 p.m., Bernd Steinhauser wrote: > > --- > This is an automatic

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

tps://git.reviewboard.kde.org/r/118796/#comment42008> Let's make this a QSet, it will be faster. - Aleix Pol Gonzalez On June 17, 2014, 2:36 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-m

Re: Review Request 118797: Port webshortcuts runner

tps://git.reviewboard.kde.org/r/118797/#comment42014> Plasma is probably not needed anymore, KRunner is a separate framework Other than that, it looks good to me. I'll leave Vishesh the honor of giving you the ship it. - Aleix Pol Gonzalez On June 17, 2014, 2:53 p.m., Rohan

Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

Diff: https://git.reviewboard.kde.org/r/118799/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

ps://git.reviewboard.kde.org/r/118799/#review60284 --- On June 17, 2014, 4:02 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

l PRE-CREATION src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f Diff: https://git.reviewboard.kde.org/r/118799/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kd

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > <https://git.reviewboard.kde.org/r/118733/diff/1/?file=280911#file280911line118> > > > > Actually, shouldn't we have a find_package sddm and install it wh

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799/#review60422 ------- On June 17, 2014, 10:47 p.m., Aleix Pol Gonzalez wrote: > >

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60512 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 19, 2014

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

> On June 19, 2014, 4:26 p.m., David Edmundson wrote: > > This patch doesn't include Plasma's SectionScroller, so it would be a > > regression. > > However I'm not entirely sure what SectionScroller actually does, so > > possibly not an important one. Shouldn't we either commit to the review r

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

ne in the config file, rather than hardcoded? - Aleix Pol Gonzalez On June 20, 2014, 12:21 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

> On June 20, 2014, 2:56 p.m., Marco Martin wrote: > > this could maybe fix > > https://bugs.kde.org/show_bug.cgi?id=336070 > > > > but i'm a bit on the fence. > > To me kida seems that to be really "correct", one would allow either > > manually resizing popups xor allowing applets to resize t

Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- Booted again, tests still pass, no warnings. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125812: Fix icon-based status notifier icons

Diffs - applets/systemtray/package/contents/ui/StatusNotifierItem.qml d2cc2f6 Diff: https://git.reviewboard.kde.org/r/125812/diff/ Testing --- I don't get empty spaces anymore. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-dev

Re: Review Request 125812: Fix icon-based status notifier icons

https://git.reviewboard.kde.org/r/125812/diff/ Testing --- I don't get empty spaces anymore. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

works like the rest of the properties. Diffs - src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml f8fddb7 Diff: https://git.reviewboard.kde.org/r/125809/diff/ Testing --- Booted again, tests still pass, no warnings. Thanks, Aleix Pol Gonzalez

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

iff: https://git.reviewboard.kde.org/r/125451/diff/ Testing --- Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D) Thanks, Aleix Pol Gonzalez ___ Plasma-

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review87448 --- On Oct. 26, 2015, 6:39 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generate

Re: Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/#review87734 --- +1 - Aleix Pol Gonzalez On Oct. 30, 2015, 6:07 a.m

Re: Review Request 125927: Unbox QJSValue in config property map

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125927/#review87896 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Nov

Re: Review Request 125975: X11 build system cleanup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125975/#review88092 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 6, 2015

Re: Review Request 125889: Take QApplication::wheelScrollLines into account from ScrollView

:) - Aleix Pol Gonzalez On Oct. 31, 2015, 12:28 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126042: avoid QMenu::exec in plasmoid context menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126042/#review88292 --- Ship it! LGTM, thanks! - Aleix Pol Gonzalez On Nov. 12

Re: Review Request 126063: [DragArea] Support specifying delegateImage as QString

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126063/#review88367 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 14, 2015

Re: Review Request 126064: [DragArea] Add dragActive property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/#review88368 --- How come we never needed this? (nor Qt did) - Aleix Pol

Re: Review Request 125990: [Widget Explorer] Fix applet uninstall

. - Aleix Pol Gonzalez On Nov. 15, 2015, 4:06 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126098: Install session file for plasma on wayland

whistles. :) - Aleix Pol Gonzalez On Nov. 17, 2015, 4:55 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126115: Unset environment variables before starting kwin_wayland

> On Nov. 19, 2015, 1:26 p.m., Sebastian Kügler wrote: > > Possibly naive question: How would I use it with my custom-build setup, > > where I need vars like QT_PLUGIN_PATH, etc. set to be able to start the > > binaries at all? > > Martin Gräßlin wrote: > I don't have a solution for it yet

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

tps://git.reviewboard.kde.org/r/126113/#comment60769> It could be useful to use qGuiApp here, so that software that doesn't use QApplication can use it as well. - Aleix Pol Gonzalez On Nov. 20, 2015, 2:27 p.m., Marco Martin wrote: > > ---

Re: Review Request 126148: [plasma-framework] qstring optimizations

se of QIcon::fromTheme. - Aleix Pol Gonzalez On Nov. 23, 2015, 9:36 p.m., Nick Shaforostoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

<https://git.reviewboard.kde.org//r/126151/#fcomment493> Why is this not a grid? O.= - Aleix Pol Gonzalez On Nov. 23, 2015, 10:50 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88802 --- Ship it! Looks good! - Aleix Pol Gonzalez On Nov. 25

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

> On Nov. 25, 2015, 3:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open s

Re: Review Request 126185: Make the KAppTemplate CMake module global

https://techbase.kde.org/Policies/CMake_Coding_Style - Aleix Pol Gonzalez On Nov. 27, 2015, 3:26 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126216: Do not produce negative struts on switching screens

return invalid (at least if ::geometry also isn't invalid). I'll add some debug locally and try to reproduce the issue. Thanks for looking into this! - Aleix Pol Gonzalez On Dec. 1, 2015, 7:45 p.m., Jan Kundrát wrote: > >

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment60983> You might want to add documentation. You can get inspired with `kde-modules/KDEFrameworkCompilerSettings.cmake` or `modules/ECMInstallIcons.cmake`. Note it's also lacking the copyright header. - Aleix Pol Gonzalez On Dec. 3, 201

Re: Review Request 126237: make comment role searchable in timezone selection

) <https://git.reviewboard.kde.org/r/126237/#comment60984> Also maybe cache the QModelIndex? - Aleix Pol Gonzalez On Dec. 4, 2015, 2:12 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126283: Use KDE_INSTALL_DATADIR to install update script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126283/#review89266 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 8, 2015, 6

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment61055> Naming them .zip on windows, won't make it a zip file, if you use tar j. I suggest just using .tar.bz2 everywhere. - Aleix Pol Gonzalez On Dec. 9, 2015, 12:27 p.m., Marco M

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > <https://git.reviewboard.kde.org/r/126185/diff/3/?file=421456#file421456line59> > > > > Naming them .zip on windows, won't make it a zip file,

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

> Plasma (wayland) (wayland) > > Rex Dieter wrote: > If need be, yes. > > Aleix Pol Gonzalez wrote: > AFAIR, SDDM is the only one officially supported by Plasma. It's not > really acceptable that it has visual regressions. > > Martin Klapetek wr

Review Request 126348: Make it possible to provide the metadata in json

/ Testing --- Tests still pass (except for https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez

Re: Review Request 126348: Make it possible to provide the metadata in json

> Tests still pass (except for > https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, > that is not passing in master). > Adds a test plugin with a json file in it. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126348: Make it possible to provide the metadata in json

,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126411: KF5::Plasma: Fix potential use-after-free in FrameSVG

! :) - Aleix Pol Gonzalez On Dec. 18, 2015, 3:21 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126417: don't rely on char* to QString implicit conversion

> On Dec. 18, 2015, 3:35 p.m., Kai Uwe Broulik wrote: > > i'm wondering whether those are still needed Well, it's still being called. +1 on the patch, it can be further fixed later. - Aleix --- This is an automatically generated e-mail

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89823 --- bump? - Aleix Pol Gonzalez On Dec. 15, 2015, 4:24 p.m

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

meone wanted to modify it, what should he base on?) - Aleix Pol Gonzalez On Dec. 11, 2015, 8:04 p.m., Ken Vermette wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/#review89920 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 22, 2015

Re: Review Request 126472: Don't always load the timetracker

initially because it was asked not to. IIRC. Anyway, +1. - Aleix Pol Gonzalez On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > I'm ok with this, although it wasn't guarded initially because it was asked > > not to. IIRC. > > > > Anyway, +1. Some small documentation about the environm

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

tps://git.reviewboard.kde.org/r/126466/#comment61645> Are you sure it is a good idea to load the pixmap as we're rendering? This will have quite some disk IO (icon look-up, read and rendering if an svg). - Aleix Pol Gonzalez On Dec. 22, 2015, 5:32 p.m., Eike

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89942 --- +1 - Aleix Pol Gonzalez On Dec. 22, 2015, 5:58 p.m., Eike

Re: Review Request 126544: [Kickoff] Hide history tab if empty

at UI structure change every now and then. - Aleix Pol Gonzalez On Dec. 28, 2015, 3:01 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126548: Kill PowerDevil runner

> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? I often suspend from KRunner. - Alei

Re: Review Request 126548: Kill PowerDevil runner

> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? > > A

Re: Review Request 126573: Don't duplicate checking content length is within user set bounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/#review90336 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 30, 2015

Re: Review Request 126575: Add missing emit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126575/#review90337 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 30, 2015

Re: Review Request 126576: Don't emit signals in another object from panel.

g/r/126576/#comment61812> Unrelated? Why? Otherwise we have weird screen jumps... shell/panelview.cpp (line 166) <https://git.reviewboard.kde.org/r/126576/#comment61811> remove? The rest LGTM. Thanks. - Aleix Pol Gonzalez On Dec. 30, 2015, 1 p.m., David Edm

Re: Review Request 126594: [SNI DataEngine] ProtocolVersion is an int

Pol Gonzalez On Jan. 1, 2016, 11:05 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126348: Make it possible to provide the metadata in json

=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126629: update the sddm kcm first step

o take all the horizontal space? - Aleix Pol Gonzalez On Jan. 5, 2016, 3:34 a.m., Andreas ka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90655 --- +1 makes sense to me. - Aleix Pol Gonzalez On Jan. 5, 2016

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90785 --- Looks good. +1 - Aleix Pol Gonzalez On Jan. 8, 2016, 2:34

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 8, 2016, 2:34 a.m.) > > > Review request for KDE Frameworks, Plasma and A

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

refer > > Q_FOREACH as replacement, the Q_ macros seem safer in the long run. > > Aleix Pol Gonzalez wrote: > It also detaches. > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ > > Sebastian Kügler wrote: > but would

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

src/plasma/svg.cpp (line 1018) <https://git.reviewboard.kde.org/r/126720/#comment62134> Looks like `emit customColorSchemeChanged(); emit repaintNeeded();` could be called within `d->updateCustomStyleCrc();`. Sorry if I missed something, but doesn't this patch makes themes cr

Review Request 126740: Add a script for optimizing svgs

40/diff/ Testing --- ``` kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 32M icons 32M icons-dark/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark

Re: Review Request 126740: Add a script for optimizing svgs

an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91055 ----------- On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote: > > --- > T

Re: Review Request 126740: Add a script for optimizing svgs

we should provide users whatever is easier to execute when we release. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91064 ---------

Re: Review Request 126740: Add a script for optimizing svgs

diff/ > > > Testing > --- > > ``` > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ > 32M icons > 32M icons-dark/ > > #run the script > > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-da

Re: Review Request 126740: Add a script for optimizing svgs

obably the compression to svgz to be done at > > build time and have all simple svgs in the repository > > Aleix Pol Gonzalez wrote: > What do you mean with "because git"? Because we might have the exact same > problem with svgo then. > > Sebastian Kügler w

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ) &

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ) &

Re: Review Request 126740: Add a script for optimizing svgs

obably the compression to svgz to be done at > > build time and have all simple svgs in the repository > > Aleix Pol Gonzalez wrote: > What do you mean with "because git"? Because we might have the exact same > problem with svgo then. > > Sebastian Kügler w

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ) &

Re: Review Request 126740: Add a script for optimizing svgs

s-dark/ 32M icons 32M icons-dark/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@k

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

tps://git.reviewboard.kde.org/r/126792/#comment62375> QUrl url(sourceString); - Aleix Pol Gonzalez On Jan. 18, 2016, 11:48 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126807: Ensure connection to exist before using

ether it's a proper fix though. - Aleix Pol Gonzalez On Jan. 19, 2016, 10:24 a.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126740: Add a script for optimizing svgs

k/ 32M icons 32M icons-dark/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org ht

Re: Review Request 126740: Add a script for optimizing svgs

el@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126848: Remove unused dependency in kgamma

to get them in a RR. - Aleix Pol Gonzalez On Jan. 22, 2016, 7:08 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

<    1   2   3   4   5   6   7   8   9   10   >