D27109: Fix duplicate results for sessions, simplify and optimize

alex added a comment. No problem, thanks for reviewing :-) REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27109 To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann Cc: cullmann,

D27166: Refactor converter runner

alex added a comment. Yes, I had a look, but I thought there may be a way to solve this using the KDE conversion API. The new changes now support 12 different currency symbols instead of just 3. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To:

D27166: Refactor converter runner

alex updated this revision to Diff 76324. alex added a comment. Add support for other currency symbols, use named groups for regex Now the plugin can evaluate queries like "4$>￥. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27096: Refactoring, improve validation in kcm, optimize

alex added a comment. First of all thanks for the idea, but is the QString API needed ? These strings are just used for reading the config and if you have a look at the implementation of the readEntry method: QStringList KConfigGroup::readEntry(const QString , const QStringList )

D26799: Apply KDE coding style, minor optimizations

alex updated this revision to Diff 73987. alex added a comment. Adjust formatting of lambdas REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26799?vs=73980=73987 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26799 AFFECTED FILES

D26799: Apply KDE coding style, minor optimizations

alex updated this revision to Diff 73988. alex added a comment. Add parentheses for parameter list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26799?vs=73987=73988 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26799 AFFECTED

D26799: Apply KDE coding style, minor optimizations

alex marked an inline comment as done. alex added inline comments. INLINE COMMENTS > meven wrote in filteredfoldermodel.cpp:38 > space ? I am not sure. I am not sure too, because in the plasma-workspace project and even some qt files it is sometimes formatted like above but sometimes it is

D27166: Refactor converter runner

alex updated this revision to Diff 76487. alex added a comment. Support combination of currency symbols and letters Now queries like `4us$>ca$` are supported. Every currency from the QLocale API which has a currency symbol and support in the unit conversion backend can be used in this

D27096: Refactoring, improve validation in kcm, optimize

alex updated this revision to Diff 76350. alex added a comment. - Implement suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27096?vs=75358=76350 BRANCH charrunner_improvements (branched from master) REVISION DETAIL

D27166: Refactor converter runner

alex updated this revision to Diff 76347. alex added a comment. Use character types for currency symbols in regex REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=76324=76347 BRANCH converter_runner_refactoring (branched from master)

D27166: Refactor converter runner

alex added a comment. In D27166#617379 , @sitter wrote: > Yeah, I don't think I understand. I am sure a unit test would make things clearer ;) ;) Yes, I will add one :-). And in the last commit I just used a regex feature which matches

D26912: Use Qt5 signal syntax, format files, optimizations

alex added a comment. Hello, I already wondered how this will be handled. Should I abandon this revision now and maybe create a new one with the relevant changes once your request has been merged ? And is there any way I could have known that this kcm is going to be refactored ?

D27166: Refactor converter runner

alex updated this revision to Diff 75064. alex added a comment. Use Regex for query parsing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=75039=75064 BRANCH converter_runner_refactoring (branched from master) REVISION DETAIL

D27166: Refactor converter runner

alex added a reviewer: sitter. alex marked an inline comment as done. alex added a comment. The regex has been implemented and the code is now ~100 lines shorter but provides the same functionality and the few remaining utility functions have been moved to the runner class. This should

D27052: Solid-device-automounter/kcm: Convert some foreach

alex added a comment. > if it is a function you don't need to do anything if the function is const (keys()), if not the best practice is to introduce an intermediate const variable That makes everything clear, thank you very much ! REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27063: Fix disabeling of autolock timeout

alex created this revision. alex added reviewers: mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY When the "Lock Screen:" checkbox gets disabled the timeout spin box gets disabled too. But the spin

D27052: Solid-device-automounter/kcm: Convert some foreach

alex added a comment. Hello, I have a question regarding your changed. you sometimes declare the variables you want to loop over before the loop, but sometimes in the loop. For instance in DeviceModel.cpp line 135 it is declared as a const before the loop and in line 139 it is

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74848. alex added a comment. Undo changes that were supposed to be in new diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74847=74848 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74847. alex added a comment. Refactoring, improve validation in kcm, optimize REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74830=74847 BRANCH charrunner_fix REVISION DETAIL

D27096: Refactoring, improve validation in kcm, optimize

alex created this revision. alex added reviewers: davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The config keys are now in a separate file, instead of having them at two places.

D27063: Fix disabeling of autolock timeout

alex added a comment. Thats a good point, the issue is that the validation slot gets only triggered if the value gets changed. If the automatic locking is disabled the value does not change and no signal gets triggered. Setting the spin box disabled by default is then the easiest

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex created this revision. alex added reviewers: kossebau, vhanda. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The two foreach occurences are refactored and the signals in the runner/kcm now use the C++ 11

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74795. alex added a comment. Simplify statement REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74793=74795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27063: Fix disabeling of autolock timeout

alex updated this revision to Diff 74787. alex added a comment. Set spinbox disabled by default REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27063?vs=74769=74787 BRANCH fix_disabled_state REVISION DETAIL https://phabricator.kde.org/D27063

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74793. alex added a comment. Remove unused include REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74789=74793 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex created this revision. alex added reviewers: davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Now Konsole is actually startet when an option is selected. Additionally the match

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex updated this revision to Diff 74853. alex added a comment. Allow search for profiles without "konsole" prefix REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=74852=74853 BRANCH konsole_bugfix (branched from master) REVISION DETAIL

D27109: Fix duplicate results for sessions, simplify and optimize

alex created this revision. alex added reviewers: broulik, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The sessions are now only loaded when the plugin is initialized or the folder

D27109: Fix duplicate results for sessions, simplify and optimize

alex updated this revision to Diff 74875. alex added a comment. Minor formatting improvements REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27109?vs=74874=74875 BRANCH katesession_improvements (branched from master) REVISION DETAIL

D26904: Use Qt5 syntax for signal, rename files

alex created this revision. alex added reviewers: mlaurent, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The signal in the SonnetSpellCheckingModule constructor now uses the Qt5 syntax and the

D26912: Use Qt5 signal syntax, format files, optimizations

alex created this revision. alex added reviewers: mlaurent, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The files have been formatted according to the KDE/Qt conventions. The signals in the

D26912: Use Qt5 signal syntax, format files, optimizations

alex updated this revision to Diff 74355. alex added a comment. Implement requested changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26912?vs=74352=74355 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26912 AFFECTED FILES

D26912: Use Qt5 signal syntax, format files, optimizations

alex updated this revision to Diff 74528. alex added a comment. Remove unnecessary parentheses. I just forgot to remove these, sorry. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26912?vs=74355=74528 REVISION DETAIL

D27166: Refactor converter runner

alex created this revision. alex added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The logic from the converter runner has been refactored and moved to seperate files.

D27166: Refactor converter runner

alex added a comment. While I was refactoring this project I haven't changed the string parsing logic itself. What do you think about changing the parsing process using a regex, for example to the regex from https://regex101.com/r/EUDzQi/7. This can make the parsing process/adding

D27166: Refactor converter runner

alex added a comment. Thanks for the quick answer, I will adjust the code/copyright. The reason I moved the functions to new files is that the runner file was really big and after splitting it up it was working well and the code was more readable/maintainable. But I wanted to wait

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74830. alex added a comment. Simplify and optimize REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74795=74830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex marked an inline comment as done. alex added a comment. Hello, thanks for the response. I addition to your requested change I have made some smaller improvements. But I have a question about the concept of this runner: Why is the data for every match session newly created ?

D26912: Use Qt5 signal syntax, format files, optimizations

alex added a comment. Yes, I have used an automatic formatter. And in general about formatting: When I commit a patch which contains code changes, should I format the files (even the code that I don't directly edit) or would it be easier for the reviewers if I commit this in a separate

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added reviewers: ngraham, broulik. alex added a comment. > Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years. Thanks anyway. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex,

D27495: Remove unnecessary code and function calls

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The ShellConfig class has been deleted. This config class was in KDE4 for the

D27495: Remove unnecessary code and function calls

alex added a comment. Thanks for the feedback. The actionsForMatch method gets actually called very often, I debugged this by adding `qWarning() << match.text();` as a debug statement in the method. But I guess that I can keep the changes. REPOSITORY R120 Plasma Workspace

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 76023. alex added a comment. Remove QDebug include, add license REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76022=76023 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL

D27513: Kill Runner: Remove duplicate function calls and refactor

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Duplicate function calls to load the config in the runner/config have been

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 76085. alex added a comment. Pass file directly to add_library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76023=76085 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL

D27166: Refactor converter runner

alex updated this revision to Diff 75359. alex added a comment. - Start implementing requested changes - Remove unnecessary class declaration REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=75064=75359 BRANCH converter_runner_refactoring

D27166: Refactor converter runner

alex marked 11 inline comments as done. alex added a comment. Hello, I have found no way to get the currency symbols, other that hard coded. If you have a look at https://phabricator.kde.org/source/kunitconversion/browse/master/src/currency.cpp$67 you can see that the symbols are

D27096: Refactoring, improve validation in kcm, optimize

alex updated this revision to Diff 75358. alex added a comment. - Implement requested changes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27096?vs=74849=75358 BRANCH charrunner_improvements (branched from master) REVISION DETAIL

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex updated this revision to Diff 75724. alex added a comment. Remove unnecessary include, simplify REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=74853=75724 BRANCH konsole_bugfix (branched from master) REVISION DETAIL

D27365: fix condition in KonsoleProfiles::run

alex added a comment. Hello, I have already created a patch for this (and some other improvements) which is currently waiting to be reviewed: https://phabricator.kde.org/D27098 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27365 To: McPain, heikobecker

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex created this revision. alex added reviewers: ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The foreach has been refactored and the loadSyntaxes method gets now called

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex updated this revision to Diff 76144. alex added a comment. Adjust comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=76142=76144 BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 76149. alex marked an inline comment as done. alex added a comment. Revert moving of config keys from commit "Remove duplicate function calls, move config keys to new file" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27576: Kill Runner: Move config keys to new file

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The config keys/sorting enum have been moved to a new file, before

D27495: Remove unnecessary code and function calls

alex updated this revision to Diff 76009. alex added a comment. Remove unnecessary Q_UNUSED macro REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27495?vs=75963=76009 BRANCH shellrunner_cleanup REVISION DETAIL

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex updated this revision to Diff 75930. alex added a comment. Rebase patch as requested REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=75724=75930 BRANCH konsole_bugfix (branched from master) REVISION DETAIL

D26738: Fix typo, launch plugin with argument, change signals

alex created this revision. alex added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The typo in the HACKING file has been fixed, the kcms/runners plugin is now able to launch a specific

D26747: Fix typo

alex created this revision. alex added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The word editing had one "t" to much TEST PLAN / REPOSITORY R119 Plasma Desktop BRANCH master

D26738: Fix typo, launch plugin with argument, change signals

alex updated this revision to Diff 73814. alex added a comment. As requested the update of the HACKING file will be committed separately. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26738?vs=73794=73814 REVISION DETAIL

D26799: Apply KDE coding style, minor optimizations

alex created this revision. alex added reviewers: ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The affected files have been reformatted following the KDE coding style (this makes up most of the

D28684: Kate Runner: Implement drag and drop for sessions

alex created this revision. alex added reviewers: Plasma, Kate, cullmann, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY You can now drag the sessions from the runner to the taskbar or the desktop. TEST

D28684: Kate Runner: Implement drag and drop for sessions

alex added a comment. The usecase is that you can pin the sessions to the taskbar. For instance if you have a quicklaunch widget in your panel for your favorite applications. And yeah I get the point about including this logic into Kate itself. REPOSITORY R114 Plasma Addons REVISION

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 80484. alex added a comment. Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=79560=80484 BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 AFFECTED FILES

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 80485. alex added a comment. Minor issue when rebasing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=80484=80485 BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 AFFECTED

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 79560. alex added a comment. Suspend matching if the profiles are empty REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=75930=79560 BRANCH arcpatch-D27098_1 REVISION DETAIL

D28663: Kate Runner: Cleanup and improvements

alex created this revision. alex added reviewers: Plasma, Kate, cullmann, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The overview feature has been removed, because this is already handled using the

D28192: WIP: Refactor dictionary runner

alex added inline comments. INLINE COMMENTS > sitter wrote in dictionaryrunner_config.cpp:29 > That's an implementation detail though, is it not? From the outside we > shouldn't make assumption about what the implementation does unless the > documentation says what we can assume. > Today the

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80578. alex added a comment. Implement requested changes Thanks, I will do that after the bugfix is done :-) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=79466=80578 BRANCH arcpatch-D28619

D27098: Konsole Runner: optimize and simplify

alex added a comment. @ngraham and others, may I ship this? REPOSITORY R114 Plasma Addons BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, broulik Cc: apol, plasma-devel, Orage,

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. Friendly ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28619 To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80580. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=80578=80580 REVISION DETAIL https://phabricator.kde.org/D28619 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage,

D28473: BookmarksRunner: Early return and formatting

alex added a comment. Should this(and the following patches) go to a stable branch, because they fix a bug that has been reported (418526)? REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79019. alex added a comment. Implement requested changes. PS: I had already tested the migration locally and added it to the test plan. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79017=79019

D28544: RecentDocuments Runner: Cleanup and formatting

alex added a comment. I didn't knew this patch existed and that it introduces coneptual changes. This is just a patch with smaller improvements/cleanup. Because of this I suggest waiting for your patch to be merged and than rebasing . REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27576: Kill Runner: Move config keys to new file

alex added a comment. Thanks!  And may I ship this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27576: Kill Runner: Move config keys to new file

alex updated this revision to Diff 79224. alex added a comment. Fix wrong username REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27576?vs=78137=79224 BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 AFFECTED

D28544: RecentDocuments Runner: Cleanup and formatting

alex updated this revision to Diff 79244. alex added a comment. Change import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28544?vs=79243=79244 BRANCH recentdocuments_cleanup (branched from master) REVISION DETAIL

D28544: RecentDocuments Runner: Cleanup and formatting

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY - Instead of early returning in the match method if the list of

D28192: WIP: Refactor dictionary runner

alex added inline comments. INLINE COMMENTS > sitter wrote in dictionaryrunner.cpp:90 > You could simply use the lastPartOfSpeech I would guess. From what I've seen > and what Kai tells me you really only need to set setData if you want to > implement actions (`::actionsForMatch`) and need to

D28458: Bugfix ConverterRunner

alex created this revision. alex added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Skip empty parts when splitting the units(D27166: Refactor converter runner

D28458: Bugfix ConverterRunner

alex added a comment. I don't know why but I cant land this patch(`arc land --preview` looks fine) and the previous commits worked: `fatal: remote error: service not enabled: /kdeplasma-addons` I would be thankful if you could commit this. REPOSITORY R114 Plasma Addons BRANCH

D28473: BookmarksRunner: Early return and formatting

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch handles the early return and the formatting. Additionally

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex updated this revision to Diff 78906. alex added a comment. Remove unused includes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28439?vs=78905=78906 BRANCH bookmarks_change_icon_handling_in_matches REVISION DETAIL

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex created this revision. alex added reviewers: apol, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Before: A pointer to the favicon gets written in the BookmarkMatch and using this

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. In D28439#638188 , @davidedmundson wrote: > QIcon isn't thread safe. Sorry, I wasn't aware about that and haven't found anything when I had a quick look at the docs before submitting this patch. But if I may

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. In D28439#638357 , @bruns wrote: > In D28439#638188 , @davidedmundson wrote: > > > QIcon isn't thread safe. > > > I think this is related to

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79083. alex added a comment. Implement warnings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79019=79083 BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79086. alex added a comment. Use categories for warnings, cleanup imports REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79083=79086 BRANCH bookmarksrunner_firefox_fix_prep (branched from master)

D27576: Kill Runner: Move config keys to new file

alex added a comment. Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch). What is the best way to solve this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576 REVISION DETAIL

D27513: Kill Runner: Remove duplicate function calls and refactor

alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27513 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28619: BookmarksRunner: Remove caching of profile database path

alex created this revision. alex added reviewers: Plasma, bruns, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch removes the caching

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. > I would argue for just removing the `grp.writeEntry("dbfile", m_dbFile)` line. This keeps the current behavior for the second group, and still solves the problem for the first group when there is no config yet. Only users of the second group with an existing config

D26111: Runner: make recentdocument use KActivityStats data

alex added inline comments. INLINE COMMENTS > recentdocuments.cpp:98 > +QString destUrlString = url.adjusted(QUrl::RemoveFilename).path(); > +if (destUrlString.startsWith(homePath)) { > +destUrlString = QLatin1String("~") + > destUrlString.mid(homePath.length());

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol, broulik, davidedmundson Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c55ffdca923a: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 81006. alex added a comment. Fix small issue from splitting up patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76149=81006 BRANCH arcpatch-D27513 REVISION DETAIL

D27576: Kill Runner: Move config keys to new file

alex added a comment. @meven and others, may I ship this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29319: KCM Plasmasearch: Do not intialize runners in config module

alex created this revision. alex added reviewers: Plasma, davidedmundson, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The runners are loaded from the plugin info list

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

alex created this revision. alex added reviewers: Plasma, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Because the actions are always the same the X-Plasma-Request-Actions-Once property can be set to

D28473: BookmarksRunner: Early return and formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e518d45a4d61: BookmarksRunner: Early return and formatting (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79086=81648

  1   2   >