System tray notification

Hi, I don't write a bug report, as this is not a bug in itself, just something that seems to be badly designed. Or maybe it is still unfinished, in that case ignore the mail. The idea of keeping the notifications visible for a longer time makes sense and I support it. The way how it works

Re: System tray notification

Marco Martin wrote: true, the problem is that sophisticate communication like the mail associated to that notification has been read is totally impossible in the spec (and probably quite out of scope too, since it would require too much burden to the applications themselves, situation that

Re: System tray notification

Andreas Marschke wrote: AFAIK the notifications do have a clickable cross in the upper corner and a dragable title bar so basically no worries right? Happy clicking on them. :) Obviously that doesn't work if you have notifications for mail folder or RSS feeds with fairly high traffic. You

Re: Notifications not automatically hidden anymore

Hi, I've been testing and evaluating the current behavior of the systray notifications, and I have to admit, that I still don't like it. Now that the notifications are cleared after 5 minutes when using the computer is better, but not enough, and I agree with this statement: Aleix Pol wrote:

Re: The future of Power Management - together with Activities

On Saturday, October 01, 2011 16:27:48 Dario Freddi wrote: Hello all, and sorry for cross-posting. [...] I can't comment on activities, never used them, nor feel the need to use them. So this sounds more like the power management applet would force me to create and use activites. What I can

Re: The future of Power Management - together with Activities

On Saturday, October 01, 2011 23:13:06 Dario Freddi wrote: Is it? Certainly disabling desktop effects and 3D acceleration has an impact. Sorry to disappoint you, but this action will be removed in 4.8. Martin has explicitely stated that for how compositing in KDE works now turning off

Re: The future of Power Management - together with Activities

On Sunday, October 02, 2011 14:45:58 Dario Freddi wrote: That was one example. Another example brought up is e.g switching of strigi or nepomuk indexing when switching to a power saving profile. These two are something that usually kick in when you are in idle mode, exactly when the

Re: The future of Power Management - together with Activities

On Sunday, October 02, 2011 17:04:50 Martin Gr��lin wrote: So please calmn down and lets focus on improving the user experience by not spending too much time on too long� threads. I'm far from being upset or anything. I just gave my opinion, which seems to match others as well. We were *asked*

Re: The future of Power Management - together with Activities

On Sunday, October 02, 2011 20:31:11 Dario Freddi wrote: I don't think so. Every other system does a similar thing: there is no use in saving battery when you're on AC, when you are on battery these components are turned off. I don't think this should be configurable at all, and to a certain

KRunner plugin documentation

Hi, I like a lot the KRunner plugins, but I find one issue with them: it is not documented how you should use them. I discovered some of the features, but probably not everything. And I see no place in the UI where the documentation could be plugged in. Every plugin has an Info button, but

Re: KRunner plugin documentation

Sebastian Kügler wrote: Hey Andras, On Wednesday, December 07, 2011 09:55:59 Andras Mantia wrote: I like a lot the KRunner plugins, but I find one issue with them: it is not documented how you should use them. I discovered some of the features, but probably not everything. And I see

Re: KRunner plugin documentation

Sebastian Kügler wrote: The text is not semi-transparant on my machine, maybe you're using a different theme? I have the same issue with Air and Oxygen. Here is a screenshot: http://i.imgur.com/SjgWN.png The background is the composer for this mail. :) Andras

Re: KRunner plugin documentation

Martin Klapetek wrote: On Wed, Dec 7, 2011 at 11:50, Andras Mantia aman...@kde.org wrote: Sebastian Kügler wrote: The text is not semi-transparant on my machine, maybe you're using a different theme? I have the same issue with Air and Oxygen. Here is a screenshot: http://i.imgur.com

Re: KRunner plugin documentation

Sebastian Kügler wrote: On Wednesday, December 07, 2011 12:08:41 Martin Klapetek wrote: On Wed, Dec 7, 2011 at 12:04, Andras Mantia aman...@kde.org wrote: Martin Klapetek wrote: On Wed, Dec 7, 2011 at 11:50, Andras Mantia aman...@kde.org wrote: Sebastian Kügler wrote: The text

[PATCH] Show the job progress in separate dialog

Hi, the attached patch introduces a config option to show the job progress dialogs as separate dialogs. The reason is: 1) people are used to the old ones 2) the new ones, integrated into the systray notification have some limitation compared to the old ones, like not being visible every time,

Re: Systray Notifications

Rob Scheepmaker wrote: Agreed, Ideally those should be hidden. Something I could do is only let notifications appear after a job has been running for a couple of seconds so all those very short jobs won't bother you, As far as I know this is exactly what happens with the old dialogs.

plasma plasma-desktop

Hi, I noticed that after I compiled trunk I have two panels, systray without icons and similar strange things. After a while I realized that I have both plasma and plasma-desktop running. It happens because I have a distro packaged KDE 4.1 (and now 4.2) in /usr and a self compiled one in

Review Request: Display correct week number in the calendar widget

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/76/ --- Review request for Plasma. Summary --- The calendar widget currently display

Re: Review Request: Display correct week number in the calendar widget

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/76/#review147 --- Any opinion about this? - Andras On 2009-02-14 06:30:08, Andras

Re: Review Request: Display correct week number in the calendar widget

scheduling with people over the phone a bit harder (your week 32 is my week 33??) ... but if you're concerned about that you'll use a standard calendar system rather than a regional one, no? so .. this should be fixed properly. Andras Mantia wrote: Yes, it would add some confusion. I

D8493: Make Folder View screen aware

amantia added a comment. @davidedmundson Any comments? If not, I will push this tomorrow. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni,

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22868. amantia added a comment. Guard screenmapper usage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22797=22868 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8850: Support drag and drop between shared folder view containments

amantia marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8598: FolderView: position files at drop event target position

amantia accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH wip/lim-2 REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8598: FolderView: position files at drop event target position

amantia requested changes to this revision. amantia added a comment. This revision now requires changes to proceed. Milian, please also update the commit description (the last paragraph needs to go away). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22795. amantia marked 2 inline comments as done. amantia added a comment. Handle Eike's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22444=22795 BRANCH master REVISION DETAIL

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > hein wrote in foldermodel.cpp:1688 > I know it's a very theoretical case, but you're not disconnecting from an old > non-null ScreenMapper here. > > You're also not calling invalidateFilter even though filterAcceptsRow uses > the mapper. It's

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22797. amantia added a comment. Guard m_screenMapper usage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22682=22797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8850: Support drag and drop between shared folder view containments

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1131 > unguarded same here REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8850: Support drag and drop between shared folder view containments

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1123 > unguarded It is guarded (line 1117) REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8598: FolderView: position files at drop event target position

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e94888701c32: FolderView: position files at drop event target position (authored by mwolff, committed by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8922: Avoid jumping of items toward right/botton when dropping

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c0f8856742a4: Avoid jumping of items toward right/botton when dropping (authored by amantia). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.

D8493: Make Folder View screen aware

This revision was automatically updated to reflect the committed changes. Closed by commit R119:88718b162ada: Make Folder View screen aware (authored by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22795=23063 REVISION DETAIL

D8493: Make Folder View screen aware

amantia removed a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, apol, mwolff Cc: anthonyfieroni,

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 23065. amantia added a comment. Rebased REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22868=23065 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8915: Update the proxy to source and source to proxy mapping correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:98d56d9135b1: Update the proxy to source and source to proxy mapping correctly (authored by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8850: Support drag and drop between shared folder view containments

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc9c3d32a381: Support drag and drop between shared folder view containments (authored by mwolff, committed by amantia). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D9307: Show newly created items on the right desktop

amantia added reviewers: Plasma, hein, mwolff, broulik. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9300: Store screenMapping info only once

amantia updated this revision to Diff 23846. amantia added a comment. Add const REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9300?vs=23821=23846 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 AFFECTED FILES

D9300: Store screenMapping info only once

amantia added a comment. I think it is better to store once, than 2-3 times (per desktop) as the data is the same. I'm not sure if the corona level is the best, although I don't see big problems with it. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D9300: Store screenMapping info only once

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart Cc: mart, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9300: Store screenMapping info only once

amantia added reviewers: Plasma, mwolff, hein, broulik. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9300: Store screenMapping info only once

amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Until now every FolderView applet stored exactly the same screenMapping info in the config file. Store it only once using the config

D9311: Create new items at the position where the context menu was invoked

amantia added reviewers: Plasma, broulik, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9307: Show newly created items on the right desktop

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9307 To: amantia, #plasma, hein, mwolff, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9311: Create new items at the position where the context menu was invoked

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9311 To: amantia, #plasma, broulik, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

amantia added reviewers: Plasma, mwolff, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9300: Store screenMapping info only once

amantia added a comment. I will merge this latest on Monday if there is no further objection REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart Cc: mart, mlaurent, plasma-devel,

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 23954. amantia added a comment. Fixed issues pointed out by Laurent. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=23898=23954 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9325 AFFECTED FILES

D9323: Use ScreenMapper everywhere as a singleton

amantia updated this revision to Diff 23897. amantia added a comment. Connect to screenammper only if used as a containment CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9323?vs=23894=23897 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9323 AFFECTED FILES

D9325: Use QUrl in the ScreenMapper API

amantia added reviewers: Plasma, mwolff, dakon, broulik. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9323: Use ScreenMapper everywhere as a singleton

amantia added inline comments. INLINE COMMENTS > broulik wrote in foldermodel.cpp:124 > Why have this member then? For convenience > broulik wrote in foldermodel.cpp:194 > I think we shouldn't connect to the signals if we're not a containment? Yes, that makes sense, I will fix it REPOSITORY

D9300: Store screenMapping info only once

amantia added a comment. In https://phabricator.kde.org/D9300#179031, @broulik wrote: > Screen mapper is a singleton type, so it won't cause problems when one screen adds a mapping, it will propagate to the other containments automagically? Before we had `plasmoid.configuration` which

D9313: Don't move back items to second screen if they were manually moved

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9313 To: amantia, #plasma, hein, mwolff Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9313: Don't move back items to second screen if they were manually moved

amantia added reviewers: Plasma, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8598: FolderView: position files at drop event target position

amantia accepted this revision. amantia added a comment. This revision is now accepted and ready to land. Looks good for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8493: Make Folder View screen aware

amantia added a comment. Ok, let's wait for Eike and for the DND patches to be ready. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham,

D8598: FolderView: position files at drop event target position

amantia requested changes to this revision. amantia added a comment. This revision now requires changes to proceed. Sorry, found two small issues :) INLINE COMMENTS > foldermodel.cpp:1076 > +// remember drop target position for target URL and forget about the > source URL > +

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in screenmapper.cpp:85 > this should imo be a for loop to make it clear that it is iterating over all > items (more ideomatic). Also, couldn't you use range-based for here even? range based loop: I need access to both key and value

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22444. amantia added a comment. Some code reogranization per Milian's request REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22438=22444 BRANCH master REVISION DETAIL

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22313. amantia marked 2 inline comments as done. amantia added a comment. Implement changes requested by anthonyfieroni REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22312=22313 BRANCH master

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22342. amantia added a comment. - WIP: Multiscreen drag and drop support in folder view REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22313=22342 BRANCH arcpatch-D8598_1 REVISION DETAIL

D8598: FolderView: position files at drop event target position

amantia requested changes to this revision. amantia added a comment. This revision now requires changes to proceed. Unfortunately the current approach fails when the folderview points to desktop:/ . In that case the targetUrl in the copyJobStarted is different ("desktop:/foo") from the url

D8566: Add API to retrieve the screen id for a screen name

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eab03787350a: Add signals indicating if a screen was added or removed (authored by amantia). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D8567: Emit signals when a screen is added or removed

amantia closed this revision. amantia added a comment. https://commits.kde.org/plasma-framework/eab03787350a6c8cf56b1bf95f89b360c6633de3 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8567 To: amantia, #plasma, ervin, dvratil, mlaurent, hein,

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22344. amantia added a comment. Restoring previous version overwritten by mistake. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22342=22344 BRANCH master REVISION DETAIL

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22312. amantia added a comment. Handle the case when the folder view's path changes on one of the desktops REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21838=22312 BRANCH master REVISION DETAIL

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22630. amantia added a comment. Fix problem of having ghost items, fix problem of losing items when an item is moved to a screen and back. Add unit test for the positioner when items are moved between screens. Problem: moving multiple items

D8850: WIP: support drag and drop between shared folder view containments

amantia commandeered this revision. amantia edited reviewers, added: mwolff; removed: amantia. amantia added a comment. Commandeered and trying to fix the mess now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff Cc: broulik,

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22631. amantia added a comment. Fix uploaded diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22630=22631 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22632. amantia added a comment. Clean unit test and code: move out the unique testing part (will be moved to a new patch) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22631=22632 BRANCH master REVISION DETAIL

D8850: WIP: support drag and drop between shared folder view containments

amantia added inline comments. INLINE COMMENTS > mwolff wrote in positionertest.cpp:219 > second? this is the first and only one in this test, no? There is one coming from init() (m_folderModel) > mwolff wrote in positionertest.cpp:229 > `QVERIFY` the wait, also below Changed, the rest is

D8915: Update the proxy to source and source to proxy mapping correctly

amantia updated this revision to Diff 22665. amantia added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Add uniqueness testing for the maps CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8915?vs=22659=22665

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22679. amantia added a comment. Drop the items to the right screen when dragging from outside of the folder view. I admit it is not the nicest code for finding the final URL (that will be returned by KDirModel), ideas are welcome to improve it.

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22677. amantia added a comment. - More stricter detection for moving between screens to fix issue when a file is moved/copied out from within a folder of the desktop. - Enable the code only when the folder view is used in a containment Bugs

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22682. amantia added a comment. - Improve path detection as suggested by Milian - fix d for multiple items. There is only one issue, but I think it is acceptable this way: when moving two or more items that are not near each other to a new screen,

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22657. amantia added a comment. Move out fix for proxy to source and remove the change from updateMap CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22632=22657 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850

D8850: Support drag and drop between shared folder view containments

amantia retitled this revision from "WIP: support drag and drop between shared folder view containments" to "Support drag and drop between shared folder view containments". amantia edited the summary of this revision. amantia added reviewers: Plasma, hein. REVISION DETAIL

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22438. amantia added a comment. Handle screen removal correctly: - adjust the first screen per path in a more efficient way - adjust the number of screens per path properly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22428. amantia marked 2 inline comments as done. amantia added a comment. Add a code comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22387=22428 BRANCH master REVISION DETAIL

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in screenmapper.cpp:108 > `m_itemsOnDisabledScreensMap` stores "names" from the `m_screenItemMap`, so I > think this line here is wrong and should also use the proposed > `screenUrlForPath` above, or `QUrl::fromUserInput`, no?

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22434. amantia added a comment. Remove unused var REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22428=22434 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED FILES

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in screenmapper.cpp:41 > this is a pretty arbitrary timer, can you add a comment on why 100ms is > better than going through the eventloop once via QMetaObject::invokeMethod > with the delayed flag set? Done. InvokeMethod would not

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22387. amantia marked 2 inline comments as done. amantia added a comment. Fix for some of Milian's comments (rest later, need to move to different computer) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8493: Make Folder View screen aware

amantia updated this revision to Diff 21838. amantia added a comment. remove unimplemented method REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21837=21838 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED

D8493: Make Folder View screen aware

amantia updated this revision to Diff 21837. amantia added a comment. - add unit tests for different scenarios of foldermodel and screenmapper usage on multiple screens - connect screenMappingChanged to invalidateFilter - as addMapping is called from withing filterAcceptRows, make it

D8598: FolderView: position files at drop event target position

amantia added a comment. I didn't tested the code yet, but in general looks good for me. INLINE COMMENTS > foldermodel.cpp:181 > +if (!m_dropTargetPositions.isEmpty()) { > +qDebug() << "clearing drop target positions after timeout:" << > m_dropTargetPositions; > +

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > anthonyfieroni wrote in foldermodel.cpp:163-164 > When QObject dies it's disconnected to all signal/slots. In this case if you > want to not notify FolderModel you can use > > m_screenMapper->disconnect(this); Yes, I know, indeed this might

D8493: Make Folder View screen aware

amantia added a comment. I have changed the code to not rely on screen removal/addition signals inside the FolderView plugin, but use the existing code from shellcorona. This also ensures that we get the signals for the right id, and works correctly as long as the screen layout detection in

D8493: Make Folder View screen aware

amantia added a reviewer: apol. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol Cc: davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8493: Make Folder View screen aware

amantia updated this revision to Diff 21685. amantia added a comment. Use the plasma signals with screen id instead of QGuiApplication signals with the QScreen objects. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21619=21685 BRANCH

D8567: Return the screen id for a screen name.

amantia updated this revision to Diff 21686. amantia added a comment. Emit the screenRemoved from within removeDesktop REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8567?vs=21683=21686 BRANCH master REVISION DETAIL

D8567: Return the screen id for a screen name.

amantia marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8567 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8589: Make the folder model screen aware

amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - store a map of url/screen ids in the configuration file - have a central mapping object shared by all folder views - if the model is

D8567: Return the screen id for a screen name.

amantia updated this revision to Diff 21683. amantia edited the summary of this revision. amantia added a comment. Emit the screenRemoved/screenAdded signals. This needs a small rename of an internal method. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8566: Add API to retrieve the screen id for a screen name

amantia updated this revision to Diff 21682. amantia added a comment. Add signals instead of a new virtual method (that is not BIC). This also makes us not rely on screen name, but only on plasma-internal screen id. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D8566: Add API to retrieve the screen id for a screen name

amantia added a comment. @broulik Very good point, luckily I reworked it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8566 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot,

D8589: Make the folder model screen aware

amantia abandoned this revision. amantia added a comment. Created by mistake, right one is https://phabricator.kde.org/D8493 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8589 To: amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1316 > adding some comment here would help people reading the code in the future. > I.e. something like "exclude items that are shown on a different screen" > > also, I personally think this code is not pretty at

D8567: Return the screen id for a screen name.

amantia updated this revision to Diff 21687. amantia added a comment. Remove unneeded changed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8567?vs=21686=21687 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8567 AFFECTED FILES

  1   2   3   >