D13013: Small fixes for execute_kwallet

anthonyfieroni added a comment. It's ok to me. REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D13013 To: aacid, fvogt Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY onDataChanged: some cases

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni added a comment. On previous version onStackingOrderChanged will not restore windows state, it just stops the effect. So onActiveTaskChanged to replace onDataChanged? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13529 To: anthonyfieroni,

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni updated this revision to Diff 36270. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13529?vs=36160=36270 REVISION DETAIL https://phabricator.kde.org/D13529 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml To:

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni updated this revision to Diff 36160. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13529?vs=36142=36160 REVISION DETAIL https://phabricator.kde.org/D13529 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml To:

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni added a comment. onVirtualDesktopChanged and onActivityChanged it looks good to deactivate effect with restoring windows state. Because you can miss or forgive that you activate it, we definitely NOT want to deactivate effect when you click desktop :) I think now it's looking

D13752: Kill solidautoeject

anthonyfieroni added a comment. I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is mounting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson,

D10342: From 100% plasma cpu usage to normal when using vivaldi

anthonyfieroni added a comment. In D10342#286360 , @jtamate wrote: > Or perhaps is it better to try to create that cache in KServiceTypeTrader? That will be the right place, reading from disk is always costly, it will be better to make

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

anthonyfieroni added inline comments. INLINE COMMENTS > deviceserviceaction.cpp:91 > +} else { > +connect(access, ::StorageAccess::accessibilityChanged, > +this, ::_k_accessibilityChanged); Why not use it in all cases? REPOSITORY R120 Plasma Workspace

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added a comment. I'm not sure it's Qt bug, it change behavior and now it doing in *right* way. So i'm patch to be merged +1. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D9506: milti-screen sleep fix

anthonyfieroni added reviewers: sebas, drosca. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9738: Support font/ttf and font/otf mimetypes in kfontinst

anthonyfieroni added inline comments. INLINE COMMENTS > Misc.cpp:293 > { > -return "application/x-font-type1"==mime || > "application/x-font-ttf"==mime || > +return "font/otf"==mime || "font/ttf"==mime || > + "application/x-font-type1"==mime || >

D9506: milti-screen sleep fix

anthonyfieroni added a comment. @McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc:

D9998: Actually quit threads nicely

anthonyfieroni added a comment. If it's not running event loop why run is called? REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D9998 To: fvogt, #plasma, ivan, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10118: Disable keyboard geometry preview code

anthonyfieroni added a comment. I believe that port away from boost will fix the problem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anthonyfieroni added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:94 > delete shader; > -delete target; > +shader = NULL; > + m_simpleTarget should be deleted too > blur.cpp:96-104 > +for (int i = 0; i <

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

anthonyfieroni added a comment. You should increase minimal required plasma-framework version to 5.44 but when you do this this patch goes to master i.e. 5.13. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: anthonyfieroni, plasma-devel,

D10297: Add new "Tools" button above System Monitor's process list

anthonyfieroni added inline comments. INLINE COMMENTS > ksysguardprocesslist.cpp:199 > KSysGuardProcessListPrivate(KSysGuardProcessList* q, const QString > ) > -: mModel(q, hostName), mFilterModel(q), mUi(new > Ui::ProcessWidget()), mProcessContextMenu(nullptr),

D10429: Disable the title bar separator by default

anthonyfieroni added a comment. -1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

anthonyfieroni added a reviewer: apol. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma, apol Cc: apol, asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:42 > property bool vertical: plasmoid.formFactor == PlasmaCore.Types.Vertical > -property int itemSize: units.roundToIconSize(Math.min(Math.min(width, > height),

D10610: Fix favicons in firefox bookmarks runner

anthonyfieroni added reviewers: Plasma, broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu, #plasma, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

anthonyfieroni added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.cpp:57-68 > > So Adaptive can a default even environment variable is not setted? > > yes, adaptive is the default > > > Furthermore you can make a static function to access value > > it's done anyways only

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. It looks good to me. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma, anthonyfieroni Cc:

D10750: wayland: Add support for zwp_linux_dmabuf

anthonyfieroni added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > abstract_egl_backend.cpp:117 > +for (auto *dmabuf : qAsConst(m_dmabufBuffers)) { > +dmabuf->destroyImage(); > +} Call delete dmabuf will have same effect.

D10512: try to preload certain applets in a smart way

anthonyfieroni added inline comments. INLINE COMMENTS > appletquickitem.cpp:57-68 > +if (s_preloadPolicy == Uninitialized) { > +if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) { > +const QString policy = >

D10835: [kicker] Never execute recent documents

anthonyfieroni added inline comments. INLINE COMMENTS > recentusagemodel.cpp:286 > if (!resource.startsWith(QLatin1String("applications:"))) { > -new KRun(docData(resource, Kicker::UrlRole).toUrl(), 0); > +QUrl resourceUrl = docData(resource,

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added a comment. Deletion is needed https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in widgetexplorer.cpp:448 > Such a slot not existing at all. Even more WidgetExplorer is closed upon DownloadDialog is shown, which makes such slot useless. But now it can be opened more than one DownloadDialogs and

D9338: [comic] Fix comic updater time interval

anthonyfieroni updated this revision to Diff 24295. anthonyfieroni marked 2 inline comments as done. anthonyfieroni edited the test plan for this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=23936=24295 REVISION DETAIL

D9338: [comic] Fix comic updater time interval

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in comicupdater.cpp:86 > I assume this line is the important change? > > +1 to this bit. Yes. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson,

D9479: [widgetexplorer] Fix trying to show deleted dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted dialog (authored by anthonyfieroni). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added a comment. Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel,

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added a comment. In https://phabricator.kde.org/D9473#182455, @fvogt wrote: > In https://phabricator.kde.org/D9473#182449, @anthonyfieroni wrote: > > > Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. > > >

D9479: [widgetexplorer] Fix trying to show deleted dialog

anthonyfieroni created this revision. anthonyfieroni added reviewers: fvogt, davidedmundson, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY WidgetExplorer is destroyed on close which deletes KNS dialog. TEST

D9338: [comic] Fix comic updater time interval

This revision was automatically updated to reflect the committed changes. Closed by commit R114:095196ca6438: [comic] Fix update interval (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=24295=24303 REVISION DETAIL

D9479: [widgetexplorer] Fix trying to show deleted dialog

anthonyfieroni updated this revision to Diff 24297. anthonyfieroni added a comment. Remove entire destructor. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9479?vs=24296=24297 REVISION DETAIL https://phabricator.kde.org/D9479 AFFECTED FILES

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in widgetexplorer.cpp:448 > what's the situation with this line? Such a slot not existing at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma,

D13529: [minimizeAll] Do not try to restore window state on model change

anthonyfieroni updated this revision to Diff 36300. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13529?vs=36270=36300 REVISION DETAIL https://phabricator.kde.org/D13529 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml To:

D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. Let's abandon it, i'll return to it, if still needed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 To: anthonyfieroni, #plasma, davidedmundson, sitter, dfaure Cc: hein,

D14546: [Service Runner] Look up relative entryPaths

anthonyfieroni added inline comments. INLINE COMMENTS > servicerunner.cpp:474 > + > +if (path.isEmpty()) { > +return nullptr; Does it better to check that file exists? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14546 To: broulik, #plasma,

D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks

anthonyfieroni added inline comments. INLINE COMMENTS > configgroup.cpp:67 > d->synchTimer->stop(); > d->configGroup->sync(); > } Here as well should be sync(), if it destroys object before timer is elapsed e.g. before 1.5 sec it will crash. REPOSITORY R120 Plasma

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

anthonyfieroni added a comment. +1 from me. REVISION DETAIL https://phabricator.kde.org/D14440 To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D14437: Fix QFileDialog not remembering the last visited directory.

anthonyfieroni added inline comments. INLINE COMMENTS > apol wrote in kdeplatformfiledialoghelper.cpp:118 > I'm not sure I understand the comment. Is it like a TODO? It works without comment, i think these connections are not needed. REPOSITORY R135 Integration for Qt applications in Plasma

D14822: Use QJSValue as method parameter type for the scripting interface

anthonyfieroni added inline comments. INLINE COMMENTS > applet.cpp:139 > > -d->configGroup.writeEntry(key, value); > +d->configGroup.writeEntry(key, value.toVariant()); > d->configDirty = true; So writeEntry gets QJSValue& now why you call again toVariant(), here

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > soliddeviceengine.cpp:67 > +KDiskFreeSpaceInfo info = KDiskFreeSpaceInfo::freeSpaceInfo(m_path); > +emit infoObtained(m_path, m_udi, info.isValid(), info.available(), > info.size()); > +} Don't you forget to emit finished? >

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > soliddeviceengine.cpp:564 > + > +m_timers[path] = timer; > + You can remove it, see below. > soliddeviceengine.cpp:574 > +connect(job, ::FileSystemFreeSpaceJob::result, > +[this, path, udi](KIO::Job *job,

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > soliddeviceengine.cpp:588 > +// start timer: after 15 seconds we will get an error > +timer->start(15000); > } job->start(); as well. REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik,

D14855: Add applet with screen layouts and presentation mode

anthonyfieroni added a comment. @broulik, i'm pretty sure that it has a review that enable accessing OSD by mouse, can you investigate and ship it. I'm not against this but accessing OSD by mouse is pretty good feature after all. REPOSITORY R104 KScreen REVISION DETAIL

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

anthonyfieroni added inline comments. INLINE COMMENTS > McPain wrote in soliddeviceengine.cpp:560 > Any ideas how to do it correctly? It has a default parameters just call event with 3 parameters not 5. REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham,

D14437: Fix QFileDialog not remembering the last visited directory.

anthonyfieroni added a comment. +1 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D14437 To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson Cc: apol, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15093: Add WireGuard capability.

anthonyfieroni added a comment. When you use background-color you combine with QPalette, at least, because you break all other themes. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc:

D15011: [Kickoff] Make the search field always look like a search field

anthonyfieroni added a comment. I'm -1 for this, it's not needed to click in just start typing witch is more intuitive. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15011 To: ngraham, #plasma, #vdg, davidedmundson Cc: anthonyfieroni, filipf, abetts,

D14050: Fwupd Backend For Review and Improvement

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:16 > + > +#find_package(GIO) > +find_package(Soup) Why you comment it when you use it, see below. > FwupdBackend.cpp:68 > +if (!m_fetching) > + m_reviews->initialize(); > +

D14060: Clean up string casts

anthonyfieroni added inline comments. INLINE COMMENTS > parser.cpp:145 > +const QByteArray type = > map[QStringLiteral("type")].toByteArray().toUpper(); > if (type.contains("LVDS") || type.contains("EDP") || > type.contains("IDP") || type.contains("7")) { >

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

anthonyfieroni added a comment. Thats what doubt me: https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/minimizeall/plugin/minimizeall.cpp;65fc80441388c5f3e70832c40e1d7afea6778e83$63-68 REPOSITORY R114 Plasma Addons REVISION DETAIL

D11233: Ordered system tray

anthonyfieroni added inline comments. INLINE COMMENTS > ConfigEntries.qml:464 > + (shownAutoItems[0].taskId != modelData.taskId)) > +text: "▲" > +width: 30 icon: "arrow-up" > ConfigEntries.qml:478 > +

D10835: [kicker] Never execute recent documents

anthonyfieroni added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma, hein Cc: ngraham, hein, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

anthonyfieroni added inline comments. INLINE COMMENTS > ConfigEntries.qml:110-119 > + /* for (var i = 0; i < statusNotifierModel_cfg.count; ++i) { > +var item = statusNotifierModel.get(i); > +itemInfo[item.Id] = { > "taskId": item.Id, >

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

anthonyfieroni added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:108 > m_buttons->addButton(m_fileWidget->cancelButton(), > QDialogButtonBox::RejectRole); > connect(m_buttons, SIGNAL(rejected()), m_fileWidget, SLOT(slotCancel())); >

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

anthonyfieroni added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:243 > +{ > +m_fileWidget->writeViewConfig(); > +QDialog::reject(); You can see at line 108 on reject is called slotCancel, so for convenience just call it m_fileWidget->slotCancel(); Then you

D11571: [Battery Monitor] Support "Gaming Input Battery type"

anthonyfieroni added a comment. @broulik, does it makes sens, when batteries isn't available (as your screenshot) to be shown, the icon of next device in the list, in systray ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11571 To: broulik, #plasma,

D11590: Add mutex round static member used in a thread

anthonyfieroni added inline comments. INLINE COMMENTS > backgroundlistmodel.cpp:532 > > -m_suffixes = suffixes.toList(); > +s_suffixes = suffixes.toList(); > } Potentially it still can produce a crash, the function returns a reference to list, simultaneously read/write

D10890: Don't skip certain recent documents in kicker and taskmanager

anthonyfieroni added a comment. It looks good to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10890: Prepare for KIO KRecentDocument fix (D10863)

anthonyfieroni added a comment. So why you called hack, why no just add conditional compilation against 5.44 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot,

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Someone? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

anthonyfieroni added inline comments. INLINE COMMENTS > startup.cpp:194 > +connect(phase1, ::finished, this, [=]() { > +ksmserver->setupShortcuts(); // done only here, because it needs > kglobalaccel :-/ > +}); Can we delay it to finishStartup? > startup.cpp:210 > > -void

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. In D15616#341840 , @davidedmundson wrote: > The DataEngine also has a timer for timeouts, so we now have two timeout timers. > Having two timeout timers doesn't seem right. Yep, i'm on same opinion,

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 43461. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42286=43461 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES dataengines/comic/comicprovider.cpp To: anthonyfieroni,

D15616: [Comic] Handle error state correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7c7c00798048: [comicprovider] Restart timer on redirect request (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. @davidedmundson to commit or you have other objections? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16715: make global menu minimize state aware

anthonyfieroni added inline comments. INLINE COMMENTS > appmenumodel.cpp:245-248 > +if (info.isMinimized()) { > +setMenuIsHidden(true); > +} else { > +setMenuIsHidden(false); setMenuHidden(info.isMinimized()); > appmenumodel.h:42 > Q_PROPERTY(bool

D16842: [clipboard] Limit length of clipboard text item visualisation

This revision was automatically updated to reflect the committed changes. anthonyfieroni marked an inline comment as done. Closed by commit R120:d53622d7d9e0: [clipboard] Limit length of clipboard text item visualisation (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT

D16856: [comicproviderwrapper] Always finish on last request in pageRetrieved

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Otherwise provider can be marked as failed REPOSITORY R114

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni added a comment. Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plasma, broulik, davidedmundson

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY The problem: 1. Unplug laptop power supply 2. On screen

D16856: [comic] Sync configuration on write

anthonyfieroni updated this revision to Diff 45556. anthonyfieroni added a comment. Better not change data engine REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16856?vs=45396=45556 REVISION DETAIL https://phabricator.kde.org/D16856 AFFECTED

D16873: [comic] Request current identifier on date changed

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY The problem is when date is changed we connect to source ex.

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni updated this revision to Diff 45502. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16890?vs=45500=45502 REVISION DETAIL https://phabricator.kde.org/D16890 AFFECTED FILES applets/systemtray/package/contents/ui/main.qml To:

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY It still has one problem, after configuration is

D16842: [clipboard] Limit length of clipboard text item visualisation

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Applying regex to long text item (> 5000 symbols) is

D16844: [comic] Correct usage of DataEngineConsumer

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Comic applet is DataEngineConsumer which take care of loading

D16844: [comic] Correct usage of DataEngineConsumer

anthonyfieroni updated this revision to Diff 45370. anthonyfieroni added a comment. Fix diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16844?vs=45369=45370 REVISION DETAIL https://phabricator.kde.org/D16844 AFFECTED FILES

D15840: [Folder View] Remember selected item when navigating in subfolders

anthonyfieroni added inline comments. INLINE COMMENTS > FolderView.qml:1114 > onListingCompleted: { > if (!gridView.model && plasmoid.expanded) { > gridView.model = positioner; Do we have grodView.model after back clicked? If we do in expanded

D15875: [Media Controller] Disallow seeking beyond end of track

anthonyfieroni added a comment. 1s file is a corner case as well as 0, cause you have always 2 positions - start and stop. In 0/1s these 2 steps just match, if you are write 0 isn't valid in 0s length file, does it? +1 for the patch from me. REPOSITORY R120 Plasma Workspace REVISION

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15840: [Folder View] Remember selected item when navigating in subfolders

anthonyfieroni added inline comments. INLINE COMMENTS > thsurrel wrote in FolderView.qml:1114 > My understanding was that the gridView.model could be undefined only if the > FolderModel was not ready. But if we navigated into a subfolder and we are > asking to go back, than the FolderModel had

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42035. anthonyfieroni added a comment. Another approach: If timer expires in 2 min without result disconnect it from source and starts again for next 2 min, when it expires if try to update again by activate slotCurrentDay REPOSITORY R114

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping, @davidedmundson let's make some change on this REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42148. anthonyfieroni added a comment. Stop indicator in a minute, restart engine in 10 sec. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42035=42148 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42286. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42148=42286 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h

D13745: Implement support for virtual desktops on Wayland

anthonyfieroni added inline comments. INLINE COMMENTS > abstracttasksproxymodeliface.cpp:216 > + > +const QModelIndex = mapIfaceToSource(index); > +const AbstractTasksModelIface *m = dynamic_cast AbstractTasksModelIface *>(sourceIndex.model()); mapIfaceToSource and mapToSource returns

D15616: [Comic] Handle error state correctly

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY This happen really rare, i've used comic applet on my desktop

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 41977. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=41976=41977 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h

D16890: [systemtray] Keep config entries after modifying

anthonyfieroni added a comment. But for some reason, on second Entries show warnings says: cannot call createObject on null object. Looks like it is treated as local object or something. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To:

D16873: [comic] Request current identifier on date changed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:fd19c36ec4e4: [comic] Request current identifier on data change (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT

D16856: [comicupdater] Fix last day check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:28493251921b: [comicupdater] Fix last day check (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons

D16918: [dimdisplay] Do not change screen brightness on invalid values

This revision was automatically updated to reflect the committed changes. Closed by commit R122:6f350690723a: [dimdisplay] Do not change screen brightness on invalid values (authored by anthonyfieroni). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D17874: [dimdisplay] Effectively waits display to wake-up

anthonyfieroni added a comment. Does someone test it, @thsurrel ? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D17874 To: anthonyfieroni, mart, broulik, thsurrel, #plasma Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

<    1   2   3   4   5   6   7   >