D12278: WIP: [Colors KCM] Port to new design

2019-01-02 Thread Björn Feber
GB_2 added a comment. > This removes the "Apply to non-Qt applications checkbox" which isn't something one should uncheck. I disagree. I even think it should be disabled by default, because it causes issues in GTK 2 apps such as this: https://i.stack.imgur.com/jpeYm.jpg I think it is

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

2019-01-05 Thread Björn Feber
GB_2 added a comment. In D17963#386701 , @ngraham wrote: > Hmm, this results in the menu having one colored icon and two monochrome icons. > > My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we should mention it by

D18012: [SDDM theme] Update the theme preview

2019-01-06 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. +1, updated and looks much better REPOSITORY R120 Plasma Workspace BRANCH new-sddm-preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D18012 To: filipf,

D18012: [SDDM theme] Update the theme preview

2019-01-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a3bbdef02ad8: [SDDM theme] Update the theme preview (authored by filipf, committed by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18016: Don't use hardcoded background color

2019-01-06 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Fixes the hardcoded SDDM theme preview background color F6530004: SDDM KCM Breeze.png

D18381: Add tooltip to configure panel button

2019-01-20 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a08f3d135c5: Add tooltip to configure panel button (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18381?vs=49870=49918 REVISION DETAIL

D18381: Add tooltip to configure panel button

2019-01-19 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds a tooltip to the configure panel button. F6556503: Configure Panel Tooltip.png

D18269: Improve the Splash Screen KCM

2019-01-15 Thread Björn Feber
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd94db08a555: Improve the Splash Screen KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D18267: Improve the Cursor Theme KCM

2019-01-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The Cursor Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it

D18269: Improve the Splash Screen KCM

2019-01-15 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > GB_2 wrote in kcm_splashscreen.desktop:2 > Yes, I just used it because I think it should be included in Plasma 5.15 and > it is the closest to a login splash icon I could find. BTW, the Plymouth Splash KCM just uses an empty screen icon.

D18269: Improve the Splash Screen KCM

2019-01-15 Thread Björn Feber
GB_2 added a comment. In D18269#393711 , @ngraham wrote: > In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch. Ok, sorry. REPOSITORY R119 Plasma

D18269: Improve the Splash Screen KCM

2019-01-15 Thread Björn Feber
GB_2 updated this revision to Diff 49544. GB_2 added a comment. Use old icon `preferences-system-splash` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18269?vs=49541=49544 BRANCH improve-splashscreen-kcm (branched from master) REVISION DETAIL

D18267: Improve the Cursor Theme KCM

2019-01-15 Thread Björn Feber
GB_2 added a comment. In D18267#393604 , @davidedmundson wrote: > Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so) Ok, there is one more patch that I will make with this name

D18267: Improve the Cursor Theme KCM

2019-01-15 Thread Björn Feber
GB_2 added a comment. In D18267#393635 , @ngraham wrote: > In D18267#393620 , @davidedmundson wrote: > > > > In the tooltip and header on the page > > > > > > > > > In the description of the

D18269: Improve the Splash Screen KCM

2019-01-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Splash Screen KCM has some

D18269: Improve the Splash Screen KCM

2019-01-15 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm_splashscreen.desktop:2 > I know you're making this change because we don't actually have a > `preferences-system-splash` icon, but is this really semantically correct? It > seems like we should actually create that icon, or

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Björn Feber
GB_2 added a comment. In D18247#393021 , @davidedmundson wrote: > > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and > > Where? > > > renames

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2015bad98e64: Improve Desktop/Plasma Theme KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18247?vs=49453=49461 REVISION DETAIL

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Desktop/Plasma Theme KCM has some

D12278: [Colors KCM] Port to new design

2019-01-23 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > colors.cpp:58 > + > +KAboutData *about = new KAboutData(QStringLiteral("kcm_colors"), > i18n("Configure color schemes"), > + QStringLiteral("2.0"), QString(), > KAboutLicense::GPL); Better: "Choose the

D18267: Improve the Cursor Theme KCM

2019-01-15 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0a4d3fa415d: Improve the Cursor Theme KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18267?vs=49536=49540 REVISION DETAIL

D17622: [Panel Edit Mode] Show screen edge button and panel size button tooltips immediately after click

2018-12-16 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This sets the delay of the tooltips added in D17323 to 0, so

D17574: Remove period ( . ) character from the end

2018-12-14 Thread Björn Feber
GB_2 added a comment. The two images need to be swapped. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17574 To: shubham, #plasma, #vdg, mart Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis,

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-14 Thread Björn Feber
GB_2 requested review of this revision. GB_2 added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:58 > This doesn't make sense.. > > We're re-evaulating because hasElement might have changed when switching > themes. So just remove the line? REPOSITORY R119 Plasma

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-15 Thread Björn Feber
GB_2 added a comment. In D17410#374062 , @davidedmundson wrote: > > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work... > > Use console.log to check your code is

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-15 Thread Björn Feber
GB_2 updated this revision to Diff 47615. GB_2 added a comment. Remove unneeded line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46739=47615 REVISION DETAIL https://phabricator.kde.org/D17321 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-04 Thread Björn Feber
GB_2 added a comment. Waiting for https://phabricator.kde.org/D17355 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-05 Thread Björn Feber
GB_2 added a comment. Because https://phabricator.kde.org/D17355 is currently not working properly, we have two options: 1. Small "Height/Width" button F6458263: Panel Edit Mode Buttons (1).png 2. Align "Height/Width" button contents on

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-05 Thread Björn Feber
GB_2 added a comment. Ok, number two then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47033. GB_2 added a comment. Add tooltip for the resize button, change tooltip text and increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47011=47033 REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-07 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY There is a configure button and an alternatives button in the context menu of an applet, but there

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47054. GB_2 added a comment. Update TODO text. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=47051=47054 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47038. GB_2 added a comment. Improve wording. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47033=47038 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47045. GB_2 added a comment. Fix tooltip text color (for real this time). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47041=47045 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47058. GB_2 added a comment. Hide the tooltip if you click on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47045=47058 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

2018-12-07 Thread Björn Feber
GB_2 added a comment. In D17323#372752 , @Codezela wrote: > when resizing the panel can we show the width of it > 48px ,36px etc > because now when I resize the panel I guess what better visually > but if I know the size exactly It will

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

2018-12-07 Thread Björn Feber
GB_2 added a comment. It's okay :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg, ngraham Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel,

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

2018-12-07 Thread Björn Feber
GB_2 updated this revision to Diff 47041. GB_2 added a comment. Fix text color. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47038=47041 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-08 Thread Björn Feber
GB_2 added a comment. In D17410#373036 , @ngraham wrote: > Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17321#370322 , @ngraham wrote: > For the panel edit mode button, I think this is 100% appropriate since it opens a configuration UI. For the toolbox, I'm not as convinced yet, since clicking on it opens a menu with a

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17323#370411 , @matheusm wrote: > +1, but why aren't the buttons content centered? They are, do you think that because of the screenshot? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Björn Feber
GB_2 updated this revision to Diff 46739. GB_2 edited the summary of this revision. GB_2 added a comment. Only change panel toolbox icon. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46736=46739 REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Modifies the screen edge button and panel size button in the panel edit mode to make them easier to

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. Oh, you mean the button content... I will try to fix that! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros,

D17321: Change toolbox icon from from a hamburger icon to a configure icon

2018-12-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the desktop/panel toolbox icon from a hamburger icon to a configure icon (as suggested in

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 updated this revision to Diff 46749. GB_2 edited the summary of this revision. GB_2 added a comment. Update panel size button icons. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46741=46749 REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. Hmm... when a button has an icon the content gets aligned on the left and I can't find a way to change it... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-03 Thread Björn Feber
GB_2 added a comment. I managed to fix it, but it the Plasma QML Button code needs to be changed. Should I create a new Phabricator revision or add it here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-06 Thread Björn Feber
GB_2 updated this revision to Diff 47011. GB_2 added a comment. Increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47010=47011 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-06 Thread Björn Feber
GB_2 updated this revision to Diff 47010. GB_2 added a comment. Improve code and add tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46973=47010 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-06 Thread Björn Feber
GB_2 updated this revision to Diff 46971. GB_2 added a comment. Added the tooltip. F6459564: Panel Edit Mode Buttons (3).png It is ready now! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17440: Rotate busy indicator clockwise

2018-12-08 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Breeze, VDG. GB_2 added projects: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Most loading/refresh icons have a circular arrow pointing clockwise,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-06 Thread Björn Feber
GB_2 added a comment. Oops, forgot the import... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-06 Thread Björn Feber
GB_2 updated this revision to Diff 46972. GB_2 added a comment. Use QQC2 tooltip. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46971=46972 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-06 Thread Björn Feber
GB_2 updated this revision to Diff 46973. GB_2 added a comment. Add import. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=46972=46973 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D18005: Include only the largest size for each wallpaper

2019-01-08 Thread Björn Feber
GB_2 added a comment. @cfeck had a good idea: In D18005#387519 , @cfeck wrote: > Maybe symlinking all to the largest version? REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL

D17934: [Kickoff] Increase Kickoff information label readability

2019-01-04 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:510c88f65b76: [Kickoff] Increase Kickoff information label readability (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

2019-01-04 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This adds an icon to the "Edit Applications..." menu entry to make it look better. F6525011: Edit

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

2019-01-04 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f29c04572c06: [Kicker and Kickoff] Use an icon for the Edit Applications... menu entry (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17935: [Clipboard] Use ellipsis in the search field label ('Search...' instead of 'Search')

2019-01-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d066eb8cbd85: [Clipboard] Use ellipsis in the search field label (Search... instead of… (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R120 Plasma Workspace CHANGES

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R126:d8069f6fcbde: [kde-cli-tools] Add search ellipsis to label, make label more consistent with… (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R126 KDE CLI Utilities

D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c52d93976e60: [plasma-desktop] Add search ellipsis to Font Management and Date and Time (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES

D18048: [Connections] Add search ellipsis to network connection search

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R116:9c7de905eab3: [Connections] Add search ellipsis to network connection search (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R116 Plasma Network Management Applet

D18206: Improve the Look and Feel KCM

2019-01-12 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes that and

D18206: Improve the Look and Feel KCM

2019-01-13 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:beca304a1f44: Improve the Look and Feel KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18206?vs=49321=49374 REVISION DETAIL

D17934: [Kickoff] Increase Kickoff information label readability

2019-01-03 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Looks better now! REPOSITORY R119 Plasma Desktop BRANCH centered-infolabel (branched from master) REVISION DETAIL https://phabricator.kde.org/D17934 To: rooty, ngraham, #vdg, #plasma,

D17934: [Kickoff] Increase Kickoff information label readability

2019-01-03 Thread Björn Feber
GB_2 added a comment. In D17934#386050 , @ngraham wrote: > The opacity change makes sense to me: since this text isn't visible by default, there's no reason to make it difficult to read with a low opacity. If you go hunting for it and want to

D17410: Add alternatives button to applet configuration in panel edit mode

2018-12-08 Thread Björn Feber
GB_2 added a comment. I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: davidedmundson, ngraham,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17323#370402 , @ngraham wrote: > Feel free to come up with a better wording; mine is probably crap since I just randomly thought of it. :p Yeah :P REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

2018-12-02 Thread Björn Feber
GB_2 added a comment. In D17323#370396 , @trickyricky26 wrote: > This is awesome, thank you! > > If this is not clear enough, would it be technically possible to display a tooltip explaining you have to drag the button and make that tooltip

D18546: [Desktop Toolbox] Use "tools" icon

2019-01-25 Thread Björn Feber
GB_2 added a comment. In D18546#400253 , @hein wrote: > How about we actually rename it "Desktop Menu". +1, good idea! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18546 To: ngraham, #vdg, #plasma Cc:

D18561: Use same intro page system settings icon as in the desktop file

2019-01-27 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the same system settings icon in the intro page that is used in the desktop file for consistency

D18559: Use correct sidebar back button press color

2019-01-26 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY The system settings currently use a wrong sidebar back button press color, which can look very bad on

D19077: Redesign the theme preview window

2019-04-02 Thread Björn Feber
GB_2 added a comment. I like B too. BTW, can "Background:" and the background selection button be centered like in a form layout? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-02 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes,

D19077: Redesign the theme preview window

2019-04-02 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D19829: kicker: add option to make root level icons visible

2019-04-02 Thread Björn Feber
GB_2 added a comment. In D19829#432852 , @i.Dark_Templar wrote: > Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-03-31 Thread Björn Feber
GB_2 added a comment. In D20144#441083 , @ngraham wrote: > +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-04-02 Thread Björn Feber
GB_2 added subscribers: rooty, filipf, abetts, ndavis. GB_2 added a comment. In D20144#441802 , @ngraham wrote: > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them?

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-04-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:da0adfedcab0: Make location of Lock Widgets and Remove Panel buttons more obvious (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber
GB_2 added a comment. @rooty Can you please reopen this? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: rooty, #vdg, #plasma, filipf, ngraham, GB_2 Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber
GB_2 added a comment. Is this okay with a form layout? F6753594: Adjusted SDDM KCM Background Label and Button.png If yes, I will take over this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D20266: Add new notification plasmoid

2019-04-05 Thread Björn Feber
GB_2 added a comment. Amazing! INLINE COMMENTS > FullRepresentation.qml:247 > +opacity: 0.6 > +text: list.count === 0 ? i18n("No unread notifications.") : > i18n("Notifications") > +} Please remove the dot to make it consistent with other Plasmoids.

D20266: Add new notification plasmoid

2019-04-05 Thread Björn Feber
GB_2 added a comment. I made a better timeout indicator that you can use: F6755221: TimeoutIndicator.qml This is how it looks like: F6755222: Circular Timeout.mp4 REPOSITORY R120 Plasma Workspace REVISION

D19209: [sddm-kcm] Adjust Background label and button

2019-04-04 Thread Björn Feber
GB_2 commandeered this revision. GB_2 edited reviewers, added: rooty; removed: GB_2. GB_2 added a comment. Ok, thanks. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham, rooty Cc: GB_2, abetts,

D19209: [sddm-kcm] Adjust Background label and button

2019-04-06 Thread Björn Feber
GB_2 added a comment. I think I can leave it how it is now. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-03-31 Thread Björn Feber
GB_2 added a comment. In D20144#441087 , @ngraham wrote: > Maybe just switch the buttons' positions and add a spacer between them, then? I can try putting a spacer or seperator between the 2 buttons, but if I switch the positions of

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-04-01 Thread Björn Feber
GB_2 updated this revision to Diff 55225. GB_2 added a comment. Add separator and spacer between the two buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20144?vs=55139=55225 BRANCH master REVISION DETAIL

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

2019-03-31 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406079 Move these two buttons to the left/top of the panel edit mode toolbar.

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > filipf wrote in ConfigBehavior.qml:69 > I tried `units.largeSpacing` first then realized it's not aligned with the > top text (not even with 1.0 scaling) so I did something like > `(units.largeSpacing - units.smallSpacing * 2)` which worked ok with

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ConfigAppearance.qml:21 > +import QtQuick 2.0 > +import QtQuick.Controls 1.0 as QQC1 > +import QtQuick.Controls 2.5 Import is not needed anymore. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf,

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ConfigAppearance.qml:21 > Yes it is, there's a RowLayout in here. I meant the QQC1 import, but it was removed just before I posted this comment :P REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > hein wrote in ConfigBehavior.qml:69 > Wait, 10x the checkbox width? Should be `units.largeSpacing` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein Cc:

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-24 Thread Björn Feber
GB_2 added a comment. Almost perfect! INLINE COMMENTS > ConfigBehavior.qml:64 > +id: onlyGroupWhenFull > +text: i18n("Only when the Task Manager is full") > +enabled: groupingStrategy.currentIndex > 0 && groupPopups.checked "Task Manager" should be

D17410: Add alternatives button to applet configuration in panel edit mode

2019-02-28 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty,

D19280: [TaskManager] Modernize and reorganize configuration settings

2019-02-26 Thread Björn Feber
GB_2 added a comment. Now just update the screenshots. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot,

D19077: Redesign the theme preview window

2019-02-21 Thread Björn Feber
GB_2 added a comment. In D19077#417065 , @filipf wrote: > OK so down to only one hack now. If possible I'd really like to keep it because it works in 100% of the cases I tested it with and results in better visuals; don't know how to fix on the

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:59 > Then do it so I can accept the patch I already did it. > apol wrote in gtkconfigkcmodule.cpp:65 > That's fine, but you can do it in a separate patch. I'm already updating the strings here. I always did

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 54026. GB_2 added a comment. Add back word GNOME and update GHNS button tooltip REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53994=54026 BRANCH master REVISION DETAIL

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 53994. GB_2 added a comment. Clean desktop file REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53967=53994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FILES

  1   2   3   4   5   6   7   >