D19454: WIP: Fix errors in kirigami example files

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Remove deprecation, fix anchors in RowLayout and remove trailing space **Done:** - Sidebar.qml -

D19314: Fix bug (check null didn't work)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:938b79be2421: Fix bug (check null didnt work) (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19314?vs=52552=52600 REVISION DETAIL

D19321: Fix a right to left issue

This revision was automatically updated to reflect the committed changes. Closed by commit R169:0e5bc4887d27: Fix a right to left issue (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19321?vs=52562=52599 REVISION DETAIL

D19321: Fix a right to left issue

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REPOSITORY R169 Kirigami BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D19321 AFFECTED FILES src/controls/ActionTextField.qml To:

D19315: Use ActionTextField to implement the searchField

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Need Kirigami latest version (master) and D19314 **Warning:** Remove the opacity change

D19314: Fix bug (check null didn't work)

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Found a bug when adding this component to system settings, != null didn't work TEST PLAN Tested with applications already using

D19301: Use Kirigami.ActionTextField for the SearchField

This revision was automatically updated to reflect the committed changes. Closed by commit R134:0bb9bd345f0a: Use Kirigami.ActionTextField for the SearchField (authored by ognarb). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19300: Improve ToolTip in the ActionTextField component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e0503e1794b5: Improve ToolTip in the ActionTextField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19300?vs=52528=52536 REVISION

D19301: Use Kirigami.ActionTextField for the SearchField

ognarb updated this revision to Diff 52533. ognarb marked 2 inline comments as done. ognarb added a comment. Improve code REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19301?vs=52529=52533 BRANCH master REVISION DETAIL

D19301: Use Kirigami.ActionTextField for the SearchField

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Need Kirigami latest version (master) TEST PLAN A regression found (need D19300 ) REPOSITORY

D19300: Improve ToolTip in the ActionTextField component

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY - Add standard duration (Kirigami.Units) - Don't display when text is not empty (same behaviour as in Discover) TEST PLAN

D18716: Add an ActionTextField component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d92bd4fe02c3: Add an ActionTextField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52411=52519 REVISION DETAIL

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52411. ognarb added a comment. - Fix typo in doc - Code refactorization REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52214=52411 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18716

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52214. ognarb marked 2 inline comments as done. ognarb added a comment. - Revert unrelated change - Use icon.name instead of iconName REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52204=52214 BRANCH

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52204. ognarb added a comment. - Use Kirigami.Icon instead of Controls.ToolBouton - Fix doc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52141=52204 BRANCH master REVISION DETAIL

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52141. ognarb added a comment. - Use list of actions - Text don't go under buttons now - Fix some warning in the testcase Sidebar.qml @mart That do you recommand me to use for the icons instead of ToolButton? I tried to do it with Kirigami.Icon

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52127. ognarb added a comment. WIP: use repeater and list of actions REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52125=52127 BRANCH arcpatch-D18716 REVISION DETAIL https://phabricator.kde.org/D18716

D18716: Add a TextField component

ognarb updated this revision to Diff 52125. ognarb marked 2 inline comments as done. ognarb added a comment. - use Controls namespace - use ActionTextField instead of TextField REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=51215=52125 BRANCH

D19011: Thunderbolt KCM and KDED module

ognarb added inline comments. INLINE COMMENTS > fakeserver.h:1 > +#ifndef FAKESERVER_H > +#define FAKESERVER_H You forgot to add a GPL license header for this file. Same for: - autotests/bolt/fakeserver/fakeserver.cpp - autotests/bolt/kded/kdedtest.cpp - autotests/bolt/lib/managertest.cpp -

D18716: Add a TextField component

ognarb added a comment. @mart thanks for the review, I don't have enough time this weekend, but I will start working on it next Tuesday :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18716 To: ognarb, apol, #kirigami, ngraham, mart Cc: broulik, mart, apol,

D18716: Add a TextField component

ognarb added inline comments. INLINE COMMENTS > TextField.qml:101 > +} > +icon.name: root.leftAction != null ? root.rightAction.iconName : "" > +visible: root.leftAction != null && root.leftAction.visible @mart I'm not sure if it's the right way to convert the icon from

D18716: Add a SearchField component

ognarb updated this revision to Diff 51215. ognarb added a comment. Create a generic TextField instead REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=50813=51215 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18716 AFFECTED

D18716: Add a SearchField component

ognarb added a comment. In D18716#404718 , @mart wrote: > If we are going to have a specialized line edit, I think it shouldn't be specific for search, but be a common component of things that we have to boilerplate too often as they are

D18716: Add a SearchField component

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This is based on the searchField from Discover. It's a sugestion from @ngraham and I find it's a great idea. Note: Because

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb added a comment. In D17482#375191 , @broulik wrote: > Breaks build of plasma-desktoop: > > index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article > > ^ >

D17482: Upload new screenshots in the documentation and uncomment a section

This revision was automatically updated to reflect the committed changes. Closed by commit R119:86bc4bb1f806: Upload new screenshots in the documentation and uncomment a section (authored by ognarb). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb added a comment. In D17482#375170 , @yurchor wrote: > Oops... Sorry. No problems :) Thanks for the review. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb,

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb added inline comments. INLINE COMMENTS > yurchor wrote in index.docbook:103 > To keep the result valid this line should be removed as well. Look line 78, I just moved the beginning of the comment. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ognarb requested review of this revision. REVISION SUMMARY New screenshots that reflect current version of system settings. I also uncommented a section in the

<    1   2