[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

https://bugs.kde.org/show_bug.cgi?id=375909 --- Comment #2 from Chris Holland <zrenf...@gmail.com> --- Huh you're right David. Just checked that it's still blue by opening a new session. I didn't actually check to see if the theme.conf.user and wallpaper was deleted. Guess they might hav

[Breeze] [Bug 375909] New: Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

https://bugs.kde.org/show_bug.cgi?id=375909 Bug ID: 375909 Summary: Breeze SDDM wallpaper was reset in KDE Neon 5.9 update Product: Breeze Version: 5.9.0 Platform: Neon Packages OS: Linux Status: UNCONFIRMED

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. What DPI are you using SubDiff? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, drosca, Zren Cc: plasma-devel,

[Differential] [Updated] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. F2562978: 2017-02-23___17-03-39.png Looks like the icon is really small in plasmoidviewer? Just wondering why you used a IconItem+MouseArea pattern for the button instead of `PlasmaComponents.ToolButton`? The positioning

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:283 > Please move literal to right side of comparison: `PulseObject.ports.length > > 0` or even in this case you can just write `PulseObject.ports.length`. > > But actually make it `Ports.length` as said in previous

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added inline comments. INLINE COMMENTS > subdiff wrote in ListItemBase.qml:283 > > Please move literal to right side > > I like to read my inequalities from lower value to higher one. Easier to read > the code this way. Besides style is there something else speaking against > that? What

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I'm using the default DPI of 96. `PlasmaExtras.Heading { level: 5 }` is what's controlling the RowLayout height. Level 5 is just the `theme.defaultFont.pointSize`

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

Zren added a comment. Ah, just noticed the title (bytes => bits), and I agree it should remain bytes, or at least be optional. > I proposed bits per second for network monitor only since users internet speeds are advertised/shown as "Mbps" or "Kbps" or the like. Do the math (divide

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

Zren added a comment. Any reason for not using if (...) { } else if (...) { } else { } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4551 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vishalrao Cc: Zren,

[Differential] [Request, 10 lines] D4845: Fix context menu button's icon size when on default DPI

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ToolButton pads the contexts of the label+icon based on the desktop theme's svg margins. Causing the icon to only be 12px, which is scaled down

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

Zren edited the summary of this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, subdiff, drosca, broulik Cc: plasma-devel, progwolff,

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added inline comments. INLINE COMMENTS > Zren wrote in ListItemBase.qml:122 > Not really. Just wanted to have consistent code with ToolButtonStyle, but I > already had to change `control` => `parent` so might as well remove it. > ToolButton is basically a `flat: true` Button so that part

[Differential] [Updated, 10 lines] D4845: Fix context menu button's icon size when on default DPI

Zren updated this revision to Diff 11969. Zren added a comment. Remove `|| !parent.flat` REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4845?vs=11964=11969 REVISION DETAIL https://phabricator.kde.org/D4845 AFFECTED FILES

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

Zren marked 3 inline comments as done. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, subdiff, drosca, broulik Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:122 > Do we really need this (we certainly don't need the `parent.flat` part)? It > doesn't seem to change the icon at all. Not really. Just wanted to have consistent code with ToolButtonStyle, but I already had to

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. @davidedmundson: Yes. I usually test in plasmoidviewer since it's the same (except for emoji rendering ). I get the same effect because you're still trying to stuff a 16px icon into a 12px hole at 1x DPI (96). The

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I did, there wasn't any change from when I tested it with `Layout.maximumHeight`, because there's padding around the icon. Huh, I didn't post a screenshot, here: F2657863: 2017-02-27___14-51-23.png

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. Ah! Sorry bout that, `/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls/Styles/Plasma/ToolButtonStyle.qml` is different from what it shows in git. I copied the git source to that file, and while there was a bit of complaining about the stringlist => string bit,

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I mentioned earlier: > Using Layout.maximumHeight: parent.height on the ToolButton will make it 18px tall, but will also make the icon tiny by default (because it keeps the padding). We can bypass this by anchoring a child IconItem. You need to anchor an

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. Oh crap. I just realized the stringlist => string error caused the svg not to load at all. Which means it wouldn't detect the margins from the svg. Essentially causing it to not add any "padding". If I copy "use anchors instead of fillHeight …"

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Before tackling the implicitWidth/height stuff, I noticed that my microphone's Heading label was getting moved on the first click. Adding `height: contextMenuButton.height` fixes it but that doesn't feel right. https://streamable.com/07hc0 REPOSITORY R115 Plasma

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In TiledMenu, I need access to the localized home directories so I can link to the right folders in the bottom left area above the power icon.

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren added a comment. Thought you might want that, but wasn't sure how to expose QStandardPaths to QML. Got an example handy? All I can find is: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmacomponents/enums.h

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Yeah, it's probably dpi scaling. And I didn't want to mess with the height of the ListItemBase. On further testing, it seems adding smallSpacing margins isn't as bad as I thought. Back and Forth Gif: https://streamable.com/0ld55 F3154040:

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Ah, ignore the `visible: false` in that, was testing which variables ToolButton uses (iconSource. iconName). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma, subdiff, drosca Cc: subdiff, drosca,

D5144: Change the volume icon/mute button into a ToolButton

Zren updated this revision to Diff 12746. Zren added a comment. Create a reusuble SmallToolButton class. Add smallSpacing around the mute button. Remove spacing between the two rows to counter the increase in height. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D5086: Applet: Add Raise maximum volume action to context menu

Zren added a comment. Looks good. F3126554: 2017-03-22___20-56-01.png There's one issue I want to point out that I dealt with, is that other instances of the widget won't be in the "raised" state (eg: other screens). Example:

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Another thing we could do to keep things small vertically is set `spacing: 0` in the `ColumnLayout { id: column }`. F3154383: 2017-03-23___11-50-47.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

T5412: Improve Plasma PA usability

Zren added a comment. I made https://phabricator.kde.org/D5144 which turns the volume icon/mute button into a ToolButton. TASK DETAIL https://phabricator.kde.org/T5412 To: Zren Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai,

D5144: Change the volume icon/mute button into a ToolButton

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds a hover effect so the user knows it's a button. Unlike the application-menu button, I didn't add the smallSpacing around it so

T5412: Improve Plasma PA usability

Zren added a comment. Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not follow the color scheme. The 16px `-muted`, which is a softlink to the `mic-off.svg` icon is okay. This is because the `style="color:#4d4d4d;..."` which overrides the `fill:currentColor`. We'll

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren added a comment. And yes I know KDE Neon is Qt 5.7.1 at the moment, I meant to ask wither it's part of the standard install of Qt. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5170 To: Zren, hein Cc: broulik, plasma-devel, progwolff, lesliezhai,

D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths

Zren added a comment. Oh neat! Hmm experimental Qt 5.8 library is fine, but would it be installed by default on say KDE Neon or would it need a package to be manually installed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5170 To: Zren, hein Cc: broulik,

D5144: Change the volume icon/mute button into a ToolButton

Zren updated this revision to Diff 13070. Zren edited the summary of this revision. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5144?vs=12746=13070 REVISION DETAIL https://phabricator.kde.org/D5144 AFFECTED FILES

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. > I've seen that, but that is unrelated to this change, so please move it into separate review. Sorry. I hit a wall on that bug and it drove me crazy. I just found out that changing `spacing: 0` to `spacing: 1` will cause things to layout correctly the first time.

D5144: Change the volume icon/mute button into a ToolButton

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2ac365e96b70: Change the volume icon/mute button into a ToolButton (authored by Zren). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D4845: Fix context menu button's icon size when on default DPI

This revision was automatically updated to reflect the committed changes. Closed by commit R115:4d4867b89996: Fix context menu button's icon size when on default DPI (authored by Zren). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

Listening to a notification button's "onClick" in the notifications DataEngine

It seems the ActionInvoked and NotificationClosed signal isn't exposed anywhere. The signals are defined here: https://github.com/KDE/plasma-workspace/blob/master/dataengines/notifications/notificationsengine.h#L84 And the signals are called here:

D4845: Fix context menu button's icon size when on default DPI

Zren updated this revision to Diff 12221. Zren added a comment. Fix merge conflict based on removal of x/y parameters in contextmenu.show() Change height from slider.height to units.iconSizes.small REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. Ah, the `contextMenu.show(x, y)` changed to `contextMenu.show()`. I've got to comment out `roundToIconSize: false` in the mute "button" to test now since that probably requires a new version of frameworks. I changed the `slider.height` to `Layout.preferredHeight:

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. That's a good idea @broulik . Slider height for the Desktop themes I have installed (I used this script ): - air: 20px - Arctica: 24px - Arezzo: 24px - arquetype-dark: 24px - Bise: 24px -

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Should I go ahead and commit this? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma, subdiff, drosca Cc: mart, subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5209: Load translations from KPackage files if bundled

Zren added a comment. Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then? Does this mean: 1. `digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po` 2.

D6764: Add font size setting to the digital clock plasmoid

Zren added inline comments. INLINE COMMENTS > DigitalClock.qml:473 > italic: plasmoid.configuration.italicText > -pixelSize: 1024 > +pointSize: plasmoid.configuration.fontSize > } We use `font.pixelSize` to avoid the

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

Zren added a comment. Hmmm, this seems better than my solution since mine stays in the boosted state (slide.maxValue=150%) after the volume when back below 100%. I'm guessing the side effect of this method is that if you uncheck "force boost" when the volume is 150%, it will stay at

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. In https://phabricator.kde.org/D6188#115778, @broulik wrote: > About panels covering the contents, perhaps you want to take into account `plasmoid.availableScreenRect` but `root` already has a `margin` based on this, so maybe just use the `ScrollView`'s size

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. Oh now I remember why I used `scrollView.viewport`. We don't want to count the scrollbars as "extra" space. Notice in this screenshot it would perfectly fit another row, but the scrollbar made the area shorter. F3782025: 2017-06-12___13-17-47.png

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. So removing the following two conditionals fixes it. I'm not sure why they are there. Right now it only stops at the panels if we're already overflowing. in `rightMargin`: `(folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowLeftToRight ||

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren updated this revision to Diff 15393. Zren added a comment. +readonly. +semicolons. Remove check for if we're already overflowing, using rtl layout, or if it's "arrange in columns/rows", since the ScrollView shouldn't be covered by panels. REPOSITORY R119 Plasma Desktop CHANGES

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren marked 2 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6188 To: Zren, hein Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6201: [Desktop] Avoid binding loop on label.width by anchoring left/right to the frame

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Is there a reason we need to have the label to be implicitWidth? Right now, we get a binding loop on `width: Math.min(label.implicitWidth +

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren updated this revision to Diff 15398. Zren added a comment. We don't really need to wait for folderViewLayer.ready before setting the bottom/right anchors anymore. Don't add extra spacing if we're not a containment (the desktop). Remove comment that's no longer applicable. REPOSITORY

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren updated this revision to Diff 15400. Zren added a comment. Semicolons... (I should install a linter) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6188?vs=15398=15400 REVISION DETAIL https://phabricator.kde.org/D6188 AFFECTED FILES

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. In https://phabricator.kde.org/D6188#115982, @hein wrote: > You didn't change the comment above the code you modified. Did you test that this is no longer an issue? If not, the comment needs adjusting. Ah, yeah, I should remove that comment. Beforehand, you

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added inline comments. INLINE COMMENTS > anthonyfieroni wrote in FolderView.qml:538 > Why it used (6 * units.smallSpacing) it makes more space at bottom? It should > be same as iconwidth calculation, about me. I see you not change it, but it > should. Fairly certain was `smallSpacing *

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. What behaviour should the folder widget use: 1. Old behaviour: https://streamable.com/5gk5p 2. Current behaviour with the patch: https://streamable.com/qs4s4 3. Combination of the two, when "arranged in rows", it should stretch to fill the width, but keep a

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. > https://cgit.kde.org/plasma-desktop.git/commit/?id=f49ca6ee277142539e0302f2848c79ff41d319cf @hein Good catch with the `&& isRootView`. It's just optimization since the extraSpace for the popup is 0 right? Now that I think on it, not sure why I made the variables

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren added inline comments. INLINE COMMENTS > hein wrote in FolderView.qml:492 > Maybe I'm blind, but you're linking to a definition of a 'ready' prop in a > different file. FolderView.qml can't depend on a property in main.qml, this > will e.g. break in FolderViewDialog. And yeah,

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:33793e9e2f56: [FolderView] Don't calculate extra spacing when we don't need to. (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6322?vs=15709=15719#toc REPOSITORY R119

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren updated this revision to Diff 15709. Zren added a comment. +semicolon and specify it's scrollArea.ready REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6322?vs=15705=15709 REVISION DETAIL https://phabricator.kde.org/D6322 AFFECTED FILES

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6322 To: Zren, hein Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Wait until the ScrollView component has completed before attempting to dynamically size the icons based on the viewport width/height. A

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. So before my commit, it was only needing to do: qml: cellHeight iconHeight 108 qml: cellWidth iconWidth 92 qml: cellHeight iconHeight 108 with no updates after the panel is added. - After my patch logs:

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren added inline comments. INLINE COMMENTS > hein wrote in FolderView.qml:492 > Missing semicolon, also ready is defined nowhere. Arg, curses. `ready` is defined 2 lines up. Also, do you want me to put `scrollArea.ready` so it's not confused with `folderViewLayer.ready` defined in

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current thickness is also shown when dragging as well. Closing the ruler thing and reopening will recreate the component, so the

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren updated this revision to Diff 15888. Zren added a comment. Jump by 2px. Jump by __ clicks. Make sure thickness is even. Hide thickness in button after 1 second. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6392?vs=15873=15888 REVISION

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren added a comment. Great idea about using a timer in the binding. I can probably keep the onThicknessChanged binding since it does change size when moved from left/right to top/bottom. As far as I can tell, the `wheel.delta` is only using the hardcoded jumps of ±120 (on click) (or

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5932: KCM for controlling Night Color

Zren added a comment. Is there a "daytime" setting or is it hardcoded to be 100% blue? Redshift Control for example: F3764291: 2017-05-25___08-09-46.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5932 To:

D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell

Zren added a comment. Hmm, just of this after reading a comment on reddit. Latte-Dock uses another process, would this cause keyboard shortcuts to not work for it? I'm not sure if it has a different app name.

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

This revision was automatically updated to reflect the committed changes. Closed by commit R119:20ba491cb6bd: [Folder View] Pad cellWidth/cellHeight with the extra space (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren updated this revision to Diff 15368. Zren edited the summary of this revision. Zren added a comment. Cleaner logic in calcExtraSpacing(). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6188?vs=15367=15368 REVISION DETAIL

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is an initial attempt. There's a few edge cases I need to deal with, but I just want to be sure I'm on the right track first. This turned

D5684: Move all streams when changing default device

Zren added a comment. I see you saw the /r/linux thread: https://www.reddit.com/r/linux/comments/68jy8l/kde_users_how_do_you_switch_between_two_audio/ Going to suggest another test: 1. Open mpv with audio playing. 2. Set DeviceA as default 3. Close mpv 4. Set DeviceB as

D5729: #379003: Fix National Geographic POTD provider

Zren added inline comments. INLINE COMMENTS > sebas wrote in natgeoprovider.cpp:96 > Why this change? Moving away from https to http seems backward... The https redirects to http (HTTP 302 temp move), then redirects to add the trailing slash (HTTP 301 Perm Move). F3744087:

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

Zren created this revision. Zren added a reviewer: ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY First I fixed the ActionItem label width exiting the button boundaries mentioned in

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

Zren edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7355: Properly change buttons hit area to enforce Fitts law when windows are quick-tiled and or vertically/horizontally maximiezed. At the same time, do not draw the window round corners.

Zren added a comment. Neat. I gave it a test. F3864946: 2017-08-16___17-42-51.png The right edge now hovers the decoration button, and so does the corner and top edge. However, the top edge and corner still show the "resize" cursors even

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

This revision was automatically updated to reflect the committed changes. Closed by commit R845:0ad9e0a1fdc2: Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size (authored by Zren). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

Zren added a comment. No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else.  REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff,

D9201: Slightly reduce vertical gutter width.

Zren added a comment. Before patch: - `GridView.cellHeight` was `icon.height + text.height + 6 * smallSpacing` - `Loader {id: frameLoader }` was `icon.height + text.height + 5 * smallSpacing`. It also has a `y offset` giving it a `1 * smallSpacing` top margin. After patch: -

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

Zren updated this revision to Diff 34138. Zren added a comment. Remove unrelated brace formatting. If there's nothing else, I'll merge it this evening. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12859?vs=34090=34138 REVISION DETAIL

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:b0fc4805e961: [QuickShare] Respect units.iconSizeHints.panel for panel icon (authored by Zren). REPOSITORY R114

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 33951. Zren added a comment. Use `connect(m_newStuffDialog.data(), ...)` to support gcc 4.8. Add license headers. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12040?vs=33024=33951 REVISION DETAIL

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Reported on reddit:

D13596: Fix there being more security updates than total updates in notifier

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY We currently read the previous `m_securityCount` instead of using the current `securityCount`. BUG:

D13508: Swap Trash for Delete action when only one is enabled and the Shift modifier is pressed

Zren added inline comments. INLINE COMMENTS > FolderView.qml:281 > pressedItem = hoveredItem; > - > +https://bugs.kde.org/show_bug.cgi?id=120008 > var pos = mapToItem(hoveredItem.actionsOverlay, mouse.x, > mouse.y); Looks like you accidently pasted this, or

D13596: Fix there being more security updates than total updates in notifier

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9577e7d1d333: Fix there being more security updates than total updates in notifier (authored by Zren). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D13596: Fix there being more security updates than total updates in notifier

Zren added a comment. Thanks @apol for merging it. Thanks @ngraham for testing it and the link and @davidedmundson for explaining how bugfixes are merged. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13596 To: Zren, #discover_software_store, apol

D13390: Fonts KCM: Fix text readability regression

Zren added a comment. Would the `TextField.readOnly` property be useful here? http://doc.qt.io/qt-5/qml-qtquick-controls-textfield.html#readOnly-prop F5894577: 2018-06-06___19-47-34.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

Zren abandoned this revision. Zren added a comment. No prob. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13162 To: Zren Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY This prevents the user from accidentally dragging a `.desktop` file into their browser. BUG: 390034

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. In D12040#257170 , @mart wrote: > so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8. > if accessed normally, it doesn't need it So I need to change

D9201: Slightly reduce vertical gutter width.

Zren commandeered this revision. Zren added a reviewer: hein. Zren added a comment. Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the sidebar. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: Zren, #plasma, hein Cc: ngraham,

D9201: Slightly reduce vertical gutter width.

Zren updated this revision to Diff 24677. Zren edited the summary of this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9201?vs=23791=24677 REVISION DETAIL https://phabricator.kde.org/D9201 AFFECTED FILES

D9201: Slightly reduce vertical gutter width.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5ae880f84626: Slightly reduce vertical gutter width. (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9201?vs=24677=24805 REVISION DETAIL

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

Zren updated this revision to Diff 24808. Zren retitled this revision from "[Panel Config] Scrolling over size button increments size by 1 and shows current thickness" to "[Panel Config] Scrolling over size button increments size by 2 and shows current thickness". Zren edited the summary of this

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

Zren marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9726: Change device "master volume" to be the max of all channels instead of the avg

Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY When we use the avg, it's very easy to "boost" the "right speaker" over

D4140: Rework playing of volume feedback

Zren added a comment. Is the `onVolumeChange` call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us. Does this fire `onVolumeChange` immediately? sinkModel.preferredSink.volume = volume; If so, you're currently calling playFeedback();

  1   2   3   >