D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. I know that DrKonqi hardly pops up these days. But still, if this button became more popular, then D11235 and D11236 might get some attention as well... REPOSITORY R871 DrKonqi REVISION

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 6 inline comments as done. croick added a comment. Thank you for your comments, totally forgot about licensing. INLINE COMMENTS > maximilianocuria wrote in queryptrace.cpp:26 > Please honour TMPDIR or, even better, use QTemporaryDir (this will also make > the generated path

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34670. croick added a comment. - add license text - use `QDir::tempPath()` - ifdefs to definition REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=30979=34670 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34671. croick marked an inline comment as done. croick added a comment. - check size of socket path REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=34670=34671 BRANCH ptracer REVISION DETAIL

D9892: cmake: Use the official CMake variable for building as a static plugin.

croick added inline comments. INLINE COMMENTS > CMakeLists.txt:69 > +if (PLASMA_ENABLED) > +install(DIRECTORY styles/Plasma DESTINATION > ${KDE_INSTALL_QMLDIR}/org/kde/kirigami.2/styles) > +endif() When trying to install it using kdesrc-build, it complains about not finding

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

croick added a reviewer: Plasma: Workspaces. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D10195 To: croick, #kdevelop, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

croick created this revision. croick added a reviewer: KDevelop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY - register a DBus service to make it work at all - service name

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

croick edited the test plan for this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D10195 To: croick, #kdevelop, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

This revision was automatically updated to reflect the committed changes. Closed by commit R871:2c0f0449a560: DrKonqi: Enable DBus-Interface for debugging with KDevelop (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10195?vs=26227=28877#toc REPOSITORY R871

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > crashtest.cpp:138 > > - //start drkonqi directly so that drkonqi's output goes to the console > - KCrash::CrashFlags flags = KCrash::AlwaysDirectly; That reasoning does not seem to be true. The output can still be read when started

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick created this revision. croick added reviewers: Plasma: Workspaces, apol, mwolff. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY - independently of the config setting in

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick created this revision. croick added reviewers: Plasma: Workspaces, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY - In Linux recent kernels only allow

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 29249. croick added a comment. - remove superfluous include REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29247=29249 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 30979. croick added a comment. - update socket file location REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29249=30979 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. bump REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick, #plasma_workspaces, apol, mwolff Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 11 inline comments as done. croick added a comment. `read()` and `write()` were assumed to work right away, I added a loop around. INLINE COMMENTS > ossi wrote in crashtest.cpp:133 > this addition isn't used or explained anywhere for all i can tell. It's used to unset the

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49618. croick added a comment. - use debuggee pid instead of DrKonqi pid for socket name - make sure to read/write all bytes from/to socket REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49607=49618 BRANCH

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49649. croick marked an inline comment as done. croick added a comment. - change order and add comment to kdeinit option in crashtest - add warning if debuggee does not respond as expected REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49651. croick marked 5 inline comments as done. croick added a comment. - emit warning if no socket is available REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49649=49651 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > ossi wrote in ptracer.cpp:65 > you really could just use != here ... ^^ wow... REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49705. croick edited the summary of this revision. croick added a comment. - adjust warning and check for EINTR when polling REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49651=49705 BRANCH ptracer

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. Actually, by using `KCrash::setFlags(KCrash::KeepFDs)` in KDevelop, so preventing the closing of all FDs, the problem is fixed(?) as well. But I think, that the situation should not appear, even for a "misconfigured" debuggee. REPOSITORY R871 DrKonqi REVISION

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. **GDB** Actually the problem is about joining threads at the end of `main()`. After being stuck and `kill -SIGSTOP $(pidof kdevelop)`, DrKonqi turns out to be here: #0 0x7fbf18adbf6d in __pthread_timedjoin_ex () from /usr/lib/libpthread.so.0 #1

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY Observed with a crashing KDevelop: If the QApplication is destructed after cleanup of the DrKonqi backend, somehow a

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added a comment. > you got the parent-child ordering wrong in the commit message. ^^ What do you mean? The (internal) debugger is a child of the debuggee. $ pstree -pn $(pidof crashtest) crashtest(17220)─┬─{crashtest}(17221) ├─{crashtest}(17222)

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49717. croick added a comment. - swap variable declaration REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49710=49717 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49710. croick added a comment. - swap lines, declare array for response message where needed REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49705=49710 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49607. croick edited the summary of this revision. croick edited the test plan for this revision. croick added a comment. - rename queryPtrace to setPtracer - add a kdeinit option in crashtest REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. In D18245#418656 , @thiago wrote: > This last backtrace does not show anything stuck. Thread 1 was actively running, in fact (it's inside of malloc). > > Also note your testcase has no window, since the widget is

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. A backtrace where it gets stuck in the destructor of QApplication. (gdb) info thread Id Target Id Frame * 1Thread 0x736a2f80 (LWP 6015) "testqt" 0x76906f6d in __pthread_timedjoin_ex

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. The problem does not seem to be specific to DrKonqi. Once DrKonqi and KDevelop are stuck, any Qt program may have problems starting or quitting. A minimal example #include #include int main(int argc, char **argv) { QApplication

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a subscriber: ossi. croick added a comment. I dug in the history of KCrash and realized, that closing all the file descriptors was introduced (7bbf112e5e97d40b9a4f9fdd167b064a1019843b ) to make the X11

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. The following steps allow creating the backtraces. Simply attaching to KDevelop does not work, since that sends a SIGSTOP to all threads (and releases the dead lock). Attaching to DrKonqi after closing the dialog does not work since the process already is defunct:

D18245: Create QApplication in a scope to work around possible deadlock

croick added a comment. In D18245#418708 , @thiago wrote: > I repeat: there's no indication in the backtrace that it is stuck. What's your evidence that it is? You wrote an application that shows nothing and never exits. Now it showed nothing

D18245: Create QApplication in a scope to work around possible deadlock

croick updated this revision to Diff 52524. croick retitled this revision from "[DrKonqi] Create QApplication in a scope to fix possible deadlock" to "Create QApplication in a scope to work around possible deadlock". croick edited the summary of this revision. croick added a comment. - add

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. A few screenshots: Before the patch: - `ShowDebugButton=false` in drkonqirc F6567349: beforepatch_1.png - `ShowDebugButton=true` in drkonqirc F6567353: beforepatch_2.png

D11235: Request change of ptrace scope from KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R871:9f3cfcff960c: Request change of ptrace scope from KCrash (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11235?vs=49717=50215#toc REPOSITORY R871 DrKonqi CHANGES SINCE

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick updated this revision to Diff 59394. croick added a comment. Rebase to current master REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=29245=59394 BRANCH nicebutton REVISION DETAIL https://phabricator.kde.org/D11234 AFFECTED FILES

D18245: Create QApplication in a scope to work around possible deadlock

croick updated this revision to Diff 59395. croick added a comment. Rebase to current master REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18245?vs=52524=59395 BRANCH scopedqapp REVISION DETAIL https://phabricator.kde.org/D18245 AFFECTED FILES

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick updated this revision to Diff 59627. croick marked 5 inline comments as done. croick added a comment. - Fix code style. - Save state of the debug button in a member variable. - Resize the dialog after inserting/removing the debug button. REPOSITORY R871 DrKonqi CHANGES SINCE

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. Thanks for looking into this :D Past self obviously still had to read the style guide and tried not to change header files. I took your commit cc640cea as an example to resize the

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick updated this revision to Diff 61377. croick added a comment. - more style fixes - do not adjustSize after adding the button, since that is redundant now REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=59627=61377 BRANCH nicebutton

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick marked 2 inline comments as done. croick added a comment. In D11234#492200 , @sitter wrote: > Could you explain your thinking behind the adjustSize call please? The way I see it the window should scale up as necessary if the size hints

D11234: [DrKonqi] Show debug button when KDevelop session is running

This revision was automatically updated to reflect the committed changes. Closed by commit R871:95b6b8b613c2: Show debug button when KDevelop session is running (authored by croick). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=61377=61456

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. Thanks for your review. It was the last in a series of patches and I'll try to advertise the whole "Debug your KDE application with KDevelop"-feature somewhere. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick,

D18245: Create QApplication in a scope to work around possible deadlock

croick abandoned this revision. croick added a comment. I can no longer reproduce the deadlock, so I'll abandon this. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18245 To: croick, sitter, #kdevelop Cc: dfaure, thiago, ossi, plasma-devel, LeGast00n, jraleigh,