D25198: KCM Colors : port color scheme state management to KConfigXT

crossi added a comment. In D25198#559853 , @broulik wrote: > Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25220

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi updated this revision to Diff 69467. crossi added a comment. make access to selectedStyle more consistent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25220?vs=69466=69467 REVISION DETAIL https://phabricator.kde.org/D25220 AFFECTED

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi updated this revision to Diff 69468. crossi added a comment. missed that one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25220?vs=69467=69468 REVISION DETAIL https://phabricator.kde.org/D25220 AFFECTED FILES kcms/style/kcmstyle.cpp

D25198: KCM Colors : port color scheme state management to KConfigXT

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25198 AFFECTED

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi updated this revision to Diff 69053. crossi added a comment. Remove assignement to currentIndex. Add a C++ bypass to setCurrentIndex without breaking the binding. REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi updated this revision to Diff 69055. crossi added a comment. Missing const ref, rename private header accordingly REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25000?vs=69053=69055 REVISION DETAIL

D25198: KCM Colors : port color scheme state management to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:199bbe20d72c: KCM Colors : port color scheme state management to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25290: KCM launchfeedback : port to KConfig XT

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Simple KCM, all settings' states are automatically handled thanks

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi added inline comments. INLINE COMMENTS > ervin wrote in kcmstyle.cpp:98 > Space before &, not after. Will fix > ervin wrote in kcmstyle.cpp:245 > AFAICT this is the only place where m_effectsDirty is read. So I think you > can remove that flag altogether, which should bring further

D25274: KCM LookAndFeel : port to KConfig XT

crossi updated this revision to Diff 69643. crossi added a comment. misspelling REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25274?vs=69642=69643 REVISION DETAIL https://phabricator.kde.org/D25274 AFFECTED FILES

D25274: KCM LookAndFeel : port to KConfig XT

crossi updated this revision to Diff 69642. crossi added a comment. Add kcfg files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25274?vs=69641=69642 REVISION DETAIL https://phabricator.kde.org/D25274 AFFECTED FILES

D25274: KCM LookAndFeel : port to KConfig XT

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25274 AFFECTED

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi updated this revision to Diff 69635. crossi added a comment. style + consistency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25220?vs=69468=69635 REVISION DETAIL https://phabricator.kde.org/D25220 AFFECTED FILES

D25290: KCM launchfeedback : port to KConfig XT

crossi added inline comments. INLINE COMMENTS > ervin wrote in main.qml:33 > Or... but that's more work and I'd say it should come in another patch on top > of that one. We migrate the config file to use an enum all the way. This > boolean trap exists in the config after all. Added enum to

D25290: KCM launchfeedback : port to KConfig XT

crossi updated this revision to Diff 69794. crossi added a comment. Add enum declaration to make boolean settings in qml a bit more readable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25290?vs=69745=69794 REVISION DETAIL

D25792: Add notifiers to workspace options kcfg

crossi added a comment. Thanks @davidedmundson for spotting this regression. Actually, only AnimationDurationFactor should notify. From D25586 See kcms/workspaceoptions/workspaceoptions.cpp line 221. REPOSITORY R119 Plasma Desktop REVISION

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

crossi created this revision. crossi added reviewers: Plasma, ervin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Following D25792 and D25586

D24846: Port kcm icons to kconfigxt

crossi added inline comments. INLINE COMMENTS > iconsmodel.cpp:29 > #include > +#include > include not used REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24846 To: bport, ervin, mart, #plasma, crossi Cc: broulik, plasma-devel, LeGast00n,

D26045: Add immutability to KCM Icons

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:55 > Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff > Marco fixed a while back? Yes it should. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To:

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality. - At initialization, the current theme is not selected in the grid view. - When settings a theme for deletion, it does not activate the apply button

D26052: KCM Cursor Theme : Use ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > kcmcursortheme.cpp:367 > { > m_settings->save(); > +setPreferredSize(m_settings->cursorSize()); Now you should simply call ManagedConfigModule::save(); instead > kcmcursortheme.cpp:384 > { > m_settings->load(); > +

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY For KCM Notification, allow to register the generated

D26048: KCM Notification port to ManagedConfigModule

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Require D26046 and D26047

D24925: KCM KSplash port to ManagedConfigModule

crossi updated this revision to Diff 68734. crossi added a comment. Remove unnecessary override REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68699=68734 REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILES

D24916: KCM style : fix combobox that weren't updated after user made change

crossi updated this revision to Diff 68748. crossi added a comment. refactor code into a function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24916?vs=68670=68748 REVISION DETAIL https://phabricator.kde.org/D24916 AFFECTED FILES

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Binding with combobox index was broken REPOSITORY R858 Qt Quick Controls 2:

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi added inline comments. INLINE COMMENTS > ervin wrote in ComboBox.qml:92 > What about that one? :-) Yes, this one breaks as well. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25000 To: crossi, #plasma, ervin, mart, bport, broulik

D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

crossi updated this revision to Diff 68416. crossi added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. restore blank lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24819?vs=68405=68416 REVISION DETAIL

D24730: Port KCMSplashScreen to KConfigXT

crossi updated this revision to Diff 68450. crossi added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. remove unnecessary emit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24730?vs=68130=68450 REVISION DETAIL

D24925: KCM KSplash port to ManagedConfigModule

crossi updated this revision to Diff 68699. crossi added a comment. setNeedsSave() not needed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68682=68699 REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILES

D24925: KCM KSplash port to ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > crossi wrote in kcm.cpp:148 > it needs an explicit call, like load() and save() My bad. setNeedsSave() is no longer needed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To: crossi, #plasma, ervin, mart,

D24925: KCM KSplash port to ManagedConfigModule

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED

D24923: Use more return early

crossi resigned from this revision. crossi added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > jgrulich wrote in networkmodel.cpp:402 > I think this is a valid Qt coding style, it was just my obsession to use > curly braces everywhere, even for single line

D24925: KCM KSplash port to ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:148 > doesn't managed module take care of this? it needs an explicit call, like load() and save() REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To: crossi, #plasma, ervin,

D24923: Use more return early

crossi requested changes to this revision. crossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:402 > // Check whether the connection is already in the model to avoid > duplicates, but this shouldn't happen > -if

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY KConfig XT does not store default values in conf files. KCM Style applying

D24917: KCM Style port to KConfigXT

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES kcms/style/CMakeLists.txt

D24916: KCM style : fix combobox that weren't updated after user made change

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. TEST PLAN Inside Configure Icons and Toolbars popup menu, change some value in combobox, hit

D24917: KCM Style port to KConfigXT

crossi updated this revision to Diff 68978. crossi added a comment. Move some duplicated code to a function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24917?vs=68671=68978 REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES

D24730: Port KCMSplashScreen to KConfigXT

crossi updated this revision to Diff 68532. crossi added a comment. Use both key and name tag in entry to generate pretty signals' name. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24730?vs=68450=68532 REVISION DETAIL

D24820: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package

This revision was automatically updated to reflect the committed changes. Closed by commit R119:550a9a25d628: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package (authored by crossi). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R119

D24729: remove unnecessary ; + add const to getter + typo in Roles declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c402ff93c219: remove unnecessary ; + add const to getter + typo in Roles declaration. (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24730: Port KCMSplashScreen to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:77b27da43cd2: Port KCMSplashScreen to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24730?vs=68532=68534 REVISION DETAIL

D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1b857f927037: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method… (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24731: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd1f77d5dbff: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package (authored by crossi). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY

D24729: remove unnecessary ; + add const to getter + typo in Roles declaration.

crossi created this revision. crossi added reviewers: Plasma, ervin, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24729 AFFECTED FILES

D24916: KCM style : fix combobox that weren't updated after user made change

crossi updated this revision to Diff 68755. crossi added a comment. qml style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24916?vs=68748=68755 REVISION DETAIL https://phabricator.kde.org/D24916 AFFECTED FILES

D25395: Make avatar icon dpr aware aka HiDPI rendered

crossi added inline comments. INLINE COMMENTS > accountmodel.cpp:545 > +void AccountModel::setDpr(qreal dpr) { > +this->dpr = dpr; > +} See my previous comment, 'this->' prefix won't be necessary. > accountmodel.h:95 > AutomaticLoginSettings m_autoLoginSettings; > +qreal

D25522: KCM Colors : take into account immutable property

crossi updated this revision to Diff 70350. crossi added a comment. fix style issue REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25522?vs=70294=70350 REVISION DETAIL https://phabricator.kde.org/D25522 AFFECTED FILES kcms/colors/colors.cpp

D25525: KCM Style : take into account immutable properties

crossi updated this revision to Diff 70351. crossi added a comment. adjustment since view.enabled also show disabled look and feel REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25525?vs=70297=70351 REVISION DETAIL

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:561401636f7d: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound… (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25274: KCM LookAndFeel : port to KConfig XT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:613d5e12871c: KCM LookAndFeel : port to KConfig XT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25274?vs=69643=70280 REVISION

D25290: KCM launchfeedback : port to KConfig XT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ff86f0abb454: KCM launchfeedback : port to KConfig XT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25290?vs=69794=70281 REVISION

D25526: KCM launch feedback : take into account immutable properties

crossi updated this revision to Diff 70300. crossi added a comment. blank line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25526?vs=70298=70300 REVISION DETAIL https://phabricator.kde.org/D25526 AFFECTED FILES

D25522: KCM Colors : take into account immutable property

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25522 AFFECTED FILES kcms/colors/colors.cpp kcms/colors/colors.h

D25523: KCM LookAndFeel : take into account immutable property

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25523 AFFECTED FILES kcms/lookandfeel/package/contents/ui/main.qml

D25525: KCM Style : take into account immutable properties

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Depends on D25520 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25524: KCM KSplash : take into account immutable property

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25524 AFFECTED FILES kcms/ksplash/package/contents/ui/main.qml To:

D25526: KCM launch feedback : take into account immutable properties

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25526 AFFECTED FILES kcms/launch/package/contents/ui/main.qml To:

D25526: KCM launch feedback : take into account immutable properties

crossi updated this revision to Diff 70304. crossi added a comment. Make the propery readonly, boolean condition to repeat the same pattern enabled: !immutable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25526?vs=70300=70304 REVISION DETAIL

D25526: KCM launch feedback : take into account immutable properties

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:45 > Imho this is confusing. > The property should be `readonly property bool cursorImmutable: > kcm.setings.immutable && ..` and then this would be `enabled: !immutable` Thanks for pointing this. Reworked the property

D25586: KCM WorkspaceOptioins port to KConfigXT. Take into account immutable properties

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25586: KCM WorkspaceOptioins port to KConfigXT. Take into account immutable properties

crossi updated this revision to Diff 70482. crossi added a comment. typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25586?vs=70480=70482 REVISION DETAIL https://phabricator.kde.org/D25586 AFFECTED FILES kcms/workspaceoptions/CMakeLists.txt

D25522: KCM Colors : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:298611977e3b: KCM Colors : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25522?vs=70350=70556

D25523: KCM LookAndFeel : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:277bb04e7455: KCM LookAndFeel : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25525: KCM Style : take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a7089ca61db2: KCM Style : take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25525?vs=70351=70559

D25524: KCM KSplash : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dd9a6da45f9e: KCM KSplash : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25524?vs=70296=70558

D25526: KCM launch feedback : take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b2383cc77f6: KCM launch feedback : take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in kpropertywriter_p.h:26 > Throwing out another option > > class KPropertyWriter : public QObject, public QQmlPropertyValueSource > { > Q_INVOKABLE bool writeProperty(QVariant value); > } > >

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

This revision was automatically updated to reflect the committed changes. Closed by commit R135:9313c877f55f: Fix issue when there is no WidgetStyle value in kdeglobals (authored by crossi). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D24916: KCM style : fix combobox that weren't updated after user made change

crossi abandoned this revision. crossi added a comment. Fix by D25000 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24925: KCM KSplash port to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:332226003b04: KCM KSplash port to ManagedConfigModule (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68734=69090 REVISION

D24917: KCM Style port to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbed4b3efcdb: KCM Style port to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24917?vs=68978=69089 REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

This revision was automatically updated to reflect the committed changes. Closed by commit R858:35fae4b55fc8: Do not assign combobox currentIndex as it breaks binding. (authored by crossi). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25290: KCM launchfeedback : port to KConfig XT

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:33 > Yes, I would prefer all of this to be abstracted away from the QML, the > `checked` bindings area also quite messy I agree it's a bit tricky, we have a kind of enum choice written as a binary representation in the

D25290: KCM launchfeedback : port to KConfig XT

crossi updated this revision to Diff 69745. crossi added a comment. Use proper signal handler & Fix typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25290?vs=69683=69745 REVISION DETAIL https://phabricator.kde.org/D25290 AFFECTED FILES

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. In D26039#579546 , @davidre wrote: > - Only move to the next theme if the current selected one is marked for deletion > > FYI I could spot this same bug in the colors kcm. Will fix after this Looks good to

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Allow the KCM Notifications to query the immutable

D26083: KCM Notifications : disable settings that are immutable

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Need D26082 to work. TEST

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi added inline comments. INLINE COMMENTS > broulik wrote in settings.h:343 > Not a fan of this becoming public API Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to register them in the KCM's ConfigModule ? REPOSITORY R120 Plasma Workspace

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. In D26039#579253 , @davidre wrote: > - Reinstate isSaveNeeded > - Fix initial index and pendingDeletion I can confirm these issue are fixed. Still one concern, when setting an item for pending deletion, it

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

crossi added a comment. some nitpicks, otherwise looks good. INLINE COMMENTS > componentchooser.h:42 > virtual void defaults()=0; > +virtual bool isDefaults() { > +return false; Can you make it const please. > componentchooserbrowser.cpp:110 > > -const auto = >

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea08681efe5e: libnotificationmanager : deprecate Settings ctor that takes a config (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 74021. crossi added a comment. Following discussion with @ervin and @broulik, export generated KConfig settings, remove singleton option. The KCM will have its own KConfig settings' instance like other KCMs. REPOSITORY R120 Plasma Workspace CHANGES

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 74023. crossi added a comment. Remove unneeded forward declaration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=74021=74023 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES

D26048: KCM Notification port to ManagedConfigModule

crossi updated this revision to Diff 74028. crossi added a comment. Following new approach in D26047 , also taking into immutability is much more straightforward. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26048: KCM Notification port to ManagedConfigModule

crossi added a comment. In D26048#598157 , @ervin wrote: > Wondering, do we still need "settings"? I guess it's for the per-app settings? Yes, for app specific settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26048: KCM Notification port to ManagedConfigModule

crossi updated this revision to Diff 74037. crossi added a comment. Not necessary anymore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26048?vs=74028=74037 REVISION DETAIL https://phabricator.kde.org/D26048 AFFECTED FILES

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 76380. crossi added a comment. constexpr REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=76379=76380 REVISION DETAIL https://phabricator.kde.org/D26834 AFFECTED FILES

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 76379. crossi added a comment. constexpr instead of static REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=74116=76379 REVISION DETAIL https://phabricator.kde.org/D26834 AFFECTED FILES

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 77068. crossi added a comment. rename group attribute to parentGroupName REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=76834=77068 REVISION DETAIL https://phabricator.kde.org/D27155 AFFECTED FILES

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi added a comment. @broulik any thoughts on this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26834 To: crossi, ervin, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added inline comments. INLINE COMMENTS > bport wrote in style_widgetstyle_default_breeze.pl:8 > This will fix only for Breeze theme > This will fix existing case but we also need to fix the root cause (i.e. how > we end up with a lowercase name). Root cause was fixed by D27407

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 76834. crossi added a comment. use parentGroup attribute REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=75090=76834 REVISION DETAIL https://phabricator.kde.org/D27155 AFFECTED FILES

D27155: libnotificationmanager : add app-specific kconfig settings

crossi created this revision. crossi added reviewers: ervin, broulik, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Provide a kcfg for app-specific notifications with kconfig. Require D27059

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 75090. crossi added a comment. Remove specific default values, will rely on shipped settings. Fix comment at EOL that makes the entry not read. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi created this revision. crossi added reviewers: Plasma, ervin, broulik, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY App-specific notifications' behavior are now managed with KConfigXT.

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

crossi accepted this revision. crossi added a comment. This revision is now accepted and ready to land. Both patch applied and tested, it works for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27073 To: broulik, #plasma, crossi, ervin Cc: plasma-devel,

  1   2   >