D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > breezestyle.cpp:4474 > painter->fillRect(iconRect, > option->palette.brush(QPalette::Base)); > proxy()->drawItemPixmap(painter, iconRect, Qt::AlignCenter, >

D28703: Make KAccess a regular startup application

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please double check wayland startup is ok. The kcminit had a X-KDE-OnlyShowOnQtPlatforms=xcb; guard Orca situation should be fine

D28692: Don't leak DrKonqi dialog / fix crash on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R871:b2ebd8f2ca33: Dont leak DrKonqi dialog / fix crash on wayland (authored by davidedmundson). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28692?vs=79675=79695

D28698: Save unneeded DBus roundtrip

davidedmundson added a comment. > (the ugly notification which pops on the top of screen) when Plasma notifications are not ready yet Plasma ships a trick for that which means that we always get plasma notifications when plasma is installed regardless of if it's running. REPOSITORY

D28692: Don't leak DrKonqi dialog / fix crash on wayland

davidedmundson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.cpp:67 > Adding a qApp as a parent here? I can't, qwidgets only take qwidgets as parents. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28692 To: davidedmundson, #plasma Cc:

D28692: Don't leak DrKonqi dialog / fix crash on wayland

davidedmundson added a comment. Thread 1 "drkonqi" hit Breakpoint 1, 0x7f0664dd8570 in QtWaylandClient::QWaylandDisplay::handleWindowDeactivated(QtWaylandClient::QWaylandWindow*)@plt () from /opt/qt5/plugins/wayland-shell-integration/libxdg-shell.so (gdb) bt #0

D28692: Don't leak DrKonqi dialog / fix crash on wayland

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY When a QApplication is in it's destructor it calls window->destroy() on

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

Is a failure, caused by some baloo thing.

D28676: Drop kdeinit from ksmserver

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5ea6a05ebb8e: Drop kdeinit from ksmserver (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28676?vs=79631=79637 REVISION

D28626: [plasma-session] Don't prematurely cache systemEnvironemnt

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:4e681fdb580f: [plasma-session] Dont prematurely cache systemEnvironemnt (authored by davidedmundson). REPOSITORY

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

davidedmundson added a comment. > Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet. I don't follow, why don't we just disable the screencasting thing if we don't have pipewire. I don't see why we would affect the rest. REPOSITORY R838

D28676: Drop kdeinit from ksmserver

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY As we don't launch with kinit, no point ksmserver linking against it TEST

D28627: WIP: Made panel opaque on maximized window

davidedmundson added a comment. > or is the window.isMaximized implementation bad in win? The problematic part of this patch is that whenever any property on any window changes we're checking all items. We only want to: - check when isMaximised potentially changes - only

D28627: WIP: Made panel opaque on maximized window

davidedmundson requested changes to this revision. davidedmundson added a comment. Ok, so the logic is - the goal is to blend in. If you're not showing the desktop, you can't blend in to it. I can at least understand the thought process. --- Code wise, this needs a lot of work.

D28652: [Cursors] Remove Resolution Dependant option

davidedmundson added a comment. Other related question. What happens if we specify the size as being 24, but the icon set doesn't have that? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson, ngraham Cc:

D28652: [Cursors] Remove Resolution Dependant option

davidedmundson added a comment. what happens to users that have 0 written out in their config file already? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven, davidedmundson Cc: plasma-devel, kde-doc-english, Orage, LeGast00n,

Re: Making PipeWire required for xdp-kde

Check the KDE CI has everything before doing that. You may also find kde-distro-packagers a better ML to ask to find real world problems. >From the plasma side, go for it. David

D28214: Add background portal

davidedmundson added inline comments. INLINE COMMENTS > background.cpp:165 > +qCDebug(XdgDesktopPortalKdeBackground) << "enable: " << enable; > +qCDebug(XdgDesktopPortalKdeBackground) << "commandline: " << > commandline; > +qCDebug(XdgDesktopPortalKdeBackground) << "

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Failing!

*18:17:26* /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/applets/taskmanager/plugin/backend.cpp:27:10: fatal error: 'KNotificationJobUiDelegate' file not found*18:17:26* #include should be just a case of waiting for knotifications to sync.

D28627: WIP: Made panel opaque on maximized window

davidedmundson added a comment. Why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28626: [plasma-session] Don't prematurely cache systemEnvironemnt

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY plasma-session goes to great lengths to make sure we have the latest env

D28616: Split KWin startup out of KSMServer

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Direction is beautiful, so much red! INLINE COMMENTS > logout.cpp:229 > +auto saveSessionCall = > m_kwinInterface->aboutToSaveSession(currentSession());

D28368: [krunner] Avoid (a third!) pointless config parse

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6dc04ef0adec: [krunner] Avoid a uneeded pointless config parse (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28366: [krunner] Don't set the position three times in a row

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2d372d3dfd1: [krunner] Dont set the position three times in a row (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28365: [krunner] Avoid (another) pointless config load on start

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1c48e351c646: [krunner] Avoid reparsing the config load on start (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28364: [krunner] Avoid a config pointless extra config load

This revision was automatically updated to reflect the committed changes. Closed by commit R120:23534a3b4f6e: [krunner] Avoid a config pointless extra config load (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28154: Add users KCM

davidedmundson added a comment. > Drop group stubs; there will be bad UX because two different polkit actions (and thus two dialogs backtoback) would be needed for apply with groups Don't rule out the obvious other option there - changing accountsservice. It already has all the code,

D27576: Kill Runner: Move config keys to new file

davidedmundson added a comment. > Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch). git config user.name then git commit --amend --author "Your Name " REPOSITORY R120 Plasma

D25549: [kcms/keyboard] Port away from KToolInvokation

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Changed my mind. This is a kcm, so having a startup notification for kcm wouldn't bring a lot. Also you're not going to have a different env between kcmshell5 and

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 79106. davidedmundson added a comment. Add xembedsniproxy and gdbusmenuproxy REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78922=79106 BRANCH master REVISION DETAIL

D28487: Upstream of the ksysguard based plasmoids

davidedmundson added inline comments. INLINE COMMENTS > applet.h:29 > > +#include "scriptengine.h" > Can we split all the changes in shell/* REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: davidedmundson, mmustac, ahiemstra,

Re: notifications for non-plasmashell components

On Wed, Apr 1, 2020 at 10:13 AM Bhushan Shah wrote: > > Morning, > > I was looking into notifications for plasma mobile lockscreen from last > few days, current set of patches are in kscreenlocker, plasma-workspace, > and plasma-phone-components. > > - https://phabricator.kde.org/D28455 > -

D28333: Add a new daemon for stats monitoring

davidedmundson updated this revision to Diff 78977. davidedmundson added a comment. Register bus name after loading plugins REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=78658=78977 BRANCH master REVISION DETAIL

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Seems pretty simple and sensible. 1 minor fixup needed. INLINE COMMENTS > server_p.cpp:234 > +hints, notification.timeout()); > +

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

davidedmundson added a comment. > @davidedmundson - is QIcon(QImage(...)) save? For the way it's used in the runner, yes. > Before this patch the icon was created in the BookmarkMatch::asQueryMatch method which was called from the secondary thread. Then my comment is happily

D28455: add dbus interface to the greeter

davidedmundson added a comment. I'd say we go for the simplest solution +++ Given we have MPRIS on here, if we were to do any DBus lockdowns we would almost certainly want to use xdg-dbus-proxy, at which point this would continue to work. INLINE COMMENTS > greeterapp.cpp:139 > +

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 78922. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78917=78922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28305 AFFECTED FILES

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 78917. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78541=78917 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28305 AFFECTED FILES

D28422: WIP: Use ecm_install_configured_files macro

davidedmundson updated this revision to Diff 78912. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28422?vs=78854=78912 BRANCH configured_install REVISION DETAIL https://phabricator.kde.org/D28422

D28428: [screenlocker] listen to notifications from the notification server

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We've added a DBus interface to the screensaver host; ksmserver or kwin respectively. That receives the notification and then using a different API over wayland,

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

davidedmundson added a comment. QIcon isn't thread safe. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added a comment. looks good to me, but lets delay merging till the relevant other parts are ready. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28424 To: hchain, davidedmundson, broulik, dfaure, ngraham, meven Cc: plasma-devel, Orage,

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:43 > Do we rather want it in libexec since it's not meant to be run by the user? There's a bit of a challenge there. We need this executable to be found by the xdg generator. libexec seems to be all over

D28422: WIP: Use ecm_install_configured_files macro

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY DO NOT MERGE YET. Uploaded to show intended usage whilst discussing API. TEST PLAN N/A REPOSITORY R120

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

davidedmundson added a comment. As a question, rather than a researched proposal, is it better to check for the pin in? systemtray / PlasmoidItem.qml Connections { target: applet onExpandedChanged: { INLINE COMMENTS > main.qml:158 > + > +

D28339: [kapplymousetheme] Avoid loading QPT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aa2212e25c92: [kapplymousetheme] Avoid loading QPT (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28339?vs=78640=78800

D28369: [runners/recentdocuments] disable executables or .desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:97bf7d777e56: [runners/recentdocuments] disable executables or .desktop files (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

davidedmundson added a comment. Be careful about mixing terms here. This absolutely does not change "the timezone". This changes what the applet shows. It is super super important that if a user travels to another country even for a vacation they update the system timezone. The

D28383: Add PageRouter component

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This needs way more description and explanation of the problem it's trying to solve. REPOSITORY R169 Kirigami REVISION DETAIL

D28369: [runners/recentdocuments] disable executables or .desktop files

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's possible to have a .desktop file in your recent documents list as you

D28368: [krunner] Avoid (a third!) pointless config parse

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We are krunner, our default config will be krunnerrc, we can load the

D28366: [krunner] Don't set the position three times in a row

davidedmundson updated this revision to Diff 78708. davidedmundson retitled this revision from "[krunner] Don't set the position twice in a row" to "[krunner] Don't set the position three times in a row". davidedmundson edited the summary of this revision. davidedmundson added a comment.

D28366: [krunner] Don't set the position twice in a row

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY loadConfig does this on the line belwo REPOSITORY R120 Plasma Workspace

D28365: [krunner] Avoid (another) pointless config load on start

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D28364: [krunner] Avoid a config pointless extra config load

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN #plasma REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D28333: Add a new daemon for stats monitoring

davidedmundson updated this revision to Diff 78658. davidedmundson added a comment. Drop object library, it was too cool for some cmake versions REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=78625=78658 BRANCH master REVISION DETAIL

D28341: Use new simpler way to disable session management in services

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9be7dedb87ea: Use new simpler way to disable session management in services (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28341: Use new simpler way to disable session management in services

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D28339: [kapplymousetheme] Avoid loading QPT

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Cuts time down significantly. Ideally we should kill this binary, but

Qt5.14 - CI Updated

Plasma 5.19 will depend on Qt5.14 Thanks to our amazing sysadmins, CI has been updated. We can now go mental using new API \o/ Please remember to bump the QT_MIN_VERSION when a repo changes. David

D28333: Add a new daemon for stats monitoring

davidedmundson added inline comments. INLINE COMMENTS > nvidiaplugin.json:1 > +{ > +"KPlugin": { To address this, I don't use the json at all, as it's itself a factory class which provides metadata. But I couldnt' get rid of it without error. REPOSITORY R106 KSysguard REVISION DETAIL

D28333: Add a new daemon for stats monitoring

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY ksysguardd, whilst good, has a few problems The code is a bit archaic,

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

davidedmundson added inline comments. INLINE COMMENTS > touchpad.qml:607 > + > +from: 1 > +to: 10 So I can only make it faster? Is that sensible? > touchpad.qml:615 > + > +onValueChanged: { > +if (touchpad != undefined && enabled &&

D28232: [SpellChecking KCM] Fix the build

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I could rework the patch to make it conditional on 5.14 and keep the iterator-based ctors as-is. May as well merge this and just revert when we're able to use 5.14

D28306: Make the hover state clarifying, but not main

davidedmundson added a comment. @ngraham the default theme doesn't change with this patch. I believe there are no plans to do so. INLINE COMMENTS > Task.qml:331 > +if (isHovered) > +return TaskTools.taskPrefix(basePrefix + >

D28300: Opt into KIO changes for cgroup management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b6a8662dbd91: Opt into KIO changes for cgroup management (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28300?vs=78527=78547

D28305: WIP: Systemd Startup

davidedmundson added inline comments. INLINE COMMENTS > ahiemstra wrote in CMakeLists.txt:44 > This pattern is repeated multiple times, maybe we should make a macro out of > it? Like `install_systemd_service_file(source_file)` that's a good idea > apol wrote in ksmserver.service.cmake:8 > Why

D28305: WIP: Systemd Startup

davidedmundson added a comment. In terms of testing, you will need: - this patch - to rerun ./login-sessions/install-sessions.sh - cherry-picked the relevant repos in kded, kwin, kactivitymanagerd This will give you a basic session, for everything , you'll also want

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 78541. davidedmundson added a comment. add comments explaining some code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78539=78541 BRANCH master REVISION DETAIL

D28305: WIP: Systemd Startup

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This brings numerous advantages such as: - easier admin configuration with drop-ins, overrides a nd

D28300: Opt into KIO changes for cgroup management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It was safeguarded by an environment variable so we don't retroactively

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

davidedmundson added inline comments. INLINE COMMENTS > globalshortcuts.cpp:42 > editor = new KGlobalShortcutsEditor(this, > KShortcutsEditor::GlobalAction); > -connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool))); > +connect(editor, ::changed, this, >

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

Briefly investigated, it seems another false positive of frameworks being out of sync which will resolve itself. David

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson added a comment. My fault, I'll fix it REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson updated this revision to Diff 78368. davidedmundson added a comment. Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=78336=78368 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D28172: [applets/digital-clock] Fix date sizing in vertical panel

davidedmundson accepted this revision. davidedmundson added a comment. You probably still want the elide. We have a word wrap on, so you'll only hit this elide option when the alternative is paint outside the area and just leak over other items in the system tray. That always looks

D27509: Introduce ProcessDataModel

This revision was automatically updated to reflect the committed changes. Closed by commit R111:834de9a585c6: Introduce ProcessDataModel (authored by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=78091=78346 REVISION

D28209: [applets/notes] Actually hide button row when it's not visible

davidedmundson added a comment. > Wouldn't this cause the text field to resize and shift around? Perhaps set enabled to false instead. That's something layouts do. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28209 To: ngraham, #plasma, #vdg,

D28200: Enable wrapping of error messages which use KMessageWidget

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I wonder if it makes sense to set this on the widget itself, as a sensible default. No. Not because it's a better or worse default, but because making a

Re: Drag and drop to system tray

When you say system tray, what specifically are you referring to? There are definitely no plans to support dropping files onto the org.kde.plasma.systemtray containment.

D28115: feat(kded): add a dbus method to lock current rotation

davidedmundson added a comment. How does mobile retrieve the current lockAutoRotate value? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28115 To: bshah, romangg Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. ..it made no difference REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma, kmaterka Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28134: Add ColorUtils

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. What's your intended usecase? Is Kirigami the right place? The original scope for that was "core application building blocks". INLINE COMMENTS >

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. > OK, one small wait won't kill the world, right? :) Not in a unit test. If it ends up not making a difference I'll revert. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma, kmaterka

D28183: [kioslave/desktop] Attempt at making test more robust

This revision was automatically updated to reflect the committed changes. Closed by commit R120:715be958eaa5: [kioslave/desktop] Attempt at making test more robust (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. That won't work as is because I would need to re-run const KFileItem fileItem = lister->findByUrl(destUrl); REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma Cc: kmaterka, plasma-devel,

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. Just to clarify something the failure was always on this line: > QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath)); and we saw one thing still have a ".part" suffix. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. > In theory QTRY_VERIFY should wait up to 5 seconds until condition is met. qWait(250) shouldn't change much... The big difference is that before if one spyFilesAdded is emitted after say 10ms, we'll continue immediately on with the test Whereas now

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We have an unstable test. KCoreDirLister has a timer involved set to 200ms

Re: Manner in which kde-gtk-config development is conducted

You're absolutely right that mistakes were made and have reason to be frustrated. kde-gtk-config is now maintained by new developers. Plasma has a new influx of new people which is good to see and something we need to foster carefully. Overall these new devs are doing a super job and we want to

D28154: Add users KCM

davidedmundson added a comment. > Since the new KCM's name (kcm_user) does natch the name of the old one (user_manager) this will require a change in System Settings to actually make it appear. Also for some reason it does not show up to kcmshell list: The names need to match, otherwise

D28154: Add users KCM

davidedmundson added a comment. I can't see any saving to "~/.face.icon" this is needed for legacy compatibility with other systems that don't use accounts service. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 78091. davidedmundson added a comment. cache kuser REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=78089=78091 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27509 AFFECTED

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 78089. davidedmundson added a comment. cache kuser REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=78025=78089 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27509 AFFECTED

Re: 2 kirigami fixes for a point release

>> > Kirigami seems to be rather unstable, I wonder if anything can be done to >> > improve upon that [*]. > >> One important thing seems to have been getting sloppy in those repos; >> mandatory code reviews. >> That's an easy thing to enforce, and we know it makes a huge difference to >> code. >>

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 779 - Still unstable!

This was a real breakage. It is super important, we could be preventing other people from doing any development work. Please can people be more on top of CI failures. Any failure should have someone either fix it, even if you didn't cause it, or write up an explanation of why it's not an issue.

Re: KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

I investigated this (slightly) it seems these are false positives. A new method was introduced in kcrash, that symbol is exported, then this fails to link. It implies this is just the CI system linking against an old kcrash until frameworks sync. David

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 78025. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. lambdas everywhere REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=76653=78025 BRANCH master REVISION

D28099: Show command output on unknown failure

davidedmundson added inline comments. INLINE COMMENTS > mountdialog.cpp:57 > + > +QMessageBox::critical(this, i18n("Error details"), message); > + Kded is one of the processes that shouldn't freeze, lets avoid nested event loops Some sort of box = new QMessageBox()

Re: Problems in KWayland causes by API and ABI compatibility promises

There's definitely a problem, and I think it's a lot more than just discussing location and protocol versions. My typical workflow is reading the wayland protocol in detail, and kwayland is in that awkward position where I absolutely still need to read those underlying docs and the abstraction

<    1   2   3   4   5   6   7   8   9   10   >