Re: Review Request 120040: Install kdesu under bin

On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: > > I'm a bit worried by the multitude of user and distro specific scripts that > > rely on kdesu being present :/ > > Marco Martin wrote: > to me either way it gets fixed i'm ok. > the other option is to keep it called kdesu, so it would

Re: Kioslave repos

On Wednesday 20 August 2014 11:38:12 Jonathan Riddell wrote: > On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: > >On Tue, Aug 19, 2014 at 9:49 PM, David Faure wrote: > > On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > > > On Tue, Ju

Re: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119081/#review67886 --- Ship it! much cleaner indeed - David Faure On Sept. 23

DialogNativeTest::position() breakage

eworks-de...@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel - -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.

Re: DialogNativeTest::position() breakage

On Saturday 11 October 2014 21:02:30 Marco Martin wrote: > On Saturday 11 October 2014 12:41:43 David Faure wrote: > > Can a plasma developer look into this? > > > > http://build.kde.org/job/plasma-framework_master_qt5/830/Variation=All,lab > > el =LINBUILDER/

Re: Review Request 120568: Save the default browser into the group [Default Applications]

the http scheme handler is kde-open then use KRun directly" in the kio code that looks up x-scheme-handler stuff (grep says: KRun and DesktopExecParser). - David Faure On Oct. 12, 2014, 8:40 p.m., Luc Menut wrote: > > --- >

Re: Review Request 120568: Save the default browser into the group [Default Applications]

> On Oct. 12, 2014, 8:51 p.m., David Faure wrote: > > kcms/componentchooser/componentchooserbrowser.cpp, line 102 > > <https://git.reviewboard.kde.org/r/120568/diff/1/?file=318115#file318115line102> > > > > No, I am very much against this. > > &g

Re: Review Request 120568: Save the default browser into the group [Default Applications]

Updated Oct. 12, 2014, 8:40 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-desktop > > > Description > --- > > Save the default browser by writing x-scheme-handler/http and > x-scheme-handler/https into the group [D

Re: Review Request 120565: Save the default file manager into the group [Default Applications]

tions" is obsoleted by this, I guess you're keeping it for old implementations, that's fine. Hmm, well, kservice/src/kbuildsycoca/kmimeassociations.cpp is such an "old" implementation, it doesn't read Default Applications yet :-) That's something else you migh

Re: Review Request 120564: Write default file manager into mimeapps.list in XDG_CONFIG_HOME

account? I don't have time to submit all your patches :-) https://techbase.kde.org/Contribute/Get_a_Contributor_Account - David Faure On Oct. 12, 2014, 5:48 p.m., Luc Menut wrote: > > --- > This is an automatically genera

Re: Review Request 120569: Save the default email client into the group [Default Applications]

g settings (the EmailClient and the x-scheme-handler/mailto. - David Faure On Oct. 12, 2014, 8:43 p.m., Luc Menut wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Fwd: Plasma Framework problems

the current > master, 5.3 status plus one comit, or..? Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. Sorry for the delay. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mai

Re: Fwd: Plasma Framework problems

me for urgent requests... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Fwd: Plasma Framework problems

On Thursday 23 October 2014 13:20:06 David Edmundson wrote: > On Thu, Oct 23, 2014 at 9:33 AM, David Faure wrote: > > On Monday 20 October 2014 02:52:58 David Edmundson wrote: > > > >Give me the sha1 to cherry-pick and I&#x

Re: KPackage framework

in indexing (and indexing tool) since if it doesn't depend from > kservice it should be completely independent from it Sounds like depending on kcoreaddons (if the plugin indexing can go there) would be better than duplicating the whole thing. -- David Faure, fa...@kd

Re: KPackage framework

On Monday 22 December 2014 10:21:21 Marco Martin wrote: > On Saturday 20 December 2014, David Faure wrote: > > > in the branch mart/kpluginmetadata there is an experiment in porting > > > away > > > from kservice, tough if i go all the way it should have a complet

Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

s.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 Diff: https://git.reviewboard.kde.org/r/121718/diff/ Testing --- Compiling without qt5 webkit. Thanks, David Faure ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review72659 --- On Dec. 28, 2014, 6:16 p.m., David Faure wrote: > >

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

found) REVIEW: 121718 Diffs (updated) - CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 Diff: https://git.reviewboard.kde.org/r/121718/diff/ Testing --- Compiling without qt5 webkit. Thanks, David

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

Diffs - CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 Diff: https://git.reviewboard.kde.org/r/121718/diff/ Testing --- Compiling without qt5 webkit. Thanks, David Faure ___ P

Re: Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121882/#review73281 --- Ship it! Ship It! - David Faure On Jan. 6, 2015, 3:05 p.m

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

Qt should be taking care of - David Faure On Jan. 21, 2015, 4:57 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: KF 5.8 changelog

On Friday 13 March 2015 09:29:44 David Faure wrote: > Plasma framework > > * Fix plasmapkg2 for translated systems > * Improve tooltip layout > * Make it possible to let plasmoids to load scripts outside the plasma > package > ... Plasma-framework developers: this &q

Re: KF 5.8 changelog

t; having those entries on any commit. Every bugfix (compared to the previous release, not for commits from the day before) can matter to users of the frameworks. Having them in the changelog is IMHO useful. So I agree, it's not "every commit", but it's not "major featur

Re: Review Request 123131: Port kio_man away from kdelibs4support

> On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: > > man/kio_man.cpp, line 242 > > > > > > Not correct, this returns only user configured list of languages, > > whereas it previously returned the full list. >

Re: Review Request 123131: Port kio_man away from kdelibs4support

fficiently rare that we > can just add "@deprecated use > `KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, > QStandardPaths::GenericDataLocation).groupList()` instead" to > KLocale::languageList()? > > David Faure wrote: > Sounds to m

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

> On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: > > autotests/globaltest.cpp, line 96 > > > > > > This should be (1).txt? > > Ashish Bansal wrote: > imho if my any file starts with ".", that's my dot fi

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

for that in QMimeDatabase, it can return the mimetype and even the known suffix without any iteration needed, see QMimeDatabase::suffixForFileName. - David Faure On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: > > --- > This is an autom

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

tps://git.reviewboard.kde.org/r/123224/#comment5> basename += src/core/global.cpp (line 417) <https://git.reviewboard.kde.org/r/123224/#comment54445> QString suggestedName = (it's not used before this line, so it should be declared here; could even be &

Re: Review Request 123544: kioclient ls: properly construct QUrl.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79694 --- Ship it! Ship It! - David Faure On April 28, 2015, 6:18

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

ly written as left(start). Same for the other mid(0, ) above. The unittest will tell you if I'm wrong by one char, but I don't think so :) - David Faure On April 30, 2015, 9:05 a.m., Ashish Bansal wrote: > > --- >

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79787 --- Ship it! Ship It! - David Faure On May 2, 2015, 4:46 p.m

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

::UDSEntry::UDS_TARGET_URL, QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); This would seem safer to me, because closer to the kde4 behaviour. I'm just not sure you caught all the cases where the target url was used (e.g. properties dialog etc.) - David Faure On M

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80432 --- Ship it! Ship It! - David Faure On May 13, 2015, 7:38 p.m

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

doesn't have operator<< for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first place). I'm pretty sure that toLocal8Bit().constData() is the proper way to give a QString to cout/c

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

> On July 20, 2015, 12:32 p.m., David Faure wrote: > > This is rather surprising. How does it compile? std::cout doesn't have > > operator<< for QString, and QString's implicit conversion to char * is > > disabled by -DQT_NO_CAST_TO_ASCII (which is set,

Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

--- Logged out and back in many times :) My autostart folder got copied correctly, including symlinks Thanks, David Faure ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

://commits.kde.org/kcoreaddons/bf48030d6fec4efbfa0f8ea5a379d2250dc9da1c (just pushed now) - David Faure On July 30, 2015, 12:48 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83190 --- On July 30, 2015, 12:48 p.m., David Faure wrote: > >

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 Diff: https://git.reviewboard.kde.org/r/124534/diff/ Testing --- Logged out and back in many times :) My autostart folder got copied correctly, including symlinks Thanks, David Faure

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

531e88b4257901e890f16c23761d2c0aa538d524 Diff: https://git.reviewboard.kde.org/r/124534/diff/ Testing --- Logged out and back in many times :) My autostart folder got copied correctly, including symlinks Thanks, David Faure ___ Plasma-devel

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

marked as submitted. Review request for Plasma and Vishesh Handa. Changes --- Submitted with commit e33b582fda5588762aa50e3ad619283b97e7d758 by David Faure to branch master. Repository: plasma-workspace Description --- Commit f913e251fe6 removed this, due to a porting bug: both

Re: Review Request 123131: Port kio_man away from kdelibs4support

directory (*it_dir)? After all the current logic is to iterate over a list of languages, and see which ones do exist. Might as well just look at what exists, without starting from a possible list of languages? - David Faure On March 25, 2015, 9:17 p.m., Alex Richardson wrote

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

= isn't necessary, could just be = - David Faure On Aug. 5, 2015, 8:57 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

instance, aren't you missing an accessor in KService? OK, on the other hand, if this is the only user, then property("...") would do too, but still, compile-time checking is more robust. About ksycocathreadtest: I just pushed many fixes for it, does it pass for you now? - David Fa

Re: Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux, gcc - Build # 11 - Fixed!

e-frameworks-devel from the CC list? I'd like to split the responsibilities cleanly. Anything in the CI view "Frameworks kf5-qt5" (and stable) should come here, anything else shouldn't ;) -- David Faure, fa...@kde.org, http://www.dav

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83697 --- Ship it! - David Faure On Aug. 5, 2015, 10:41 p.m

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

(and in fact ksycoca already) do resolve aliases. - David Faure On May 13, 2015, 5:05 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

> On Sept. 7, 2015, 7:25 a.m., David Faure wrote: > > There's no need to call aliases() at all, trader queries (and in fact > > ksycoca already) do resolve aliases. And since you're calling this for one URL at a time, you don't need KFileItemActions, just

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

separate line of code for readability, but other than that, this looks good, thanks for having made and tested the change. - David Faure On Sept. 8, 2015, 3:05 p.m., Martin Klapetek wrote: > > --- > This is an automatically ge

Re: Review Request 125187: Stop requiring Frameworks 5.15

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85238 --- Ship it! Ship It! - David Faure On Sept. 12, 2015, 9:38

Re: Review Request 125187: Stop requiring Frameworks 5.15

is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Reposit

Re: Review Request 125420: Load the mimetype file lowercase name

/r/125420/#comment59356> or faster, QString::compare(mimeName, name(), Qt::CaseInsensitive) != 0 - David Faure On Sept. 27, 2015, 2:59 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 125420: Load the mimetype file lowercase name

, that this is for shared-mime-info < 1.3 So that we can remove that code, in 10 years ;) - David Faure On Sept. 28, 2015, 8:41 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, vi

plasma crash in tooltipmanager

0400907 in main (argc=1, argv=0x7fff1ba26ec8) at /d/kde/build/4/kdebase/workspace/plasma/shells/desktop/plasma_qgv_dummy.cpp:3 -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://

Re: Review Request: Libkonq support for the nepomuk search runner

al to the usage of krunner to be able to rely on kdebase-apps being > installed. it must stay in workspace. I'm out of context -- which part of libkonq is the Locations runner interested in? -- David Faure, fa...@kde.org, sponsored by Qt S

Re: Review Request: Libkonq support for the nepomuk search runner

ibkonq avoid code duplication and ensures > consistency. Yes but my question is _which_ libkonq exactly. > we also have uses for servicemenus, but that's a different topic. =) _That_ code is already factored out, please check if KonqMenuActions would do the job as it is, and then we can

Re: KDE/kdelibs/plasma

acceptable, and might carry over into > kde includes.. which arn't. Well we do it in all the rest of kdelibs (CamelCase for Qt, lowercase for kde). Not a big problem imho. -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Konqueror (ht

Re: Review Request: Libkonq support for the nepomuk search runner

see the problem with a konq-specific runner being implemented in kdebase/apps. Given that apps has a dependency on workspace, it's certainly ok to put a runner in apps that implements konq-specific stuff, isn't it? Or does it support multiple browsers? (but then, could the konq p

KDE/kdelibs

SVN commit 935291 by dfaure: Make ksycoca threadsafe. Summary of changes: - OOo design for the 4 ways to access ksycoca data (mmap, qfile, shared mem, dummy qbuffer), which also allows to have a KConfig key for choosing the technology to use. - per-thread KSycoca::self() and per-thread sycoca f

Moving code for "Open With" and ServiceMenu actions to kdelibs

s for reviewing the patch (especially the API, which I already cleaned up compared to what was in libkonq). Of course I also ported the libkonq classes to those new classes (can't remove them, for BC reasons, but they are now mere wrappers). -- David Faure, fa...@kde.org, sponsored by Qt

Re: Moving code for "Open With" and ServiceMenu actions to kdelibs

On Tuesday 05 May 2009, Allen Winter wrote: > On Tuesday 17 March 2009 4:03:03 pm David Faure wrote: > > The code for handling "open with" action/submenus and servicemenus (RMB / > > Actions / ...) > > is currently in libkonq (and used by dolphin and konqueror), bu

Re: Review Request for KWayland for inclusion in frameworks

=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/kwayland_testWaylandOutputDevice/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 123281: Avoid triggering bug 340691

e it's just confusing, as this patch shows - David Faure On April 7, 2015, 11:46 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)

copyTo" that the bug mentions, then it has to be fixed differently. - David Faure On April 7, 2015, 6:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

only difference with the other KSharedConfig::Ptr from above ("profile"). - David Faure On May 14, 2016, 6:48 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 127875: Selected state concept for icons

tps://git.reviewboard.kde.org/r/127875/#comment64730> Could q->theme() be NULL here in some cases? See https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/testReport/(root)/TestSuite/khtml_parttest/ - David Faure On May 13, 2016, 9:46 a.m., Marco Mar

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux, All, gcc - Build # 44 - Still Unstable!

void ThemeTest::loadSvgIcon() { const auto *iconTheme = KIconLoader::global()->theme(); QString iconPath; if (iconTheme) { iconPath = iconTheme->iconPath(QLatin1String("konversation.svg"), 48, KIconLoader::MatchBest); } m_svg->setImagePath(ic

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

re, making it a single method that takes care of opening both source and kde4 dest, and doing the copyTo. But if what I mean is unclear to you, just ship it and I'll do the refactoring I have in mind. - David Faure On May 16, 2016, 8:5

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

de.org/r/127918/#comment64744> simpleConfigGroup.name() could be simplified to sourceGroup :) - David Faure On May 17, 2016, 4:42 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95550 --- Ship it! Ship It! - David Faure On May 17, 2016, 5:40

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

itten as QVERIFY(!...) - David Faure On May 19, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

> On May 22, 2016, 11:49 a.m., David Faure wrote: > > Looks fine to me, except for the reasoning in the commit log. It's > > perfectly fine to reimplement an existing virtual method from a base class > > into a derived class, this doesn't break ABI. > >

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

tps://git.reviewboard.kde.org/r/128055/#comment64955> This could all be done with a single line, QDir().mkpath(packagesDirName); No need to check if it exists already, mkpath will do that for you anyway. - David Faure On May 30, 2016, 12:33 p.m., Wolfgang Bauer

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96041 --- Ship it! Ship It! - David Faure On May 30, 2016, 1:17

Re: Review Request 128519: Fix XDG_DATA_DIRS path in startkde

ex Dieter's opinion in the bug description for https://bugs.kde.org/show_bug.cgi?id=332107 (the bug is fixed, but still, I would argue with not messing with an env var if we don't need to) - David Faure On July 25, 2016, 10:18 a.m., Ni

Failing unittests

gtest fails with Qt 5.5 Guys, get fixing :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

[plasma-framework] autotests: Skip autotest that is broken with Qt 5.5

Git commit 8abeceaffd0c93028810ea12131b7fa8bcd13b12 by David Faure. Committed on 07/08/2016 at 11:25. Pushed by dfaure into branch 'master'. Skip autotest that is broken with Qt 5.5 Eike Hein said this was fixed by David Rosca in Qt >= 5.6.1. CCMAIL: plasma-devel@kde.org

Branch inconsistencies

to a local branch of Plasma/5.7 ----- -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

They're just not really maintained (but then again that is a problem for konqueror itself as well, especially due to being built on top of deprecated web engines...). (I hate this situation.) - David Faure On Aug. 15, 2016, 11:40 a.m

Re: Review Request 128685: Proofread + update performance kcm docbook

other konqueror-related docbook? - David Faure On Aug. 15, 2016, 11:48 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 128767: Fix crash when no QApplication is available.

s QThread(0x14af560), current thread is QThread(0x14e4240) Could not find any platform plugin Thanks, David Faure

Re: Review Request 128767: Fix crash when no QApplication is available.

---- On Aug. 26, 2016, 7:05 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128767/ > -

Fwd: Cron ~/bin/update_kf5.sh

. > Unable to perform a git checkout of origin/Plasma/5.8 to a local branch of Plasma/5.8 - -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

> On Aug. 16, 2016, 7:05 a.m., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 7 > > <https://git.reviewboard.kde.org/r/128684/diff/1/?file=474210#file474210line7> > > > > Yeah I don't understand what this docbook is doing here :-)

moving kdepasswd to plasma-desktop/kcms/useraccount?

tead? Not sure who maintains either one, the names I see in there are all from 2004 or before. So I suppose this is nowadays "plasma team collective maintainance", which is why I'm asking on plasma-devel before adding a few more files to plasma-desktop ;-) Please CC me, I'm no

Re: Review Request 128767: Fix crash when no QApplication is available.

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit a940089a8f2af58b14b4bfa76db23a199b65a04e by David Faure to branch master. Repository: plasma-framework Description --- This happens when QtCreator launches qmlplugindump. Testcase

Re: Review Request 129315: Don't install plasmoid desktop files as services

> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote: > > I'm in favor of this, let's wait to 5.29 tough 5.28 RC is tagged, you can now push commits for 5.29. - David --- This is an automatically generated e-mail. To reply, visit: https://

Re: status of kde/plasma kiosk framework in kf5

a terminal in the current folder ^^ > > > > > dolphin shouldn't allow this.. right? > > > > Konsole's desktop file has a key X-KDE-AuthorizeAction=shell_access that > > tells klauncher to refuse to start it when such restriction is in effect. > > > &g

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

A better approach would be QTRY_VERIFY(findFileWidget()); This will repeatedly call findFileWidget() until it works or until 5 seconds have passed. Then you don't need timers nor separate methods nor a new member variable. The rest of the test can just follow that line. -

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

/kfiledialog_unittest.cpp (line 109) <https://git.reviewboard.kde.org/r/129732/#comment68103> Will be uninitialized if the lambda isn't called. Better initialize it. - David Faure On Dec. 31, 2016, 9:42 a.m., Albert Astals Cid wrote: > > ---

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:189 > +}); > +statJob->start(); > } You don't need to start() KIO jobs, they start automatically. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabrica

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:159 > > -// TODO use kio stat job which also works for remote stuff > -QMimeDatabase db; > -const QMimeType mimeType = db.mimeTypeForUrl(m_url); > +// TODO use kio stat job which also works for remote stuff > +

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added a comment. Much nicer indeed. +2 on the KIO part. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4157 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart, dfaure Cc: plasma-devel, lesliez

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:159 > > -return; > +if (name.isEmpty() && > url.scheme().startsWith(QLatin1String("http"))) { > +name = url.host(); Why only http? This would be useful for FTP, SMB and many other things, no? REPO

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added inline comments. INLINE COMMENTS > broulik wrote in iconapplet.cpp:159 > There you would usually have a filename that makes sense. No, not necessarily. You can point to the root of a FTP server with ftp://ftp.kde.org/ and you can even point to your home dir on an FTP server with

<    1   2   3   4   5   >