D15145: Fixes minor memory leak in the KNSBackend

hallas created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Fixes minor memory leak in the KNSBackend, the destructor of KNSBackend failed to delete the contents of the m_rootCategories

D15145: Fixes minor memory leak in the KNSBackend

hallas closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D15145 To: hallas, apol Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hallas closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19890: Changes the drawing of QToolButton inline indicator arrows

hallas created this revision. hallas added reviewers: VDG, Breeze, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Changes the drawing of inline indicators with QToolButtons so that it is drawn as a

D19890: Changes the drawing of QToolButton inline indicator arrows

hallas added a comment. Hi @ngraham , I have made this separate change to discuss the redesign of the indicator arrows. The current patch changes the indicator arrow so that the toolbutton stays the same size and the indicator arrow is drawn as a two pixel arrow with one pixel margin

D19714: Fixes crash when closing with Detailed Memory Information open

hallas created this revision. hallas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Fixes a crash that occurs if you close KSysGuard with a Detailed Memory Information window open.

D19714: Fixes crash when closing with Detailed Memory Information open

hallas added a comment. Ping - anyone? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D19714 To: hallas, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#482950 , @ngraham wrote: > Actually maybe it just needs a rebase on master... Let me give it a rebase then :D REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hallas,

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. Hi @ngraham - any update on this one? Should we move forward with this approach or should we do something else? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hallas, ngraham Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2,

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#461499 , @mart wrote: > In D20867#457580 , @hallas wrote: > > > In D20867#457575 , @davidedmundson wrote: > > > > >

D20867: Add Property to disable drawing of menu arrow indicators

hallas created this revision. hallas added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Add Property to disable drawing of menu arrow indicators. This is useful for navigation type Tool

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#457570 , @davidedmundson wrote: > There shouldn't be any Breeze specific code in client apps. It's a sign of something being wrong. > > What's a navigation style toolbutton and where do you want to use

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#457575 , @davidedmundson wrote: > QToolButton::setArrowType? I just tried that, but it doesn't seem like Breeze honors this property - at least not for the `QToolButton` produced by

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#457575 , @davidedmundson wrote: > QToolButton::setArrowType? After reading the documents and experimenting a bit, I think that this property is not what we are looking for. The Arrow Type property is to

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

hallas added a comment. Note that I haven't tested this patch locally because I don't know how to "run" the locally compiled devicenotifier. I can see that I get a `plasma_engine_devicenotifications.so` library from building the project, but I don't know how to "run" it, do we have a cli

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

hallas created this revision. hallas added reviewers: Frameworks, broulik, bruns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Use the KListOpenFilesJob class from KCoreAddons to retrieve the applications

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

hallas added a comment. In D25125#558043 , @anthonyfieroni wrote: > Set QT_PLUGIN_PATH to you local path with plugin after that set the system path for others > `QT_PLUGIN_PATH=/local/path:/system/path executable` Thanks for the info