D25086: Port to KGlobalAccel

2019-11-16 Thread David Redondo
davidre added a comment. No, I wanted to let David take a second look. But I can commit later. REPOSITORY R103 KMenu Editor BRANCH globalaccel (branched from master) REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaurent,

D25191: replace bespoke xkb geometry parser with xkb

2019-11-14 Thread David Redondo
davidre added a comment. Is the FooBar class for testing? I don't see it used anywhere. (and would guess soofrom the name) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25191 To: sitter, #plasma Cc: davidre, ngraham, plasma-devel, LeGast00n,

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo
davidre added a comment. In D25273#561847 , @ngraham wrote: > Also, the combobox's model appears to have duplicates for Breeze, Breeze Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for me: F7760168:

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo
davidre updated this revision to Diff 69667. davidre added a comment. Load initial color scheme name from the respective .colors file REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=69639=69667 BRANCH colorschemes (branched from master)

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo
davidre added a comment. In D25273#561845 , @ngraham wrote: > Nice, it's good to get rid of so much boilerplate. > > However when I change the system's own color scheme from Breeze to anything else and start Cuttlefish, the app itself uses

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > main.cpp:130 > +engine.rootContext()->setContextProperty("colorSchemes", colorSchemes); > +engine.load(QUrl::fromLocalFile(package.filePath("mainscript"))); > + Moving the setting of the context properties before loading of the file fixes

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo
davidre updated this revision to Diff 69639. davidre added a comment. Was a typo REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=69637=69639 BRANCH colorschemes (branched from master) REVISION DETAIL https://phabricator.kde.org/D25273

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo
davidre planned changes to this revision. davidre added a comment. I somehow broke it before uploading REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25273 To: davidre, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY By using KColorSchemeManager we can enable viewing icons with all installed color schemes. REPOSITORY R118 Plasma SDK BRANCH

D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port

2019-11-12 Thread David Redondo
davidre added a comment. Seems to work REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25261 To: davidedmundson, #plasma Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D25086: Port to KGlobalAccel

2019-11-11 Thread David Redondo
davidre updated this revision to Diff 69577. davidre marked 2 inline comments as done. davidre added a comment. QLatin1String REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69483=69577 BRANCH globalaccel (branched from master) REVISION

D25086: [WIP] Port to KGlobalAccel

2019-11-08 Thread David Redondo
davidre updated this revision to Diff 69483. davidre added a comment. update application for migration based on the one I did for spectacle REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69279=69483 BRANCH globalaccel (branched from

D25157: [Slideshow] Reenable other modes

2019-11-06 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d0df800b46f9: [Slideshow] Reenable other modes (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25157?vs=69309=69335 REVISION DETAIL

D25086: [WIP] Port to KGlobalAccel

2019-11-06 Thread David Redondo
davidre added a comment. In D25086#559109 , @mlaurent wrote: > For me it seems ok > > Did you finish it ? is it work ? or still in progress ? Shortcut setting and displaying works so far in my testing. I still need to do the

D25157: [Slideshow] Reenable other modes

2019-11-05 Thread David Redondo
davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Was accidentally removed in 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-05 Thread David Redondo
davidre updated this revision to Diff 69301. davidre marked an inline comment as done. davidre added a comment. - const - System services REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25144?vs=69287=69301 BRANCH categorize (branched from

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo
davidre added a comment. In D25144#558670 , @ngraham wrote: > Hmm, I think that would be confusing. "Session" isn't the name of any user-facing applications. That stuff is really a part of Plasma, both technically speaking, and also in terms of

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo
davidre added a comment. In D25144#558665 , @ngraham wrote: > In D25144#558663 , @davidre wrote: > > > In D25144#558630 , @ngraham wrote: > > > > >

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo
davidre added a comment. In D25144#558630 , @ngraham wrote: > However I see a problem with changing "Application Launchers" to "Applications": It implies that the items in that category will give you access to change all the shortcuts for those

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Currently the shortcuts are divided into two lists. "Application Launchers" for shortcuts added via .desktop files (actually

D25086: [WIP] Port to KGlobalAccel

2019-11-04 Thread David Redondo
davidre updated this revision to Diff 69279. davidre marked an inline comment as done. davidre added a comment. Thanks for spotting! REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69107=69279 BRANCH globalaccel (branched from master)

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread David Redondo
davidre added a comment. I don't know how Discover works but to me looks the wrong fix. Does every third party wallpaper then also need to have a name with plasma in it? In my opinion ServiceType Plasma/Wallpaper should be enough for a Service as add-on and not having plasma in it's name.

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > globalaccel.cpp:50 > + > +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString ) > +{ I think the list that is returned can have up to 2 entries. The shortcut and the alternate shortcut. However the currently Gui shows/configures only

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo
davidre updated this revision to Diff 69107. davidre marked 4 inline comments as done. davidre added a comment. - comments REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69105=69107 BRANCH globalaccel (branched from master) REVISION

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo
davidre marked an inline comment as done. davidre added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:39 > Why removing it ? Accidentally REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo
davidre updated this revision to Diff 69105. davidre added a comment. - Don't delete disabled - Remove guards REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69095=69105 BRANCH globalaccel (branched from master) REVISION DETAIL

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Replace KHotkeys with KGlobalAccel WIP because of missing migration REPOSITORY R103 KMenu Editor BRANCH globalaccel

D24985: [wallpapers/image] Seed random number generator

2019-10-29 Thread David Redondo
davidre accepted this revision. davidre added a comment. I think this is fine. Imo we can address the comments on master REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24985 To: davidedmundson, #plasma, ngraham, davidre Cc: davidre, apol,

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

2019-10-28 Thread David Redondo
davidre added a comment. To clarify my comment refers to > The logic is fine but if we start with 0 wallpapers and then add 20 newones we don't shuffle anything. For the other cases shuffling the added images is probably the right thing REPOSITORY R120 Plasma Workspace BRANCH

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

2019-10-28 Thread David Redondo
davidre added a comment. Are you sure? Shouldn't we be hitting this case: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n773 ? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24986 To: davidedmundson, #plasma,

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

2019-10-23 Thread David Redondo
davidre added a comment. > We would need some way to hide the default _launch entry I don't think that is a problem. I think we could wrap https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n119 in an if and only register _launch if the [Desktop Entry]

D24890: Report windowing system

2019-10-23 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R871:8b8f813620b5: Report windowing system (authored by davidre). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24890?vs=68607=68608 REVISION DETAIL

D24890: Report windowing system

2019-10-23 Thread David Redondo
davidre updated this revision to Diff 68607. davidre added a comment. report Unknown REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24890?vs=68604=68607 BRANCH windowsystem (branched from master) REVISION DETAIL https://phabricator.kde.org/D24890

D24890: Report windowing system

2019-10-23 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > CMakeLists.txt:30 > -Notifications IdleTime) > -if(APPLE) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem) I don't know but I just moved the find_package WindowSystem out of the if because now it would be needed

D24890: Report windowing system

2019-10-23 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Sometimes applications have different code paths for X11 or Wayland. Drkonqi reporting that saves one "question -> wait for reply

D24723: Fix slideshow crashing in invalidate()

2019-10-21 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a1cf305ffb21: Fix slideshow crashing in invalidate() (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24723?vs=68304=68407 REVISION

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-19 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R124:a81d0ca787d7: Draw categories in iconview in a similiar style as Kirigami and new… (authored by davidre). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Redondo
davidre updated this revision to Diff 68304. davidre added a comment. Build the new order only after setting the source model. In invalidate just shuffling is enough. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24723?vs=68302=68304 BRANCH

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Redondo
davidre updated this revision to Diff 68302. davidre marked 3 inline comments as done. davidre added a comment. Like this? I also changed the condition in image.cpp otherwise the order wouldn't have been random on the first run with these changes. REPOSITORY R120 Plasma Workspace

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > slidefiltermodel.cpp:51 > +if(sourceModel) { > +connect(sourceModel, ::rowsInserted, this, > ::invalidate); > +connect(sourceModel, ::rowsRemoved, this, > ::invalidate); Good point. No need to invalidate in the other cases.

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo
davidre updated this revision to Diff 68117. davidre added a comment. Simplify the logic. In configmode we don't need the random order. We just use the order of the underlying model. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo
davidre updated this revision to Diff 68115. davidre added a comment. Need rebuild here, rowCount could have changed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24723?vs=68114=68115 BRANCH Plasma/5.17 REVISION DETAIL

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo
davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY QSortFilterProxyModel uses std::stable_sort internally which requires that the comparison

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-10 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D24533 AFFECTED FILES icons/CategoryDrawer.cpp

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-08 Thread David Redondo
davidre added a comment. > Make it possible to have an auto-hiding panel that only appears when clicking on a button somewhere else: https://bugs.kde.org/show_bug.cgi?id=412483 I don't think the point matches the bug report entirely but maybe one could hack something like this together

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R118:66d7bc83fc1e: [Cuttlefish] Compare an icon in different themes (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67120=67124

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > Comparison.qml:66 > +Item { > +id: wrapper > +Layout.preferredWidth: 128 https://doc.qt.io/qt-5/qt.html#AlignmentFlag-enum REPOSITORY R118 Plasma SDK BRANCH comparison (branched from

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > Comparison.qml:66 > +Item { > +id: wrapper > +Layout.preferredWidth: 128 I use it for centering the icon in the middle of the 128x128 free space for the icon. `Qt.AlignCenter` is not enough

D24304: [Cuttlefish] Add 48 to the sizeslider

2019-10-01 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R118:37763ba7b84d: [Cuttlefish] Add 48 to the sizeslider (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24304?vs=67052=67121 REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
davidre updated this revision to Diff 67120. davidre marked 3 inline comments as done. davidre added a comment. Use paint-none directly REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67118=67120 BRANCH comparison (branched from master)

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
davidre updated this revision to Diff 67118. davidre marked 4 inline comments as done. davidre added a comment. nitpicks REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67070=67118 BRANCH comparison (branched from master) REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > Comparison.qml:70 > +height: comparisonSize > +source: modelData.iconPath > +} That's what I did first acutally but I didn't like that for two reasons. First it would

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo
davidre added a comment. Thanks for accepting this so quickly! Does anyone have any comments on the code? I would like to improve my qml and any suggestion/best practice is welcome. REPOSITORY R118 Plasma SDK BRANCH comparison (branched from master) REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

2019-09-30 Thread David Redondo
davidre updated this revision to Diff 67070. davidre added a comment. Show a symbol when a theme doesn't have the icon REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24305?vs=67053=67070 BRANCH comparison (branched from master) REVISION DETAIL

D24305: [Cuttlefish] Compare an icon in different themes

2019-09-30 Thread David Redondo
davidre added a comment. In D24305#539727 , @filipf wrote: > LGTM. Can the overlay be spawned in the vertical center of the window as well or is that defined in Kirigami itself? Also what happens when there are a lot of themes, does the overlay

D24305: [Cuttlefish] Compare an icon in different themes

2019-09-30 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The icon in different installed themes is shown in an overlay sheet. REPOSITORY R118 Plasma SDK BRANCH comparison (branched

D24304: [Cuttlefish] Add 48 to the sizeslider

2019-09-30 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The initial icon size Cuttlefish starts with is 48 (Kirigami.Unis.iconSizes.large). However this size cannot be selected using

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo
davidre added a comment. In D23712#525974 , @ngraham wrote: > There are some inline comments that aren't done yet. Also, the slider's text label still says 81 and 162 instead of 64 and 128 for the last two slider values. I also noticed

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > cuttlefish.qml:32 > > -width: units.gridUnit * 60 > -height: Math.round(width / 3 * 2) > - > property int iconSize: units.iconSizes.large > property bool darkScheme: false Why not Kirigami units here? REPOSITORY R118 Plasma

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-02 Thread David Redondo
davidre added a comment. The reason it's transparent is because the clear color of the buffer is set to the background color when it's changed [1][2]. This worked before probably because the Color was (0, 0, 0). For transparent windows we need to set it to `Qt::transparent`[3] and enable

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-12 Thread David Redondo
davidre added a comment. In D23080#510815 , @ngraham wrote: > IMO the ideal state of affairs would be to somehow emulate the colors of the standard Qt tab widget: > > F7205923: Screenshot_20190812_073407.png

D23049: Add Kirigami ListSection component

2019-08-09 Thread David Redondo
davidre added a comment. Should this set ` sectionDelegate: true` and not expose this to the outside? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson,

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread David Redondo
davidre added a comment. Sorry my bad, I misread the diff. I thought you added a new flag (as proposed above) and looked at `exportGtkTheme` but that flag is an existing one. And to my shame it doesn't even have a green background. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread David Redondo
davidre added a comment. It seems the header with the new flag is missing from the diff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22844 To: cblack, #plasma Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

Addendum to 29/07/2019 meeting

2019-07-29 Thread David Redondo
Hi, I landed https://phabricator.kde.org/D22121 which allows sorting the wallpaper slideshow in a specific order. This is managed by a QSortFilterProxyModel. This model is now also used for the actual slideshow and the config dialog (No more QStringlist of the images that we want to show/are

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-25 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea32a7611227: [Image Wallpaper Slideshow] Allow setting of different sorting orders (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22121?vs=62529=62530#toc REPOSITORY

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-25 Thread David Redondo
davidre updated this revision to Diff 62529. davidre added a comment. Last touches - remove QDebug - don't restore image if we are in random mode - if we have seen all images generate a new random order REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-19 Thread David Redondo
davidre added a comment. How can we move this forward? Are there things I overlooked? Is it sill crashing sometimes? Code comments? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc: davidedmundson, msdobrescu,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-12 Thread David Redondo
davidre updated this revision to Diff 61648. davidre added a comment. - Only restore wallpaper on startup - Guard against empty path I couldn't understand why this was being called with an empty string so I just guard against it at the call site. Maybe this also helps @ngrahams

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-09 Thread David Redondo
davidre added a comment. So I'm crashing when I hit apply and then ok because `addURL` is called from qml with an empty string and I don't understand why. In main.qml I have onConfiguredImageChanged: { if (modelImage != configuredImage) { console.log("configured

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo
davidre planned changes to this revision. davidre added a comment. I may have introduced a similar crash or made it easier to trigger Nate's crash. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc:

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo
davidre updated this revision to Diff 61335. davidre added a comment. - Remember current slide between starts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=61318=61335 BRANCH slideshow (branched from master) REVISION DETAIL

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo
davidre added a comment. In D22121#492179 , @msdobrescu wrote: > Thanks, selecting from any image is useful, to avoid starting always from the top one. But should not enable the button until a check is done. Ideally if you want a

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo
davidre added a comment. In D22121#492173 , @msdobrescu wrote: > I'd say it is some half-implemented feature, probably. Could it be useful to navigate by keyboard and check/uncheck images, by using space, for example? You can still

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo
davidre updated this revision to Diff 61318. davidre added a comment. Don't start if we are in config mode I had another crash here via reload -> processPaths -> endInsertRows. Triggered by repeatetly checking and unchecking a checkbox. My guess is that because of multiple calls to

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo
davidre updated this revision to Diff 61314. davidre marked 2 inline comments as done. davidre added a comment. Disable selecting the wallpaper in slideshow configuration This was introduced when the gridview from the single image dialog was added to the slideshow one. In my mind it

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-08 Thread David Redondo
davidre added a comment. I guess one drawback is that you have to reindex all the files when the sort mode is changed. REVISION DETAIL https://phabricator.kde.org/D22256 To: msdobrescu, ngraham, davidre, #plasma Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-07 Thread David Redondo
davidre added a comment. In D22121#491833 , @davidedmundson wrote: > Nate's crash is due to data not code. > > for (int i = 0; i < m_packages.size(); i++) { > QString package = m_packages[i].path(); > if

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-06 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > image.cpp:600 > +m_slideshowModel->addBackground(path); > +m_currentSlide = m_slideFilterModel->indexOf(path) - 1; > nextSlide(); Currently the slideshow would restart. I guess we could check here if the index is -1. Or

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo
davidre added a comment. In D22121#490983 , @ngraham wrote: > I still get the same crash. :( Very weird I just tried it in a VM which hadn't seen the patch at all yet and it doesn't crash. REPOSITORY R120 Plasma Workspace REVISION

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo
davidre updated this revision to Diff 61116. davidre added a comment. - Sort case insensitive REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=61115=61116 BRANCH slideshow (branched from master) REVISION DETAIL

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo
davidre updated this revision to Diff 61115. davidre added a comment. I couldm't crash it by clicking apply but noticed some type errors because the proxymodel din't have all the functionality of the underlying model. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo
davidre added a comment. Weird. I can't get it to crash at all but I will look at and think about it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-03 Thread David Redondo
davidre updated this revision to Diff 61081. davidre added a comment. - Bool is now other way around REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=61078=61081 BRANCH slideshow (branched from master) REVISION DETAIL

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-03 Thread David Redondo
davidre updated this revision to Diff 61078. davidre added a comment. - Don't invalidate if we are in the config view and the mode is set to random REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60826=61078 BRANCH slideshow (branched

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-30 Thread David Redondo
davidre added a comment. Ah I forgot a word there. I wanted to say don't change the current order if the sort order is switched to random. And when opened and the current mode is random whatever. Displaying the order for the other modes is quite good I think. REPOSITORY R120 Plasma

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-30 Thread David Redondo
davidre added a comment. In D22121#488479 , @ngraham wrote: > That fixed my crash, yay! > > I see a UX issues with the Random mode though: since the list re-sorts itself randomly, it becomes harder to locale any given wallpaper in there

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-29 Thread David Redondo
davidre updated this revision to Diff 60826. davidre added a comment. - add my copyright REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60825=60826 BRANCH slideshow (branched from master) REVISION DETAIL

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-29 Thread David Redondo
davidre updated this revision to Diff 60825. davidre marked 4 inline comments as done. davidre added a comment. - String changes and remove debug statement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60823=60825 BRANCH slideshow

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-29 Thread David Redondo
davidre updated this revision to Diff 60823. davidre added a comment. Sort only if a sortmode has been specified Otherwise it could have been initialized to an invalid value which caused us to reach Q_UNREACHABLE and crash. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-27 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Allows setting of other sorting orders like alphabetical or last modified date. To enable this a new ProxyModel is introduced

D21993: [Klipper] Always restore the last clipbboard item

2019-06-22 Thread David Redondo
davidre created this revision. davidre added reviewers: ngraham, davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY D19852 intrdouced

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R169:43eb5fae5784: Set SwipeListItem implicitHeight to be the maximum of content and actions (authored by davidre). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread David Redondo
davidre created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise if the content is smaller than the actions they will be partially outside out of the item REPOSITORY R169 Kirigami

D19745: Fix system tray UI/UX & refactor

2019-05-15 Thread David Redondo
davidre added a comment. In D19745#465569 , @ratijastk wrote: > So, I've merged done git rebase on master — just one conflicting line, rewritten after me in a better way. But now I have no way to test it, because CMake Error `Could not find a

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread David Redondo
davidre added a comment. > I haven't found a way to align Kirigami.FormLayout together in a repeater. Maybe you could use twinFormLayouts like in D19873 and D19932 ? REPOSITORY R102 KInfoCenter REVISION DETAIL

D19687: Allow single images to be excluded from the slideshow

2019-04-01 Thread David Redondo
davidre updated this revision to Diff 55164. davidre added a comment. - Change default of cfg_UncheckedSlides to [] - Change toggled to checked REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19687?vs=54010=55164 BRANCH toggleSlides REVISION

D19687: Allow single images to be excluded from the slideshow

2019-03-29 Thread David Redondo
davidre added a comment. almost weekly ping REPOSITORY R120 Plasma Workspace BRANCH toggleSlides REVISION DETAIL https://phabricator.kde.org/D19687 To: davidre, #plasma, #vdg, ngraham Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19687: Allow single images to be excluded from the slideshow

2019-03-23 Thread David Redondo
davidre added a comment. Ping! REPOSITORY R120 Plasma Workspace BRANCH toggleSlides REVISION DETAIL https://phabricator.kde.org/D19687 To: davidre, #plasma, #vdg, ngraham Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

2019-03-21 Thread David Redondo
davidre added a comment. Great! I see that also fixes the issue that the label vanished when the window got to narrow. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham, mart Cc: davidre, mart, abetts, plasma-devel,

<    1   2   3   4   5   >