Switching activities and keeping applications

2011-11-08 Thread Fabian Riethmayer
Hello, I was just talking to sebas on IRC about switching activities and take all my applications with me. He said, it was not (easily) possible at the moment to switch between activities and still have all my running applications with me, but I might send my usecase to plasma mailing list. My

Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

2012-08-01 Thread Fabian Riethmayer
/nepomukmusicmodel.cpp d4f7449 components/mediabrowser/MediaItemDelegate.qml bd181ab Diff: http://git.reviewboard.kde.org/r/105816/diff/ Testing --- Thanks, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

2012-08-01 Thread Fabian Riethmayer
, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

2012-08-02 Thread Fabian Riethmayer
http://git.reviewboard.kde.org/r/105816/s/660/ Thanks, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

2012-08-02 Thread Fabian Riethmayer
, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Changed MediaItemDelegate.qml, more space between items, a frame for pictures, fixed keyboardinteraction.

2012-08-06 Thread Fabian Riethmayer
, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Rework of metadatamusic qml components.

2012-11-12 Thread Fabian Riethmayer
/metadatamusicbackend/metadatamusiccomponents/qmldir 3f2f55d components/mediabrowser/MediaItem.qml PRE-CREATION components/mediabrowser/MediaItemDelegate.qml e3fe582 Diff: http://git.reviewboard.kde.org/r/107299/diff/ Testing --- Thanks, Fabian Riethmayer

Re: Review Request: Rework of metadatamusic qml components.

2012-11-12 Thread Fabian Riethmayer
://git.reviewboard.kde.org/r/107299/diff/ Testing --- Thanks, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rework of metadatamusic qml components.

2012-11-12 Thread Fabian Riethmayer
: http://git.reviewboard.kde.org/r/107299/diff/ Testing --- Thanks, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Rework of metadatamusic qml components.

2012-11-13 Thread Fabian Riethmayer
/metadatamusiccomponents/MediaBrowser.qml 5218866 Diff: http://git.reviewboard.kde.org/r/107299/diff/ Testing --- Screenshots (updated) --- Artist view http://git.reviewboard.kde.org/r/107299/s/827/ Track view http://git.reviewboard.kde.org/r/107299/s/828/ Thanks, Fabian

Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

2012-11-14 Thread Fabian Riethmayer
://git.reviewboard.kde.org/r/107325/diff/ Testing --- Screenshots --- Trackview with cover http://git.reviewboard.kde.org/r/107325/s/831/ Thanks, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

2012-11-14 Thread Fabian Riethmayer
/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 08735a2 Diff: http://git.reviewboard.kde.org/r/107325/diff/ Testing --- Screenshots --- Trackview with cover http://git.reviewboard.kde.org/r/107325/s/831/ Thanks, Fabian Riethmayer

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

2012-11-14 Thread Fabian Riethmayer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107325/#review21986 --- Ship it! Ship It! - Fabian Riethmayer On Nov. 14, 2012, 12

PMC tonight at 23:59 hours UTC

2012-12-12 Thread Fabian Riethmayer
Hi! Just a reminder, PMC goes into a feature free tonight at 23:59 hours UTC[1]. If you have new features in a branch, or local clone, merge them with master already. Don't hesitate to ask if someone has a question/concern. [1]

PMC feature free tonight at 23:59 hours UTC

2012-12-13 Thread Fabian, Riethmayer
Hi! Just a reminder, PMC goes into a feature free tonight at 23:59 hours UTC[1]. If you have new features in a branch, or local clone, merge them with master already. Don't hesitate to ask if someone has a question/concern. [1]

Review Request: Reusable qml components for mediabrowsing

2012-12-23 Thread Fabian Riethmayer
/MediaLineItemDelegate.qml PRE-CREATION components/MediaListBrowser.qml PRE-CREATION components/TabBrowser.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107861/diff/ Testing --- Thanks, Fabian Riethmayer ___ Plasma-devel mailing list Plasma-devel

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-22 Thread Fabian Riethmayer
fabianr added a comment. The layout looks good and is according to the HIG. You probably shouldn't display duplicate information, but if I understood the comments correct this is already addressed. A case could be made that this information is actually the most interesting one, and

D4960: Pause media players on suspend

2017-03-20 Thread Fabian Riethmayer
fabianr added a comment. Looking good to me. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4960 To: broulik, #plasma, #vdg, graesslin Cc: fabianr, andreaska, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5382: Improve password dialogs

2017-04-13 Thread Fabian Riethmayer
fabianr added a comment. It looks like the spacing between the 4 content sections (title, description, passwords, buttons) is not always the same. To me it the spacing between title - description and password - buttons looks equal, but description - password seems to be smaller. I would

D5262: Animate quick tiling outline

2017-04-20 Thread Fabian Riethmayer
fabianr added a comment. +1, I like the new animation. It adds information without introducing any new "clutter" or slow down REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5262 To: broulik, #vdg, #plasma, #kwin Cc: fabianr, graesslin, plasma-devel, kwin, spstarr,

D5424: [Notifications] Introduce "settings" action

2017-04-18 Thread Fabian Riethmayer
fabianr added a comment. I like the change, the text button was too striking. the icon is much better REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5424 To: broulik, #vdg, #plasma, markg, mck182 Cc: fabianr, andreaska, mck182, markg, plasma-devel,

D5382: Improve password dialogs

2017-04-18 Thread Fabian Riethmayer
fabianr added a comment. +1, other then the spacing mentioned above, I like the change. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D5382 To: jgrulich, #vdg, #plasma Cc: fabianr, mart, broulik, plasma-devel, spstarr, progwolff,

D9431: [Login / Lock screen] Highlight button when focus or hover

2017-12-20 Thread Fabian Riethmayer
fabianr added a comment. Hover and focus should not have the same visual effect, otherwise a user can not distinguish them. Either - show only an effect for focus - use two different effects, eg underline and highlight - handle it like a list and use the same highlight for focus

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-07 Thread Fabian Riethmayer
fabianr updated this revision to Diff 33745. fabianr added a comment. - Changed 'How to use' for on demand pattern to incorporate phab feedback REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33631=33745 BRANCH swipe

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-04 Thread Fabian Riethmayer
fabianr updated this revision to Diff 33609. fabianr added a comment. - Updated visuals for listview and folderview REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=32867=33609 BRANCH swipe REVISION DETAIL

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-04 Thread Fabian Riethmayer
fabianr marked an inline comment as done. fabianr added inline comments. INLINE COMMENTS > colomar wrote in ondemand.rst:27 > Since this is a command pattern, shouldn't this link to command patterns > instead of navigation patterns? My intention was to suggest switching to a navigation pattern

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-04 Thread Fabian Riethmayer
fabianr updated this revision to Diff 33631. fabianr added a comment. - Fixed typo REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33609=33631 BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 AFFECTED

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-16 Thread Fabian Riethmayer
fabianr updated this revision to Diff 34275. fabianr added a comment. - removed border around dolphin example in ondemand pattern REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=34271=34275 BRANCH swipe REVISION DETAIL

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-16 Thread Fabian Riethmayer
fabianr updated this revision to Diff 34271. fabianr added a comment. - moved example image to the top in ondemand pattern REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33745=34271 BRANCH swipe REVISION DETAIL

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-16 Thread Fabian Riethmayer
fabianr closed this revision. REPOSITORY R985 KDE Human Interface Guidelines REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, davidedmundson, mart, hein, kamathraghavendra

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-05-02 Thread Fabian Riethmayer
fabianr added a comment. > to me pinning should mean: > > - i say what are the most important tasks to me (regardless if it's for one activity or for all activities) > - i want them always there, no matter whether running or not > - they stay always exactly in the same place (muscle

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-04 Thread Fabian Riethmayer
fabianr added inline comments. INLINE COMMENTS > mart wrote in ondemand.rst:11 > maybe add a dolphin screenshot as well with the + on hover? (or folderview) There is a dolphin screenshot with the hover in the desktop section, (line 48+) REPOSITORY R985 KDE Human Interface Guidelines

D10438: increase left/right margin of menuitems

2018-02-12 Thread Fabian Riethmayer
fabianr added a comment. According to the HIG units.smallSpacing (4px) or units.largeSpacing (18px) or multiples of these should be used when ever possible, maybe it would make sense to uses these? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag,

D10438: reserve space for checkable widgets in menu items

2018-02-13 Thread Fabian Riethmayer
fabianr added a comment. @zzag It would be greate if you could add a screenshot of the new context menu to https://community.kde.org/KDE_Visual_Design_Group/HIG/ContextMenu#Examples . Of cause other improvements/corrections to the page are more then welcome, too. If you hagve question you

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

2018-02-08 Thread Fabian Riethmayer
fabianr accepted this revision. fabianr added a comment. This revision is now accepted and ready to land. To keep the notification open when it is not visible is the suggested action in the notification draft too: https://community.kde.org/Plasma/Notifications#Behaviour_2 REPOSITORY R120

D9638: [effects] replace old slide effect with a new one

2018-02-15 Thread Fabian Riethmayer
Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D14238: Polish Notifier Plasmoid's UI

2018-07-20 Thread Fabian Riethmayer
fabianr added a comment. Maybe add a second button "Update" that does update right away without viewing the available update list? Most users probably won't be interested in which packages are updated, but just want to stay up to date? REPOSITORY R134 Discover Software Store REVISION

D14238: Polish Notifier Plasmoid's UI

2018-07-23 Thread Fabian Riethmayer
fabianr added a comment. In D14238#295426 , @apol wrote: > In D14238#295251 , @fabianr wrote: > > > Maybe add a second button "Update" that does update right away without viewing the available

D11069: [WIP] refine decoration shadows

2018-03-09 Thread Fabian Riethmayer
fabianr added a comment. In D11069#221381 , @zzag wrote: > So, I'd spent last two hours trying to find good menu shadow params.. HIG guidelines don't say too much about shadows(also, navigating them is hard) so I don't know whether these

D11876: Display star ratings

2018-04-04 Thread Fabian Riethmayer
fabianr added a comment. +1 for no line And if there must be a line, please choose a different color. Plasma blues is supposed to be used to indicate possible interaction . REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham,

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

2018-04-19 Thread Fabian Riethmayer
fabianr added a comment. What I don't like is that the menus in the different hierarchy levels can have a different size now. To have them in an uniform size gives them a more consistent look. Change all the menus, in all hierarchy levels, to the same dynamic size? REPOSITORY R119

D12091: HIG entry for On-demand pattern and swipe list item

2018-04-23 Thread Fabian Riethmayer
fabianr updated this revision to Diff 32867. fabianr added a comment. - Merge branch 'master' into swipe - added a screenshot for a desktop swipelistitem, small formating change - Added png file REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-24 Thread Fabian Riethmayer
fabianr added a comment. +1 As soon as there are enough tasks in the task bar, that you can not any longer read the title at a glimpse or the tasks start to group the task bar, it looses so much of its usefulness. In groups you have to hover , wait, move the mouse and click to activate

D17556: Make Status and Notification popup consistent with others.

2018-12-14 Thread Fabian Riethmayer
fabianr added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:98 > topMargin: hiddenItemsView.visible ? units.smallSpacing : 0 > -leftMargin: hiddenItemsView.iconColumnWidth + units.largeSpacing; > +leftMargin: 5 > } Please don't use

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-09 Thread Fabian Riethmayer
fabianr added a comment. The HIG states: "When the visual design calls for an area of exceptional focus, a larger typeface size may be used. In this case use a Light typeface weight to keep the stroke width similar to other styles throughout the interface" I think, if you want to have

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-09 Thread Fabian Riethmayer
fabianr added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-09-26 Thread Fabian Riethmayer
fabianr added a comment. > It doesn't auto-hide by default in macOS. I decided to make it span the full width of the screen because not doing this is IMO one of the dumbest parts of that macOS dock, because it pointlessly wastes the bottom-left-most and bottom-right-most pixels, which are

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Fabian Riethmayer
fabianr added a comment. > I'd also consider to make the global theme also change plasma theme, color scheme or even application style so that it switches to a even more similiar interface. If Cupertino global theme switched to a light version of https://store.kde.org/p/1252328/, that would

D25055: [containments/desktop] Delete the "Tweaks" page and its options

2019-10-31 Thread Fabian Riethmayer
fabianr added a comment. I would In D25055#557216 , @hein wrote: > If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox? > > I have to admit though