Re: Review Request: Support for the plasma:/ protocol in urls from emails/web pages and the network:/ kioslave

generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1515/#review2242 --- On 2009-09-03 18:23:03, Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail

Re: Tokamak4 Attendance, LAST CALL

Hi, Mardi, le 5 janvier 2010, à 14:02, John Layt a écrit: On Tuesday 05 January 2010 11:26:27 Sebastian Kügler wrote: Please everybody who's planning to attend Tokamak4, to be held from 19th - 26th February at the openSuse premises in Nuremberg, Germany, do the following: Finally using

Bookmarks plasmoid moved to kdereview

Hi all, I've just moved the Bookmarks plasmoid* from playground to kdereview. It's a simple one-button plasmoid which on a click (or activation) shows the standard bookmarks menu and calls KRun for the selected bookmark. It can be configured to just show a subtree of the whole bookmarks tree,

Re: Bookmarks plasmoid moved to kdereview

Hi Chani, Mardi, le 12 janvier 2010, à 04:03, Chani a écrit: On January 11, 2010 18:21:11 Aaron J. Seigo wrote: On January 11, 2010, Friedrich W. H. Kossebau wrote: I've just moved the Bookmarks plasmoid* from playground to kdereview. cool; i may not have much time between now and 4.4.0

Re: Bookmarks plasmoid moved to kdereview

Hi Aaron, Mardi, le 12 janvier 2010, à 03:21, Aaron J. Seigo a écrit: On January 11, 2010, Friedrich W. H. Kossebau wrote: I've just moved the Bookmarks plasmoid* from playground to kdereview. cool; i may not have much time between now and 4.4.0 to look at it, but i'll do my best

Re: Bookmarks plasmoid moved to kdereview

Hi, Mardi, le 12 janvier 2010, à 02:14, Friedrich W. H. Kossebau a écrit: Hi all, I've just moved the Bookmarks plasmoid* from playground to kdereview. It's a simple one-button plasmoid which on a click (or activation) shows the standard bookmarks menu and calls KRun for the selected

Re: Bookmarks plasmoid moved to kdereview

Mardi, le 26 janvier 2010, à 00:00, Aaron J. Seigo a écrit: On January 24, 2010, Friedrich W. H. Kossebau wrote: Upcoming Tuesday two weeks have passed since the move into kdereview. Thanks to Albert, Burkhard and Laurent some i18n problems have been fixed. Did anyone else have the time

Re: Bookmarks plasmoid moved to kdereview

Mercredi, le 27 janvier 2010, à 19:23, Aaron J. Seigo a écrit: On January 27, 2010, Friedrich W. H. Kossebau wrote: Mardi, le 26 janvier 2010, à 00:00, Aaron J. Seigo a écrit: On January 24, 2010, Friedrich W. H. Kossebau wrote: Upcoming Tuesday two weeks have passed since the move

Re: Review Request: Support for the plasma:/ protocol in urls from emails/web pages and the network:/ kioslave

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1515/ --- (Updated 2010-01-29 16:23:40.126653) Review request for Plasma. Changes

Re: KDE/kdenetwork/kdnssd/ioslave

Hi again, Kevin, Jeudi, le 28 avril 2011, à 23:45, Friedrich W. H. Kossebau a écrit: the network:/ kio-slave (which btw already lists plasma remote widgets, but in a device-centric way, not service- centric), the attached patch never made it to kdelibs/plasma (bitrotted in http

How to do a Plasma runner which only triggers once the query string is complete?

Hi, (cc:ing marble-devel for heads-up, please follow-ups only on plasma-devel) I would like to do a Plasma runner which reuses the runners that Marble, your favourite celestial body watcher, has. Yes, Marble has also runners: In the Navigation sidebar, in the edit field below Search the user

Re: How to do a Plasma runner which only triggers once the query string is complete?

Ping... so, noone any idea? On marble-devel Anders proposed to wait until user stops typing, but from what I could see there is no way to make use of that here, right? So is the only option really some kind of end-keyword? :( Lundi, le 17 octobre 2011, à 20:32, Friedrich W. H. Kossebau a écrit

Review Request: KACTIVITIES_LIBRARY vs. KACTIVITIES_LIBS

/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing --- Applied the patch and kde-workspace builds completely for me and plasma-desktop co. runs fine Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing

Re: Review Request: KACTIVITIES_LIBRARY vs. KACTIVITIES_LIBS

/CMakeLists.txt 056f9d4 plasma/desktop/shell/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing --- Applied the patch and kde-workspace builds completely for me and plasma-desktop co. runs fine Thanks, Friedrich W. H. Kossebau

Re: Review Request: KACTIVITIES_LIBRARY vs. KACTIVITIES_LIBS

plasma/desktop/applets/pager/CMakeLists.txt 056f9d4 plasma/desktop/shell/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing --- Applied the patch and kde-workspace builds completely for me and plasma-desktop co. runs fine Thanks, Friedrich W. H

Re: Review Request 128108: update weather applet ui

PlasmaComponents.Label applets/weather/package/contents/ui/main.qml (line 155) <https://git.reviewboard.kde.org/r/128108/#comment65088> Please do not delete "textFormat: Text.StyledText", just add "opacity: 0.6". - Friedrich W. H. Kossebau On J

Re: Review Request 128108: update weather applet ui

already (but only with a fixed version :) ). - Friedrich W. H. Kossebau On June 8, 2016, 10:25 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

marked as submitted. Review request for Plasma, Albert Astals Cid, Jonathan Riddell, Luigi Toscano, and Harald Sitter. Changes --- Submitted with commit 40e9146fba8fdfa1ca11abb34f371f5ce1ae7d05 by Friedrich W. H. Kossebau to branch master. Repository: releaseme Description

Re: Review Request 128108: update weather applet ui

To reply, visit: > https://git.reviewboard.kde.org/r/128108/ > --- > > (Updated June 10, 2016, 10:37 p.m.) > > > Review request for Plasma and Friedrich W. H. Kossebau. > > > Repository: kdeplasma-addons > > > Descri

Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

nly tested `LC_ALL=C LANG=C msgfmt --statistics somefile.po -o /dev/null> 2>&1` on the commandline, worked as expected, no file created. Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.

Re: Restoring weather applet in kdeplasma-addons

Hi Martin, Am Freitag, 5. Februar 2016, 17:05:43 CET schrieb Marco Martin: > On Friday 05 February 2016 16:23:38 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I am missing the weather applet in my Plasma5 workspace. I found the > > sources in kdeplasma-addons/ap

Restoring weather applet in kdeplasma-addons

Hi, I am missing the weather applet in my Plasma5 workspace. I found the sources in kdeplasma-addons/applets/weather, but it seems not yet ported and is disabled from the build. So I would see to port it over now myself. A few questions I have: Q1: Is anyone already looking into it? Any

Re: Restoring weather applet in kdeplasma-addons

Am Freitag, 5. Februar 2016, 19:15:29 CET schrieb Marco Martin: > On Friday 05 February 2016 18:39:00 Friedrich W. H. Kossebau wrote: > > I see. And found it now, plasma-workspace/dataengines/weather. Seems it > > was started in 2014, but then lost focus of developers. Some &qu

Re: Restoring weather applet in kdeplasma-addons

Am Montag, 8. Februar 2016, 10:41:00 CET schrieb Marco Martin: > On Monday 08 February 2016, Friedrich W. H. Kossebau wrote: > > No config support yet, are QWidget-based config dialogs that even still > > supported API-wise? > > eh, unfortunately no,because mixing qwidget

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

rather "interesting" and should be revisited by UI experts. As said, for now concentrated on porting the existing applet and would like to postpone this to after the applet is ported as it is. Okay to drop this for this review? > On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrot

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

bs/plasmaweather/weathervalidator.cpp 4d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

ently, so even a lambda will not help :) In general that might be a useful API addition, but here, for the Weather applet, not needed, so cannot back the addition with a usecase (yet). - Friedrich W. H. --- This is an automatically generated

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> there. The weather icons also leak outside the strip but this looks like it > > might be intended. > > > > It also looks like we need some Breeze weather icons :) > > Friedrich W. H. Kossebau wrote: > Thanks a lot for your detailed review and testing, very appreciated! &g

Re: Restoring weather applet in kdeplasma-addons

rieb Marco Martin: > On Tuesday 09 February 2016 01:07:14 Friedrich W. H. Kossebau wrote: > > the > > > > > config key > > > > You meant "main.xml" here where you wrote "config.xml", right? > > (would match files I found elsewhere in

Re: Theming issues noted while porting Weather applet

Hi, Am Samstag, 27. Februar 2016, 18:13:28 CET schrieb Marco Martin: > On Saturday 27 February 2016, Friedrich W. H. Kossebau wrote: > > * PlasmaCore.FrameSvgItem seems to not update to changes of the Plasma > > color theme, stays with theme current on start > > that s

Re: Theming issues noted while porting Weather applet

Am Montag, 29. Februar 2016, 13:17:42 CET schrieb Kai Uwe Broulik: > ‎> If there one switches between dark and breeze meta themes, then for some > reason the updates of the FrameSvgItem items only happen delayed on the > next > > Yeah I've also seen the look and feel package kcm doesn't properly

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

iting on search. - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review92916 --- On Feb. 29, 2016, 2:23 a

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> there. The weather icons also leak outside the strip but this looks like it > > might be intended. > > > > It also looks like we need some Breeze weather icons :) > > Friedrich W. H. Kossebau wrote: > Thanks a lot for your detailed review and testing, very appreciated! &g

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> there. The weather icons also leak outside the strip but this looks like it > > might be intended. > > > > It also looks like we need some Breeze weather icons :) > > Friedrich W. H. Kossebau wrote: > Thanks a lot for your detailed review and testing, very appreciated! &g

Review Request 127193: Revival of Weather applet (for Plasma 5.6)

2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

dataengines/weather/ions/envcan/CMakeLists.txt a3daa55 dataengines/weather/ions/envcan/ion_envcan.h 19407d6 dataengines/weather/ions/envcan/ion_envcan.cpp 56efc7a Diff: https://git.reviewboard.kde.org/r/127248/diff/ Testing --- Thanks, Friedrich W

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

On March 2, 2016, 12:54 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127252/ > -

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

.org/r/127248/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127252: Port all ion plugins away from KDELibs4Support

://git.reviewboard.kde.org/r/127252/diff/ Testing --- Tested both noaa & wettercom station, still showed correct day numbers for me. Could not test with non-arabic number presentation locale (only assume it should work) Thanks, Friedrich W. H. Koss

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

de.org/r/127248/#review93038 --- On March 1, 2016, 8:10 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

: https://git.reviewboard.kde.org/r/127248/#review93038 ----------- On March 1, 2016, 8:10 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-m

Re: Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

marked as submitted. Review request for Plasma, Kai Uwe Broulik and Marco Martin. Changes --- Submitted with commit d5b8faa0e07be47f6bc2177d6e7ae40df873c014 by Friedrich W. H. Kossebau to branch Plasma/5.6. Repository: kdeplasma-addons Description --- Possible root of the error

Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

--- 10/10 times configuring a new weather station (also from different services) worked & did not result in an empty widget (but then before I also only seldomly saw that). Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-d

Re: bbcukmet feature in bugfix branch?

Hi Harald, Am Mittwoch, 6. April 2016, 11:23:04 CEST schrieb Harald Sitter: > Not that I know what an ion is but I am pretty sure [1] is a feature > and not a bug fix, yet it is in the bug fix branch for 5.6 :-( thanks for speaking out when seeing possible rule breaking, very appreciated. This

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

e give this applet another test and consider getting it in for 5.6, I surely am not the only one missing it a lot :) - Friedrich W. H. Kossebau On March 1, 2016, 12:43 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an aut

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

hervalidator.cpp 4d016e2 Diff: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

f: https://git.reviewboard.kde.org/r/127193/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review93003 --- On March 1, 2016, 3:18 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automa

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

marked as submitted. Review request for Plasma and Marco Martin. Changes --- Submitted with commit 6801fa9c2475887f4ca993aba5ae091a181d901b by Friedrich W. H. Kossebau to branch master. Repository: plasma-workspace Description --- Porting `KLocalizedDate(date.date()).formatDate

Use-cases for ASCII-art kwin backend (Re: Minutes Monday Plasma Meeting)

Am Montag, 4. April 2016, 12:42:39 CEST schrieb Sebastian Kügler: > * april-fool: https://phabricator.kde.org/D1283 - might work as easter egg, > opinions? Use-cases: * nice gimmick for Plasma demo points on fairs/events (as eye catcher or talk starter), if separate (virtual) machine is

RFC: Enabling users to report issues with Plasma widgets

Hi, challenge: 1. take your favourite Plasma widget 2. find a bug or idea for an improvement with it 3. report it to the maintainer of the widget 1. & 2. are easy. But 3. is not easy at all. Question: Are endusers supposed to report issues with Plasma widgets and get in contact with its

Re: RFC: Enabling users to report issues with Plasma widgets

Thanks for the feedback so far, everyone. Looks like this is something were consensus needs more work before moving on with whatever plan. Will look more into this end of April. Though also happy to have someone else pick up this topic meanwhile and do the lead. Until then still welcoming

Review Request 128594: Add a kapptemplate for Plasma Wallpaper

675e71 Diff: https://git.reviewboard.kde.org/r/128594/diff/ Testing --- Installed the template, then created a new wallpaper plugin using kapptemplate and following the README, then selected in wallpaper config, incl. editing the plugin config by entering a new text. Thanks, Frie

Re: Review Request 128594: Add a kapptemplate for Plasma Wallpaper

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit d4f10cd67e8c4811d3a39fbd44e1f16655c9b2fc by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- This template should allow people

Re: Review Request 128612: Add translation domain to wallpaper QML object

.DisplayText || i18n("") ``` - Friedrich W. H. Kossebau On Aug. 5, 2016, 1:56 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy errors in API dox)

e142552 src/plasma/data/servicetypes/plasma-dataengine.desktop 9280645 src/plasma/pluginloader.h 80cd1e9 Diff: https://git.reviewboard.kde.org/r/128616/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy errors in API dox)

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- plasma-dataengine.desktop misses

Re: Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy errors in API dox)

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 4bf1ef7ea6b30a37170ded7bdb3ac826b87a9b94 by Friedrich W. H. Kossebau to branch master. Repository: plasma-framework Description --- plasma-dataengine.desktop misses

Re: Review Request 128897: cursor model: look for cursors in correct place

tps://git.reviewboard.kde.org/r/128897/#comment66752> Should these includes not be conditional on whether X11 is found or not? - Friedrich W. H. Kossebau On Sept. 13, 2016, 12:44 p.m., Jason A. Donenfeld wrote: > > --- > This is a

[Differential] [Commented On] D4120: add support for display_name in categories

kossebau added a comment. Sounds good. While touching this, have you considered localized display names? While content description might be still English as lingua-franca, having the display name localized might be another step into the direction of average users which are not fluent in

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

as discussed on irc). Though my POV is limited, file widgets being not my playing ground, so perhaps better have someone else ship-it, too. - Friedrich W. H. Kossebau On Dec. 31, 2016, 9:42 a.m., Albert Astals Cid wrote

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

/kfiledialog_unittest.cpp (line 106) <https://git.reviewboard.kde.org/r/129732/#comment68101> Please also add a comment why `QTest::qWaitForWindowExposed()` is not used as with similar tests, not obvious to me at least. - Friedrich W. H. Kossebau On Dec. 31, 2016, 1:20 a.m., Albert Astals Cid

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. kossebau added a comment. @jriddell : no use to have me as reviewer: I did not do the respective change of kdevplatform API, so cannot really tell if this is the correct usage here. Also have I never run plasmate, so cannot test this patch quickly.

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5127 To: jriddell, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5405: Create desktop file name based on organization domain unless set explicitely

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Having slept over this one night, I still think that this change should be not the way to go to fix the seen issues. The actual problem is bad usage in application code,

D5405: Create desktop file name based on organization domain unless set explicitely

kossebau added a comment. In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage? In the current KAboutData

D5791: Allow to disable blinking cursor completely

kossebau added a comment. In https://phabricator.kde.org/D5791#108454, @kfunk wrote: > This is so trivial, yet I saw the demand for being able to disable the blinking cursor several times... > > Am I missing something or why was the minimum 200? Properly if blinking that was

D5937: No longer build Plasmate by default

kossebau abandoned this revision. kossebau added a comment. Plasmate got moved into own repo now, discarding. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade, jriddell, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D5937: No longer built Plasmate by default

kossebau created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Does not work currently and needs a maintainer. REPOSITORY R118 Plasma SDK BRANCH dontbuildplasmatebydefault REVISION DETAIL

D5937: No longer build Plasmate by default

kossebau retitled this revision from "No longer built Plasmate by default" to "No longer build Plasmate by default". REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade, jriddell Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D5937: No longer built Plasmate by default

kossebau added a comment. IMHO Plasmate should not be released for default build also with Plasma 5.10. Distribution packagers seems to just look if things built, but not test the functionality, at least when it comes to Plasmate. E.g. for openSUSE plasmate is part of the package

D5914: Add template for Plasma QML Applet with QML extension

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Should help people to kick-off plasmoids which also use custom QML classes. TEST PLAN Created new plasmoid from

D5914: Add template for Plasma QML Applet with QML extension

kossebau added a comment. Get created template bundle here: https://share.kde.org/index.php/s/eHJGEku7pw7DotV REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau added a comment. Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum

D6054: Use explicit flag values or explicit constructor instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D5914: Add template for Plasma QML Applet with QML extension

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4d5793c28a3f: Add template for Plasma QML Applet with QML extension (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5914?vs=14681=14687#toc REPOSITORY R242 Plasma

D9072: make ksshaskpass work with git-lfs

kossebau resigned from this revision. kossebau added a comment. no clue about these ksshaskpass internals, sorry REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D12794: [weather applet] Improve name & comment metadata

kossebau updated this revision to Diff 34137. kossebau added a comment. pick up proposed wording, thanks for that Will push this version then CET tonight, unless someone objects "shipit"s still welcome as well :) REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

kossebau updated this revision to Diff 33251. kossebau added a comment. remove explicit cancelling of superseded MatchReply REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10079?vs=33027=33251 BRANCH portBalooRunnerToKDBusRunner REVISION DETAIL

D12794: [weather applet] Improve name & comment metadata

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The applet shows both observation and the forecast as reported

D12794: [weather applet] Improve name & comment metadata

kossebau added a comment. Hoping for some native speaker with weather science background to provide proper naming here :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12794 To: kossebau, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12944: [weather applet] Show a note why "Show temperature" is disabled

kossebau added a comment. Looking like this when triggered: F5854760: Screenshot_20180518_045938.png Message text might need more improvement, proposals welcome. And fine to do master-only, just completing things now this has been started to deal

D12944: [weather applet] Show a note why "Show temperature" is disabled

kossebau updated this revision to Diff 34405. kossebau added a comment. Using Kirigami.InlineMessage with layout now in control and improved message text (and updated to more HIG-conformant UI) REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D12944: [weather applet] Show a note why "Show temperature" is disabled

kossebau added a comment. Looks like this when hit: F5853714: Screenshot_20180517_160131.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12944 To: kossebau, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D12944: [weather applet] Show a note why "Show temperature" is disabled

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Giving the user a clue why the setting is disabled helps them

D12944: [weather applet] Show a note why "Show temperature" is disabled

kossebau added a comment. Meh, forgot about ensuring proper wordwrapping, but somehow Layout.fillWidth: true wrapMode: Text.WordWrap don't have the desired effect, seems the groupbox is messing into that. Screws this approach. In D12944#264142

D12794: [weather applet] Improve name & comment metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R114:286561d839e0: [weather applet] Improve name comment metadata (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12794?vs=34137=34189

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Both the compact and the fullpresentation variants of the

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R114:6ce58880151d: [Timer applet] Fix double speed countdown commands run multiple times (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D13065: [Timer applet] Fix double speed countdown & commands run multiple times

kossebau added a comment. Patch is against 5.12 branch. Sadly does not apply cleanly against 5.13 & master, blame me for code brush up since then... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13065 To: kossebau, #plasma Cc: plasma-devel, ragreen, Pitel,

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

kossebau resigned from this revision. kossebau added a comment. Myself have not dealt with KIO/UDS for some years, so no clue what is wanted here. Also only touched this repo for buildsystem brush-over, so not a good reviewer candidate, thus resigning as reviewer. @smithjd I would

D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6f491642e9b9: [kded kcm] Fix estimating dbusModuleName of kded plugins (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13623?vs=36357=36362#toc REPOSITORY R119 Plasma

D13360: Touchpad KDED module: Convert to JSON metadata

kossebau added a comment. Given the D-Bus object path for the module is generated from the moduleid, which is set by kded using the KPluginMetaData::pluginId (in `KDEDModule *Kded::loadModule(const KPluginMetaData , bool onDemand)`, a fix might have been instead to set in the

D13360: Touchpad KDED module: Convert to JSON metadata

kossebau added a comment. In D13360#280205 , @marten wrote: > Apologies for the unforeseen trouble. Happens also to the best now and then, and only to get better the next time :) > I'll revert the committed change for now, and then

D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

kossebau added a comment. Target: 5.12 LTS REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13623 To: kossebau, dfaure, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

kossebau created this revision. kossebau added reviewers: dfaure, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The entry X-KDE-DBus-ModuleName has never been

D13818: Port from KStandardDirs to QStandardPaths

This revision was automatically updated to reflect the committed changes. Closed by commit R116:f327922e60fb: Port from KStandardDirs to QStandardPaths (authored by kossebau). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D13360: Touchpad KDED module: Convert to JSON metadata

kossebau added a comment. This patch seems to have broken things ("kcm does not load") by what people reported in irc for 5.13.1. By a quick investigation the main reason is, that the old plugin binary with the name "kded_touchpad" is used both to provide the plugin for kcm as well as

  1   2   3   4   5   6   >