D10499: [spellcheck runner] Make each suggestion copyable as separate item

kossebau added a comment. Thanks for review. In D10499#210493 , @broulik wrote: > > and then copy the correct or suggested into the clipboard for further usage? > > Calculator runner does `setText` on `QClipboard` in `run`, so I guess

D10337: First approach to a plasmoid that can display the state of caps lock

kossebau added a comment. Quick note before I forget again: doesn't this need some Messages.sh? There are some i18n calls in the QML. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol, #plasma, jriddell Cc: kossebau, graesslin, abetts, broulik,

D10659: [AppletConfiguration] Let applet override Return closing the dialog

kossebau added a comment. Eek. Undocumented secret properties make my toe nails roll up. Can this property become something more official, with real documentation (and test case), so that other applet config pages can make use of it as well? No real insight into design of applet

D10660: [Weather applet] Let Return invoke search

kossebau added a comment. Not tested, but seems good to me by pure reading. INLINE COMMENTS > ConfigWeatherStation.qml:33 > + > +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || > searchStringEdit.length === 0 > Slightly undecided: given above we use the `length`

D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f7fd71258f15: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2 (authored by kossebau).

D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2

kossebau added a comment. Taking the comments on D10450 about this patch as implicit +1 and going to push now, so there is 2 more days of build testing before the next release. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

kossebau added inline comments. INLINE COMMENTS > michaelh wrote in baloosearchrunner.cpp:103 > Baloo can also handle these types > > - Archive > - Spreadsheet (also found with type:Document) > - Presentation (also found with type:Document) > > see basicindexingjob >

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

kossebau added a comment. Could not reproduce that error locally, and build.kde.org had also not reported any problems. But given it failed for at least two people and the neon CI (https://build.neon.kde.org/job/xenial_unstable_plasma_plasma-desktop_bin_amd64/528/consoleFull) there might

D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2

kossebau created this revision. kossebau added reviewers: FreeBSD, tcberner, bshah, mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also improves race

D10596: Remove uninstalled themerc files for no longer existing Qt themes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4149b474d301: Remove uninstalled themerc files for no longer existing Qt themes (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10596: Remove uninstalled themerc files for no longer existing Qt themes

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH deleteunusedthemercfiles REVISION

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

This revision was automatically updated to reflect the committed changes. Closed by commit R114:cd25c7078ab2: [konsolesession runner] Rename to konsoleprofiles, no sessions here (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D10259: [Look and feel KCM] Fix copying color scheme data

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6ab44dcb86b1: [Look and feel KCM] Fix copying color scheme data (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10259?vs=26399=27313#toc REPOSITORY R119 Plasma

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10259 To: kossebau, broulik, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

This revision was automatically updated to reflect the committed changes. Closed by commit R119:502e8dc1080f: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddfc158a6715: Have all krunner plugin desktop files prefixed with plasma-runner- (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10515?vs=27170=27183#toc REPOSITORY

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With all desktop files being installed in

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

kossebau added a subscriber: ltoscano. kossebau added a comment. @ltoscano Some question about the translation catalog which gets renamed here as well, from "plasma_runner_konsolesessions" to "plasma_runner_konsoleprofiles": Plasma 5.12 branch has the konsolesessions.po catalogs

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Possibly because the runner was based on the kate session

D10499: [spellcheck runner] Make each suggestion copyable as separate item

kossebau added inline comments. INLINE COMMENTS > spellcheck.cpp:222 > +Plasma::QueryMatch match(this); > +match.setType(Plasma::QueryMatch::HelperMatch); > match.setIconName(QStringLiteral("checkbox")); Not sure if HelperMatch is the correct thing here.

D10499: [spellcheck runner] Make each suggestion copyable as separate item

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Before all suggestions are only shown as single item with a

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

kossebau added a reviewer: mart. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10485 To: kossebau, #freebsd, tcberner, bshah, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

kossebau created this revision. kossebau added reviewers: FreeBSD, tcberner, bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also improves race condition on creating the

D10398: [krunner] No need to duplicate work of KAboutData::setApplicationData

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c6dc4b566c7e: [krunner] No need to duplicate work of KAboutData::setApplicationData (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10400: Use KDEInstallDir variables instead of custom calculated install paths

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e04947534c77: Use KDEInstallDir variables instead of custom calculated install paths (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10400?vs=26804=26825#toc REPOSITORY

D10400: Use KDEInstallDir variables instead of custom calculated install paths

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Consistent usage of install variables avoids mismatches for

D10398: [krunner] No need to duplicate work of KAboutData::setApplicationData

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also let KAboutData handle app arguments REPOSITORY R120

D10386: Fix LnF theme data for window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R31:ed754c8ba48d: Fix LnF theme data for window decoration (authored by kossebau). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10386?vs=26758=26790 REVISION DETAIL

D10384: Fix LnF theme data for window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R113:0f9d5c8e1bdc: Fix LnF theme data for window decoration (authored by kossebau). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10384?vs=26756=26789 REVISION

D10386: Fix LnF theme data for window decoration

kossebau added a comment. Once confirmed, would also fix the same with the normal Breeze package (which I only now found, being in plasma-workspace, while I expected plasma-desktop). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10386 To: kossebau, mart Cc:

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Okay, got my test user setup working again and thus finally can test how the code behaves in real life, next to the unit test. Turns out that the "bug" is not opposed to the user by some magic things happening. In the normal usage the new setting is somehow

D10386: Fix LnF theme data for window decoration

kossebau created this revision. kossebau added a reviewer: mart. kossebau added a project: Plasma. kossebau requested review of this revision. REVISION SUMMARY Plasma LnF KCM reads the window decoration data from cg = KConfigGroup(conf, "kwinrc"); cg = KConfigGroup(,

D10384: Fix LnF theme data for window decoration

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Plasma LnF KCM reads the window decoration data from cg =

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau updated this revision to Diff 26662. kossebau added a comment. keep also ampersand with varname, not type, in method signature REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26661=26662 BRANCH portmediawiki REVISION DETAIL

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau updated this revision to Diff 26661. kossebau marked an inline comment as done. kossebau added a comment. update to kai's feedback REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26208=26661 BRANCH portmediawiki REVISION DETAIL

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau marked 2 inline comments as done. kossebau added a comment. Thanks for first round of review :) INLINE COMMENTS > broulik wrote in mediawiki.cpp:134 > Categorized logging, perhaps? Yes, though I plan to do this later in one concentrated go for all of kdeplasma-addons, so things

D10268: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2b7dbb611b35: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

kossebau resigned from this revision. kossebau added a comment. Tried few times to grasp all the related code to give this some insightful review, but always ran out of time. Sadly not qualitfied to review this code in reasonable amount of time. At least triggered some general quality

D10268: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN

kossebau created this revision. kossebau added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH appstreamrunnertranslations REVISION

D10262: [Look and feel KCM] Fix creating a broken colors scheme file in KcmTest

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Writing just a sausage name into the test color scheme file

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Oh, and this fixes the unit test "KcmTest::testKCMSave()" which is failing since https://phabricator.kde.org/R119:cf49d415e7bb30e98c0e7529e7307d8449b8ffcd (both in 5.12 and master after yesterday's merge). REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10259 To: kossebau, broulik, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Another option would be to move the configGroup.writeEntry("ColorScheme", scheme); behind the config-copy loop. But then I would think that we do not want to blend in the kdeglobals config into the color schemes files data in general, or? There is

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau created this revision. kossebau added reviewers: broulik, davidedmundson, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Using one argument with

D10223: Improve preview thumbnail quality

kossebau added a comment. Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma Cc: kossebau,

D9835: Bump min cmake version to 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fc53e3420188: Bump min cmake version to 3.0 (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9835?vs=25197=26250#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

kossebau closed this revision. kossebau added a comment. Has been committed as https://phabricator.kde.org/R114:36f5e02ea22e57f4bccffb40bb0bcb85c38118e4 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10163 To: kossebau, jriddell, mart, davidedmundson Cc:

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau updated this revision to Diff 26208. kossebau added a comment. rebase to latest master REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26186=26208 BRANCH portmediawiki REVISION DETAIL https://phabricator.kde.org/D10184

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau created this revision. kossebau added reviewers: broulik, jriddell, davidedmundson, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Straight initial port of

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

kossebau added a comment. I just saw that 5.12 beta tarballs have all the po files for all the dead applets, runners etc, because of the translation system just executing Messages.sh etc, ignoring any skipped subdirs in the actual buildsystem. 5.12 being an LTS, perhaps it might make

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

kossebau edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10163 To: kossebau, jriddell, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

kossebau created this revision. kossebau added reviewers: jriddell, mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With no-one having invested into

D10110: Port konsolesessions runner to Plasma5/Qt5

This revision was automatically updated to reflect the committed changes. Closed by commit R114:2f3bcfa8c61d: Port konsolesessions runner to Plasma5/Qt5 (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10110?vs=25972=26016#toc REPOSITORY R114 Plasma Addons

D10116: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a19c9118000c: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D10116: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner

kossebau created this revision. kossebau added reviewers: broulik, jriddell, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

kossebau retitled this revision from "Port baloo krunner plugin to KDBusRunner" to " [Draft] Port baloo krunner plugin to KDBusRunner". kossebau edited the summary of this revision. REPOSITORY R120 Plasma Workspace BRANCH portBalooRunnerToKDBusRunner REVISION DETAIL

D10110: Port konsolesessions runner to Plasma5/Qt5

kossebau created this revision. kossebau added reviewers: broulik, jriddell, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Ported following changes in

D10104: Port charrunner to Plasma5/Qt5

This revision was automatically updated to reflect the committed changes. Closed by commit R114:58e9e839f0a2: Port charrunner to Plasma5/Qt5 (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10104?vs=25959=25969 REVISION DETAIL

D10104: Port charrunner to Plasma5/Qt5

kossebau created this revision. kossebau added reviewers: broulik, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY As it has been part of Plasma4, is mentioned in

D10079: Port baloo krunner plugin to KDBusRunner

kossebau added a dependency: D10078: Add separate lib KF5::DBusRunner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10079 To: kossebau, davidedmundson, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10079: Port baloo krunner plugin to KDBusRunner

kossebau created this revision. kossebau added reviewers: davidedmundson, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH

D9872: [weather] Show optionally temperature next to icon in compact mode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ad04c42b28d1: [weather] Show optionally temperature next to icon in compact mode (authored by kossebau). REPOSITORY

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau added a comment. Given the feature freeze tomorrow, this being a non-critical feature at the outer spheres of plasma, the feature itself making sense surely, and being the de-facto maintainer of the weather applet code, I decided to just push this now. I have had run most of the

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau updated this revision to Diff 25326. kossebau added a comment. Align label text size twisting more with the one of fuzzyclock REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9872?vs=25307=25326 BRANCH

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau added a comment. Looks like this when enabled on the panels (tooltip shown for one on right panel): F5648962: Screenshot_20180114_124441.png Would really, really like to get this in for 5.12 :) All the layout logic might be a little

D9872: [weather] Show optionally temperature next to icon in compact mode

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Adds the logic for showing an alternative component

D9689: Add a per-process CPU usage graph shown in the process list

kossebau added a comment. Looks like a very nice to have feature :) (no review though, not my playground, was just curious when you pointed to it on irc) INLINE COMMENTS > ProcessModel.h:210 > +Q_DECLARE_METATYPE(QVector); > + > #endif You could also add `

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

kossebau added a comment. @broulik Seems to miss some include with Qt 5.7? build fails now on CI in the patched code: https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/15/ REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To:

D9835: Bump min cmake version to 3.0

kossebau added a subscriber: hein. kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:99 > > -ecm_configure_package_config_file(LibTaskManagerConfig.cmake.in > +configure_package_config_file(LibTaskManagerConfig.cmake.in >

D9835: Bump min cmake version to 3.0

kossebau edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9835 To: kossebau, #plasma, jriddell Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9835: Bump min cmake version to 3.0

kossebau added a comment. Similar fixes could be done to the other Plasma repos. Would care myself for kdeplasma-addons, as I have a build setup for that as well, so can test. INLINE COMMENTS > CMakeLists.txt:12 > find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets Quick

D9835: Bump min cmake version to 3.0

kossebau created this revision. kossebau added reviewers: Plasma, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Allows to drop ECMPackageConfigHelpers for

D9751: [weather] Add configuration option which weather services providers to use

This revision was automatically updated to reflect the committed changes. Closed by commit R114:18f3b152ca31: [weather] Add configuration option which weather services providers to use (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9751?vs=25049=25070#toc

D9751: [weather] Add configuration option which weather services providers to use

kossebau updated this revision to Diff 25049. kossebau marked 2 inline comments as done. kossebau added a comment. integrate Kai's feedback REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9751?vs=24977=25049 BRANCH

D9751: [weather] Add configuration option which weather services providers to use

kossebau marked 4 inline comments as done. kossebau added inline comments. INLINE COMMENTS > broulik wrote in configWeatherStation.qml:101 > Can you verify that toggling the MenuItem does not break this binding? It > shouldn't cause much trouble, though, as you only change selected services in

D9751: [weather] Add configuration option which weather services providers to use

kossebau added a comment. Drop-down menu looks like this (first item selected, hovering over second): F5631180: Screenshot_20180109_081008.png Additional advantage of the menu: makes it more transparent what services providers are currrently

D9751: [weather] Add configuration option which weather services providers to use

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY When searching a weather station/location to select for the

D9633: Add a private libPlasmaWeatherSolar for the ion data engines

kossebau abandoned this revision. kossebau added a comment. Discarding this one and instead went the route of async querying from the time dataengine... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9633 To: kossebau, #plasma, jriddell Cc: plasma-devel,

D9633: Add a private libPlasmaWeatherSolar for the ion data engines

kossebau added a comment. Better ideas very welcome, this is just a desperate first shot at the challenge. (Yes, right in time before feature freeze, boh me. One could also claim though it is rather a late Plasma5 porting regression fix ;) ) REPOSITORY R120 Plasma Workspace REVISION

D9072: make ksshaskpass work with git-lfs

kossebau resigned from this revision. kossebau added a comment. no clue about these ksshaskpass internals, sorry REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6054: Use explicit flag values or explicit constructor instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau added a comment. Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The constructor of QFlags which was intended to handle literal "0" as commonly used indicator of no-flags-set has

D5937: No longer build Plasmate by default

kossebau abandoned this revision. kossebau added a comment. Plasmate got moved into own repo now, discarding. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade, jriddell, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D5937: No longer build Plasmate by default

kossebau retitled this revision from "No longer built Plasmate by default" to "No longer build Plasmate by default". REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade, jriddell Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D5937: No longer built Plasmate by default

kossebau added a comment. IMHO Plasmate should not be released for default build also with Plasma 5.10. Distribution packagers seems to just look if things built, but not test the functionality, at least when it comes to Plasmate. E.g. for openSUSE plasmate is part of the package

D5937: No longer built Plasmate by default

kossebau created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Does not work currently and needs a maintainer. REPOSITORY R118 Plasma SDK BRANCH dontbuildplasmatebydefault REVISION DETAIL

D5914: Add template for Plasma QML Applet with QML extension

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4d5793c28a3f: Add template for Plasma QML Applet with QML extension (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5914?vs=14681=14687#toc REPOSITORY R242 Plasma

D5914: Add template for Plasma QML Applet with QML extension

kossebau added a comment. Get created template bundle here: https://share.kde.org/index.php/s/eHJGEku7pw7DotV REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D5914: Add template for Plasma QML Applet with QML extension

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Should help people to kick-off plasmoids which also use custom QML classes. TEST PLAN Created new plasmoid from

D5791: Allow to disable blinking cursor completely

kossebau added a comment. In https://phabricator.kde.org/D5791#108454, @kfunk wrote: > This is so trivial, yet I saw the demand for being able to disable the blinking cursor several times... > > Am I missing something or why was the minimum 200? Properly if blinking that was

D5405: Create desktop file name based on organization domain unless set explicitely

kossebau added a comment. In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage? In the current KAboutData

D5405: Create desktop file name based on organization domain unless set explicitely

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Having slept over this one night, I still think that this change should be not the way to go to fix the seen issues. The actual problem is bad usage in application code,

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5127 To: jriddell, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. kossebau added a comment. @jriddell : no use to have me as reviewer: I did not do the respective change of kdevplatform API, so cannot really tell if this is the correct usage here. Also have I never run plasmate, so cannot test this patch quickly.

[Differential] [Commented On] D4120: add support for display_name in categories

kossebau added a comment. Sounds good. While touching this, have you considered localized display names? While content description might be still English as lingua-franca, having the display name localized might be another step into the direction of average users which are not fluent in

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

as discussed on irc). Though my POV is limited, file widgets being not my playing ground, so perhaps better have someone else ship-it, too. - Friedrich W. H. Kossebau On Dec. 31, 2016, 9:42 a.m., Albert Astals Cid wrote

Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog

/kfiledialog_unittest.cpp (line 106) <https://git.reviewboard.kde.org/r/129732/#comment68101> Please also add a comment why `QTest::qWaitForWindowExposed()` is not used as with similar tests, not obvious to me at least. - Friedrich W. H. Kossebau On Dec. 31, 2016, 1:20 a.m., Albert Astals Cid

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

kossebau added a comment. Okay, thanks for fixing for Qt 5.8. Cherry-picked your commit also for the Plasma/5.8 branch now for upcoming Plasma 5.8.4 release, given Plasma 5.9.0 will only appear after Qt 5.8.0 (by schedules at least), so chances are people will want to run 5.8 with 5.8 :)

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kdeplatformfiledialoghelper.cpp:368 > This does NOT build for me. > > qplatformdialoghelper.h:295:5: error: > ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private >

<    1   2   3   4   5   6   >