D12936: Rewrite workspace KCM in QtQuick

furkantokac updated this revision to Diff 34351. furkantokac marked 16 inline comments as done. furkantokac added a comment. Bracked style correction. Removed translation data in ".desktop" files. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12936: Rewrite workspace KCM in QtQuick

furkantokac updated this revision to Diff 34353. furkantokac added a comment. kcm.cpp and kcm.h files are renamed as workspaceoptions.cpp and workspaceoptions.h to preserve the git history better. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12936: Rewrite workspace KCM in QtQuick

furkantokac updated this revision to Diff 34354. furkantokac added a comment. kcm.cpp and kcm.h files are renamed as workspaceoptions.cpp and workspaceoptions.h to preserve the git history better. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12974: Workspace KCM Code Improvement

furkantokac added a comment. In D12974#264920 , @ngraham wrote: > While we're doing some formatting and style cleanup work, how about renaming some variables? For example `m_ostateToolTip` and `m_ostateVisualFeedback` aren't very descriptive

D12973: Workspace KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 34500. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12973?vs=34459=34500 BRANCH kcmworkspace-Redesign REVISION DETAIL

D12974: Workspace KCM Code Improvement

furkantokac marked 3 inline comments as done. furkantokac added inline comments. INLINE COMMENTS > zzag wrote in workspaceoptions.cpp:37 > I think you could do something like this in the header file > > class ... { > ... > m_stateToolTip = true; > m_stateVisualFeedback = true;

D12974: Workspace KCM Code Improvement

furkantokac updated this revision to Diff 34499. furkantokac added a comment. State variable names are changed. Some formatting improvements. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12974?vs=34458=34499 BRANCH kcmworkspace-CodeFormatting

D12936: Rewrite workspace KCM in QtQuick

furkantokac updated this revision to Diff 34357. furkantokac added a comment. Bug fixed about checkbox check states. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12936?vs=34354=34357 BRANCH bug393547-SingleDoubleClickFunc REVISION DETAIL

D12946: Single/Double Click Option at Workspace KCM

furkantokac updated this revision to Diff 34379. furkantokac added a comment. Single/Double click implementation is done. Tested. Everything is working fine. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12946?vs=34370=34379 BRANCH bug393547-SingleDoubleClickClicking REVISION

D12946: Single/Double Click Option at Workspace KCM

furkantokac added inline comments. INLINE COMMENTS > romangg wrote in main.qml:90 > Just: `onSingleClickChanged: singleClick.checked = kcm.singleClick;` This is not okay. If singleclick is not set initially, doubleclick radio button should be enabled. This code doesn't to that. REPOSITORY

D12946: Single/Double Click Option at Workspace KCM

furkantokac updated this revision to Diff 34381. furkantokac added a comment. Qml padding added. Some small fixes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12946?vs=34380=34381 BRANCH bug393547-SingleDoubleClickClicking REVISION DETAIL https://phabricator.kde.org/D12946

D12946: Single/Double Click Option at Workspace KCM

furkantokac updated this revision to Diff 34380. furkantokac added a comment. QDBus is organized. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12946?vs=34379=34380 BRANCH bug393547-SingleDoubleClickClicking REVISION DETAIL https://phabricator.kde.org/D12946 AFFECTED FILES

D12946: Single/Double Click Option at Workspace KCM

furkantokac updated this revision to Diff 34382. furkantokac added a comment. QDBus is reorganized. Implementation is clear now. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12946?vs=34381=34382 BRANCH bug393547-SingleDoubleClickClicking REVISION DETAIL

D12936: kcm_workspace is finished.

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY kcm_workspaceoptions is changed as kcm_workspace. It is rewritten in QML, ConfigModule.

D12936: kcm_workspace is finished.

furkantokac added a comment. In D12936#263894 , @ngraham wrote: > BTW, here are a couple of formatting rules you should follow: https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch Oh I know it but just forgot.

D12973: Workspace KCM Redesign Using Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R119:78cd8bb31ea3: Workspace KCM Redesign Using Kirigami (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12973?vs=34500=34616 REVISION

D12974: Workspace KCM Code Improvement

furkantokac marked 8 inline comments as done. furkantokac added inline comments. INLINE COMMENTS > davidedmundson wrote in workspaceoptions.cpp:97 > We want to batch our syncs to plasmarc, which the old code did better. > > I wouldn't bother trying to be clever with checking if it's the

D12974: Workspace KCM Code Improvement

furkantokac updated this revision to Diff 34652. furkantokac added a comment. Changes are done according to feedbacks. For detailed information, please check the commit message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12974?vs=34499=34652

D12974: Workspace KCM Code Improvement

furkantokac updated this revision to Diff 34656. furkantokac added a comment. .qrc file is cancelled. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12974?vs=34652=34656 BRANCH kcmworkspace-CodeFormatting REVISION DETAIL

D12974: Workspace KCM Code Improvement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:de742972bf31: Workspace KCM Code Improvement (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES

D12936: Rewrite workspace KCM in QtQuick

furkantokac added inline comments. INLINE COMMENTS > zzag wrote in workspaceoptions.cpp:110 > Coding style nitpick: No whitespace after `(` and before `)`. Also, I > believe, there should be a whitespace between control statement keyword and > opening parentheses. Done. Thanks. I avoid small

D12946: Single/Double Click Option at Workspace KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d3ef895516fe: Single/Double Click Option at Workspace KCM (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12946?vs=34382=34393

D12936: Rewrite workspace KCM in QtQuick

This revision was automatically updated to reflect the committed changes. Closed by commit R119:856f58955aec: Rewrite workspace KCM in QtQuick (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12936?vs=34357=34387 REVISION

D12974: Workspace KCM Code Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY Code formatting is improved. "save" function is improved by preventing unnecessary file

D12936: kcm_workspace is finished.

furkantokac added a comment. In D12936#263939 , @ngraham wrote: > In D12936#263907 , @furkantokac wrote: > > > In D12936#263886 , @davidedmundson wrote:

D12936: kcm_workspace is finished.

furkantokac updated this revision to Diff 34343. furkantokac added a comment. Rewrite workspace KCM in QtQuick REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12936?vs=34332=34343 BRANCH bug393547-SingleDoubleClickFunc REVISION DETAIL

D12936: Rewrite workspace KCM in QtQuick

furkantokac added a comment. In D12936#263969 , @ngraham wrote: > Please follow standard KDE style for braces in new code: > > void myFunction() { > int stuff = 1; > } > According to Kdelibs Coding Style

D12973: Workspace KCM Redesign and Formatting Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH kcmWorkspaceFormatting REVISION DETAIL

D12973: Workspace KCM Redesign and Formatting Improvement

furkantokac updated this revision to Diff 34459. furkantokac added a comment. Workspace KCM is redesigned by using Kirigami. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12973?vs=34454=34459 BRANCH kcmworkspace-Redesign REVISION DETAIL

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. Just realized that paddings look bad in QQC2. Any recommendation ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot,

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35926. furkantokac added a comment. After a discussion, decided to go back to V0.2 because of some UI issues. Bug reports will be filed about the issues. For now, we'll use qqc1. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:251 > +id: accelProfileFlat > +Kirigami.FormData.label: i18n("Acceleration profile:") > +text: i18n("Flat") This label doesn't show up. If we put it to Column, it shows up vertically

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. If everyone is happy and the patch is tested, I'll push the code after a last test for Wayland and Xorg. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: safaalfulaij, mart,

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35908. furkantokac added a comment. V0.3 - QtQuickControls version is updated to 2.0. Some code cleaning. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=35809=35908 BRANCH arcpatch-D13372

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. In D13372#275788 , @safaalfulaij wrote: > Small question, why we're not using QQC2-based controls? Thanks! New diff is coming with QQC2-based controls. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35961. furkantokac added a comment. V0.3 sizeHint and minimumSizeHint are added. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=35926=35961 BRANCH arcpatch-D13372 REVISION DETAIL

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac added a comment. @davidedmundson @mart Thanks for the feedback. New patch is coming. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13573 To: furkantokac, romangg, ngraham, #plasma, mart Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel,

D13372: Mouse KCM Redesign Using Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e4ce025aa706: Mouse KCM Redesign Using Kirigami (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=36119=36122 REVISION

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 36119. furkantokac added a comment. V0.6 Wayland version (main.qml) is tested (X was already tested). Corrections are done. Functionality is same. All the possibilities are tested. Works fine. Ready to push. REPOSITORY R119 Plasma Desktop

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13573

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35974. furkantokac added a comment. Stupid mistake that I have done is fixed. Thank you romangg. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=35961=35974 BRANCH arcpatch-D13372 REVISION DETAIL

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35809. furkantokac added a comment. Update V0.2 Page is converted to ScrollablePage. ExclGroupBox converted to RadioButton since the titling is issue with ExclGroupBox + ScrollablePage. Middle-click title is updated. REPOSITORY R119 Plasma

D13372: Mouse KCM Redesign Using Kirigami

furkantokac marked an inline comment as done. furkantokac added inline comments. INLINE COMMENTS > mart wrote in main.qml:31 > KCM.SimpleKCM This is not based on KConfigModule yet so it is not okay to convert it to SimpleKCM since it'll look for "kcm" reference from the backend but will not be

D13372: Mouse KCM Redesign Using Kirigami

furkantokac marked an inline comment as done. furkantokac added a comment. Please test the code and if everyone is happy, I'll push the code. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: mart, plasma-devel,

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. In D13372#277040 , @mart wrote: > for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever. So please keep following

D13372: Mouse KCM Redesign Using Kirigami

furkantokac added a comment. In D13372#277078 , @mart wrote: > here a patch against this which ports it to qqc2, using the completely different radiobutton mechanics qqc2 uses, fixing separators, removing plasmacore import > F5907175:

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 36059. furkantokac added a comment. V0.4 QtQuickControls version is updated to 2.0. Some code cleaning. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=35974=36059 BRANCH arcpatch-D13372

D13372: Mouse KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 36061. furkantokac added a comment. V0.5 import org.kde.plasma.core is removed for main.qml. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13372?vs=36059=36061 BRANCH arcpatch-D13372 REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35066. furkantokac added a comment. "NoScroll" setting is removed. Feedbacks are applied. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=34950=35066 BRANCH kcmtouchpad-kirigamidesign REVISION

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269402 , @ngraham wrote: > Sadly, Libinput only allows one scrolling method to be active at once. See https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html > > So until and unless we can

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269312 , @esedgh wrote: > Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development. > > But now that you're at it, I may give you a bit of feedback

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REVISION SUMMARY Touchpad KCM is redesigned in Kirigami. Tested in Wayland+Libinput and Xorg+Libinput.

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#268853 , @ngraham wrote: > Is the user-facing control for the click method (areas or clickfinger) going to come in a separate patch? It might make sense to add

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:94 > +enabled: touchpadCount > 1 > +//Layouts.Layout.fillWidth: true > +implicitWidth: units.gridUnit * 10 This will go if nobody tells me it is necessary. I couldn't find any use case that this

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. @romangg There are some "TODO"s in the code. Please tell me if they still need to be applied so I'll do them, if they are not, I'll remove them. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added inline comments. INLINE COMMENTS > main.qml:466 > +} // END Kirigami.FormLayout > +} // END KCM.SimpleKCM This comment will be changed as "END Kirigami.ScrollablePage" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac,

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 34950. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=34949=34950 BRANCH kcmtouchpad-kirigamidesign REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269989 , @ngraham wrote: > Here's another idea for the multi-tapping radio button to reduce the string length: > > Two-finger tap: (o) Right-click (three-finger tap to middle-click) >

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35554. furkantokac added a comment. Combobox is expanded. MiddleEmulayion string is changed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=35545=35554 BRANCH arcpatch-D13141 REVISION DETAIL

D13141: Touchpad KCM Redesign Using Kirigami

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:dd1244d66766: Touchpad KCM Redesign Using Kirigami (authored by furkantokac). REPOSITORY R119 Plasma Desktop

D13372: Mouse KCM is redesigned by using Kirigami. Tested on Xorg and Wayland. Functionality is same.

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13372

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35527. furkantokac added a comment. Tapping strings are changed. Natural scrolling string is added. If there is only 1 touchpad, device combobox set to insvisible. ScrollablePage is changed with Page. REPOSITORY R119 Plasma Desktop CHANGES

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35545. furkantokac added a comment. Combobox is always visible. Combobox manual resizing is removed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=35527=35545 BRANCH arcpatch-D13141 REVISION

D13672: Mouse KCM Pointer Speed Slider Improvement

This revision was automatically updated to reflect the committed changes. Closed by commit R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13672?vs=36495=36714

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac updated this revision to Diff 36783. furkantokac added a comment. "value" part of last "Slider" patch is reverted since that kind of changes will be handled with another patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:239 > Let's do this in a separate commit where we change it along with the same > value in the Mouse KCM. Sure it will be better. Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13767

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac updated this revision to Diff 36801. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13767?vs=36783=36801 BRANCH arcpatch-D13767 REVISION DETAIL https://phabricator.kde.org/D13767

D13767: Touchpad KCM Pointer Speed Slider Improvement

This revision was automatically updated to reflect the committed changes. Closed by commit R119:86e674c6a2b9: Touchpad KCM Pointer Speed Slider Improvement (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13767?vs=36801=36802

D13573: Touchpad KCM QtQuickControls2 Conversion

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6a4b5870fb2f: Touchpad KCM QtQuickControls2 Conversion (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13573?vs=36648=36649

D13672: Mouse KCM Pointer Speed Slider Improvement

furkantokac added a comment. In D13672#281774 , @ngraham wrote: > `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old dumb text. :) This patch actually solves the problem specified on bug title, "libinput pointer

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac updated this revision to Diff 36648. furkantokac added a comment. Typo fix. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13573?vs=36308=36648 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13573 AFFECTED FILES

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac updated this revision to Diff 36308. furkantokac added a comment. V0.2 Converted everything to qqc2. SizeHint is corrected. Tested. Please review it. After your review, I'll also enable the Acceleration Profile with this patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE

D13573: Touchpad KCM QtQuickControls2 Conversion

furkantokac added a comment. In D13573#280026 , @ngraham wrote: > Looks good to me too. > > In D13573#279852 , @furkantokac wrote: > > > - Please review it. After your review, I'll also enable

D13672: Mouse KCM Pointer Speed Slider Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13672

D14016: Splitting Touchpad KCM, Stage 2

furkantokac created this revision. furkantokac added a project: Plasma. furkantokac requested review of this revision. REVISION SUMMARY Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new

D13997: Splitting Touchpad KCM

furkantokac updated this revision to Diff 37484. furkantokac added a comment. Phase 1 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13997?vs=37464=37484 REVISION DETAIL https://phabricator.kde.org/D13997 AFFECTED FILES

D14017: Splitting Touchpad KCM, Stage 3

furkantokac created this revision. furkantokac added a project: Plasma. furkantokac requested review of this revision. REVISION SUMMARY kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. kcm_touchpad is dummy for now. Tested, it is working. REPOSITORY R119 Plasma

D13997: Splitting Touchpad KCM

furkantokac updated this revision to Diff 37438. furkantokac added a comment. Stage 2 : Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new folder "touchpadx". Since "touchpad" folder is

D13997: Splitting Touchpad KCM

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13997

D13997: Splitting Touchpad KCM

furkantokac added a comment. Since you can review the old diff, I'm moving to stage 2. If you have problem with the Stage 1's diff, please tell me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13997 To: furkantokac, romangg, ngraham, #plasma Cc:

D13997: Splitting Touchpad KCM

furkantokac added a comment. In D13997#289384 , @romangg wrote: > If we go with this split the stages should be: > > 1. Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X

D13997: Splitting Touchpad KCM

furkantokac updated this revision to Diff 37464. furkantokac edited the test plan for this revision. furkantokac added a comment. Stage 3 kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. Tested and working fine. To test it, you should manually remove the old