Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-15 Thread Kai Uwe Broulik
it to be centered horizontally, and wrap, but a maximum of one line is allowed? This will have no effect whatsoever since the label will just grow outside horizontally because it has no width/side anchors set. - Kai Uwe Broulik On Aug. 14, 2014, 10:25 nachm., Dan Vrátil wrote

Paste Sticky note onto panel

2014-08-15 Thread Kai Uwe Broulik
Hi there, I just discovered when middleclicking a panel it will dump a sticky note there like it does on the desktop. Is this intended? Looks weird to me, at least when not in panel config mode. You can easily accidentally drop a note there but then not get rid of it without entering the

Re: Paste Sticky note onto panel

2014-08-17 Thread Kai Uwe Broulik
yes, is intended (and i was regularly using it in kde4, had a side panel just for that actually), when not locked (if this happens when actually locked is a problem) but note that locked != just panel controller closed Right, I had widgets unlocked. Now that mediacontroller handles

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-17 Thread Kai Uwe Broulik
screen on resume config option? ++1 That thing really ought to be in the Screen Locker config - Kai Uwe Broulik On Aug. 17, 2014, 3:10 nachm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Plasma popup window types

2014-08-17 Thread Kai Uwe Broulik
Hi there, I noticed that the scalein effect is applied to plasma popups interfering with the slidingpopups effect. The scalein checks for not window.popupMenu and window.specialWindow and window.utility and window.minimized as well as not effect.isGrabbed(window, Effect.WindowAddedGrabRole),

Review Request 119817: Display notification popup at the top for top panel

2014-08-17 Thread Kai Uwe Broulik
/97aea6b9-b71f-4787-9a9b-574b5c6e5bc4__toppopup.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-18 Thread Kai Uwe Broulik
On Aug. 18, 2014, 8:55 vorm., Martin Klapetek wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 162 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line162 Thinking about the label... What if we'd remove the Warning: part and either

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread Kai Uwe Broulik
/08/12/a246f3b3-bb12-4756-8069-594d25bd39f6__fuzzyonthedesktop.png Configuration UI https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/a144ea07-e18a-4a90-965a-3db51d91fb5d__fuzzyconfig.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing

Re: Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-18 Thread Kai Uwe Broulik
-594d25bd39f6__fuzzyonthedesktop.png Configuration UI https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/a144ea07-e18a-4a90-965a-3db51d91fb5d__fuzzyconfig.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 119866: Thumbnails in Klipper

2014-08-20 Thread Kai Uwe Broulik
-thumbnails.png https://git.reviewboard.kde.org//r/119866/#fcomment249 A tooltip might be useful, there's not much room for the filename. - Kai Uwe Broulik On Aug. 20, 2014, 6:29 nachm., Sebastian Kügler wrote: --- This is an automatically

Re: Plasma 5 - thank you

2014-08-21 Thread Kai Uwe Broulik
Hello Carl, Thank you for your kind words! Me and my fellow devs highly appreciate that. It's attractive. People are interested in what it is. It's fast, smooth. Kudos also to the Visual Design Group which managed to create an appealing fresh new design language for all of KDE in a relatively

Re: Review Request 119866: Thumbnails in Klipper

2014-08-22 Thread Kai Uwe Broulik
On Aug. 20, 2014, 6:38 nachm., Kai Uwe Broulik wrote: File Attachment: Klipper with thumbnails - klipper-thumbnails.png https://git.reviewboard.kde.org/r/119866/#fcomment251 A tooltip might be useful, there's not much room for the filename. Sebastian Kügler wrote: I thought

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-24 Thread Kai Uwe Broulik
checkbox in battery monitor has become quite small here now. - Kai Uwe Broulik On Aug. 20, 2014, 6:51 nachm., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-24 Thread Kai Uwe Broulik
/#comment45490 Remove the more, it's already graded. separately - Kai Uwe Broulik On Aug. 23, 2014, 11:19 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 119739: Don't hardcode applet configuration sidebar size

2014-08-24 Thread Kai Uwe Broulik
at 180dpi) but somebody with an ordinary display should definitely verify that. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118908: Adjust taskmanager tooltip size to window thumbnail

2014-08-24 Thread Kai Uwe Broulik
-8b7aacd237af__taskmanagertooltip1.png Grouped https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/f1df0096-271c-4229-8466-8374ef56492a__taskmanagertooltip2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 119920: Restore original checkbox and radio button size

2014-08-24 Thread Kai Uwe Broulik
Radio Button, in Radio Button it also does away with the hardcoded 6px margin used previously. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/119929/#comment45573 QHashint, Plasma::Containment * - Kai Uwe Broulik On Aug. 25, 2014, 1:24 nachm., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

2014-08-25 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/119797/#comment45574 Does that work? Shouldn't it be dataChanged() ? - Kai Uwe Broulik On Aug. 25, 2014, 1:39 nachm., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 119934: Make nothing interesting going on labels in applets consistent

2014-08-25 Thread Kai Uwe Broulik
/119934/diff/ Testing --- Device notifier still shows its label, notifications still show their label (not if there are notifications), mediacontroller unchanged. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 119934: Make nothing interesting going on labels in applets consistent

2014-08-25 Thread Kai Uwe Broulik
/notifications/package/contents/ui/main.qml fd39c57 Diff: https://git.reviewboard.kde.org/r/119934/diff/ Testing --- Device notifier still shows its label, notifications still show their label (not if there are notifications), mediacontroller unchanged. Thanks, Kai Uwe Broulik

Re: Review Request 119866: Thumbnails in Klipper

2014-08-26 Thread Kai Uwe Broulik
/clipboard.qml https://git.reviewboard.kde.org/r/119866/#comment45618 Math.round(…) ? Some minor nitpicks, otherwise looking fine. - Kai Uwe Broulik On Aug. 25, 2014, 11:20 nachm., Sebastian Kügler wrote: --- This is an automatically

Re: Review Request 119866: Thumbnails in Klipper

2014-08-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65343 --- Ship it! Ship It! - Kai Uwe Broulik On Aug. 25, 2014, 11

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Kai Uwe Broulik
Hi, I think for batteries, we're doing that already (at least in Plasma 4 we didn't add the battery plasmoid to the panel for desktop systems). I am not sure whether distributions with their custom layout.js picked that up (I'm not even sure if I changed that in our default layout) but

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/119974/#comment45711 Is that still needed? - Kai Uwe Broulik On Aug. 28, 2014, 12:30 nachm., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Kai Uwe Broulik
yeah, the function to check from the scripting engine is there and ported, but the systray doesn't use it and just adds it by default, i guess because there are brightness controls as well now And the PM checkbox which is handy on desktop too. And it shows your mouse battery, if any. So

Review Request 120003: Allow changing month with mouse wheel

2014-08-30 Thread Kai Uwe Broulik
/calendar/qml/MonthView.qml 2a14f28 Diff: https://git.reviewboard.kde.org/r/120003/diff/ Testing --- Yup. Going back and forth between months using mouse wheel and touchpad. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 119817: Display notification popup at the top for top panel

2014-08-30 Thread Kai Uwe Broulik
Notifications at the top https://git.reviewboard.kde.org/media/uploaded/files/2014/08/17/97aea6b9-b71f-4787-9a9b-574b5c6e5bc4__toppopup.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-30 Thread Kai Uwe Broulik
ago already. You need to rebase this then. I apologize for the inconvenience. - Kai Uwe Broulik On Aug. 23, 2014, 11:19 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread Kai Uwe Broulik
? applets/notes/plugin/filesystemnoteloader.cpp https://git.reviewboard.kde.org/r/120036/#comment45925 QDir::separator() - or at least QLatin1Char - Kai Uwe Broulik On Sept. 2, 2014, 11:02 vorm., David Edmundson wrote

Re: Review Request 120003: Allow changing month with mouse wheel

2014-09-02 Thread Kai Uwe Broulik
rather nicely. Traditional mouse wheel works perfectly. Diffs - src/declarativeimports/calendar/qml/MonthView.qml 2a14f28 Diff: https://git.reviewboard.kde.org/r/120003/diff/ Testing --- Yup. Going back and forth between months using mouse wheel and touchpad. Thanks, Kai Uwe Broulik

Re: Review Request 119920: Restore original checkbox and radio button size

2014-09-06 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/119920/diff/ Testing --- CheckBox looks like it did before, did not test Radio Button, in Radio Button it also does away with the hardcoded 6px margin used previously. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 120089: Taskbar: Enforce minimum stripes of 1

2014-09-07 Thread Kai Uwe Broulik
a minimumValue of 1 Diffs - applets/taskmanager/package/contents/ui/ConfigGeneral.qml 18243f6 applets/taskmanager/package/contents/config/main.xml 75eb45e Diff: https://git.reviewboard.kde.org/r/120089/diff/ Testing --- Minimum value of 1 is enforced Thanks, Kai Uwe Broulik

Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-07 Thread Kai Uwe Broulik
/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-07 Thread Kai Uwe Broulik
) - src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 9dc17fa src/qmlcontrols/kcoreaddons/formats.h 275f351 src/qmlcontrols/kcoreaddons/formats.cpp c853e97 Diff: https://git.reviewboard.kde.org/r/120087/diff/ Testing --- Adjusted battery monitor, shows proper value. Thanks, Kai Uwe

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-07 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-07 Thread Kai Uwe Broulik
, 2014, 1:24 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/ --- (Updated Sept. 7, 2014, 1:24

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-09 Thread Kai Uwe Broulik
, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-09 Thread Kai Uwe Broulik
/#review66125 --- On Sept. 9, 2014, 1:56 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/#review65987 --- On Sept. 7, 2014, 1:49 nachm., Kai Uwe Broulik wrote

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-10 Thread Kai Uwe Broulik
/kcoreaddons/formats.h 275f351 src/qmlcontrols/kcoreaddons/formats.cpp c853e97 src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 9dc17fa Diff: https://git.reviewboard.kde.org/r/120087/diff/ Testing --- Adjusted battery monitor, shows proper value. Thanks, Kai Uwe Broulik

Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/120141/diff/ Testing --- Works as it did before - just more beautiful :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
--- On Sept. 11, 2014, 10:28 vorm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- (Updated Sept. 11

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c Diff: https://git.reviewboard.kde.org/r/120141/diff/ Testing --- Works as it did before - just more beautiful :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
that have an animation, also when opacity=0 visible is considered false, so you can just remove the line Kai Uwe Broulik wrote: Ah, thanks for the tip. Sebastian Kügler wrote: Actually, visible and opacity are independent in QtQuick 2. opacity == 0 doesn't imply visible == false

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
that have an animation, also when opacity=0 visible is considered false, so you can just remove the line Kai Uwe Broulik wrote: Ah, thanks for the tip. Sebastian Kügler wrote: Actually, visible and opacity are independent in QtQuick 2. opacity == 0 doesn't imply visible == false

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Kai Uwe Broulik
Notifier notification ;) - Kai Uwe Broulik On Sept. 3, 2014, 4:16 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-11 Thread Kai Uwe Broulik
/notes/plugin/filesystemnoteloader.cpp https://git.reviewboard.kde.org/r/120036/#comment46244 Same here applets/notes/plugin/filesystemnoteloader.cpp https://git.reviewboard.kde.org/r/120036/#comment46245 will add spaces for you :) - Kai Uwe Broulik On Sept. 7, 2014, 3:07 nachm

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
--- On Sept. 11, 2014, 12:56 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141

Re: System tray icon sizes

2014-09-12 Thread Kai Uwe Broulik
Hi, One of the problems is that most of the tray icons use a Plasma IconItem which follows the icon sizes (16, 22, 32, 48, ...) whereas a custom item does not. This is also the reason why battery and network usually appear in a different size since they're using SvgItem which doesn't have this

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-12 Thread Kai Uwe Broulik
this still is ... color scheme, animations, selection delegate, page switch animation, etc, it's all very inconsistent. Kai Uwe Broulik wrote: Weird. The width is based on gridUnit for quite some time now. I didn't deliberately break that - does it work without this patch? We could

Review Request 120170: Use base color for applet configuration sidebar to match widget apps

2014-09-12 Thread Kai Uwe Broulik
Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120170: Use base color for applet configuration sidebar to match widget apps

2014-09-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120170/#review66516 --- On Sept. 12, 2014, 7:14 nachm., Kai Uwe Broulik wrote

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Kai Uwe Broulik
/#comment46466 The label wraps, right? That would probably overlap the action buttons, if any. applets/notifications/package/contents/ui/NotificationDelegate.qml https://git.reviewboard.kde.org/r/120232/#comment46467 Can/Why should there be links in the title? - Kai Uwe Broulik On Sept. 16

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-17 Thread Kai Uwe Broulik
desktoppackage/contents/configuration/ConfigCategoryDelegate.qml fd7b88c Diff: https://git.reviewboard.kde.org/r/120141/diff/ Testing --- Works as it did before - just more beautiful :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel

Re: System tray icon sizes

2014-09-21 Thread Kai Uwe Broulik
Btw, since we are refining systray icons, do they work also on a size of 22x22(if not I'll fix the code)? I would love to get rid of the old hack of 24x24, that is just a remnant of the xembed legacy icons Is that the reason why even if I use units.roundToIconSize on the batterymonitor the

Re: Review Request 120314: Add timezones support into clock applet

2014-09-22 Thread Kai Uwe Broulik
changes? - Kai Uwe Broulik On Sept. 22, 2014, 11:05 vorm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Kai Uwe Broulik
On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote: Doesn't always keeping Local enabled create an awkward situation if you want to default a clock to a non-Local timezone but want wheel scrolling disabled for accident-safety a la sebas? Then you need to: 1. Enable additional

Re: Review Request 120314: Add timezones support into clock applet

2014-09-24 Thread Kai Uwe Broulik
timezone 2. Enable wheelscroll 3. OK dialog 4. Change TZ by scrolling 5. Go back to dialog to disable wheelscroll Kai Uwe Broulik wrote: In Plasma 4.x there is a combo box that allows you to change the timezone without a mousewheel (which should be possible nonetheless, since

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-25 Thread Kai Uwe Broulik
is: Thursday, 25 September 2014 Berlin: 11:31 London: 10:31 Toronto: 4:31 - Kai Uwe Broulik On Sept. 25, 2014, 2:12 vorm., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

2014-09-25 Thread Kai Uwe Broulik
On Sept. 25, 2014, 9:33 vorm., Kai Uwe Broulik wrote: Can you provide a screenshot of the tooltip? Jeremy Whiting wrote: I'm using the same function to create the time format. but with a different argument. I guess I could make two separate functions instead, but why not just use

Review Request 120370: Make Battery Item behave like a regular IconItem

2014-09-25 Thread Kai Uwe Broulik
/2014/09/25/0712caf9-f9ef-4f95-9ab7-8fe5de5ae434__newiconsizes.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120370: Make Battery Item behave like a regular IconItem

2014-09-25 Thread Kai Uwe Broulik
. File Attachments Uniform icon sizes https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/0712caf9-f9ef-4f95-9ab7-8fe5de5ae434__newiconsizes.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 120370: Make Battery Item behave like a regular IconItem

2014-09-25 Thread Kai Uwe Broulik
Attachments Uniform icon sizes https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/0712caf9-f9ef-4f95-9ab7-8fe5de5ae434__newiconsizes.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 120374: Fix system tray icons not always properly centered in vertical panel

2014-09-25 Thread Kai Uwe Broulik
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/6d7c5583-dd0a-4f8a-a9e0-de331f55c182__trayiconsbefore.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/39f7ad29-3518-4d97-8d27-11c9e4dc1555__trayiconsafter.png Thanks, Kai Uwe Broulik

Re: Review Request 120374: Fix system tray icons not always properly centered in vertical panel

2014-09-26 Thread Kai Uwe Broulik
-3518-4d97-8d27-11c9e4dc1555__trayiconsafter.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 339447] Do not turn off the laptop after pressing the button Turn Off.

2014-09-27 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=339447 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de

Re: Review Request 120385: Cleanup system tray configuration

2014-09-27 Thread Kai Uwe Broulik
changing the extra items. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120386: Fix Apply button in applet configuration

2014-09-27 Thread Kai Uwe Broulik
/configuration/AppletConfiguration.qml 2da918e Diff: https://git.reviewboard.kde.org/r/120386/diff/ Testing --- Opened config, changed and applied values, switched between pages, in systray and digitalclock config. Config restored properly. Thanks, Kai Uwe Broulik

Review Request 120389: Fix collapsing panelcontroller buttons when they are too wide

2014-09-27 Thread Kai Uwe Broulik
is massive in German and the button gets wider than the window but that's out of this patch's scope) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120390: Fix NotificatonPopup size

2014-09-27 Thread Kai Uwe Broulik
/ Testing --- Ran knotificationdbustest and everything works as expected again, both initial positioning as well as re-positioning due to a popup disappearing. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 120389: Fix collapsing panelcontroller buttons when they are too wide

2014-09-27 Thread Kai Uwe Broulik
collapsed, tooltip appears on hovering. In vertical panel buttons have text (although that one is massive in German and the button gets wider than the window but that's out of this patch's scope) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list

Re: Review Request 120390: Fix NotificatonPopup size

2014-09-27 Thread Kai Uwe Broulik
/contents/ui/NotificationPopup.qml 63036f1 Diff: https://git.reviewboard.kde.org/r/120390/diff/ Testing --- Ran knotificationdbustest and everything works as expected again, both initial positioning as well as re-positioning due to a popup disappearing. Thanks, Kai Uwe Broulik

Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
has icon and text Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
accordingly - Mousewheel'd kmix, tooltip text was updated properly - Steam tooltip now has icon and text File Attachments (updated) Steam tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png Thanks, Kai Uwe

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/#review67566 --- On Sept. 28, 2014, 4:06 nachm., Kai Uwe Broulik wrote

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
--- On Sept. 28, 2014, 4:06 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407

Re: Review Request 120407: Show application title if SNI does not provide a tooltip

2014-09-28 Thread Kai Uwe Broulik
, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120386: Fix Apply button in applet configuration

2014-09-29 Thread Kai Uwe Broulik
and digitalclock config. Config restored properly. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Merging stable into master

2014-10-01 Thread Kai Uwe Broulik
What's up with those translations though? Merging is no fun atm because I get merge conflicts in desktop files all the time. Is Scripty not running on master or something? ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Kai Uwe Broulik
? - Kai Uwe Broulik On Okt. 2, 2014, 1:27 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67813 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 2, 2014, 1:27

Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
/ProgressBar.qml b872c97 Diff: https://git.reviewboard.kde.org/r/120489/diff/ Testing --- Change brightness to zero, no more couple of pixels area in the progress bar. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
this. Diffs - src/declarativeimports/plasmacomponents/qml/ProgressBar.qml b872c97 Diff: https://git.reviewboard.kde.org/r/120489/diff/ Testing --- Change brightness to zero, no more couple of pixels area in the progress bar. Thanks, Kai Uwe Broulik

Review Request 120491: Add indeterminate ProgressBar to test

2014-10-04 Thread Kai Uwe Broulik
/diff/ Testing --- Showed that switching this to an Animator is not as trivial as I thought :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/#review67930 --- On Okt. 4, 2014, 8:27 nachm., Kai Uwe Broulik wrote

Re: Review Request 120491: Add indeterminate ProgressBar to test

2014-10-04 Thread Kai Uwe Broulik
- tests/components/progressbar.qml a43b113 Diff: https://git.reviewboard.kde.org/r/120491/diff/ Testing --- Showed that switching this to an Animator is not as trivial as I thought :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list

Re: Review Request 120489: Hide PrograssBar inner item when value is 0

2014-10-04 Thread Kai Uwe Broulik
. This patch fixes this. Diffs - src/declarativeimports/plasmacomponents/qml/ProgressBar.qml b872c97 Diff: https://git.reviewboard.kde.org/r/120489/diff/ Testing --- Change brightness to zero, no more couple of pixels area in the progress bar. Thanks, Kai Uwe Broulik

Review Request 120500: Remove VLC workaround

2014-10-05 Thread Kai Uwe Broulik
: 332584 https://bugs.kde.org/show_bug.cgi?id=332584 Repository: plasma-workspace Description --- commit a998595ff7fa0751c894987e2a046ef685169ef5 Author: Kai Uwe Broulik k...@privat.broulik.de Date: Sun Oct 5 15:03:56 2014 +0200 Revert Fix mediacontroller showing twice for VLC

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Kai Uwe Broulik
application to handle text/html? That way it will always be the distribution's preferred browser. - Kai Uwe Broulik On Okt. 9, 2014, 8:41 vorm., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: wallpapers on lock screen

2014-10-13 Thread Kai Uwe Broulik
Hi, apparently OSX 10.8 Mountain Lion uses the current user's wallpaper, dimmed, whereas 10.9 Mavericks uses a generic gray background with Apple logo (with no way of changing that - apart from replacing a couple of system files) Cheers ___

Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel

2014-10-14 Thread Kai Uwe Broulik
On Okt. 14, 2014, 7:02 vorm., Martin Klapetek wrote: Could we possibly get Suspend button instead? Suspend stores the session state into memory and then restores it without any issues (and we lock screen on wakeup anyway); many times I have found my laptop with locked screen and I

Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel

2014-10-14 Thread Kai Uwe Broulik
as that drops you to the login manager where you can suspend. Sure not as comfortable as directly exposing it. But we don't need to expose every option which might make sense ;-) Kai Uwe Broulik wrote: Although closing the lid apparently reliably suspends the device, even when locked

Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel

2014-10-14 Thread Kai Uwe Broulik
as that drops you to the login manager where you can suspend. Sure not as comfortable as directly exposing it. But we don't need to expose every option which might make sense ;-) Kai Uwe Broulik wrote: Although closing the lid apparently reliably suspends the device, even when locked

Review Request 120602: Fix glitching Alternatives dialog

2014-10-15 Thread Kai Uwe Broulik
to not fill the entire screen. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120602: Fix glitching Alternatives dialog

2014-10-15 Thread Kai Uwe Broulik
) - desktoppackage/contents/explorer/AppletAlternatives.qml 4e97dc9 Diff: https://git.reviewboard.kde.org/r/120602/diff/ Testing --- Dialog flies in smoothly trying to display the list without scrollbars but is still properly max'd to not fill the entire screen. Thanks, Kai Uwe

Re: Review Request 120602: Fix glitching Alternatives dialog

2014-10-15 Thread Kai Uwe Broulik
--- Dialog flies in smoothly trying to display the list without scrollbars but is still properly max'd to not fill the entire screen. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Baloo - Not Indexing everything by default

2014-10-16 Thread Kai Uwe Broulik
Hi, * Desktop, Documents, Videos, Pictures and Music. All of these are xdg user directories. The only reason I actually index my kf5 folder with all the git clones in it, is because Dolphin doesn't properly fallback when searching non-indexed locations and then it won't find anything (in

Review Request 120604: Cleanup applet configuration scrollbar handling

2014-10-16 Thread Kai Uwe Broulik
loop warning (as far as I could see it in the verbose console output), no more once in a while appearing scrollbars when resizing dialogs smaller. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Should touch events update the cursor position?

2014-10-16 Thread Kai Uwe Broulik
Hi, I find it distracting to have the highly-visible cursor follow my finger all the time. What Windows 8 does - and I have to admit, that thing might suck on a Desktop but the touch hybrid stuff is quite well thought out - it hides the mouse cursor when touch interaction happens and shows a

<    1   2   3   4   5   6   7   8   9   10   >