marked as submitted.
Review request for Plasma, KDE Usability, Craig Drummond, Eike Hein, and Lukáš
Tinkl.
Changes
---
Submitted with commit e284e9dc17051f22d05985e218fa44ddaba78de5 by Kai Uwe
Broulik to branch master.
Bugs: 343632
https://bugs.kde.org/show_bug.cgi?id=343632
as submitted.
Review request for Plasma.
Changes
---
Submitted with commit d9719f10374f4885a3ae3efd7e3b4f23e953e59d by Kai Uwe
Broulik to branch master.
Bugs: 357352
http://bugs.kde.org/show_bug.cgi?id=357352
Repository: plasma-framework
Description
---
Animators do not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124586/#review91199
---
Ping
- Kai Uwe Broulik
On Jan. 2, 2016, 12:54 nachm., Kai
Broulik
On Nov. 23, 2015, 9:50 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/#review91201
---
Ping
- Kai Uwe Broulik
On Jan. 7, 2016, 9:05 nachm., Kai
apses (Review 126777) when I only have one virtual desktop
and re-appears if there are multiple. It also re-appears when I enter panel
configuration.
This should also be used for the quick chat applet.
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing
---
See Review 126776
Diffs
-
applets/pager/package/contents/ui/main.qml 0c367c6
applets/pager/plugin/pager.cpp ca31cb2
Diff: https://git.reviewboard.kde.org/r/126777/diff/
Testing
---
Works
Thanks,
Kai Uwe Broulik
___
Plasma
on.qml (line 152)
<https://git.reviewboard.kde.org/r/126779/#comment62314>
Space after if:
if (…) {
- Kai Uwe Broulik
On Jan. 18, 2016, 10:29 vorm., Eduardo Lara wrote:
>
> ---
> This is an automatically gener
> On Jan. 16, 2016, 11:04 vorm., Kai Uwe Broulik wrote:
> > - The busy cursor looks unlike anything we use elsewhere and eerily similar
> > to what Android has nowadays. It looks rather hectic and that the two lines
> > briefly connect looks awkward.
> > - The "
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 3dce39fd21eb36a1d912a299fad7fc3e2a4a7c72 by Kai Uwe
Broulik to branch Plasma/5.5.
Bugs: 357143
https://bugs.kde.org/show_bug.cgi?id=357143
Repository: plasma-workspace
Description
---
Doesn&#
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit dc7c3c1a0f25ae4e6f9d66b9c8df300d0768c9f7 by Kai Uwe
Broulik to branch master.
Repository: plasma-desktop
Description
---
With the newly introduced HiddenStatus we now have a way to hide panel applets
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit eb3b3006b9e275688481be7eb57b798f73d12faf by Kai Uwe
Broulik to branch master.
Repository: plasma-desktop
Description
---
See Review 126776
Diffs
-
applets/pager/package/contents/ui/main.qml
applets/quicklaunch/package/contents/ui/main.qml (line 106)
<https://git.reviewboard.kde.org/r/126786/#comment62379>
wrapMode: Text.NoWrap also?
- Kai Uwe Broulik
On Jan. 17, 2016, 9:35 nachm., David Rosca wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126786/#review91270
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Jan. 18, 2016
. disable the drop
area?
We have the problem of Firefox not opening a window because we eat the drop
event. Of course doing that won't solve the root cause but at least alleviate
it.
- Kai Uwe Broulik
On Jan. 18, 2016, 6:47 nachm., David Rosca
changes to the theme SVG files without the version
number having changed, we have a lot of people complaining about broken themes
with the 5.4->5.5 transition and we'll get this over and over again until we
find a solution for that.
- Kai Uwe Broulik
On Jan. 5, 2016, 6:11 nachm., Kai Uwe
n the Applet*interface* not
Applet.
- Kai Uwe Broulik
On Jan. 19, 2016, 12:25 nachm., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
> On Jan. 19, 2016, 8:41 nachm., Kai Uwe Broulik wrote:
> > Doesn't compile, contextualActionsAboutToShow is in the Applet*interface*
> > not Applet.
Also, it should probably call it on the currently active applet, not the syste
marked as submitted.
Review request for Plasma, KDE Usability and Eike Hein.
Changes
---
Submitted with commit f9e87f911bb7823b1ae1aca16606cc9b50adf7e0 by Kai Uwe
Broulik to branch master.
Bugs: 352126
https://bugs.kde.org/show_bug.cgi?id=352126
Repository: plasma-desktop
context menu entry for
the clipboard plasmoid. It even shows an arrow but there's no menu.
Might be the case when an applet's state is active but I have forcefully hidden
it?
- Kai Uwe Broulik
On Jan. 19, 2016, 12:29 nachm., David Edmun
enerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/#review91354
-------
On Jan. 19, 2016, 9:47 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To
Hi,I suggested removing them a couple of times. +1Also since it's not really the Air from 4.x but has some adjustments to use theme colors in tray icons before we dumped it in favor of Breeze. This makes it look r
Hi,Yes, please! That's the crazy idea Thomas and I had a while ago. Looking forward to see it implemented. I would make it a bit more generic though, ie. not necessarily tied to just window thumbnails.We now have
I misread the name, Window Metadata doesn't imply a restriction to thumbnails,
so all good for future exploration I guess :)
Awesome stuff!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
)
<https://git.reviewboard.kde.org/r/126837/#comment62494>
Please use the active property of Loader rather than setting the source in
various places.
- Kai Uwe Broulik
On Jan. 21, 2016, 3:04 nachm., Marco Martin wrote:
>
> -
> On Jan. 21, 2016, 4 nachm., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 102
> > <https://git.reviewboard.kde.org/r/126837/diff/1/?file=435073#file435073line102>
> >
> > Please use the active property of Loader rathe
7;s also a reserved QML keyword.
Also, you can access any role with a name clash by accessing it through
"model", ie. model.index
- Kai Uwe Broulik
On Jan. 23, 2016, 1:14 nachm., Daniel Faust wrote:
>
> ---
> This is an autom
> On Jan. 23, 2016, 1:22 nachm., Kai Uwe Broulik wrote:
> > id isn't particularly better either as that's also a reserved QML keyword.
> >
> > Also, you can access any role with a name clash by accessing it through
> > "model", ie. model.index
org/r/126642/#review91402
---
On Jan. 5, 2016, 6:11 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
marked as submitted.
Review request for Plasma and KDE Usability.
Changes
---
Submitted with commit 1ed7209f08aa69cec7847c606da8a2fc091dc603 by Kai Uwe
Broulik to branch master.
Repository: plasma-workspace
Description
---
Instead of showing a detached status bar with the device
name label
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
Works.
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
> On Jan. 24, 2016, 8:58 nachm., Jonathan Marten wrote:
> > Ping anyone?
Please if you fixed an issue raised mark is as fixed so the "open issues" count
drops, making it easier to see what has changed. After it's zero and you
already got a "Ship It" (see above, "Fix it", covered behind there's
enerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review91550
---
On Jan. 24, 2016, 9:40 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automa
--------------
On Jan. 15, 2016, 3:03 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
marked as submitted.
Review request for Plasma, Jan Grulich and Lamarque Souza.
Changes
---
Submitted with commit d8edcc6ab77836127f3cef5833bcd9e8a88a6e9f by Kai Uwe
Broulik to branch master.
Repository: plasma-nm
Description
---
It's quite natural that the connection goes
> On Jan. 27, 2016, 3:55 nachm., Thomas Pfeiffer wrote:
> > So, the situation is not that special: We ask for confirmation to err on
> > the side of caution (which makes sense since there is no going back) but
> > don't want to bother users with dialogs they don't care about. In fact, the
> >
rated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/#review91645
---------------
On Jan. 24, 2016, 9:49 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatical
t's german, so label longer than usual also doesn't
> help i guess)
>
> Kai Uwe Broulik wrote:
> I explicitly made it so the runner window keeps its size but I can make
> it grow accordingly. (is even easier code-wise)
>
> Marco Martin wrote:
> what about us
t's german, so label longer than usual also doesn't
> help i guess)
>
> Kai Uwe Broulik wrote:
> I explicitly made it so the runner window keeps its size but I can make
> it grow accordingly. (is even easier code-wise)
>
> Marco Martin wrote:
> what about us
d.kde.org/media/uploaded/files/2015/12/28/9f3046f1-6acb-460d-a515-6abab6522dfe__krunnerjumplists.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126593/#review91807
---
Ping
- Kai Uwe Broulik
On Jan. 1, 2016, 6:41 nachm., Kai
fcb0c57
Diff: https://git.reviewboard.kde.org/r/126929/diff/
Testing
---
Works like the Pager
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 2a05e6efd280fcb3c902a82a1a16b3e71530fdb0 by Kai Uwe
Broulik to branch master.
Bugs: 298306
http://bugs.kde.org/show_bug.cgi?id=298306
Repository: ktp-desktop-applets
Description
---
This causes
d the
config dialog disappears immediately after it was shown.
I guess this is because hide on window deactivate in Dialog checks for whether
I tapped a containment, which I did, and then keeps the dialog open.
Thanks,
Kai Uwe Broulik
___
Plasma-
Description
---
I don't know why this was omitted.
Diffs
-
src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h 3e47f00
src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp a70ce90
Diff: https://git.reviewboard.kde.org/r/126937/diff/
Testing
---
Thanks,
Ka
26937/diff/
Testing (updated)
---
Works.
I added it to the lockscreen qml in hopes of finding a privacy vulnerability
but the greeter window stayed there no matter what. :)
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kd
marked as submitted.
Review request for Plasma and Martin Gräßlin.
Changes
---
Submitted with commit 8ea478dbcc3349dd421ac64fc5263801d6859185 by Kai Uwe
Broulik to branch master.
Repository: kdeclarative
Description
---
I don't know why this was omitted.
Diffs
-
- 12)
<https://git.reviewboard.kde.org/r/126930/#comment62693>
You can do that in the property directly:
property var layouts: [
{ shortName: "us", longName: "English" }
...
dialog.cpp 26d6710
Diff: https://git.reviewboard.kde.org/r/126143/diff/
Testing
---
Broke my UserSwitcher.qml file, got KRunner instead.
Fixed it, got the proper QML UI again.
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-dev
---
Works.
File Attachments
New close button
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma
"de(nodeadkeys)" and "de(neo)"
- Kai Uwe Broulik
On Feb. 1, 2016, 11:08 vorm., David Rosca wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
hat's because kscreenlocker_greet is a QGuiApplication and QToolTip used by
QtQuick.Controls requires QApplication
- Kai Uwe Broulik
On Feb. 1, 2016, 11:14 vorm., David Rosca wrote:
>
> ---
> This is an automatically generated e-mai
to the DesktopView?
- Kai Uwe Broulik
On Jan. 31, 2016, 2:51 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
pp (line 92)
<https://git.reviewboard.kde.org/r/126944/#comment62700>
You can use a lambda
- Kai Uwe Broulik
On Feb. 1, 2016, 12:58 nachm., David Rosca wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/#review91852
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Feb. 1, 2016, 1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126943/#review91851
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Feb. 1, 2016
marked as submitted.
Review request for Plasma, KDE Usability and Martin Gräßlin.
Changes
---
Submitted with commit 1aab04cec1c479d68171216b877d1b91a7af5adc by Kai Uwe
Broulik to branch master.
Bugs: 327530
https://bugs.kde.org/show_bug.cgi?id=327530
Repository: plasma-desktop
nager::BasicMenu
which we could use. Unfortunately QAction doesn't support "sections" so the
"Recent Documents" heading won't work with that.
- Kai Uwe Broulik
On Jan. 1, 2016, 6:41 nachm., Kai Uwe Broulik wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91876
---
+1
- Kai Uwe Broulik
On Feb. 1, 2016, 7:30 nachm., Martin
-4fef-8dc1-872588e967b5__simplifiedthemesettings.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
w.cpp bc40083
Diff: https://git.reviewboard.kde.org/r/126947/diff/
Testing
---
Dragged widget from Widget Explorer and successfully configured it.
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/ma
/
Testing
---
Works now.
KNotificationDBusTest also works fine.
Plasma Undo notifications are no longer persistent but this is unrelated to
this patch.
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
marked as submitted.
Review request for Plasma and Martin Klapetek.
Changes
---
Submitted with commit bec916168c269df8807678c61aeb551cc3aac10e by Kai Uwe
Broulik to branch master.
Repository: plasma-workspace
Description
---
This was an oversight when porting to call the dataengine
28)
<https://git.reviewboard.kde.org/r/126952/#comment62717>
Why not make this the ColumnLayout? Should give you sensible minimum sizing
of the dialog and stuff for free?
- Kai Uwe Broulik
On Feb. 1, 2016, 7:52 nachm., David Edmundson
ts/ui/FolderItemToolTipDelegate.qml
a8b6f44
containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb
Diff: https://git.reviewboard.kde.org/r/126956/diff/
Testing
---
Works. No more glitchy tooltips.
(I wish the thumbnails in Folder tooltips were bigger, though)
Thanks,
Kai Uwe Br
> On Feb. 1, 2016, 7:39 nachm., Boudhayan Gupta wrote:
> > +1
> >
> > Ideally the default look-n-feel package should include only two themes -
> > the default one and a high-contrast counterpart. In fact all other themes
> > should reside elsewhere.
> >
> > If we still want to "officially" pr
> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the
> > time I need the plasma oxygen theme too to give the user the one single
> > click feature (look & feel package). Is there an space where you can move
> > "un
ettings.
File Attachments
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/63234dfa-36e4-4daf-99ec-014ebb663c2c__Screenshot_20160201_231414.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma and Eike Hein.
Changes
---
Submitted with commit 954a4bc30b84b46d5cdfd9d5809dcd56fdff7dfd by Kai Uwe
Broulik to branch master.
Repository: plasma-desktop
Description
---
Show the title you would get in the popup also in the tooltip
/#comment62711>
QLatin1Char('.') ?
src/plasma/scripting/scriptengine.cpp (line 67)
<https://git.reviewboard.kde.org/r/126672/#comment62712>
This vector is already const, so it cannot detach
src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 484)
<https:/
ts
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma and Martin Gräßlin.
Changes
---
Submitted with commit 467565d4556b0481779e3aa0cbce47ed9a919318 by Kai Uwe
Broulik to branch master.
Repository: plasma-workspace
Description
---
Prevents them from being hidden by show desktop.
They&#x
)
<https://git.reviewboard.kde.org/r/126950/#comment62718>
Array.prototype.push.apply(runners, plasmoid.configuration.extraRunners)
is faster, sigh, JavaScript...
https://jsperf.com/array-prototype-push-apply-vs-concat/20
- Kai Uwe Broulik
On Feb. 1, 2016, 7:52 nachm.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126951/#review91897
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Feb. 1, 2016, 7
and update to kf5 with Kubuntu 16.04
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for
> > the switch it would be nice to give the user the posibility for an soft
> > switch.
>
> andreas kainz wrote:
> in addition a lot of dev's
---
On Feb. 1, 2016, 9:23 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126956/
> -
board.kde.org/r/126960/#review91926
---
On Feb. 1, 2016, 11:12 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
)
<https://git.reviewboard.kde.org/r/126962/#comment62753>
OpacityAnimator ?
- Kai Uwe Broulik
On Feb. 2, 2016, 3:10 nachm., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> if plasma provided
wallpapers via d-bus, it would not be a problem
We should add something like this nonetheless as parsing the config files broke
more than once already. Also there's requests for setting a wallpaper via DBus.
Unfortunately due to Plasma's modular architecture wrt wallpapers
359 - 360)
<https://git.reviewboard.kde.org/r/126968/#comment62775>
Braces pls
Also below
scripting/scriptedeffect.cpp (lines 363 - 365)
<https://git.reviewboard.kde.org/r/126968/#comment62774>
const the list and use range-for
- K
:)
- Kai Uwe Broulik
On Feb. 4, 2016, 8:30 nachm., Bernhard Friedreich wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
0/#review91907
---
On Feb. 1, 2016, 11:12 nachm., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.re
files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
How about this? #2
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
Thanks,
Kai Uwe Broulik
___
Plasma
optional and turned off by
default and were only re-introduced after frequent user complaints.
- Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92071
------------
deprecated.
Not sure about the QFileDialog stuff.
- Kai Uwe Broulik
On Feb. 5, 2016, 1:21 nachm., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
Marco,
Your weather dataengine pulls in Qt XML but doesn't find it. Had the same build
error locally.
Originalnachricht
Von: no-re...@kde.org
Gesendet: Samstag, 6. Februar 2016 11:44
An: sgcl...@kde.org; plasma-devel@kde.org
Antwort an: no-re...@kde.org
Betreff: Jenkins-kde-ci: plasma-worksp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126811/#review92126
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Feb. 6, 2016, 2
marked as submitted.
Review request for Plasma and KDE Usability.
Changes
---
Submitted with commit 4ebf130ee66a912a5dac360441a8c0060eab247e by Kai Uwe
Broulik to branch master.
Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org
marked as submitted.
Review request for Plasma, KDE Usability and Andrew Lake.
Changes
---
Submitted with commit 35bfaf2978ce4e24c07238b0230dd48b2ac6b566 by Kai Uwe
Broulik to branch master.
Repository: plasma-desktop
Description
---
This removes the theme editor thing in the
/kcategorizeditemsviewmodels.cpp (line 73)
<https://git.reviewboard.kde.org/r/126994/#comment62851>
This comment is obsolete now
- Kai Uwe Broulik
On Feb. 5, 2016, 8:16 nachm., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically g
> On Feb. 8, 2016, 9:29 vorm., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 52
> > <https://git.reviewboard.kde.org/r/126962/diff/2/?file=443681#file443681line52>
> >
> > onStatusChanged: {
> > if (status === Load
)
<https://git.reviewboard.kde.org/r/126962/#comment62864>
onStatusChanged: {
if (status === Loader.Ready)
?
- Kai Uwe Broulik
On Feb. 8, 2016, 3:24 vorm., Aleix Pol Gonzalez wrote:
>
> ---
> This is a
> On Feb. 8, 2016, 9:29 vorm., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 52
> > <https://git.reviewboard.kde.org/r/126962/diff/2/?file=443681#file443681line52>
> >
> > onStatusChanged: {
> > if (status === Lo
> Well, in any case, it has to be possible to permanently scroll the last item
> of a list above the action button, regardless of any property setting.
> Otherwise it would simply be broken, no matter how we change the action
> button
> behavior (as it would always be partially covered by the b
marked as submitted.
Review request for Plasma and Eike Hein.
Changes
---
Submitted with commit d290ac0d0e071fa69cf07f1c3b95d140ecbfbf97 by Kai Uwe
Broulik to branch master.
Repository: plasma-desktop
Description
---
Fixes the tooltips being broken for me (not properly resizing
t's german, so label longer than usual also doesn't
> help i guess)
>
> Kai Uwe Broulik wrote:
> I explicitly made it so the runner window keeps its size but I can make
> it grow accordingly. (is even easier code-wise)
>
> Marco Martin wrote:
> what about us
t's german, so label longer than usual also doesn't
> help i guess)
>
> Kai Uwe Broulik wrote:
> I explicitly made it so the runner window keeps its size but I can make
> it grow accordingly. (is even easier code-wise)
>
> Marco Martin wrote:
> what about us
marked as submitted.
Review request for Plasma and Vishesh Handa.
Changes
---
Submitted with commit efcdab0f7238762bfdabfd3ba3569676eb8890ba by Kai Uwe
Broulik to branch master.
Repository: milou
Description
---
This exposes the name and icon of the single runner that is currently
501 - 600 of 7784 matches
Mail list logo
