D27438: Increase System Tray Plasmoid spacing value slightly

kmaterka added a comment. There is already a margin added around icons, "units.smallSpacing / 2" if I remember correctly. IMO it is OK without additional spacing (maybe because I'm used to it?). Anyway, VDG should decide what is the best and what is consistent with other elements of Plasm

D27088: [applets/SystemTray] Implement sorting in the model

kmaterka added a comment. OK, I will wait for second review from @davidedmundson, @broulik or @mart. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D27088 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik Cc: mart,

D27401: [applets/SystemTray] Fix crash on shutdown

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ccd4536a6ce8: [applets/SystemTray] Fix crash on shutdown (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27401?vs=75690&id=75723 RE

D27401: [SysterTray] Fix crash on shutdown

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY When having expanded System Tray once, plasmashell crashes on teardown. BUG: 417552 FIXED-IN: 5.19.

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 75134. kmaterka added a comment. Rebase, only D27088 left REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74805&id=75134 BRANCH master REVISION DETAIL https:/

D27088: [SystemTray] Implement sorting in the model

kmaterka updated this revision to Diff 75112. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27088?vs=74837&id=75112 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27088 AFFECTED FILES applets/s

D27085: [SystemTray] Bunch of fixes and improvements in QML

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a79f80ed79ae: [SystemTray] Bunch of fixes and improvements in QML (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27085?vs=74832&id=

D27126: [SNI] Fix race condition in item registration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:31303ad3542b: [SNI] Fix race condition in item registration (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27126?vs=74929&id=74932

D27126: [SNI] Fix race condition in item registration

kmaterka added inline comments. INLINE COMMENTS > statusnotifierwatcher.cpp:69 > +if (m_registeredServices.contains(notifierItemId)) { > +return; > +} Is this OK? Are mid-method returns allowed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2

D27126: [SNI] Fix race condition in item registration

kmaterka updated this revision to Diff 74929. kmaterka added a comment. Updated the code. This time I was not event able to reproduce race condition. Is something like this OK? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27126?vs=74924&id=74929

D27126: [SNI] Fix race condition in item registration

kmaterka added a comment. It is hard to reproduce, but with enough tries you should get empty items in "hidden" area of system tray. I used this script: for i in `seq 1 100`; do echo $i telegram-desktop & sleep 2 killall telegram-desktop

D27126: [SNI] Fix race condition in item registration

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY If StatusNotifierItem is registered and then immediately destroyed, it is possible that QDBusServiceWatcher will n

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. ... and second one: D27088 . It contains model refactoring and sorting. After that two are accepped I will rebase this one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka

D27088: [SystemTray] Implement sorting in the model

kmaterka added a comment. Extracted from D26992 to make review easier REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27088 To: kmaterka, #plasma_workspaces, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27088: [SystemTray] Implement sorting in the model

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Replace two wrapping PlasmaCore.SortFilterModel with custom sorting on model side. Extract common code to base c

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. First revision: D27085 . In contains some random improvements REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik Cc:

D27085: [SystemTray] Bunch of fixes and improvements in QML

kmaterka added a comment. Unrelated changes extracted from D26992 to make review easier REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27085 To: kmaterka, #plasma_workspaces, #plasma Cc: plasma-devel, Orage, LeGast00n,

D27085: [SystemTray] Bunch of fixes and improvements in QML

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Few unrelated fixes, bunched togheter: - move some code from main.qml to PlasmoidItem where it belongs - eas

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74805. kmaterka added a comment. I will split it into smaller changes, this one is too big for a review. I'll keep it here as a backup. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74802&id=74805

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74802. kmaterka added a comment. Rebase2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74797&id=74802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26992 AFFECTED FILES applets/

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74797. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74586&id=74797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26992 AFFECTED FILES applets/s

D27068: [System Tray] Initially set correct category for plasmoids

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. I definitely need to split D26992 into smaller chunks :) I had it fixed, but obviously D26992 can't be merged f

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. This change is very big. I can try to split in into two (maybe more) id that's required. If yes, should I connect revisions somehow? Create task, add parent/child revision? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To:

D26992: [SystemTray] Use unified data model everywhere

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Use the unified data model everywhere, not just in configuration. This simplifi

D26850: [SystemTray] Fix model update in settings (missing icon)

This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R120:3ba955f4f5c5: [SystemTray] Fix model update in settings (missing icon) (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26924: [SystemTray] Remove scrolbar paddings

kmaterka added a comment. In D26924#601024 , @ngraham wrote: > The scrollbar changes are in 5.18; shouldn't this go to the stable branch instead of master-only? Yes, sorry, I forgot about this REPOSITORY R120 Plasma Workspace REVI

D26924: [SystemTray] Remove scrolbar paddings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2f08da60981a: [SystemTray] Remove scrollbar paddings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26924?vs=74383&id=74403 REVISI

D26925: Add IntelliJ IDEA project files to ignored

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a2a2609048f0: Add IntelliJ IDEA project files to ignored (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26925?vs=74384&id=74385 RE

D26925: Add IntelliJ IDEA project files to ignored

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Used by some developers, IntelliJ IDEA has nice git, diff and replace tools. RE

D26924: [SystemTray] Remove scrolbar paddings

kmaterka updated this revision to Diff 74383. kmaterka added a comment. Just reverting last update, I will create separate revision. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26924?vs=74381&id=74383 BRANCH master REVISION DETAIL https://

D26924: [SystemTray] Remove scrolbar paddings

kmaterka updated this revision to Diff 74381. kmaterka added a comment. - Add IntelliJ IDEA project files to ignored REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26924?vs=74380&id=74381 BRANCH master REVISION DETAIL https://phabricator.kde.

D26924: [SystemTray] Remove scrolbar paddings

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Removes additional paddings. Not needed when scrollbar is no longer overlaying

D26923: Fix systemtray configuration

kmaterka added a comment. Look good for me, but someone else from KDE team needs to approve this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26923 To: carewolf, #plasma_workspaces, davidedmundson Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-O

D26923: Fix systemtray configuration

kmaterka added a comment. Thanks for noticing! The `currentValue` property was introduced with QtQuick.Controls 2.14 (Qt 5.14). Very convenient, unfortunately Plasma 5.18 must support Qt 5.12. BTW. QML import

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#600853 , @carewolf wrote: > This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It works if I rename the variable to something else Are you using Qt 5.14? REPOSITORY

D26850: [SystemTray] Refresh icon in settings on update

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > broulik wrote in systemtraymodel.cpp:269 > Avoid `keys()` which creates a temporary list, instead use iterators > > const auto roleNames = sourceModel->roleNames(); > for (auto it = roleNames.begin()

D26850: [SystemTray] Refresh icon in settings on update

kmaterka updated this revision to Diff 74272. kmaterka added a comment. Iterator used REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26850?vs=74164&id=74272 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26850 AFFECTED FILES ap

D26719: [Battery Monitor] Glow icon on hover

kmaterka added a comment. Issue, notification icon is "bold" now: F7911982: Screenshot_20200122_195941.png before changes: F7911984: Screenshot_20200122_201557.png I need to fix it first. REPOSITORY R1

D26850: [SystemTray] Refresh icon in settings on update

kmaterka added a comment. Problem was in duplicated role names, which confused ListView/delegate. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26850 To: kmaterka, #plasma_workspaces, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26850: [SystemTray] Refresh icon in settings on update

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Fixes a bug, when system tray settings is opened and new application is o

D26719: [Battery Monitor] Glow icon on hover

kmaterka marked an inline comment as done. kmaterka added a comment. The question is: should I move this component somewhere else? PlasmaComponents3? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26719 To: kmaterka, #plasma_workspaces, #plasma, broulik, n

D26719: [Battery Monitor] Glow icon on hover

kmaterka updated this revision to Diff 73799. kmaterka added a comment. Remove leftovers from tests REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26719?vs=73767&id=73799 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26719 AFFEC

D26719: [Battery Monitor] Glow icon on hover

kmaterka updated this revision to Diff 73767. kmaterka added a comment. Apply to notification icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26719?vs=73766&id=73767 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26719 AFFECT

D26719: [Battery Monitor] Glow icon on hover

kmaterka updated this revision to Diff 73766. kmaterka added a comment. Separate component REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26719?vs=73739&id=73766 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26719 AFFECTED FILES

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Konrad Materka changed: What|Removed |Added Component|general |Battery Monitor CC

D26719: [Battery Monitor] Glow icon on hover

kmaterka added a comment. As proposed by @broulik in Bug 416310 it might be a good idea to create IconEffects.qml (or IconEffect.qml?). Ideally, it should have a feature parity with KIconEffect. Any recommendations? Where to put this component (

D26719: [Battery Monitor] Glow icon on hover

kmaterka added inline comments. INLINE COMMENTS > CompactRepresentation.qml:67 > -pluggedIn: batteryContainer.pluggedIn > -height: isConstrained ? batteryContainer.iconSize : > batteryContainer.iconSize - batteryLabel.height > -width: h

D26719: [Battery Monitor] Glow icon on hover

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, broulik, ngraham, davidedmundson. Herald added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY All icons in System Tray "glow" a little bit when mouse is over the icon. This is

D26586: [SystemTray] Rework system tray settings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2bfeb160bad: [SystemTray] Rework system tray settings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73504&id=73629 REVI

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. Is the review (by other Plasma members) done? Please let me know when can I push changes :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik,

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#594236 , @nicolasfella wrote: > There's a minor problem (that I've seen in other place as well). When scrolling the content overflows the frame on the top a bit: Should I use `import QtQuick.Controls 2

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#594211 , @ngraham wrote: > Some of the code looks a bit hairy to me, but I don't see anything catastrophic. :) What exactly? I can quickly fix/refactor that. REPOSITORY R120 Plasma Workspace BRANCH

D26586: [SystemTray] Rework system tray settings

kmaterka marked an inline comment as done. kmaterka added a comment. In D26586#593966 , @ahiemstra wrote: > There should be no need to explicitly specify paddings now that D26530 has landed. But there's a bun

D26586: [SystemTray] Rework system tray settings

kmaterka marked 2 inline comments as done. kmaterka added a comment. Anything else to change/fix? When is the code freeze, this Friday? INLINE COMMENTS > kmaterka wrote in ConfigEntries.qml:114 > Yes, I don't like this neither. It is a workaround for a problem in > Kirigami.AbstractListItem.

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73504. kmaterka added a comment. Replaced hack with explicit padding settings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73470&id=73504 BRANCH master REVISION DETAIL https://phabricator.kde.

D22176: Rework system tray settings

kmaterka added a comment. @ngraham You commented in wrong revision, this was is abandoned :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73470. kmaterka added a comment. Fixes for column size, it is calculated dynamically now REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73414&id=73470 BRANCH master REVISION DETAIL https://phabr

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#593549 , @ngraham wrote: > The alignment for items with shortcuts is a bit odd: F7881593: Screenshot_20200113_130125.png Yes, I know. Shortcuts can be really long,

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. @mart @ngraham I see heated discussion in D26530 . What should I do with scrollbars? I can change it to something like this: F7880950: image.png REPOSITORY R120 Plasma Workspace REVI

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73414. kmaterka added a comment. Removed feature that allowed to hide whole category. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73395&id=73414 BRANCH master REVISION DETAIL https://phabrica

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#593154 , @ngraham wrote: > There are no sections and everything's disabled. Hmm, there is one small change in the C++ model (category added), maybe you need to restart/logout so that C++ library is relo

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#593114 , @mart wrote: > fine for me too. OK, I will remove this feature. INLINE COMMENTS > mart wrote in ConfigEntries.qml:114 > this should never be necessary and will probably cause bugs. > It looks

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. Final decision: should I remove feature which allows to hide whole category? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: meven, nicolasfella,

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73395. kmaterka added a comment. Workaround for Kirigami.AbstractListItem REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73389&id=73395 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73389. kmaterka added a comment. Review fixes: Key shortcut header width Background Few other small changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73284&id=73389 BRANCH master REVISI

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. > The discussion about overlay vs non-overlay scrollbars is unrelated to whether or not to show a frame and background behind a scrollview. :) Just add the background for now I think. Oh, true, my mistake. It looks much better with background, thanks! > Fin

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#592050 , @ngraham wrote: > Much better! The scrollview needs a frame around it though. You can do this by adding this to it: Is it decided (D26530 )? Correct me if I

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. This changes is based on the idea from D22176 . It needs review and probably more testing. Is it visually correct? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma

D26586: [SystemTray] Rework system tray settings

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Combines settings of SNI icons and plasmoids in one list. BUG: 360307 FIX

D26530: ScrollView: Do not overlay scrollbars over contents

kmaterka added a comment. Example when current way looks bad: D22176 . We can live with that and add margins/padding when needed. Or not :) - Old-fashioned scrollbars are also bad, they look old and sometimes ugly (especially when list has different s

D22176: Rework system tray settings

kmaterka added a comment. It looks abandoned, but rewrite of configuration is very needed, users are confused (and there are bug reports due to this). I have few more idea: - checkbox "Always show all entries" is misleading now. It won't enable all applets. When checked, it is no lo

D26545: [SystemTray] Set maximum size to block tiling

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4a65dcefe494: [SystemTray] Set maximum size to block tiling (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26545?vs=73131&id=73134

D26545: WIP: [SystemTray] Set maximum size to block tiling

kmaterka added a comment. In D26545#590861 , @ngraham wrote: > FWIW it is possible to restore the original size by using the same tiling shortcut again. Oh, I tested this on multi-screen setup, but it is working indeed if: - I use sh

D26545: WIP: [SystemTray] Set maximum size to block tiling

kmaterka added a comment. There must be a better way to fix that. Layout.minimum = Layout.maximum has nice side affect that does what I want, but maybe better place is to change some (?) window flags in PlasmaCode.Dialog? INLINE COMMENTS > CalendarView.qml:36-37 > Layout.preferredHeigh

D26545: WIP: [SystemTray] Set maximum size to block tiling

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY System tray dialog/popup can be tiled. This should not be allowed, in this case expanded

D26395: [XembedSNIProxy] Hide container window when something shows it

kmaterka added a comment. In D26395#590409 , @davidedmundson wrote: > > What should be in FIXED-IN? AFAIK 5.18 is frozen. Should I commit it into master? > > 5.18 doesn't exist yet, let alone being frozen I guess I misunderstood "5.1

D26395: [XembedSNIProxy] Hide container window when something shows it

This revision was automatically updated to reflect the committed changes. kmaterka marked 3 inline comments as done. Closed by commit R120:69786a1ff947: [XembedSNIProxy] Hide container window when something shows it (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UP

D26395: [XembedSNIProxy] Hide container window when something shows it

kmaterka added a comment. What should be in FIXED-IN? AFAIK 5.18 is frozen. Should I commit it into master? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26395 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson Cc: plasma-devel, Le

D26395: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka added a comment. This is another approach to fix 357443 . It is still a workaround, but more reliable and uses better concept. INLINE COMMENTS > fdoselectionmanager.cpp:167 > +// workaround for BUG 357443: when KWin is restarted,

D26395: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. It is black with opa

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:21a89dd6e1ae: [XembedSNIProxy] Regression - really resize instead of notifying only. (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

kmaterka added inline comments. INLINE COMMENTS > sniproxy.cpp:228 > { > -xcb_configure_notify_event_t event; > -memset(&event, 0x00, sizeof(xcb_configure_notify_event_t)); xcb_configure_notify_event_t @davidedmundson In this commit

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

kmaterka added a comment. I don't know why I missed that, I tested D25777 but obviously not enough. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26088 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson Cc: plas

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Regression introduced in previous commit, review D25777 . Tray

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:24f75b2fda71: [XembedSNIProxy] Redirect and handle structure requests on the embedded window. (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:4 > make sure you update this sometime I have another fix ready :) In future I will want to cleanup the code a bit (formatting, maybe some refactoring). I don't know if this welcomed because this will break

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:154 > can you explain the swapping 0 and m_containerWid here? I knew someone will ask, I wanted to add comment here but you were too quick :) I was not following the standard - worked because most clients (in

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY When the window is embedded, it should not request position change. Sometimes applications are mis

D25580: [System Tray] Unified data model for System Tray items

kmaterka added a comment. In D25580#578732 , @trmdi wrote: > Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 I double checked that. If I understand correctly the

kquickcharts should be added to plasma-workspace as dependency

ation unavailable file:///home/user/kde/usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/CompactRepresentation.qml:27:1: module "org.kde.quickcharts" is not installed -- Regards: Konrad Materka

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Konrad Materka changed: What|Removed |Added CC||mate...@gmail.com --- Comment #41 from Konrad

D22176: Rework system tray settings

kmaterka added a comment. D25580 pushed, @nicolasfella, can you rebase? In addition, as we are basically removing categories, you need to remove: - `shownCategories` from `main.qml` - `categoryShown` from `AbstractItem.qml` - applicationStatus

D25580: [System Tray] Unified data model for System Tray items

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d2fa8e6b812: [System Tray] Unified data model for System Tray items (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=71232&

D25580: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 71232. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=71231&id=71232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 AFFECTED FILES apple

D25580: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 71231. kmaterka marked 5 inline comments as done. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=70464&id=71231 BRANCH master REVISION DETAIL https://phabric

D25580: [System Tray] Unified data model for System Tray items

kmaterka marked 5 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > nicolasfella wrote in ConfigEntries.qml:68 > You can try doing > > for (item of systemTrayModel) { > ] > > But I don't know if that will work Unfortunately model is not iterable. This code will be

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

This revision was automatically updated to reflect the committed changes. Closed by commit R120:02bbef3b506a: [XembedSNIProxy] Send all container windows to background on KWin restart (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka added a comment. In D25603#569113 , @davidedmundson wrote: > Alternatively, if we need to reset something when our window gets moved...could we watch for our window getting moved? > It'll be the more technically correct, and keeps th

Add D24530 to 5.17.4

Hi, I fixed one issue in D24530 but it didn't manage to be in the 5.17 release. I thought it is not important but seems it is quite annoying for users. How can I add this fix to Plasma 5.17.4? Can I just cherry-pick and push or some official approval is needed? -- Regards: Konrad Materka

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka updated this revision to Diff 70528. kmaterka added a comment. Empty line removed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25603?vs=70527&id=70528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25603 AFFECTED FILES

<    1   2   3   4   >