D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. In D19822#439167 , @hein wrote: > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. > The suggestion about the hover effect though is a nice one +1 I wonder if we should make it turn gray when hovering over the option and stay gray while muted, or just turn gray and then once you move your cursor away it gets its color back regardless of whether

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. > No, it's not. Yeah it is :D > Trivial options have a lot of cost attached to them: They make a UI noisier and more intimidating, and therefore less appealing. They also make it less effective by making it harder to find what you're looking for, as you have

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

rooty added a comment. > In projects where maintenance is lacking you will notice a trend towards options sprawl for that reason. That doesn't make sense. It might mean there's a lack of direction but not necessarily a lack of maintenance. Whether expansion leads to "option sprawl"

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

rooty added a comment. I like this idea, more variety Especially considering that the default setting doesn't really change, just gets renamed essentially? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze Cc: rooty, plasma-devel,

D19129: [sddm-theme] Apply new username prompt and user list icons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8ee8ca17290e: [sddm-theme] Apply new username prompt and user list icons (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 52408. rooty added a comment. Tidy up comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=52088=52408 BRANCH arcpatch-D19036 REVISION DETAIL https://phabricator.kde.org/D19036 AFFECTED FILES

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 52409. rooty added a comment. Missed a comma REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=52408=52409 BRANCH arcpatch-D19036 REVISION DETAIL https://phabricator.kde.org/D19036 AFFECTED FILES

D19148: Make shadow sizes linear

rooty added a comment. I don't see a difference either REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen,

D19077: Redesign the theme preview window

rooty added a comment. In D19077#417814 , @ngraham wrote: > > I'm not thrilled by the need to introduce new warnings in order to implement a hack. It's all a pretty stinky code smell, to be honest. :) Maybe @davidedmundson has

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

rooty added a comment. you got my vote, i think this looks a lot less stuck-on REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19280: [TaskManager] Modernize and reorganize configuration settings

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Works fine for me on neon, best wait for Nate's go-ahead but I'm convinced :D REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280

D19077: Redesign the theme preview window

rooty added a comment. P.S. I moved the background button to the bottom, F6635412: image.png and I removed the vertical spacer so the label below the picture would never get cut off again (that glitch was fairly annoying and unpredictable...)

D19077: Redesign the theme preview window

rooty added a comment. Maybe we should switch tack - the other KCMs just state "Icon theme by Author" or "Cursor theme by Author" in their tooltips. We could just do that here. "Theme by Author" The license and email/web addresses of the author don't seem to be crucial information and

D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. In D19214#419682 , @ngraham wrote: > OK, so let's pretend the password field height bug doesn't exist since it's gotta be solved elsewhere. Haha sure thing :D I mean I was meaning to wait until it was resolved

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty updated this revision to Diff 52578. rooty added a comment. Remove unnecessary (pasted) lines of code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52577=52578 BRANCH tighten-clock-shadow (branched from master) REVISION DETAIL

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty added a comment. In D19325#419745 , @rooty wrote: > Render shadows before labels Is "visible:" enough here or do I need layer.enabled too? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19325

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty updated this revision to Diff 52580. rooty added a comment. Render shadows before labels REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52578=52580 BRANCH tighten-clock-shadow (branched from master) REVISION DETAIL

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

rooty added a comment. In D19295#419562 , @ngraham wrote: > Hah! Doesn't get much simpler than this. ikr :D REPOSITORY R120 Plasma Workspace BRANCH battery-config-kirigami (branched from master) REVISION DETAIL

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c691ce09f18: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19325: [sddm-theme/lock screen] WIP, Tighten Clock shadows

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch tightens the shadows around the clock in the Breeze SDDM theme and lock screen so as to prevent the appearance of a diffuse

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty added a comment. @ngraham there's actually another problem here, but one that's more readily seen in UserDelegate.qml The shadow is rendered **after** the label - which results in the label being darker than it should be (the shadows should go under the label not on top). This is

D19369: [sddm-theme] Remove login screen blur effect

rooty updated this revision to Diff 52684. rooty edited the test plan for this revision. rooty added a comment. Clean up some more REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19369?vs=52680=52684 BRANCH no-more-blur (branched from master)

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Wow that's fancy. +1 I only wish we could also change the Splash Screen background the same way we can change the sddm theme background. Or better yet, have matching

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. Hold on, could we? If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze Could we make the sddm theme and this splashscreen use that same file? REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. I don't know... if we made the splash screen use the same image as the login screen, it would become an extension of the login screen. Because otherwise, for a user that's using a third party wallpaper for the breeze sddm theme, you've got (1) one wallpaper for

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. In D19373#420786 , @filipf wrote: > ^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty marked an inline comment as done. rooty added a comment. In D19325#420388 , @ngraham wrote: > Ah, I see now! I even implemented that, touché. :) > > Also, why did you change the shadow from a layer effect to a separate item? If that's

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. In D19409#421790 , @davidedmundson wrote: > The relevant preview we need to do is see how the blur looks over a near completely black and a near completely white image. Nearly entirely but not entirely

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. How's this - dark: F6644939: image.png and F6644942: image.png - bright: F6644947: image.png and F6644949: image.png

D19379: [sddm-theme] Add a bottom panel

rooty added a comment. In D19379#421018 , @broulik wrote: > I would prefer something less intrusive like a gradient. > > > wouldn't it be better to move them towards the center? > > People not finding the keyboard layout button and other

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. In D19409#421894 , @ngraham wrote: > Huge improvement. Don't forget to change the preview images in `lookandfeel/contents/previews/` though! > > Also this fixes https://bugs.kde.org/show_bug.cgi?id=398963. Sure

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty added a comment. In D19364#421161 , @ngraham wrote: > Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows. I'll add an outline sure > Another thing is that in my

D19369: [sddm-theme] Remove login screen blur effect

rooty marked an inline comment as done. rooty added inline comments. INLINE COMMENTS > ngraham wrote in Main.qml:136 > I'm not sure this removal is necessary or related to this patch. We might be > able to remove it anyway, if its fixed in 0.14 like the comment says, but > that should be in a

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#421170 , @ngraham wrote: > Hmm, that's a shame. Well, regardless of implementation, I'd like to see //some// form of animation when the size changes. :) But it looks very smooth already. It's choppy in

D19369: [sddm-theme] Remove login screen blur effect

rooty updated this revision to Diff 52766. rooty marked 2 inline comments as done. rooty added a comment. Bring back timer REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19369?vs=52684=52766 BRANCH no-more-blur (branched from master) REVISION

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421353 , @rooty wrote: > Bring back timer Better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19369 To: rooty, #vdg, #plasma, filipf, ngraham Cc: plasma-devel,

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay. P.S. What happens to the blur if sddm defaults to software rendering? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2286c89b9e31: [sddm-theme/lock screen] Tighten clock and username shadows (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421370 , @ngraham wrote: > Yep, looks great now! Let's wait to land this until all the dependent patches are approved too. Sure thing REPOSITORY R120 Plasma Workspace BRANCH no-more-blur (branched

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#421381 , @davidedmundson wrote: > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole Carousel system. I'm not sold on this idea :D I'm just worried it'll come out tacky

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. P.S. @davidedmundson I know this may not be the place to ask this, in regard to the blur/wallpaper fader, is it possible to implement the changes from D18377 in the wallpaper fader? Is that something I could file a report with Qt

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421378 , @davidedmundson wrote: > This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that. I can't believe I'm going to walk back my original argument

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421405 , @davidedmundson wrote: > RE: blur > > To do it the same way that patch did it in the end (Using sRGB textures) would require a Qt patch. That would magically fix all shaders. I've not tried, but it

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty updated this revision to Diff 52872. rooty added a comment. Add second user (Katie) to preview REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19409?vs=52871=52872 BRANCH adjust-blur (branched from master) REVISION DETAIL

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty updated this revision to Diff 52874. rooty added a comment. Bring back comment deleted by accident REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19433?vs=52873=52874 BRANCH bump-up-label-fonts (branched from master) REVISION DETAIL

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty updated this revision to Diff 52871. rooty added a comment. Update preview image REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19409?vs=52792=52871 BRANCH adjust-blur (branched from master) REVISION DETAIL

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch increases the font size of the username and action button labels for better readability. REPOSITORY R120 Plasma

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty added a comment. In D19433#422367 , @filipf wrote: > In any case, I'd like to have it like this: > > - no shadows with blur Even though the shadows are pretty, I'm inclined to agree that no shadows might be a better fit. >

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty added a comment. The cliff-notes version of the level 4 vs level 3 problem F6646443: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19433 To: rooty, #vdg, #plasma, ngraham Cc: filipf, ngraham,

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty added a comment. In D19433#422364 , @filipf wrote: > The difference is too jarring with level 3. pointSize then, because the fonts are too hazy if you use level 4. Not to belabor the point but take a closer look at the screenshots

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty added a comment. In D19409#422361 , @filipf wrote: > In D19409#422203 , @rooty wrote: > > > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty added a comment. In D19364#422438 , @mglb wrote: > What about adding the same shadow under icons? Otherwise it looks like a text floating above flat background. We're actually deliberating on whether to abandon the shadow idea

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty added a comment. In D19409#422572 , @ngraham wrote: > Yeah, that doesn't look great. :/ > > For elements like the actionbuttons and the username that will always appear over a blur, I guess we should abandon the text shadows. For the

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty added a comment. In D19433#422564 , @ngraham wrote: > It's probably not the worst thing in the world if we use hardcoded font sizes here. We already do for the clock, and the login screen isn't able to read user-chosen font sizes anyway,

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty updated this revision to Diff 52928. rooty added a comment. Use pointSize, adjust username/password font sizes as well, adjust lock screen font sizes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19433?vs=52883=52928 BRANCH

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty added a comment. Okay, then I'll just update the preview here seeing as there's nothing else to be done here REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19409 To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf Cc: plasma-devel, jraleigh,

D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. In D19214#424106 , @ngraham wrote: > Hmm, the Kirigami text field doesn't look like that in an app. Must be some weird SDDM environment thing? > > Either way, let's fix the height issue *somehow*. :) It's sorta

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty added a comment. The animator causes a little bit of a problem (keep your eye on the Sleep button): F6655268: consequences-of-advanced-spellcasting.mp4 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty updated this revision to Diff 52930. rooty added a comment. Roll back preview change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19409?vs=52872=52930 BRANCH arcpatch-D19409 REVISION DETAIL https://phabricator.kde.org/D19409

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

rooty added a comment. In D19433#422829 , @ngraham wrote: > In D19433#422827 , @rooty wrote: > > > P.S. I know it's unrelated but shouldn't the logout screen say "Restart" (like the SDDM theme)? I

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dd4176d1f669: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19458: [Logout screen] Change labels to match SDDM theme labels

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH rename-reboot-1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19458 AFFECTED FILES

D19458: [Logout screen] Change labels to match SDDM theme labels

rooty updated this revision to Diff 52935. rooty added a comment. Remove extra space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19458?vs=52934=52935 BRANCH rename-reboot-1 (branched from master) REVISION DETAIL

D19469: [sddm-theme] Update login screen preview image

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH update-preview-image (branched from master) REVISION DETAIL https://phabricator.kde.org/D19469 AFFECTED

D19458: [Logout screen] Change labels to match SDDM theme labels

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d8a7443605bd: [Logout screen] Change labels to match SDDM theme labels (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

This revision was automatically updated to reflect the committed changes. Closed by commit R119:604244b6cb66: [Kicker, Kickoff Dash] Change labels to match SDDM theme labels (authored by rooty). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19458: [Logout screen] Change labels to match SDDM theme labels

rooty updated this revision to Diff 52937. rooty added a comment. Include data.js REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19458?vs=52935=52937 BRANCH rename-reboot-1 (branched from master) REVISION DETAIL

D19460: [powerdevil] Correct labels

rooty added a comment. I wonder if people would notice if it ended in a preposition (ironically "Never turn the screen off" sounds nicer to me) INLINE COMMENTS > ngraham wrote in activityWidget.ui:72 > While we're touching this, I think "Never turn off the screen" would sound > more

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty added a comment. In D19468#423093 , @ngraham wrote: > Won't the outlines get drawn when blurred if software rendering is in use? I can't get any blur with software rendering though? Another problem too - forcing software rendering

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 52976. rooty added a comment. Disable shadows with softwareRendering enabled REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=52954=52976 BRANCH shadows-only-when-inactive (branched from master)

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 52978. rooty added a comment. Correct typographical error REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=52976=52978 BRANCH shadows-only-when-inactive (branched from master) REVISION DETAIL

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch follows patch D19458 and applies the same label changes to Kicker/Kickoff/Dash.

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

rooty added a comment. P.S. I'd like to be able to upload screenshots but I wrecked my Arch install an hour or so ago so I'm not going to be able to build this for at least a couple of hours :D Sorry REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19459 To:

D19460: [powerdevil] Correct labels

rooty added a comment. Should "Act like" be replaced with "Behave as?" REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D19460 To: rooty Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch corrects the grammar in certain labels and makes others conform with the KDE HIG. REPOSITORY R122 Powerdevil BRANCH

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when opaque

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch removes the shadow from the usernames on the login and lock screens. It also restricts the clock shadow to just the opaque

D19460: [powerdevil] Correct labels

rooty updated this revision to Diff 52958. rooty marked an inline comment as done. rooty added a comment. Shut down --> turn off REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19460?vs=52938=52958 BRANCH powerdevil-hig (branched from master)

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2eec8cb1b505: [sddm-theme/lock screen] Adjust login and lock screen blur effect (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

rooty updated this revision to Diff 52932. rooty added a comment. Introduce font adjustments to logout screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19433?vs=52928=52932 BRANCH arcpatch-D19433 REVISION DETAIL

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty added a comment. In D19409#422811 , @ngraham wrote: > You know, it occurs to me that we should probably change the previews after we're done with all of this, or else each patch will need its own adjusted preview images! Sorry to have

D19433: [sddm-theme/lock screen] Adjust login screen and lock screen font sizes

rooty added a comment. P.S. I know it's unrelated but shouldn't the logout screen say "Restart" (like the SDDM theme)? I just noticed it. Also "Log out" (or uppercase?) instead of "Logout"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19433 To: rooty,

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty added a comment. If I use PropertyAnimation instead of OpacityAnimator, the opacity problem seems to go away. Can anyone confirm? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #plasma Cc:

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

rooty accepted this revision. rooty added a comment. You have no idea how much of a headache not having this option has been huge +1 REPOSITORY R119 Plasma Desktop BRANCH task-manager-alternatives-in-item-context-menu (branched from master) REVISION DETAIL

D19467: [colors-kcm] Fix blurry previews

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Looks good to me. You might want to wait for someone else's say-so too tho REPOSITORY R119 Plasma Desktop BRANCH fix-blurry-previews (branched from master) REVISION DETAIL

D19479: [SDDM theme] Add opacity on hover to action buttons

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Very elegant REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #plasma Cc: plasma-devel,

D19372: [sddm-theme] Enlarge user avatar in focus

rooty updated this revision to Diff 53028. rooty added a comment. Rebase; add property animation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19372?vs=52683=53028 BRANCH arcpatch-D19372 REVISION DETAIL https://phabricator.kde.org/D19372

D19372: [sddm-theme] Enlarge user avatar in focus

rooty updated this revision to Diff 53030. rooty added a comment. Prevent user avatar in focus from becoming blurred REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19372?vs=53028=53030 BRANCH arcpatch-D19372 REVISION DETAIL

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. P.S. Should we use "live: true" or just delete the line? Because it's true by default, but this makes it clear that it shouldn't be live: false REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc:

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#421391 , @filipf wrote: > In D19372#421381 , @davidedmundson wrote: > > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

rooty added a comment. Actually this works on the logout screen too, at least on my setup: F6651424: simplescreenrecorder-2019-03-03_04.21.58.mp4 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D19510: [Logout screen] Fix label opacity failing

rooty added a comment. This is a neat workaround as discussed in D19479 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 To: filipf, #plasma, ngraham, rooty Cc: plasma-devel, jraleigh, GB_2,

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

rooty added a comment. P.S. I took the liberty of replacing Suspend with the word Sleep to the user prompt screen too e588bebe78d27a92da2db0ba4260c26f76e28743 REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19077: Redesign the theme preview window

rooty added a comment. The shadow's the culprit! If you add the height of the shadow (assign it an id beforehand), then there's no white bar at the bottom :D REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg,

D19077: Redesign the theme preview window

rooty added a comment. This color "hack" actually makes the rectangle's color match some kind of weird in-between color that's not in the color scheme: F6628246: 75f5ca80-946e-4324-8f24-977fc96bc09b.jpeg It takes on a color like the Applications tab

D19077: Redesign the theme preview window

rooty added a comment. In D19077#416439 , @filipf wrote: > In D19077#416432 , @rooty wrote: > > > In D19077#416430 , @filipf wrote: > > > > > You have

D19209: [sddm-kcm] Adjust Background label and button

rooty added a comment. Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: rooty, #vdg,

D19077: Redesign the theme preview window

rooty added a comment. In D19077#416726 , @mmustac wrote: > To be honest this kcm looks out of place when I compare it to the newer refurbished ones. The new look is quite an improvement compared to the current state but when I look at the

D19209: [sddm-kcm] Adjust Background label and button

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adjusts the "Background:" label (adds padding and changes its alignment) and button to align with the changes implemented

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty added a comment. In D19364#420865 , @filipf wrote: > Will let Nate verify that the outline patch has been done well here, but otherwise looks good. Wait but I haven't added outlines, just shadows... Should I add outlines for

  1   2   3   4   >