Re: New lockscreen

On Friday 11 of January 2013 10:28:22 Martin Gräßlin wrote: the implementation has been kept there AFAIK because people complain that we wanted to remove it. It would be nice if the people who want to have the old screen savers would step up to support the maintenance. Yes it would have been

Re: plasma-framework in kdereview

On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. So, do we really have to move it there? Imho would be prudent to keep it somewhere else where api/abi stability is not

Re: plasma-framework in kdereview

On Friday 25 of April 2014 15:43:39 Marco Martin wrote: On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi

Re: Review Request 118889: Use new Konqui in the about Dialog

the plush version for each of those. ASAP. Just saying. :) /ot - Luigi Toscano On June 22, 2014, 10:13 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889

Re: Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 applications.

/#comment44373 Just to be sure: is khelpcenter/kf5 meant to replace khelpcenter/kdelibs4, right? (no coinstallability) - Luigi Toscano On Ago. 3, 2014, 6:59 p.m., Matthew Dawson wrote: --- This is an automatically generated e-mail

Re: Minimum translation percentage for Plasma 5 releases (second take)

Albert Astals Cid ha scritto: After talking to a few people here in Randa about this issue, I come with an updated suggestion. * We ship all translations that are over a very low limit (say 5%) * When selecting a language in the language KCM that has less than $PERCENTAGE we show a

Re: Minimum translation percentage for Plasma 5 releases (second take)

On Wednesday 13 of August 2014 11:38:33 Albert Astals Cid wrote: El Dimecres, 13 d'agost de 2014, a les 01:09:04, Luigi Toscano va escriure: Albert Astals Cid ha scritto: This way we set the expectations correctly, and people that prefer running translated even if it's just 23%, can do

Re: Kioslave repos

On Wednesday 20 of August 2014 11:38:12 Jonathan Riddell wrote: On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at

Re: KDE Plasma Addons i18n Status

David Edmundson ha scritto: i18n people, KDE Plasma Addons is in a tricky i18n state. We have lots of code that hasn't yet been ported to Plasma 5, so naturally it is disabled. This means we have a lot of i18n strings that are basically unused in this release. I don't want to delete

Re: KDE Plasma Addons i18n Status

Luigi Toscano ha scritto: David Edmundson ha scritto: i18n people, KDE Plasma Addons is in a tricky i18n state. We have lots of code that hasn't yet been ported to Plasma 5, so naturally it is disabled. This means we have a lot of i18n strings that are basically unused in this release

Re: [kde-doc-english] Two new files in stable-kf5?

Antoni Bella Pérez ha scritto: Hi I not found these two translations in the trunk-kf5 branch. kde-workspace/desktop_kdelibs_kfilemetadata.po kde-workspace/libkonq.po As a translator, this seems strange. Redirecting to the appropriate lists... Ciao -- Luigi

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

Aleix Pol ha scritto: On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org

Re: Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 applications.

On Aug. 3, 2014, 7:05 p.m., Luigi Toscano wrote: Scarlett Clark wrote: Hello, I am trying to fix this exact issue in Kubuntu. I applied this patch and khelpcenter does indeed start now. However, documentation is not found for most apps. I think installing kdelibs4 to get

Re: Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 applications.

existing stuff and there are no conflicts with existing files. - Luigi Toscano On Aug. 3, 2014, 6:59 p.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119589

Re: kdeplasma-addons

Kai Uwe Broulik ha scritto: Hi everyone, I just noticed that there are no translations whatsoever for kdeplasma-addons, at least the German repository I checked [1] has an empty kdeplasma-addons folder. What's wrong there? :) [1]

Re: Plasma 5.2 bits for kdereview

Jonathan Riddell ha scritto: Plasma 5.2 is due out next month and there's a few KDE projects which would be good to be included. Please review these for inclusion in kde/workspace.. Bluedevil frameworks branch by David Rosca https://projects.kde.org/projects/extragear/base/bluedevil

Re: Plasma 5.2 bits for kdereview

Sebastian Kügler ha scritto: On Friday, December 19, 2014 18:46:11 Luigi Toscano wrote: kscreen and libkscreen maintained by Dan Vrátil. libkscreen is already released with Plasma but isn't in kde/workspace. https://projects.kde.org/projects/extragear/libs/libkscreen https

Re: Plasma 5.2 bits for kdereview

Jonathan Riddell ha scritto: polkit-kde already requested on this list http://thread.gmane.org/gmane.comp.kde.devel.general/68224/focus=85357 This has been moved, but master is still kdelibs4-based. - Is it going to change? - Is there a final kdelibs4-based branch that can be tracked for the

Re: Review Request 123131: Port kio_man away from kdelibs4support

the locale, I fear a difference between Qt locales and system locales; it should be properly checked - Luigi Toscano On March 25, 2015, 9:41 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: timing of KDE5 panel in login

On Friday 27 of March 2015 19:21:35 Takao Fujiwara wrote: I'd like to run a custom panel at bottom right in KDE5 for ibus(propertypanel.vala): https://github.com/ibus/ibus/tree/master/ui/gtk3 Hi, this is a Plasma 5 related question, try to ask on the plasma-devel list (now in CC, I don't

Re: Review Request 123473: Port mouse theme kcm to QML

to: applets/icontasks/metadata.desktop containments/folder/metadata.desktop kcms/access/kcmaccess.desktop kcms/baloo/kcm_baloofile.desktop which I think are unrelated. - Luigi Toscano On April 23, 2015, 4:08 p.m., Marco Martin wrote

[plasma-sdk/Plasma/5.3] /: Use the new DTD for KF5

Git commit 850d80e612ff33f17bab1e5a58cfe81da6d4da81 by Luigi Toscano. Committed on 22/04/2015 at 22:24. Pushed by ltoscano into branch 'Plasma/5.3'. Use the new DTD for KF5 Otherwise there is an implicit dependency on kdelibs4support. Sorry for the last-minute fix before the tagging day. CCMAIL

Review Request 123846: Enable translations for devicenotifications dataengine

/devicenotifications/Messages.sh PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123846/diff/ Testing --- I could not test it, sorry, but I had to report it before forgetting. Thanks, Luigi Toscano ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather

On May 19, 2015, 7:21 p.m., Lukáš Tinkl wrote: Yes, please backport as well Burkhard, please commit to Plasma/5.3; I will do the same, then merge into master. - Luigi --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 123846: Enable translations for devicenotifications dataengine

marked as submitted. Review request for Localization and Translation (l10n) and Plasma. Changes --- Submitted with commit b174a3c92601853bc499d9c2dc62fd8b440cbba8 by Luigi Toscano to branch Plasma/5.3. Repository: plasma-workspace Description --- The patch should be quite

Repository cleanup: kdereview/adjustableclock

Hi all, the SVN counterpart of the kdereview module contains an copy of adjustableclock plasma applet (Plasma/kdelibs4): http://websvn.kde.org/trunk/kdereview/plasma/applets/adjustableclock/ It has been there for a while, of course it would need a rewrite to work with Plasma 5 and there are more

Re: Review Request 124296: Update autostart kcm docbook to kf5

. - Luigi Toscano On Lug. 27, 2015, 7:12 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124296

Re: Review Request 124692: Add new entities for sebas and plasma-pa

go into 5.13, and also that Plasma 5.4 depends on 5.13. Otherwise people won't be able to generate the doc. Temporary workaround: don't use the entities in plasma-pa until Plasma 5.5. - Luigi Toscano On Ago. 11, 2015, 2:45 a.m., Sebastian Kügler wrote

Re: Plasma 5.4 branched

Jonathan Riddell ha scritto: I've branched plasma modules so stable is now Plasma 5.4, could someone ensure the translations are matching? kwayland-integration kmenuedit user-manager plasma-nm plasma-workspace oxygen powerdevil khotkeys kwayland breeze kgamma kde-cli-tools milou ki

Re: Plasma 5.4 branched

Jonathan Riddell ha scritto: plasma-sdk Extragear, right? kwallet-pam plasma-pa We don't have a stable i18n branch for kdereview, for obvious reason (a module in kdereview is transitioning). Is it possible to resolve this problem? I personally think that the two modules have been pushed to

Re: Review Request 124548: Proofread kgamma kcm docbook to kf5

the maintainer ack to ship this. - Luigi Toscano On Lug. 31, 2015, 3:02 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124548

Re: Review Request 124495: Proofread ksysguard docbook for kf5

on the maintainer for the content. - Luigi Toscano On Lug. 27, 2015, 8:48 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124495

Re: Review Request 124296: Update autostart kcm docbook to kf5

- Luigi Toscano On Lug. 23, 2015, 10:09 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124296

Review Request 126018: Use the plural form for "Notification" category

-notification.desktop 24fee0d Diff: https://git.reviewboard.kde.org/r/126018/diff/ Testing --- Thanks, Luigi Toscano ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126018: Use the plural form for "Notification" category

atically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126018/#review88227 ----------- On Nov. 10, 2015, 10:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated

Re: Review Request 126018: Use the plural form for "Notification" category

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 571985f5fd8b2ab1b0d8c91aeb96135ba04a789b by Luigi Toscano to branch master. Repository: systemsettings Description --- The word used to be plural (even if combined with other words) in the previous

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

depend on dbusmenu, but maybe it's just not implemented there. If sebas says it's fine, then I'm fine. I'm fine with committing as it is, but do we have an entity for plasma; ? - Luigi Toscano On Lug. 7, 2015, 6:47 p.m., Burkhard Lück wrote

Re: Scope of framework integration plugin?

On Monday 30 of November 2015 12:48:26 Martin Graesslin wrote: > Hi all, > > there is currently a review request to add OSX specific changes to framework > integration plugin [1]. > > This seems wrong to me. I think our framework integration plugin is about > integration Qt applications into the

Re: KActivities repository split

Ivan Čukić ha scritto: > Hi everyone, > > As previously announced, KActivities has been split into a few > separate repositories. This mail is mostly intended to notify our dear > packagers of the change, and the plan for the transition period. > > KActivities framework 5.19 (as released a few

Re: remove khelpcenter from next Plasma release?

On Wednesday 09 of March 2016 16:16:54 Sebastian Kügler wrote: > On Wednesday, March 09, 2016 17:05:14 Luigi Toscano wrote: > > That said, I perceive this email as "khelpcenter is not welcome in > > Plasma", > > probably with a maintainer ("hell-bent on keepin

Re: two exceptions for string freeze in Plasma

On Wednesday 09 of March 2016 09:26:05 Sebastian Kügler wrote: > On Tuesday, March 08, 2016 22:04:26 Luigi Toscano wrote: > > Sebastian Kügler ha scritto: > > > On Tuesday, March 08, 2016 21:20:22 Luigi Toscano wrote: > > >> Alexander Potashev ha scritto: > >

Re: remove khelpcenter from next Plasma release?

On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote: > On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote: > > > Let me cut right to the chase, do you want to maintain it? Does it need > > > to > > > be in Plasma? > > > > Yes, I can ma

Re: remove khelpcenter from next Plasma release?

Luigi Toscano ha scritto: > On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote: >> On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote: >>>> Let me cut right to the chase, do you want to maintain it? Does it need >>>> to >>>> be in Pl

Re: Review Request 124495: Proofread ksysguard docbook for kf5

> On Aug. 9, 2015, 4:38 p.m., Luigi Toscano wrote: > > Review on terminology fine by me; waiting a bit on the maintainer for the > > content. Plasma developers, any comment for this review? Can we commi

Re: remove khelpcenter from next Plasma release?

On Thursday 17 of March 2016 11:54:31 Aaron Honeycutt wrote: > Kubuntu uses it for our Documentation but our current tools do have a PDF > export option as well as epub so we could use a different tool to read > those files without khelpcenter. I do thank every developer for his/her > work and

Review Request 127417: Fix KDE -> Plasma in keyboard kcm strings

/keyboard/index.docbook 813dab4 kcms/keyboard/kcmmiscwidget.ui 3603b96 Diff: https://git.reviewboard.kde.org/r/127417/diff/ Testing --- It compiles, the modified strings are used. Thanks, Luigi Toscano ___ Plasma-devel mailing list Plasma

Re: remove khelpcenter from next Plasma release?

Luigi Toscano ha scritto: > Luigi Toscano ha scritto: >> On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote: >>> On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote: >>>>> Let me cut right to the chase, do you want to maintain it? Does it

Re: remove khelpcenter from next Plasma release?

On Wednesday 09 of March 2016 15:29:28 Sebastian Kügler wrote: > Hi all, > > [For the sake of sanity, please reply to both list, this topic affects > applications and Plasma.] > > One of the topics we are discussing at the current Plasma sprint is whether > we really want khelpcenter as part of

Re: Review Request 127417: Fix KDE -> Plasma in keyboard kcm strings

marked as submitted. Review request for Documentation and Plasma. Changes --- Submitted with commit 7a251c605761e344c55146aaef9f7bd55915a499 by Luigi Toscano to branch master. Repository: plasma-desktop Description --- See the summary. I did not commit it directly because I'm

Re: two exceptions for string freeze in Plasma

Sebastian Kügler ha scritto: > On Tuesday, March 08, 2016 21:20:22 Luigi Toscano wrote: >> Alexander Potashev ha scritto: >>> 2016-03-08 23:04 GMT+03:00 Ivan Čukić <ivan.cu...@kde.org>: >>>> We have had System Settings since ages, this patch just strea

Re: two exceptions for string freeze in Plasma

Alexander Potashev ha scritto: > 2016-03-08 23:04 GMT+03:00 Ivan Čukić : >> We have had System Settings since ages, this patch just streamlines >> other similar components to that naming scheme. > > OK then. Sorry for the noise. > Well, couldn't this be the right time to

Re: Review Request 126953: Remove Theme Details KCM

/Development/Tutorials/Plasma5/ThemeDetails - Luigi Toscano On Feb. 8, 2016, 12:15 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: status of kde/plasma kiosk framework in kf5

David Edmundson ha scritto: > ​Here's my list I spent the evening on from searching the code. When you are done with all the discoveries, could you please update the pages on wikis, like for example: https://userbase.kde.org/KDE_System_Administration#User_.26_Group_Profiles (and related

Re: Review Request 128447: KCM move digital camera into subsection removable-device

Applications and not in Plasma? - Luigi Toscano On July 17, 2016, 11:25 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wednesday, 1 February 2017 11:52:01 CET Alexander Zhigalin wrote: > Completely agreeing with Rene, Luigi and Milian. > All this sounds very sad to me. > Phabricator is indeed very powerful and better for management stuff. > But Differential is not even merely comparable to RB by ease of use,

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wednesday, 1 February 2017 10:31:44 CET Francis Herne wrote: > Sorry, forgot to reply-all and only sent to kdevelop-devel... > > - > > Hi, > > First off, there's a lot of postponed, or at least possibly-useful, > work on ReviewBoard which would be lost. Some of this is from

Re: Phabricator: All repositories registered - upcoming workflow changes

Ben Cooksley ha scritto: > On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin > wrote: >> On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: >> >> Hi, > > Hi Rene, > >> >> >From this point forward, communities should be moving away from >>> Reviewboard to Phabricator

Re: Phabricator: All repositories registered - upcoming workflow changes

René J.V. Bertin ha scritto: > On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: > >> You missed the point. This "bit rot" is not about disk damage but >> about software incompatibility. ZFS doesn't help with that... > > You mean diffs that no longer apply cleanly? In that case you

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ltoscano added a comment. In https://phabricator.kde.org/D4614#88485, @fabianr wrote: > > A case could be made that this information is actually the most interesting one, and could have a more prominent place, then on the last tab. Would it be possible to display the

[Differential] [Updated] D4671: Touchpad KCM: simplify few UI strings

ltoscano added a reviewer: subdiff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4671 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, subdiff Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Closed] D4671: Touchpad KCM: simplify few UI strings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc8c82ac1b43: Touchpad KCM: simplify few UI strings (authored by ltoscano). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4671?vs=11511=11561 REVISION

[Differential] [Changed Subscribers] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ltoscano added inline comments. INLINE COMMENTS > davidedmundson wrote in Messages.sh:6 > is this not overwriting the generated extraction above? As others pointed out: this is not needed: the new strings are already going to be extracted into baloowidgets.pot. Try it for yourself:

[Differential] [Request, 8 lines] D4671: Touchpad KCM: simplify few UI strings

ltoscano created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4671 AFFECTED FILES

[Differential] [Changed Subscribers] D4198: Require Qt 5.7

ltoscano added a subscriber: Sysadmin. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4198 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: #sysadmin, graesslin, plasma-devel, lesliezhai,

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

ltoscano added a comment. In https://phabricator.kde.org/D4797#90068, @subdiff wrote: > This looks weird, because painting a whole button is not a small hint for the user that he can interact with the element but looks more like a completely new independent button suddenly being

Re: Merging strings

Kristóf Kiszel ha scritto: > Hello, > > in the kde-workspace/kcm_activities5.po there is a message which isn't > translatable to Hungarian in itself, the message #28. If I translate it to a > space, it will look silly on the GUI, but if it could be merged with the > message #27 to "for %1 month"

Re: Review Request 128741: Update paths docbook

; if there are no objections from the Plasma team, this should go in before the freeze for 5.8. - Luigi Toscano On Ago. 23, 2016, 6:32 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

> On Ago. 16, 2016, 9:05 a.m., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 51 > > > > > > Well, qt5-webkit and kwebkitpart do still exist. They're just not > > really maintained (but

Re: Review Request 128907: Remove Konqueror kcm docbooks from plasma-desktop repo

> On Sept. 14, 2016, 4:55 p.m., Aleix Pol Gonzalez wrote: > > will you do the move from kde-runtime -> kdebase-apps? First we may want to split kde-baseapps (see the email on kde-core-devel), but apart from that, yes. - Luigi --- This

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

separate change (import + fixes), is it correct? Then it's fine by me (pending confirmation for the shipit), the changes are fine and we can refine it later (better than the current situation). - Luigi Toscano On Nov. 11, 2016, 10:31 a.m., Burkhard Lück wrote

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

separate change (import + fixes), is it correct? Then it's fine by me (pending confirmation for the shipit), the changes are fine and we can refine it later (better than the current situation). - Luigi Toscano On Nov. 11, 2016, 10:02 a.m., Burkhard Lück wrote

Re: Review Request 129380: remove kcm docbooks which have their code in other repos from plasma-desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129380/#review100807 --- Ship it! Inviala! - Luigi Toscano On Nov. 11, 2016, 7

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

the next Frameworks release to fix it, in case. - Luigi Toscano On Nov. 11, 2016, 4:39 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

it. There is enough time before the freeze of Plasma 5.9 (more than one month) to fix it in case of problems. - Luigi Toscano On Nov. 11, 2016, 4:38 p.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Sept. 15, 2016, 9:28 a.m., Luigi Toscano wrote: > > Can they be made co-installable with the ones with kde-runtime, as both > > modules can be available at the same time? This is the problem of the > > missing support for kcontrol5 > > > > It was alr

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

the calculation of the date in the library. But that can take ages, so this is more a note. - Luigi Toscano On Gen. 1, 2017, 9:38 a.m., Roman Standzikowski wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

> On Gen. 2, 2017, 6:37 a.m., Laurent Montel wrote: > > Seems ok. > > Ship it. > > Regards See the comments on the way to specify the new public holiday only from 2011. - Luigi --- This is an automatically generated e-mail. To reply,

Re: Plasma/5.9 branches created

Jonathan Riddell ha scritto: > I've created the Plasma/5.9 branches for Plasma ahead of the beta > release coming up shortly. > > [...] > > Translators please update stable translations for Plasma/5.9, and LTS > translations for Plasma/5.8. The translations of trunk5 (tracking master) have been

Re: announcement: plymouth-kcm in kdereview

Jonathan Riddell ha scritto: > On Thu, Dec 29, 2016 at 12:58:10PM +0100, Marco Martin wrote: >> Hi all, >> announcing a new KCM module to change the plymouth splash screen >> The repository is named plymouth-kcm and is headed for kdereview now. >> its final resting place would be the workspace

D5053: Fix terminology: use Plasma for the desktop

ltoscano added a comment. I'm not sure whether this is really about Plasma startup, or some modules work even when kded5 is started outside Plasma. I'm a bit lost about the current status. Otherwise I would have pushed the change directly. REPOSITORY R119 Plasma Desktop REVISION

D5053: Fix terminology: use Plasma for the desktop

ltoscano created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use Plasma when the sentence refers to the desktop. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D5053: Fix terminology: use Plasma for the desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7d8811a95c5: Fix terminology: use Plasma for the desktop (authored by ltoscano). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5053?vs=12481=12497

D5297: [TextFieldStyle] Fix textField is not defined error

ltoscano added a comment. please remember the right credentials when you push, if this is accepted REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5297 To: davidedmundson, #plasma Cc: ltoscano, plasma-devel, #frameworks, progwolff, lesliezhai,

D5405: Create desktop file name based on organization domain unless set explicitely

ltoscano added a comment. I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas,

D5405: Create desktop file name based on organization domain unless set explicitely

ltoscano added a comment. One thing for sure: the code should be moved back to the constructor, and not dynamically at each call of desktopFileName(), or it would be a behavioral change. (Or at least it should be probably cached if we get an agreement in breaking this). And regarding

D5405: Create desktop file name based on organization domain unless set explicitely

ltoscano added a comment. In https://phabricator.kde.org/D5405#101575, @mak wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the

D5405: Create desktop file name based on organization domain unless set explicitely

ltoscano added a comment. In https://phabricator.kde.org/D5405#101577, @kossebau wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the

D5405: Create desktop file name based on organization domain unless set explicitely

ltoscano added a comment. In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences,

D5445: update baloo kcm docbook

ltoscano added inline comments. INLINE COMMENTS > fvogt wrote in index.docbook:62 > Which current text? This got added. > > I'd phrase it like "Use 'Also index file content' to also index the file > contents additional to the file names". Right, I wanted to say "proposed text", not "current

D5445: update baloo kcm docbook

ltoscano added inline comments. INLINE COMMENTS > fvogt wrote in index.docbook:62 > That is a bit misleading IMO, "Use 'Also index file content' to only index > the filename or [...]" Uh, how is it different from the current text? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D5471: https://bugs.kde.org/show_bug.cgi?id=377994

ltoscano added a comment. I can't comment on the content of the patch, but I have a comment on the titles and the summary. The content of title+summary+test plan will become the git commit message, so I would: - change the title in a small summary of the change - in the body of

D5405: Create desktop file name based on organization domain unless set explicitely

ltoscano added a comment. In https://phabricator.kde.org/D5405#101624, @graesslin wrote: > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > > > In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > > > > > The desktop file name should follow the way how

D4939: Get rid of KDELibs4Support

ltoscano set the repository for this revision to R122 Powerdevil. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4070: Changes to global menu applet

ltoscano added inline comments. INLINE COMMENTS > main.qml:55 > +checked: checkable > +iconSource: appletEnabled ? i18n("application-menu") : > i18n("emblem-warning") > onClicked: { A bit late to the party, but if this is the freedesktop name of an icon, then it

D5490: Only follow mouse when moved (Fixes Bug #372635)

ltoscano added a comment. While you fix the issue with the code, please add a line BUG: 372635 in the summary instead of the other reference to the bug; this should send a notification and close the bug when the review is accepted. REPOSITORY R112 Milou REVISION DETAIL

Re: Retirement of SVN Commitfilter and Legacy Get Hot New Stuff systems

Ben Cooksley ha scritto: > Hi all, > > Last year sysadmin was given access to the system which hosts the SVN > Commitfilter (which lived at commitfilter.kde.org) and the predecessor > to the OCS network of sites (now store.kde.org). > > Earlier this year we started having some issues with that

Re: Retirement of SVN Commitfilter and Legacy Get Hot New Stuff systems

Ben Cooksley ha scritto: > On Sat, Jul 29, 2017 at 11:33 PM, Luigi Toscano > <luigi.tosc...@tiscali.it> wrote: >> Ben Cooksley ha scritto: >> >>> I've checked and it appears that only a small handful of applications >>> still use newstuff.kde.org: >

D5209: Load translations from KPackage files if bundled

ltoscano added a comment. In https://phabricator.kde.org/D5209#124129, @davidedmundson wrote: > contents/locale/fr/org.kde.blahblah.po > > which is the same as KDE4. I guess you mean contents/locale/fr/org.kde.blahblah.**mo** ? REPOSITORY R242 Plasma Framework (Library)

D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma

ltoscano created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fix the reference to KDE (or remove them when not strictly needed). TEST PLAN The code still compiles. REPOSITORY R119 Plasma Desktop

D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma

ltoscano added a comment. ... and few in-line questions for the reviewers. INLINE COMMENTS > autostart.cpp:75 > KAboutData* about = new KAboutData(QStringLiteral("Autostart"), > - i18n("KDE Autostart Manager"), > +

  1   2   3   >