D20248: Update link to Kdelibs_Coding_Style

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D20248 AFFECTED FILES HACKING To: meven Cc:

D20248: Update link to Kdelibs_Coding_Style

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c69acc0973a5: Update link to Kdelibs_Coding_Style (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20248?vs=55408=55456 REVISION

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven updated this revision to Diff 56123. meven added a comment. Fix formatting of details REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20492?vs=56113=56123 BRANCH arcpatch-D20492 REVISION DETAIL https://phabricator.kde.org/D20492 AFFECTED

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven added a comment. When AC is plugged: F6770195: ac-plugged.png When AC is unplugged: F6770194: ac-unplugged.png I have noticed that sometimes the remaining time is not available. In which case

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven added a comment. Also I'd like to display the duration naturally like "1 hour 30 minutes" instead of "1:30" as it does currently. Could someone point me to the right Kcore/KLocale feature for this ? I have done a little research but haven't found any, perhaps we are lacking the

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven updated this revision to Diff 56125. meven added a comment. No need to keep stored localy the batterRemainingTime REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20492?vs=56123=56125 BRANCH arcpatch-D20492 REVISION DETAIL

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven added a comment. In D20492#450265 , @ngraham wrote: > These are notifications that aren't shown by default, right? I believe so, and that the plugged out event is notified by a sound by default. But I am not sure at the moment.

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven added a comment. In D20492#448825 , @ngraham wrote: > Screenshots would be nice. :) That's my intent, we can yet talk about wording. I can now move forward after recompiling everything... REPOSITORY R122 Powerdevil REVISION

D20492: [WI] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Improve the notification when the ac adapter is plugged/unplugged. Displaying direcly in them the time remaining to empty or fill the

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 56369. meven added a comment. Port to QtQuickControls 2 and proper FormLayout REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56359=56369 BRANCH arcpatch-D20598 REVISION DETAIL

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven planned changes to this revision. meven added a comment. In D20533#450777 , @ngraham wrote: > In D20533#450711 , @broulik wrote: > > > -1 please let's cleanup / rewrite the energy info kcm

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. New State: F6776169: energy-information-after-2.png QtControls port is not done. It is just a step. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. After last patch : F6776301: energy-information-after-3.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf Cc: filipf, davidre, broulik, plasma-devel,

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 56376. meven added a comment. Fix FormLayout alignment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56369=56376 BRANCH arcpatch-D20598 REVISION DETAIL https://phabricator.kde.org/D20598 AFFECTED

D15418: Dim application icon when it is not playing anything

meven added a comment. In D15418#364811 , @mart wrote: > In D15418#331397 , @ngraham wrote: > > > Maybe something like this? > > > > F6283615: Screenshot_20180924_195355.png

D15418: Dim application icon when it is not playing anything

meven added a comment. In D15418#452214 , @meven wrote: > In D15418#364811 , @mart wrote: > > > In D15418#331397 , @ngraham wrote: > > > > > Maybe

D20533: Display two shortcuts to the kcm Energy Information from the battery applet.

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven updated this revision to Diff 56113. meven added a comment. Improve wording REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20492?vs=56063=56113 BRANCH arcpatch-D20492 REVISION DETAIL https://phabricator.kde.org/D20492 AFFECTED FILES

D16425: Added new Suspend then Hibernate option

meven added a comment. In D16425#448999 , @avaldes wrote: > I applied this patch to v5.15.4 tag and tested with that and it works (my machine is running plasma 5.15.4), I can change the brightness with the keyboard and set the

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. In D20598#471149 , @filipf wrote: > In D20598#455424 , @ngraham wrote: > > > This doesn't actually work for me. Upon opening, the following is printed to the console: > >

D10750: wayland: Add support for zwp_linux_dmabuf

meven added a comment. In D10750#327333 , @zzag wrote: > Any update on this? I am wondering as well. This seems like good progress was already done and what is left is some test fixes and polish. I can only encourage @fredrik and

D21273: Add support for newer linux kernel power_supply API

meven added a comment. Friendly ping to our dear reviewers @broulik @davidedmundson @hein REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: meven, alexeymin, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2,

D22028: Improve QWidget KCM and QML KCM consistency

This revision was automatically updated to reflect the committed changes. Closed by commit R102:4d5321648e9a: Improve QWidget KCM and QML KCM consistency (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60485=60619 REVISION

D22090: Fix a warning message

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Fix warning messages such as :

D22028: Improve QWidget KCM and QML KCM consistency

meven added a comment. In D22028#486409 , @ngraham wrote: > Could this be backported to the stable branch? It's a relative straightforward bugfix. Unfortunately no, it would cause a bug without the D20598

D22090: Fix a warning message

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2dbdc6c59168: Fix a warning message (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22090?vs=60645=60658 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60206. meven added a comment. Add some padding around the inline message when history is not available REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60205=60206 BRANCH arcpatch-D20598_1 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60193. meven added a comment. Rebase code, apply Filip's patch, fix right padding of graph REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=56376=60193 BRANCH arcpatch-D20598_1 REVISION DETAIL

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60205. meven added a comment. Use KCM.SimpleKCM as root item, fix padding issues, increment kcm version, clean up old now unnecssary workaround REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60193=60205

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven updated this revision to Diff 60208. meven added a comment. Fix text REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56903=60208 BRANCH arcpatch-D20533_2 REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20598: Port kcm energy info to kirigami 2, fix colors issues

This revision was automatically updated to reflect the committed changes. Closed by commit R102:bd3341235582: Port kcm energy info to kirigami 2, fix colors issues (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60231=60232

D21961: Port fileindexmonitor kcm to QQC2 and use KCM.SimpleKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R102:2451f2be74d7: Port fileindexmonitor kcm to QQC2 and use KCM.SimpleKCM (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21961?vs=60220=60236

D20598: Port kcm energy info to kirigami 2, fix colors issues

meven updated this revision to Diff 60231. meven added a comment. import QtQuick.Controls 2.5 as QQC2 REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20598?vs=60206=60231 BRANCH arcpatch-D20598_1 REVISION DETAIL https://phabricator.kde.org/D20598

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a4e231e7b6c0: Display a shortcut to the kcm Energy Information from the battery applet… (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21961: Port fileindexmonitor kcm to QQC2 and use KCM.SimpleKCM

meven created this revision. meven added reviewers: filipf, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D21961 AFFECTED

D22028: Improve QWidget KCM and QML KCM consistency

meven created this revision. meven added reviewers: mart, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY - Set QWidget KCMs title font size to the same one as QML ones - Add content margin to QWidget

D22028: Improve QWidget KCM and QML KCM consistency

meven updated this revision to Diff 60446. meven added a comment. Remove lines that shouldn't have been included REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60442=60446 BRANCH fix-title-qml REVISION DETAIL

D22012: Clean up old bug workarount in KCMFileIndexer

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D22012 AFFECTED FILES Modules/fileindexermonitor/kcm.cpp

D22044: Fix a Qml warning

meven created this revision. meven added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Fix a bad reference REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL

D22044: Fix a Qml warning

This revision was automatically updated to reflect the committed changes. Closed by commit R102:71dbbbeb64a1: Fix a Qml warning (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22044?vs=60486=60487 REVISION DETAIL

D22028: Improve QWidget KCM and QML KCM consistency

meven updated this revision to Diff 60485. meven added a comment. Remove changes that will go to another review REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60484=60485 BRANCH fix-title-qml REVISION DETAIL

D22028: Improve QWidget KCM and QML KCM consistency

meven updated this revision to Diff 60484. meven added a comment. Adjust font size REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60446=60484 BRANCH fix-title-qml REVISION DETAIL https://phabricator.kde.org/D22028 AFFECTED FILES

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven updated this revision to Diff 56588. meven added a comment. Inverted checks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56587=56588 BRANCH arcpatch-D20533_1 REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in batterymonitor.qml:142 > Generally we start menu items with action verbs. And in this case we don't > need ellipsis because no further input from the user is required as a part of > the

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven updated this revision to Diff 56602. meven added a comment. Start menu action with a verb REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56588=56602 BRANCH arcpatch-D20533 REVISION DETAIL https://phabricator.kde.org/D20533

D20863: Allow folder view elements to be be dropped using other Action than Copy

meven added a comment. In D20863#461260 , @ngraham wrote: > Now don't forget to merge to master. :) > > git checkout Plasma/5.15 > git pull > git checkout master > git merge -s recursive -Xours origin/Plasma/5.15 > git push

D20863: Allow folder view elements to be be dropped using other Action than Copy

meven created this revision. meven added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Relates to D20838 REPOSITORY R119 Plasma Desktop BRANCH

D20863: Allow folder view elements to be be dropped using other Action than Copy

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b753301b74ac: Allow folder view elements to be be dropped using other Action than Copy (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20863: Allow folder view elements to be be dropped using other Action than Copy

meven added a comment. @hein is it ok ? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20863 To: meven, ngraham, hein Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16425: Added new Suspend then Hibernate option

meven added a comment. In D16425#449330 , @avaldes wrote: > This is how the module looks with the new option: > F6770639: image.png > It looks the same as the "Even when an external monitor is

D16425: Added new Suspend then Hibernate option

meven added a comment. I tried using it but my system does not suspend-then-hibernate mode. You can check if your system supports it once you have systemd >= 239 and the following command returns true : qdbus org.freedesktop.PowerManagement /org/freedesktop/PowerManagement

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven updated this revision to Diff 56903. meven added a comment. Check the energy information is available before showing a link to it, don't show a link to it from the battery applet REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. In D20598#456309 , @filipf wrote: > Works for me, nice work with aligning the layouts. > > I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven updated this revision to Diff 56235. meven added a comment. Typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56183=56235 BRANCH arcpatch-D20533 REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > apol wrote in batterymonitor.qml:106 > Typo? kcm_energyinfo vs kcms_energyinfo Thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven updated this revision to Diff 56236. meven marked 2 inline comments as done. meven added a comment. Capitalization REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56235=56236 BRANCH arcpatch-D20533 REVISION DETAIL

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

meven added a comment. The energy info kcm would need some attention though. kcmshell5 kcm_energyinfo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven added a comment. In D20492#450712 , @broulik wrote: > I think remaining time is way too unreliable for this. We first need a way to calculate a moving average before showing it i this context imho How come this be be good enough

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Just a beginning. I haven't found a way to align Kirigami.FormLayout together in a repeater. There is still room for improvement.

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added inline comments. INLINE COMMENTS > broulik wrote in main.qml:459 > Shouldn't be neccessary as it's `QQC2.Label` For breeze dark this makes the label, dark gray on a dark background. See before screenshot. Could it be a breeze dark bug ? REPOSITORY R102 KInfoCenter REVISION

D16425: Added new Suspend then Hibernate option

This revision was automatically updated to reflect the committed changes. Closed by commit R122:daa06ba31ff1: Added new Suspend then Hibernate option (authored by avaldes, committed by meven). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D16425: Added new Suspend then Hibernate option

meven added a comment. In D16425#488989 , @avaldes wrote: > In D16425#488963 , @davidedmundson wrote: > > > I'd quite like to get this in as I'll end up moving part of this - and we've got too much

D16425: Added new Suspend then Hibernate option

meven accepted this revision. meven added a comment. Except that I couldn't test it, the code looks in great shape to me. REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham, meven Cc: ericadams,

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63669. meven added a comment. Add a logging category REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63654=63669 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY In a laptop when the ac line is un plugged, kinfocenter wrongly display that the ac power

D23112: Add a event Spy for GtkFileChooser recent files

meven created this revision. meven added reviewers: Frameworks, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY GtkFileChooser/GtkRecentManager follows

D23152: [energy kcm] Display Vendor and product

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The code is not great, I would be open to have a suggestion to improve it. I tried to pass

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven added a comment. In D23130#511562 , @broulik wrote: > That property is whether the selected battery powers the computer or is just a peripheral. Perhaps just the label must be changed? That might be a better solution, indeed.

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven updated this revision to Diff 63717. meven added a comment. [kcm energy] Display vendor and battery model REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23130?vs=63670=63717 BRANCH dev1 REVISION DETAIL https://phabricator.kde.org/D23130

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven updated this revision to Diff 63718. meven added a comment. Fix mismatched commit REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23130?vs=63717=63718 BRANCH dev1 REVISION DETAIL https://phabricator.kde.org/D23130 AFFECTED FILES

D23152: [energy kcm] Display Vendor and model

meven updated this revision to Diff 63720. meven added a comment. Add a space REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23152?vs=63719=63720 BRANCH dev2 REVISION DETAIL https://phabricator.kde.org/D23152 AFFECTED FILES

D23198: Skip mime type check only for files on network mounts

meven updated this revision to Diff 63859. meven added a comment. Use toLocalFile() instead of path() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23198?vs=63855=63859 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23198

D23152: [energy kcm] Display Vendor and model

meven added a comment. For reference in GNOME, the equivalent feature looks like : https://i.stack.imgur.com/V7Fpk.png I would be in favor of rename the "Manufacturer" section to "Manufacturing" or "Part" or "Component". REPOSITORY R102 KInfoCenter REVISION DETAIL

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#512999 , @ngraham wrote: > In D23198#512942 , @broulik wrote: > > > `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. > >

D12827: Added process details in the process list context menu

meven added a comment. I quite like this feature @chrisx I hope you can still push it forward after all this time. INLINE COMMENTS > DetailsDlg.cpp:1 > +/* > + KSysGuard, the KDE System Guard Personally I would favor a class name with no abbreviation, here DetailsDialog, and here

D23198: Skip mime type check only for files on network mounts

meven added a comment. For reference in GNOME, the equivalent feature looks like : https://i.stack.imgur.com/V7Fpk.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: ngraham, broulik, plasma-devel, LeGast00n,

D23218: Fix compile warning

This revision was automatically updated to reflect the committed changes. Closed by commit R161:45309604c7c6: Fix compile warning (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23218?vs=63918=63964 REVISION DETAIL

D23237: Do not display vendor, Product and capacity in network plasmoid

meven created this revision. meven added reviewers: ngraham, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Those information mostly clutter the plasmoid UI and not very informative. The

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven added a comment. Given: 1. this is buggy right now 2. not very informative even with a proper label I am in favor of landing this as is. REPOSITORY R102 KInfoCenter BRANCH dev1 REVISION DETAIL https://phabricator.kde.org/D23130 To: meven, broulik, ngraham Cc:

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63913. meven added a comment. Reduce the amount of included code and linked libraries REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63890=63913 BRANCH arcpatch-D23112 REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

This revision was automatically updated to reflect the committed changes. Closed by commit R161:acbc21c15622: Add a event Spy for GtkFileChooser recent files (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D23218: Fix compile warning

meven created this revision. meven added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Add a Q_UNUSED to avoid a compile warning TEST PLAN Build REPOSITORY R161 KActivity Manager Service

D23237: Do not display vendor, Product and capacity in network plasmoid

meven added a comment. In D23237#514154 , @apol wrote: > LGTM but the title looks wrong, this isn't the network plasmoid. Fixed I didn't except that to be that consensual ;) REPOSITORY R120 Plasma Workspace BRANCH master

D23237: Do not display vendor, Product and capacity in network plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8e8441146aa8: Do not display vendor, Product and capacity in network plasmoid (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23237: Do not display vendor, Product and capacity in network plasmoid

meven added a comment. In D23237#514287 , @meven wrote: > In D23237#514154 , @apol wrote: > > > LGTM but the title looks wrong, this isn't the network plasmoid. > > > Fixed Sorry it is

D23175: Clean up old bug workaround

This revision was automatically updated to reflect the committed changes. Closed by commit R119:352f6e835359: Clean up old bug workaround (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23175?vs=63795=63797 REVISION DETAIL

D23175: Clean up old bug workaround

meven created this revision. meven added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The workaround is not necessary anymore. See https://bugreports.qt.io/browse/QTBUG-40765

D23175: Clean up old bug workaround

meven updated this revision to Diff 63795. meven added a comment. Clean up patch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23175?vs=63794=63795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23175 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63786. meven marked 9 inline comments as done. meven added a comment. Remove unnecessary pointer use, code formatting REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63724=63786 BRANCH master

D22012: Clean up old bug workaround in KCMFileIndexer

This revision was automatically updated to reflect the committed changes. Closed by commit R102:31b9b402f077: Clean up old bug workaround in KCMFileIndexer (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22012?vs=60397=63791 REVISION

D22012: Clean up old bug workaround in KCMFileIndexer

meven added a comment. In D22012#512025 , @davidedmundson wrote: > It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 with some pretty sparse docs, then

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63830. meven added a comment. run uncrustify-kf5 REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63786=63830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#511354 , @ivan wrote: > Thanks for geting involved this much! :D REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc:

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63713. meven added a comment. Add const where need be, simplify KTrader query REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63669=63713 BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:143 > Let's hope commands will never have spaces in them :) It is to just extract the executable name, we don't want to have an exploding number of initiatingAgent for every

D23150: [energy kcm] Fix width$ of lines in the graph background

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Before: After: REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63724. meven added a comment. grammar REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63713=63724 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

meven marked an inline comment as done. meven added a comment. In D23112#511779 , @ngraham wrote: > Cool stuff. Does it handle duplicates when a file is present in both GTKFileChooserRecent and KActivitiesStats? Yes, the file url is a

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kactivitymanagerd-plugin-gtk-eventspy.json:41 > Not sure you need to add translations of your own name here This was done for Ivan so I guess the translation team fills this. REPOSITORY

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#510798 , @broulik wrote: > Can you check out the `KBookmarks` framework which has classes for processing xbel files Thanks for pointing it out. I just did, and It does not seem to cover my use case here

  1   2   3   4   5   6   7   8   >