painter before applying clip
- Manuel
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/#review6538
---
On 2010-07-13 18:44:45, Manuel
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/
---
(Updated 2010-07-13 19:09:06.255053)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/
---
Review request for Plasma.
Summary
---
Correct drawing code in systemtray.
---
On 2010-07-13 19:09:06, Manuel Mommertz wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/#review6561
---
On 2010-07-13 19:09:06, Manuel Mommertz wrote
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/
---
(Updated 2010-07-15 10:41:09.211652)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4645/
---
Review request for Plasma.
Summary
---
This patch mainly moves lines
but the theme does not provide a
horizontal seperator it goes to painting a vertical one with code for
horizontal formfactor... definitly not what we want
- Manuel
On 2010-07-15 14:39:18, Manuel Mommertz wrote:
---
This is an automatically
On Monday 27 September 2010 23:09:16 Aaron J. Seigo wrote:
ave you done any timings to test how long the DOM parsing takes on svgs we
have in the theme?
Not yet. But I have still some ideas to reduce the overhead. As soon as I feel
fine with the code, I will do some timings.
(i'd also
On Monday 27 September 2010 23:09:16 Aaron J. Seigo wrote:
have you done any timings to test how long the DOM parsing takes on svgs we
have in the theme?
Average loading time with current trunk: 11ms
Average loading time with my patch applied: 27ms
But i added a simple
On Tuesday 28 September 2010 08:49:28 Julian Bäume wrote:
I’ve seen something similar in libkdegames (look for KGameSvgDocument,
somewhat different approach, but one could do similar things) and I really
want to have something like that myself.
It allows much more manipulation. A very nice
On Wednesday 29 September 2010 22:43:32 Aaron J. Seigo wrote:
On Wednesday, September 29, 2010, Manuel Mommertz wrote:
On Monday 27 September 2010 23:09:16 Aaron J. Seigo wrote:
have you done any timings to test how long the DOM parsing takes on
svgs we have in the theme?
Average
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/
---
Review request for Plasma.
Summary
---
With this patch applied SVGs
For what reason?
- Manuel
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/#review7905
---
On 2010-09-30 11:41:09, Manuel Mommertz
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/
---
(Updated 2010-10-01 08:19:06.216337)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/
---
(Updated 2010-10-01 14:25:03.138571)
Review request for Plasma.
Summary
On Wednesday 20 October 2010 12:33:28 Ingomar Wesp wrote:
so my suggestion would be for you to try and dig into the problem and see
what's going on.
Unfortunately, I'm not a complete exception from the busy with X rule,
but I hope I'll be able to spare some time to do this rather sooner
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5689/#review8338
---
If you want to use the DOM to find the size hints, you can take a
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5689/#review8346
---
Ship it!
Ok, the performance should be acceptable and the patch
On 2010-10-25 20:43:20, Marco Martin wrote:
/trunk/KDE/kdelibs/plasma/svg.cpp, line 259
http://svn.reviewboard.kde.org/r/5689/diff/3/?file=40220#file40220line259
this creates a renderer too often.
since the purpose of the cache is avoid to create renderers this is not
good
Manuel Mommertz wrote:
Right, but this is solvable by inserting the size hints in
SvgPrivate::localRectCache.
Ingomar Wesp wrote:
Right, but this is solvable by inserting the size hints in
SvgPrivate::localRectCache.
To be honest, I'm not sure I understand the cache
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5689/#review8437
---
/trunk/KDE/kdelibs/plasma/svg.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5689/#review8438
---
Ship it!
Somehow my comment on the last was lost... so again:
On 2010-10-29 20:56:15, Manuel Mommertz wrote:
/trunk/KDE/kdelibs/plasma/svg.cpp, line 85
http://svn.reviewboard.kde.org/r/5689/diff/7/?file=40411#file40411line85
should end with:
-(.*)\\1);
this is save as setMinimal is true;
Ingomar Wesp wrote:
Actually, I
On Saturday 27 November 2010 19:33:13 Aaron J. Seigo wrote:
using Plasma::Svg with a SVG file that is not in the theme, the theme's
color scheme is applied?
exactly
if so, that's a bug, and easily fixed (by not applying the colors to SVGs
that are !d-themed).
Way better then my idea. But
I looked a bit deeper in the code and there are some more things that need a
bit of work in my eyes:
Currently Plasma::Theme::styleSheet takes its colors always from defaultTheme
instead of the Theme it is called from. This is very easy to fix.
If a Plasma::Svg is not themed it stores its
On Sunday 28 November 2010 12:08:12 Aaron J. Seigo wrote:
looking at some of the new code in Svg and Theme, it's probably time to do
some more profiling of Svg as well as make sure the caching is working
properly (e.g. no renderers created on a second run of the app)
agreed. should be on the
On Sunday 28 November 2010 22:23:54 Aaron J. Seigo wrote:
i'm pretty well finished implementing it already
you are just awesome!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6008/#review9136
---
It is now even worse then before. Unthemed graphics still use the
On 2010-12-05 14:50:33, Manuel Mommertz wrote:
It is now even worse then before. Unthemed graphics still use the colors
from plasma theme but don't get informed if the theme changes. this means,
the colors that are used when first rendering the graphics stay even if I
switch
On 2010-12-05 14:50:33, Manuel Mommertz wrote:
It is now even worse then before. Unthemed graphics still use the colors
from plasma theme but don't get informed if the theme changes. this means,
the colors that are used when first rendering the graphics stay even if I
switch
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6100/
---
Review request for Plasma.
Summary
---
Currently when switching
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6100/
---
(Updated 2010-12-13 19:55:48.393540)
Review request for Plasma.
Summary
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6150/
---
Review request for Plasma.
Summary
---
The function 'checkColorHints'
On Sunday 20 February 2011 12:03:15 Marco Martin wrote:
On Sunday 20 February 2011, Manuel Mommertz wrote:
Hello,
since 4.6 plasma allows prepered svgs to use system colors. For this to
work the svg needs to have a css-style with the id 'current-color-scheme'
which gets replaced
Hey there,
version 0.3 is available which know allows different system colors for fill
and stroke on the same element.
And you now find the project here:
http://quickgit.kde.org/?p=scratch%2Fmommertz%2Fsvgmod.git
Hurry for one day of vacation ;)
Greets
Manuel Mommertz
Finaly svgmod moved to playground. The project page is available at
https://projects.kde.org/projects/playground/devtools/svgmod
All further news will be pusblished there.
Cheers
Manuel Mommertz
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
37 matches
Mail list logo
