D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler
Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi 
security settings.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-24 Thread Marius Kittler
Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi 
security settings.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma, jgrulich
Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler
Martchus added a comment.


  I don't have commit access so somebody needs to merge this for me.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-24 Thread Marius Kittler
Martchus added a comment.


  I don't have commit access so somebody needs to merge this for me.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma, jgrulich
Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-23 Thread Marius Kittler
Martchus updated this revision to Diff 21153.
Martchus added a comment.


  Add "domainSuffixMatch" to auto tests

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21149=21153

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  autotests/settings/8021xsettingtest.cpp
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-23 Thread Marius Kittler
Martchus updated this revision to Diff 21150.
Martchus added a comment.


  Adapt to updated https://phabricator.kde.org/D8402

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8405?vs=21071=21150

REVISION DETAIL
  https://phabricator.kde.org/D8405

AFFECTED FILES
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/802-1x.ui

To: Martchus, #plasma, jgrulich
Cc: jgrulich, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-23 Thread Marius Kittler
Martchus updated this revision to Diff 21149.
Martchus added a comment.


  Changed the method names

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21069=21149

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-22 Thread Marius Kittler
Martchus added a comment.


  When doing that I'm getting the following error:
  
  > Unhandled Exception ("PhabricatorEdgeCycleException")
  >  Graph cycle detected (type=5, cycle=PHID-DREV-pkm36mw773wvsopfgiic, 
PHID-DREV-4dp34miciioa53ocgthf, PHID-DREV-pkm36mw773wvsopfgiic).
  
  So I'll better keep the full URL.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-21 Thread Marius Kittler
Martchus retitled this revision from "Depends on D8402 Allow to set 
"domain-suffix-match" in Wi-Fi settings" to "Allow to set "domain-suffix-match" 
in Wi-Fi settings".

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8405: Depends on D8402 Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-21 Thread Marius Kittler
Martchus retitled this revision from "Allow to set "domain-suffix-match" in 
Wi-Fi settings" to "Depends on D8402 Allow to set "domain-suffix-match" in 
Wi-Fi settings".

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-21 Thread Marius Kittler
Martchus edited the test plan for this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-21 Thread Marius Kittler
Martchus added a dependent revision: D8402: Support "domain-suffix-match" in 
Security8021xSetting.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-21 Thread Marius Kittler
Martchus added a dependency: D8405: Allow to set "domain-suffix-match" in Wi-Fi 
settings.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-21 Thread Marius Kittler
Martchus edited the test plan for this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

To: Martchus, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-21 Thread Marius Kittler
Martchus created this revision.
Martchus added a reviewer: Plasma.
Martchus added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This concerns Wi-Fi settings of enterprise WPA/WPA2:
  
  - TLS
  - tunneled TLS
  - PEAP
  
  Requires commit `Support "domain-suffix-match" in Security8021xSetting` in 
`networkmanager-qt` (https://phabricator.kde.org/D8402).

TEST PLAN
  1. ApplySupport "domain-suffix-match" in Security8021xSetting` in 
`networkmanager-qt` as well
  2. Open connection settings
  3. Select Wi-Fi connection
  4. Configure domain under enterprise security settings
  5. Apply
  6. Open related config file, eg. 
`/etc/NetworkManager/system-connections/eduroam`
  7. Check whether "domain-suffix-match" is set correctly.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8405

AFFECTED FILES
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/802-1x.ui

To: Martchus, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-21 Thread Marius Kittler
Martchus created this revision.
Martchus added a reviewer: Plasma.
Martchus added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Required for 'Allow setting "domain-suffix-match" in Wi-Fi settings' in 
plasma-nm which concerns Wi-Fi settings of enterprise WPA/WPA2:
  
  - TLS
  - tunneled TLS
  - PEAP

TEST PLAN
  1. Apply 'Allow setting "domain-suffix-match" in Wi-Fi settings' in plasma-nm 
as well
  2. Open connection settings
  3. Select Wi-Fi connection
  4. Configure domain under enterprise security settings
  5. Apply
  6. Open related config file, eg. 
`/etc/NetworkManager/system-connections/eduroam`
  7. Check whether "domain-suffix-match" is set correctly.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart