D10151: Correction with the & problem in tabs

ngraham resigned from this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. If this is only a change for the "disconnected wifi" icon, then maybe we should mimic the "disconnected wired network" icon and make the color red, rather than fiddling with the lightness, which will never satisfy everyone (if this merged, I predict bug reports that

D10151: Correction with the & problem in tabs

ngraham edited the summary of this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. Thanks @andreask. Could we also see what it looks like next to the icon with all bars filled, or with only a few filled? This looks better for disconnected ones, but without seeing those use cases, it do worry that the presentation becomes too muddy for weak

D10131: Expose more URLs relevant to the app

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9993: Improve quality of images in notifications (Bug 385097)

ngraham added a comment. Thanks Randy! Is this in addition to, or instead of your last patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces,

D9993: Improve quality of images in notifications (Bug 385097)

ngraham added a comment. At this point, I think this easiest thing to do is to make a new patch. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel,

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Thanks René. Regarding those questions, what would your preferences be? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts,

D10131: Expose more URLs relevant to the app

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26062. ngraham added a comment. "Make a Donation" -> "Donate" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26033=26062 BRANCH more-URLs REVISION DETAIL

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26033. ngraham added a comment. Fix unintentional whitespace change REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26032=26033 BRANCH more-URLs REVISION DETAIL

D10131: Expose more URLs relevant to the app

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26032. ngraham added a comment. Be smarter about how we find and display the links REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26024=26032 BRANCH more-URLs REVISION DETAIL

D10131: Expose more URLs relevant to the app

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham added inline comments. INLINE COMMENTS > apol wrote in ApplicationPage.qml:347 > Donation:? Donate:? > > "Make a donation" reads a bit too long to me for such a title. "Donate: sounds good. "Make a Donation:" would probably be 4 lines long in German, anyway. :) REPOSITORY R134

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Thanks for the info! So if/hen this goes in, what are the next steps? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts,

D9993: Improve quality of images in notifications (Bug 385097)

ngraham added a comment. No worries! This revision is already closed and associated with a commit, so you should open a new revision to hold the new diff. If you're not using Arcanist to generate patches yet, here's the documentation:

D9995: Allow longer app names in titlebar without eliding

ngraham added a comment. Yup, I've been running with this for a week; no issues seen. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9995 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

ngraham edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10039 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic! Works much better now. In testing, it looks like this does fix all the concerns in 371023. REPOSITORY R114 Plasma Addons REVISION DETAIL

D10102: base scrolling on the smallest item

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I understand now. This patch does indeed make it //better// in the case where you have icons with really long/tall filenames, but it doesn't do anything to help the general case of

D10102: base scrolling on the smallest item

ngraham edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10146: Further improve quality of images in notifications (Bug 385097)

ngraham added a comment. I would have approved too, had you not beat me too it! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10146 To: rkron, #plasma_workspaces, #plasma, broulik, ngraham Cc: davidedmundson, #plasma, #plasma_workspaces, plasma-devel,

D9995: Allow longer app names in titlebar without eliding

This revision was automatically updated to reflect the committed changes. Closed by commit R134:53dfa26a11fb: Allow longer app names in titlebar without eliding (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10151: Solved bug 382512

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for the patch! In general, it's best to title your Phabricator revision with a short description of the change or fix itself, and mention the bug in the Summary section.

D10217: Choose source with a combobox, but only on the desktop view

ngraham added a comment. We were not able to achieve consensus, I'm afraid. If you'd like to be involved in Discover's design, please let me know and I'll invite you to the Discover-Design Telegram room, where we discuss these things. REPOSITORY R134 Discover Software Store REVISION

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. FWIW, I don't think I'd ever want this enabled by default, and I'm leery of adding the option to Breeze. I'm not sure how much it really fits the visual style. Only very very subtle blur transparency would ever work here without becoming garish and distracting--and

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. Eh, maybe I'm wrong. Still... [shakes old man stick] I don't like it! These whippersnappers and their transparency! Back in my day things were opaque and we liked it that way! I won't die on this hill though, since it's being proposed as an optional feature and

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. In https://phabricator.kde.org/D10170#198655, @zzag wrote: > @ngraham: blur is OK but it should be used wisely. Blurring the hell out from UI is not really cool. > > IMO, changes like this, require some changes in the "design language". > PS. does Plasma

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. F5687564: What it looks like.png Nice! There are a few polish changes I'd like to see: - Add a header label saying "Top reviews",

D10217: Choose source with a combobox, but only on the desktop view

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Here I am again, hawking my

D10217: Choose source with a combobox, but only on the desktop view

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10217 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D10170: Added optional transparency/blur to menu frames

ngraham added a comment. OK, I have to admit that those examples look really, really good. 30% more than 40%. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel,

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

ngraham added a comment. We need screenshots! This is impossible to review without applying the diff without before-and-after screenshots. Also, the title becomes the commit message, and should therefore follow standard commit message guidelines: describe the fix, use the imperative

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. Seems useful! Couple of nitpicks: - `KsysGuard` itself appears in the menu :) - The button should look like a dropdown menu button and have a downward-pointing arrow on the right side REPOSITORY R111 KSysguard Library REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. You can't just add the appropriate arrow icon to a regular button; you have to actually use the correct type of button from the start, and then it gets the icon in the right place automatically. Check out how the "All Processes" button is constructed, and you can

D7087: Add "Copy Info" button to the About System KCM

ngraham added a comment. The UI is much better now! Looks great and works fine. If you can't easily figure out how to make ctrl+c work, that's fine for now, and we can investigate that in a later patch. INLINE COMMENTS > Module.cpp:29 > #include > -#if KCOREADDONS_VERSION >=

D10305: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

ngraham added a comment. Thanks for doing this! A few notes: - Put "CCBUG: 358930" on its own line in the Summary; this will cause the commit to show up in that biug, without closing it. - No need to mention the bug number in the title (which becomes the commit message). - The title

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

ngraham added a comment. Thanks for doing this! A few notes: - Put "BUG: 358930" on its own line in the Summary; this will cause that bug to get closed once this goes in. - Put "Depends on https://phabricator.kde.org/D10305; on its own line in the Summary to mark that this patch

D10223: Improve preview thumbnail quality

ngraham added a comment. Nice! The visual artifacts here look similar or the same as ones we sometimes see in Discover and KInfoCenter at HiDPi scale factors: F5693185: Screenshot_20180122_143515.png F5693186: Pixellated logo.png

D10223: Improve preview thumbnail quality

ngraham added a comment. @markg it's now about sharpness or blurring, but rather the "before" screenshot is pixellated and has weird artifacts around the edges. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma,

D10223: Improve preview thumbnail quality

ngraham accepted this revision. ngraham added a comment. Either way, to my mind slightly blurry is better than slightly blurry, pixellated, and bugged around the edges, so +1. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To:

D10148: KCM: Show only available device profiles

ngraham added a comment. Does this fully fix 365723? And if not, what more is needed there? REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella Cc: ngraham, nicolasfella, broulik,

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

ngraham added a comment. Actually it's the opposite: the other patch depends on this one. This is the framework, and that other one uses the changes in this one. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, plasma-devel,

D10325: RFC: [KFileWidget] Hide places frame and header

ngraham added a comment. Shouldn't this be controlled by System Settings > Application Style > Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels? Otherwise, people who check that setting will have a visible frame around the Places panel in Dolphin, but not in

D10325: RFC: [KFileWidget] Hide places frame and header

ngraham added a comment. OK, great. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10181: Removed the "fastblur" path

ngraham added a reviewer: VDG. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma, #vdg Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff,

D10181: Removed the "fastblur" path

ngraham accepted this revision as: VDG. ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. No VDG objections! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma, #vdg Cc: fredrik,

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH block-geometry-update-on-finish-resize-5.12 REVISION DETAIL https://phabricator.kde.org/D10156 To: graesslin, #kwin, #plasma, jgrulich Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff,

D10217: Choose source with a combobox, but only on the desktop view

ngraham abandoned this revision. ngraham added a comment. Discussed it internally, not popular. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10217 To: ngraham, apol, #discover_software_store, #vdg Cc: rkflx, plasma-devel, ZrenBot, progwolff,

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

ngraham added a comment. Since there aren't any string changes, technically it could still go into the 5.12 branch. Or it could go into master at anytime. I approve in concept, FWIW. But we should probably get formal approval from @broulik or @davidedmundson first. REPOSITORY R119

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

ngraham added a comment. If the other patch applies properly, and is correctly marked as a dependency of this one, I //think// you can re-base this on master and it will work. But I'm pretty rubbish at dependent patches myself and will let someone else take over, REVISION DETAIL

D8695: Fix ampersand characters not showing in tab titles

ngraham added a comment. Hello! I'm very sorry that this patch was somehow missed and not committed in back November, and that another patch with the same diff took its place yesterday. This was an oversight on our part and we will try to make sure that it doesn't happen again! REPOSITORY

D10325: RFC: [KFileWidget] Hide places frame and header

ngraham accepted this revision as: ngraham. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a subscriber: andreaska. ngraham added a comment. In https://phabricator.kde.org/D10297#203143, @rkflx wrote: > In https://phabricator.kde.org/D10297#203140, @gregormi wrote: > > > Do we really need that icon? > > > My two cents: A button without icon looks

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. macOS uses a little gear icon for these kinds of menus: F5698887: lrlLcWn.png I've always rather liked it. Seems to connote "Action, tools, stuff here!" Would be even better with text, like we have. REPOSITORY R111

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. Looks awesome, +1 from me feature-wise. Just a few a naive code comments for now. INLINE COMMENTS > ksysguardprocesslist.cpp:360 > > - > //Sort by username by default Let's do unrelated whitespace/style cleanup in another patch. >

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. One more thought. For for consistency, maybe the tools menu should have a horrible hamburger menu icon like the otherwise identiacal one we added to Spectacle recently? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To:

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. How about a new screenshot in the Summary section? ;) REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. Feature-wise, I love it. My only objection is that I'd really like to somehow remove the redundant KSysGuard entry from the menu if it was opened as a standalone app, not via the [alt] + [⎋] shortcut. REPOSITORY R111 KSysguard Library REVISION DETAIL

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. Is this committable? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10151: Correction with the & problem in tabs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:5ce56e6bb5ef: Correction with the problem in tabs (authored by carlavilla, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D10151: Correction with the & problem in tabs

ngraham added a comment. Done. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:0ed4aae225c0: Correction with the problem in tabs (authored by carlavilla, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D10151: Correction with the & problem in tabs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better now, thanks! Works fine. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham,

D10151: Correction with the & problem in tabs

ngraham added a comment. I'll cherry pick 'em. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 388633 Take the device pixel ratio into consideration

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the test plan for this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10328: [Task Manager] Use KFilePlacesModel::isHidden

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10328 To: broulik, #plasma, hein, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10438: increase left/right margin of menuitems

ngraham added a comment. We cannot ever remove the shortcuts from the menus, for countless usability reasons. Lack of discoverable keyboard shortcuts is one of the many productivity and ergonomic flaws of GNOME; we cannot regress to that level. in macOS, the shortcuts are more compact

D10463: Consistently use a Toolbar for headers

ngraham created this revision. ngraham added reviewers: Discover Software Store, abetts, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 385973 Use a ToolBar for

D10463: Consistently use a Toolbar for headers

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D10463: [WIP/RFC] Consistently use a Toolbar for headers

ngraham added a comment. As long as it looks good on the desktop too (or we can make it look good on the desktop too), I'm okay with that. Does it look and behave acceptably right now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To:

D10463: [WIP/RFC] Consistently use a Toolbar for headers

ngraham retitled this revision from "Consistently use a Toolbar for headers" to "[WIP/RFC] Consistently use a Toolbar for headers". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL

D10438: increase left/right margin of menuitems

ngraham added a comment. In D10438#205010 , @abetts wrote: > In D10438#205009 , @ngraham wrote: > > > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a comment. [We will iterate over this incrementally since it's on master] REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10438: increase left/right margin of menuitems

ngraham added a comment. Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to put checkboxes to the left of the text (which I would support). REPOSITORY R31

D10438: reserve space for checkable widgets in menu items

ngraham added a comment. +1 on this new approach. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10463: [WIP/RFC] Consistently use a Toolbar for headers

ngraham abandoned this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: mmustac, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10463: [WIP/RFC] Consistently use a Toolbar for headers

ngraham added a comment. Abandoning in favor of D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers , which is a saner and more sustainable way to do the same thing, and will also yield benefits for other Kirigami consumers because

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. It doesn't merge cleanly on master. Can you re-base it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a comment. Getting there! - Change the text "Show reviews" to "Show more reviews" - Maybe change the "Reviews" header to "Top Reviews". Judgment call, not necessarily required - The increased padding between the reviews is good, but now the divider line is misplaced.

D10383: Fix pinning apps when their .desktop file has a space in the file name.

ngraham added a comment. Is this expected to fully fix https://bugs.kde.org/show_bug.cgi?id=385942? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10383 To: hein, #plasma, broulik, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. In D10297#204581 , @rkflx wrote: > @ngraham Sorry, was busy working on Spectacle and Gwenview so did not get around to this yet. Would you mind filing the bug? https://bugs.kde.org/show_bug.cgi?id=390285 >

D10438: increase left/right margin of menuitems

ngraham added a comment. I could //maybe// see this working for the left edge, but having such a lot of padding between the right edge and the arrows seems a little weird to me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham,

D10476: Improve "write the first review" text

This revision was automatically updated to reflect the committed changes. Closed by commit R134:bc533aaf7086: Improve write the first review text (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10476?vs=27037=27059

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10475: Make it possible to show the title despite having ctx actions

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10475 To: apol, #kirigami Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10471 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

ngraham added a comment. FWIW I like it, but since this is mostly subjective, I wouldn't fight to the death to retain if if everyone else suddenly hated it. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc:

D10483: Polish ToolBarApplicationHeader appearance

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Increase the toolbar height by 4 pixels, to make it

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. No, but in Desktop mode, if the window is not widescreen, then the left side of the header currently gets navigation buttons: Back when you can go back, and after the first time you go back, Forward is shown, too. REPOSITORY R169 Kirigami REVISION DETAIL

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. Thanks for the patch! 1. Please follow the formatting guidelines in https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch 2. Please update the Test Plan section with evidence of testing. A pair of before-and-after screenshots is always

D7849: Fix the tray icon scaling on HiDPI screens

ngraham added a comment. Does this actually fully fix https://bugs.kde.org/show_bug.cgi?id=360333? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks,

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10471 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This patch makes the title right-aligned, which is non-standard with anything. Let's keep it left-aligned for now. Also, what happens to the navigation buttons if you're not in

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. For me this patch still has the titles aligned to the right, even after your change: F5710374: right.png But as currently implemented, if we move the title over to the left as I'm asking for, then the above image would

D10483: Polish ToolBarApplicationHeader appearance

ngraham updated this revision to Diff 27096. ngraham added a comment. Revert change to center title REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10483?vs=27071=27096 BRANCH header-polish REVISION DETAIL https://phabricator.kde.org/D10483 AFFECTED

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: abetts, #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

<    2   3   4   5   6   7   8   9   10   11   >