D10483: Polish ToolBarApplicationHeader appearance

This revision was automatically updated to reflect the committed changes. Closed by commit R169:667cc4318a18: Polish ToolBarApplicationHeader appearance (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10483?vs=27096=27097 REVISION

D10483: Polish ToolBarApplicationHeader appearance

ngraham added a comment. I've reverted the title alignment changes for now. There are too many patches in flight to keep up! If this is good, let's land it (and also Aleix's patches once they're all good too) and then I'll iterate on the titles a bit more. Does that sound like a plan?

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. I fear this will generate the exact same types of user complaints that the huge clock text did before we gave it more vertical padding: people will say that the icons are too tall and don't have enough padding. Let's try not changing the appearance and vertical

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. In D10487#205827 , @pgkos wrote: > I could argue that the numbers come from Material Design guidelines - it recommends between 10% to 20% of padding

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. Padding is fine. We're just saying that: - You need to retain the default appearance for a default sized panel - You need to use programmatic padding values rather than magic numbers REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10476: Improve "write the first review" text

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10476 To: ngraham, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10476: Improve "write the first review" text

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current text is ambiguous and un-exciting.

D10500: Make the review pop-up a bit more user-friendly

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10475: Make it possible to show the title despite having ctx actions

ngraham added a reviewer: abetts. ngraham added a comment. Great, now we have the titles on the left, like @mart wants. We're getting there! There are a couple remaining issues: - Needs a re-base as it doesn't apply cleanly onto current master - Now everything in the header is

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham created this revision. ngraham added reviewers: Kirigami, apol. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The OverlaySheet already defines a bottomMargin, so we

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10500: Make the review pop-up a bit more user-friendly

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Polish the design of the review input pop-up,

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham updated this revision to Diff 27150. ngraham added a comment. Use a more programmatically correct approach (top_adding+buttomPadding instead of Units.gridUnit*2); this will work for clients that change the padding values REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. @rkflx Not naive at all! In this patch, we are trying to solve the general case of how a navigation header with context actions should look. Once we implement this control in Discover, we will //definitely// be removing the title from the app page's use of it,

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham marked an inline comment as done. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. Going up from the 0.71 magic number to the 0.85 magic number would make the clock bigger than it currently is, no? Can you supply a screenshot of how this works now at standard size, increased size, and witha high-DPI display? Since magic numbers are bad, and

D10502: Eliminate unnecessary bottom padding on OverlaySheets

ngraham retitled this revision from "Eliminate unnecessary bottom pading on OverlaySheets" to "Eliminate unnecessary bottom padding on OverlaySheets". REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol,

D10502: Eliminate unnecessary bottom padding on OverlaySheets

ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10251: [RFC] Use mipmap filtering in window thumbnails

ngraham added a comment. Crisper would definitely be nicer too, but if that's too hard, this is already a big visual win even in its current state. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: ngraham,

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. I agree with @rkflx. I think we need to step back here and do some more long, hard design work before we rush to implementation. The proposed approach will not work for most narrow headers as there will simply not be enough room for navigation buttons, a title,

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. Don't worry Henrik, you're all good. The underlying issue here is that we haven't actually done the necessary design work for this feature yet. The appropriate Kirigami HIG section is empty: https://community.kde.org/KDE_Visual_Design_Group/KirigamiHIG#Bars If

D10512: try to preload certain applets in a smart way

ngraham added a comment. Let's keep in mind the PR aspect of this: if we end up 30 MB heavier and a few seconds slower on a cold boot for a new install, advanced users who frequent internet forums and write reviews will notice this, but they probably won't notice that some widgets open more

D10500: Make the review pop-up a bit more user-friendly

ngraham added a comment. The empty space on the bottom is a bug in Kirigami that I fixed this morning with D10502: Eliminate unnecessary bottom padding on OverlaySheets . The star rating change is a good idea (because yeah, 1 star as the default is

D10522: Added vertical separator

ngraham added a comment. Reminds me of Windows. I think I could get used to the vertical line, but I don't like how the horizontal lines intersect with it. Makes the menu look like a grid. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10522 To: anemeth, ngraham,

D10500: Make the review pop-up a bit more user-friendly

ngraham planned changes to this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

ngraham updated this revision to Diff 27203. ngraham added a comment. - Merge branch 'master' into review-popup-button-text - Also fix 390426 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10500?vs=27131=27203 BRANCH

D10500: Make the review pop-up a bit more user-friendly

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10429: Disable the title bar separator by default

ngraham added a comment. If we turn it off by default, the set of people who will deliberately go and turn it on will be so small that it might make more sense to just remove it entirely. The only people who seem to notice and/of care seem to be people using Breeze Dark or another

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. To commit this for you, I need an email address. Can you provide one? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff,

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. Thanks. Confirmed the fix, BTW. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a subscriber: rkflx. ngraham added a comment. Maybe make it a PushButton instead of a ToolButton, and it will magically work? Here's how @rkflx implemented an appropriate Tools menu in Spectacle recently: D10371: Move printing to a new tools button

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham updated this revision to Diff 26699. ngraham added a comment. Simplify the code and address review comments REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10357?vs=26685=26699 BRANCH master REVISION DETAIL

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham marked 4 inline comments as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in Module.cpp:145 > Did you check how it behaves with a distro-provided pixmap? I fear it would > become tiny. I don't think we have any kind of `@2x` support for that Yes, it still works

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the test plan for this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the summary of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10357: Show high-resolution and vector logos properly in HighDPI mode

This revision was automatically updated to reflect the committed changes. Closed by commit R102:82e64226c2e6: Show high-resolution and vector logos properly in HighDPI mode (authored by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

ngraham added a comment. This came up again recently as a user pain point: https://www.reddit.com/r/kde/comments/7vnxhc/plasma_512_is_out_and_it_is_faster_stabler_and/dttyqwi/?utm_content=permalink_medium=front_source=reddit_name=kde REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10362: Swap reveal password button logic

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me, consistency is good. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg, ngraham Cc:

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a reviewer: Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham added a comment. No worries, it sent me down the right path, at least! REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10524 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10522: Added vertical separator

ngraham added a comment. Don't worry Hugo, I don't think we're going to turn Breeze into a mutant that you don't recognize. :) This change doesn't seem very popular, and if it's necessary to make a previous change work, that calls into question whether that was the right change. REPOSITORY

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

ngraham edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10524 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10527: Improve "show more reviews" string and logic

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10527 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10527: Improve "show more reviews" string and logic

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use slightly more natural text for the

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

ngraham created this revision. ngraham added reviewers: Kirigami, apol. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY If the header text is going to be left aligned, we'd

D10525: Only let the user write the first review if they've actually installed the app

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Previously, you could write the first

D10525: Only let the user write the first review if they've actually installed the app

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10525 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10523: Fix warnings

ngraham added a comment. Much better! I still get a few warnings though: file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicationHeader.qml:49: TypeError: Cannot read property of null

D7087: Add "Copy Info" button to the About System KCM

ngraham accepted this revision. ngraham added a comment. Fine from my side. We still need to figure out the translation issue--either work to make it translatable, or accept that this output will be English-only. I'll let the other reviewers have their say on that matter. REPOSITORY R102

D10525: Only let the user write the first review if they've actually installed the app

ngraham updated this revision to Diff 27271. ngraham added a comment. Remove the enabled: part of this patch; will manually commit it to 5.12, since it has no string changes REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10527: Improve "show more reviews" string and logic

This revision was automatically updated to reflect the committed changes. Closed by commit R134:47d77057ded5: Improve show more reviews string and logic (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10527?vs=27209=27268

D10548: Improve app list padding under the header

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10548 To: ngraham, #discover_software_store, apol Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

ngraham added reviewers: apol, abetts. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store, apol, abetts Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10525: Only let the user write the first review if they've actually installed the app

This revision was automatically updated to reflect the committed changes. Closed by commit R134:e6c35b6d5c69: Only let the user write the first review if theyve actually installed the app (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10525?vs=27271=27272#toc

D10548: Improve app list padding under the header

This revision was automatically updated to reflect the committed changes. Closed by commit R134:89cf44b3e207: Improve app list padding under the header (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10548?vs=27273=27274

D10548: Improve app list padding under the header

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Make sure the delegates don't touch the

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10524 To: ngraham, #kirigami, apol, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10604: Show the text by the page action tool buttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. A clear improvement IMHO: F5715593: After.png REPOSITORY R169 Kirigami BRANCH showText REVISION DETAIL

D10606: Show all add-ons in a single category to improve discoverability and search performance

ngraham abandoned this revision. ngraham added a comment. Closing in favor of D10611: Put all systemwide add-ons in Plasma Addons category , which makes more sense. REPOSITORY R134 Discover Software Store REVISION DETAIL

D10611: Put all systemwide add-ons in Plasma Addons category

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10611: Put all systemwide add-ons in Plasma Addons category

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:4959871c57d7: Put all systemwide add-ons in Plasma Addons category (authored by ngraham). REPOSITORY R134 Discover

D10606: Show all add-ons in a single category to improve discoverability and search performance

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10606 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10606: Show all add-ons in a single category to improve discoverability and search performance

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 390594 Right now the Add-ons are

D10611: Put all systemwide add-ons in Plasma Addons category

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 390594 TEST PLAN Application Addons

D10611: Put all systemwide add-ons in Plasma Addons category

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10622: Add multimedia sub-categories

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY FEATURE: 388933 TEST PLAN Tested in KDE

D10620: Improve sidebar header visibility

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10622: Add multimedia sub-categories

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10620: Improve sidebar header visibility

ngraham created this revision. ngraham added reviewers: Plasma, Kirigami, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 384638 FIXED-IN: KDE Plasma 5.12.2

D10622: Add multimedia sub-categories

ngraham updated this revision to Diff 27441. ngraham added a comment. Fix category icons (even though they're not currently displayed; maybe they will be, someday) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10622?vs=27440=27441 BRANCH

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham added a reviewer: Discover Software Store. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Beautiful! Lovely gif too. Thanks for that. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham added a comment. Thanks! I'll land this later tonight, if Alex doesn't beat me to it. REPOSITORY R134 Discover Software Store BRANCH diffD10701 REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson,

D10618: Fix ComboBox & mode description for image fill mode

ngraham added a comment. No worries! There's always a bit of a learning curve here. You might check out https://community.kde.org/Infrastructure/Phabricator, which outlines some sane workflows for Phabricator. The new Arabic translations in `applets/mediaframe/package/metadata.desktop`

D10618: Fix ComboBox & mode description for image fill mode

ngraham added a comment. Thanks! Also please address @davidedmundson's requests and revert the changes from Label to Text and the new Arabic translations (translation is done via another process). REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION

D8168: kcm_input: Refactor the code and add support for libinput under X11

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: romangg, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10618: Fix ComboBox & mode description for image fill mode

ngraham added a comment. Thanks! I'll let @davidedmundson push this if he's satisfied with the changes. REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL https://phabricator.kde.org/D10618 To: sharvey, #plasma, mart, davidedmundson Cc: ngraham,

D10620: Improve sidebar header visibility

ngraham added a comment. Oh shoot, I hadn't noticed that. :( REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10618: Fix ComboBox & mode description for image fill mode

ngraham added a comment. We'll need an email address for you first. What's a good one? REPOSITORY R114 Plasma Addons BRANCH mediaframefix (branched from master) REVISION DETAIL https://phabricator.kde.org/D10618 To: sharvey, #plasma, mart, davidedmundson Cc: ngraham, plasma-devel,

D10642: [kcmkwin/rules] Disable detect button on Wayland

ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. Maybe we should just remove it instead of disabling it? Otherwise people will wonder why it's disabled and sitting there, taunting them. Alternatively, an informative tooltip explaining the issue

D10620: Improve sidebar header visibility

ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart,

D10652: [Run Command] Add history drop down button

ngraham added a comment. Indeed; I never discovered it! This is great. INLINE COMMENTS > RunCommand.qml:125 > +right: parent.right > +rightMargin: 6 // from PlasmaStyle TextFieldStyle > +verticalCenter: parent.verticalCenter Do we

D10620: Improve sidebar header visibility

ngraham closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D10652: [Run Command] Add history drop down button

ngraham accepted this revision as: VDG. ngraham added a comment. VDG-wise, big thumbs up. This is a clear usability improvement. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10652 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D10652: [Run Command] Add history drop down button

ngraham added a comment. I imagine refactoring that not to use magic numbers is a bigger effort. Still, we should keep that in mind, I think. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10652 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel,

D10620: Improve sidebar header visibility

ngraham updated this revision to Diff 27550. ngraham added a comment. re-base on Plasma 5.12 branch REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27540=27550 BRANCH more-visible-headers (branched from Plasma/5.12) REVISION DETAIL

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

ngraham added a comment. Memes aside, I have to agree. This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who putting junk all over their desktop. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

ngraham added a comment. In D10588#210246 , @zzag wrote: > > This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who like putting junk all over their desktop. > > What's the

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

ngraham added a comment. Heh, okay. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10691: Fix plasmashell crash when database is broken

ngraham added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks Cc:

D10620: Improve sidebar header visibility

ngraham updated this revision to Diff 27540. ngraham marked 2 inline comments as done. ngraham added a comment. Also improve subcategory headers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27539=27540 BRANCH more-visible-headers

D10620: Improve sidebar header visibility

ngraham updated this revision to Diff 27539. ngraham added a comment. Use supportsMouseEvents: false instead REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27438=27539 BRANCH more-visible-headers (branched from master) REVISION DETAIL

D10620: Improve sidebar header visibility

ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart,

D10512: try to preload certain applets in a smart way

ngraham added a comment. If by default this slows down plasmashell's loading in favor of making widgets load faster, I'm against it. People will notice the drawbacks of the former more than the benefits of the latter. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. The title is still the primary focus for this header UI, which means (for RTL languages at least), it needs to be left or center aligned. This means the actions have to be on the right, to make sure your eyes don't see them before the title. @abetts, what do

D10753: Provide the source selection as a contextual action

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I see what you're going for here, but the "Sources" menu you're trying to add still doesn't actually work, same as the Sort menu. Is there an open Kirigami patch that this

<    3   4   5   6   7   8   9   10   11   12   >