D24223: [WIP] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Niccolò Venerandi
niccolove added a comment. In Cupertino, I think that the apps launcher should be limited in width and should auto-hide. Regarding a side panel, I think it's really easy and nice to make the system tray somehow full height, that would easily mimick macOS and W10

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-11 Thread Niccolò Venerandi
niccolove added a comment. In D24223#537927 , @fabianr wrote: > > It doesn't auto-hide by default in macOS. I decided to make it span the full width of the screen because not doing this is IMO one of the dumbest parts of that macOS dock,

D27669: WIP: [kstyle] Tools area

2020-02-26 Thread Niccolò Venerandi
niccolove added a comment. It should not be the window decoration theme to draw the line, as the user might want to change the decoration whilst preserving the tools area appearance. I'm not sure how Kvantum does it, but it's able to draw 1px lines on apps: F8132802:

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Niccolò Venerandi
niccolove added a comment. +1 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27737: Fixed margin of digital clock

2020-02-29 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737

D27697: WIP: Added top area to notification header

2020-02-29 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76672. niccolove added a comment. Fixed layouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76571=76672 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED FILES

D27737: Fixed margin of digital clock

2020-02-29 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fed83f884acd: Fixed margin of digital clock (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27737?vs=76678=76692 REVISION DETAIL

D27737: Fixed margin of digital clock

2020-02-29 Thread Niccolò Venerandi
niccolove added a comment. Is this correct, or is there anything special I have to do to land it to stable? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma, davidedmundson, ngraham Cc: gvgeo, davidedmundson, ngraham,

D27697: WIP: Added top area to notification header

2020-02-29 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76674. niccolove added a comment. Fix close button right margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76672=76674 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-01 Thread Niccolò Venerandi
niccolove added a comment. E.g.: dedoimedo complained about this in both the .18 and .17 review. BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: IlyaBizyaev, ngraham, plasma-devel, Orage,

D27832: Fix spacing change

2020-03-04 Thread Niccolò Venerandi
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:eb4235eae1e8: Fix spacing change (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D27832: Fix spacing change

2020-03-04 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY A accidentally changed spacing with my previous commit REPOSITORY R120 Plasma Workspace BRANCH fixspacing (branched from

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-03-04 Thread Niccolò Venerandi
niccolove added a comment. +1 to 38 Weirdly enough, the plasma icon only looks that big from >40, while the IOTM does not use big icons in 40 yet. I'd like small icons to be used consistently. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To:

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77001. niccolove added a comment. Remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=76911=77001 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove added a comment. Ah, this one. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27824: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77002. niccolove added a comment. Remove previous highlight REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27824?vs=76912=77002 BRANCH highlight (branched from master) REVISION DETAIL

D27824: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove added a comment. Seems correct to me - rather, the nm button is way too on the right. I could make that one consistent instead. REPOSITORY R97 Bluedevil BRANCH highlight (branched from master) REVISION DETAIL https://phabricator.kde.org/D27824 To: niccolove, #plasma, #vdg,

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77004. niccolove added a comment. Nope REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77003=77004 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove added a comment. In D27823#621958 , @ngraham wrote: > This needs a rebase. Also you probably need to delete the existing mouseover highlight effect. Git is telling me this is up to date. Also, what existing mouseover effect?

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77003. niccolove added a comment. Right margin of button REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77001=77003 BRANCH highlight (branched from master) REVISION DETAIL

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-03-05 Thread Niccolò Venerandi
niccolove added a comment. The plasma logo is also quite big. For reference, here's my 38px panel: F8152196: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: KonqiDragon,

D26945: fix(plasmoid): add smallSpacing to leftMargin

2020-03-04 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R104:b0f3fa30d427: fix(plasmoid): add smallSpacing to leftMargin (authored by niccolove). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26945?vs=76025=76920 REVISION

D26946: Changed leftMargins to smallSpacing to be consistent

2020-03-04 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:149075077b82: Changed leftMargins to smallSpacing to be consistent (authored by niccolove). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26946?vs=76913=76923#toc REPOSITORY R120 Plasma

D26946: Changed leftMargins to smallSpacing to be consistent

2020-03-04 Thread Niccolò Venerandi
niccolove added a comment. Uff, I screwed up landing this patch: https://cgit.kde.org/plasma-workspace.git/commit/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma, ngraham Cc: gvgeo, ngraham, plasma-devel, Orage,

D27807: Changed style of pressed list item to be consistent

2020-03-04 Thread Niccolò Venerandi
niccolove abandoned this revision. niccolove added a comment. Actually, there is a proper way to do this. Gimme a sec. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, ndavis,

D27824: Use consistent highlight

2020-03-04 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This uses the PlasmaComponents.Highlight feature to be consistent with other lists REPOSITORY R97 Bluedevil BRANCH

D26946: Changed leftMargins to smallSpacing to be consistent

2020-03-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76913. niccolove added a comment. Remove spacing changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=76024=76913 BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-04 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. niccolove requested review of this revision. REVISION SUMMARY Use the PlasmaComponents.Highlight feature to be consistent with other lists. REPOSITORY

D26945: fix(plasmoid): Added smallSpacing to leftMargin

2020-03-04 Thread Niccolò Venerandi
niccolove added a comment. Is the commit given by the patch title that I just changed, or do I have to change the commit name somewhere else? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26945 To: niccolove, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27189: Created a top area based on widgets/toparea.svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76529. niccolove added a comment. - Merge branch 'master' into topbar REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76374=76529 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76530. niccolove added a comment. Using new TopArea element from PlasmaComponents REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76529=76530 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a comment. Ok - I think I got it. I will try to create a generic PlasmaCore.TopArea element and use it here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: mart, ngraham, ndavis,

D27189: Created a top area based on widgets/toparea.svg

2020-02-27 Thread Niccolò Venerandi
niccolove added inline comments. INLINE COMMENTS > mart wrote in ExpandedRepresentation.qml:48 > not in all places you will have access to a dialog. the magic correct values > should come from the toparea margins itself done to go well with the > correspoding background svg. > > in the end, i

D27697: WIP: Added top area to notification header

2020-02-27 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This is supposed to add a top area to floating notifications: (just a sec) The result is not correct: (just a sec)

D27697: WIP: Added top area to notification header

2020-02-27 Thread Niccolò Venerandi
niccolove added a comment. Wait, are notifications ignoring dialog/background theme margins!? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27697 To: niccolove Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27697: WIP: Added top area to notification header

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76543. niccolove added a comment. Fix margins REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76533=76543 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED FILES

D27697: WIP: Added top area to notification header

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76571. niccolove added a comment. Fixed margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76543=76571 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED FILES

D27189: Created a top area based on widgets/toparea.svg

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76374. niccolove added a comment. Used toparea margins rather than systray dialog.margins REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=75095=76374 BRANCH topbar (branched from master) REVISION

D27189: Created a top area based on widgets/toparea.svg

2020-02-25 Thread Niccolò Venerandi
niccolove added inline comments. INLINE COMMENTS > mart wrote in ExpandedRepresentation.qml:48 > not in all places you will have access to a dialog. the magic correct values > should come from the toparea margins itself done to go well with the > correspoding background svg. > > in the end, i

D26946: Changed leftMargins to smallSpacing to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove added a comment. F8146611: Screenshot_20200303_103831.png Seems aligned to me, the problem is that the new small checkbox has a margin to the left by default. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76823. niccolove added a comment. Make anchors fill parent REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76530=76823 BRANCH topbar (branched from master) REVISION DETAIL

D27697: WIP: Added top area to notification header

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76825. niccolove added a comment. Components and rounding REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76674=76825 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED

D26773: Added option to blur background on active window

2020-01-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 74439. niccolove added a comment. Set all proper leftMargins to smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26773?vs=73894=74439 BRANCH master REVISION DETAIL

D26945: Added smallSpacing to leftMargin

2020-01-27 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY With the other two patches, this aims to make leftMargin consistent in plasmoids. REPOSITORY R104 KScreen BRANCH master

D26946: Changed leftMargins to smallSpacing to be consistent

2020-01-27 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY With other two patches, this aims to make leftMargin consistent in widgets REPOSITORY R120 Plasma Workspace BRANCH

D27159: Moved the header to the bottom

2020-02-04 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Moved the header to the bottom, according to T10470 REPOSITORY R120 Plasma Workspace

D27143: moved do not disturb to the bottom

2020-02-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75012. niccolove added a comment. Renamed header to footer REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27143?vs=74956=75012 BRANCH bottom_notification_options (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment. In D27189#606788 , @ndavis wrote: > .+1 to this idea. I noticed that the separator on the left is less dark. I'm not necessarily opposed to that, but is it intentional? Also, where is toparea.svg? I don't see it in

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH topbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D27189 AFFECTED FILES

D27194: Remove human avatars

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment. +1 REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D27194 To: ndavis, #vdg Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment. In D27189#606914 , @ngraham wrote: > Yeah, so you'll want to submit a plasma-frameworks patch which includes the new SVG and mark this as depending on it. Okay > The reason why the text is now pushed over

D27143: moved do not disturb to the bottom

2020-02-03 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY As per T10470 , I moved the notification do not disturb buttons to the bottom TEST PLAN

D27144: Moved toggles to the bottom according to T10470

2020-02-03 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R97 Bluedevil BRANCH move_toggle_to_bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D27144 AFFECTED

D26946: Changed leftMargins to smallSpacing to be consistent

2020-01-28 Thread Niccolò Venerandi
niccolove added a comment. I thought about this; so, I should remove margins from everywhere, and we add them to the desktop theme? I can make that patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma Cc: gvgeo, ngraham,

D26773: Added option to blur background on active window

2020-01-27 Thread Niccolò Venerandi
niccolove added a comment. Sorry, forgot I was on a arc feature already! Forget the last commit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26773 To: niccolove, #plasma Cc: mart, Zren, ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage,

D26946: Changed leftMargins to smallSpacing to be consistent

2020-01-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 74443. niccolove added a comment. Revert accidental line changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=74441=74443 BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

2020-02-19 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76024. niccolove added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=74443=76024 BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D26945: Added smallSpacing to leftMargin

2020-02-19 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76025. niccolove added a comment. - Merge branch 'master' of https://anongit.kde.org/kscreen REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26945?vs=74438=76025 BRANCH master REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

2020-02-19 Thread Niccolò Venerandi
niccolove added a comment. In D26946#602022 , @ngraham wrote: > What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have

D27436: Use task rather than tabs

2020-02-16 Thread Niccolò Venerandi
niccolove added a comment. In D27436#612343 , @The-Feren-OS-Dev wrote: > To make it stretch to the borders, simply just remove padding from panel.svgz and from the Plasmoid highlight SVG. But themes should be able to set their padding,

D27436: Use task rather than tabs

2020-02-16 Thread Niccolò Venerandi
niccolove added a comment. ...but that does not seem simple and would be inconsistent with the task view, so we might want to leave that for another patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27436 To: niccolove, #vdg Cc: The-Feren-OS-Dev,

D27436: Use task rather than tabs

2020-02-16 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Switch from tabs for pressed applets to tasks. - Tabs should be avoided because it's quite semantically incorrect and I

D27189: Created a top area based on widgets/toparea.svg

2020-02-16 Thread Niccolò Venerandi
niccolove added a comment. See D27444 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27189: Created a top area based on widgets/toparea.svg

2020-02-16 Thread Niccolò Venerandi
niccolove added a comment. I'm afraid I need help here, I can't figure out the layout. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D26773: Added option to blur background on active window

2020-01-19 Thread Niccolò Venerandi
niccolove added a comment. I've tried to ask some users, and I received generally positive feedback on the idea, as many considered it pretty. There's a plugin that does this (with many positive reviews on the store), but I think it's not a good idea to fork very similar codebases, and this

D26773: Added option to blur background on active window

2020-01-19 Thread Niccolò Venerandi
niccolove added a comment. Mh, but this is specifically to blur just the wallpaper, as you might want to get information from other windows. At that point, it would be weird for it to be a kwin effect, as it's much more related to just the wallpaper, and the user would expect it to be in

D26773: Added option to blur background on active window

2020-01-19 Thread Niccolò Venerandi
niccolove added a comment. Yes, I *DID* take some code from Zren plugin and wrote some other. My intention was absolutely not to steal his code, I want to be clear about that: I had opened an issue on his repo asking him to upstream the code, but then I thought that it was probably simple

D26773: Added option to blur background on active window

2020-01-19 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Create an option, off by default, that blurs the wallpaper when it detecs an open window. Currently it broke the transition

D27979: Added top area to notifications

2020-03-11 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Added the new PlasmoidHeading component to notifications, see: (...) This also adds it to the notifications in the history,

D27697: WIP: Added top area to notification header

2020-03-11 Thread Niccolò Venerandi
niccolove added a comment. Opened another one due to i-messed-up-arc-again: https://phabricator.kde.org/D27979 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27697 To: niccolove, broulik, ngraham Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n,

D27189: Created a top area based on widgets/toparea.svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77410. niccolove added a comment. Trying to get rid of unrelated changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77409=77410 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77411. niccolove added a comment. Second try of getting rid of unrelated changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77410=77411 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77412. niccolove added a comment. Third one's a charm REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77411=77412 BRANCH systray_toparea (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77416. niccolove added a comment. Trailing spaces REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77412=77416 BRANCH systray_toparea (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77409. niccolove added a comment. - Merge branch 'master' into topbar REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76823=77409 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-12 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77512. niccolove added a comment. Removed head REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77510=77512 BRANCH systray_toparea (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-03-12 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77514. niccolove added a comment. - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into systray_toparea remove unrelated change

D27189: Created a top area based on widgets/toparea.svg

2020-03-12 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77510. niccolove added a comment. - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into systray_toparea REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77416=77510 BRANCH

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77203. niccolove added a comment. Fixed double declaration REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77004=77203 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77212. niccolove added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77203=77212 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77219. niccolove added a comment. remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77218=77219 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove added a comment. Should now work? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27824: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R97:24f2bd58bb5a: Use consistent highlight (authored by niccolove). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27824?vs=77002=77205 REVISION DETAIL

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77217. niccolove added a comment. remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77215=77217 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77218. niccolove added a comment. ops REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77217=77218 BRANCH highlight (branched from master) REVISION DETAIL

D27824: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove added a comment. Wait, I think I understood the reason REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D27824 To: niccolove, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77214. niccolove added a comment. rebase x2 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77212=77214 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove added a comment. well fuck. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77215. niccolove added a comment. rebase x3 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77214=77215 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77254. niccolove added a comment. ops REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77253=77254 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77253. niccolove added a comment. fixed name of list REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77219=77253 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi
niccolove added a comment. Sorry, I had different files with different versions. Now it shows correctly for me, with all files up to date. That said, is it normal that: F8167163: image.png - the top elements has a top separator - icon size of

D27436: Use task rather than tabs

2020-03-09 Thread Niccolò Venerandi
niccolove added a comment. Actually, after some use, I don't think this is the best effect to use. I will investigate more. REPOSITORY R119 Plasma Desktop BRANCH avoid_tabs_for_applets (branched from master) REVISION DETAIL https://phabricator.kde.org/D27436 To: niccolove, #vdg,

D27189: Created a top area based on widgets/toparea.svg

2020-03-14 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f4195688e68e: Created a top area based on widgets/toparea.svg (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77514=77628

D27189: Created a top area based on widgets/toparea.svg

2020-03-14 Thread Niccolò Venerandi
niccolove added a comment. Weird. I can't reproduce, neither in my compiled nor stable install: F8176254: Screenshot_20200314_233208.png But then again, apparently it's not master-y master, so maybe something changed? REPOSITORY R120 Plasma

D27189: Created a top area based on widgets/toparea.svg

2020-03-14 Thread Niccolò Venerandi
niccolove added a comment. I think I have the old network manager. I will submit patches. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n,

D27979: [WIP] Add top area to notifications

2020-03-11 Thread Niccolò Venerandi
niccolove added a comment. In D27979#625809 , @broulik wrote: > Please also test with icons and configure button, I use https://tests.peter.sh/notification-generator/ which can generate a multitude of test notifications Yepp, I did test

D28627: Adaptive panel opacity

2020-04-13 Thread Niccolò Venerandi
niccolove added a comment. I feel like it makes sense for the user to want to use a opaque panel rather than a transparent one. Also, that relies on themes actually turning on the effect, while users could already benefit from it even on current themes if the setting was exposed. Also, that

D28873: Add SwipeNavigator component

2020-04-16 Thread Niccolò Venerandi
niccolove added inline comments. INLINE COMMENTS > mart wrote in SwipeNavigator.qml:55 > different tabbars should really depend only on whether it's a mobile device > or not (and be at bottom if mobile): a very small window on desktop is not a > mobile app I think the tabbar should not be at

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 80313. niccolove added a comment. Only merge if header is actually visible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79483=80313 BRANCH arcpatch-D28467 REVISION DETAIL

  1   2   3   >