Re: qqc2-breeze-style

[Noah Davis]

Just chiming in: I agree that qqc2-breeze-style is a stopgap and not
an effective long term solution for our QQC2 theming. I agree that a
new unified theming system would be the ideal solution to arrive at,
but I knew it wasn't being worked on and couldn't be finished in a
timely manner for the release of the KDE PinePhone. I also did not
have the expertise necessary to do it myself. In comparison, making a
new QQC2 style in time for the KDE PinePhone release was a much easier
option and it appears to have been effective.

On Mon, Apr 12, 2021 at 4:20 PM Nate Graham  wrote:
>
> [explicitly CCing Noah]
>
>
> On 3/10/21 8:52 AM, Marco Martin wrote:
> > On Wed, Mar 10, 2021 at 4:09 PM Nate Graham  wrote:
> >>
> >> People go off an do their own thing in an un-coordinated manner when
> >> there is a significant problem that's not being solved, that problem has
> >> existed for a while without being addressed, and there is no clear
> >> direction or centrally coordinated plan for solving it.
> >
> > yes, that's exactly what happened and is a good warning for the future.
> > Also a good signal that we should start thinking and actually doing 
> > something
> > wrt a good theming story, which we clearly don't have.
> > To me, the most promising approach was the quick prototype Arjen did
> > back at akademy
> > https://invent.kde.org/ahiemstra/qtunifiedstyle
> > whether is something realistic to turn is something actually useful or
> > not remains to be seen.
> > We do have a ton of things to do otherwise, so is not easy to find
> > time for this, but is becoming
> > more and more important
> >
>
> Based on other random conversations since this email thread petered out,
> it seems like we're going to end up considering qqc2-breeze-style to be
> a successful yet temporary stopgap solution from PlaMo, and continue
> using the qqc2-desktop-style theme bridge we currently have--fixing bugs
> and improving performance as needed--until we re-do and unify our whole
> theming system.
>
> On that subject, have we done any further brainstorming? I remember
> being fairly impressed with Arjen's prototype as well. I love the idea
> of finally being able to theme everything consistently, and also the
> possibility of using CSS which is simple, easily writable, and easily
> readable in a diff view without losing your mind :)
>
> As I understand it, here's the latest proposal:
>
> 1. We make a universal theme of some sort (using CSS, QML, or something
> else; exact format TBD)
> 2. We make a QStyle that is essentially a Kvantum-style theming engine
> that consumes the universal theme and applies it to Widgets-based
> apps
> 3. We make a QQC2 style that consumes the universal theme and applies it
> to QtQuick software, including (optionally) Plasma, without going
> through QPainter or the QStyle at all
> 4. We keep the existing Plasma QQC2 style that knows how to consume
> existing SVG-based Plasma themes, for compatibility's sake
> 5. We add a user-facing setting for apps to allow people to choose
> whether to have:
> - Their apps use the universal theme
> - Their apps use a different QStyle, such as Lightly or Kvantum
> 6. We add a user-facing setting for Plasma to allow people to choose
> whether to have:
> - Plasma use the same universal style as their apps
> - Plasma use a different universal style from the one being used for
>   their apps
> - Plasma use an SVG-based Plasma 5 theme, which we deprecate in
>   Plasma 6 but continue to support
> 6. In Plasma 7, we sunset support for SVG-based Plasma themes as well as
> generic QStyles (including Kvantum!) and only support the new
> universal theme--whatever it is we come up with
>
>
> Am I representing everything accurately, to the best of everyone else's
> memory?
>
> Nate

Re: Feedback and problems regarding the application launcher

[Noah Davis]

Hi Tom, I'm already working on a patch that will solve some of the
issues you listed. The current version of Kickoff has a fixed size,
which is why text gets elided so much. My patch will make the default
size scale to fit the content better. It's not quite ready since the
context menus for apps don't have any useful content yet, but I would
appreciate some feedback about the rest of it. If you have any
feedback, please post it in a comment on the MR and not as a reply to
this email.

https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/420

On Wed, Jun 23, 2021 at 7:04 AM Tom Zander  wrote:
>
> Short version; right click on the application launcher and select
> "Show alternative" and select one of the other ones.
>
> The Application Launcher is a typical usability disaster that
> (looking at the merge request) comes from too many chefs and not
> enough actual users testing it. Making it default before it was
> found actually nice and useful by a large section of the
> **users**.
>
> See https://ibb.co/FKS4nQP
>
> Some UX flaws that we found with actual usage;
>
> - texts are not shown fully. (Sl... instead of sleep).
> - pressing the shutdown options then gives another full screen
> dialog to select _again_. Why now simply one "Shutdown" item?
>
> - Items that have a dot dot dot instead of the full text do not
> have a mouse-over tooltip or auto-expanding feature to show the
> full text. I don't know what I'm clicking on here...
>
> - the top row of items in my screenshot are a mix between tabs
> (applications / places) and buttons (sleep etc) and one popup.
> But there is no visual indication about their different behaviors.
> This breaks one of the most fundamental UX rules: avoid
> surprises.
>
> - The button (top right) that shows alternative ways to leave
> (like logout) is an arrow-left. If it were on the left side of
> the dialog, that might work, but on the right the concept just
> fails to indicate "leave". Additionally, it should be square to
> indicate leave. Not round.
> The way it is now, it looks like a "collapse to right" icon.
>
> - List on left is sorted alphabetically, with fun things
> like "All" and "Development" in English being prominently at the
> top. Which makes it the worst case for most users.
> No, the excuse that people won't install stuff they will not use
> does not fly.
>
> - The old problem of menus changing on hover has re-appeared.
> Users not so adapt with the mouse will not move the mouse very
> fast and they will move from one of the menus to the item in a
> diagonal line. As the mouse moves, they will end up triggering a
> menu-change involuntarily until they realize the problem (hah!)
> and move horizontal to the icons area before they go vertically
> down to the icon they want.
>
> - List on the left is not very consistent when operated with a
> touch-screen. Sometimes a swipe leads to selections, sometimes it
> leads to moving the list. This is a solved problem, people. Who
> went and started re-innovating flick-lists?
>
> - My full name is listed bottom left. Why? That does NOT belong
> in an application launcher.
> Hovering over it, again gives me a 'dot dot dot' type text that
> only adds confusion. (and why?)
>
> - the "Places" tab has 3 items
>   + "Computer" (which is a place, but it then lists places,
>   but also Remote. contradicting its sorting).
>   + "History" this is not a place. What is that doing here?
>   + "Frequently used". Nice feature, but that should
>   affect sorting, not force people to go to a back-alley place to
>find the things he used often. Completely misses the point
>again.
>
> - Search, as OP indicated, is interesting. For instance I DO have
> kcalc installed and its description is "Scientific Calculator".
> Searching for "ca" does NOT find it.
> Now, if I type a 3rd char, suddenly it does. Weird.
>
>
> [old geezer rant]
>
> Now, in my time we had people actually sit down with users and do
> a dozen main usage tasks and then we'd find out what the problems
> were based on actual users doing stuff. User testing.
>
> That actually gave pretty decent software. Stable software we had
> back then that we now see Windows copying for their version 11.
> It would be nice if we went back to this level of stability.
> Especially before making something this fresh become the default
> it very clearly is not ready to be.
>
> /end rant.
>
>
>
> On dinsdag 22 juni 2021 15:16:02 CEST Michael Algemeen wrote:
> > Dear recipient,
> >
> > I am writing you because I have some feedback and problems
> > regarding the application launcher.
> >
> > I have replaced kcalc with another calculator. I uninstalled it
> > via the package manager, but it stays in the launcher. I can't
> > figure out how to get rid of it, can you help?
> >
> > Also, when I type “ca”, the first program it returns is
> > “cantana” despite never using it. Can I make it suggest
> > “Calculator” instead? Xfce does this.
> >
> > Also, how do I remove entries that are

Re: Soft Feature Freeze

[Noah Davis]

Hello, I would like to get one final Breeze QStyle patch into the
beta: https://invent.kde.org/plasma/breeze/-/merge_requests/136

It's a one-liner that just enables antialiasing on combobox menu
items, so it shouldn't cause any problems.

On Thu, Sep 16, 2021 at 4:11 AM Tom Zander  wrote:
>
> On donderdag 16 september 2021 09:55:59 CEST Bhushan Shah wrote:
> > - To avoid the git history mess, we can revert it in 5.23
> > branch after it is branched, and keep master as-is
>
> Honestly, don't be such a purist about a clean git history.
> Its not worth the effort.
>
>
>

D24706: [RFC] Change button style

[Noah Davis]

ndavis updated this revision to Diff 76490.
ndavis added a comment.


  Update

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24706?vs=73742&id=76490

BRANCH
  ndavis/pushbutton-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24706

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, 
plasma-devel, manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a subscriber: hpereiradacosta.
ndavis added a comment.


  Adding Hugo as a subscriber since he might have some advice.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis added a comment.


  In D24706#619482 , @mart wrote:
  
  > hmm, buttons look quite.. flat now? there was a lot of discussion on what 
should be flat and what not. while i think having things a bit flatter doesn't 
actually hurt, could this be considered an usability issue?
  
  
  I think it's only style issue as long as we have either good enough contrast 
on the background or good enough contrast on the outline. I'm personally not 
100% into the flat look, but it's hard to get the gradient right and I don't 
like the current gradient.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, 
plasma-devel, manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Dolphin is crashing pretty regularly for me and it has this graphical glitch 
every time it crashes:
  F8143719: Screenshot_20200301_092241.PNG 

  Backtrace:
  F8143722: dolphin-20200301-092242.kcrash.txt 

  
  I'm on Qt 5.14.1 with all of my KDE software on git master.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  This line is way too bright on Dark themes{F8143729 
}

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Falkon doesn't blend: F8143736: Screenshot_20200301_093246.PNG 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  It's too hard to tell the difference between active and inactive icons: 
F8143741: Screenshot_20200301_093349.PNG 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: WIP: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Okular has the same problem as Dolphin. Backtrace: F8143746: 
okular-20200301-093637.kcrash.txt 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, 
ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27807: Changed style of pressed list item to be consistent

[Noah Davis]

ndavis added a subscriber: plasma-devel.
ndavis added a comment.


  It's strange that the plasma-devel mailing list isn't automatically added, 
even when it's a reviewer group.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Noah Davis]

ndavis added a comment.


  I don't want to turn this into bikeshedding, but I think a size of 42 is 
better because that raises the size of task manager icons to 32px. 22px is 
pretty small for an IOTM.
  With that said, I think something we'll have to work on is finding ways to 
improve the way panel items are sized so that we don't have to pick sizes based 
on how different widgets change icon sizes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Noah Davis]

ndavis added a comment.


  In D27845#622434 , @KonqiDragon 
wrote:
  
  > Why Show/Hide Desktop icon is so huge?
  
  
  Because icon sizing in panels is a mess.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27874: Disable the audio stream indicator for IOTM

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  After having used it for months, it still gets in the way when used with the 
Icons-only Task Manager.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  disable-audioindicator-iotm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27874

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: ndavis, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27874: Disable the audio stream indicator for IOTM

[Noah Davis]

ndavis updated this revision to Diff 77043.
ndavis added a comment.


  - Hide audio indicator setting for IOTM

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27874?vs=77040&id=77043

BRANCH
  disable-audioindicator-iotm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27874

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: ndavis, #vdg, #plasma
Cc: ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27874: Disable the audio stream indicator for IOTM

[Noah Davis]

ndavis added a comment.


  Do we really want a feature that new users have to learn to dodge?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27874

To: ndavis, #vdg, #plasma
Cc: ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27874: Disable the audio stream indicator for IOTM

[Noah Davis]

ndavis updated this revision to Diff 77045.
ndavis added a comment.


  - Use an option instead

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27874?vs=77043&id=77045

BRANCH
  disable-audioindicator-iotm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27874

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: ndavis, #vdg, #plasma
Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Noah Davis]

ndavis added a comment.


  @davidedmundson Nate says smallSpacing doesn't work here. Do you know why?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Do we need to add a Header color set to KColorScheme?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  In D27669#627465 , @davidre wrote:
  
  > In D27669#627464 , @ndavis wrote:
  >
  > > Do we need to add a Header color set to KColorScheme?
  >
  >
  > How would that help? KIconLoader still wouldn't know which color to use, 
wouldn't it?
  
  
  Maybe I don't understand the internals well enough. My understanding is that 
the titlebar color isn't really part of the colorscheme, it's just read from 
the colorscheme config file. If the titlebar and toolbar were both using the 
Header color set, then they would use the same colors, right?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28064: [applet/notes] Show a "remove" button on the button row

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  makes sense to me

REPOSITORY
  R114 Plasma Addons

BRANCH
  show-remove-button-too (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28064

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27874: Disable the audio stream indicator for IOTM by default

[Noah Davis]

ndavis added a comment.


  In D27874#628714 , @ngraham wrote:
  
  > Title needs updating to reflect the current state of the patch, if you'd 
still like to propose that we do this. I'm still not sure I understand the 
point. The indicator is already disable-able for both the IOTM and TTM. What 
value is being gained here?
  
  
  it's an annoyance enabled by default. I suppose the fact it can be clicked on 
could be made optional, but do we really want to add more options?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27874

To: ndavis, #vdg, #plasma
Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28211: [applets/systemtray] Make Pin button a bit larger

[Noah Davis]

ndavis added a comment.


  In D28211#632893 , @ngraham wrote:
  
  > The size is actually perfect for being a ToolButton: F8194949: 
Screenshot_20200323_085422.png 
  >
  > However yeah, the actual icon size in a ToolButton is `smallMedium`, so I 
guess the fact that you need to use `small` to get the right size is an issue 
with the component.
  
  
  If that's the case, is this actually the right fix to do? Or will this patch 
be updated after the PC3 ToolButton is fixed?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  normal-sized-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28211

To: ngraham, #vdg, #plasma, ognarb
Cc: ndavis, broulik, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  In D27669#634758 , @ngraham wrote:
  
  > So I'm still having an issue with the feature um, not working. :( I have it 
turned on in the Breeze settings but it behaves as if off; that is to say, I 
see no different appearance compared to the status quo.
  >
  > Is anyone else experiencing this, or just me?
  
  
  It doesn't work for me either. I tested with Dolphin and Kate.

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  I use a kdesrc-build environment. My process was this:
  
cd breeze
arc patch D27669
ninja -C "$( pwd | sed 's:/src/:/build/:' )" install  #I use this through a 
script named kdesrc-ninja and it works well
source ~/kde/.setup-env  #This makes the terminal session use the 
kdesrc-build environment
dolphin
  
  
  
  In D27669#634824 , 
@hpereiradacosta wrote:
  
  > F8199260: Screenshot_20200325_210812.png 

  
  
  That white combo box looks a little nasty against the dark gray background. I 
wonder if there's anything that can be done about it.

REPOSITORY
  R31 Breeze

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> breeze.kcfg:36
>  
> -true
> +false
>  

Maybe instead of disabling this, we should make its color red? I like the 
circle and making it red would be more consistent with our icons.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

[Noah Davis]

ndavis added a comment.


  In D28356#636362 , @paulm wrote:
  
  > > It has been part of the default kde look for many years (for all of 
oxygen and breeze) and forms a core part of our design brand. It's something 
where you can spot breeze on the first look. It seems MacOS can get away with 
colored circles without people complaining about usability.
  >
  > I would argue that usability is far more important than branding, and that 
KDE's brand is not that popular, especially since KDE4 there was a migration 
away from KDE, coinciding with the Oxygen theme; there are millions of more 
users that could be migrating to Linux than exist already. The fact that you 
are on a usable open-source GNU system should sell KDE more than anything! The 
main thing being imitated here is also KDE1! The arrows in Oxygen/Breeze remind 
me more of the Windows 3.1 brand and the usability problems I had when I first 
tried to use it.
  >
  > I for one would argue that MacOS also does this very badly, and that MacOS 
usability is not as great as the fanatics would attest.
  
  
  KDE4 was unpopular because it was heavier and buggier, not because the 
titlebar buttons were different. I think the current buttons are clear enough 
as they are and any change would be more of a branding change than a usability 
change. KDE 1 copied a lot from CDE, including the titlebar buttons. Windows 
3.1 is different enough that we're pretty obviously not copying it. We also 
have a maximized symbol, unlike Windows 3.1.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28356

To: paulm, #vdg, #breeze, hpereiradacosta, cblack, davidre
Cc: ndavis, davidre, broulik, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  I've discovered another bug. When you move a window by dragging on an empty 
area, the hover effect on toolbar buttons stops working.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Noah Davis]

ndavis added a comment.


  This is merely an indicator and not a button, right? If so, you should not 
use `edit-reset` since you cannot actually reset the settings there. I'll try 
to come up with another indicator.
  
  I'm concerned that this indicator will make system settings visually messy. 
Is it really needed?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Noah Davis]

ndavis added a comment.


  maybe it would make more sense to add a different way to view non-default 
settings? like maybe a summary of custom settings.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#638344 , @ngraham wrote:
  
  > @ndavis like this?
  >
  > F8206344: Screenshot_20200330_123644.png 

  
  
  yes

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  When I try to get this patch with `arc patch` on top of the branch for D27669 
, git says a cherry pick failed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#639599 , @ngraham wrote:
  
  > You don't need to already be on the other branch, just apply this on top of 
master. If all goes well, `arc` should first apply D27669 
, then this one.
  
  
  If I do it that way, it says "This diff is against commit 
86851917557ea7deeaaac05b3d62e021d93041e9, but the commit is nowhere in the 
working copy."

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  it succeeds. It probably doesn't need whatever commit it's trying to use.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Noah Davis]

ndavis added a comment.


  In D28461#639470 , @ngraham wrote:
  
  > So every single KCM will need to be patched to add a settings proper in 
support of this? Oof. Is there no easier way?
  
  
  Perhaps we could find a way to turn it to our advantage? Do //all// KCMs 
really need to have this kind of indicator?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  Do we really still need Breeze Light to be separate from Breeze? I think it 
would make more sense to have just Breeze Light and Breeze Dark. After that, we 
should refer to all light versions of Breeze as Breeze Light instead of just 
Breeze. Breeze should then only be used to refer to the complete theme or a 
color scheme compatible version of Breeze (i.e., Breeze plasma theme).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#639693 , @ngraham wrote:
  
  > But would we still have Breeze, Breeze Light, and Breeze Dark Plasma 
themes? If we're going to get  rid of the Breeze color scheme and just have 
light and dark, it might be a bit odd to still have a Breeze Plasma theme.
  
  
  
  
  In D28317#639653 , @ndavis wrote:
  
  > [...] Breeze should then only be used to refer to the complete theme or a 
color scheme compatible version of Breeze (i.e., Breeze plasma theme).
  
  
  I guess you could call it Breeze Adaptive or Breeze Chameleon, but I don't 
think it's necessary.
  
  In D28317#639693 , @ngraham wrote:
  
  > Also maybe we should discuss that after this patch, or separately?
  
  
  I don't think eliminating one of the light color schemes needs to be done 
separately. Discussions about what to do about plasma themes and icon themes 
are outside the scope of this patch, but I just wanted you to see where I was 
going with that suggestion.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  In D27669#639519 , @ngraham wrote:
  
  > While working on D28317 , I noticed 
something: when a window becomes inactive, the icons change their colors, but 
only for the parts of the icon using the text color. Red icons, or parts of 
icons that are red, don't change at all which is a little weird-looking:
  
  
  Perhaps we shouldn't change the text color on inactive windows? We can 
already change the background color. It would only require changes to the 
default color schemes.
  
  > Do we need an inactive red color or something?
  
  It should be possible to make an inactive version of NegativeText based on 
the inactive color.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Noah Davis]

ndavis added a comment.


  Why isn't a checkbox better than a combobox here? Aren't there only 2 
opposite choices here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D28280#640239 , @ngraham wrote:
  
  > Currently there are only two choices, yes. However as mentioned before, one 
of the goals of this patch is to future-proof the UI for the addition of more 
options, which is coming soon.
  
  
  Oh right
  
  LGTM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  refine-baloo-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma, ndavis
Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28646: [Notifications] Sort popups ascending

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Nice usability improvement!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28646

To: broulik, #plasma, #vdg, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Noah Davis]

ndavis added a comment.


  So this makes Breeze respect the global animation speed setting in the 
Workspace Behavior - > General Behavior KCM?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: ndavis, plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28651: Load and use global animation settings

[Noah Davis]

ndavis added a comment.


  I don't know enough about KDE configuration management to judge the code, but 
changing animation speeds in SySe works if I restart apps after the change.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Noah Davis]

ndavis added a comment.


  Works for me. @ngraham, perhaps you forgot to restart `kded5`? I forgot that 
at first.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Noah Davis]

ndavis added a comment.


  You need to fix the git author info. If you upload a patch via the web UI 
instead of `arc`, the author info gets messed up.
  
  It's still working for me. I also still need to restart apps for changes to 
the global animation settings to apply.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28841: Raise size of default fixed-width font from 9 to 10pt

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  even-bigger-hack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28841

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Noah Davis]

ndavis added a comment.


  What is the usecase for this?
  
  The progress tab's page highlight changes width with the percent of progress, 
correct? I think it looks wrong like that, unless I'm missing an important bit 
of context.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D28873: Add SwipeNavigator component

[Noah Davis]

ndavis added a comment.


  So are these just all views that run simultaneously like apps on a task bar? 
What makes this different from tabs?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart

D28888: Fix navigation regressions

[Noah Davis]

ndavis added a comment.


  In D2#649712 , @cblack wrote:
  
  > In D2#649710 , @ngraham 
wrote:
  >
  > > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. 
Could they just go back to using real list items instead?
  >
  >
  >
  >
  >   That's what I initially attempted, but non-deterministic behaviour was 
caused by swapping out a list of cards for a list of listitems.
  
  
  Could you be more specific?

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[Noah Davis]

ndavis added a comment.


  Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's 
process filtering and tools comboboxes are right next to each other and have 
different behavior.
  
  This causes another problem with all monochrome icons on the Breeze 
colorscheme though:
  F8245273: Screenshot_20200418_104206.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[Noah Davis]

ndavis added a comment.


  In D28908#651314 , @davidre wrote:
  
  > In D28908#651078 , @ndavis wrote:
  >
  > > Oddly, I can't reproduce the bug this fixes in all comboboxes. 
KSysGuard's process filtering and tools comboboxes are right next to each other 
and have different behavior.
  > >
  > > This patch causes another problem with all monochrome icons on the Breeze 
colorscheme though:
  > >  F8245273: Screenshot_20200418_104206.png 

  >
  >
  > Isn't one of them a toolbuttons with menu, not a combobox? 
  >  I don't think this patches causes that issue. Do you have
  >  https://phabricator.kde.org/R31:66d0b0b4e3e1adc389dbd4ce1976d81860d1880d ?
  
  
  You're right, it looks like this patch doesn't cause the problem. I thought 
it did because the problem doesn't appear until I change color schemes and I 
normally change color schemes when testing Breeze patches.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28908: Use the same icon mode calculation for comboboxes as for buttons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Ok, it took me a while to fully understand what this patch does, but it seems 
to be working fine.

REPOSITORY
  R31 Breeze

BRANCH
  combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Noah Davis]

ndavis added a comment.


  Oof, what a sad set of example notifications 😂

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added a comment.


  I found something vary curious and I don't know what the cause could be. The 
corners are smoother when the cards are taller and rougher when they are 
shorter.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added a comment.


  Actually, width does affect the roughness. The corners are at their smoothest 
when the card is a square.
  
  F8253358: Screenshot_20200422_092539.png 

  
  F8253360: Screenshot_20200422_092453.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Much better and thanks! LGTM

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added a comment.


  This has a ShadowedRectangle underneath and a transparent Rectangle with a 
border on top: F8253587: Screenshot_20200422_115104.png 

  
  Is there nothing that can be done about that?

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> sdf.glsl:199
>  // This
> -const lowp float sdf_default_smoothing = 0.005;
> +const lowp float sdf_default_smoothing = 0.4;
>  

I played around with this value and found that 0.625 was pretty decent. It 
slightly improved the corners in bigscreen and made the corners of 
Kirigami.Card a bit smoother without making the lines blurry. Top: 0.625; 
Bottom: 0.4
F8253710: Screenshot_20200422_125706.png 

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  This time when I try to apply the patch, it fails. I have the most up to date 
version of D27669  too.
  
╭ …/src/kde/workspace/breeze   master  
╰ arc patch D28317
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D28317.
Branch name arcpatch-D27669 already exists; trying a new name.
Created and checked out branch arcpatch-D27669_1.
Checking patch kstyle/config/ui/breezestyleconfig.ui...
Checking patch kstyle/config/breezestyleconfig.cpp...
Checking patch kstyle/breezetoolsareamanager.h...
Checking patch kstyle/breezetoolsareamanager.cpp...
Checking patch kstyle/breezestyle.h...
Checking patch kstyle/breezestyle.cpp...
Checking patch kstyle/breezehelper.h...
Checking patch kstyle/breezehelper.cpp...
Checking patch kstyle/breeze.kcfg...
Checking patch kstyle/CMakeLists.txt...
Applied patch kstyle/config/ui/breezestyleconfig.ui cleanly.
Applied patch kstyle/config/breezestyleconfig.cpp cleanly.
Applied patch kstyle/breezetoolsareamanager.h cleanly.
Applied patch kstyle/breezetoolsareamanager.cpp cleanly.
Applied patch kstyle/breezestyle.h cleanly.
Applied patch kstyle/breezestyle.cpp cleanly.
Applied patch kstyle/breezehelper.h cleanly.
Applied patch kstyle/breezehelper.cpp cleanly.
Applied patch kstyle/breeze.kcfg cleanly.
Applied patch kstyle/CMakeLists.txt cleanly.
 COMMITTED  Successfully committed patch.


This diff is against commit 33be688c002cb4829fee475f0199cbffbb8dc265, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (944d47cd098ff8abf85f08823cbe7d033eee082d)
[Y/n] y

Checking patch kstyle/breezetoolsareamanager.cpp...
error: while searching for:
this, [this]() {
emit toolbarUpdated();
});
<<< HEAD
toolbar->installEventFilter(this);
===
>>> c2487fc1... [kstyle] Tools area
}
connect(widget, &QObject::destroyed,
this, [this, widget]() {

error: patch failed: kstyle/breezetoolsareamanager.cpp:187
error: while searching for:

void ToolsAreaManager::unregisterWidget(QWidget *widget)
{
<<< HEAD
if (qobject_cast(widget)) {
widget->setContentsMargins(0,0,0,0);
widget->removeEventFilter(this);
}
===
if (qobject_cast(widget)) 
widget->setContentsMargins(0,0,0,0);
>>> c2487fc1... [kstyle] Tools area
_registeredWidgets.remove(widget);
QList toRemove;
for (auto window : animationMap.keys()) {

error: patch failed: kstyle/breezetoolsareamanager.cpp:213
Checking patch kdecoration/breezesettingsdata.kcfg...
Checking patch kdecoration/breezebutton.cpp...
Checking patch colors/BreezeLight.colors...
Checking patch colors/Breeze.colors...
Applying patch kstyle/breezetoolsareamanager.cpp with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
Applied patch kdecoration/breezesettingsdata.kcfg cleanly.
Applied patch kdecoration/breezebutton.cpp cleanly.
Applied patch colors/BreezeLight.colors cleanly.
Applied patch colors/Breeze.colors cleanly.

 Patch Failed!
Usage Exception: Unable to apply patch!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  the cmake file in `colors/` also needs to be updated for the patch to build.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  It's the change to `kstyle/breezetoolsareamanager.cpp` that causes this patch 
to fail to apply. That file doesn't exist anywhere.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  Never mind, I was wrong, I see it in arcpatch-D27669. However, just to see 
what would happen, I made my arcpatch-D27669 branch the upstream of 
arcpatch-D28317 and it said that arcpatch-D28317 was behind a commit. Are you 
sure you've rebased against the tools area patch correctly?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  The event filter in `breezetoolsareamanager.cpp` already exists in the tools 
area patch and the other changes are incompatible with the current version of 
the tools area patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#655922 , @ngraham wrote:
  
  > I mean, how to fix it with `arc`. :)
  
  
  I don't know what the branch looks like on your end. Maybe just zip up the 
whole repo and send it to me?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  No wait, that would be half a gigabyte of stuff. Maybe not the best idea to 
zip it up.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29139: Remove .clang-format

[Noah Davis]

ndavis created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  It was an ignored file that was committed to the repo at some point.
  Because it's automatically generated and replaces the version commited to the 
repo when the project is built, it keeps causing kdesrc-build to report build 
failures for this project.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  clangformat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29139

AFFECTED FILES
  .clang-format

To: ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29139: Remove .clang-format

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:50bde7c5ba33: Remove .clang-format (authored by ndavis).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29139?vs=81042&id=81058

REVISION DETAIL
  https://phabricator.kde.org/D29139

AFFECTED FILES
  .clang-format

To: ndavis, ivan, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  I'm seeing a lot of this message in GDB when I switch from a different QStyle 
such as Fusion back to Breeze:
  
QBackingStore::endPaint() called with active painter; did you forget to 
destroy it or call QPainter::end() on it?
  
  I also see this sometimes:
  
QWidget::repaint: Recursive repaint detected

INLINE COMMENTS

> breezetoolsareamanager.cpp:127
> +auto geoUpdate = [=]() {
> +_helper->_invalidateCachedRects = true;
> +emit toolbarUpdated();

When I run GDB on `oxygen-demo5`, sometimes it tells me that `oxygen-demo5` 
crashes on this line. I'm not sure how to make it happen reliably, but it 
usually involves changing QStyles with the Style combobox or color schemes with 
the Color Scheme combobox.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D29144: [applets/weather] Improve UX for selecting a weather station

[Noah Davis]

ndavis added a comment.


  Can you also make locations show up as you type so that you don't need a 
search button?

REPOSITORY
  R114 Plasma Addons

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik, spstarr
Cc: ndavis, spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29012: Fix variable mixup

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Works for me

REPOSITORY
  R31 Breeze

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29012

To: davidre, #breeze, #plasma, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ndavis wrote in breezetoolsareamanager.cpp:127
> When I run GDB on `oxygen-demo5`, sometimes it tells me that `oxygen-demo5` 
> crashes on this line. I'm not sure how to make it happen reliably, but it 
> usually involves changing QStyles with the Style combobox or color schemes 
> with the Color Scheme combobox.

Now I can consistently get oxygen-demo5 to crash on this line by switching to 
Fusion and then Oxygen.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> breezetoolsareamanager.cpp:127
> +auto geoUpdate = [=]() {
> +_helper->_invalidateCachedRects = true;
> +emit toolbarUpdated();

I misclicked. It's this line with `_helper->_invalidateCachedRects = true;`

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28888: Fix navigation regressions

[Noah Davis]

ndavis added a comment.


  This needs to be rebased

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  The only remaining problem I can find is this one with certain kinds of menu 
buttons:
  F8260819: vokoscreenNG-2020-04-26_00-43-00.mp4 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  Try this colorscheme for a while and see what you think of it: F8270896: 
BreezeDark10.colors 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  Oops, that's a leftover bit from when I was testing my changes to the Breeze 
QStyle. This color scheme is something I've been slowly working on for a while.
  
  New version with fixed selection color and darker titlebar: F8271489: 
Breeze10.colors 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#659952 , @ngraham wrote:
  
  > Thanks, that's fixed now. Is the tooltip background supposed to be this 
grayish color though?
  >
  > F8271573: Screenshot_20200429_124914.png 

  >
  > If we're go with a light tooltip, I think I'd prefer it to look like the 
current Plasma tooltip, which IMO is nicer with a lighter background.
  
  
  I wanted it to stick out from the window and view backgrounds a bit more. 
Here I've changed it to use the color of buttons: F8271722: Breeze10.colors 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  Forgot to change a few more of the selection colors. I might as well post the 
updated Breeze Dark version too.
  
  F8271896: Breeze10.colors 
  
  F8271897: BreezeDark10.colors 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#639653 , @ndavis wrote:
  
  > Do we really still need Breeze Light to be separate from Breeze? I think it 
would make more sense to have just Breeze Light and Breeze Dark colorschemes 
(delete Breeze Light, rename Breeze to Breeze Light). Maybe Breeze Classic too 
if people want the old Breeze colorscheme, but that could be on store.kde.org 
instead. After that, we should refer to all light versions of Breeze as Breeze 
Light instead of just Breeze. Breeze should then only be used to refer to the 
complete theme or a color scheme compatible version of Breeze (i.e., Breeze 
plasma theme).
  
  
  Back to this: Now that Breeze Light is gone, what if we rename Breeze to 
Breeze Light? How will that affect people upgrading from the old version of 
Breeze or Breeze Light?
  
  Also, since I'm working on the color schemes, do you think it would make more 
sense for the color scheme to be a separate patch from the titlebar button 
changes?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28888: Fix navigation regressions

[Noah Davis]

ndavis added a comment.


  Thanks, this fixes the navigation issue after a page has been selected. The 
main grid view is still annoying though.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  cblack/better-navigation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami, ndavis
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  I also renamed Breeze to Breeze Light because it's very awkward to talk about 
the Breeze project when it's not clear whether or not you're talking about just 
the light version.

TEST PLAN
  TODO

REPOSITORY
  R31 Breeze

BRANCH
  new-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29439

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeDark.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis updated this revision to Diff 81963.
ndavis added a comment.


  squash commits

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29439?vs=81962&id=81963

BRANCH
  new-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29439

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeDark.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis updated this revision to Diff 81966.
ndavis added a comment.


  Fix some colors

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29439?vs=81963&id=81966

BRANCH
  new-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29439

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeDark.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt

To: ndavis, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Noah Davis]

ndavis added a comment.


  In D29365#663395 , @ngraham wrote:
  
  > Of course the problem with a spinbox is that by displaying numbers, it 
demands some kind of legend or label. What does a value of 100 mean? Does a 
value of 0 make any sense? etc. The value displayed to the user must make some 
sense or explained with context. In this case, perhaps a percentage would work, 
with the default value being "100%", and the max and min values displaying 50% 
and 200%, or something, or whatever the scale actually is.
  
  
  Didn't we solve this already with Slider + Spinbox in the Display 
Configuration KCM?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis added a comment.


  In D29439#663746 , @GB_2 wrote:
  
  > Do we still want to ship the old Breeze Classic with Plasma or do we put it 
in `kde-vdg-extras`? I think there are quite a few people who like the mix of 
dark header and light content.
  
  
  I have no strong opinions on that matter. It would need to be adjusted for 
the Breeze evolution. Breeze High Contrast also needs to be adjusted and made 
to actually have high contrast.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29439

To: ndavis, #vdg
Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Noah Davis]

ndavis added a comment.


  I had a look at the documentation for libinput pointer acceleration 
(https://wayland.freedesktop.org/libinput/doc/latest/pointer-acceleration.html).
 For anyone following this conversation:
  
  - `0` is the default
  - when greater than `0`, acceleration starts sooner and pointer movement 
increases by larger factors
  - when less than `0`, acceleration starts later and pointer movement 
increases by smaller factors until pointer movement does not increase with 
mouse movement speed. The point where that happens is somewhere in the range of 
greater than `-0.75` and less than `-0.5`.
  
  In D29365#663774 , @kurmikon wrote:
  
  > With percentage there's no need to set a slider in my opinion. It's 
intuitive that 0 and 100 and the limits. That implementation would be good with 
the real values libinput handles for "AccelSpeed" option, showing the slider 
moves between -1 and 1, see here .
  
  
  Since understanding the way values match acceleration speeds is kind of 
tricky here, I don't think making the value a percentage would be very helpful. 
Only people who read the documentation will actually know what to expect from 
the values, so I think it would be best to show values that match the 
documentation.
  
  > But if that case @ngraham will say the ticks are too many for the slider 
and we lose accuracy. There's no way to build a slider like the brightness one 
(plus a spinbox) inside power management kcm with real values and without 
ticks? A format function to round on at least two decimal will be given.
  
  In the Display Configuration KCM, the slider and spin box in the screenshot 
have different increments. The slider has increments of 25% to quickly give 
values that should work fine for most people. The spinbox has increments of 
6.25% for those that want finer control.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

[Noah Davis]

ndavis added a comment.


  I'm removing the dependency on the tools area patch because while it is 
related, this patch doesn't really depend on it and making it depend on that 
would unnecessarily complicate things.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29439

To: ndavis, #vdg
Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Reposting here so that it won't be forgotten. Some windows are lacking the 
underline:
  
  F8288512: Screenshot_20200506_002747.png 

  F8288514: Screenshot_20200506_002908.png 

  
  For some reason, the settings window for KDevelop takes roughly 4x longer to 
load with this patch. I'm not sure why that is and I don't see any suspicious 
messages that seem related to this patch in GDB.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D29081: [QStyle] Make menu titles look less like menu items

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Big +1 to the idea, but this shouldn't use `darker()` because that won't look 
right in Breeze Dark.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Noah Davis]

ndavis added a comment.


  In D29081#665226 , @cblack wrote:
  
  > In D29081#665203 , @ndavis wrote:
  >
  > > Big +1 to the idea, but this shouldn't use `darker()` because that won't 
look right in Breeze Dark.
  >
  >
  > Personally, I think this will look fine when always using `darker()`.
  
  
  It's not consistent with how breeze dark normally works though.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29570: Fix some alignments

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> PowerManagementItem.qml:34
>  Layout.fillWidth: true
> +Layout.leftMargin: units.smallSpacing
>  

How does this affect RTL layouts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma
Cc: ndavis, abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Noah Davis]

ndavis added a comment.


  I agree with the size chosen if we are doing a vertical panel, but I can't 
think of any way to justify this change in a way that I find satisfactory. 
There's no clear improvement over using a horizontal panel, just tradeoffs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ndavis, niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Noah Davis]

ndavis added a comment.


  That's a good point. Is there a way to choose a different default layout 
based on info about the user's setup? I think choosing layouts based on the 
user's hardware may be necessary to get defaults that please most people while 
still being touch friendly in contexts where that is needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: ndavis, niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

[Noah Davis]

ndavis added a comment.


  In D29749#671032 , @ngraham wrote:
  
  > 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. 
I'm not saying don't do this, but maybe it's a bit premature?
  
  
  GIMP has its own built-in themes now and it uses its own dark theme by 
default. Audacity is actually a wxWidgets app.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29749

To: gikari, cblack, #plasma, #vdg
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

[Noah Davis]

ndavis added a comment.


  wxWidgets is supposed to have GTK3 support since 2.9.4, but Audacity still 
uses GTK2 for me.
  https://docs.wxwidgets.org/3.1.3/page_port.html#page_port_wxgtk
  
  Audacity also has its own built-in themes and you can't fully use the system 
theme; you can only use it partially.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29749

To: gikari, cblack, #plasma, #vdg
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29264: New tabs for Breeze

[Noah Davis]

ndavis added a comment.


  Would you mind moving this to GitLab? You'll just need to fork the breeze 
repo, add your fork as a remote to the existing repo you're working on and push 
your branch to the fork. For instance, this is what I do for myself:
  
git remote add ndavis_fork g...@invent.kde.org:ndavis/breeze.git
git push ndavis_fork
  
  After you push, you can make a Merge Request. A link to make a merge request 
will even show up in the terminal when you push.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: ndavis, niccolove, manueljlin, filipf, ngraham, cblack, plasma-devel, 
dmenig, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D20569: Use more compact OSD

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  I have no problem with this.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D20569_2

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis
Cc: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, 
hein, Codezela, filipf, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D24706: [RFC] Change button style

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Resuming this on invent

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, 
plasma-devel, dmenig, manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender

D27874: Disable the audio stream indicator for IOTM by default

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Abandoning this since nobody wanted it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27874

To: ndavis, #vdg, #plasma
Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart