Re: Could use some help on getting the QML taskmanager running in KDE 4.8

2012-05-07 Thread Sebastian Kügler
On Monday, May 07, 2012 11:17:07 Mark wrote: That is some very interesting information I'm guessing that will have to go in PlasmaExtraComponents? or QtExtraComponents? or do we need a KDEExtraComponents ^_- Separate plugin, I suppose. It's not functionality I'd like to see in UI Components.

Re: request: create panel and plasma colors configuration tool

2012-05-15 Thread Sebastian Kügler
On Tuesday, May 15, 2012 14:39:17 gnomek wrote: graphic inside it anyway, at all? Maybe something that uses not pictures but vector graphic or another way would be a better solution. Everything uses vector graphics in Plasma's theming (that's what the .svg(z) extension is). In some cases we

[kde-workspace] plasma/generic/dataengines/geolocation: Make geolocation engine use hostip.info

2012-05-15 Thread Sebastian Kügler
Git commit d22434f1524ccdb4754c97f00368e4487730ed1c by Sebastian Kügler. Committed on 15/05/2012 at 18:17. Pushed by sebas into branch 'master'. Make geolocation engine use hostip.info HostIP is a Free, community-based service offering a REST API. This fixes the geolocation engine not working

Re: Plasma_UX_improvement_project news

2012-05-16 Thread Sebastian Kügler
Hi Erik and Jana, On Wednesday, May 16, 2012 19:54:42 J.K. Majeed wrote: Over the course of our school semester we have been assigned the task of helping the development of Plasma Active, a task that has been very intriguing and interesting for all of us. We are a student group of six members

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-22 Thread Sebastian Kügler
should improve that part of the UI. I used it for a development task yesterday, and this installatio workflow issue struck me as overly complex and have to learn it rather than understand it without thinking. - Sebastian Kügler On May 16, 2012, 6:38 p.m., Giorgos Tsiapaliwkas wrote

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-23 Thread Sebastian Kügler
On Wednesday, May 23, 2012 05:20:25 Antonis Tsiapaliokas wrote: 2)Some lines doesn't have any differences because i have remove some whitespaces and tabs... In the future, please put them in a separate patch, that makes reviewing a lot easier. 1)The icons for the tabbox are wrong. I have

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Sebastian Kügler
On May 22, 2012, 12:49 p.m., Aaron J. Seigo wrote: publisher/publisher.cpp, line 132 http://git.reviewboard.kde.org/r/104969/diff/1/?file=64637#file64637line132 looks like a stray change... (though signign could be fixed to signing ;) Giorgos Tsiapaliwkas wrote: signing

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-23 Thread Sebastian Kügler
/104969/#comment11151 remove that one ;) - Sebastian Kügler On May 23, 2012, 6:25 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-24 Thread Sebastian Kügler
On May 23, 2012, 6:36 p.m., Giorgos Tsiapaliwkas wrote: A side note here. Why publisher doesn't use a *.ui file? I guess that the *.ui are the prefered way as it regards the QWidgets. No? Do you want me to port the file into a *.ui file? Yes, that would be good. - Sebastian

Re: Survey to prepare 'Next Workspace Iteration' sprint

2012-06-04 Thread Sebastian Kügler
On Monday, June 04, 2012 22:49:35 Alex Fiestas wrote: On Monday, June 04, 2012 08:17:27 PM Aaron J. Seigo wrote: p.s. and why isn't this Tokamak 5 and instead morphed into the nebulous Next Workspace Iteration Sprint which does nothing to build on the community platform we have going here,

Re: Thoughts on the Iteration Sprint, discussions and criticism

2012-06-05 Thread Sebastian Kügler
Hey, On Tuesday, June 05, 2012 13:31:44 Dario Freddi wrote: This mail was originally born as a reply to the survey thread, but it eventually drifted into something bigger which probably deserved his own thread. First of all I'd like to speak both with a Plasma hat (which I think I always

Re: The tooltip state. Not that good. Proposal for improvement.

2012-06-05 Thread Sebastian Kügler
On Tuesday, May 29, 2012 21:37:42 Mark wrote: Seriously, thank you for the information. That little piece of vital information was missing on the wiki. I added it: http://techbase.kde.org/Development/Tutorials/Plasma/QML/API#Dialog though you probably want to make it more acurate. Stating the

Re: The tooltip state. Not that good. Proposal for improvement.

2012-06-05 Thread Sebastian Kügler
On Tuesday, June 05, 2012 14:57:42 Mark wrote: On Tue, Jun 5, 2012 at 1:28 PM, Sebastian Kügler se...@kde.org wrote: On Tuesday, May 29, 2012 21:37:42 Mark wrote: Seriously, thank you for the information. That little piece of vital information was missing on the wiki. I added it: http

Re: Drag-and-Drop for StackFolder

2012-06-05 Thread Sebastian Kügler
Hi Ural, On Tuesday, June 05, 2012 17:19:46 Ural Mullabaev wrote: I am a Rosa Linux developer. Recently we implemented Drag-and-Drop mechanism for StackFolder and would like to know chances to include StackFolder in KDE 4.9. For new features, it is unfortunately too late. We're already past

Re: Review Request: Use the same text color as C++ Plasma::LineEdit

2012-06-06 Thread Sebastian Kügler
/105159/ --- (Updated June 6, 2012, 10:55 a.m.) Review request for Plasma and Sebastian Kügler. Description --- Plasma::LineEdit uses the button text color for its text. Do the same in PlasmaComponents.TextField to avoid

Re: Review Request: Use the same text color as C++ Plasma::LineEdit

2012-06-06 Thread Sebastian Kügler
, short of hardcoding it. While I think we should use a special color that maches the view's background, this is an improvement over hardcoding, therefore ship it. - Sebastian Kügler On June 6, 2012, 10:55 a.m., Aurélien Gâteau wrote

Re: Review Request: Use the same text color as C++ Plasma::LineEdit

2012-06-06 Thread Sebastian Kügler
On June 6, 2012, 11:23 a.m., Sebastian Kügler wrote: Button background is probably the closest we have, short of hardcoding it. While I think we should use a special color that maches the view's background, this is an improvement over hardcoding, therefore ship it. BTW, the same

Re: Re: KDE architecture diagram

2012-06-08 Thread Sebastian Kügler
On Thursday, June 07, 2012 22:16:13 Aurélien Gâteau wrote: Le jeudi 7 juin 2012 21:11:09 Aaron J. Seigo a écrit : there's an artificial spliting between kde workspace and plasma active that does not exist. those of us working on these things keep saying that but nobody seems to either be

Re: Re: KDE architecture diagram

2012-06-08 Thread Sebastian Kügler
On Friday, June 08, 2012 14:37:09 Aurélien Gâteau wrote: Perhaps the KDE Workspace box should be named KDE SC Plasma Workspaces. Read this: http://community.kde.org/Promo/Branding/Map#KDE_Workspaces in short: (KDE Workspaces, in principle can include other workspaces, Plasma Workspaces

Re: Re: Re: KDE architecture diagram

2012-06-08 Thread Sebastian Kügler
On Friday, June 08, 2012 12:35:46 Martin Klapetek wrote: On Fri, Jun 8, 2012 at 12:01 PM, Sebastian Kügler se...@kde.org wrote: Food for thought: How many Linux kernel developers do you know that try to divide the Linux kernel in subprojects for servers, desktops, embedded systems? Here

Re: Travel to Sprint tomorrow

2012-06-10 Thread Sebastian Kügler
On Sunday, June 10, 2012 19:01:56 Martin Gräßlin wrote: On Sunday 10 June 2012 18:35:27 Marco Martin wrote: On Sunday 10 June 2012, Björn Balazs wrote: I will be at Barcelona Airport tomorrow about 14:30. If there is anyone with similar arrival time, ping me to meet to travel to the house

Re: Quality Team: LCD weather station and calendar (in panel) are really broken

2012-06-14 Thread Sebastian Kügler
Hey all, On Wednesday, June 13, 2012 22:31:36 Anne-Marie Mahfouf wrote: The LCD Weather Station applet is in a non working state and the Quality Team thinks it cannot be shipped as it is. The problem is that two providers which cover Europe had an API change (and some freedom

Re: moving forward

2012-06-15 Thread Sebastian Kügler
On Friday, June 15, 2012 09:11:28 Aaron J. Seigo wrote: hello... it has become apparent that we need to do something here about the attitude demonstrated by some of those who have chosen to participate in plasma. being here is not a right. it is a privelege we each earn through the simple

Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-18 Thread Sebastian Kügler
On Monday, June 18, 2012 15:37:30 Viranch Mehta wrote: The button size and the hover appearance is different from the original one. The IconButton component was made to keep the look of the buttons consistent with the original version of the applet. Do we want to change this? Yes, it should

Re: Review Request: Support for multiple batteries in battery monitor applet

2012-06-19 Thread Sebastian Kügler
On June 16, 2012, 6:40 p.m., Marco Martin wrote: i think the change is on the right path, but should wait for the unfreeze, since is not a trivial fix David Edmundson wrote: Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry

Raj change

2012-06-20 Thread Sebastian Kügler
Hey, Triggered by the comments on my blog, I'd like to change Raj's monthly available money from 300€ to 60€, which seems way more in line with reality. Unless someone objects, I'll make that change. http://vizzzion.org/blog/2012/06/plasma-personas-carla-and-raj/ Cheers, -- sebas

Re: Team meeting today

2012-06-20 Thread Sebastian Kügler
On Wednesday, June 20, 2012 14:12:48 Anne-Marie Mahfouf wrote: The call for an IRC meeting mail starts with it has become apparent that we need to do something here about the attitude demonstrated by some of those who have chosen to participate in plasma. in which I would have liked the

Re: Re: Raj change

2012-06-20 Thread Sebastian Kügler
On Wednesday, June 20, 2012 16:46:28 Kevin Ottens wrote: Hello, On Wednesday 20 June 2012 13:05:04 Sebastian Kügler wrote: Triggered by the comments on my blog, I'd like to change Raj's monthly available money from 300€ to 60€, which seems way more in line with reality. Well, we knew

Re: Plasma Containment default setting

2012-06-21 Thread Sebastian Kügler
On Thursday, June 21, 2012 15:20:57 Luca Beltrame wrote: In data giovedì 21 giugno 2012 15:15:48, Aaron J. Seigo ha scritto: it had imports for them, but no components from MobileComponents were actually being used .. so: no :) Thanks. Just one more question. Does SLC, to be properly

Re: Plasma Containment default setting

2012-06-22 Thread Sebastian Kügler
On Friday, June 22, 2012 07:34:32 Kevin Ottens wrote: sebas: is the web thumbnails branch still needing to be merged? Nope, everything is in master. (kdelibs patch had landed earlier already, the webkit thumbnailer is not needed anymore since that's now done by the original HTML thumbnailer.

Re: Re: Plasma Bug Workflow BOF

2012-06-28 Thread Sebastian Kügler
On Friday, June 22, 2012 15:11:42 Myriam Schweingruber wrote: What needs to be understood is that all code can have bugs, that is only natural and nobody will deny that. But that also means that we should thrive to make the code better, and IMHO to some extend a developer should feel

Re: Re: Raj change

2012-06-28 Thread Sebastian Kügler
On Wednesday, June 20, 2012 18:01:54 Swapnil Bhartiya wrote: I think the mistake we made was to go for 300€ with no explanation, just changing it to 60€ sounds like repeating the same mistake. When I left home and moved to Delhi to prepare for my mass communication and journalism degree

Re: Re: Re: Team meeting today

2012-06-28 Thread Sebastian Kügler
On Thursday, June 21, 2012 16:49:42 Mark wrote: I'm not sure about this but someone with in depth git knowledge can probably clarify on this. I think git has an option to at least show which people commited to which file. If you simply do that for all of git log . in a given directory helps.

Re: Hiding the cashew

2012-06-30 Thread Sebastian Kügler
Hi Ionut, On Friday, June 29, 2012 23:57:59 Ionut Colceriu wrote: I'm looking for a way to consistently hide the cashew, or at least place it behide a panel. The cashew is an integral part of the default containment. You can use or write a containment that doesn't have the cashew. Plasma's

Re: kde-workspace KDE/4.9 broken

2012-07-09 Thread Sebastian Kügler
On Monday, July 09, 2012 22:55:46 Albert Astals Cid wrote: Someone merged master to KDE/4.9, no clue if anyone is working on fixing it, but just thought you'd want to know KDE/4.9 is broken, you probably don't want to commit there untils it's fixed. Fix is being worked on. -- sebas

ownCloud Plasma client

2012-07-11 Thread Sebastian Kügler
hi all, During Akademy, we had a BoF session to improve KDE integration with ownCloud. One of the things we came up with is a new architecture for the client. The reasons for that is that we want to move things out of the system tray, we want to make the client touch-friendly (so it can also

Re: ownCloud Plasma client

2012-07-12 Thread Sebastian Kügler
Hi Aleix, On Thursday, July 12, 2012 00:34:24 Aleix Pol wrote: First of all, it's good to see people pushing owncloud (and synchronization) in general in KDE, I think it's something really needed. Kudos for that! Thanks! Now, I just wanted to say that it doesn't look like something it would

Re: [Owncloud] ownCloud Plasma client

2012-07-12 Thread Sebastian Kügler
Hi Diederik, (Re-adding plasma-devel to CC:) On Thursday, July 12, 2012 14:37:02 Diederik de Haas wrote: On Wednesday 11 July 2012 20:11:33 Sebastian Kügler wrote: Comments, critique and praise most welcome =) Sounds interesting I've 'only' seen pictures wrt to the Files app, how about

Re: QML Calendar, issues with making a selection

2012-07-17 Thread Sebastian Kügler
On Tuesday, July 17, 2012 15:46:47 Mark wrote: [...] Right now i only see one possible kind of clean way to do this. Maintain all the events in C++ (which i was already planning on doing), but also maintaining where every event should be placed in X and Y. I wasn't planning on doing that

Re: System tray: configuration dialog

2012-07-24 Thread Sebastian Kügler
On Friday, July 20, 2012 13:03:51 Dmitry wrote: What do you think about removing column allowing setting the hot-keys (shortcuts) for every tray task/application/embedded applet? The obvious question: Where would you set the shortcut then? Remember, keyboard usage is quite common among power

Re: Review Request: Support for multiple batteries in battery monitor applet

2012-08-02 Thread Sebastian Kügler
On Sunday, July 29, 2012 12:45:00 Viranch Mehta wrote: On Sun, Jun 17, 2012 at 2:45 PM, David Edmundson k...@davidedmundson.co.ukwrote: Given this patch is untested (due to Viranch having only one battery) and that we will have a lot of angry users complaining that the feature is

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/#review17368 --- Did you forget to add the patch to the preview? - Sebastian

Re: Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105940/#review17369 --- Ship it! Makes sense. Thanks! - Sebastian Kügler On Aug. 9

Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)

2012-08-14 Thread Sebastian Kügler
On Friday, July 27, 2012 17:31:08 Rolf Eike Beer wrote: Am Donnerstag 26 Juli 2012, 10:14:42 schrieb Marco Martin: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/#review16464

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Sebastian Kügler
. - Sebastian Kügler On Aug. 14, 2012, 11:06 a.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- (Updated

Re: Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-15 Thread Sebastian Kügler
On Aug. 14, 2012, 11:01 a.m., Sebastian Kügler wrote: Makes sense. Thanks! Simeon Bird wrote: Cheers! To master, or can I back-port it to 4.9.1 as well? I think committing it to the KDE/4.9 branch is fine as well. Please use the BUG and FIXED-IN keywords in your commit, so it turns

Re: move plasma tools to plasmate

2012-08-16 Thread Sebastian Kügler
Hey, First of all: if anybody objects to having these tools (plasmoidviewer, etc.) not shipped with kde-workspace anymore, speak now or forever hold your peace. :) On Monday, August 13, 2012 17:40:39 Giorgos Tsiapaliokas wrote: my GSoC tasks included to move the plasma tools(those are

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-23 Thread Sebastian Kügler
of doing the exact same =). - Sebastian Kügler On Aug. 22, 2012, 9:34 a.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-24 Thread Sebastian Kügler
On Friday, August 24, 2012 10:23:07 Antonis Tsiapaliokas wrote: On Aug. 23, 2012, 10:19 p.m., Sebastian Kügler wrote: mainwindow.cpp, line 261 http://git.reviewboard.kde.org/r/106118/diff/1/?file=79947#file79947lin e261 I don't really like this deviation in behavior, mainly

Re: move plasma tools to plasmate

2012-08-25 Thread Sebastian Kügler
On Tuesday, August 21, 2012 19:42:16 Alex Fiestas wrote: I have changed my mind on this topic with the following conclusion (hope it is useful for future actions). I think it is =) The main reason why I don't like this movement is because it adds an extra dependency for the random KDE

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-27 Thread Sebastian Kügler
mainwindow.cpp http://git.reviewboard.kde.org/r/106118/#comment14322 Put the next two lines into an else, otherwise the code can become crashy (konsole == 0) when someone else adds a new project type. - Sebastian Kügler On Aug. 27, 2012, 7:18 a.m., Antonis Tsiapaliokas wrote

Re: Review Request: LCD Weather Station QML port

2012-08-27 Thread Sebastian Kügler
http://git.reviewboard.kde.org/r/106226/#comment14327 Why not use theme here, if we don't have a fixed background anyway? - Sebastian Kügler On Aug. 26, 2012, 8:06 p.m., Luis Gabriel Lima wrote: --- This is an automatically generated

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-27 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/106118/#comment14355 Why not just } else { ? - Sebastian Kügler On Aug. 27, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: move plasma tools to plasmate

2012-08-28 Thread Sebastian Kügler
On Tuesday, August 28, 2012 10:37:10 Marco Martin wrote: i would like again a repo like that with all needed (did i already mentioned i'm definitely not a fan of micro git repos?;) that may include plsmate, plasma tools and some of the tools in kdesdk, intersection between those that make

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Sebastian Kügler
On Wednesday, September 05, 2012 22:28:03 Giuseppe Calà wrote: Actually, it is possible to change all kde settings with kwriteconfig command tool; f.i. kwriteconfig --file plasma-desktop-appletsrc --group Containments --group # --group Wallpaper --group image --key wallpaper --type string

Re: RFC: on notifications applet

2012-09-07 Thread Sebastian Kügler
On Thursday, September 06, 2012 13:05:48 Shaun Reich wrote: curious, are the inner layout shifting bugs magically fixed with this qml version? *crosses fingers toes* Most likely, yes. That seems to be genuine QGraphicsLayout borkage. -- sebas http://www.kde.org | http://vizZzion.org | GPG

[kde-workspace/plasma/mart/notifications-qml] /: fix desktop file overwrite notifications from kde-workspace

2012-09-10 Thread Sebastian Kügler
Git commit 7f4b3536fefbf854db978334f00dfe9aa2d934c6 by Sebastian Kügler. Committed on 21/06/2011 at 18:25. Pushed by mart into branch 'plasma/mart/notifications-qml'. fix desktop file overwrite notifications from kde-workspace The .desktop file installed overwrites the .desktop file

Re: Poll - Rethinking battery remaining time option

2012-09-12 Thread Sebastian Kügler
On Wednesday, September 12, 2012 14:30:08 Marco Martin wrote: I'm for keeping the config option as least possible damage, i think it has been discussed to death (including why user polls for features don't work) +1 I don't think it's useful to engage in this discussion again. -- sebas

Re: Poll - Rethinking battery remaining time option

2012-09-12 Thread Sebastian Kügler
On Wednesday, September 12, 2012 13:54:34 David Edmundson wrote: On Wed, Sep 12, 2012 at 1:41 PM, Sebastian Kügler se...@kde.org wrote: On Wednesday, September 12, 2012 14:30:08 Marco Martin wrote: I'm for keeping the config option as least possible damage, i think it has been discussed

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-14 Thread Sebastian Kügler
: - when the applet is in a panel / popup by dragging the edges - when it's on the desktop, using the applet handle Applying the config changing it to a different size is wrong in both cases. I'm not sure where the bug stems from, but this doesn't look like a good solution to me. - Sebastian Kügler

Re: Plasma Wallpapers in QML

2012-09-14 Thread Sebastian Kügler
On Thursday, September 13, 2012 18:25:58 Aleix Pol wrote: Hi, So I was tired of KPeople for today and I've decided to play a bit with wallpapers. What I did was to create a very very simple plugin (~40 sloc) that lets you easily specify a wallpaper given a QML url. Now it's hardcoded, and

Re: Status of QML Porting

2012-09-15 Thread Sebastian Kügler
On Saturday, September 15, 2012 12:16:26 Marco Martin wrote: battery This one's done and merged, released with 4.9, thanks to Viranch. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-15 Thread Sebastian Kügler
On Sept. 14, 2012, 3 p.m., Sebastian Kügler wrote: The user can change the size of the calendar in two ways: - when the applet is in a panel / popup by dragging the edges - when it's on the desktop, using the applet handle Applying the config changing it to a different size

Randa Frameworks5 preps

2012-09-17 Thread Sebastian Kügler
Hey, [This email is mostly interesting to those of us meeting in Randa later this week] Before we meet in Randa, it makes sense to have a look at your dev setup, so that we can get started quickly. We shortly talked about this on IRC today. If you'd like to spare yourself some setup time in

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-17 Thread Sebastian Kügler
/#comment15155 Do we setVisible(true) it when we change package? I don't see this in the code, but haven't tried. Something to check... - Sebastian Kügler On Sept. 17, 2012, 11:14 a.m., Giorgos Tsiapaliwkas wrote

Re: Review Request: hide the konsole on the close project

2012-09-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106478/#review19079 --- Ship it! Ship It! - Sebastian Kügler On Sept. 17, 2012, 11

Re: Review Request: Device notifier: fix free space information

2012-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106490/#review19105 --- Ship it! Ship It! - Sebastian Kügler On Sept. 18, 2012, 12

Re: Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/106495/#comment15188 Coding style: { and } even for oneliners plasma/generic/tools/wallpaperviewer/main.cpp http://git.reviewboard.kde.org/r/106495/#comment15189 whitespace - Sebastian Kügler On Sept. 18, 2012, 3:22 p.m., Aleix Pol Gonzalez wrote

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
it to KDE/4.9 and master. - Sebastian Kügler On Sept. 18, 2012, 5:40 p.m., Ralf Jung wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: Patch looks good now, thanks a lot! Please commit it to KDE/4.9 and master. Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? Is it okay to remove a no longer needed overload

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/#review19157 --- Ship it! Ship It! - Sebastian Kügler On Sept. 19, 2012, 11

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-19 Thread Sebastian Kügler
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: Patch looks good now, thanks a lot! Please commit it to KDE/4.9 and master. Sebastian Kügler wrote: Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Sebastian Kügler
On Thursday, September 20, 2012 11:40:41 Ralf Jung wrote: Hi, Ralf Jung wrote: Actually, the patch presented here does not break BC. This function I renamed is part of CalendarPrivate and therefore can not be used from the outside. The BC breakage would (possibly) be introduced by

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Sebastian Kügler
see any other way to fix this, and your patch looks clean. Please submit to KDE/4.9 and master. - Sebastian Kügler On Sept. 21, 2012, 3:57 p.m., Ralf Jung wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Fit Grid elements in Item

2012-09-24 Thread Sebastian Kügler
On Monday, September 24, 2012 11:45:22 David Edmundson wrote: Although you've told the grid to anchor on the right hand side, you've also (implicitly) told it it needs to be 4 buttons wide, and each button is hardcoded to be at least 12 characters wide. (plasmacomponents/qml/Button.qml:95). At

Re: Fit Grid elements in Item

2012-09-24 Thread Sebastian Kügler
On Monday, September 24, 2012 14:14:39 David Edmundson wrote: To clarify, by change I meant to consider adding a minimumWidth/minimumHeight property, not removing the current implicitWidth It's impossible for a user of the component to do this accurately because it needs both the label

Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-24 Thread Sebastian Kügler
On Sunday, September 23, 2012 11:02:02 Commit Hook wrote: Can this also pushed to 4.9 branch? Don't forget to push to master as well. (Or maybe I missed that one?) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___

Re: commit problem

2012-09-24 Thread Sebastian Kügler
On Tuesday, September 25, 2012 06:26:15 Reza Shah wrote: Thanks, yesterday talked with Marco at #plasma and managed to solve this. A short note that it's solved would have been nice in this case, it saves others some time. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key

Re: Fit Grid elements in Item

2012-09-25 Thread Sebastian Kügler
On Monday, September 24, 2012 22:37:03 Luiz Romário Santana Rios wrote: And another thing: while this works for the width, the analogous code for the height (height: (grid.height / grid.rows) - grid.spacing) does this: http://oi48.tinypic.com/24l7jom.jpg . Why? That looks odd. Can you post the

Re: Plasma Wallpapers in QML

2012-09-25 Thread Sebastian Kügler
On Tuesday, September 25, 2012 10:24:04 Aleix Pol wrote: On Tue, Sep 25, 2012 at 9:31 AM, Aaron J. Seigo ase...@kde.org wrote: On Tuesday, September 25, 2012 03:21:39 Aleix Pol wrote: git clone kde:scratch/apol/qmlwallpapers works very nicely; would be even nicer if mouse events were

Re: Behavior on systray icon clicking

2012-09-25 Thread Sebastian Kügler
On Tuesday, September 25, 2012 14:37:45 Kåre Särs wrote: On Tuesday 25 September 2012 12:56:40 Aaron J. Seigo wrote: On Tuesday, September 25, 2012 13:33:11 Kåre Särs wrote: I have spacial memory this is a basic part of human cognitive abilities. even toddlers who can only crawl

Re: Fit Grid elements in Item

2012-09-25 Thread Sebastian Kügler
On Tuesday, September 25, 2012 12:42:58 Luiz Romário Santana Rios wrote: And also, are there more plasmoids which are not in that listing? The list *should* be complete. If you find anything that's not in there, please add it. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID:

Re: plasma2 and ToolTipManager

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 15:35:26 Marco Martin wrote: comments? Sounds straightforward to do. Do we need WM support for the placement? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list

Re: plasma: QGraphicsView-ectomy

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 17:15:14 Aaron J. Seigo wrote: * PopupApplet: i don't think it should be a differerent class from Applet, still don't have a clear idea how to do that, but the only difference could be in desktop file i actually really like the idea that all aplets are

Re: Move kde-workspace/plasma/generic/tools into plasmate

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 14:14:16 Giorgos Tsiapaliokas wrote: Hello, In the attached patch I move the kde-workspace/plasma/generic/tools into plasmate and also I move the plasmate into plasmate/plasmate. What do you think? Go for it. -- sebas http://www.kde.org |

Re: plasma: QGraphicsView-ectomy

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 17:15:14 Aaron J. Seigo wrote: * View: not sure what to do with this (also, there is still come code commented in applet and containment that was using views) I'm open to ideas on what the semantics of this should be. i would like not having views at all in

Re: Fit Grid elements in Item

2012-09-27 Thread Sebastian Kügler
On Wednesday, September 26, 2012 20:27:08 Luiz Romário Santana Rios wrote: 2012/9/25 Luiz Romário Santana Rios luizroma...@gmail.com: Em 25/09/2012 08:44, Marco Martin notm...@gmail.com escreveu: take a look at the bettio/qml-gsoc-calculator branch, you should continue from that work

Re: Review Request: Fix repositioning the toolbox when the widgets are locked

2012-09-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106457/#review19491 --- Ship it! Looks good. - Sebastian Kügler On Sept. 16, 2012

Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

2012-09-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106622/#review19576 --- Ship it! Ship It! - Sebastian Kügler On Sept. 28, 2012, 12

Re: Display Configuration KCM design review

2012-10-02 Thread Sebastian Kügler
On Tuesday, October 02, 2012 14:29:24 Dan Vrátil wrote: As some might notice [0], we are working with Alex Fiestas on new display management for KDE. I'm now working on new KCM. Aaron suggested in comments below the blog post that it would be nice to discuss design of the KCM with you,

Re: Review Request: Correct horizontalAlignment and verticalAlignment properties of TextArea

2012-10-03 Thread Sebastian Kügler
components as well? There's a changed copy of this component with different text-selection mechanics, so your patch would be useful there as well. - Sebastian Kügler On Oct. 3, 2012, 12:22 a.m., Romário Rios wrote

Re: Review Request: Fix TextArea Plasma component documentation

2012-10-03 Thread Sebastian Kügler
as well? There's a changed copy of this component with different text-selection mechanics, so your patch would be useful there as well. - Sebastian Kügler On Oct. 3, 2012, 1:31 a.m., Romário Rios wrote: --- This is an automatically

Re: [RFC] Trigger KRunner on top screenedge

2012-10-03 Thread Sebastian Kügler
On Wednesday, October 03, 2012 13:44:06 Martin Gräßlin wrote: just wanted some feedback on an idea I got today. What about binding the showing of KRunner on hitting the top screen edge? Given that KRunner slides in from the top edge it would end up in a neat functionality, throw the cursor

Re: Button component width

2012-10-03 Thread Sebastian Kügler
On Wednesday, October 03, 2012 22:44:20 Mark wrote: You really seem to be thinking in plasma active. And in there it might actually work and benefit in every possible way. On the desktop things like this just don't work. Devs want to have freedom and certainly don't want to be limited. One

Re: Review Request: Trigger KRunner from screenedge

2012-10-04 Thread Sebastian Kügler
On Thursday, October 04, 2012 12:27:11 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106721/ Trigger KRunner from screenedge New screen edge action is added

Re: [RFC] Trigger KRunner on top screenedge

2012-10-07 Thread Sebastian Kügler
On Wednesday, October 03, 2012 17:28:24 Martin Gräßlin wrote: On Wednesday 03 October 2012 16:15:40 Sebastian Kügler wrote: On Wednesday, October 03, 2012 13:44:06 Martin Gräßlin wrote: just wanted some feedback on an idea I got today. What about binding the showing of KRunner on hitting

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Sebastian Kügler
On Wednesday, October 10, 2012 15:43:11 Lukáš Tinkl wrote: Good catch, is this code only in master or also in 4.9 branch? Should be the same in both, this fix needs to go into both branches. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Review Request: Device notifier: show mounted device and path

2012-10-12 Thread Sebastian Kügler
://git.reviewboard.kde.org//r/106755/#scomment101 This tooltip looks really odd and out of place this way.:/ - Sebastian Kügler On Oct. 12, 2012, 9:41 a.m., Jonathan Marten wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Fix padding to the left and right of text in a textField

2012-10-12 Thread Sebastian Kügler
On Thursday, October 11, 2012 15:09:07 David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106797/ --- Review

Re: Review Request: Device notifier: show mounted device and path

2012-10-12 Thread Sebastian Kügler
On Friday, October 12, 2012 13:42:35 Lamarque Vieira Souza wrote: This tooltip looks really odd and out of place this way.:/ The transparency effect does not look good here. I would like to know how to disable it too, there is this bug against the QML shutdown dialog with the same problem:

<    1   2   3   4   5   6   7   8   9   10   >